CSC/ECE 517 Fall 2021 - E2137. Fix view in student task/list page

From Expertiza_Wiki
Jump to navigation Jump to search


Team Members

Subodh Thota (sthota@ncsu.edu)


Anjali Garg (agarg25@ncsu.edu)


Lalitha Mulakaluri (lmmulaka@ncsu.edu)


Mentor : Yunkai 'Kai' Xiao (yxiao28@ncsu.edu)

Problem Statement & Solutions

Background

After logging into Expertiza, the student tasks page is rendered to the user. There are two segments in this: one segment displays the upcoming project deadlines and upcoming tasks and the other segment contains the assignments and the things in which the student is participating. The issue here is that there is some extra information that needs to be removed and aligned so that the information displayed is more clearer and concise.


Commits made by our team

Our team's works include the changes as mentioned in this section only. Any commit other than the ones mentioned here has been by other teams.


First commit

In the first commit, the ReadMe file was changed so that an initial pull request could be created as soon as possible for tracking any future changes in the codebase.


Files Involved

app/helpers/student_task_helper.rb

app/views/student_task/list.html.erb


Goal

The problems that need to be fixed are:


Problem 1

Consider the case where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment. (This allows for the column for course to be removed, making the display more compact.). The previous team has already implemented this change.


Solution 1


This has been implemented by the previous team.


Problem 2


In general, no column needs to be shown if there are no values in it. This would apply to “Badges” if no assignments in the list contain badges.


Solution 2

Added function to student_task_helper.rb:

Here we added a functionality to the helper function and removed the badges column from the table. The credentials for logging in are :

       • Student login: username -> student6420, password -> password
       • Student login: username -> student6361, password -> password



This is a helper function that we will wrap around the column


Before and After Badges column is removed

Before:

After:



Problem 3


It doesn’t make sense to have a column for Review Grade, and not for the grade for submitted work (“Submission Grade”) but the badges and courses column needs to go. Also, they did not change the name of last column (publishing rights).


Solution 3


Added the highlighted lines in app/views/student_task/list.html.erb



This had added the submission grade column in the assignments table which was not there earlier.


Adding the submission grade column

Before: Same as 4


After :

Demonstration Clips

1. Before the changes were made: https://youtu.be/XSl1MF-QtxI

2. After the changes were made: https://youtu.be/tKkONX6jQVg

Test Plan

1. There should be no empty columns.

2. If a student is enrolled in multiple courses, the assignments should be grouped course-wise.

3. There should not exist either just review grade column or just submission grade column. Both should be showed on the assignments page together.


Testing

Mini Tests

Our final tests included mini tests. We checked that the student should be assigned a submission grade after grading. If they do not have a submission grade yet, the grade should be assigned N/A.


Deployment

We have deployed this application in VCL and the IP address is : http://152.7.99.126:8080/ The credentials for the login are:

Username: instructor6

Password: password

References

https://github.com/expertiza/expertiza/pull/1903

https://github.com/expertiza/expertiza/pull/1788