CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews
Project Background
- Expertiza Project - E2086 : Let course staff as well as students do reviews
Primary Goal of this Project
This project aims to allow instructors to submit reviews of student work, using the same review form that students use to do reviews
Files Involved
list_submissions.html.erb
_calibration_report.html.erb
response.html.erb
Project Team Member
- Chenwei Zhou (czhou6)
- Tianrui Wang (twang33)
- Zhuolin Li
- Hao Zhang
Project Design Philosophy
Issue
Methods need to be fixed
Test Plan
Refactor & Code Modification
Running Tests
rspec spec/models/response_spec.rb
Rspec Test Cases
Previous Implementation
This project was done by Team E1985 on Fall 2019 with the following work:
Expertiza wiki: http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1985._Let_course_staff_and_students_do_reviews
Github Pull Request: https://github.com/expertiza/expertiza/pull/1631
Github repository: https://github.com/Matrawick/expertiza
Youtube screencast: https://youtu.be/kLfZ22vlu30
Comments From Mentor
- Code for testing whether a reviewer is a staff member is put into an unrelated class (same method already exists elsewhere in system).
- There is a long code clone because the process of creating a mapping and a review is not quite the same as when the reviewer is a non-instructor; a lot of checks needed in that case are not needed here. But the current code should have been refactored to put the common code into another method.
- One test has been removed because it broke the build, & was evid. unrelated to their functionality.
- The commit was too messy; if this had been merged, it would have required refactoring.
Reference & Links
for more information about this project, please visit Project Lists