CSC/ECE 517 Fall 2017/E1786 OSS Project Juniper: Bookmark enhancements
Peer Review Information
For users intending to view the deployed Expertiza associated with this assignment, the credentials are below: Instructor login: username -> instructor6, password -> password
Introduction
Expertiza Background
Expertiza is an open-source educational web application developed on Ruby on Rails platform. Students and Instructors use this app though their credentials. Instructors can add new projects, assignments etc as well edit the previous ones and at a later stage can see the student submission and grade them. Students can form teams for the projects, submit their work through handles (Wiki page, link to a video etc). Students can even review their teammates and other peers, as well give them any suggestions if required.
Description of the current project
This project is intended to make Bookmarks user-friendly. If the instructor allows the students to create bookmarks, the student has access to create and view them provided he gives a valid bookmark.
Files modified in current project
GradesController
This is a controller that helps students and instructors view grades and reviews, update scores, check for grading conflicts and calculate penalties. A couple of long and complex methods were refactored from this controller along with removal of some non-functional code and a few language changes to make it Ruby style. Three methods in particular, namely conflict_notification ,calculate_all_penalties and edit were found to be too long and were in need of refactoring into smaller, easier to manage methods. Few more compact methods were created for this purpose. There were no existing test cases for the controller. We have added a spec file named 'grades_spec.rb' under the spec folder. As no changes were done for the model, no tests for the model were included.
GradesHelper
This is a helper class which contains methods for constructing a table(construct_table) and to check whether an assignment has a team and metareveiw(has_team_and_metareview)
List Of Changes
We worked on the following work items :
UI Testing :
a) Back button for the page "View Bookmark" and "Create Bookmark" was resolved.
1. Login with the credentials to expertiza. 2. Go to 'My assignments' and select OSS Project/writeup. 3. Select 'Signup sheet'. 4. Many titles for projects are shown. Select a title and choose either 'View Bookmark' or 'Add Bookmark' button 5. If you choose 'View Bookmark', after viewing, press the back button to go back to Signup sheet. 6. You will land up in Sign-up sheet page. 7. If you choose 'Add Bookmark', you can add by giving Bookmark details and save it. 8. Now press back button. 9. You will land in Sign-up sheet page.
b) Creating Blank(Empty) Bookmarks problem was resolved.
1. Login into the expertiza with the credentials. 2. Go to 'My Assignments' 3. Select OSS Project/writeup 4. Now choose the "Sign-up sheet". 5. You will be displayed with titles to all available OSS projects. 6. Choose the one for which you want to create/add a bookmark. 7. Try giving empty fields and press "ENTER". 8. You should be given a warning saying "Error occurred while creating bookmark. Make sure you entered all fields". 9. You will still remain in the same page unless you press 'Back' button.
c) Issue of having the access to create the bookmarks even though instructor denied the access. / Creating and viewing the bookmarks even if the instructor has denied the access for it.
1.Login to expertiza as instructor. 2. Select 'Manage' tab and choose 'Assignments' from it. 3. Select OSS Project and to edit. 4. Click on 'Topic' button and see if the 'Allow participants to create bookmarks' is checked or not. 5. If it's checked, un-check it. 6. Now login into expertiza as student and select 'My assignments' 7. Click on OSS project/writeup. 8. Select 'Sign-up sheet' and you see all titles available for OSS projects. 9. Against each title, you can't see any buttons to either add/view bookmarks. 10. You can now repeat the process by checking in the button and see if the add and view button against the titles are accessible/not.
</nowiki>