CSC/ECE 517 Spring 1989/oss E1503 RSA: Difference between revisions
Jump to navigation
Jump to search
| Line 10: | Line 10: | ||
This class is responsible for calculating top 3 individuals which is to be displayed as the leaderboard for the class and generates a metric which aggregates peer review scores for all course assignments and then sorts individuals. | This class is responsible for calculating top 3 individuals which is to be displayed as the leaderboard for the class and generates a metric which aggregates peer review scores for all course assignments and then sorts individuals. | ||
'''What needs to be don''' | |||
Methods like <i>getParticipantsScore</i> and <i>extractPersonalAchievements</i> needs to be refactored as these single functions have multiple responsibilities. They can be modularized delegating single resposibility to one function. <i>sortHash</i> method is not an explicit leaderboard model and can be moved to helper functions. Some snippets of code are redundant and have no effect on functionality. They can be removed. | Methods like <i>getParticipantsScore</i> and <i>extractPersonalAchievements</i> needs to be refactored as these single functions have multiple responsibilities. They can be modularized delegating single resposibility to one function. <i>sortHash</i> method is not an explicit leaderboard model and can be moved to helper functions. Some snippets of code are redundant and have no effect on functionality. They can be removed. | ||
Revision as of 21:13, 22 March 2015
Project Description
Classes involved:
leaderboard.rb leaderboard_controller.rb
Modules involved:
leaderboard_helper.rb
What they do
This class is responsible for calculating top 3 individuals which is to be displayed as the leaderboard for the class and generates a metric which aggregates peer review scores for all course assignments and then sorts individuals.
What needs to be don
Methods like getParticipantsScore and extractPersonalAchievements needs to be refactored as these single functions have multiple responsibilities. They can be modularized delegating single resposibility to one function. sortHash method is not an explicit leaderboard model and can be moved to helper functions. Some snippets of code are redundant and have no effect on functionality. They can be removed.