CSC/ECE 517 Spring 2022 - E2241: Heatgrid fixes and improvements: Difference between revisions

From Expertiza_Wiki
Jump to navigation Jump to search
No edit summary
No edit summary
Line 25: Line 25:
<h2> Current Implementation </h2>
<h2> Current Implementation </h2>
<h2> Plan of work </h2>
<h2> Plan of work </h2>
<h3> Restrict teammates from reviewing their own work (Issue #2019)</h3>
<p>Relevant bug of this issue can’t be reproduced to deal with it. So comprehensive test cases must be written to be notified if the bug arises again. We are planning to add rspec unit tests covering the following cases:
</p>
<ul>
<li><b> If the instructor unchecks “ Allow self review” option</b></li>
<ol>
<li> Instructor should not be able to assign a student to review work that he/she has submitted. </li>
<li> Instructor should not be able to assign a student to review work that their teammate has submitted.</li>
<li> Students should not be able to review work he/she has submitted.</li>
<li> Students should not be able to review work a teammate has submitted.</li>
</ol>
<li><b> If the instructor checks “ Allow self review” option</b></li>
<ol>
<li> Instructor should be able to assign a student to review work that he/she has submitted.</li>
<li> Instructor should be able to assign a student to review work that their teammate has submitted.</li>
<li> Students should be able to review work he/she has submitted. </li>
<li> Students should be able to review work a teammate has submitted.</li>
</ol>
</ul>
<h2> Files to be targeted </h2>
<h2> Files to be targeted </h2>
<h3>Issue #1869</h3>
<h3>Issue #1869</h3>

Revision as of 02:09, 7 April 2022

This page provides information about the refactoring work done on the reputation web service controller as part of the OSS project.

Team

Mentor

  • Nicholas Himes (nnhimes)

Team Members (PinkPatterns)

  • Eshwar Chandra Vidhyasagar Thedla (ethedla)
  • Gokul Krishna Koganti (gkogant)
  • Jyothi Sumer Goud Maduru (jmaduru)
  • Suneha Bose (sbose2)

Heat Grid

Heat Grid refers to a part of view in expertiza that shows review scores of all the reviews done for a particular assignment. It shows scores given for each rubric by peer reviewers. This is used by instructors to assign scores to individual assignments and by students to view review scores of their assignment. Our project scope involves dealing with fixing issues related to the heat grid and any subsequent bugs that might arrive.

Issues identified

Restrict teammates from reviewing their own work (Issue #2019)

There are some instances where a student was shown as reviewing his/her team. This is impossible and is classified as a bug. This must be dealt with. Test cases must be extensively added so that we can be notified if the bug occurs again.

Deal with the metrics of the heat grid (Issue #1869)

metric-1 column name in the heat grid follows bad naming convention. It doesn't explain what the column refers to. This must be changed to make the column name more apt.

As of now, the heat grid uses only one metric (metric-1). We must facilitate the system for addition of new metrics. Instructors should be able to toggle between various metrics as per their preferences. This can be done by the use of a drop down menu.

Current Implementation

Plan of work

Restrict teammates from reviewing their own work (Issue #2019)

Relevant bug of this issue can’t be reproduced to deal with it. So comprehensive test cases must be written to be notified if the bug arises again. We are planning to add rspec unit tests covering the following cases:

  • If the instructor unchecks “ Allow self review” option
    1. Instructor should not be able to assign a student to review work that he/she has submitted.
    2. Instructor should not be able to assign a student to review work that their teammate has submitted.
    3. Students should not be able to review work he/she has submitted.
    4. Students should not be able to review work a teammate has submitted.
  • If the instructor checks “ Allow self review” option
    1. Instructor should be able to assign a student to review work that he/she has submitted.
    2. Instructor should be able to assign a student to review work that their teammate has submitted.
    3. Students should be able to review work he/she has submitted.
    4. Students should be able to review work a teammate has submitted.

Files to be targeted

Issue #1869

For Heat grid

  • app/views/grades/_view_heatgrid.html.erb
  • app/views/grades/view_team.html.erb
  • app/helpers/grades_helper.rb
  • app/controllers/grades_controller.rb
  • app/models/vm_question_response.rb
  • app/models/vm_question_row.rb

For Assignment

  • app/views/assignment/edit/_general.html.erb
  • app/controllers/assignments_controller.rb

Test Plan

  • Capybara Test cases for testing the UI of heat grid view with the expected metric for the respective assignment and the UI of team view with relevant metric selected with all other metrics in the dropdown
  • Spec test cases for testing the grades controller and assignment controller to check if they are returning the values as expected
  • Unit test cases will be added to verify the logic behind the methods to calculate the values for their metrics

Important Links

Retrieved from "https://wiki.expertiza.ncsu.edu/index.php?title=CSC/ECE_517_Spring_2022_-_E2241:_Heatgrid_fixes_and_improvements&oldid=144534"