CSC/ECE 517 Spring 2022 - E2239: Further refactoring and improvement of review mapping helper.rb: Difference between revisions
Jump to navigation
Jump to search
| Line 1: | Line 1: | ||
== Background == | == Background == | ||
This project builds on the work done by E2125, which focused on simplifying the methods in <code>review_mapping_helper</code>. This project focuses on refactoring that seeks to make the current code more understandable and transparent. | |||
== Problems and planned changes == | == Problems and planned changes == | ||
Revision as of 22:56, 30 March 2022
Background
This project builds on the work done by E2125, which focused on simplifying the methods in review_mapping_helper. This project focuses on refactoring that seeks to make the current code more understandable and transparent.
Problems and planned changes
Problem: The method get_data_for_review_report violates the Expert pattern
get_data_for_review_report passes back a data structure with multiple response objects to the _review_report.html.erb view. This violates the Expert pattern, because the given view does not know how to break apart the structure passed to it.
- Proposed Solution :
get_data_for_review_reportwill be refactored to use partials, which