CSC/ECE 517 Spring 2022 - E2217: Refactor questionnaires controller: Difference between revisions
Jump to navigation
Jump to search
| Line 5: | Line 5: | ||
=== Problems and Solutions === | === Problems and Solutions === | ||
* '''Problem''': The ''create_questionnaire'' method is not used | * '''Problem''': The ''create_questionnaire'' method is not used.''create_questionnaire'' has no immediate apparent calls, and appears to have the same functionality as ''create''. | ||
**'''Solution''': | |||
*'''Solution''': | |||
* '''Problem''': The ''create'' method is 49 lines long, and needs to be broken up | * '''Problem''': The ''create'' method is 49 lines long, and needs to be broken up | ||
Revision as of 18:50, 17 March 2022
This page describes the changes made for the Spring 2022 OSS Project E2217: Refactoring Questionnaires Controller
Description
This project focused on sanding down the rough edges of questionnaires_controller.rb through the removal of the unused create_questionnaire method, breaking up the exceedingly long create method, transfer of hardcoded values in the add_new_questions method, and general code cleanup.
Problems and Solutions
- Problem: The create_questionnaire method is not used.create_questionnaire has no immediate apparent calls, and appears to have the same functionality as create.
- Solution:
- Problem: The create method is 49 lines long, and needs to be broken up
- Solution:
Modified Files
(Add modified files and list of changes here)
Testing
Running Tests
rspec ./spec/controllers/questionnaires_controller_spec.rb
Pull Request
(Add pull request link here)