CSC/ECE 517 Fall 2020 - E2070. Refactor response controller.rb: Difference between revisions
Jump to navigation
Jump to search
(Created page with "E2070. Refactor response_controller.rb Background: A response is the object that is created when someone fills out a review rubric, such as when one writes a review, gives f...") |
No edit summary |
||
| Line 1: | Line 1: | ||
== Project Introduction == | |||
Background: A response is the object that is created when someone fills out a review rubric, such as when one writes a review, gives feedback to a reviewer, or fills out a survey. Responses to the individual rubric items are kept in Answer objects; each Answer object has a response_id to say what Response it is part of. Since response_controller needs to work with many kinds of responses, its code is pretty general. It is not the worst controller in the system, but it would be much clearer if its method names were more descriptive of what they do. | Background: A response is the object that is created when someone fills out a review rubric, such as when one writes a review, gives feedback to a reviewer, or fills out a survey. Responses to the individual rubric items are kept in Answer objects; each Answer object has a response_id to say what Response it is part of. Since response_controller needs to work with many kinds of responses, its code is pretty general. It is not the worst controller in the system, but it would be much clearer if its method names were more descriptive of what they do. | ||
Project Member | === Project Team Member=== | ||
Chenwei Zhou (czhou6) | |||
Tianrui Wang (twang33) | |||
Xinran Li | |||
=== Goal of this Project=== | |||
This project tries to modify and refactor the response_controller.rb in a more clear way | |||
=== Files Involved === | |||
response_controller.rb | |||
response.rb | |||
== Issue == | |||
=== Methods need to be fixed === | |||
* def assign_instance_vars | |||
* def scores | |||
* def new | |||
* def set_questionnaire | |||
* def set_questionnaire_for_new_response | |||
* def show_calibration_results_for_students | |||
=== Recommandation from mentor === | |||
== Refactor & Code Modification == | |||
Revision as of 22:08, 12 October 2020
Project Introduction
Background: A response is the object that is created when someone fills out a review rubric, such as when one writes a review, gives feedback to a reviewer, or fills out a survey. Responses to the individual rubric items are kept in Answer objects; each Answer object has a response_id to say what Response it is part of. Since response_controller needs to work with many kinds of responses, its code is pretty general. It is not the worst controller in the system, but it would be much clearer if its method names were more descriptive of what they do.
Project Team Member
Chenwei Zhou (czhou6) Tianrui Wang (twang33) Xinran Li
Goal of this Project
This project tries to modify and refactor the response_controller.rb in a more clear way
Files Involved
response_controller.rb
response.rb
Issue
Methods need to be fixed
- def assign_instance_vars
- def scores
- def new
- def set_questionnaire
- def set_questionnaire_for_new_response
- def show_calibration_results_for_students