CSC/ECE 517 Fall 2015/oss E1565 AAJ: Difference between revisions
Jump to navigation
Jump to search
| Line 66: | Line 66: | ||
|- | |- | ||
| list_administrators.html.erb | | list_administrators.html.erb | ||
| Changed line 7 to | | Changed line 7 to <%= link_to user.name, :action => 'show_admin',:id => user.id %> | ||
| There is no show method in Admin Controller | | There is no show method in Admin Controller | ||
|- | |- | ||
| Line 74: | Line 74: | ||
|- | |- | ||
| list_super_administrators.html.erb | | list_super_administrators.html.erb | ||
| Changed line 7 to | | Changed line 7 to <%= link_to user.name, :action => 'show_super_admin',:id => user.id %> | ||
| There is no show method in Admin Controller. | | There is no show method in Admin Controller. | ||
|- | |- | ||
| Line 82: | Line 82: | ||
|- | |- | ||
| list_super_administrators.html.erb | | list_super_administrators.html.erb | ||
| Removed | | Removed <%= link_to 'New Super administrator', :action => 'new' %> | ||
| There can be only one super admin. | | There can be only one super admin. | ||
|} | |} | ||
| Line 94: | Line 94: | ||
|- style="vertical-align:top;" | |- style="vertical-align:top;" | ||
| create | | create | ||
| Changed line | | Changed line @institution = Institution.new(params[:institution]) to @institution = Institution.new(:name => params[:institution][:name]) | ||
| Was throwing error | | Was throwing error | ||
|} | |} | ||
| Line 105: | Line 105: | ||
|- style="vertical-align:top;" | |- style="vertical-align:top;" | ||
| create | | create | ||
| Added the line | | Added the line @user.institutions_id=params[:users][:institutions_id] | ||
| To include institution for newly created users | | To include institution for newly created users | ||
|- | |- | ||
Revision as of 01:28, 1 November 2015
E1565: Refactoring Admin Controller and Course Controller
This page provides a description of the Expertiza based OSS project aimed at refactoring Admin Controller and Course Controller.
In order to run our code visit the link 152.46.16.123:3000 and use the following credentials - username: admin, password: admin.
Introduction to Expertiza
Expertiza is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities.
Problem Statement
Files involved
admin_controller.rb views in app/views/admin folder user_controller
What they do:
The admin controller defines the changes that can be done on other types of users by super-admin and provides the view accordingly.
What needs to be done:
- The text field for adding a new admin/instructor has to be removed, leaving only the button.
- When the button is clicked, it should be redirected to new user creation view making the role (super-admin, admin or instructor) selected as default.
- Make sure that user creation works for super-admin/admin/instructor.
- Associate the users with the institution table
- Add a drop down to the view of creating users so that new account creator can select the institute and save it.
Changes Made
Admin Controller
| Method Name | Changes Made | Reason For Change |
|---|---|---|
| show_super_admin | Added this method to controller | This method helps in displaying the specified super_admin |
| show_admin | Added this method to Admin Controller | This method helps in displaying the specified admin |
| remove_instructor | Added this method to Admin Controller | This method helps in destroying an instructor. |
| remove_administrator | Added this method to Admin Controller | This method helps in destroying an administrator. |
| remove_super_administrator | Added this method to Admin Controller. | This method helps in destroying a super_admin. |
Views/admin
| Method Name | Changes Made | Reason For Change |
|---|---|---|
| list_administrators.html.erb | Removed the text field next to New Administrator button | The button redirects to a new user page and passes a hidden field with role:administrator |
| list_administrators.html.erb | Changed line 7 to <%= link_to user.name, :action => 'show_admin',:id => user.id %> | There is no show method in Admin Controller |
| list_instructors.html.erb | Removed the text field next to New Instructor button | The button redirects to a new user page and passes a hidden field with role:Instructor |
| list_super_administrators.html.erb | Changed line 7 to <%= link_to user.name, :action => 'show_super_admin',:id => user.id %> | There is no show method in Admin Controller. |
| list_super_administrators.html.erb | Removed the Parent column from line 4 | Super admins don't have any parents. |
| list_super_administrators.html.erb | Removed <%= link_to 'New Super administrator', :action => 'new' %> | There can be only one super admin. |
Institution Controller
| Method Name | Changes Made | Reason For Change |
|---|---|---|
| create | Changed line @institution = Institution.new(params[:institution]) to @institution = Institution.new(:name => params[:institution][:name]) | Was throwing error |
User Controller
| Method Name | Changes Made | Reason For Change |
|---|---|---|
| create | Added the line @user.institutions_id=params[:users][:institutions_id] | To include institution for newly created users |
| user_params | Added the parameter institutions ID. | To include institution for newly created users. |