CSC/ECE 517 Fall 2014/OSS E1466 gjf: Difference between revisions
Jump to navigation
Jump to search
| Line 10: | Line 10: | ||
<br> | <br> | ||
'''Classes involved:''' grades_controller.rb | '''Classes involved:''' grades_controller.rb | ||
'''What it does:''' | |||
This class lists the grades of all the participants for an assignments and also their reviews. Instructor can edit scores, calculate penalties and send emails for conflicts. | |||
'''What needs to be done:''' | '''What needs to be done:''' | ||
*Modify '''calculate_all_penalties''' method which is too complex and long. | *Modify '''calculate_all_penalties''' method which is too complex and long. | ||
*Put the '''get_body_text''' method in a mailer rather than in the grades_controller. | *Put the '''get_body_text''' method in a mailer rather than in the grades_controller. | ||
| Line 16: | Line 22: | ||
*Refactor '''view_my_scores''' method to '''grades_show''' and delete the unnecessary variables. | *Refactor '''view_my_scores''' method to '''grades_show''' and delete the unnecessary variables. | ||
*Try not to query for reviews and meta reviews in '''grades_show''' method. | *Try not to query for reviews and meta reviews in '''grades_show''' method. | ||
===Screenshots=== | ===Screenshots=== | ||
Revision as of 19:16, 25 October 2014
E1466: Refactoring GradesController
This wiki deals with our implementation of a controller in expertiza: grade_controller for the Expertiza Project using Ruby on Rails.
Introduction
Expertiza is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities.
Project Description
Classes involved: grades_controller.rb
What it does:
This class lists the grades of all the participants for an assignments and also their reviews. Instructor can edit scores, calculate penalties and send emails for conflicts.
What needs to be done:
- Modify calculate_all_penalties method which is too complex and long.
- Put the get_body_text method in a mailer rather than in the grades_controller.
- Refactor conflict_nofication method to conflict_email and make it delegated to the mailer.
- Refactor view_my_scores method to grades_show and delete the unnecessary variables.
- Try not to query for reviews and meta reviews in grades_show method.