CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements: Difference between revisions
No edit summary |
No edit summary |
||
Line 3: | Line 3: | ||
===What is wrong with it=== | ===What is wrong with it=== | ||
It is called from Instructor's "Assign Grades" function and student's view scores functions. But , there | It is called from Instructor's "Assign Grades" function and student's view scores functions. But, there is an issue where the students can review their own assignments. Also, the column name "metric-1" is not self explanatory and needs to be changed. | ||
=Issue 1= | =Issue 1= | ||
== Problem Definition == | == Problem Definition == | ||
===Issue #2019=== | ===Issue #2019=== | ||
This questions whether the reviewers are correctly identified. In one case, a student was shown as reviewing his/her team, which should not be possible. Also write tests so that if this bug occurs again, we will be informed. | |||
== Current Implementation == | == Current Implementation == |
Revision as of 03:34, 4 November 2021
Project Background
Heatgrid is the page where instructor can visit and view the work done by participant using Reviews, Author Feedbacks and Meta Reviews. This one web page displays all the evaluations done by peers of the participant for his project. The page is displayed in the format of table with colors. The columns in the table can be sorted with the requirement of the project. Heatgrid shows scores assigned by reviewers on individual rubric items for participant.
What is wrong with it
It is called from Instructor's "Assign Grades" function and student's view scores functions. But, there is an issue where the students can review their own assignments. Also, the column name "metric-1" is not self explanatory and needs to be changed.
Issue 1
Problem Definition
Issue #2019
This questions whether the reviewers are correctly identified. In one case, a student was shown as reviewing his/her team, which should not be possible. Also write tests so that if this bug occurs again, we will be informed.
Current Implementation
Overview
In the current review system implementation, the instructor has the ability to select or deselect the "Allow Self Reviews?" checkbox from the "Review Strategy" tab of the Edit Assignment page. On deselecting this checkbox, a student will not be able to review his/her own work.
UI Screenshots
The following images show how this functionality works currently:
The instructor will get the error "You cannot assign this student to review his/her own artifact." when an attempt to add a student as a reviewer to his/her own assignment is made.
Control Flow
Observations
Whenever an instructor assigns a reviewer for an assignment of a team, there is already a check present and it is not allowing instructor to assign the team member of the team for the review.
Test Plan
Files to be Targeted
Issue 2
Problem Definition
Issue#1869
Notes that there is a “metric-1” column in the review report, but it doesn’t say what the metric is. Please figure out what the metric is, and change the column header accordingly. However, the intent was that eventually an instructor would be allowed to select a metric to be shown on the heatgrid. So, somewhere in the UI for creating/editing an assignment, there should be a way for the instructor to select a metric from a dropdown list. You don’t have to add any more metrics to this list other than the one that is currently displayed, just create a mechanism for adding metrics in the future.
Current Implementation
Overview
In the current implementation, the columns in the heatgrid table are static. The "metric-1" column in the table represents the count of comments for the respective question which have a word count greater than 10. On hovering over the column name, the correct information is displayed but the name itself does not make the information apparent at first glance.
UI Screenshots
The following image captures how the heatgrid is currently being displayed:
Refactoring
The header for the metric-1 column should be changed and it should display an appropriate name for the metric.
Files to be Targeted
Test Plan
Important Links
- GitHub repository link: https://github.com/ShlokSayani/expertiza
- Project Description Document: https://docs.google.com/document/d/1slx4HPIbgTH-psIKMSCF-HDF9brxf-FuYhzVT9ZiIrM/edit#heading=h.tqdrrd12xs4x
- GitHub Issue #1869: https://github.com/expertiza/expertiza/issues/1869
- GitHub Issue #2019: https://github.com/expertiza/expertiza/issues/2019
Team
- Shlok Sayani (sdsayani)
- Hardik Udeshi (hvudeshi)
- Isha Gupta (igupta)
- Manish Shinde (msshinde)