CSC/ECE 517 Fall 2021 - E2121. Refactor suggestion controller.rb: Difference between revisions
Jump to navigation
Jump to search
Line 1: | Line 1: | ||
== | ==Introduction== | ||
This page provides a description of the Expertiza based OSS project. | This page provides a description of the Expertiza based OSS project. | ||
Line 9: | Line 9: | ||
===About Expertiza=== | ===About Expertiza=== | ||
[http://expertiza.ncsu.edu/ Expertiza] is an open source project based on [http://rubyonrails.org/ Ruby on Rails] framework. | [http://expertiza.ncsu.edu/ Expertiza] is an open-source educational project based on [http://rubyonrails.org/ Ruby on Rails] framework. | ||
===Related Functions=== | |||
=== | * Files Involved: suggestion_controller.rb, assignment_team.rb, sign_up_topic.rb, suggestion_controller_spec.rb (create) | ||
* The following functions are related to E2121: | |||
** Students could submit suggestions of topic | |||
** Instructors could approve or reject suggested topics of students | |||
** Instructors and students could create teams | |||
===Tasks Statement=== | |||
The following tasks were accomplished in this project: | The following tasks were accomplished in this project: | ||
Line 23: | Line 30: | ||
** Test when topic_id.nil? to make sure the waitlist is cleared. | ** Test when topic_id.nil? to make sure the waitlist is cleared. | ||
** Test the submit, student_view, student_edit, update_suggestion, add_comment function | ** Test the submit, student_view, student_edit, update_suggestion, add_comment function | ||
===Procedure to Test Our project Manually | |||
* Click the link [http://152.7.176.62:8081/ E2121]. | |||
* 使用流程 | |||
==Refactor Suggestion Controller.rb== | |||
==Test by RSpec== |
Revision as of 01:03, 20 October 2021
Introduction
This page provides a description of the Expertiza based OSS project.
About Expertiza
Expertiza is an open-source educational project based on Ruby on Rails framework.
Related Functions
- Files Involved: suggestion_controller.rb, assignment_team.rb, sign_up_topic.rb, suggestion_controller_spec.rb (create)
- The following functions are related to E2121:
- Students could submit suggestions of topic
- Instructors could approve or reject suggested topics of students
- Instructors and students could create teams
Tasks Statement
The following tasks were accomplished in this project:
- Line 76 and 77: use more Ruby-like String concepts
- Line 94: Refactor create_new_team to assignment_team.rb
- Line 125: Refactor notification to simplify control logic.
- Line 160: Refactor approve_suggestion to indicate that notification is being sent.
- Test functions and increase coverage:
- Check error in approve
- Test reject_suggestion
- Test when topic_id.nil? to make sure the waitlist is cleared.
- Test the submit, student_view, student_edit, update_suggestion, add_comment function
===Procedure to Test Our project Manually
- Click the link E2121.
- 使用流程