E1844 Issues related to names: Difference between revisions
(Created page with "==Introduction== ==='''Problem Statement'''=== ---- =='''Issues to be fixed'''== Issues as described by the problem statement: Issue #842: Team names created by bidding are in...") |
No edit summary |
||
| Line 12: | Line 12: | ||
Issue #982: Usernames can have spaces in them. And currently, if you create a user with a space in the username, you can't impersonate that user. Expertiza should prohibit spaces in usernames. Implementation should probably just include a format check in the user model, and tests to validate a username. | Issue #982: Usernames can have spaces in them. And currently, if you create a user with a space in the username, you can't impersonate that user. Expertiza should prohibit spaces in usernames. Implementation should probably just include a format check in the user model, and tests to validate a username. | ||
---- | |||
=='''Modified Files for fixing issue #842'''== | |||
1) app/controllers/lottery_controller.rb | |||
2) app/controllers/suggestion_controller.rb | |||
3) app/models/team.rb | |||
4) spec/models/team_spec.rb | |||
=='''Modified Files for fixing issue #982'''== | |||
1) app/models/user.rb | |||
2) spec/models/user_spec.rb | |||
---- | ---- | ||
Revision as of 21:39, 2 November 2018
Introduction
Problem Statement
Issues to be fixed
Issues as described by the problem statement:
Issue #842: Team names created by bidding are incorrect Somewhere in the bidding code, or the code that assigns topics based on bids, team names are generated. In this case, team names are not appended to the name of the assignment, like they are when teams are created elsew
Issue #982: Usernames can have spaces in them. And currently, if you create a user with a space in the username, you can't impersonate that user. Expertiza should prohibit spaces in usernames. Implementation should probably just include a format check in the user model, and tests to validate a username.
Modified Files for fixing issue #842
1) app/controllers/lottery_controller.rb
2) app/controllers/suggestion_controller.rb
3) app/models/team.rb
4) spec/models/team_spec.rb
Modified Files for fixing issue #982
1) app/models/user.rb
2) spec/models/user_spec.rb