E1827 Topic management: Difference between revisions
No edit summary |
|||
Line 21: | Line 21: | ||
* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. | * Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. | ||
== Files modified == | |||
---- | ---- | ||
The following files were modified | The following files were modified | ||
* app/views/sign_up_sheet/_add_signup_topics.html.erb | * app/views/sign_up_sheet/_add_signup_topics.html.erb | ||
Line 32: | Line 33: | ||
== Files Added == | == Files Added == | ||
---- | |||
The following files were added | The following files were added | ||
* | * |
Revision as of 18:40, 2 November 2018
This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.
Peer Review Information
The following credentials are recommended for testing the changes:
- Instructor Login: username: instructor6 password: password
- Youtube link:
Introduction
Background
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.
Problem Statement
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.
What needs to be done?:
- Issue #971 Change create topic UI into AJAX.
- Issue #926 We need a way to sort topics by topic number in assignment#edit page.
- Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.
Files modified
The following files were modified
- app/views/sign_up_sheet/_add_signup_topics.html.erb
- app/views/sign_up_sheet/_table_header.html.erb
- app/views/sign_up_sheet/_table_line.html.erb
- app/views/sign_up_sheet/_add_signup_topics.html.erb
- app/views/sign_up_sheet/_table_header.html.erb
Files Added
The following files were added
Solutions Implemented
Issue #971 Change create topic UI into AJAX
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered. To enable AJAX the sign_up_sheet_controller.rb must be modified so that it renders JSON to handle the table/form.
In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).
Issue #926 We need a way to sort topics by topic number in assignment#edit page.
Use the TableSorter css that is already used by several tables in Expertiza (see its documentation here) to enable sorting of the topics by the table headers in views>sign_up_sheet>_add_signup_topics.html.erb.
We should allow instructors to give feedback when accepting or rejecting topic suggestions.
As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.
A possible solution would be to add a column in the views>suggestion>list.html.erb with a textbox in the table and “send” button and handle sending the comments when the send button is pressed in suggestion_controller.rb. Add an extra column called “feedback” in the suggestion table to store instructor’s comments to the suggested topics.