CSC/ECE 517 Spring 2017 E1711: Difference between revisions
Jump to navigation
Jump to search
No edit summary |
No edit summary |
||
Line 1: | Line 1: | ||
<font size="5"><b> E1711. Refactor delayed_mailer.rb and scheduled_task.rb</b></font> | <font size="5"><b> E1711. Refactor delayed_mailer.rb and scheduled_task.rb</b></font> | ||
__TOC__ | |||
=Overview= | =Overview= | ||
Line 7: | Line 9: | ||
[http://expertiza.ncsu.edu/ Expertiza] is a web based tool that allows instructors to create collaborative assignments where students can provide peer feedback on each others work. It provides instructors a system to manage assignments and different courses. | [http://expertiza.ncsu.edu/ Expertiza] is a web based tool that allows instructors to create collaborative assignments where students can provide peer feedback on each others work. It provides instructors a system to manage assignments and different courses. | ||
== | ==Scope of project E1711== | ||
The goal of E1711 was to refactor code found in the files delayed_mailer.rb and scheduled_task.rb. | The goal of E1711 was to refactor code found in the files <i>delayed_mailer.rb</i> and <i>scheduled_task.rb</i>. | ||
The following issues were identified as the scope of this project | |||
* <i>scheduled_task.rb</i> duplicated most of its code from <i>delayed_mailer.rb</i>. Our objective is to reduce/remove the duplication in keeping with the DRY principle. | |||
* The <code>perform</code> method uses a giant case statement, instead we were to incorporate the use of polymorphism | |||
* The <code>mail_signed_up_users</code> is long and should be broken into smaller and better named methods | |||
* Add/modify test cases as we added/removed/modified areas of the code |
Revision as of 23:43, 22 March 2017
E1711. Refactor delayed_mailer.rb and scheduled_task.rb
Overview
Introduction to Expertiza
Expertiza is a web based tool that allows instructors to create collaborative assignments where students can provide peer feedback on each others work. It provides instructors a system to manage assignments and different courses.
Scope of project E1711
The goal of E1711 was to refactor code found in the files delayed_mailer.rb and scheduled_task.rb.
The following issues were identified as the scope of this project
- scheduled_task.rb duplicated most of its code from delayed_mailer.rb. Our objective is to reduce/remove the duplication in keeping with the DRY principle.
- The
perform
method uses a giant case statement, instead we were to incorporate the use of polymorphism - The
mail_signed_up_users
is long and should be broken into smaller and better named methods - Add/modify test cases as we added/removed/modified areas of the code