CSC/ECE 517 Spring 2023 E2310: Difference between revisions

From Expertiza_Wiki
Jump to navigation Jump to search
No edit summary
No edit summary
 
(13 intermediate revisions by the same user not shown)
Line 6: Line 6:
=== Mentor ===
=== Mentor ===


* Vinay Deshmukh
* Jialin Cui


=== Team Members ===
=== Team Members ===
Line 15: Line 15:


== Description and Testing ==
== Description and Testing ==
Our project deals with writing test cases for the summary_helper.rb file. The summary helper is responsible for doing the following tasks:
Our project deals with refactoring the answer.rb file. The code is responsible for doing the following tasks:
* Get all answers for each question and send them to summarization WS.
* To design and implement an answsers_by_response method that returns answers in each response.
* Get average scores and a summary for each question in a review by a reviewer.
* Get the answer model fully tested.


=== Files Involved ===
=== Files Involved ===


* summary_helper.rb
* answer.rb
* summary_helper_spec.rb
* answer_spec.rb


=== Running Tests ===
=== Running Tests ===
To successfully run summary_helper_test in local machine, please run the below rspec command.  
To successfully run answer_spec on the local machine, please run the below rspec command.  
<pre>
<pre>
   rspec spec/helpers/summary_helper_spec.rb
   rspec spec/answer_spec.rb
</pre>
</pre>


=== Requirement ===


summary_helper class had methods which were not tested. Our job was to test all the methods so that we can verify summary_helper class is working fine.
== Project Description ==


The objective of the project is to refactor the following Ruby on Rails model classes in the existing project:- Answer Model on Expertiza.The model is designed to represent answers to questions in Expertiza.  So, whenever anyone fills out a rubric, each “question” that is answered creates a new Answer object.


=== Test Plan ===
The task is to refactor the existing code present in the model file and implement them in a new repository. Since the project is implemented from scratch, there are various aspects of the project that have to be implemented and therefore unit test cases are implemented to test the implementation.


After going through all the methods in the class, we figured out there were some methods that were never being called. So, we removed all the redundant methods that are not being called. Now we had only 9 methods in the class that we need to test. Nine methods in summary_helper class that needed to be tested were:


* summarize_reviews_by_reviewee
* answers_by_question_for_reviewee_in_round:
* summarize_reviews_by_reviewee_question
  1. This method joins the responses, answers, response_maps, and questions table.
* get_max_score_for_question
  2. Then it applies a where clause to filter the results based on the given assignment_id, reviewee_id, q_id, and round parameters.
* summarize_sentences
  3. It retrieves answers and comments columns from the combined table.
* get_sentences
* break_up_comments_to_sentences
* calculate_avg_score_by_criterion
* calculate_round_score
* calculate_avg_score_by_round


For the testing, we have mock following items : 
<pre>
  let(:answer) { Answer.new(answer: 1, comments: 'This is a sentence. This is another sentence.', question_id: 1) }
  let(:answer1){ Answer.new(answer: 2, comments: 'This is a sentence1. This is another sentence1.', question_id: 2)}
  let(:question) {build(:question, weight:1, type:"Criterion")}
  let(:avg_scores_by_criterion) { {a:2.345} }
</pre>
* get_sentences
  To test this method we mocked an answer object and checked if the number of sentences is equal to the number of comments provided in the answer.
  We identified two test cases for this method:
  1. When the answer is nil
  2. When the comment is two sentences
   
   
Code Snippet:
Code Snippet:
<pre>
describe '#get_sentences' do
    context 'when the answer is nil' do
      it 'returns a nil object' do
        expect(@summary.get_sentences(nil)).to eq(nil)
      end
    end
    context 'when the comment is two sentences' do
      it 'returns an array of two sentences' do
        sentences = @summary.get_sentences(answer)
        expect(sentences.length).to be(2)
      end
    end
  end
</pre>


    scope :by_question_for_reviewee_in_round, -> (assignment_id, reviewee_id, q_id, round) do
      joins(response: {map: :reviewer})
      .joins(:question)
      .where("review_maps.reviewed_object_id = ? AND
              review_maps.reviewee_id = ? AND
              answers.question_id = ? AND
              responses.round = ?", assignment_id, reviewee_id, q_id, round)
      .select(:answer, :comments)
  end


* get_max_score_for_question
  To test this method we mocked two different types of questions which are as follows:
  1. let(:questionOne){Question.new(type:'Checkbox')}
  2. let(:questionTwo) { build(:question, questionnaire: questionnaire1, weight: 1, id: 1) }
  Now based on the different question types we tested two scenarios for this method:
  1. When the question type is Checkbox
  2. When question type is not Checkbox
Code Snippet:
<pre>
describe 'get_max_score_for_question' do
    context 'When question type is Checkbox' do
      let(:questionOne){Question.new(type:'Checkbox')}
      it 'returns 1' do
        max_score = @summary.get_max_score_for_question(questionOne)
        expect(max_score).to be(1)
      end
    end
    context 'When question type is not Checkbox' do
      let(:questionnaire1) { build(:questionnaire, id: 2) }
      let(:questionTwo) { build(:question, questionnaire: questionnaire1, weight: 1, id: 1) }
      it 'return the max score for the provided question' do
        allow(Questionnaire).to receive(:where).with(id:2).and_return(questionnaire1)
        allow(questionnaire1).to receive(:first).and_return(questionnaire1)
        expect(@summary.get_max_score_for_question(questionTwo)).to eql(5)
      end
    end
  end
</pre>




* summarize_sentence
* answers_by_question:
  To test this method we mocked a comments array with the following values ["Hello this is first comment", "This is second comment"]. This method is making a web service call at the following Web Service:
  1. This method joins the questions, answers, responses, and response_maps table.  
  'http://peerlogic.csc.ncsu.edu/sum/v1.0/summary/8/lsa'
  2. Then it applies a where clause to filter the results based on the given q_id and assignment_id.  
  We are using expect to compare the expected result with the actual result from the web service call.
  3. It retrieves the distinct answers and comments columns from the combined table.  
  Disclaimer: This web service call results in a bad gateway error while running the test case. We have already informed our mentor and the professor regarding the same.
   
   
Code Snippet:
Code Snippet:
<pre>
 
describe '#summarize_sentence' do
     scope :by_question, -> (assignment_id, q_id) do
     context 'successful webservice call' do
        joins(response: {map: :reviewer})
      comments = ["Hello this is first comment", "This is second comment"]
        .joins(:question)
      summary_ws_url = WEBSERVICE_CONFIG['summary_webservice_url']
         .where("review_maps.reviewed_object_id = ? AND
      it 'return success' do
              answers.question_id = ?", assignment_id, q_id)
         expect(@summary.summarize_sentences(comments,summary_ws_url)).not_to eql(nil)
        .select(:answer, :comments)
      end
        .distinct
     end
     end
  end
</pre>




* break_up_comments_to_sentences
  This methods question answer array and breaks them into comments.
  In our testing we provided the question_answer array of length 2 and see if the number of comments is equal to 2.
Code Snippet:
<pre>
    describe '#break_up_comments_to_sentences' do
    context 'when the question_answers is not nil' do
      it 'add the comment to an array to be converted as a json request' do
        comments = @summary.break_up_comments_to_sentences([answer])
        expect(comments.length).to be(2)
      end
    end
    context 'when the question_answers is nil' do
      it 'returns an empty array' do
        comments = @summary.break_up_comments_to_sentences([])
        expect(comments.length).to be(0)
      end
    end
  end
</pre>


* answers_by_question:
  1. This method joins the responses, answers, response_maps, and questions table. 
  2. Then it applies a where clause to filter the results based on the given assignment_id, reviewee_id and q_id. 
  3. It retrieves answers and comments columns from the combined table.


* calculate_avg_score_by_criterion
This test is to see when question answer was given, the output of method is correctly calculated as percentage of question score.
Code Snippet:
Code Snippet:
<pre>
 
  describe '#calculate_avg_score_by_criterion' do
     scope :by_question, -> (assignment_id, q_id) do
     context 'when question_answers are available' do
        joins(response: {map: :reviewer})
      it 'calculate percentage question_score  & no float' do
        .joins(:question)
  expect(@summary.calculate_avg_score_by_criterion([answer,answer1], 3)).to be_within(0).of(50)
        .where("review_maps.reviewed_object_id = ? AND
         end
              answers.question_id = ?", assignment_id, q_id)
        .select(:answer, :comments)
         .distinct
     end
     end
</pre>


== Test Plan ==


This test is to see when question answer was nil, the output of method is correctly calculated as 0.  
We have implemented test cases using RSpec for different validation checks for answer.rb.
Code Snippet:
<pre>
    context 'when question_answers are not available' do
      it 'gives question scores 0.0' do
        expect(@summary.calculate_avg_score_by_criterion([], 3)).to eq(0.0)
      end
    end
</pre>


This test is to see when q_max_score = 0, the output of method is correctly calculated.
Code Snippet:
Code Snippet:
<pre>
    context 'when q_max_score = 0' do
      it 'gives pure question_score' do
        expect(@summary.calculate_avg_score_by_criterion([answer,answer1], 0)).to eq(3.0)
      end
    end
  end
</pre>


  require '/Users/aw/Documents/Course Study Material/OODD/Program 3/spec/rails_helper.rb'
  require '/Users/aw/Documents/Course Study Material/OODD/Program 3/spec/spec_helper.rb'


* calculate_round_score
  RSpec.describe Answer, type: :model do
The test is to see when the criteria input is nil, the method gives right output of nil, which is 0 in this case.  
    describe ".by_question_for_reviewee_in_round" do
Code Snippet:
      let(:assignment) { create(:assignment) }
<pre>
      let(:reviewer) { create(:user) }
  describe '#calculate_round_score' do
      let(:reviewee) { create(:user) }
  context 'when criteria not available' do
      let(:round) { 1 }
    it 'returns 0.0 since round_score = 0.0' do
      let(:question) { create(:question, assignment: assignment) }
      expect(@summary.calculate_round_score(avg_scores_by_criterion, nil)).to eq(0.to_f)
      let(:response_map) { create(:review_map, reviewed_object: assignment, reviewer: reviewer, reviewee: reviewee) }
      let(:response) { create(:response, map: response_map, round: round) }
      let!(:answer) { create(:answer, question: question, response: response) }
      it "returns the answer and comments for the specified question, reviewee, assignment, and round" do
        expect(Answer.by_question_for_reviewee_in_round(assignment.id, reviewee.id, question.id, round))
          .to match_array([{answer: answer.answer, comments: answer.comments}])
     end
     end
   end
   end
</pre>


  describe ".by_question" do
    let(:assignment) { create(:assignment) }
    let(:reviewer) { create(:user) }
    let(:question) { create(:question, assignment: assignment) }
    let(:response_map) { create(:review_map, reviewed_object: assignment, reviewer: reviewer) }
    let(:response) { create(:response, map: response_map) }
    let!(:answer) { create(:answer, question: question, response: response) }
    it "returns the answer and comments for the specified question and assignment" do
      expect(Answer.by_question(assignment.id, question.id))
        .to match_array([{answer: answer.answer, comments: answer.comments}])
    end
  end


The test is to see when the criteria input is not nil, the method gives the right output, which is to get a two-digit round score. The criteria input was defined as question in mock section.
  describe ".by_question_for_reviewee" do
Code Snippet:
    let(:assignment) { create(:assignment) }
<pre>
    let(:reviewer) { create(:user) }
  context 'when criteria not nil' do
    let(:reviewee) { create(:user) }
    it 'get 2 round_score  ' do
    let(:question) { create(:question, assignment: assignment) }
      expect(@summary.calculate_round_score(avg_scores_by_criterion, question)).to be_within(0.01).of(2.345)
    let(:response_map) { create(:review_map, reviewed_object: assignment, reviewer: reviewer, reviewee: reviewee) }
    end
    let(:response) { create(:response, map: response_map) }
  end
    let!(:answer) { create(:answer, question: question, response: response) }
end
    it "returns the answer and comments for the specified question, reviewee, and assignment" do
</pre>
      expect(Answer.by_question_for_reviewee(assignment.id, reviewee.id, question.id))
        .to match_array([{answer: answer.answer, comments: answer.comments}])
    end
  end


 
  describe ".by_response" do
* calculate_avg_score_by_round
    let(:response) { create(:response) }
This test is to see the method round an average number up to Two-digit. The input of avg_scores_by_criterion was given as 2.345, and we tested here that it gives two-digit round number as 2.35.
    let!(:answer) { create(:answer, response: response) }
Code Snippet:
    it "returns the answer for the specified response" do
<pre>
      expect(Answer.by_response(response.id)).to eq([answer.answer])
  describe '#calculate_avg_score_by_round'do
    end
  context 'when avg_scores_by_criterion available' do
    it 'gives 2 round value' do
      expect(@summary.calculate_avg_score_by_round(avg_scores_by_criterion, question)).to eq(2.35)
    end
  end
   end
   end
</pre>
end


=== Test Execution ===
=== Test Execution ===
We divided the work among the teammates and started tackling the problems. We stubbed the data using factory and mocked the method calls which were being done internally to get the desired output from the methods that were calling other methods internally.
We divided the work among the teammates and started tackling the problems. We stubbed the data using the factory and mocked the method calls which were being done internally to get the desired output from the methods that were calling other methods internally.


=== Test Coverage ===
The summary helper spec file is newly created. This project increased testing coverage by 72.86% according to simplecov test.
[[File:test_coverage.png]]


=== Conclusion ===
=== Conclusion ===
While we tried to test all the methods in the summary_helper.rb class, we faced some blockers. All the blockers are described below:-
We have refactored the code in the answer.rb file to return answers in each response. We have tested the model fully and attaching the video of the passed test cases in the submission.
* summarize_sentences method
summary_webservice_url: 'http://peerlogic.csc.ncsu.edu/sum/v1.0/summary/8/lsa'
This URL is being used in the summary_helper.rb file and we were not able to mock it. It's giving us bad gateway error while we try to hit that url.
 
* summarize_reviews_by_reviewee method
 
In this method we found out in the loop, questions[round] is not the correct way of passing the individual question since questions is an array and use 0 based indexing. Whereas in the above logic it is being treated as a hash.
 
* summarize_reviews_by_reviewee_question method
 
This method uses the instance variables from a different method(summarize_reviews_by_reviewee) which are not being passed as arguments to this method. Technically this type of initialization is bad coding practice and hence needs refratoring.
 
 
We tested all other remaining methods in the summary_helper.rb class. All the unit tests passed and the methods were working as expected. We tried to cover corner cases but there is room for some improvement.

Latest revision as of 03:10, 23 March 2023

About Expertiza

Expertiza is an assignment/project management portal that can be used by both instructors and students for collaborative learning and feedback. It is an open-source project based on Ruby on Rails framework. It allows the instructors not only to create and customize new or existing assignments but also to create a list of topics the students can sign up for. Students can form teams to work on various projects and assignments. Expertiza also lets students peer-review other students' submissions, enabling them to work together to improve others' learning experiences.

Team

Mentor

  • Jialin Cui

Team Members

  • Aman Waoo
  • Girish Wangikar
  • Pranavi Sharma Sanganabhatla

Description and Testing

Our project deals with refactoring the answer.rb file. The code is responsible for doing the following tasks:

  • To design and implement an answsers_by_response method that returns answers in each response.
  • Get the answer model fully tested.

Files Involved

  • answer.rb
  • answer_spec.rb

Running Tests

To successfully run answer_spec on the local machine, please run the below rspec command.

  rspec spec/answer_spec.rb


Project Description

The objective of the project is to refactor the following Ruby on Rails model classes in the existing project:- Answer Model on Expertiza.The model is designed to represent answers to questions in Expertiza. So, whenever anyone fills out a rubric, each “question” that is answered creates a new Answer object.

The task is to refactor the existing code present in the model file and implement them in a new repository. Since the project is implemented from scratch, there are various aspects of the project that have to be implemented and therefore unit test cases are implemented to test the implementation.


  • answers_by_question_for_reviewee_in_round:
 1. This method joins the responses, answers, response_maps, and questions table. 
 2. Then it applies a where clause to filter the results based on the given assignment_id, reviewee_id, q_id, and round parameters. 
 3. It retrieves answers and comments columns from the combined table. 


Code Snippet:

   scope :by_question_for_reviewee_in_round, -> (assignment_id, reviewee_id, q_id, round) do
      joins(response: {map: :reviewer})
      .joins(:question)
      .where("review_maps.reviewed_object_id = ? AND
              review_maps.reviewee_id = ? AND
              answers.question_id = ? AND
              responses.round = ?", assignment_id, reviewee_id, q_id, round)
      .select(:answer, :comments)
  end


  • answers_by_question:
 1. This method joins the questions, answers, responses, and response_maps table. 
 2. Then it applies a where clause to filter the results based on the given q_id and assignment_id. 
 3. It retrieves the distinct answers and comments columns from the combined table. 

Code Snippet:

   scope :by_question, -> (assignment_id, q_id) do
       joins(response: {map: :reviewer})
       .joins(:question)
       .where("review_maps.reviewed_object_id = ? AND
             answers.question_id = ?", assignment_id, q_id)
       .select(:answer, :comments)
       .distinct
   end


  • answers_by_question:
 1. This method joins the responses, answers, response_maps, and questions table.  
 2. Then it applies a where clause to filter the results based on the given assignment_id, reviewee_id and q_id.  
 3. It retrieves answers and comments columns from the combined table.


Code Snippet:

   scope :by_question, -> (assignment_id, q_id) do
       joins(response: {map: :reviewer})
       .joins(:question)
       .where("review_maps.reviewed_object_id = ? AND
             answers.question_id = ?", assignment_id, q_id)
       .select(:answer, :comments)
       .distinct
   end

Test Plan

We have implemented test cases using RSpec for different validation checks for answer.rb.

Code Snippet:

 require '/Users/aw/Documents/Course Study Material/OODD/Program 3/spec/rails_helper.rb'
 require '/Users/aw/Documents/Course Study Material/OODD/Program 3/spec/spec_helper.rb'
 RSpec.describe Answer, type: :model do
   describe ".by_question_for_reviewee_in_round" do
     let(:assignment) { create(:assignment) }
     let(:reviewer) { create(:user) }
     let(:reviewee) { create(:user) }
     let(:round) { 1 }
     let(:question) { create(:question, assignment: assignment) }
     let(:response_map) { create(:review_map, reviewed_object: assignment, reviewer: reviewer, reviewee: reviewee) }
     let(:response) { create(:response, map: response_map, round: round) }
     let!(:answer) { create(:answer, question: question, response: response) }
     it "returns the answer and comments for the specified question, reviewee, assignment, and round" do
       expect(Answer.by_question_for_reviewee_in_round(assignment.id, reviewee.id, question.id, round))
         .to match_array([{answer: answer.answer, comments: answer.comments}])
    end
  end
 describe ".by_question" do
   let(:assignment) { create(:assignment) }
   let(:reviewer) { create(:user) }
   let(:question) { create(:question, assignment: assignment) }
   let(:response_map) { create(:review_map, reviewed_object: assignment, reviewer: reviewer) }
   let(:response) { create(:response, map: response_map) }
   let!(:answer) { create(:answer, question: question, response: response) }
   it "returns the answer and comments for the specified question and assignment" do
     expect(Answer.by_question(assignment.id, question.id))
       .to match_array([{answer: answer.answer, comments: answer.comments}])
   end
 end
 describe ".by_question_for_reviewee" do
   let(:assignment) { create(:assignment) }
   let(:reviewer) { create(:user) }
   let(:reviewee) { create(:user) }
   let(:question) { create(:question, assignment: assignment) }
   let(:response_map) { create(:review_map, reviewed_object: assignment, reviewer: reviewer, reviewee: reviewee) }
   let(:response) { create(:response, map: response_map) }
   let!(:answer) { create(:answer, question: question, response: response) }
   it "returns the answer and comments for the specified question, reviewee, and assignment" do
     expect(Answer.by_question_for_reviewee(assignment.id, reviewee.id, question.id))
       .to match_array([{answer: answer.answer, comments: answer.comments}])
   end
 end
 describe ".by_response" do
   let(:response) { create(:response) }
   let!(:answer) { create(:answer, response: response) }
   it "returns the answer for the specified response" do
     expect(Answer.by_response(response.id)).to eq([answer.answer])
   end
 end
end

Test Execution

We divided the work among the teammates and started tackling the problems. We stubbed the data using the factory and mocked the method calls which were being done internally to get the desired output from the methods that were calling other methods internally.


Conclusion

We have refactored the code in the answer.rb file to return answers in each response. We have tested the model fully and attaching the video of the passed test cases in the submission.