|
|
| (One intermediate revision by the same user not shown) |
| Line 1: |
Line 1: |
| == '''Refactor ''review_mapping_helper.rb''''' ==
| |
|
| |
|
| This page gives a description of the changes made for the ''review_mapping helper.rb'' of Expertiza based OSS project.
| |
|
| |
| ==Expertiza Background ==
| |
| Expertiza is a web application where students can submit and peer-review learning objects (articles, codes, websites, etc). Instructors add and grade the assignments submitted by students to Expertiza. Students can be assigned in teams based on their selection of the topics.
| |
|
| |
| == Problem Statement: ==
| |
|
| |
| The review_mapping_helper.rb has multiple functions with a wrong naming convention, they are classic examples of bad function names. These functions are to be refactored accordingly. Few of the variables names used in the method must also be refactored to make it more relevant and understandable. In addition, some function's code is to be optimized to ensure that it follows DRY principle. Also, comments must be added to all functions of the file.
| |
|
| |
| == Refactored method names ==
| |
| All the method names that are refactored are mentioned below-
| |
|
| |
| '''Before:'''
| |
|
| |
| get_each_round_review_and_feedback_response_map_for_feedback_report
| |
|
| |
| '''After:'''
| |
|
| |
| TO-DO
| |
|
| |
|
| |
|
| |
| '''Before:'''
| |
|
| |
| get_certain_round_review_and_feedback_response_map_for_feedback_report
| |
|
| |
| '''After:'''
| |
|
| |
| TO-DO
| |
|
| |
|
| |
|
| |
| '''Before:'''
| |
|
| |
| get_team_name_color_in_review_report
| |
|
| |
| '''After:'''
| |
|
| |
| TO-DO
| |
|
| |
|
| |
|
| |
| '''Before:'''
| |
|
| |
| get_current_round_for_review_report
| |
|
| |
| '''After:'''
| |
|
| |
| TO-DO
| |
|
| |
|
| |
|
| |
| '''Before:'''
| |
|
| |
| get_each_round_score_awarded_for_review_report
| |
|
| |
| '''After:'''
| |
|
| |
| TO-DO
| |
|
| |
|
| |
|
| |
| '''Before:'''
| |
|
| |
| get_min_max_avg_value_for_review_report
| |
|
| |
| '''After:'''
| |
|
| |
| TO-DO
| |