User:Ptrived - Revision history

Ptrived: /* E1614. Refactoring Response Controller */

2016-03-23T17:14:52Z

E1614. Refactoring Response Controller

← Older revision		Revision as of 17:14, 23 March 2016
Line 168:		Line 168:
	end		end
	</pre>		</pre>


			===References===

			#[https://github.com/anuragshendge/expertiza Forked Repository for Expertiza Project]
			#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
			#[https://github.com/expertiza/expertiza Expertiza on GitHub]

Ptrived: /* E1614. Refactoring Response Controller */

2016-03-23T17:11:42Z

E1614. Refactoring Response Controller

@@ Line 111: / Line 111: @@
      end
      redirect_to :controller => 'response', :action => 'saving', :id => @map.map_id, :return => params[:return], :msg => msg, :save_options => params[:save_options]
    end
 </pre>

Ptrived: /* E1614. Refactoring Response Controller */

2016-03-23T16:58:26Z

E1614. Refactoring Response Controller

@@ Line 57: / Line 57: @@
      @response.email();
      redirect_to :controller => 'response', :action => 'saving', :id => @map.map_id, :return => params[:return], :msg => msg, :error_msg => error_msg, :save_options => params[:save_options]
    end
 </pre>

Ptrived: /* Moving variable declaration to right places */

2016-03-23T16:46:07Z

Moving variable declaration to right places

@@ Line 24: / Line 24: @@
 There were two variables "msg" and "error_msg" in the create method which were declared and initialized to blank strings and then again assigned some string value before it was used in the method. So we moved the variable declaration to the place were it was used and removed the unnecessary variable declaration. Below if the code snippet for the changes done:
 <pre>
-   Hello
+ def create
 </pre>

Ptrived: /* E1614. Refactoring Response Controller */

2016-03-23T16:44:55Z

E1614. Refactoring Response Controller

← Older revision		Revision as of 16:44, 23 March 2016
Line 22:		Line 22:
	===Changes done as part of refactoring===		===Changes done as part of refactoring===
	====Moving variable declaration to right places====		====Moving variable declaration to right places====
			There were two variables "msg" and "error_msg" in the create method which were declared and initialized to blank strings and then again assigned some string value before it was used in the method. So we moved the variable declaration to the place were it was used and removed the unnecessary variable declaration. Below if the code snippet for the changes done:
			<pre>
			Hello
			</pre>

Ptrived: /* E1614. Refactoring Response Controller */

2016-03-23T16:37:37Z

E1614. Refactoring Response Controller

← Older revision		Revision as of 16:37, 23 March 2016
Line 16:		Line 16:
	* Replacing if else block with switch statements.		* Replacing if else block with switch statements.
	* Remove the unreachable code.		* Remove the unreachable code.

			===About Response Controller===
			The Response controller is responsible for the CRUD(Create, Read, Update and Delete) operations on responses. The users can fill out a questionnaire such as review rubric or feedback on the partner's contribution. So the ResponseController handles the various operations on the responses, which are objects that Expertiza creates when you fill out a questionnaire.

			===Changes done as part of refactoring===
			====Moving variable declaration to right places====

Ptrived: Created page with "==E1614. Refactoring Response Controller== This page provide the details of the changes done as part of the refactoring response controller project(E1614). TOC ===A brief ..."

2016-03-23T16:28:20Z

Created page with "==E1614. Refactoring Response Controller== This page provide the details of the changes done as part of the refactoring response controller project(E1614). __TOC__ ===A brief ..."

New page

==E1614. Refactoring Response Controller==

This page provide the details of the changes done as part of the refactoring response controller project(E1614).

__TOC__

===A brief overview of Expertiza===
[http://expertiza.ncsu.edu/ Expertiza] project is a platform to create reusable learning objects through peer review. It is an open source project which uses [http://rubyonrails.org/ Ruby on Rails] framework.

===Project Statement===
The main aim of this project was to refactor the response_controller. The following tasks were completed as part of refactoring in this project:

* Moving variable declaration to right places.
* Removing unused variables.
* Fixing code duplication.
* Replacing if else block with switch statements.
* Remove the unreachable code.

User:Ptrived - Revision history

Ptrived: /* E1614. Refactoring Response Controller */

Ptrived: /* E1614. Refactoring Response Controller */

Ptrived: /* E1614. Refactoring Response Controller */

Ptrived: /* Moving variable declaration to right places */

Ptrived: /* E1614. Refactoring Response Controller */

Ptrived: /* E1614. Refactoring Response Controller */

Ptrived: Created page with "==E1614. Refactoring Response Controller== This page provide the details of the changes done as part of the refactoring response controller project(E1614). __TOC__ ===A brief ..."

Ptrived: Created page with "==E1614. Refactoring Response Controller== This page provide the details of the changes done as part of the refactoring response controller project(E1614). TOC ===A brief ..."