User:Hxia3 - Revision history

Hxia3: /* Refactored self.compute_scores method */

2015-10-27T19:31:50Z

Refactored self.compute_scores method

← Older revision		Revision as of 19:31, 27 October 2015
Line 14:		Line 14:

	==Refactored self.compute_scores method==		==Refactored self.compute_scores method==
	As described in OSS project , the self.compute_scores method is complex. Followed the principle that one method only do one thing, we split the the self.compute_scores by adding a method called self.compute_stat to take on some responsibilities from the self.compute_scores method, namely, computing the current score. Specific changes before and after are shown below:		As described in OSS project, the self.compute_scores method is complex. Followed the principle that one method only do one thing, we split the the self.compute_scores by adding a method called self.compute_stat to take on some responsibilities from the self.compute_scores method, namely, computing the current score. Specific changes before and after are shown below:

	===Before changes===		===Before changes===
Line 106:		Line 106:
	return curr_score, scores		return curr_score, scores
	end		end


	==Refactored "submission_valid?" method==		==Refactored "submission_valid?" method==

2015-10-27T19:31:37Z

Command to run the test: rspec spec/models/answer_spec.rb

← Older revision		Revision as of 19:31, 27 October 2015
Line 110:		Line 110:
	==Refactored "submission_valid?" method==		==Refactored "submission_valid?" method==
	We found some parts of codes in the 'self.submission_valid?' method can be taken out as a individual method. To fulfill the function which calculates the latest review phase start time, we named this method as 'latest_review_deadline". See the changes below:		We found some parts of codes in the 'self.submission_valid?' method can be taken out as a individual method. To fulfill the function which calculates the latest review phase start time, we named this method as 'latest_review_deadline". See the changes below:
	~~====Command to run the test: rspec spec/models/answer_spec.rb====~~
	===Before changes===		===Before changes===
	def self.submission_valid?(response)		def self.submission_valid?(response)

2015-10-27T19:31:18Z

Command to run the test: rspec spec/models/answer_spec.rb

← Older revision		Revision as of 19:31, 27 October 2015
Line 211:		Line 211:
	There are six methods in the new version of answer.rb; so we performed six unit tests. The test file for Answer model is answer_spec.rb which can be found in the directory: expertiza/spec/models/ . Below is the unit test code:		There are six methods in the new version of answer.rb; so we performed six unit tests. The test file for Answer model is answer_spec.rb which can be found in the directory: expertiza/spec/models/ . Below is the unit test code:
	====Command to run the test: rspec spec/models/answer_spec.rb====		====Command to run the test: rspec spec/models/answer_spec.rb====
	require 'rspec'		require 'rspec'
	require_relative '../rails_helper'		require_relative '../rails_helper'

2015-10-27T19:30:57Z

Command to run the test: rspec spec/models/answer_spec.rb

2015-10-27T19:27:31Z

Unit tests using Rspec

← Older revision		Revision as of 19:27, 27 October 2015
Line 210:		Line 210:
	==Unit tests using Rspec==		==Unit tests using Rspec==
	There are six methods in the new version of answer.rb; so we performed six unit tests. The test file for Answer model is answer_spec.rb which can be found in the directory: expertiza/spec/models/ . Below is the unit test code:		There are six methods in the new version of answer.rb; so we performed six unit tests. The test file for Answer model is answer_spec.rb which can be found in the directory: expertiza/spec/models/ . Below is the unit test code:
			====Command to run the test: rspec spec/models/answer_spec.rb====
	require 'rspec'		require 'rspec'
	require_relative '../rails_helper'		require_relative '../rails_helper'

2015-10-27T19:26:15Z

Refactored "submission_valid?" method

← Older revision		Revision as of 19:26, 27 October 2015
Line 109:		Line 109:

	==Refactored "submission_valid?" method==		==Refactored "submission_valid?" method==
	we found some parts of codes in the 'self.submission_valid?' method can be taken out as a individual method. To fulfill the function which calculates the latest review phase start time, we named this method as 'latest_review_deadline". See the changes below:		We found some parts of codes in the 'self.submission_valid?' method can be taken out as a individual method. To fulfill the function which calculates the latest review phase start time, we named this method as 'latest_review_deadline". See the changes below:
			====Command to run the test: rspec spec/models/answer_spec.rb====
	===Before changes===		===Before changes===
	def self.submission_valid?(response)		def self.submission_valid?(response)

2015-10-27T04:18:42Z

Refactored self.submission_valid? method

← Older revision		Revision as of 04:18, 27 October 2015
Line 108:		Line 108:


	==Refactored ~~self.~~submission_valid? method==		==Refactored "submission_valid?" method==
	we found some parts of codes in the 'self.submission_valid?' method can be taken out as a individual method. To fulfill the function which calculates the latest review phase start time, we named this method as 'latest_review_deadline". See the changes below:		we found some parts of codes in the 'self.submission_valid?' method can be taken out as a individual method. To fulfill the function which calculates the latest review phase start time, we named this method as 'latest_review_deadline". See the changes below:

2015-10-27T04:16:56Z

Unit tests using Rspec

← Older revision		Revision as of 04:16, 27 October 2015
Line 266:		Line 266:
	end		end

	# Unit test for 'submission_valid?'
			# Unit test for 'submission_valid?'
	describe 'submission valid' do		describe 'submission valid' do
	before(:each) {		before(:each) {

2015-10-27T04:16:15Z

Unit tests using Rspec

← Older revision		Revision as of 04:16, 27 October 2015
Line 266:		Line 266:
	end		end

	# Unit test for 'submission_valid?'		# Unit test for 'submission_valid?'
	describe 'submission valid' do		describe 'submission valid' do
	before(:each) {		before(:each) {

2015-10-27T04:13:21Z

Refactored self.submission_valid? method

← Older revision		Revision as of 04:13, 27 October 2015
Line 109:		Line 109:

	==Refactored self.submission_valid? method==		==Refactored self.submission_valid? method==
	we found some parts of codes in the self.submission_valid? method can be taken out as a individual method. To fulfill the function which calculates the latest review phase start time, we named this method as ~~"self.~~latest_review_deadline". See the changes below:		we found some parts of codes in the 'self.submission_valid?' method can be taken out as a individual method. To fulfill the function which calculates the latest review phase start time, we named this method as 'latest_review_deadline". See the changes below:

	===Before changes===		===Before changes===