M1852 Implement missing WebAudio node support - Revision history

Rkolhe: /* Build */

2018-12-08T01:12:20Z

Build

← Older revision		Revision as of 01:12, 8 December 2018
Line 440:		Line 440:

	=='''Build'''==		=='''Build'''==
	<strong>12/07- A Servo team member (@ferjm: Fernando Jimenez Moreno) <b>~~approved~~</b> the pull request (#164)</strong>		<strong>12/07- A Servo team member (@ferjm: Fernando Jimenez Moreno) <b>merged</b> the pull request (#164)</strong>
	[[File:merged164-2.png]]		[[File:merged164-2.png]]

2018-12-08T00:57:50Z

Build

← Older revision		Revision as of 00:57, 8 December 2018
Line 441:		Line 441:
	=='''Build'''==		=='''Build'''==
	<strong>12/07- A Servo team member (@ferjm: Fernando Jimenez Moreno) <b>approved</b> the pull request (#164)</strong>		<strong>12/07- A Servo team member (@ferjm: Fernando Jimenez Moreno) <b>approved</b> the pull request (#164)</strong>
	[[File:~~Merged 164~~.png]]		[[File:merged164-2.png]]

	12/06- Completed the changes stated in the review for Constant Source Node example. The updated pull request can be accessed via [https://github.com/servo/media/pull/164 here]		12/06- Completed the changes stated in the review for Constant Source Node example. The updated pull request can be accessed via [https://github.com/servo/media/pull/164 here]

2018-12-08T00:55:51Z

Build

← Older revision		Revision as of 00:55, 8 December 2018
Line 440:		Line 440:

	=='''Build'''==		=='''Build'''==
	12/07- A Servo team member (@ferjm: Fernando Jimenez Moreno) <b>approved</b> the pull request (#164)		<strong>12/07- A Servo team member (@ferjm: Fernando Jimenez Moreno) <b>approved</b> the pull request (#164)</strong>
			[[File:Merged 164.png]]

	12/06- Completed the changes stated in the review for Constant Source Node example. The updated pull request can be accessed via [https://github.com/servo/media/pull/164 here]		12/06- Completed the changes stated in the review for Constant Source Node example. The updated pull request can be accessed via [https://github.com/servo/media/pull/164 here]
Line 449:		Line 450:


	<strong~~><big~~>11/8- A Servo team member (@Manishearth) <b>approved</b> the pull request and advised us to make some minor formatting changes.~~</big>~~</strong>		<strong>11/8- A Servo team member (@Manishearth) <b>approved</b> the pull request and advised us to make some minor formatting changes.</strong>

	[[File:pullReq.png]]		[[File:pullReq.png]]

2018-12-08T00:49:08Z

Build

← Older revision		Revision as of 00:49, 8 December 2018
Line 440:		Line 440:

	=='''Build'''==		=='''Build'''==
			12/07- A Servo team member (@ferjm: Fernando Jimenez Moreno) <b>approved</b> the pull request (#164)

	12/06- Completed the changes stated in the review for Constant Source Node example. The updated pull request can be accessed via [https://github.com/servo/media/pull/164 here]		12/06- Completed the changes stated in the review for Constant Source Node example. The updated pull request can be accessed via [https://github.com/servo/media/pull/164 here]

2018-12-07T00:59:31Z

Build

← Older revision		Revision as of 00:59, 7 December 2018
Line 440:		Line 440:

	=='''Build'''==		=='''Build'''==
	12/06- Completed the changes stated in the review for Constant Source Node example. The updated pull request can be accessed via [https://github.com/servo/media/pull/164]		12/06- Completed the changes stated in the review for Constant Source Node example. The updated pull request can be accessed via [https://github.com/servo/media/pull/164 here]

	11/9- The formatted changes have been committed as said in the review.The changes to the formatting can be seen [https://github.com/Avanthikaa/media/commit/5d8cdfc029daf69122c64f8bfcceaec6f80916a4 here]		11/9- The formatted changes have been committed as said in the review.The changes to the formatting can be seen [https://github.com/Avanthikaa/media/commit/5d8cdfc029daf69122c64f8bfcceaec6f80916a4 here]

2018-12-07T00:59:02Z

Build

← Older revision		Revision as of 00:59, 7 December 2018
Line 440:		Line 440:

	=='''Build'''==		=='''Build'''==
			12/06- Completed the changes stated in the review for Constant Source Node example. The updated pull request can be accessed via [https://github.com/servo/media/pull/164]

	11/9- The ~~the~~ formatted changes have been committed as said in the review.The changes to the formatting can be seen [https://github.com/Avanthikaa/media/commit/5d8cdfc029daf69122c64f8bfcceaec6f80916a4 here]		11/9- The formatted changes have been committed as said in the review.The changes to the formatting can be seen [https://github.com/Avanthikaa/media/commit/5d8cdfc029daf69122c64f8bfcceaec6f80916a4 here]

	[[File:format_commit.png]]		[[File:format_commit.png]]

2018-12-07T00:27:15Z

Test Plan

← Older revision		Revision as of 00:27, 7 December 2018
Line 593:		Line 593:

	3) Different sounds based on the type of oscillator (waveform) must be generated after definite interval of time.		3) Different sounds based on the type of oscillator (waveform) must be generated after definite interval of time.

			4) Run the command <big><code>./constant_source</code></big>

	Examples for the different sound waves can be found below:		Examples for the different sound waves can be found below:
Line 600:		Line 602:
	<li>[https://en.audiofanzine.com/medias/audio/#id:473859 Sawtooth]		<li>[https://en.audiofanzine.com/medias/audio/#id:473859 Sawtooth]
	<li>[https://upload.wikimedia.org/wikipedia/commons/d/df/220_Hz_anti-aliased_triangle_wave.ogg Triangle]		<li>[https://upload.wikimedia.org/wikipedia/commons/d/df/220_Hz_anti-aliased_triangle_wave.ogg Triangle]



	=='''References'''==		=='''References'''==

2018-12-07T00:24:12Z

Code Snippet

2018-12-07T00:19:39Z

Files (to be) modified

← Older revision		Revision as of 00:19, 7 December 2018
Line 51:		Line 51:
	=='''Files (to be) modified'''==		=='''Files (to be) modified'''==
	* media/audio/src/oscillator_node.rs		* media/audio/src/oscillator_node.rs
	* media/audio/src/~~constant_source~~.rs		* media/audio/src/constant_source_node.rs
	* media/audio/src/node.rs		* media/audio/src/node.rs
	* media/audio/src/lib.rs		* media/audio/src/lib.rs
Line 57:		Line 57:
	* media/audio/src/param.rs		* media/audio/src/param.rs
	* media/examples/oscillator.rs		* media/examples/oscillator.rs
			* media/examples/constant_source.rs

	=='''Implementation'''==		=='''Implementation'''==

2018-11-21T01:17:07Z

Code Snippet

← Older revision		Revision as of 01:17, 21 November 2018
Line 237:		Line 237:

	We created the <code>constant_source.rs</code> file in the <code>audio/src/</code> directory which has the function to generate a constant tone		We created the <code>constant_source.rs</code> file in the <code>audio/src/</code> directory which has the function to generate a constant tone


	<pre>		<pre>
Line 312:		Line 311:

	</pre>		</pre>


	=='''Build'''==		=='''Build'''==