E1929 Visualizations for Instructors - Revision history

Rdemarc at 03:21, 3 May 2019

2019-05-03T03:21:34Z

← Older revision		Revision as of 03:21, 3 May 2019
Line 72:		Line 72:
	* spec/models/assignment_spec.rb		* spec/models/assignment_spec.rb
	* spec/models/questionnaire_spec.rb		* spec/models/questionnaire_spec.rb


	== Testing ==		== Testing ==

Rdemarc at 03:20, 3 May 2019

2019-05-03T03:20:49Z

← Older revision		Revision as of 03:20, 3 May 2019
Line 114:		Line 114:

	== Shortcomings ==		== Shortcomings ==
	* We were unable to find two compatible assignments in the Expertiza test database to fully test our Compare Assignments feature. We did test all the functionality ~~using hard-coded data~~, but ~~weren~~'t ~~able to do it pulling~~ real data ~~like we did for the Analyze Assignments feature~~.		* We were unable to find two compatible assignments in the Expertiza test database to fully test our Compare Assignments feature. We did test all the functionality by seeding the database, but it technically wasn't using real data.

Rdemarc: /* Code Changes */

2019-05-01T01:59:58Z

Code Changes

← Older revision		Revision as of 01:59, 1 May 2019
Line 49:		Line 49:
	[https://github.com/expertiza/expertiza/pull/1440/files Files Added/Modified]		[https://github.com/expertiza/expertiza/pull/1440/files Files Added/Modified]

	Added: 10 + Modified: 13 = Total: 23		Added: 10 + Modified: 11 = Total: 21

	* app/assets/javascripts/rubric_stats.js '''(new)'''		* app/assets/javascripts/rubric_stats.js '''(new)'''

Gshugh: /* Code Changes */

2019-05-01T00:31:23Z

Code Changes

← Older revision		Revision as of 00:31, 1 May 2019
Line 51:		Line 51:
	Added: 10 + Modified: 13 = Total: 23		Added: 10 + Modified: 13 = Total: 23

	* Gemfile
	* Gemfile.lock
	* app/assets/javascripts/rubric_stats.js '''(new)'''		* app/assets/javascripts/rubric_stats.js '''(new)'''
	* app/controllers/grades_controller.rb		* app/controllers/grades_controller.rb
Line 74:		Line 72:
	* spec/models/assignment_spec.rb		* spec/models/assignment_spec.rb
	* spec/models/questionnaire_spec.rb		* spec/models/questionnaire_spec.rb


	== Testing ==		== Testing ==

Rdemarc at 04:02, 27 April 2019

2019-04-27T04:02:35Z

← Older revision		Revision as of 04:02, 27 April 2019
Line 141:		Line 141:

	[https://github.com/gshugh/expertiza/tree/OSS-HW4 GitHub Repo]		[https://github.com/gshugh/expertiza/tree/OSS-HW4 GitHub Repo]

			[https://drive.google.com/file/d/1jmOYfbNOlXQObtsK4MoIti-LsjJ_Y88P/view Demo Video]

	[https://docs.google.com/document/d/1Ozw2Bj2u_LyeKUdDqAyQtz1stEIKrxkmRnwmNyUgmzw/edit#heading=h.5kwrelqdnewh Problem Statement]		[https://docs.google.com/document/d/1Ozw2Bj2u_LyeKUdDqAyQtz1stEIKrxkmRnwmNyUgmzw/edit#heading=h.5kwrelqdnewh Problem Statement]

Rdemarc at 03:45, 27 April 2019

2019-04-27T03:45:27Z

← Older revision		Revision as of 03:45, 27 April 2019
Line 44:		Line 44:

	* Refactored [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts.html.erb _team_charts.html.erb] partial view to use partials for each graphic. Previously both charts were defined together in _team_charts.html.erb, but now each graphic has its own partial view ([https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts_averages.html.erb _team_charts_averages.html.erb], [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts_distribution.html.erb _team_charts_distribution.html.erb], [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts_rubric_stats.html.erb _team_charts_rubric_stats.html.erb]). This allows more flexibility going forward, if it's decided one chart should move to a new place on the page, or to a new page.		* Refactored [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts.html.erb _team_charts.html.erb] partial view to use partials for each graphic. Previously both charts were defined together in _team_charts.html.erb, but now each graphic has its own partial view ([https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts_averages.html.erb _team_charts_averages.html.erb], [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts_distribution.html.erb _team_charts_distribution.html.erb], [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts_rubric_stats.html.erb _team_charts_rubric_stats.html.erb]). This allows more flexibility going forward, if it's decided one chart should move to a new place on the page, or to a new page.


	=== Code Changes ===		=== Code Changes ===

Rdemarc: /* Extra Issues Fixed */

2019-04-27T03:45:12Z

Extra Issues Fixed

← Older revision		Revision as of 03:45, 27 April 2019
Line 44:		Line 44:

	* Refactored [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts.html.erb _team_charts.html.erb] partial view to use partials for each graphic. Previously both charts were defined together in _team_charts.html.erb, but now each graphic has its own partial view ([https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts_averages.html.erb _team_charts_averages.html.erb], [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts_distribution.html.erb _team_charts_distribution.html.erb], [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts_rubric_stats.html.erb _team_charts_rubric_stats.html.erb]). This allows more flexibility going forward, if it's decided one chart should move to a new place on the page, or to a new page.		* Refactored [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts.html.erb _team_charts.html.erb] partial view to use partials for each graphic. Previously both charts were defined together in _team_charts.html.erb, but now each graphic has its own partial view ([https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts_averages.html.erb _team_charts_averages.html.erb], [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts_distribution.html.erb _team_charts_distribution.html.erb], [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts_rubric_stats.html.erb _team_charts_rubric_stats.html.erb]). This allows more flexibility going forward, if it's decided one chart should move to a new place on the page, or to a new page.
	* Updated [https://github.com/gshugh/expertiza/blob/OSS-HW4/app/views/grades/_team_charts.html.erb _team_charts.html.erb] so the "Hide stats" button on the View Scores page properly changes to "Show stats" when the statistic charts are hidden.


	=== Code Changes ===		=== Code Changes ===

Rdemarc at 03:44, 27 April 2019

2019-04-27T03:44:48Z

← Older revision		Revision as of 03:44, 27 April 2019
Line 75:		Line 75:
	* spec/models/assignment_spec.rb		* spec/models/assignment_spec.rb
	* spec/models/questionnaire_spec.rb		* spec/models/questionnaire_spec.rb


	== Testing ==		== Testing ==

Rdemarc: /* Code Changes */

2019-04-27T03:44:08Z

Code Changes

← Older revision		Revision as of 03:44, 27 April 2019
Line 50:		Line 50:
	[https://github.com/expertiza/expertiza/pull/1440/files Files Added/Modified]		[https://github.com/expertiza/expertiza/pull/1440/files Files Added/Modified]

	~~New~~: 10 + Modified: 13 = Total: 23		Added: 10 + Modified: 13 = Total: 23

	* Gemfile		* Gemfile
Line 75:		Line 75:
	* spec/models/assignment_spec.rb		* spec/models/assignment_spec.rb
	* spec/models/questionnaire_spec.rb		* spec/models/questionnaire_spec.rb


	== Testing ==		== Testing ==

Rdemarc at 03:18, 27 April 2019

2019-04-27T03:18:33Z

Show changes