E1909 Refactor review mapping controller - Revision history

Rpalusz: /* Team Members */

2019-04-02T02:57:09Z

Team Members

2019-04-02T02:56:29Z

E1909. Refactoring the Review Mapping Controller

← Older revision		Revision as of 02:56, 2 April 2019
Line 120:		Line 120:

	For the commit associated with our final submission, all existing tests pass according to travis-ci.		For the commit associated with our final submission, all existing tests pass according to travis-ci.

			===Team Members===

			* Randy Paluszkiewicz
			* Eyesore Katsaros
			* Weijia Li

			===References===
			#[https://github.com/ikatsarncsu/expertiza/tree/beta Github Project Repository Fork]
			#[https://github.com/expertiza/expertiza/pull/1396 Github Pull Request]
			#[http://expertiza.ncsu.edu/ Expertiza]

2019-04-02T02:50:31Z

E1909. Refactoring the Review Mapping Controller

← Older revision		Revision as of 02:50, 2 April 2019
Line 119:		Line 119:
	There are existing RSpec tests (spec\controllers\review_mapping_controller_spec.rb) for the given file; we were tasked with ensuring that our changes did not break any of the existing tests, thus retaining the previous code's functionality.		There are existing RSpec tests (spec\controllers\review_mapping_controller_spec.rb) for the given file; we were tasked with ensuring that our changes did not break any of the existing tests, thus retaining the previous code's functionality.

	~~The goal was to also add~~ tests to ~~validate that our refactored methods were still working as intended~~.		For the commit associated with our final submission, all existing tests pass according to travis-ci.

2019-04-02T02:26:36Z

Test Plan

← Older revision		Revision as of 02:26, 2 April 2019
Line 117:		Line 117:
	===Test Plan===		===Test Plan===

	There are existing RSpec tests for the given file; we were tasked with ensuring that our changes did not break any of the existing tests, thus retaining the previous code functionality.		There are existing RSpec tests (spec\controllers\review_mapping_controller_spec.rb) for the given file; we were tasked with ensuring that our changes did not break any of the existing tests, thus retaining the previous code's functionality.

			The goal was to also add tests to validate that our refactored methods were still working as intended.

2019-04-02T02:16:02Z

E1909. Refactoring the Review Mapping Controller

← Older revision		Revision as of 02:16, 2 April 2019
Line 114:		Line 114:

	Although the above could stay as-is in assign_reviewers_for_team, there already seems to be too much functionality in this method, which is why it was moved to insufficient_assign_reviewers		Although the above could stay as-is in assign_reviewers_for_team, there already seems to be too much functionality in this method, which is why it was moved to insufficient_assign_reviewers

			===Test Plan===

			There are existing RSpec tests for the given file; we were tasked with ensuring that our changes did not break any of the existing tests, thus retaining the previous code functionality.

2019-04-02T02:15:52Z

Test Plan

← Older revision		Revision as of 02:15, 2 April 2019
Line 114:		Line 114:

	Although the above could stay as-is in assign_reviewers_for_team, there already seems to be too much functionality in this method, which is why it was moved to insufficient_assign_reviewers		Although the above could stay as-is in assign_reviewers_for_team, there already seems to be too much functionality in this method, which is why it was moved to insufficient_assign_reviewers

	~~===Test Plan===~~

	~~There are existing RSpec tests for the given file; we were tasked with ensuring that our changes did not break any of the existing tests, thus retaining the previous code functionality.~~

2019-04-02T02:15:44Z

Test Plan

← Older revision		Revision as of 02:15, 2 April 2019
Line 115:		Line 115:
	Although the above could stay as-is in assign_reviewers_for_team, there already seems to be too much functionality in this method, which is why it was moved to insufficient_assign_reviewers		Although the above could stay as-is in assign_reviewers_for_team, there already seems to be too much functionality in this method, which is why it was moved to insufficient_assign_reviewers

	==Test Plan==		===Test Plan===

	There are existing RSpec tests for the given file; we were tasked with ensuring that our changes did not break any of the existing tests, thus retaining the previous code functionality.		There are existing RSpec tests for the given file; we were tasked with ensuring that our changes did not break any of the existing tests, thus retaining the previous code functionality.

2019-04-02T02:15:12Z

E1909. Refactoring the Review Mapping Controller

← Older revision		Revision as of 02:15, 2 April 2019
Line 114:		Line 114:

	Although the above could stay as-is in assign_reviewers_for_team, there already seems to be too much functionality in this method, which is why it was moved to insufficient_assign_reviewers		Although the above could stay as-is in assign_reviewers_for_team, there already seems to be too much functionality in this method, which is why it was moved to insufficient_assign_reviewers

			==Test Plan==

			There are existing RSpec tests for the given file; we were tasked with ensuring that our changes did not break any of the existing tests, thus retaining the previous code functionality.

2019-04-02T02:11:54Z

Test Plan

← Older revision		Revision as of 02:11, 2 April 2019
Line 114:		Line 114:

	Although the above could stay as-is in assign_reviewers_for_team, there already seems to be too much functionality in this method, which is why it was moved to insufficient_assign_reviewers		Although the above could stay as-is in assign_reviewers_for_team, there already seems to be too much functionality in this method, which is why it was moved to insufficient_assign_reviewers

	~~==Test Plan==~~

	~~Because there were no existing RSpec tests for the given file, we were required to make some~~

2019-04-02T02:11:43Z

Test Plan

← Older revision		Revision as of 02:11, 2 April 2019
Line 115:		Line 115:
	Although the above could stay as-is in assign_reviewers_for_team, there already seems to be too much functionality in this method, which is why it was moved to insufficient_assign_reviewers		Although the above could stay as-is in assign_reviewers_for_team, there already seems to be too much functionality in this method, which is why it was moved to insufficient_assign_reviewers

	== Test Plan ==		==Test Plan==

	Because there were no existing RSpec tests for the given file, we were required to make some		Because there were no existing RSpec tests for the given file, we were required to make some