CSC/ECE 517 Spring 2020 E2016 Revision planning tool - Revision history

Gwang25: /* Models */

2020-05-04T19:58:09Z

Models

← Older revision		Revision as of 19:58, 4 May 2020
Line 173:		Line 173:
	===Models ===		===Models ===
	'''models/due_date.rb'''		'''models/due_date.rb'''
	*self.get_next_due_date: find next_due_date and return in ascending order.		*self.get_next_due_date: find all next_due_date and return the first one when all dates in ascending order.
	'''models/question.rb'''		'''models/question.rb'''
	*Form association relationship with <code>Team</code> via <code>team_id</code>.		*Form association relationship with <code>Team</code> via <code>team_id</code>.

Gwang25: /* Controllers */

2020-05-04T19:21:30Z

Controllers

← Older revision		Revision as of 19:21, 4 May 2020
Line 165:		Line 165:
	'''controllers/response_controller.rb'''		'''controllers/response_controller.rb'''
	*update/ new/ create/ set_content: use <code>set_questions</code> to get the questions from the original rubric and from revision plan proposed by the team with the corresponding <code>reviewee_id</code>.		*update/ new/ create/ set_content: use <code>set_questions</code> to get the questions from the original rubric and from revision plan proposed by the team with the corresponding <code>reviewee_id</code>.
	*set_questions: a new private method that gets a ~~correct~~ set of questions for each team in a given round through function <code>questions</code> in <code>Questionnaire</code> model.		*set_questions: a new private method that gets a set of questions for each team in a given round through function <code>questions</code> in <code>Questionnaire</code> model.
	'''controllers/grades_controller.rb'''		'''controllers/grades_controller.rb'''
	*view_my_scores：add <code>@team_id</code> to retrieve_questions method, so students could see the revision plan question in "Your scores"		*view_my_scores：add <code>@team_id</code> to retrieve_questions method, so students could see the revision plan question in "Your scores"

Gwang25: /* Controllers */

2020-05-04T19:17:00Z

Controllers

← Older revision		Revision as of 19:17, 4 May 2020
Line 153:		Line 153:
	*edit: when params[:team_id] is exist, "edit_revision_plan" will be redirected.		*edit: when params[:team_id] is exist, "edit_revision_plan" will be redirected.
	*update: extract the duplicate code as a new function <code>update_questions</code>.		*update: extract the duplicate code as a new function <code>update_questions</code>.
	*add_new_questions: add <code>team_id</code> to question, allow student to add new question for revision plan.		*add_new_questions: add <code>team_id</code> and round number which is set 2 to question, allow student to add new question for revision plan.
	*save_all_questions: The duplicate code is extracted as a new function <code>update_questions</code>. The function <code>adjust_question_seq</code> is used to adjust the sequence of the question in the revision plan based on the origin rubric.		*save_all_questions: The duplicate code is extracted as a new function <code>update_questions</code>. The function <code>adjust_question_seq</code> is used to adjust the sequence of the question in the revision plan based on the origin rubric.
	*edit_revision_plan: a new method that prepares view template and supplies revision planning questions that belong to the current team		*edit_revision_plan: a new method that prepares view template and supplies revision planning questions that belong to the current team

Gwang25: /* Controllers */

2020-05-04T18:58:21Z

Controllers

← Older revision		Revision as of 18:58, 4 May 2020
Line 154:		Line 154:
	*update: extract the duplicate code as a new function <code>update_questions</code>.		*update: extract the duplicate code as a new function <code>update_questions</code>.
	*add_new_questions: add <code>team_id</code> to question, allow student to add new question for revision plan.		*add_new_questions: add <code>team_id</code> to question, allow student to add new question for revision plan.
	*save_all_questions: The duplicate code is extracted as a new function <code>~~update_revision~~</code>. The function <code>adjust_question_seq</code> is used to adjust the sequence of the question in the revision plan based on the origin rubric.		*save_all_questions: The duplicate code is extracted as a new function <code>update_questions</code>. The function <code>adjust_question_seq</code> is used to adjust the sequence of the question in the revision plan based on the origin rubric.
	*edit_revision_plan: a new method that prepares view template and supplies revision planning questions that belong to the current team		*edit_revision_plan: a new method that prepares view template and supplies revision planning questions that belong to the current team
	*update_questions: a new private method that could update questions that are already created. This method is extracted from original methods <code>update</code> and <code>save_all_questions</code>.		*update_questions: a new private method that could update questions that are already created. This method is extracted from original methods <code>update</code> and <code>save_all_questions</code>.

Gwang25: /* Controllers */

2020-05-04T18:57:11Z

Controllers

← Older revision		Revision as of 18:57, 4 May 2020
Line 152:		Line 152:
	*action_allowed?: allow students could edit revision questionnaire.		*action_allowed?: allow students could edit revision questionnaire.
	*edit: when params[:team_id] is exist, "edit_revision_plan" will be redirected.		*edit: when params[:team_id] is exist, "edit_revision_plan" will be redirected.
	*update: extract the duplicate code as a new function <code>~~update_revision~~</code>.		*update: extract the duplicate code as a new function <code>update_questions</code>.
	*add_new_questions: add <code>team_id</code> to question, allow student to add new question for revision plan.		*add_new_questions: add <code>team_id</code> to question, allow student to add new question for revision plan.
	*save_all_questions: The duplicate code is extracted as a new function <code>update_revision</code>. The function <code>adjust_question_seq</code> is used to adjust the sequence of the question in the revision plan based on the origin rubric.		*save_all_questions: The duplicate code is extracted as a new function <code>update_revision</code>. The function <code>adjust_question_seq</code> is used to adjust the sequence of the question in the revision plan based on the origin rubric.
	*edit_revision_plan: a new method that prepares view template and supplies revision planning questions that belong to the current team		*edit_revision_plan: a new method that prepares view template and supplies revision planning questions that belong to the current team
	*~~update_revision~~: a new private method that could update questions that are already created. This method is extracted from original methods <code>update</code> and <code>save_all_questions</code>.		*update_questions: a new private method that could update questions that are already created. This method is extracted from original methods <code>update</code> and <code>save_all_questions</code>.
	*adjust_question_seq: a new private method that could move the questions created by students behind the questions in the original rubric.		*adjust_question_seq: a new private method that could move the questions created by students behind the questions in the original rubric.
	*question_params: add team_id		*question_params: add team_id

Gwang25: /* Views */

2020-05-04T18:54:12Z

Views

← Older revision		Revision as of 18:54, 4 May 2020
Line 203:		Line 203:
	*Pass the <code>@map.reviewee_id</code> and <code>@response.round</code> to function <code>display_as_html</code>.		*Pass the <code>@map.reviewee_id</code> and <code>@response.round</code> to function <code>display_as_html</code>.
	'''views/response/response.html.erb'''		'''views/response/response.html.erb'''
	*~~Change~~ the structure		*The structure is changed. Because the origin structure couldn't show the sequence of questions correctly which means the first question will always be shown in last position.
	'''views/grades/_review.html.erb'''		'''views/grades/_review.html.erb'''
	*Pass the <code>participant.team.id</code> and <code>round</code> to function <code>display_as_html</code>.		*Pass the <code>participant.team.id</code> and <code>round</code> to function <code>display_as_html</code>.

Gwang25: /* Models */

2020-05-04T18:47:16Z

Models

← Older revision		Revision as of 18:47, 4 May 2020
Line 179:		Line 179:
	**<code>validates :team_id, numericality: true, allow_nil: true</code>		**<code>validates :team_id, numericality: true, allow_nil: true</code>
	'''models/questionnaire.rb'''		'''models/questionnaire.rb'''
	*questions: a new method could return questions in the original rubric and the team's revision planning questions if the team_id is supplied. The revision planning questions could be get through <code>questions</code> in <code>~~revision_plan_questionnaire~~</code> model.		*questions: a new method could return questions in the original rubric and the team's revision planning questions if the team_id is supplied. The revision planning questions could be get through <code>questions</code> in <code>RevisionPlanQuestionnaire</code> model.
	'''models/response.rb'''		'''models/response.rb'''
	*display_as_html: add team_id and round which could be passed to <code>construct_review_response</code>		*display_as_html: add team_id and round which could be passed to <code>construct_review_response</code>

Gwang25: /* Models */

2020-05-04T18:46:18Z

Models

← Older revision		Revision as of 18:46, 4 May 2020
Line 179:		Line 179:
	**<code>validates :team_id, numericality: true, allow_nil: true</code>		**<code>validates :team_id, numericality: true, allow_nil: true</code>
	'''models/questionnaire.rb'''		'''models/questionnaire.rb'''
	*questions: a new method could return questions in the original rubric and the team's revision planning questions if the team_id is supplied.		*questions: a new method could return questions in the original rubric and the team's revision planning questions if the team_id is supplied. The revision planning questions could be get through <code>questions</code> in <code>revision_plan_questionnaire</code> model.
	'''models/response.rb'''		'''models/response.rb'''
	*display_as_html: add team_id and round which could be passed to <code>construct_review_response</code>		*display_as_html: add team_id and round which could be passed to <code>construct_review_response</code>

Gwang25: /* Views */

2020-05-04T18:23:27Z

Views

← Older revision		Revision as of 18:23, 4 May 2020
Line 191:		Line 191:
	===Views===		===Views===
	'''views/questionnaires/_questioinnaire.html.erb'''		'''views/questionnaires/_questioinnaire.html.erb'''
	* The code is extracted as a partial template named ''views/questionnaires/~~questions~~.html.erb''.		* The code is extracted as a partial template named ''views/questionnaires/_questions.html.erb''.
	'''views/questionnaires/edit_revision_plan.html.erb'''		'''views/questionnaires/edit_revision_plan.html.erb'''
	*It is a newly-added view file for students to create and edit their revision plan. It use some existing codes from the ''app/views/questionnaires/_questionnaire.html.erb'' view file to reduce code redundancy.		*It is a newly-added view file for students to create and edit their revision plan. It use some existing codes from the ''app/views/questionnaires/_questionnaire.html.erb'' view file to reduce code redundancy.

Gwang25: /* Views */

2020-05-04T18:23:17Z

Views

← Older revision		Revision as of 18:23, 4 May 2020
Line 191:		Line 191:
	===Views===		===Views===
	'''views/questionnaires/_questioinnaire.html.erb'''		'''views/questionnaires/_questioinnaire.html.erb'''
	* The code is extracted as a partial template named ''views/~~questionnaires_questions~~.html.erb''.		* The code is extracted as a partial template named ''views/questionnaires/questions.html.erb''.
	'''views/questionnaires/edit_revision_plan.html.erb'''		'''views/questionnaires/edit_revision_plan.html.erb'''
	*It is a newly-added view file for students to create and edit their revision plan. It use some existing codes from the ''app/views/questionnaires/_questionnaire.html.erb'' view file to reduce code redundancy.		*It is a newly-added view file for students to create and edit their revision plan. It use some existing codes from the ''app/views/questionnaires/_questionnaire.html.erb'' view file to reduce code redundancy.