CSC/ECE 517 Spring 2016/Refactor review mapping controller.rb - Revision history

Skunapa at 22:10, 1 April 2016

2016-04-01T22:10:57Z

← Older revision		Revision as of 22:10, 1 April 2016
Line 1:		Line 1:
	~~E1615. Refactoring the Review Mapping Controller~~

	This page provides details about the OSS project which was based on refactoring one of controllers related to peer reviewing strategies used in Expertiza.		This page provides details about the OSS project which was based on refactoring one of controllers related to peer reviewing strategies used in Expertiza.

Skunapa at 22:10, 1 April 2016

2016-04-01T22:10:05Z

← Older revision		Revision as of 22:10, 1 April 2016
Line 1:		Line 1:
	==E1615. Refactoring the Review Mapping Controller==		E1615. Refactoring the Review Mapping Controller

	This page provides details about the OSS project which was based on refactoring one of controllers related to peer reviewing strategies used in Expertiza.		This page provides details about the OSS project which was based on refactoring one of controllers related to peer reviewing strategies used in Expertiza.


	~~__TOC__~~

	=='''Expertiza '''==		=='''Expertiza '''==

Skunapa: moved /CSC/ECE 517 Spring 2016/Refactor review mapping controller.rb to CSC/ECE 517 Spring 2016/Refactor review mapping controller.rb

2016-04-01T22:07:49Z

moved /CSC/ECE 517 Spring 2016/Refactor review mapping controller.rb to CSC/ECE 517 Spring 2016/Refactor review mapping controller.rb

← Older revision	Revision as of 22:07, 1 April 2016
(No difference)

Skunapa: moved Http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE 517 Spring 2016/Refactor review mapping controller.rb to /CSC/ECE 517 Spring 2016/Refactor review mapping controller.rb

2016-04-01T22:07:34Z

moved Http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE 517 Spring 2016/Refactor review mapping controller.rb to /CSC/ECE 517 Spring 2016/Refactor review mapping controller.rb

← Older revision	Revision as of 22:07, 1 April 2016
(No difference)

Skunapa: moved User:Skunapa to Http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE 517 Spring 2016/Refactor review mapping controller.rb

2016-04-01T22:07:08Z

moved User:Skunapa to Http://wiki.expertiza.ncsu.edu/index.php/CSC/ECE 517 Spring 2016/Refactor review mapping controller.rb

← Older revision	Revision as of 22:07, 1 April 2016
(No difference)

Skunapa: /* Code Improvements */

2016-04-01T17:16:35Z

Code Improvements

← Older revision		Revision as of 17:16, 1 April 2016
Line 270:		Line 270:
	end		end
	</pre>		</pre>
	==='''Testing UI'''===		=='''Testing UI'''==

	'''Peer review information:'''		'''Peer review information:'''

Ndhanir at 05:43, 1 April 2016

2016-04-01T05:43:22Z

@@ Line 270: / Line 270: @@
    end
 </pre>
 ==References==

Skunapa at 20:29, 30 March 2016

2016-03-30T20:29:15Z

← Older revision		Revision as of 20:29, 30 March 2016
Line 24:		Line 24:
	The main aim of this project is to		The main aim of this project is to

	* Refactor reporting method)(response_report) which is big		* Refactor reporting method(response_report) which is big
	* Use more efficient function sample instead of shuffle for random number selection		* Use more efficient function sample instead of shuffle for random number selection
	* Remove unused and assigned variables		* Remove unused and assigned variables

Skunapa at 20:28, 30 March 2016

2016-03-30T20:28:39Z

@@ Line 6: / Line 6: @@
 __TOC__
 =='''About Review mapping controller'''==
 Review mapping controller contains methods related to peer reviewing strategies. It contains methods to add a reviewer, delete a reviewer, selecting a reviewer. Depending on the number of students and number of submissions, the topics to be reviewed are assigned to the students automatically. If a user wants to look for the team for a submission , it returns the team by comparing the submission id's with the team id's. Also, it assigns quizzes dynamically. Generation of review report, feedback report and teammate review is done.
 =='''Code Improvements'''==

Ndhanir: /* Code Improvements */

2016-03-24T03:41:04Z

Code Improvements

← Older revision		Revision as of 03:41, 24 March 2016
Line 13:		Line 13:
	=='''Code Improvements'''==		=='''Code Improvements'''==

	==='''1. Unused variables and arguments'''===		==='''Unused variables and arguments'''===

	There are unused variables in the methods which use the stack unnecessarily. So, it is better to remove the unused variables or at the least indicate that a variable is unused.		There are unused variables in the methods which use the stack unnecessarily. So, it is better to remove the unused variables or at the least indicate that a variable is unused.
Line 28:		Line 28:
	In the above case teams_hash should consist of a hash with both keys and values but the sorting is done based on values. So the key is replaced with a "_" so that the user may deem it unused in the implementation of the process.		In the above case teams_hash should consist of a hash with both keys and values but the sorting is done based on values. So the key is replaced with a "_" so that the user may deem it unused in the implementation of the process.

	==='''2. Use sample instead of shuffle'''===		==='''Use sample instead of shuffle'''===

	When sample is used, the elements in an array are chosen by using random and unique indices in the array so that the elements doesn't repeat in the array. This cannot be guaranteed in shuffle. Also by using shuffle[0] we are shuffling all the elements in the array and then picking the first element instead of picking a single element randomly which is more efficient. The following are the couple of places where shuffle[0] was used and is replaced by sample.		When sample is used, the elements in an array are chosen by using random and unique indices in the array so that the elements doesn't repeat in the array. This cannot be guaranteed in shuffle. Also by using shuffle[0] we are shuffling all the elements in the array and then picking the first element instead of picking a single element randomly which is more efficient. The following are the couple of places where shuffle[0] was used and is replaced by sample.
Line 47:		Line 47:
	</pre>		</pre>

	==='''3. Cyclomatic complexity of automatic_review_mapping_strategy method'''===		==='''Cyclomatic complexity of automatic_review_mapping_strategy method'''===

	The method automatic_review_mapping_strategy handles the number of reviews assigned to a individual and also the number of reviews that can be done with in a team. The method is very long and has many nested if statements due to which the complexity of the method is very high. Instead of a single method handling all the parts of the strategy, it is divided into several parts due to which the code is more readable and also the complexity of code is shared by each method.		The method automatic_review_mapping_strategy handles the number of reviews assigned to a individual and also the number of reviews that can be done with in a team. The method is very long and has many nested if statements due to which the complexity of the method is very high. Instead of a single method handling all the parts of the strategy, it is divided into several parts due to which the code is more readable and also the complexity of code is shared by each method.