CSC/ECE 517 Spring 2016/E1720. UI issues/fixes - Revision history

Rmyers: /* Peer Review Information */

2017-03-31T22:25:19Z

Peer Review Information

← Older revision		Revision as of 22:25, 31 March 2017
Line 9:		Line 9:
	This project does compile. Reviewers will need to perform "rake db:migrate" as we've added a database table to support notifications.		This project does compile. Reviewers will need to perform "rake db:migrate" as we've added a database table to support notifications.

	The testing plan is at the end of this document. Design principles were not needed since we mostly modified existing work. However, issue #702 is using the Factory Method design pattern, and our work added content to the existing pattern.		The testing plan is at the end of this document. There were also specs added; however, they are in the Git repository. Design principles were not needed since we mostly modified existing work. However, issue #702 is using the Factory Method design pattern, and our work added content to the existing pattern.

	== Introduction ==		== Introduction ==

Rmyers: /* UI Testing */

2017-03-31T22:23:33Z

UI Testing

← Older revision		Revision as of 22:23, 31 March 2017
Line 341:		Line 341:
	The majority of the changes can be tested via the UI. Follow the instructions below to check the tasks:		The majority of the changes can be tested via the UI. Follow the instructions below to check the tasks:

			* '''Issue #702:''' Add another institution_id to course table and The Create Course page needs to be fixed to tell the creator to specify the institution (course/_course.html.erb).
			# Login as an instructor. It will automatically go to the manage courses page.
			# Click the "New Public Course" or "New Private Course" button.
			# You will notice a drop down for institutions is available.
			# Create a new course, and the UI will automatically return to the list which displays the courses. You will see the institution listed.
			# Click on the edit button and you will be able to modify the institution for the course.

	* ~~view_publishing_rights~~		* '''Issue #316:''' Remove "Actions" column on signup sheet in a completed assignment (sign_up_sheet/list.html.erb).
	# ~~Login as~~ a ~~instructor~~ (~~better to log in as an instructor that has assignments in the tree_desiplay view~~. ~~For eg~~. ~~instructor6~~)		# Log in as any user or instructor.
	# ~~Navigate 'Manage > Assignments'~~		# Go to the assignments list. Note: this is not the manage assignments for instructors.
	# ~~Against each assignment in~~ the ~~table, an icon~~ for ~~'view_publishing_rights' can be seen~~		# Click into a finished assignment. You will notice the actions column is gone.
	# Click ~~on the 'view_publishing_rights' icon against any assignment~~		# Click into a current assignment. You will notice the actions column appears.
	~~# If the~~ assignment ~~has topics (eg~~. ~~Wikipedia contribution),~~ the ~~table in the view will have 'Topic Name' and 'Topic #' displayed~~.
	# ~~If the~~ assignment ~~does not have topics, the table~~ will ~~not have~~ the ~~above two columns~~

	* ~~Topics import feature for~~ an assignment		* '''Issue #295:''' Add a confirmation on deleting an assignment on the admin screen (tree_display/actions/_shared_actions.html.rb).
	# In the ~~tree_display~~ view of assignments~~, click on the edit icon~~. ~~(Or while creating~~ a new assignment)		# Login as an instructor. It will automatically go to the manage courses page.
	# Click on '~~Topics~~' ~~tab~~		# Click the Assignments link to switch the view from courses to assignments.
	# ~~Click on~~ '~~Import topics~~'~~, towards~~ the ~~bottom~~ of the page		# Add a new assignment.
	# ~~Select a valid CSV file~~. The ~~first, second and third columns should be~~ the ~~topic identifier, topic name and number~~ of ~~slots available, respectively~~. Note ~~that~~ the ~~topic identifier should~~ be ~~more than 10 characters long~~, ~~else import will fail~~. ~~The CSV can have an optional 4th column for 'category' but this~~ is ~~displayed in the UI~~		# Click the delete button for an assignment. Note: please add an assignment first. Most of the current assignments have dependencies that prevent them from being deleted... this is not an error.
	# ~~In case of invalid CSV import, an error message~~ will be shown.		# The UI will be directed to a page to confirm the deletion. Select "Yes" if you wish to delete the assignment.

			* '''Issue #256:''' Add a one-time notification at the top of the page which links to an article on the details of the change (it might make sense to put a javascript module in the site_controllers/index.html.rb and let other pages call this).
			# Login as an instructor. It will automatically go to the manage courses page.
			# Click on the "Manage Notifications" link above the "Courses" and "Assignments" links. Note: The link was placed here because the system has numerous issues when adding menu items. It would require us to do more work that the entirety of this project to correct the menu additions in the superuser menu.
			# You will be directed to a creation page for notifications. Note: in order for a notification to display the expiration date must be the current date or later, and the active checkbox must be selected.
			# Log out once the notification is created.
			# Log in using any account. The notification will display on the first page the user is shown. It will disappear when they change or reload the page. Note: instructors on the management page will retain the notification if they switch between Assignments, Courses, and Questionnaires. This is because the JavaScript does not actually reload the page.

Rmyers: /* UI Testing */

2017-03-31T22:08:04Z

UI Testing

← Older revision		Revision as of 22:08, 31 March 2017
Line 339:		Line 339:
	== Testing Plan: Testing from the UI ==		== Testing Plan: Testing from the UI ==
	=== UI Testing ===		=== UI Testing ===
	~~Since~~ majority of the ~~tasks for this assignment was code refactoring, only a few of these~~ can be ~~seen and~~ tested ~~through~~ the UI. Follow the instructions below to check the:		The majority of the changes can be tested via the UI. Follow the instructions below to check the tasks:


	* view_publishing_rights		* view_publishing_rights
	# Login as a instructor (better to log in as an instructor that has assignments in the tree_desiplay view. For eg. instructor6)		# Login as a instructor (better to log in as an instructor that has assignments in the tree_desiplay view. For eg. instructor6)

Rmyers: /* Files Modified in this Project */

2017-03-31T22:01:48Z

Files Modified in this Project

← Older revision		Revision as of 22:01, 31 March 2017
Line 36:		Line 36:
	* app/views/notifications/index.html.erb		* app/views/notifications/index.html.erb
	* app/views/shared/_flash_notifications.html.erb		* app/views/shared/_flash_notifications.html.erb
			* app/view/sign_up_sheet/_table_line.html.erb
	* app/views/tree_display/list.html.erb		* app/views/tree_display/list.html.erb
	* app/views/tree_display/confirm.html.erb		* app/views/tree_display/confirm.html.erb

Rmyers: /* Issue #316: */

2017-03-31T22:01:18Z

Issue #316:

← Older revision		Revision as of 22:01, 31 March 2017
Line 160:		Line 160:
	=== Issue #316: ===		=== Issue #316: ===
	This task called for removing the 'Actions' column on the signup sheet for assignments that have been completed (sign_up_sheet/list.html.erb).		This task called for removing the 'Actions' column on the signup sheet for assignments that have been completed (sign_up_sheet/list.html.erb).


	~~Added a :stage value to pass the current stage when an assignment is selected from the assignments menu view '''app/view/student_task/index.html.erb'''.~~

	~~<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant, :stage => participant.assignment.current_stage_name(topic_id) %></b></td>~~



	~~Added a local variable to hold the passes stage value from the assignments menu view in '''app/controllers/sign_up_sheet_controller.rb''' list definition.~~

	~~def list~~
	~~@topic_id = params[:stage]~~
	~~end~~

Rmyers: /* Files Modified in this Project */

2017-03-31T21:59:13Z

Files Modified in this Project

← Older revision		Revision as of 21:59, 31 March 2017
Line 34:		Line 34:
	* app/views/course/_course.html.erb		* app/views/course/_course.html.erb
	* app/views/layouts/application.html.erb		* app/views/layouts/application.html.erb
	* app/views/~~notification~~/~~list~~.html.erb		* app/views/notifications/index.html.erb
	* app/views/shared/_flash_notifications.html.erb		* app/views/shared/_flash_notifications.html.erb
	* app/views/tree_display/list.html.erb		* app/views/tree_display/list.html.erb

Rmyers: /* Issue #256: */

2017-03-31T21:58:45Z

Issue #256:

← Older revision		Revision as of 21:58, 31 March 2017
Line 257:		Line 257:


	Using scaffolding, a new index was added '''app/view/~~notification~~/index.html.erb'''.		Using scaffolding, a new index was added '''app/view/notifications/index.html.erb'''.

	<pre>		<pre>
Line 294:		Line 294:


	Added link on page for managers to manage notifications '''app/view/tree_display/~~index~~.html.erb'''.		Added link on page for managers to manage notifications '''app/view/tree_display/list.html.erb'''.

	[[File:256.png]]		[[File:256.png]]

Rmyers: /* Files Modified in this Project */

2017-03-31T21:57:10Z

Files Modified in this Project

@@ Line 24: / Line 24: @@
 == Files Modified in this Project ==
 The following files were modified for this project.
 * app/assets/javascripts/tree_display.jsx
-* config/routes.rb
+* app/controllers/auth_controller.rb
-* spec/features/instructor_interface_spec.rb
+* app/controllers/course_controller.rb
-* spec/features/team_creation_spec.rb
+* app/controllers/tree_display_controller.rb
 == Solutions implemented and Delivered ==
 === Issue #702: ===

Rmyers: /* Testing from the UI */

2017-03-31T21:33:30Z

Testing from the UI

← Older revision		Revision as of 21:33, 31 March 2017
Line 346:		Line 346:
	<br>		<br>

	== Testing from the UI ==		== Testing Plan: Testing from the UI ==
	=== UI Testing ===		=== UI Testing ===
	Since majority of the tasks for this assignment was code refactoring, only a few of these can be seen and tested through the UI. Follow the instructions below to check the:		Since majority of the tasks for this assignment was code refactoring, only a few of these can be seen and tested through the UI. Follow the instructions below to check the:

Rmyers: /* Issue #316: */

2017-03-31T21:32:43Z

Issue #316:

← Older revision		Revision as of 21:32, 31 March 2017
Line 163:		Line 163:
	<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant, :stage => participant.assignment.current_stage_name(topic_id) %></b></td>		<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant, :stage => participant.assignment.current_stage_name(topic_id) %></b></td>



	Added a local variable to hold the passes stage value from the assignments menu view in '''app/controllers/sign_up_sheet_controller.rb''' list definition.		Added a local variable to hold the passes stage value from the assignments menu view in '''app/controllers/sign_up_sheet_controller.rb''' list definition.