CSC/ECE 517 Spring 2014/final doc updated qyx - Revision history

Qjia2: /* course_team.rb */

2014-04-29T17:25:20Z

course_team.rb

← Older revision		Revision as of 17:25, 29 April 2014
Line 71:		Line 71:
	* add_participant(course_id, user)method should belong to course rather than course_team. Delete this method.		* add_participant(course_id, user)method should belong to course rather than course_team. Delete this method.
	* self.export_all_assignment_team_related_to_course(csv, parent_id, options)method should be deleted.		* self.export_all_assignment_team_related_to_course(csv, parent_id, options)method should be deleted.

			=== teams_user.rb ===
			* ''delete'' method should not call ''team.delete'', comment out corresponding statements.
			* ''self.is_team_empty'' method should not call ''length'', replace corresponding statements with ''count'' method

			=== teams_users_controller.rb ===
			* ''delete_selected'' method mistake using ''find'' and ''first'', this method could not work. No test will be made on the method

	=== Possible Bugs ===		=== Possible Bugs ===

Qjia2: /* Concerns for Test Cases */

2014-04-29T17:20:04Z

Concerns for Test Cases

← Older revision		Revision as of 17:20, 29 April 2014
Line 123:		Line 123:
	[[File:TeamUsersStory.png]]		[[File:TeamUsersStory.png]]

			=== functional/teams_users_controller_test.rb ===
	Because most of the tests are straightforward, only tests with concerns are listed.		Because most of the tests are straightforward, only tests with concerns are listed.
	* Delete_select		* Delete_select

Qjia2: /* Concerns for Test Cases */

2014-04-29T17:19:27Z

Concerns for Test Cases

@@ Line 123: / Line 123: @@
 [[File:TeamUsersStory.png]]
-Based on the user story of the teams_users_controller.rb, there are also several sub-scenarios for each method in the user story.
+Because most of the tests are straightforward, only tests with concerns are listed.
 * Delete_select
-** Test Delete_select with valid item id
+** Please notice that this method will receive an ''item_id'' and delete the first team user belonging to that item
 === unit/teams_users_test.rb ===
+Only tests with concerns are listed.
 * Delete
-** Test Delete to check if it could delete the team node and the team user
+** Notice here we would not test if the method will delete team, only test if it could delete the team user
 === functional/advertise_for_partner_controller_test.rb ===

Qjia2: /* Possible Refactoring */

2014-04-29T17:10:08Z

Possible Refactoring

← Older revision		Revision as of 17:10, 29 April 2014
Line 216:		Line 216:
	=== teams_participant.rb & teams_participants_controller.rb ===		=== teams_participant.rb & teams_participants_controller.rb ===
	* These two files are never used, no tests will cover them.		* These two files are never used, no tests will cover them.

	~~=== teams_user.rb ===~~
	* In ''delete'' method, the statements about ''team.delete'' should be commented out due to the recursion it causes.
	* ''elf.is_team_empty'' method is rewritten since the original code will cause fatal error.

	~~=== teams_users_controller.rb ===~~
	* ''delete_select'' method will not work since the params are not in accordance with the method called inside.

	==Sample Test Code==		==Sample Test Code==

Qjia2: /* Possible Bugs */

2014-04-29T17:09:09Z

Possible Bugs

← Older revision		Revision as of 17:09, 29 April 2014
Line 85:		Line 85:
	* def add_participant(assignment_id, user)		* def add_participant(assignment_id, user)
	** the AssignmentParticipant.count does not increase. This is another failure from assignment_team_test.rb.		** the AssignmentParticipant.count does not increase. This is another failure from assignment_team_test.rb.
			==== teams_user.rb ====
			* def delete(option)
			** should not call ''team.delete'', it will cause recursion error
			* def self.is_team_empty(team_id)
			** rewrite this method without using ''length'' method, the ''length'' method will generate errors here
			==== teams_users_controller.rb ====
			* def delete_selected(options)
			** the statement ''TeamsUser.find(item_id).first'' cannot work, since the method ''find'' will return an exact object, which cannot be applied ''first'' method

	== Setup ==		== Setup ==

Xguo6 at 14:48, 29 April 2014

2014-04-29T14:48:20Z

← Older revision		Revision as of 14:48, 29 April 2014
Line 54:		Line 54:
	* duplicated def self.generate_team_name() was removed		* duplicated def self.generate_team_name() was removed
	** This is removed because the same method is defined again at line 131		** This is removed because the same method is defined again at line 131
			==== advertise_for_team_controller.rb ====
	=== advertise_for_team_controller.rb ===
	* def new was removed		* def new was removed
	** since it's empty, there is no need to keep the code there		** since it's empty, there is no need to keep the code there


	=== Possible Refactoring ===		=== Possible Refactoring ===

Xguo6 at 14:46, 29 April 2014

2014-04-29T14:46:30Z

← Older revision		Revision as of 14:46, 29 April 2014
Line 64:		Line 64:
	* line 81 def self.create_node_object(name, parent_id)		* line 81 def self.create_node_object(name, parent_id)
	** see the TODO at line 80, the method will not work.		** see the TODO at line 80, the method will not work.

	=== advertise_for_team_controller.rb ===		=== advertise_for_team_controller.rb ===
	* ''update'' should be ''edit'' (this is mentioned in the comments of code)		* ''update'' should be ''edit'' (this is mentioned in the comments of code)
	* ''edit'' should be reexamined since it is only assigning the team object		* ''edit'' should be reexamined since it is only assigning the team object
			=== assignment_team.rb ===
			* in "delete" method, before sign_up.each.destory, we need to make sure sign_up is not nil.
			* in "email" method, a method named get_team_users is called but this method has no definition. We should define get_team_users somewhere or delete "email" method.
			=== course_team.rb ===
			* add_participant(course_id, user)method should belong to course rather than course_team. Delete this method.
			* self.export_all_assignment_team_related_to_course(csv, parent_id, options)method should be deleted.

	=== Possible Bugs ===		=== Possible Bugs ===

Xguo6: /* Statistics */

2014-04-29T14:39:40Z

Statistics

← Older revision		Revision as of 14:39, 29 April 2014
Line 16:		Line 16:
	; Overall (set of 6 tests) : 105 tests, 156 assertions, 2 failures, 3060 / 13457 LOC (22.74%) covered.		; Overall (set of 6 tests) : 105 tests, 156 assertions, 2 failures, 3060 / 13457 LOC (22.74%) covered.
	; Unit tests : 18 tests, 18 assertions, 0 failures		; Unit tests : 18 tests, 18 assertions, 0 failures
	; Functional tests : 87 tests, 138 assertions, 2 failures (reasons of ~~failure~~ can be found in "Possible ~~bugs~~")		; Functional tests : 87 tests, 138 assertions, 2 failures (reasons of failures can be found in "Possible Bugs")

	== Running Tests ==		== Running Tests ==

Xguo6: /* Statistics */

2014-04-29T14:39:10Z

Statistics

← Older revision		Revision as of 14:39, 29 April 2014
Line 16:		Line 16:
	; Overall (set of 6 tests) : 105 tests, 156 assertions, 2 failures, 3060 / 13457 LOC (22.74%) covered.		; Overall (set of 6 tests) : 105 tests, 156 assertions, 2 failures, 3060 / 13457 LOC (22.74%) covered.
	; Unit tests : 18 tests, 18 assertions, 0 failures		; Unit tests : 18 tests, 18 assertions, 0 failures
	; Functional tests : 87 tests, 138 assertions, 2 failures		; Functional tests : 87 tests, 138 assertions, 2 failures (reasons of failure can be found in "Possible bugs")

	== Running Tests ==		== Running Tests ==

Xguo6: /* Possible Bugs */

2014-04-29T14:37:45Z

Possible Bugs

← Older revision		Revision as of 14:37, 29 April 2014
Line 78:		Line 78:
	* def import_team_members passing wrong arguments		* def import_team_members passing wrong arguments
	** it is calling add_member and passing nil for assignment_id, which will make rails raise error.[[#unit/team_test.rb\|Test: "import team members successfully" ]]		** it is calling add_member and passing nil for assignment_id, which will make rails raise error.[[#unit/team_test.rb\|Test: "import team members successfully" ]]
			==== assignment_team.rb ====
			* def self.get_export_fields(options)
			** when the option team_name => false, the second element of the output array should be "Team members". But from the test, it is "Assignment Name". This is one failure from assignment_team_test.rb
			* def add_participant(assignment_id, user)
			** the AssignmentParticipant.count does not increase. This is another failure from assignment_team_test.rb.

	== Setup ==		== Setup ==