CSC/ECE 517 Spring 2013/OSS E605B - Revision history

Jrwills2: /* Questionnaire Subclass Unit Tests */

2013-03-29T00:57:31Z

Questionnaire Subclass Unit Tests

← Older revision		Revision as of 00:57, 29 March 2013
Line 65:		Line 65:
	* teammate_review_questionnaire.rb		* teammate_review_questionnaire.rb

	As we reviewed the tests, it was found that most of the methods were trivial (ex: the method "symbol" ~~only~~ only returns a hardcoded symbol). The only method that was found to be worth testing was the get_weighted_score method. Upon further review, however, we found that testing this method in each of the four subclasses violated the DRY principle. Therefore, we moved the test to the superclass (questionnaire.rb) to test the "get_weighted_score" method.		As we reviewed the tests, it was found that most of the methods were trivial (ex: the method "symbol" only returns a hardcoded symbol). The only method that was found to be worth testing was the get_weighted_score method. Upon further review, however, we found that testing this method in each of the four subclasses violated the DRY principle. Therefore, we moved the test to the superclass (questionnaire.rb) to test the "get_weighted_score" method.

	=== Modifications to Existing Questionnaire Subclass Tests ===		=== Modifications to Existing Questionnaire Subclass Tests ===

2013-03-29T00:56:20Z

Testing - questionnaire

← Older revision		Revision as of 00:56, 29 March 2013
Line 3:		Line 3:

	[https://github.com/chunsingtsui/expertiza Project Github Repository]		[https://github.com/chunsingtsui/expertiza Project Github Repository]

			[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza Wiki]

	== QuestionnaireController Functional Tests ==		== QuestionnaireController Functional Tests ==

2013-03-29T00:54:19Z

Testing - questionnaire

← Older revision		Revision as of 00:54, 29 March 2013
Line 2:		Line 2:
	[https://docs.google.com/a/ncsu.edu/document/d/1SVNx7Eh6dUdrz2a9rGSgBxLkxAmuBUm8eu08nHEdjIg/edit# Project Description]		[https://docs.google.com/a/ncsu.edu/document/d/1SVNx7Eh6dUdrz2a9rGSgBxLkxAmuBUm8eu08nHEdjIg/edit# Project Description]

	[https://github.com/chunsingtsui/expertiza Project Repository ~~https://github.com/chunsingtsui/expertiza~~]		[https://github.com/chunsingtsui/expertiza Project Github Repository]

	== QuestionnaireController Functional Tests ==		== QuestionnaireController Functional Tests ==

2013-03-29T00:54:01Z

Testing - questionnaire

← Older revision		Revision as of 00:54, 29 March 2013
Line 2:		Line 2:
	[https://docs.google.com/a/ncsu.edu/document/d/1SVNx7Eh6dUdrz2a9rGSgBxLkxAmuBUm8eu08nHEdjIg/edit# Project Description]		[https://docs.google.com/a/ncsu.edu/document/d/1SVNx7Eh6dUdrz2a9rGSgBxLkxAmuBUm8eu08nHEdjIg/edit# Project Description]

	[https://github.com/chunsingtsui/expertiza Project Repository]		[https://github.com/chunsingtsui/expertiza Project Repository https://github.com/chunsingtsui/expertiza]

	== QuestionnaireController Functional Tests ==		== QuestionnaireController Functional Tests ==

2013-03-29T00:53:40Z

Testing - questionnaire

← Older revision		Revision as of 00:53, 29 March 2013
Line 1:		Line 1:
	=Testing - questionnaire=		=Testing - questionnaire=
	[https://docs.google.com/a/ncsu.edu/document/d/1SVNx7Eh6dUdrz2a9rGSgBxLkxAmuBUm8eu08nHEdjIg/edit# Project Description]		[https://docs.google.com/a/ncsu.edu/document/d/1SVNx7Eh6dUdrz2a9rGSgBxLkxAmuBUm8eu08nHEdjIg/edit# Project Description]

	[https://github.com/chunsingtsui/expertiza Project Repository]		[https://github.com/chunsingtsui/expertiza Project Repository]

2013-03-29T00:53:29Z

Testing - questionnaire

← Older revision		Revision as of 00:53, 29 March 2013
Line 1:		Line 1:
	=Testing - questionnaire=		=Testing - questionnaire=
	[https://docs.google.com/a/ncsu.edu/document/d/1SVNx7Eh6dUdrz2a9rGSgBxLkxAmuBUm8eu08nHEdjIg/edit# Project Description]		[https://docs.google.com/a/ncsu.edu/document/d/1SVNx7Eh6dUdrz2a9rGSgBxLkxAmuBUm8eu08nHEdjIg/edit# Project Description]
			[https://github.com/chunsingtsui/expertiza Project Repository]

	== QuestionnaireController Functional Tests ==		== QuestionnaireController Functional Tests ==

2013-03-21T14:58:43Z

Testing - questionnaire

← Older revision		Revision as of 14:58, 21 March 2013
Line 76:		Line 76:

	ruby -Itest test/unit/questionnaire_test.rb		ruby -Itest test/unit/questionnaire_test.rb

			=== VNC Server Information ===

			IP: 152.46.16.122:2
			Password: project517

	== General Information ==		== General Information ==

2013-03-21T02:00:18Z

Highlights of Project

← Older revision		Revision as of 02:00, 21 March 2013
Line 88:		Line 88:
	* Added functional tests for questionnaire controller		* Added functional tests for questionnaire controller
	* 24 total tests		* 24 total tests
	* The test that uses the "delete" action in the controller was failing due to a potential bug in the questionnaire.rb model class		* The test that uses the "delete" action in the controller was failing due to a potential bug in the questionnaire.rb model class (refer to ''Potential Bug'' section)

	=== List of files changed ===		=== List of files changed ===

2013-03-21T01:59:48Z

Potential Bug

← Older revision		Revision as of 01:59, 21 March 2013
Line 103:		Line 103:

	= Potential Bug =		= Potential Bug =
	The Questionnaire model class contains a ''has_many :assignment_questionnaire'' that should be ''has_many :assignment_questionnaire'''s''' '' according to convention. If ~~this~~ is ~~the case~~, then in the "compute_weighted_score" method, the ''self.assignemnt_questionnaire...'' call also needs to be changed to ''self.assignment_questionnaires...''. This most likely needs to be refactored, but we did not want to do a refactor without testing its effects on the system thoroughly.		The Questionnaire model class contains a ''has_many :assignment_questionnaire'' that should be ''has_many :assignment_questionnaire'''s''' '' according to convention. Because of this, our "delete" action test fails since it doesn't match the convention. If it is indeed incorrect, then in the "compute_weighted_score" method, the ''self.assignemnt_questionnaire...'' call also needs to be changed to ''self.assignment_questionnaires...''. This most likely needs to be refactored, but we did not want to do a refactor without testing its effects on the system thoroughly.

2013-03-21T01:50:56Z

NOTE

← Older revision		Revision as of 01:50, 21 March 2013
Line 102:		Line 102:
	*test/unit/teammate_review_questionnaire_test.rb		*test/unit/teammate_review_questionnaire_test.rb

	= ~~NOTE~~ =		= Potential Bug =
	The Questionnaire model class contains a ''has_many :assignment_questionnaire'' that should be ''has_many :assignment_questionnaire'''s''' '' according to convention. If this is the case, then in the "compute_weighted_score" method, the ''self.assignemnt_questionnaire...'' call also needs to be changed to ''self.assignment_questionnaires...''. This most likely needs to be refactored, but we did not want to do a refactor without testing its effects on the system thoroughly.		The Questionnaire model class contains a ''has_many :assignment_questionnaire'' that should be ''has_many :assignment_questionnaire'''s''' '' according to convention. If this is the case, then in the "compute_weighted_score" method, the ''self.assignemnt_questionnaire...'' call also needs to be changed to ''self.assignment_questionnaires...''. This most likely needs to be refactored, but we did not want to do a refactor without testing its effects on the system thoroughly.