CSC/ECE 517 Fall 2017/M1753 OffscreenCanvas API - Revision history

Wzhang43: Undo revision 112812 by Wzhang43 (talk)

2017-11-10T10:51:11Z

Undo revision 112812 by Wzhang43 (talk)

← Older revision		Revision as of 10:51, 10 November 2017
Line 44:		Line 44:

	:3. listing ''OffscreenCanvas.rs'' in ''components/script/dom/mod.rs'';		:3. listing ''OffscreenCanvas.rs'' in ''components/script/dom/mod.rs'';

			[[File:Createoffscreencanvas.png]]

	:4. defining the DOM struct OffscreenCanvas with a ''#[dom_struct]'' attribute, a superclass or Reflector member, and other members as appropriate;		:4. defining the DOM struct OffscreenCanvas with a ''#[dom_struct]'' attribute, a superclass or Reflector member, and other members as appropriate;

			[[File:Definedomstruct.png]]

	:5. implementing the ''dom::bindings::codegen::Bindings::OffsceenCanvasBindings::OffscreenCanvasMethods'' trait for OffscreenCanvas;		:5. implementing the ''dom::bindings::codegen::Bindings::OffsceenCanvasBindings::OffscreenCanvasMethods'' trait for OffscreenCanvas;

			[[File:Dombindings.png]]

	:6. adding/updating the match arm in create_element in ''components/script/dom/create.rs'' (only applicable to new types inheriting from HTMLElement)		:6. adding/updating the match arm in create_element in ''components/script/dom/create.rs'' (only applicable to new types inheriting from HTMLElement)
Line 55:		Line 61:
	:1. Hide the new interfaces by default by adding a ''[Pref="dom.offscreen_canvas.enabled"]'' attribute to each one and add a corresponding preference to ''resources/prefs.json''		:1. Hide the new interfaces by default by adding a ''[Pref="dom.offscreen_canvas.enabled"]'' attribute to each one and add a corresponding preference to ''resources/prefs.json''
	::* Add the attribute in file ''OffscreenCanvas'' and ''OffscreenCanvasRendering'':		::* Add the attribute in file ''OffscreenCanvas'' and ''OffscreenCanvasRendering'':
			[[File:Attribute.png]]
	::* Add the corresponding preference in ''prefs.json'':		::* Add the corresponding preference in ''prefs.json'':
			[[File:Attribute2.png]]

	===Step 3: Enable Tests ===		===Step 3: Enable Tests ===
Line 69:		Line 77:

	:3. Run tests and change expected results<ref>https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations</ref>.		:3. Run tests and change expected results<ref>https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations</ref>.
			[[File:preds.png]]

	===Step 4: Implement OffscreenCanvas Constructor===		===Step 4: Implement OffscreenCanvas Constructor===
Line 77:		Line 86:
	Implement the ''OffscreenCanvas.getContext'' ignoring the WebGL requirements:		Implement the ''OffscreenCanvas.getContext'' ignoring the WebGL requirements:
	canvas.getContext(contextType, contextAttributes);		canvas.getContext(contextType, contextAttributes);

	~~===Step 6: Extract all relevant canvas operations from CanvasRenderingContext2d===~~
	Extract all relevant canvas operations from CanvasRenderingContext2d into an implementation shared with OffscreenCanvasRenderingContext2d. Create a trait that abstracts away any operation that currently uses self.canvas in the 2d canvas rendering context, since the offscreen canvas rendering context has no associated <canvas> element

	~~===Step 7: Implement the convertToBlob API===~~
	~~Implement the convertToBlob API to allow testing the contents of the canvas~~

	~~===Step 8:Support offscreen webgl contexts in the 2d context===~~
	~~support offscreen webgl contexts in a similar fashion to the 2d context, by sharing relevant code between OffscreenCanvasRenderingContext2d and WebGLRenderingContext.~~

	== '''Testing Details''' ==		== '''Testing Details''' ==

Wzhang43: /* Implementation */

2017-11-10T10:50:05Z

Implementation

← Older revision		Revision as of 10:50, 10 November 2017
Line 44:		Line 44:

	:3. listing ''OffscreenCanvas.rs'' in ''components/script/dom/mod.rs'';		:3. listing ''OffscreenCanvas.rs'' in ''components/script/dom/mod.rs'';

	~~[[File:Createoffscreencanvas.png]]~~

	:4. defining the DOM struct OffscreenCanvas with a ''#[dom_struct]'' attribute, a superclass or Reflector member, and other members as appropriate;		:4. defining the DOM struct OffscreenCanvas with a ''#[dom_struct]'' attribute, a superclass or Reflector member, and other members as appropriate;

	~~[[File:Definedomstruct.png]]~~

	:5. implementing the ''dom::bindings::codegen::Bindings::OffsceenCanvasBindings::OffscreenCanvasMethods'' trait for OffscreenCanvas;		:5. implementing the ''dom::bindings::codegen::Bindings::OffsceenCanvasBindings::OffscreenCanvasMethods'' trait for OffscreenCanvas;

	~~[[File:Dombindings.png]]~~

	:6. adding/updating the match arm in create_element in ''components/script/dom/create.rs'' (only applicable to new types inheriting from HTMLElement)		:6. adding/updating the match arm in create_element in ''components/script/dom/create.rs'' (only applicable to new types inheriting from HTMLElement)
Line 61:		Line 55:
	:1. Hide the new interfaces by default by adding a ''[Pref="dom.offscreen_canvas.enabled"]'' attribute to each one and add a corresponding preference to ''resources/prefs.json''		:1. Hide the new interfaces by default by adding a ''[Pref="dom.offscreen_canvas.enabled"]'' attribute to each one and add a corresponding preference to ''resources/prefs.json''
	::* Add the attribute in file ''OffscreenCanvas'' and ''OffscreenCanvasRendering'':		::* Add the attribute in file ''OffscreenCanvas'' and ''OffscreenCanvasRendering'':
	~~[[File:Attribute.png]]~~
	::* Add the corresponding preference in ''prefs.json'':		::* Add the corresponding preference in ''prefs.json'':
	~~[[File:Attribute2.png]]~~

	===Step 3: Enable Tests ===		===Step 3: Enable Tests ===
Line 77:		Line 69:

	:3. Run tests and change expected results<ref>https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations</ref>.		:3. Run tests and change expected results<ref>https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations</ref>.
	~~[[File:preds.png]]~~

	===Step 4: Implement OffscreenCanvas Constructor===		===Step 4: Implement OffscreenCanvas Constructor===
Line 86:		Line 77:
	Implement the ''OffscreenCanvas.getContext'' ignoring the WebGL requirements:		Implement the ''OffscreenCanvas.getContext'' ignoring the WebGL requirements:
	canvas.getContext(contextType, contextAttributes);		canvas.getContext(contextType, contextAttributes);

			===Step 6: Extract all relevant canvas operations from CanvasRenderingContext2d===
			Extract all relevant canvas operations from CanvasRenderingContext2d into an implementation shared with OffscreenCanvasRenderingContext2d. Create a trait that abstracts away any operation that currently uses self.canvas in the 2d canvas rendering context, since the offscreen canvas rendering context has no associated <canvas> element

			===Step 7: Implement the convertToBlob API===
			Implement the convertToBlob API to allow testing the contents of the canvas

			===Step 8:Support offscreen webgl contexts in the 2d context===
			support offscreen webgl contexts in a similar fashion to the 2d context, by sharing relevant code between OffscreenCanvasRenderingContext2d and WebGLRenderingContext.

	== '''Testing Details''' ==		== '''Testing Details''' ==

Jsarava at 18:55, 4 November 2017

2017-11-04T18:55:12Z

← Older revision		Revision as of 18:55, 4 November 2017
Line 127:		Line 127:

	== '''Pull Request''' ==		== '''Pull Request''' ==
	Here is our [https://github.com/servo/servo/pull/~~19012~~ pull request]. In the link you can see all code snippets changed due to implementing the above steps, as well as integration test progression information.		Here is our [https://github.com/servo/servo/pull/19067 pull request]. In the link you can see all code snippets changed due to implementing the above steps, as well as integration test progression information.

	== '''Future Work''' ==		== '''Future Work''' ==

Wzhang43: /* Step 3: Enable Tests */

2017-10-27T22:53:41Z

Step 3: Enable Tests

← Older revision		Revision as of 22:53, 27 October 2017
Line 78:		Line 78:
	:3. Run tests and change expected results<ref>https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations</ref>.		:3. Run tests and change expected results<ref>https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations</ref>.
	[[File:preds.png]]		[[File:preds.png]]


	===Step 4: Implement OffscreenCanvas Constructor===		===Step 4: Implement OffscreenCanvas Constructor===

Wzhang43: /* Step 4: Implement OffscreenCanvas Constructor */

2017-10-27T22:53:18Z

Step 4: Implement OffscreenCanvas Constructor

← Older revision		Revision as of 22:53, 27 October 2017
Line 83:		Line 83:
	Create a new OffscreenCanvas by implementing the following Syntax:		Create a new OffscreenCanvas by implementing the following Syntax:
	var offscreen = new OffscreenCanvas(256, 256);		var offscreen = new OffscreenCanvas(256, 256);



	===Step 5: Implement the getContext() method for OffscreenCanvas element ===		===Step 5: Implement the getContext() method for OffscreenCanvas element ===

Wzhang43: /* Step 1: Create Interfaces */

2017-10-27T22:53:04Z

Step 1: Create Interfaces

← Older revision		Revision as of 22:53, 27 October 2017
Line 56:		Line 56:

	:6. adding/updating the match arm in create_element in ''components/script/dom/create.rs'' (only applicable to new types inheriting from HTMLElement)		:6. adding/updating the match arm in create_element in ''components/script/dom/create.rs'' (only applicable to new types inheriting from HTMLElement)



	===Step 2: Hide newly created interfaces by default ===		===Step 2: Hide newly created interfaces by default ===

Wzhang43: /* Step 2: Hide newly created interfaces by default */

2017-10-27T22:52:38Z

Step 2: Hide newly created interfaces by default

← Older revision		Revision as of 22:52, 27 October 2017
Line 66:		Line 66:
	::* Add the corresponding preference in ''prefs.json'':		::* Add the corresponding preference in ''prefs.json'':
	[[File:Attribute2.png]]		[[File:Attribute2.png]]



	===Step 3: Enable Tests ===		===Step 3: Enable Tests ===

Wzhang43: /* Pull Request */

2017-10-27T22:51:34Z

Pull Request

← Older revision		Revision as of 22:51, 27 October 2017
Line 134:		Line 134:

	== '''Pull Request''' ==		== '''Pull Request''' ==
			Here is our [https://github.com/servo/servo/pull/19012 pull request]. In the link you can see all code snippets changed due to implementing the above steps, as well as integration test progression information.

	== '''Future Work''' ==		== '''Future Work''' ==

Wzhang43: /* Testing Details */

2017-10-27T22:48:22Z

Testing Details

← Older revision		Revision as of 22:48, 27 October 2017
Line 95:		Line 95:

	== '''Testing Details''' ==		== '''Testing Details''' ==
	* '''Building'''		:'''1. Building'''

	Servo is built with the Rust package manager, [https://crates.io/ Cargo].		Servo is built with the Rust package manager, [https://crates.io/ Cargo].
Line 117:		Line 117:
	</code>		</code>

	* '''Testing'''		:'''2. Testing'''

	Servo provides automated tests, adding the <code>--release</code> flag to create an optimized build:		Servo provides automated tests, adding the <code>--release</code> flag to create an optimized build:

Wzhang43: /* Step 5: Implement the getContext() method for OffscreenCanvas element */

2017-10-27T22:47:33Z

Step 5: Implement the getContext() method for OffscreenCanvas element

← Older revision		Revision as of 22:47, 27 October 2017
Line 87:		Line 87:
	Create a new OffscreenCanvas by implementing the following Syntax:		Create a new OffscreenCanvas by implementing the following Syntax:
	var offscreen = new OffscreenCanvas(256, 256);		var offscreen = new OffscreenCanvas(256, 256);



	===Step 5: Implement the getContext() method for OffscreenCanvas element ===		===Step 5: Implement the getContext() method for OffscreenCanvas element ===