CSC/ECE 517 Fall 2017/E1769 Refactor assignment form.rb - Revision history

Xgong6: /* References */

2017-10-28T02:18:35Z

References

← Older revision		Revision as of 02:18, 28 October 2017
Line 183:		Line 183:

	==References ==		==References ==
			Youtube: [https://youtu.be/F1WQDdmUQDk]

2017-10-27T20:41:45Z

Modified File

← Older revision		Revision as of 20:41, 27 October 2017
Line 12:		Line 12:

	== Modified File ==		== Modified File ==
			* Refactor the assignment.rb
	* Refactor the assignment_form.rb		* Refactor the assignment_form.rb
	* Refactor the assignment.rb
	* Complete relating tests in assignment_form_rspec.rb and assignment.rb		* Complete relating tests in assignment_form_rspec.rb and assignment.rb
	* Complete tests in sign_up_sheet_controller_rspec.rb		* Complete tests in sign_up_sheet_controller_rspec.rb

2017-10-27T20:34:36Z

Refactor `add_to_delayed_queue` method

← Older revision		Revision as of 20:34, 27 October 2017
Line 19:		Line 19:
	== Refactor ==		== Refactor ==
	=== Refactor `add_to_delayed_queue` method ===		=== Refactor `add_to_delayed_queue` method ===
	`add_to_delayed_queue` is a long method with some duplicate codes. In order to encourage code reuse and make it easier to understand semantics of the function, we split it into three methods, name the added two as `get_diff_from_now` and `add_delayed_job`. The changes are displayed below,		`add_to_delayed_queue` is a long method with some duplicate codes and hard to understand. In order to encourage code reuse and make it easier to understand semantics of the function, we split it into three methods, name the added two as `get_diff_from_now` and `add_delayed_job`. The changes are displayed below,

	Original Code:		Original Code:

2017-10-27T20:33:53Z

Refactor `add_to_delayed_queue` method

← Older revision		Revision as of 20:33, 27 October 2017
Line 19:		Line 19:
	== Refactor ==		== Refactor ==
	=== Refactor `add_to_delayed_queue` method ===		=== Refactor `add_to_delayed_queue` method ===
	`add_to_delayed_queue` is long method with duplicate codes. So we split it into three methods, name the added two as `get_diff_from_now` and `add_delayed_job`.		`add_to_delayed_queue` is a long method with some duplicate codes. In order to encourage code reuse and make it easier to understand semantics of the function, we split it into three methods, name the added two as `get_diff_from_now` and `add_delayed_job`. The changes are displayed below,
	~~For example~~, ~~we changed this method.~~

	Original Code:		Original Code:

2017-10-27T20:30:02Z

Rename method 'is_calibrated?' to 'calibrated?' and all other places it is used

← Older revision		Revision as of 20:30, 27 October 2017
Line 93:		Line 93:

	=== Rename method 'is_calibrated?' to 'calibrated?' and all other places it is used ===		=== Rename method 'is_calibrated?' to 'calibrated?' and all other places it is used ===
	We refactorer this method by using 'Refactor' operation in RubyMine. We renamed it to 'calibrated?' and RubyMine found all place it appeared then changed them.		In Ruby, the common naming pattern for a method which return a boolean value is an adjective followed by '?', so the method name 'is_calibrated?' is bad and a preferable one should be directly 'calibrated?'. We refactorer this method by using 'Refactor' operation in RubyMine. We renamed it to 'calibrated?' and RubyMine found all place it appeared then changed them.

	Before:		Before:

2017-10-27T20:12:40Z

@@ Line 16: / Line 16: @@
 * Complete relating tests in assignment_form_rspec.rb and assignment.rb
 * Complete tests in sign_up_sheet_controller_rspec.rb
 == Refactor ==
@@ Line 190: / Line 182: @@
    Randomized with seed 58167
 ==References ==

2017-10-27T19:05:38Z

Rspec Test

← Older revision		Revision as of 19:05, 27 October 2017
Line 171:		Line 171:
	expect(assignment.calibrated?).to be(true)		expect(assignment.calibrated?).to be(true)
	end		end
	~~end~~

	context 'when assignment is not calibrated' do		context 'when assignment is not calibrated' do
Line 178:		Line 177:
	expect(assignment.calibrated?).to be(false)		expect(assignment.calibrated?).to be(false)
	end		end
	~~end~~
	~~end~~

	We also completed remaining tests in `sign_up_sheet_controller_spec.rb`. There are a lot of methods in `sign_up_sheet_controller.rb`, and it can be executed by 'rspec spec/controllers/sign_up_sheet_controllers_spec.rb'		We also completed remaining tests in `sign_up_sheet_controller_spec.rb`. There are a lot of methods in `sign_up_sheet_controller.rb`, and it can be executed by 'rspec spec/controllers/sign_up_sheet_controllers_spec.rb'

2017-10-27T19:05:07Z

Rspec Test

← Older revision		Revision as of 19:05, 27 October 2017
Line 150:		Line 150:
	end		end
	end		end
	~~end~~

	Next we test `change_item_type` method		Next we test `change_item_type` method

2017-10-27T18:25:55Z

Rspec Test

← Older revision		Revision as of 18:25, 27 October 2017
Line 185:		Line 185:

	~/expertiza$ rspec spec/controllers/sign_up_sheet_controller_spec.rb		~/expertiza$ rspec spec/controllers/sign_up_sheet_controller_spec.rb

	...		...
	~~...~~
	Finished in 6.1 seconds (files took 7.16 seconds to load)		Finished in 6.1 seconds (files took 7.16 seconds to load)
	27 examples, 0 failures		27 examples, 0 failures

2017-10-27T18:25:22Z

Rspec Test

← Older revision		Revision as of 18:25, 27 October 2017
Line 189:		Line 189:
	Finished in 6.1 seconds (files took 7.16 seconds to load)		Finished in 6.1 seconds (files took 7.16 seconds to load)
	27 examples, 0 failures		27 examples, 0 failures

	Randomized with seed 58167		Randomized with seed 58167