CSC/ECE 517 Fall 2017/E1750 Refactor review mapping controller.rb - Revision history

Nwen: /* Examples of Refactoring */

2017-11-07T00:50:33Z

Examples of Refactoring

← Older revision		Revision as of 00:50, 7 November 2017
Line 183:		Line 183:

	=== Examples of Refactoring ===		=== Examples of Refactoring ===
	Response Report method had different switch statement testing different conditions. We split it into simpler method in different model to achieve a better cohesive in our code. We place different portions of code in models that related to their function. Updated the test after the code is completed.		Response Report method had different switch statement testing different conditions. We split it into simpler method in different model to achieve a better cohesive in our code. We place different portions of code in models that related to their function. By just calling the corresponding method decreased the length of the review mapping controller. Updated the test after the code is completed.

	def response_report		def response_report

Nwen: /* Examples of Refactoring */

2017-11-07T00:47:44Z

Examples of Refactoring

← Older revision		Revision as of 00:47, 7 November 2017
Line 223:		Line 223:

	*Original Code		*Original Code
	def response_report
			def response_report
	# Get the assignment id and set it in an instance variable which will be used in view		# Get the assignment id and set it in an instance variable which will be used in view
	@id = params[:id]		@id = params[:id]
Line 287:		Line 288:
	@user_pastebins = UserPastebin.get_current_user_pastebin current_user		@user_pastebins = UserPastebin.get_current_user_pastebin current_user
	end		end


			for example this portion of the code summarizes the reviews of each reviewee by each rubric criterion. Which is placed in the summary class with a method name def self.response_report_by_review_and_criteria.
			when "SummaryByRevieweeAndCriteria"
			sum = SummaryHelper::Summary.new.summarize_reviews_by_reviewees(@assignment, summary_ws_url)
			@summary = sum.summary
			@reviewers = sum.reviewers
			@avg_scores_by_reviewee = sum.avg_scores_by_reviewee
			@avg_scores_by_round = sum.avg_scores_by_round
			@avg_scores_by_criterion = sum.avg_scores_by_criterion

	= Result =		= Result =

Nwen: /* Examples of Refactoring */

2017-11-07T00:44:07Z

Examples of Refactoring

Nwen: /* Examples of Refactoring */

2017-11-07T00:43:34Z

Examples of Refactoring

← Older revision		Revision as of 00:43, 7 November 2017
Line 141:		Line 141:
	redirect_to action: 'list_mappings', id: assignment_id		redirect_to action: 'list_mappings', id: assignment_id
	end		end

	def team_size (teams, max_team_size)		def team_size (teams, max_team_size)
	if teams.empty? and max_team_size == 1		if teams.empty? and max_team_size == 1
Line 154:		Line 153:
	end		end
	end		end

	def artifacts_num (calibrated_artifacts_num, uncalibrated_artifacts_num, student_review_num, submission_review_num, teams)		def artifacts_num (calibrated_artifacts_num, uncalibrated_artifacts_num, student_review_num, submission_review_num, teams)
	if calibrated_artifacts_num == 0 and uncalibrated_artifacts_num == 0		if calibrated_artifacts_num == 0 and uncalibrated_artifacts_num == 0
Line 173:		Line 171:
	end		end
	end		end

	def review_num (student_review_num, submission_review_num, teams)		def review_num (student_review_num, submission_review_num, teams)
	if student_review_num == 0 and submission_review_num == 0		if student_review_num == 0 and submission_review_num == 0
Line 184:		Line 181:
	end		end
	end		end


	=== Examples of Refactoring ===		=== Examples of Refactoring ===

Nwen: /* Examples of Refactoring */

2017-11-07T00:43:09Z

Examples of Refactoring

@@ Line 223: / Line 223: @@
        @responses = Response.where(map_id: @review_response_map_ids)
      end
      @user_pastebins = UserPastebin.get_current_user_pastebin current_user
    end

Nwen: /* Examples of Refactoring */

2017-11-07T00:41:16Z

Examples of Refactoring

← Older revision		Revision as of 00:41, 7 November 2017
Line 189:		Line 189:
	Response Report method had different switch statement testing different conditions. We split it into simpler method in different model to achieve a better cohesive in our code. We place different portions of code in models that related to their function. Updated the test after the code is completed.		Response Report method had different switch statement testing different conditions. We split it into simpler method in different model to achieve a better cohesive in our code. We place different portions of code in models that related to their function. Updated the test after the code is completed.

	def response_report		def response_report
	# Get the assignment id and set it in an instance variable which will be used in view		# Get the assignment id and set it in an instance variable which will be used in view
	@id = params[:id]		@id = params[:id]

Nwen: /* Examples of Refactoring */

2017-11-07T00:40:57Z

Examples of Refactoring

@@ Line 183: / Line 183: @@
        flash[:error] = "Please choose either the number of reviews per student or the number of reviewers per team (student), not both."
      end
    end

Nwen: /* Steps to Follow */

2017-11-07T00:35:24Z

Steps to Follow

← Older revision		Revision as of 00:35, 7 November 2017
Line 13:		Line 13:
	* Complete pending tests in review_mapping_controller_spec.rb, and write integration tests for newly-created methods.		* Complete pending tests in review_mapping_controller_spec.rb, and write integration tests for newly-created methods.
	* Refactor automatic_review_mapping method		* Refactor automatic_review_mapping method

			* Refactor response_report method

	* Use find_by instead of dynamic method (L135)		* Use find_by instead of dynamic method (L135)

Nwen: /* Steps to Follow */

2017-11-02T21:51:15Z

Steps to Follow

← Older revision		Revision as of 21:51, 2 November 2017
Line 13:		Line 13:
	* Complete pending tests in review_mapping_controller_spec.rb, and write integration tests for newly-created methods.		* Complete pending tests in review_mapping_controller_spec.rb, and write integration tests for newly-created methods.
	* Refactor automatic_review_mapping method		* Refactor automatic_review_mapping method

	* Refactor response_report method

	* Use find_by instead of dynamic method (L135)		* Use find_by instead of dynamic method (L135)

Nwen: /* Steps to Follow */

2017-11-02T21:37:36Z

Steps to Follow

← Older revision		Revision as of 21:37, 2 November 2017
Line 16:		Line 16:
	* Refactor response_report method		* Refactor response_report method

	* Use find_by instead of dynamic method		* Use find_by instead of dynamic method (L135)

	* Use sort_by(&:name) instead of sort { \|a, b\| a.name <=> b.name }		* Use sort_by(&:name) instead of sort { \|a, b\| a.name <=> b.name } (L275)

	= List of Changes =		= List of Changes =

← Older revision		Revision as of 00:44, 7 November 2017
Line 243:		Line 243:
	when "SummaryByCriteria"		when "SummaryByCriteria"
	sum = SummaryHelper::Summary.new.summarize_reviews_by_criterion(@assignment, summary_ws_url)		sum = SummaryHelper::Summary.new.summarize_reviews_by_criterion(@assignment, summary_ws_url)

	@summary = sum.summary		@summary = sum.summary
	@avg_scores_by_round = sum.avg_scores_by_round		@avg_scores_by_round = sum.avg_scores_by_round
Line 275:		Line 274:
	@review_response_map_ids = ReviewResponseMap.select('id').where(reviewed_object_id: params[:id], calibrate_to: 0)		@review_response_map_ids = ReviewResponseMap.select('id').where(reviewed_object_id: params[:id], calibrate_to: 0)
	@responses = Response.where(map_id: @review_response_map_ids)		@responses = Response.where(map_id: @review_response_map_ids)

	when "PlagiarismCheckerReport"		when "PlagiarismCheckerReport"
	@plagiarism_checker_comparisons = PlagiarismCheckerComparison.where(plagiarism_checker_assignment_submission_id:		@plagiarism_checker_comparisons = PlagiarismCheckerComparison.where(plagiarism_checker_assignment_submission_id:
	PlagiarismCheckerAssignmentSubmission.where(assignment_id:		PlagiarismCheckerAssignmentSubmission.where(assignment_id:
	params[:id]).pluck(:id))		params[:id]).pluck(:id))
	when "AnswerTaggingReport"		when "AnswerTaggingReport"
	tag_prompt_deployments = TagPromptDeployment.where(assignment_id: params[:id])		tag_prompt_deployments = TagPromptDeployment.where(assignment_id: params[:id])

	@questionnaire_tagging_report = {}		@questionnaire_tagging_report = {}

	tag_prompt_deployments.each do \|tag_dep\|		tag_prompt_deployments.each do \|tag_dep\|
	@questionnaire_tagging_report[tag_dep] = tag_dep.assignment_tagging_progress		@questionnaire_tagging_report[tag_dep] = tag_dep.assignment_tagging_progress
	end		end
	end		end

	@user_pastebins = UserPastebin.get_current_user_pastebin current_user		@user_pastebins = UserPastebin.get_current_user_pastebin current_user
	end		end