CSC/ECE 517 Fall 2017/E1749 questionnaire controller.rb refactor - Revision history

Dbhanda: Blanked the page

2017-10-28T02:16:53Z

Blanked the page

Dbhanda: /* Tasks assigned */

2017-10-28T01:48:10Z

Tasks assigned

← Older revision		Revision as of 01:48, 28 October 2017
Line 43:		Line 43:
	#* Use polymorphism to replace the long switch statements		#* Use polymorphism to replace the long switch statements
	#** Move if conditions to corresponding subclasses (eg. MultipleChoiceCheckbox.rb, MultipleChoiceRadio.rb) with same method name		#** Move if conditions to corresponding subclasses (eg. MultipleChoiceCheckbox.rb, MultipleChoiceRadio.rb) with same method name
	##* Replace the conditional with the relevant method calls		#** Replace the conditional with the relevant method calls
	##* Remove duplicated code		#** Remove duplicated code
	# Use find_by instead of dynamic method		# Use find_by instead of dynamic method
	#* Write failing tests first		#* Write failing tests first

Dbhanda: /* Tasks assigned */

2017-10-28T01:47:54Z

Tasks assigned

← Older revision		Revision as of 01:47, 28 October 2017
Line 42:		Line 42:
	#* Write failing tests first.		#* Write failing tests first.
	#* Use polymorphism to replace the long switch statements		#* Use polymorphism to replace the long switch statements
	##* Move if conditions to corresponding subclasses (eg. MultipleChoiceCheckbox.rb, MultipleChoiceRadio.rb) with same method name		#** Move if conditions to corresponding subclasses (eg. MultipleChoiceCheckbox.rb, MultipleChoiceRadio.rb) with same method name
	##* Replace the conditional with the relevant method calls		##* Replace the conditional with the relevant method calls
	##* Remove duplicated code		##* Remove duplicated code

Dbhanda: /* Tasks assigned */

2017-10-28T01:47:10Z

Tasks assigned

← Older revision		Revision as of 01:47, 28 October 2017
Line 40:		Line 40:
	#* Extract duplicated code into separate methods		#* Extract duplicated code into separate methods
	# Refactor update_quiz, save_choices method		# Refactor update_quiz, save_choices method
	:* Write failing tests first.		#* Write failing tests first.
	:* Use polymorphism to replace the long switch statements		#* Use polymorphism to replace the long switch statements
	::* Move if conditions to corresponding subclasses (eg. MultipleChoiceCheckbox.rb, MultipleChoiceRadio.rb) with same method name		##* Move if conditions to corresponding subclasses (eg. MultipleChoiceCheckbox.rb, MultipleChoiceRadio.rb) with same method name
	::* Replace the conditional with the relevant method calls		##* Replace the conditional with the relevant method calls
	::* Remove duplicated code		##* Remove duplicated code
	# Use find_by instead of dynamic method		# Use find_by instead of dynamic method
	:* Write failing tests first		#* Write failing tests first
	:* L68, L385, L386, L559, L560		#* L68, L385, L386, L559, L560

	== Tasks Completed ==		== Tasks Completed ==

Dbhanda: /* Tasks assigned */

2017-10-28T01:46:43Z

Tasks assigned

← Older revision		Revision as of 01:46, 28 October 2017
Line 36:		Line 36:
	# Complete pending tests in questionnaires_controller_spec.rb, and write integration tests for newly-created methods. Please finish one set of pending tests first before refactoring corresponding methods.		# Complete pending tests in questionnaires_controller_spec.rb, and write integration tests for newly-created methods. Please finish one set of pending tests first before refactoring corresponding methods.
	# Refactor create method		# Refactor create method
	:* Write failing tests first		#* Write failing tests first
	:* Split into several simpler methods and assign reasonable names		#* Split into several simpler methods and assign reasonable names
	:* Extract duplicated code into separate methods		#* Extract duplicated code into separate methods
	# Refactor update_quiz, save_choices method		# Refactor update_quiz, save_choices method
	:* Write failing tests first.		:* Write failing tests first.

Dbhanda: /* Tasks assigned */

2017-10-28T01:45:40Z

Tasks assigned

← Older revision		Revision as of 01:45, 28 October 2017
Line 34:		Line 34:

	== Tasks assigned ==		== Tasks assigned ==
	# Complete pending tests in questionnaires_controller_spec.rb, and write integration tests for newly-created methods. Please finish one set of pending tests first before refactoring corresponding methods. ~~<br>~~		# Complete pending tests in questionnaires_controller_spec.rb, and write integration tests for newly-created methods. Please finish one set of pending tests first before refactoring corresponding methods.
	# Refactor create method ~~<br>~~		# Refactor create method
	:* Write failing tests first ~~<br>~~		:* Write failing tests first
	:* Split into several simpler methods and assign reasonable names ~~<br>~~		:* Split into several simpler methods and assign reasonable names
	:* Extract duplicated code into separate methods ~~<br>~~		:* Extract duplicated code into separate methods
	# Refactor update_quiz, save_choices method ~~<br>~~		# Refactor update_quiz, save_choices method
	:* Write failing tests first. ~~<br>~~		:* Write failing tests first.
	:* Use polymorphism to replace the long switch statements ~~<br>~~		:* Use polymorphism to replace the long switch statements
	::* Move if conditions to corresponding subclasses (eg. MultipleChoiceCheckbox.rb, MultipleChoiceRadio.rb) with same method name ~~<br>~~		::* Move if conditions to corresponding subclasses (eg. MultipleChoiceCheckbox.rb, MultipleChoiceRadio.rb) with same method name
	::* Replace the conditional with the relevant method calls ~~<br>~~		::* Replace the conditional with the relevant method calls
	::* Remove duplicated code ~~<br>~~		::* Remove duplicated code
	# Use find_by instead of dynamic method ~~<br>~~		# Use find_by instead of dynamic method
	:* Write failing tests first ~~<br>~~		:* Write failing tests first
	:* L68, L385, L386, L559, L560 ~~<br>~~		:* L68, L385, L386, L559, L560

	== Tasks Completed ==		== Tasks Completed ==

Dbhanda: /* Tasks assigned */

2017-10-28T01:44:41Z

Tasks assigned

← Older revision		Revision as of 01:44, 28 October 2017
Line 34:		Line 34:

	== Tasks assigned ==		== Tasks assigned ==
	1) Complete pending tests in questionnaires_controller_spec.rb, and write integration tests for newly-created methods. Please finish one set of pending tests first before refactoring corresponding methods. <br>		# Complete pending tests in questionnaires_controller_spec.rb, and write integration tests for newly-created methods. Please finish one set of pending tests first before refactoring corresponding methods. <br>
	2) Refactor create method <br>		# Refactor create method <br>
	:o Write failing tests first <br>		:* Write failing tests first <br>
	:o Split into several simpler methods and assign reasonable names <br>		:* Split into several simpler methods and assign reasonable names <br>
	:o Extract duplicated code into separate methods <br>		:* Extract duplicated code into separate methods <br>
	3) Refactor update_quiz, save_choices method <br>		# Refactor update_quiz, save_choices method <br>
	:o Write failing tests first. <br>		:* Write failing tests first. <br>
	:o Use polymorphism to replace the long switch statements <br>		:* Use polymorphism to replace the long switch statements <br>
	:: Move if conditions to corresponding subclasses (eg. MultipleChoiceCheckbox.rb, MultipleChoiceRadio.rb) with same method name <br>		::* Move if conditions to corresponding subclasses (eg. MultipleChoiceCheckbox.rb, MultipleChoiceRadio.rb) with same method name <br>
	:: Replace the conditional with the relevant method calls <br>		::* Replace the conditional with the relevant method calls <br>
	:: Remove duplicated code <br>		::* Remove duplicated code <br>
	4) Use find_by instead of dynamic method <br>		# Use find_by instead of dynamic method <br>
	:o Write failing tests first <br>		:* Write failing tests first <br>
	:o L68, L385, L386, L559, L560 <br>		:* L68, L385, L386, L559, L560 <br>

	== Tasks Completed ==		== Tasks Completed ==

Dbhanda: /* Issues */

2017-10-28T01:43:41Z

Issues

← Older revision		Revision as of 01:43, 28 October 2017
Line 29:		Line 29:
	==Issues==		==Issues==

	* questionnaires_controller.rb is a fairly complex file. <br>		:* questionnaires_controller.rb is a fairly complex file. <br>
	* It contains a lot of methods that are long and hard to understand, these methods need to be broken down into simpler and more specific methods that are easier to read/understand. <br>		:* It contains a lot of methods that are long and hard to understand, these methods need to be broken down into simpler and more specific methods that are easier to read/understand. <br>
	* Also, the few instances of code duplication that exist should be removed.		:* Also, the few instances of code duplication that exist should be removed.

	== Tasks assigned ==		== Tasks assigned ==

Dbhanda: /* Files involved */

2017-10-28T01:42:50Z

Files involved

← Older revision		Revision as of 01:42, 28 October 2017
Line 24:		Line 24:
	== Files involved==		== Files involved==

	# questionnaire_controller.rb ~~<br>~~		# questionnaire_controller.rb
	# questionnaire_controller_spec.rb		# questionnaire_controller_spec.rb

Dbhanda: /* Files involved and Issues in them */

2017-10-28T01:42:14Z

Files involved and Issues in them

← Older revision		Revision as of 01:42, 28 October 2017
Line 22:		Line 22:
	:Password: password <br>		:Password: password <br>

	== Files involved ~~and Issues in them~~==		== Files involved==

	# questionnaire_controller.rb <br>		# questionnaire_controller.rb <br>
	# questionnaire_controller_spec.rb		# questionnaire_controller_spec.rb

			==Issues==

	* questionnaires_controller.rb is a fairly complex file. <br>		* questionnaires_controller.rb is a fairly complex file. <br>