CSC/ECE 517 Fall 2016/E1643. Refactor Suggestion controller - Revision history

Smagapu: /* Working in UI */

2016-12-11T02:26:03Z

Working in UI

← Older revision		Revision as of 02:26, 11 December 2016
Line 285:		Line 285:
	# Now to instructor account and view suggestions against the assignment created		# Now to instructor account and view suggestions against the assignment created
	# The instructor can approve or decline		# The instructor can approve or decline
	# Open the gmail account (id: expertiza.development@gmail.com, password: qwer@1234) and look for mail if approved		# Open the gmail account (id: expertiza.development@gmail.com, password: qwer@1234) and look for mail if approved.

			This can be verified through the uploaded videos on [https://www.youtube.com/watch?v=TOhofFEjgcM&feature=youtu.be tests] and [https://vimeo.com/190331266 functioning].

	== Conclusions ==		== Conclusions ==

Amajumd at 01:13, 11 December 2016

2016-12-11T01:13:36Z

← Older revision		Revision as of 01:13, 11 December 2016
Line 192:		Line 192:

	We have considered Student2064 for this case. We test for all the following cases:		We have considered Student2064 for this case. We test for all the following cases:
	* ~~When~~ Student2064 logs in, visits Assignment 1, clicks on new suggestion and submits a new topic. Upon submitting the topic, a page with the content saying "Thank you for your suggestion! Suggested topics for Assignment 1, "Topic title" initiated", should be rendered.		* Student2064 logs in, visits Assignment 1, clicks on new suggestion and submits a new topic. Upon submitting the topic, a page with the content saying "Thank you for your suggestion! Suggested topics for Assignment 1, "Topic title" initiated", should be rendered.
	* And if view is clicked, a page with the content "View Suggested topic Computer Vision" is displayed.		* And if view is clicked, a page with the content "View Suggested topic Computer Vision" is displayed.
	* Adding a comment - Tests the case when a student submits the comment and whether a page with successful submission is resulted.		* Adding a comment - Tests the case when a student submits the comment and whether a page with successful submission is resulted.

Smagapu: /* Scenario 6 - Suggestion with no Signup approved */

2016-12-10T23:58:24Z

Scenario 6 - Suggestion with no Signup approved

← Older revision		Revision as of 23:58, 10 December 2016
Line 258:		Line 258:

	==== Scenario 6 - Suggestion with no Signup approved ====		==== Scenario 6 - Suggestion with no Signup approved ====
			The scenario comprises of testing the following steps:
	The Student2064 logs in and visits Assignment 1 to suggest “Computer Vision” topic. After suggesting, the student selects “No” for suggestion signup preference and submits suggestion. The Instructor6 logs in, visits Assignment 1 suggestions to ~~approves~~ suggestion “Computer Vision”. On approving the ~~instructor~~, a page saying "suggestion approved successfully" is rendered.		* The Student2064 logs in and visits Assignment 1 to suggest “Computer Vision” topic.
			* After suggesting, the student selects “No” for suggestion signup preference and submits suggestion.
			* The Instructor6 logs in, visits Assignment 1 suggestions to approve the suggestion “Computer Vision”.
			* On approving the suggestion, a page saying "suggestion approved successfully" is rendered for the instructor.

	=== Why these scenarios? ===		=== Why these scenarios? ===

Smagapu: /* Scenario 5 - Suggestion Voted */

2016-12-10T23:55:13Z

Scenario 5 - Suggestion Voted

← Older revision		Revision as of 23:55, 10 December 2016
Line 255:		Line 255:
	* Instructor6 logs in and should be able to check that “Computer Vision” is submitted by student2064 for Assignment 1.		* Instructor6 logs in and should be able to check that “Computer Vision” is submitted by student2064 for Assignment 1.
	* After checking the comment by student2064, Instructor votes for the suggestion.		* After checking the comment by student2064, Instructor votes for the suggestion.
	* Then~~, when~~ the Student2064 logs in, visits Assignment 1 to check that Instructor6 has voted for the suggestion.		* Then the Student2064 logs in, visits Assignment 1 to check that Instructor6 has voted for the suggestion.

	==== Scenario 6 - Suggestion with no Signup approved ====		==== Scenario 6 - Suggestion with no Signup approved ====

Smagapu: /* Scenario 5 - Suggestion Voted */

2016-12-10T23:54:53Z

Scenario 5 - Suggestion Voted

← Older revision		Revision as of 23:54, 10 December 2016
Line 251:		Line 251:

	==== Scenario 5 - Suggestion Voted ====		==== Scenario 5 - Suggestion Voted ====
	~~The~~ Student2064 logs in and suggests a topic (Computer Vision) under Assignment 1. Instructor6 logs in~~, checks~~ that “Computer Vision” is submitted by student2064 ~~fro~~ Assignment 1. After checking the comment by student2064, Instructor votes for the suggestion. Then when the Student2064 logs in, visits Assignment 1 to check that Instructor6 has voted for the suggestion.		This scenario accounts for testing the following steps:
			* Student2064 logs in and suggests a topic (Computer Vision) under Assignment 1.
			* Instructor6 logs in and should be able to check that “Computer Vision” is submitted by student2064 for Assignment 1.
			* After checking the comment by student2064, Instructor votes for the suggestion.
			* Then, when the Student2064 logs in, visits Assignment 1 to check that Instructor6 has voted for the suggestion.

	==== Scenario 6 - Suggestion with no Signup approved ====		==== Scenario 6 - Suggestion with no Signup approved ====

Smagapu: /* Scenario 4 - Suggestion Rejected */

2016-12-10T23:53:39Z

Scenario 4 - Suggestion Rejected

← Older revision		Revision as of 23:53, 10 December 2016
Line 244:		Line 244:

	==== Scenario 4 - Suggestion Rejected====		==== Scenario 4 - Suggestion Rejected====
	~~When~~ Student2064 logs in and suggests a topic (Computer Vision) under Assignment 1. The Instructor6 logs in to check that “Computer Vision” is submitted by student2064 ~~fro~~ Assignment 1. After checking the comment by student2064, Instructor6 rejects the suggestion. The Student2064 logs in, visits Assignment 1 to find out that the suggestion “Computer Vision” has been rejected.		The steps mentioned below are tested in this scenario:
			* Student2064 logs in and suggests a topic (Computer Vision) under Assignment 1.
			* The Instructor6 logs in to check that “Computer Vision” is submitted by student2064 for Assignment 1.
			* After checking the comment by student2064, Instructor6 rejects the suggestion.
			* The Student2064 logs in, visits Assignment 1 to find out that the suggestion “Computer Vision” has been rejected.

	==== Scenario 5 - Suggestion Voted ====		==== Scenario 5 - Suggestion Voted ====

Smagapu: /* Scenario 3 - Suggestion Accepted */

2016-12-10T23:52:41Z

Scenario 3 - Suggestion Accepted

← Older revision		Revision as of 23:52, 10 December 2016
Line 235:		Line 235:

	==== Scenario 3 - Suggestion Accepted====		==== Scenario 3 - Suggestion Accepted====
	Student2064 logs in and suggests a topic (Computer Vision) under Assignment 1. Instructor6 logs in and checks on Assignment 1. After logging in, instructor checks that “Computer Vision” is submitted by student2064 ~~and also~~ the comment by the student. After looking at the topic, the instructor approves the suggestion. ~~When~~ Student2064 logs in and visits Assignment 1, he/she can check that the suggestion “Computer Vision” has been accepted.		This scenario accounts for the testing the following:
			* Student2064 logs in and suggests a topic (Computer Vision) under Assignment 1.
			* Instructor6 logs in and checks on Assignment 1.
			* After logging in, instructor checks that “Computer Vision” is submitted by student2064
			* Also the comment by the student can be viewed.
			* After looking at the topic, the instructor approves the suggestion.
			* Then, when the Student2064 logs in and visits Assignment 1, he/she can check that the suggestion “Computer Vision” has been accepted.

	==== Scenario 4 - Suggestion Rejected====		==== Scenario 4 - Suggestion Rejected====

Smagapu: /* Scenario 1 - Check suggested topics */

2016-12-10T23:51:07Z

Scenario 1 - Check suggested topics

← Older revision		Revision as of 23:51, 10 December 2016
Line 172:		Line 172:

	==== Scenario 1 - Check suggested topics====		==== Scenario 1 - Check suggested topics====
	This test case ~~is to test automatically~~ the ~~situation when~~ the instructor ~~once logged in can visit~~ the ~~suggested~~ topics ~~page~~ for ~~any~~ Assignment 1.		This automatic test case checks the following steps:
			* User (Instructor6) logins in.
			* On successful login, the instructor clicks the tab for Suggestions list for a particular assignment (Assignment 1).
			* On visiting that tab, a page with content "Suggested topics for Assignment 1" is rendered with the topic name.

	<pre>		<pre>

Smagapu: /* Refactoring */

2016-12-10T23:04:50Z

Refactoring

← Older revision		Revision as of 23:04, 10 December 2016
Line 141:		Line 141:
	* Comments were added for future readability.		* Comments were added for future readability.

	~~Notice~~ that there was nothing more in terms of refactoring, as the code has been already refactored.		Note that there was nothing more in terms of refactoring, as the code has been already refactored.

	=== '''Email functionality''' ===		=== '''Email functionality''' ===

Smagapu: /* Refactoring */

2016-12-10T23:04:41Z

Refactoring

← Older revision		Revision as of 23:04, 10 December 2016
Line 133:		Line 133:

	==='''Refactoring''' ===		==='''Refactoring''' ===
	There were lot of trailing spaces in the code, which are removed. Few lines were too long and one had to scroll right to go through that line. This was taken care of. We have ~~also~~ edited the messages, making them more ~~readable and logical~~. Also, the unused ~~methods in the code~~ were ~~removed~~.		Refactoring that was done for this project is:
			* There were lot of trailing spaces in the code, which are removed.
			* Few lines were too long and one had to scroll right to go through that line. This was taken care of as shown below.
			[[File:Oss_1.PNG]]
			* We have edited the flash messages making them more intuitive. Also, the subject of the email that is sent has been modified to keep it more self-explanatory.
			* An unused method, "confirm_save" has been removed.
			* Comments were added for future readability.

	~~The comments were added for future readability~~.		Notice that there was nothing more in terms of refactoring, as the code has been already refactored.

	~~[[File:Oss_1.PNG]]~~

	=== '''Email functionality''' ===		=== '''Email functionality''' ===