CSC/ECE 517 Fall 2016/E1641. Refactor review mapping controller.rb - Revision history

Gyu9: /* Refactor delete_all_reviewer */

2016-11-05T07:20:45Z

Refactor delete_all_reviewer

← Older revision		Revision as of 07:20, 5 November 2016
Line 298:		Line 298:
	end		end
	mmappings = response_map.where(id_symbol => id)		mmappings = response_map.where(id_symbol => id)

	failedCount = ResponseMap.delete_mappings(mmappings, params[:force])		failedCount = ResponseMap.delete_mappings(mmappings, params[:force])
	if failedCount > 0		if failedCount > 0

Gyu9: /* Refactor add_reviewer */

2016-11-05T07:20:23Z

Refactor add_reviewer

← Older revision		Revision as of 07:20, 5 November 2016
Line 252:		Line 252:
	msg = $ERROR_INFO		msg = $ERROR_INFO
	end		end
	end		end

	== Refactor delete_reviewer ==		== Refactor delete_reviewer ==

Gyu9: /* Refactor add_reviewer */

2016-11-05T07:20:05Z

Refactor add_reviewer

← Older revision		Revision as of 07:20, 5 November 2016
Line 202:		Line 202:
	redirect_to action: 'list_mappings', id: assignment_id, msg: msg		redirect_to action: 'list_mappings', id: assignment_id, msg: msg
	end		end

	def create_reviewer(object)		def create_reviewer(object)
	begin		begin

Gyu9: /* Refactor add_reviewer */

2016-11-05T07:19:28Z

Refactor add_reviewer

← Older revision		Revision as of 07:19, 5 November 2016
Line 178:		Line 178:

	== Refactor add_reviewer ==		== Refactor add_reviewer ==
			def add_reviewer
	def add_reviewer
	msg = ''		msg = ''
	case params[:object]		case params[:object]
Line 194:		Line 193:
	assignment_id = assignment.id		assignment_id = assignment.id
	SignUpSheet.signup_team(assignment.id, user_id, topic_id)		SignUpSheet.signup_team(assignment.id, user_id, topic_id)

	create_reviewer(assignment)		create_reviewer(assignment)
	end		end
Line 204:		Line 202:
	redirect_to action: 'list_mappings', id: assignment_id, msg: msg		redirect_to action: 'list_mappings', id: assignment_id, msg: msg
	end		end
			def create_reviewer(object)
	def create_reviewer(object)
	begin		begin
	user = User.from_params(params)		user = User.from_params(params)

Gyu9: /* Refactor */

2016-11-05T07:18:21Z

Refactor

Show changes

Gyu9 at 07:12, 5 November 2016

2016-11-05T07:12:59Z

← Older revision		Revision as of 07:12, 5 November 2016
Line 176:		Line 176:
	participants, participants_hash)		participants, participants_hash)
	end		end

			== Refactor==

	=Test=		=Test=

Gyu9: /* Changes Implemented */

2016-11-05T07:11:05Z

Changes Implemented

← Older revision		Revision as of 07:11, 5 November 2016
Line 17:		Line 17:

	=Changes Implemented=		=Changes Implemented=
	# Merged add_reviewer and add_metareviewer to add_reviewer. Merged delete_reviewer and delete_metareviewer to delete_reviewer. Modified delete_all_metareviewer to delete_all_reviewer.		# Merged add_reviewer and add_metareviewer to add_reviewer. Merged delete_reviewer and delete_metareviewer to delete_reviewer. Modified delete_all_metareviewer to delete_all_reviewer. Based on the TA's requirement, we implemented this part on the other GitHub pull request. https://github.com/expertiza/expertiza/pull/836
	# Change the rails query from sql like code, like ReviewResponseMap.where(['reviewee_id = ? and reviewer_id = ? ', params[:contributor_id], reviewer.id]) to more rails quey like ReviewResponseMap.where(reviewee_id: params[:contributor_id],reviewer_id: reviewer.id)		# Change the rails query from sql like code, like ReviewResponseMap.where(['reviewee_id = ? and reviewer_id = ? ', params[:contributor_id], reviewer.id]) to more rails quey like ReviewResponseMap.where(reviewee_id: params[:contributor_id],reviewer_id: reviewer.id)
	# We search the function name(''add_user_to_assignment'') in the whole files, and find that this method is invoked in "participants_helper.rb", and also being invoked in the function of ''add_reviewer'' and ''add_metareviewer'' in the controller of ''review_mapping_controller''		# We search the function name(''add_user_to_assignment'') in the whole files, and find that this method is invoked in "participants_helper.rb", and also being invoked in the function of ''add_reviewer'' and ''add_metareviewer'' in the controller of ''review_mapping_controller''

Gyu9: /* Test */

2016-11-05T07:08:19Z

Test

← Older revision		Revision as of 07:08, 5 November 2016
Line 178:		Line 178:

	=Test=		=Test=
			# We test Refactor of add_reviewer, add_metareviewer, delete_reviewer, delete_metareviewer and delete_all_reviewer both from UI and Rspec. Here is a link of the UI test.https://www.youtube.com/watch?v=c9UdTnwlyvM. Also, you can check the code of this pull request. https://github.com/expertiza/expertiza/pull/836
	# We test delete_outstanding_reviewers refactor from the UI. Here is a video for this test. https://youtu.be/MZxOaSsm58E		# We test delete_outstanding_reviewers refactor from the UI. Here is a video for this test. https://youtu.be/MZxOaSsm58E
	# We use some data to test the result of old query and new query in rails console		# We use some data to test the result of old query and new query in rails console

Gyu9: /* Changes Implemented */

2016-11-05T07:01:39Z

Changes Implemented

← Older revision		Revision as of 07:01, 5 November 2016
Line 17:		Line 17:

	=Changes Implemented=		=Changes Implemented=
			# Merged add_reviewer and add_metareviewer to add_reviewer. Merged delete_reviewer and delete_metareviewer to delete_reviewer. Modified delete_all_metareviewer to delete_all_reviewer.
	# ~~change~~ the rails query from sql like code, like ReviewResponseMap.where(['reviewee_id = ? and reviewer_id = ? ', params[:contributor_id], reviewer.id]) to more rails quey like ReviewResponseMap.where(reviewee_id: params[:contributor_id],reviewer_id: reviewer.id)		# Change the rails query from sql like code, like ReviewResponseMap.where(['reviewee_id = ? and reviewer_id = ? ', params[:contributor_id], reviewer.id]) to more rails quey like ReviewResponseMap.where(reviewee_id: params[:contributor_id],reviewer_id: reviewer.id)
	# We search the function name(''add_user_to_assignment'') in the whole files, and find that this method is invoked in "participants_helper.rb", and also being invoked in the function of ''add_reviewer'' and ''add_metareviewer'' in the controller of ''review_mapping_controller''		# We search the function name(''add_user_to_assignment'') in the whole files, and find that this method is invoked in "participants_helper.rb", and also being invoked in the function of ''add_reviewer'' and ''add_metareviewer'' in the controller of ''review_mapping_controller''
	# By searching the whole project and routes, we verify that methods ''add_self_reviewer'' and ''get_team_from_submission'' in this controller are not called by any other methods except for views "show_available_submissions_for_quizzes.html.erb" and "show_available_submissions.html.erb". And those two views are not linked to any other views. So they are deleted from the project.		# By searching the whole project and routes, we verify that methods ''add_self_reviewer'' and ''get_team_from_submission'' in this controller are not called by any other methods except for views "show_available_submissions_for_quizzes.html.erb" and "show_available_submissions.html.erb". And those two views are not linked to any other views. So they are deleted from the project.

Gyu9: /* Current Implementation and Problems */

2016-11-05T06:39:40Z

Current Implementation and Problems

← Older revision		Revision as of 06:39, 5 November 2016
Line 7:		Line 7:

	The problems are:		The problems are:
			# The class has functionality for five different kinds of Responses: reviews, metareviews, teammate reviews, author feedback (“rejoinders”), and quizzes. Method names for dealing with the 5 different kinds of objects should be as similar as possible, and they should share helper functions when possible.
	# Method ''response_report'' has some SQL - like code. Rewrite with Active Record.		# Method ''response_report'' has some SQL - like code. Rewrite with Active Record.
	# Test whether method ''add_user_to_assignment'' is used. There is no way that this method should be in ReviewMappingController. Please remove this method and caller.		# Test whether method ''add_user_to_assignment'' is used. There is no way that this method should be in ReviewMappingController. Please remove this method and caller.