CSC/CSC 517 Spring 2017/oss E1718 - Revision history

Vhegde: formatting change

2017-03-23T23:05:51Z

formatting change

← Older revision		Revision as of 23:05, 23 March 2017
Line 170:		Line 170:
	* At this point, first and second students' submission has two reviews and third student's submission has zero review.		* At this point, first and second students' submission has two reviews and third student's submission has zero review.
	* Now, log in as the fourth student and review, you should be allowed to review all three artifacts instead of just the one with least reviews.		* Now, log in as the fourth student and review, you should be allowed to review all three artifacts instead of just the one with least reviews.


	'''402'''		'''402'''

Vhegde: Manual testing for 228

2017-03-23T23:05:16Z

Manual testing for 228

← Older revision		Revision as of 23:05, 23 March 2017
Line 162:		Line 162:

	'''228'''		'''228'''
			* Log in as instructor(user:instructor6) and create a new assignment and add four students to the assignment(user:student360,student361,student362,student364).
			* Log in as student, submit an artifact. (e.g:a test link)
			* Log in as second student and submit an artifact.
			* Log in as first student and review an artifact, since there is only one other submission at this point, second student's submission is up for review.
			* Log in as second student and review an artifact.
			* Now, log in as third student, submit an artifact and also do two reviews, naturally you would be reviewing first and second student's submissions.
			* At this point, first and second students' submission has two reviews and third student's submission has zero review.
			* Now, log in as the fourth student and review, you should be allowed to review all three artifacts instead of just the one with least reviews.

	'''402'''		'''402'''

Vhegde: formatting change

2017-03-23T22:59:27Z

formatting change

← Older revision		Revision as of 22:59, 23 March 2017
Line 44:		Line 44:

	'''Issue 228'''		'''Issue 228'''

	According to this issue, the reviewers, having reviewed the submission with the fewest outstanding reviews, can't review any other submission until the submission they've just reviewed catches up to other submissions in number of reviews. Reviewers who have already reviewed the submission with the fewest reviews should be able to review the submission with the next fewest reviews, regardless of what the threshold is. Solution to this would be, every time a student requests for review, setup a proper filtering process with appropriate thresholds.		According to this issue, the reviewers, having reviewed the submission with the fewest outstanding reviews, can't review any other submission until the submission they've just reviewed catches up to other submissions in number of reviews. Reviewers who have already reviewed the submission with the fewest reviews should be able to review the submission with the next fewest reviews, regardless of what the threshold is. Solution to this would be, every time a student requests for review, setup a proper filtering process with appropriate thresholds.

Vhegde: Editing for issue 228

2017-03-23T22:58:52Z

Editing for issue 228

@@ Line 44: / Line 44: @@
 '''Issue 228'''
 '''Issue 402'''
@@ Line 141: / Line 155: @@
 '''
 == Manual Testing ==
 '''

Crajase: Added manual test information

2017-03-23T20:47:00Z

Added manual test information

← Older revision		Revision as of 20:47, 23 March 2017
Line 159:		Line 159:

	'''417'''		'''417'''
			*Log in as an instructor
			*go to edit page of an assignment and navigate to Review Strategy tab.
			*Change the allowed and required field of reviews and meta-reviews.
			*Try giving greater value for required field than allowed field. It should throw an error stating the relevant message.
			*Give the correct value and save it.
			*Sign in as a student who has enrolled for that particular assignment.
			*go to "others" page.
			*The allowed and required field are displayed saying that the assignment requires atleast k reviews.
			*If meta-review is enabled for that topic then the meta-review information is also displayed.
	'''		'''

Crajase: Added Validation information and its corresponding test.

2017-03-23T20:41:20Z

Added Validation information and its corresponding test.

← Older revision		Revision as of 20:41, 23 March 2017
Line 105:		Line 105:

	</pre>		</pre>
			These variables are viewable at "others" page for each assignment in students account, and settable at "edit assignment" page, "review_strategy" tab in instructor's account. The instructor are allowed to choose whether they want upper bound on number of reviews (num_reviews && num_metareviews_allowed) by clicking check box. By this way, the instructor can allow students to review as many submission as possible but grading only required number of reviews.

	These variables are viewable at "others" page for each assignment in students account, and settable at "edit assignment" page, "review_strategy" tab in instructor's account. The instructor are allowed to choose whether they want upper bound on number of reviews (num_reviews && num_metareviews_allowed) by clicking check box. By this way, the instructor can allow students to review as many submission as possible but grading only required number of reviews.

			Validations are done by checking whether the number of reviews required is less than number of reviews allowed. i.e.) num_reviews_required <= num_reviews_allowed. Similarly for condition follows for meta reviews. These validation are done in assignment.rb file and are executed before an update is saved into database.
			<pre>
			class Assignment < ActiveRecord::Base
			validate :valid_num_review
			def valid_num_review
			if(self.num_reviews && self.num_reviews != -1 && self.num_reviews < self.num_reviews_required)
			self.errors.add(:message, "Num of reviews required cannot be greater than number of reviews allowed")
			elsif(self.num_metareviews_allowed && self.num_metareviews_allowed != -1 && self.num_metareviews_allowed < self.num_metareviews_required)
			self.errors.add(:message, "Number of Meta-Reviews required cannot be greater than number of meta-reviews allowed")
			end
			end
			end
			</pre>
			Here num_reviews and num_metareviews_allowed are negative when the upper bound for reivews are infinity.

			The corresponding tests are written in assignment_spec.rb
			<pre>
			it "check whether assignment doesnot accept required value greater than allowed value - Review" do
			@assignment.num_reviews = 1
			@assignment.num_reviews_required = 3
			expect(@assignment).not_to be_valid
			end

			it "check whether assignment doesnot accept required value greater than allowed value - Meta-Review" do
			@assignment.num_metareviews_allowed = 1
			@assignment.num_metareviews_required = 3
			expect(@assignment).not_to be_valid
			end
			</pre>
			The first test checks whether num_reviews accepts values less than num_reviews_required for which the validation should fail.
			The Second test checks whether num_metareviews_allowed accepts values less than num_metareviews_required for which the validation should fail too.

	'''		'''

Crajase: Information of View and set portion of these variables.

2017-03-23T20:24:00Z

Information of View and set portion of these variables.

← Older revision		Revision as of 20:24, 23 March 2017
Line 76:		Line 76:

	'''Issue 417'''		'''Issue 417'''
	The 4 variables, num_reviews, num_reviews_required, num_metareviews_required and num_metareviews_allowed, are added to the assignment table using rails migration. ~~These~~ variables are ~~viewable at others page for each assignment in students account~~.
			The 4 variables - num_reviews, num_reviews_required, num_metareviews_required and num_metareviews_allowed - are added to the assignment table using rails migration. The default of these variables are set to 3.

	<pre>		<pre>
Line 104:		Line 105:

	</pre>		</pre>

			These variables are viewable at "others" page for each assignment in students account, and settable at "edit assignment" page, "review_strategy" tab in instructor's account. The instructor are allowed to choose whether they want upper bound on number of reviews (num_reviews && num_metareviews_allowed) by clicking check box. By this way, the instructor can allow students to review as many submission as possible but grading only required number of reviews.



	'''		'''

Crajase: Added Database entries for new variables

2017-03-23T20:14:47Z

Added Database entries for new variables

← Older revision		Revision as of 20:14, 23 March 2017
Line 76:		Line 76:

	'''Issue 417'''		'''Issue 417'''
			The 4 variables, num_reviews, num_reviews_required, num_metareviews_required and num_metareviews_allowed, are added to the assignment table using rails migration. These variables are viewable at others page for each assignment in students account.

			<pre>
			class AddNumReviewsRequiredToAssignments < ActiveRecord::Migration
			def change
			add_column :assignments, :num_reviews_required, :integer, :default => 3
			end
			end

			class AddNumReviewsToAssignments < ActiveRecord::Migration
			def change
			change_column :assignments, :num_reviews, :integer, :default => 3
			end
			end

			class AddNumMetareviewsRequiredToAssignments < ActiveRecord::Migration
			def change
			add_column :assignments, :num_metareviews_required, :integer, :default => 3
			end
			end

			class AddNumMetareviewsAllowedToAssignments < ActiveRecord::Migration
			def change
			add_column :assignments, :num_metareviews_allowed, :integer, :default => 3
			end
			end

			</pre>

	'''		'''

Rpmee: /* Manual Testing */

2017-03-22T21:54:33Z

Manual Testing

← Older revision		Revision as of 21:54, 22 March 2017
Line 86:		Line 86:

	'''402'''		'''402'''
	1. Log in with an instructor.		*Log in with an instructor.
			*Create an assignment with topics to choose from.
	2. Create an assignment with topics to choose from.		*Log in with a student.
			*Sign up for one of the topics from the previously created assignment.
	3. Log in with a student.		*Submit an assignment for that topic.
			*Go to the Others' Work tab.
	4. Sign up for one of the topics from the previously created assignment.		*Attempt to select that topic for review -OR- Check the box for "I Don't Care"
			*Attempt to request review
	5. Submit an assignment for that topic.

	6. Go to the Others' Work tab.

	7. Attempt to select that topic for review -OR- Check the box for "I Don't Care"

	8. Attempt to request review

Rpmee: /* Manual Testing */

2017-03-22T21:53:56Z

Manual Testing

← Older revision		Revision as of 21:53, 22 March 2017
Line 87:		Line 87:
	'''402'''		'''402'''
	1. Log in with an instructor.		1. Log in with an instructor.

	2. Create an assignment with topics to choose from.		2. Create an assignment with topics to choose from.

	3. Log in with a student.		3. Log in with a student.

	4. Sign up for one of the topics from the previously created assignment.		4. Sign up for one of the topics from the previously created assignment.

	5. Submit an assignment for that topic.		5. Submit an assignment for that topic.

	6. Go to the Others' Work tab.		6. Go to the Others' Work tab.

	7. Attempt to select that topic for review -OR- Check the box for "I Don't Care"		7. Attempt to select that topic for review -OR- Check the box for "I Don't Care"

	8. Attempt to request review		8. Attempt to request review


	'''417'''		'''417'''

	'''		'''

	== References ==		== References ==
	'''		'''