CSC/CSC 517 Fall 2017/ProjectPurple - Revision history

Ralwan at 23:10, 2 November 2017

2017-11-02T23:10:49Z

← Older revision		Revision as of 23:10, 2 November 2017
Line 13:		Line 13:

	===Issue Fix===		===Issue Fix===
	A working demo of the fixed issues can be found [https://youtu.be/ysVeHlrlKo8 here].		A working demo of the fixed issues can be found [https://youtu.be/ysVeHlrlKo8 here]. The changed code can be found in the pull request made [https://github.com/expertiza/expertiza/pull/1033 here].

	The first two actions of enabling and disabling metareviews show the fixed issue #961. The action of reducing the rounds of reviews shows our fix to issue #972.		The first two actions of enabling and disabling metareviews show the fixed issue #961. The action of reducing the rounds of reviews shows our fix to issue #972.

Ralwan at 23:10, 2 November 2017

2017-11-02T23:10:02Z

← Older revision		Revision as of 23:10, 2 November 2017
Line 48:		Line 48:

	====To replicate issue [https://github.com/expertiza/expertiza/issues/972 #972]====		====To replicate issue [https://github.com/expertiza/expertiza/issues/972 #972]====
			# Go to the edit action in the assignments controller. (http://localhost:3000/assignments/(#assignment_id)/edit)
	1. Go to the edit action in the assignments controller. (http://localhost:3000/assignments/(#assignment_id)/edit)		# Click on the due dates tab.
	2. Click on the due dates tab.		# Change number of rounds of reviews to a value less than 3. (At this stage, our fix would throw a confirmation message with a warning)
	3. Change number of rounds of reviews to a value less than 3. (At this stage, our fix would throw a confirmation message with a warning)		# Upon pressing submit, the rounds of reviews will not be updated. (In our fix, the rounds of reviews will only change upon accepting the confirmation)
	4. Upon pressing submit, the rounds of reviews will not be updated. (In our fix, the rounds of reviews will only change upon accepting the confirmation)

	====To replicate issue [https://github.com/expertiza/expertiza/issues/961 #961]====		====To replicate issue [https://github.com/expertiza/expertiza/issues/961 #961]====

	1. Go to the edit action in the assignments controller. (http://localhost:3000/assignments/(#assignment_id)/edit)		# Go to the edit action in the assignments controller. (http://localhost:3000/assignments/(#assignment_id)/edit)
	2. Click on the due dates tab.		# Click on the due dates tab.
	3. Uncheck the metareviews allowed checkbox.		# Uncheck the metareviews allowed checkbox.
	4. Upon submission, the update will not be visible. (Our fix would allow this action and the update will be visible)		# Upon submission, the update will not be visible. (Our fix would allow this action and the update will be visible)

	===References===		===References===

Ralwan at 23:09, 2 November 2017

2017-11-02T23:09:31Z

← Older revision		Revision as of 23:09, 2 November 2017
Line 44:		Line 44:

	After realizing that the issue was caused by the cascade action not being implemented, implementing it was the way to go. After the implementation in the update action of the Assignment controller, the instructor was able to update the metareview required or not checkbox.		After realizing that the issue was caused by the cascade action not being implemented, implementing it was the way to go. After the implementation in the update action of the Assignment controller, the instructor was able to update the metareview required or not checkbox.

			===Test Plan===

			====To replicate issue [https://github.com/expertiza/expertiza/issues/972 #972]====

			1. Go to the edit action in the assignments controller. (http://localhost:3000/assignments/(#assignment_id)/edit)
			2. Click on the due dates tab.
			3. Change number of rounds of reviews to a value less than 3. (At this stage, our fix would throw a confirmation message with a warning)
			4. Upon pressing submit, the rounds of reviews will not be updated. (In our fix, the rounds of reviews will only change upon accepting the confirmation)

			====To replicate issue [https://github.com/expertiza/expertiza/issues/961 #961]====

			1. Go to the edit action in the assignments controller. (http://localhost:3000/assignments/(#assignment_id)/edit)
			2. Click on the due dates tab.
			3. Uncheck the metareviews allowed checkbox.
			4. Upon submission, the update will not be visible. (Our fix would allow this action and the update will be visible)

	===References===		===References===

Ralwan at 23:00, 2 November 2017

2017-11-02T23:00:51Z

← Older revision		Revision as of 23:00, 2 November 2017
Line 36:		Line 36:

	The problem was the need for metareview could not be disabled while editing an assignment. This was because the DueDate table was not updated with the necessary cascade actions.		The problem was the need for metareview could not be disabled while editing an assignment. This was because the DueDate table was not updated with the necessary cascade actions.

			=====Solution=====

			This issue was solved by implementing the cascade action manually in the update action in the assignment controller.

			=====Intuition behind fix=====

			After realizing that the issue was caused by the cascade action not being implemented, implementing it was the way to go. After the implementation in the update action of the Assignment controller, the instructor was able to update the metareview required or not checkbox.

	===References===		===References===
Line 44:		Line 52:
	#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]		#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
	#[https://github.com/expertiza/expertiza/pull/1033 Pull request link]		#[https://github.com/expertiza/expertiza/pull/1033 Pull request link]
			#[https://youtu.be/ysVeHlrlKo8 Video of fix]

Ralwan at 22:57, 2 November 2017

2017-11-02T22:57:49Z

← Older revision		Revision as of 22:57, 2 November 2017
Line 27:		Line 27:

	To solve this scenario, we introduced a warning message with a confirmation option to allow the instructor to override the rounds of reviews.		To solve this scenario, we introduced a warning message with a confirmation option to allow the instructor to override the rounds of reviews.

			=====Intuition behind fix=====

			After realizing the actual location of the code that was causing the bug, we realized that assuming the current rounds of reviews by the maximum amongst the submissions count, reviews count, and the rounds of reviews led to a scenario where even when the instructor wanted to update the rounds of reviews, he wasn't allowed to do so. This was a problem because, there would have been a certain situation where the instructor had to override the existing value because of a previous error (maybe even typographical). Thus, a confirmation message with a warning was the way to go.

	====Issue [https://github.com/expertiza/expertiza/issues/961 #961]====		====Issue [https://github.com/expertiza/expertiza/issues/961 #961]====
	=====Problem=====		=====Problem=====

	The problem was the need for metareview could not be disabled while editing an assignment. This was because the DueDate table was not updated with the necessary cascade actions~~. This was solved by implementing the cascade action manually in the update action in the assignment controller~~.		The problem was the need for metareview could not be disabled while editing an assignment. This was because the DueDate table was not updated with the necessary cascade actions.

	===References===		===References===

Vsreeni at 03:55, 30 October 2017

2017-10-30T03:55:32Z

← Older revision		Revision as of 03:55, 30 October 2017
Line 39:		Line 39:
	#[http://expertiza.ncsu.edu/ Expertiza website]		#[http://expertiza.ncsu.edu/ Expertiza website]
	#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]		#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
			#[https://github.com/expertiza/expertiza/pull/1033 Pull request link]

Vsreeni at 03:47, 30 October 2017

2017-10-30T03:47:12Z

← Older revision		Revision as of 03:47, 30 October 2017
Line 9:		Line 9:
	* Issue [https://github.com/expertiza/expertiza/issues/972 #972]: While editing an assignment, changing the number of review rounds doesn't work in Expertiza.		* Issue [https://github.com/expertiza/expertiza/issues/972 #972]: While editing an assignment, changing the number of review rounds doesn't work in Expertiza.
	* Issue [https://github.com/expertiza/expertiza/issues/961 #961]: Once an assignment is duplicated from another assignment with metareview enabled, metareview deadline cannot be disabled.		* Issue [https://github.com/expertiza/expertiza/issues/961 #961]: Once an assignment is duplicated from another assignment with metareview enabled, metareview deadline cannot be disabled.

			* Issue [https://github.com/expertiza/expertiza/issues/295 #295]: was already fixed before the start of this project.

	===Issue Fix===		===Issue Fix===

Ralwan at 14:59, 28 October 2017

2017-10-28T14:59:27Z

← Older revision		Revision as of 14:59, 28 October 2017
Line 12:		Line 12:
	===Issue Fix===		===Issue Fix===
	A working demo of the fixed issues can be found [https://youtu.be/ysVeHlrlKo8 here].		A working demo of the fixed issues can be found [https://youtu.be/ysVeHlrlKo8 here].

			The first two actions of enabling and disabling metareviews show the fixed issue #961. The action of reducing the rounds of reviews shows our fix to issue #972.

	====Issue [https://github.com/expertiza/expertiza/issues/972 #972]====		====Issue [https://github.com/expertiza/expertiza/issues/972 #972]====

Ralwan at 14:56, 28 October 2017

2017-10-28T14:56:56Z

← Older revision		Revision as of 14:56, 28 October 2017
Line 11:		Line 11:

	===Issue Fix===		===Issue Fix===
			A working demo of the fixed issues can be found [https://youtu.be/ysVeHlrlKo8 here].

	====Issue [https://github.com/expertiza/expertiza/issues/972 #972]====		====Issue [https://github.com/expertiza/expertiza/issues/972 #972]====
	=====Initial Approach=====		=====Initial Approach=====

Ralwan at 03:18, 28 October 2017

2017-10-28T03:18:38Z

← Older revision		Revision as of 03:18, 28 October 2017
Line 25:		Line 25:
	=====Problem=====		=====Problem=====

			The problem was the need for metareview could not be disabled while editing an assignment. This was because the DueDate table was not updated with the necessary cascade actions. This was solved by implementing the cascade action manually in the update action in the assignment controller.

	===References===		===References===