Expertiza_Wiki - User contributions [en]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T02:28:53Z

Ytrived:

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade/comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements of instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into the database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is a submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create an entry saves into the database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controllers/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''
* app/views/assignments/list_submissions.html.erb
'''Add code to support view changes for Grade Record'''
* app/views/review_mapping/_review_report.html.erb
'''Add code to support view changes for Grade Record'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as an instructor

2.Navigate to Manage -> Assignments

3. Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4. Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as an instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4. Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Actual Code Change===
==Files Added==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T02:25:49Z

Ytrived:

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade / comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create a entry saves into database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controllers/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''
* app/views/assignments/list_submissions.html.erb
'''Add code to support view changes for Grade Record'''
* app/views/review_mapping/_review_report.html.erb
'''Add code to support view changes for Grade Record'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as instructor

2.Navigate to Manage -> Assignments

3.Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details whill show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Actual Code Change===
==Files Added==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T02:24:48Z

Ytrived: /* Files Added */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade / comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create a entry saves into database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controllers/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''
* app/views/assignments/list_submissions.html.erb
'''Add code to support view changes for Grade Record'''
* app/views/review_mapping/_review_report.html.erb
'''Add code to support view changes for Grade Record'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as instructor

2.Navigate to Manage -> Assignments

3.Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details whill show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Actual Code Change===
==Files Added==
*app/controllers/grades_controller.rb https://bit.ly/2Cg9WzR
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/grading_histories_controller.rb https://bit.ly/2RY5xa6
'''
Calls the grading history view after validaing Submission and Review Type.

'''

*app/controllers/review_mapping_controller.rb https://bit.ly/2QywzZc
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

*app/models/grading_history.rb https://bit.ly/2PHKNRY
'''
Model for Grading History.
'''

*app/models/review_grading_history.rb https://bit.ly/2SPNR0e
'''
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb https://bit.ly/2S5EI3J
'''
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

==Files Modified==
* app/controllers/grades_controller.rb
'''
def save_grade_and_comment_for_submission
participant = AssignmentParticipant.find_by(id: params[:participant_id])
@team = participant.team
@team.grade_for_submission = params[:grade_for_submission]
@team.comment_for_submission = params[:comment_for_submission]
begin
+ GradingHistory.create(instructor_id: session[:user].id,
+ assignment_id: participant.assignment.id,
+ grading_type: "Submission",
+ grade_receiver_id: @team.id,
+ grade: @team.grade_for_submission,
+ comment: @team.comment_for_submission)
@team.save
rescue StandardError
flash[:error] = $ERROR_INFO
end
redirect_to controller: 'assignments', action: 'list_submissions', id: @team.parent_id
end'''
* app/controllers/review_mapping_controller.rb
'''
def save_grade_and_comment_for_reviewer
review_grade = ReviewGrade.find_by(participant_id: params[:participant_id])
review_grade = ReviewGrade.create(participant_id: params[:participant_id]) if review_grade.nil?
review_grade.grade_for_reviewer = params[:grade_for_reviewer] if params[:grade_for_reviewer]
review_grade.comment_for_reviewer = params[:comment_for_reviewer] if params[:comment_for_reviewer]
review_grade.review_graded_at = Time.now
review_grade.reviewer_id = session[:user].id
begin
+ GradingHistory.create(instructor_id: session[:user].id,
+ assignment_id: params[:assignment_id],
+ grading_type: "Review",
+ grade_receiver_id: Participant.find(params[:participant_id]).user_id,
+ grade: params[:grade_for_reviewer],
+ comment: params[:comment_for_reviewer])
review_grade.save!
rescue StandardError
flash[:error] = $ERROR_INFO
end
redirect_to controller: 'review_mapping', action: 'response_report', id: params[:assignment_id]
end

'''
* app/views/assignments/list_submissions.html.erb
'''
132 <td align = 'left'>
133 <%= link_to "Grading History", grading_histories_path(grade_receiver_id: Participant.where(id: r.id).pluck(:user_id).first) %>
134 </td>
'''
* app/views/review_mapping/_review_report.html.erb
'''
75 <td width="10%">
77 <%= link_to "Grading History", grading_histories_path(grade_receiver_id: team.id) %>
79 </td>
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T02:23:19Z

Ytrived: /* Files Added */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade / comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create a entry saves into database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controllers/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''
* app/views/assignments/list_submissions.html.erb
'''Add code to support view changes for Grade Record'''
* app/views/review_mapping/_review_report.html.erb
'''Add code to support view changes for Grade Record'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as instructor

2.Navigate to Manage -> Assignments

3.Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details whill show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Actual Code Change===
==Files Added==
*app/controllers/grades_controller.rb
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team. https://bit.ly/2Cg9WzR
'''

*app/controllers/grading_histories_controller.rb
'''
Calls the grading history view after validaing Submission and Review Type.https://bit.ly/2RY5xa6

'''

*app/controllers/review_mapping_controller.rb
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.https://bit.ly/2QywzZc
'''

*app/models/grading_history.rb
'''
Model for Grading History.https://bit.ly/2PHKNRY
'''

*app/models/review_grading_history.rb
'''
Model containing specifics of Review Grading History. Inherits Grading History.https://bit.ly/2SPNR0e
'''

*app/models/submission_grading_history.rb
'''
Model containing specifics of Submission Grading History. Inherits Grading History.https://bit.ly/2S5EI3J
'''

==Files Modified==
* app/controllers/grades_controller.rb
'''
def save_grade_and_comment_for_submission
participant = AssignmentParticipant.find_by(id: params[:participant_id])
@team = participant.team
@team.grade_for_submission = params[:grade_for_submission]
@team.comment_for_submission = params[:comment_for_submission]
begin
+ GradingHistory.create(instructor_id: session[:user].id,
+ assignment_id: participant.assignment.id,
+ grading_type: "Submission",
+ grade_receiver_id: @team.id,
+ grade: @team.grade_for_submission,
+ comment: @team.comment_for_submission)
@team.save
rescue StandardError
flash[:error] = $ERROR_INFO
end
redirect_to controller: 'assignments', action: 'list_submissions', id: @team.parent_id
end'''
* app/controllers/review_mapping_controller.rb
'''
def save_grade_and_comment_for_reviewer
review_grade = ReviewGrade.find_by(participant_id: params[:participant_id])
review_grade = ReviewGrade.create(participant_id: params[:participant_id]) if review_grade.nil?
review_grade.grade_for_reviewer = params[:grade_for_reviewer] if params[:grade_for_reviewer]
review_grade.comment_for_reviewer = params[:comment_for_reviewer] if params[:comment_for_reviewer]
review_grade.review_graded_at = Time.now
review_grade.reviewer_id = session[:user].id
begin
+ GradingHistory.create(instructor_id: session[:user].id,
+ assignment_id: params[:assignment_id],
+ grading_type: "Review",
+ grade_receiver_id: Participant.find(params[:participant_id]).user_id,
+ grade: params[:grade_for_reviewer],
+ comment: params[:comment_for_reviewer])
review_grade.save!
rescue StandardError
flash[:error] = $ERROR_INFO
end
redirect_to controller: 'review_mapping', action: 'response_report', id: params[:assignment_id]
end

'''
* app/views/assignments/list_submissions.html.erb
'''
132 <td align = 'left'>
133 <%= link_to "Grading History", grading_histories_path(grade_receiver_id: Participant.where(id: r.id).pluck(:user_id).first) %>
134 </td>
'''
* app/views/review_mapping/_review_report.html.erb
'''
75 <td width="10%">
77 <%= link_to "Grading History", grading_histories_path(grade_receiver_id: team.id) %>
79 </td>
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T02:22:37Z

Ytrived: /* Files Added */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade / comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create a entry saves into database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controllers/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''
* app/views/assignments/list_submissions.html.erb
'''Add code to support view changes for Grade Record'''
* app/views/review_mapping/_review_report.html.erb
'''Add code to support view changes for Grade Record'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as instructor

2.Navigate to Manage -> Assignments

3.Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details whill show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Actual Code Change===
==Files Added==
*app/controllers/grades_controller.rb
'''
Creates a Grading History Record for every Submission grade edited by the instructor for a Team. https://bit.ly/2Cg9WzR
'''

*app/controllers/grading_histories_controller.rb
'''
Calls the grading history view after validaing Submission and Review Type.https://bit.ly/2RY5xa6

'''

*app/controllers/review_mapping_controller.rb
'''

Creates a Grading History Record for every Review grade edited by the instructor for a Student.https://bit.ly/2QywzZc
'''

*app/models/grading_history.rb
'''
Model for Grading History.https://bit.ly/2PHKNRY
'''

*app/models/review_grading_history.rb
'''
Model containing specifics of Review Grading History. Inherits Grading History.https://bit.ly/2SPNR0e
'''

*app/models/submission_grading_history.rb
'''
Model containing specifics of Submission Grading History. Inherits Grading History.https://bit.ly/2S5EI3J
'''

==Files Modified==
* app/controllers/grades_controller.rb
'''
def save_grade_and_comment_for_submission
participant = AssignmentParticipant.find_by(id: params[:participant_id])
@team = participant.team
@team.grade_for_submission = params[:grade_for_submission]
@team.comment_for_submission = params[:comment_for_submission]
begin
+ GradingHistory.create(instructor_id: session[:user].id,
+ assignment_id: participant.assignment.id,
+ grading_type: "Submission",
+ grade_receiver_id: @team.id,
+ grade: @team.grade_for_submission,
+ comment: @team.comment_for_submission)
@team.save
rescue StandardError
flash[:error] = $ERROR_INFO
end
redirect_to controller: 'assignments', action: 'list_submissions', id: @team.parent_id
end'''
* app/controllers/review_mapping_controller.rb
'''
def save_grade_and_comment_for_reviewer
review_grade = ReviewGrade.find_by(participant_id: params[:participant_id])
review_grade = ReviewGrade.create(participant_id: params[:participant_id]) if review_grade.nil?
review_grade.grade_for_reviewer = params[:grade_for_reviewer] if params[:grade_for_reviewer]
review_grade.comment_for_reviewer = params[:comment_for_reviewer] if params[:comment_for_reviewer]
review_grade.review_graded_at = Time.now
review_grade.reviewer_id = session[:user].id
begin
+ GradingHistory.create(instructor_id: session[:user].id,
+ assignment_id: params[:assignment_id],
+ grading_type: "Review",
+ grade_receiver_id: Participant.find(params[:participant_id]).user_id,
+ grade: params[:grade_for_reviewer],
+ comment: params[:comment_for_reviewer])
review_grade.save!
rescue StandardError
flash[:error] = $ERROR_INFO
end
redirect_to controller: 'review_mapping', action: 'response_report', id: params[:assignment_id]
end

'''
* app/views/assignments/list_submissions.html.erb
'''
132 <td align = 'left'>
133 <%= link_to "Grading History", grading_histories_path(grade_receiver_id: Participant.where(id: r.id).pluck(:user_id).first) %>
134 </td>
'''
* app/views/review_mapping/_review_report.html.erb
'''
75 <td width="10%">
77 <%= link_to "Grading History", grading_histories_path(grade_receiver_id: team.id) %>
79 </td>
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-16T02:20:16Z

Ytrived: /* Files Added */

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade / comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create a entry saves into database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controllers/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''
* app/views/assignments/list_submissions.html.erb
'''Add code to support view changes for Grade Record'''
* app/views/review_mapping/_review_report.html.erb
'''Add code to support view changes for Grade Record'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as instructor

2.Navigate to Manage -> Assignments

3.Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details whill show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
===Actual Code Change===
==Files Added==
*app/controllers/grades_controller.rb
'''
https://bit.ly/2Cg9WzR

Creates a Grading History Record for every Submission grade edited by the instructor for a Team.
'''

*app/controllers/grading_histories_controller.rb
'''
https://bit.ly/2RY5xa6

Calls the grading history view after validaing Submission and Review Type.
'''

*app/controllers/review_mapping_controller.rb
'''
https://bit.ly/2QywzZc
Creates a Grading History Record for every Review grade edited by the instructor for a Student.
'''

*app/models/grading_history.rb
'''
https://bit.ly/2PHKNRY
Model for Grading History.
'''

*app/models/review_grading_history.rb
'''
https://bit.ly/2SPNR0e
Model containing specifics of Review Grading History. Inherits Grading History.
'''

*app/models/submission_grading_history.rb
'''
https://bit.ly/2S5EI3J
Model containing specifics of Submission Grading History. Inherits Grading History.
'''

==Files Modified==
* app/controllers/grades_controller.rb
'''
def save_grade_and_comment_for_submission
participant = AssignmentParticipant.find_by(id: params[:participant_id])
@team = participant.team
@team.grade_for_submission = params[:grade_for_submission]
@team.comment_for_submission = params[:comment_for_submission]
begin
+ GradingHistory.create(instructor_id: session[:user].id,
+ assignment_id: participant.assignment.id,
+ grading_type: "Submission",
+ grade_receiver_id: @team.id,
+ grade: @team.grade_for_submission,
+ comment: @team.comment_for_submission)
@team.save
rescue StandardError
flash[:error] = $ERROR_INFO
end
redirect_to controller: 'assignments', action: 'list_submissions', id: @team.parent_id
end'''
* app/controllers/review_mapping_controller.rb
'''
def save_grade_and_comment_for_reviewer
review_grade = ReviewGrade.find_by(participant_id: params[:participant_id])
review_grade = ReviewGrade.create(participant_id: params[:participant_id]) if review_grade.nil?
review_grade.grade_for_reviewer = params[:grade_for_reviewer] if params[:grade_for_reviewer]
review_grade.comment_for_reviewer = params[:comment_for_reviewer] if params[:comment_for_reviewer]
review_grade.review_graded_at = Time.now
review_grade.reviewer_id = session[:user].id
begin
+ GradingHistory.create(instructor_id: session[:user].id,
+ assignment_id: params[:assignment_id],
+ grading_type: "Review",
+ grade_receiver_id: Participant.find(params[:participant_id]).user_id,
+ grade: params[:grade_for_reviewer],
+ comment: params[:comment_for_reviewer])
review_grade.save!
rescue StandardError
flash[:error] = $ERROR_INFO
end
redirect_to controller: 'review_mapping', action: 'response_report', id: params[:assignment_id]
end

'''
* app/views/assignments/list_submissions.html.erb
'''
132 <td align = 'left'>
133 <%= link_to "Grading History", grading_histories_path(grade_receiver_id: Participant.where(id: r.id).pluck(:user_id).first) %>
134 </td>
'''
* app/views/review_mapping/_review_report.html.erb
'''
75 <td width="10%">
77 <%= link_to "Grading History", grading_histories_path(grade_receiver_id: team.id) %>
79 </td>
'''

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-11-20T04:12:34Z

Ytrived: /* Testing Plan */

CSC/E1869 GRADING AUDIT TRAIL

2018-11-20T04:12:14Z

Ytrived: /* Testing Plan */

CSC/E1869 GRADING AUDIT TRAIL

2018-11-20T04:09:51Z

Ytrived:

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-10T00:15:27Z

Ytrived: /* Testing */

==Introduction==
===Background===
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the students to peer review other students submission. It also allows Participant of a Team to provide feedback for the review. Apart from that, it allows the instructor to view the summary report of reviews received and feedbacks given by each participant of a team.

===Motivation===
In current system the author feedback is send by individual team members. It
would be better if one team send one single rejoinder to the review and all members
could see and edit it. Also there are real usability issues with regards to how students can
even navigate to the place where feedback can be given to reviewers. The UI needs to
be more user friendly.

In Summary report for assignment for instructors, the author feedback
section lists feedback from all team members. You should change this to list the team’s
collective feedback to its reviewers to a particular assignment

===Tasks Identified===

* Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.
* Refactor all the actions in response controllers to pass the participant id.
* Refactor author feedback tab in summary report view for the instructor.
* Change in the summary report of assignment for the instructor to display teams feedbacks.
* In the author-feedback tab on the heat grid, fixed reviewers names on top row.
* Summary reports navigation to the page where feedbacks are given to reviewers.

====Classes====
1.Team rejoinder.
* controllers/response_controller.rb
*views/grades/_reviews.html.erb
*views/response/response.html.erb
*models/vm_question_response.rb
*models/assignment_participant.rb

2.Navigation Issue fixes
*views/response/view.html.erb

3.Author feedback tab of summary report:
*models/response_map.rb
*models/team.rb
*helpers/grades_helper.rb
*views/grades/_author_feedback_tab.html.erb

4.Heatgrid top raw reviewer name fix:
*views/grades/_view_heatgrid.html.erb

====Solutions Implemented and Delivered====

*Changed per participant feedback display author feedback view to per team:

[[File:author_feedback.jpg]]

*Added "give feedback" and edit feedback functionality in the review view.
[[File:view_feedback.jpg]]

*Edited grade helper to use a questionnaire to use team ID for reviews in case of a feedback.
[[File:grades_helper.jpg]]

*Refactored new_feedback method to add team ID as the reviewer Id in the response map.

[[File:New_feedback.jpg]]

*Fixed a bug where a wrong assessment was being returned for a feedback because the map was searched on participant id instead of reviewee id.
So added a new method which will return a feedback assessment.

[[File:response_map.jpg]]

===Testing===

Fixed the existing test cases for the review feedback by a team instead of a team member.
====Test Plan====
*Should test that if there is no rejoinder for the review then it redirects to new author feedback page.

*Tests that the other teammate is able to edit.

*The page is redirecting back to the View->review.

*Tests that the rejoinder by a participant of a team is saved properly.

====Tests====

Context 'when current response is nil' do
it 'redirects to response#new page' do
allow(FeedbackResponseMap).to receive(:where).with(reviewed_object_id: 1, reviewer_id: 1).and_return([])
params = {id: 1, participant_id: 1}
session = {user: instructor}
get :new_feedback, params, session
expect(response).to redirect_to('/response/new?id=2&participant_id=1&return=feedback')
end
end

describe '#feedback' do
it 'returns corrsponding author feedback responses given by current participant' do
allow(FeedbackResponseMap).to receive(:get_feedback_assessments_for).with(participant.team).and_return([response])
expect(participant.feedback).to eq([response])
end
end

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-10T00:10:10Z

Ytrived: /* Testing */

==Introduction==
===Background===
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the students to peer review other students submission. It also allows Participant of a Team to provide feedback for the review. Apart from that, it allows the instructor to view the summary report of reviews received and feedbacks given by each participant of a team.

===Motivation===
In current system the author feedback is send by individual team members. It
would be better if one team send one single rejoinder to the review and all members
could see and edit it. Also there are real usability issues with regards to how students can
even navigate to the place where feedback can be given to reviewers. The UI needs to
be more user friendly.

In Summary report for assignment for instructors, the author feedback
section lists feedback from all team members. You should change this to list the team’s
collective feedback to its reviewers to a particular assignment

===Tasks Identified===

* Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.
* Refactor all the actions in response controllers to pass the participant id.
* Refactor author feedback tab in summary report view for the instructor.
* Change in the summary report of assignment for the instructor to display teams feedbacks.
* In the author-feedback tab on the heat grid, fixed reviewers names on top row.
* Summary reports navigation to the page where feedbacks are given to reviewers.

====Classes====
1.Team rejoinder.
* controllers/response_controller.rb
*views/grades/_reviews.html.erb
*views/response/response.html.erb
*models/vm_question_response.rb
*models/assignment_participant.rb

2.Navigation Issue fixes
*views/response/view.html.erb

3.Author feedback tab of summary report:
*models/response_map.rb
*models/team.rb
*helpers/grades_helper.rb
*views/grades/_author_feedback_tab.html.erb

4.Heatgrid top raw reviewer name fix:
*views/grades/_view_heatgrid.html.erb

====Solutions Implemented and Delivered====

*Changed per participant feedback display author feedback view to per team:

[[File:author_feedback.jpg]]

*Added "give feedback" and edit feedback functionality in the review view.
[[File:view_feedback.jpg]]

*Edited grade helper to use a questionnaire to use team ID for reviews in case of a feedback.
[[File:grades_helper.jpg]]

*Refactored new_feedback method to add team ID as the reviewer Id in the response map.

[[File:New_feedback.jpg]]

*Fixed a bug where a wrong assessment was being returned for a feedback because the map was searched on participant id instead of reviewee id.
So added a new method which will return a feedback assessment.

[[File:response_map.jpg]]

===Testing===

Fixed the existing test cases for the review feedback by a team instead of a team member.
====Test Plan====
*Should test that if there is no rejoinder for the review then it redirects to new author feedback page.

*Tests that the other teammate is able to edit.

*The page is redirecting back to the View->review.

*Tests that the rejoinder by a participant of a team is saved properly.

====Tests====

1.
<nowiki>
context 'when current response is nil' do
it 'redirects to response#new page' do
allow(FeedbackResponseMap).to receive(:where).with(reviewed_object_id: 1, reviewer_id: 1).and_return([])
params = {id: 1, participant_id: 1}
session = {user: instructor}
get :new_feedback, params, session
expect(response).to redirect_to('/response/new?id=2&participant_id=1&return=feedback')
end
end
</nowiki>
2.
<nowiki><nowiki>describe '#feedback' do
it 'returns corrsponding author feedback responses given by current participant' do
allow(FeedbackResponseMap).to receive(:get_feedback_assessments_for).with(participant.team).and_return([response])
expect(participant.feedback).to eq([response])
end
end</nowiki></nowiki>

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-10T00:08:22Z

Ytrived: /* Testing */

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-02T22:37:18Z

Ytrived:

==Introduction==
===Background===
Expertiza provides a dashboard for all the Assignments corresponding to a course and provides absolute control to the Instructors and Teaching Assistant. In addition to Assignments, it encompasses peer reviews where in participants are allowed to provide feedback anonymously about each other's work thereby providing scope for better outcome.

Assignments in Expertiza have their association with many other components like Courses,Reviews,Participants and Scores. The Assignment controller in specific performs various other actions in addition to the CRUD operations applied on its model. These actions sew up the association of an assignment with others like courses etc. There exists an Assignment Form model which acts as a wrapper for the Assignment and provides further control.

===Motivation===
In current system the author feedback is send by individual team members. It
would be better if one team send one single rejoinder to the review and all members
could see and edit it. Also there are real usability issues with regards to how students can
even navigate to the place where feedback can be given to reviewers. The UI needs to
be more user friendly.

In Summary report for assignment for instructors, the author feedback
section lists feedback from all team members. You should change this to list the team’s
collective feedback to its reviewers to a particular assignment

===Tasks Identified===
* Refactor edit and update method
* Remove irrelevant comments from the create action.
* associate_assignment_with_course and remove_assignment_from_course logic should be moved to model.
* Change to new redirect method rather using controller and action explicitly.
* Refactor the update_due_dates from Assignment Form. using the DRY principle
* Refactor code to follow the ruby style guide and Rails4 syntax.

* Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.
* Refactor all the actions in response controllers to pass the participant id.
* Refactor author feedback tab in summary report view for the instructor.
* Change in the summary report of assignment for the instructor to display teams feedbacks.
* In the author-feedback tab on the heat grid, fixed reviewers names on top row.
* Summary reports navigation to the page where feedbacks are given to reviewers.

====Classes====
1.Team rejoinder.
* controllers/response_controller.rb
*views/grades/_reviews.html.erb
*views/response/response.html.erb
*models/vm_question_response.rb
*models/assignment_participant.rb

2.Navigation Issue fixes
*views/response/view.html.erb

3.Author feedback tab of summary report:
*models/response_map.rb
*models/team.rb
*helpers/grades_helper.rb
*views/grades/_author_feedback_tab.html.erb

4.Heatgrid top raw reviewer name fix:
*views/grades/_view_heatgrid.html.erb

====Solutions Implemented and Delivered====

*Changed per participant feedback display author feedback view to per team:

[[File:author_feedback.jpg]]

*Added "give feedback" and edit feedback functionality in the review view.
[[File:view_feedback.jpg]]

*Edited grade helper to use a questionnaire to use team ID for reviews in case of a feedback.
[[File:grades_helper.jpg]]

*Refactored new_feedback method to add team ID as the reviewer Id in the response map.

[[File:New_feedback.jpg]]

*Fixed a bug where a wrong assessment was being returned for a feedback because the map was searched on participant id instead of reviewee id.
So added a new method which will return a feedback assessment.

[[File:response_map.jpg]]

===Testing===

Fixed the existed test cases for the fixes we made.

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-02T22:32:59Z

Ytrived:

File:View feedback.jpg

2018-11-02T22:17:46Z

Ytrived:

File:Response map.jpg

2018-11-02T22:17:38Z

Ytrived:

File:New feedback.jpg

2018-11-02T22:17:28Z

Ytrived:

File:Grades helper.jpg

2018-11-02T22:17:19Z

Ytrived:

File:Author feedback.jpg

2018-11-02T22:17:07Z

Ytrived:

File:Newfeedback.jpg

2018-11-02T22:03:04Z

Ytrived: uploaded a new version of "File:Newfeedback.jpg"

File:Newfeedback.jpg

2018-11-02T21:57:20Z

Ytrived:

File:1.Newfeedback.PNG

2018-11-02T21:55:14Z

Ytrived: uploaded a new version of "File:1.Newfeedback.PNG"

File:1.Newfeedback.PNG

2018-11-02T21:50:08Z

Ytrived:

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-02T21:23:54Z

Ytrived: Created page with "==Introduction== ===Background=== Expertiza provides a dashboard for all the Assignments corresponding to a course and provides absolute control to the Instructors and Teaching A..."