Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2017

2017-11-28T04:25:20Z

Ygui2:

'''Design Project Documentation'''
*[[CSC/ECE 517 Fall 2017/E17A2 Lightweight Badging System]]
*[[CSC/ECE 517 Fall 2017/E17A8. Use a profiler to identify the problems / pages that take some time to load & fix them]]
*[[CSC/ECE 517 Fall 2017/E1793. Help students find teams to join]]
*[[CSC/ECE 517 Fall 2017/E17A4 Allow calibration to be part of an assignment]]
*[[CSC/ECE 517 Fall 2017/E17A0 Team-based reviewing]]
*[[CSC/ECE 517 Fall 2017/E1793. Help students find teams to join_Team1964]]
*[[CSC/ECE 517 Fall 2017/E1791. Track the time that students look at the other submissions - logging improvement]]
*[[CSC/ECE 517 Fall 2017/E1799 Improve self-review Link peer review & self-review to derive grades]]
*[[CSC/ECE_517_Fall_2017/E1797_Timestamps_for_students_submissions]]
*[[CSC/ECE_517_Fall_2017/E17A1|CSC/ECE_517_Fall_2017/E17A1 - Let experts as well as students do reviews]]
*[[CSC/ECE_517_Fall_2017/M1753_OffscreenCanvas]]
*[[CSC/ECE 517 Fall 2017/M1754_Mutation_Testing]]
*[[CSC/ECE 517 Fall 2017/E1794. Student-generated questions added to rubric]]
*[[CSC/ECE 517 Fall 2017/E1795 Single signon for Peerlogic web services (WS intergration)]]
*[[CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably]]
*[[CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors]]
*[[CSC/ECE 517 Fall 2017/E17A4 Allow calibration to be part of an assignment_Team34]]
*[[CSC/ECE 517 Fall 2017/E17A7_Allow_Reviewers_to_bid_on_what_to_review]]
*[[CSC/ECE 517 Fall 2017/E17A9 Lazy loading (infinite scroll) for assignments courses questionnaires and user lists with Jscroll]]
*[[CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages]]
*[[CSC/ECE 517 Fall 2017/E17A5 Allow users to create an account and submit work to an "assignment" (e.g., for conference reviewing)]]
*[[CSC/ECE 517 Fall 2017/E17A3 Upgrade review input UI and sanitize text input]]
*[[CSC/ECE 517 Fall 2017/E17AA Nomination for Badges]]
*[[CSC/ECE 517 Fall 2017/E1790 Text metrics]]
*[[CSC/ECE 517 Fall 2017/E17A1 Expert Review.rb]]

'''Writing Assignment 2'''
*[[CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team]]
*[[CSC/ECE_517_Fall_2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb]]
*[[CSC/ECE_517_Fall_2017/E1774 Metareview fixes and improvements.rb]]
*[[CSC/ECE_517_Fall_2017/E1788 OSS project Maroon Heatmap fixes]]
*[[CSC/ECE 517 Fall 2017/E1781 Topic Management]]
*[[CSC/ECE_517_Fall_2017/E1745_Refactor_response_controller.rb]]
*[[CSC/ECE_517_Fall_2017/E1752 Refactor assignments controller]]
*[[CSC/ECE_517_Fall_2017/E1776_Enhance_Imports]]
*[[CSC/ECE_517_Fall_2017/E1756 TLD Refactor response.rb]]
*[[CSC/ECE_517_Fall_2017/E1772_Refactor reputation_web_service_controller.rb]]
*[[CSC/ECE_517_Fall_2017/M1753_OffscreenCanvas API]]
*[[CSC/ECE_517_Fall_2017/M1754_Mutation Testing on Servo]]
*[[CSC/ECE_517_Fall_2017/E1753 OSS project bidding tests]]
*[[CSC/ECE_517_Fall_2017/E1766_Test team functionality]]
*[[CSC/ECE 517 Fall 2017/E1767 Improve imports]]
*[[CSC/ECE_517_Fall_2017/E1786_OSS project Juniper Bookmark Enhancements]]
*[[CSC/ECE_517_Fall_2017/E1787_OSS project Bronze Score calculations]]
*[[CSC/ECE_517_Fall_2017/E1763 Fix Staggered-Deadline Assignments]]
*[[CSC/ECE 517 Fall 2017/E1757 Introduce a Student View for instructors]]
*[[CSC/ECE 517 Fall 2017/E1769_Refactor assignment_form.rb]]
*[[CSC/ECE 517 Fall 2017/E1754_Feature_test_of_rubric_advice]]
*[[CSC/ECE 517 Fall 2017/E1782 OSS Project Red Assignment Directories]]
*[[CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list]]
*[[CSC/ECE 517 Fall 2017/E1761 Test First Development Refactor assignment.rb]]
*[[CSC/ECE_517_Fall_2017/E1780_OSS_Project_Teal_Email_Notification_Enhancements]]
*[[CSC/ECE_517_Fall_2017/E1762 Test various kinds of response-map hierarchies]]
*[[CSC/ECE_517_Fall_2017/E1759 ]]
*[[CSC/ECE_517_Fall_2017/E1749_Test First Development Refactor questionnaire_controller.rb]]
*[[CSC/ECE 517 Fall 2017/E1777 Coherent specification of review requirements.rb]]
*[[CSC/ECE 517 Fall 2017/E1771_Refactor_team.rb]]
*[[CSC/ECE 517 Fall 2017/E1784 Fix mass assignments reported by Brakeman.rb]]

CSC/ECE 517 Fall 2017

2017-11-28T04:24:59Z

Ygui2:

'''Design Project Documentation'''
*[[CSC/ECE 517 Fall 2017/E17A2 Lightweight Badging System]]
*[[CSC/ECE 517 Fall 2017/E17A8. Use a profiler to identify the problems / pages that take some time to load & fix them]]
*[[CSC/ECE 517 Fall 2017/E1793_Team2607. Help students find teams to join]]
*[[CSC/ECE 517 Fall 2017/E17A4 Allow calibration to be part of an assignment]]
*[[CSC/ECE 517 Fall 2017/E17A0 Team-based reviewing]]
*[[CSC/ECE 517 Fall 2017/E1793. Help students find teams to join_Team1964]]
*[[CSC/ECE 517 Fall 2017/E1791. Track the time that students look at the other submissions - logging improvement]]
*[[CSC/ECE 517 Fall 2017/E1799 Improve self-review Link peer review & self-review to derive grades]]
*[[CSC/ECE_517_Fall_2017/E1797_Timestamps_for_students_submissions]]
*[[CSC/ECE_517_Fall_2017/E17A1|CSC/ECE_517_Fall_2017/E17A1 - Let experts as well as students do reviews]]
*[[CSC/ECE_517_Fall_2017/M1753_OffscreenCanvas]]
*[[CSC/ECE 517 Fall 2017/M1754_Mutation_Testing]]
*[[CSC/ECE 517 Fall 2017/E1794. Student-generated questions added to rubric]]
*[[CSC/ECE 517 Fall 2017/E1795 Single signon for Peerlogic web services (WS intergration)]]
*[[CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably]]
*[[CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors]]
*[[CSC/ECE 517 Fall 2017/E17A4 Allow calibration to be part of an assignment_Team34]]
*[[CSC/ECE 517 Fall 2017/E17A7_Allow_Reviewers_to_bid_on_what_to_review]]
*[[CSC/ECE 517 Fall 2017/E17A9 Lazy loading (infinite scroll) for assignments courses questionnaires and user lists with Jscroll]]
*[[CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages]]
*[[CSC/ECE 517 Fall 2017/E17A5 Allow users to create an account and submit work to an "assignment" (e.g., for conference reviewing)]]
*[[CSC/ECE 517 Fall 2017/E17A3 Upgrade review input UI and sanitize text input]]
*[[CSC/ECE 517 Fall 2017/E17AA Nomination for Badges]]
*[[CSC/ECE 517 Fall 2017/E1790 Text metrics]]
*[[CSC/ECE 517 Fall 2017/E17A1 Expert Review.rb]]

'''Writing Assignment 2'''
*[[CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team]]
*[[CSC/ECE_517_Fall_2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb]]
*[[CSC/ECE_517_Fall_2017/E1774 Metareview fixes and improvements.rb]]
*[[CSC/ECE_517_Fall_2017/E1788 OSS project Maroon Heatmap fixes]]
*[[CSC/ECE 517 Fall 2017/E1781 Topic Management]]
*[[CSC/ECE_517_Fall_2017/E1745_Refactor_response_controller.rb]]
*[[CSC/ECE_517_Fall_2017/E1752 Refactor assignments controller]]
*[[CSC/ECE_517_Fall_2017/E1776_Enhance_Imports]]
*[[CSC/ECE_517_Fall_2017/E1756 TLD Refactor response.rb]]
*[[CSC/ECE_517_Fall_2017/E1772_Refactor reputation_web_service_controller.rb]]
*[[CSC/ECE_517_Fall_2017/M1753_OffscreenCanvas API]]
*[[CSC/ECE_517_Fall_2017/M1754_Mutation Testing on Servo]]
*[[CSC/ECE_517_Fall_2017/E1753 OSS project bidding tests]]
*[[CSC/ECE_517_Fall_2017/E1766_Test team functionality]]
*[[CSC/ECE 517 Fall 2017/E1767 Improve imports]]
*[[CSC/ECE_517_Fall_2017/E1786_OSS project Juniper Bookmark Enhancements]]
*[[CSC/ECE_517_Fall_2017/E1787_OSS project Bronze Score calculations]]
*[[CSC/ECE_517_Fall_2017/E1763 Fix Staggered-Deadline Assignments]]
*[[CSC/ECE 517 Fall 2017/E1757 Introduce a Student View for instructors]]
*[[CSC/ECE 517 Fall 2017/E1769_Refactor assignment_form.rb]]
*[[CSC/ECE 517 Fall 2017/E1754_Feature_test_of_rubric_advice]]
*[[CSC/ECE 517 Fall 2017/E1782 OSS Project Red Assignment Directories]]
*[[CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list]]
*[[CSC/ECE 517 Fall 2017/E1761 Test First Development Refactor assignment.rb]]
*[[CSC/ECE_517_Fall_2017/E1780_OSS_Project_Teal_Email_Notification_Enhancements]]
*[[CSC/ECE_517_Fall_2017/E1762 Test various kinds of response-map hierarchies]]
*[[CSC/ECE_517_Fall_2017/E1759 ]]
*[[CSC/ECE_517_Fall_2017/E1749_Test First Development Refactor questionnaire_controller.rb]]
*[[CSC/ECE 517 Fall 2017/E1777 Coherent specification of review requirements.rb]]
*[[CSC/ECE 517 Fall 2017/E1771_Refactor_team.rb]]
*[[CSC/ECE 517 Fall 2017/E1784 Fix mass assignments reported by Brakeman.rb]]

CSC/ECE 517 Fall 2017

2017-11-28T04:23:50Z

Ygui2:

'''Design Project Documentation'''
*[[CSC/ECE 517 Fall 2017/E17A2 Lightweight Badging System]]
*[[CSC/ECE 517 Fall 2017/E17A8. Use a profiler to identify the problems / pages that take some time to load & fix them]]
*[[CSC/ECE 517 Fall 2017/E1793_Team2607 Help students find teams to join]]
*[[CSC/ECE 517 Fall 2017/E17A4 Allow calibration to be part of an assignment]]
*[[CSC/ECE 517 Fall 2017/E17A0 Team-based reviewing]]
*[[CSC/ECE 517 Fall 2017/E1793. Help students find teams to join_Team1964]]
*[[CSC/ECE 517 Fall 2017/E1791. Track the time that students look at the other submissions - logging improvement]]
*[[CSC/ECE 517 Fall 2017/E1799 Improve self-review Link peer review & self-review to derive grades]]
*[[CSC/ECE_517_Fall_2017/E1797_Timestamps_for_students_submissions]]
*[[CSC/ECE_517_Fall_2017/E17A1|CSC/ECE_517_Fall_2017/E17A1 - Let experts as well as students do reviews]]
*[[CSC/ECE_517_Fall_2017/M1753_OffscreenCanvas]]
*[[CSC/ECE 517 Fall 2017/M1754_Mutation_Testing]]
*[[CSC/ECE 517 Fall 2017/E1794. Student-generated questions added to rubric]]
*[[CSC/ECE 517 Fall 2017/E1795 Single signon for Peerlogic web services (WS intergration)]]
*[[CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably]]
*[[CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors]]
*[[CSC/ECE 517 Fall 2017/E17A4 Allow calibration to be part of an assignment_Team34]]
*[[CSC/ECE 517 Fall 2017/E17A7_Allow_Reviewers_to_bid_on_what_to_review]]
*[[CSC/ECE 517 Fall 2017/E17A9 Lazy loading (infinite scroll) for assignments courses questionnaires and user lists with Jscroll]]
*[[CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages]]
*[[CSC/ECE 517 Fall 2017/E17A5 Allow users to create an account and submit work to an "assignment" (e.g., for conference reviewing)]]
*[[CSC/ECE 517 Fall 2017/E17A3 Upgrade review input UI and sanitize text input]]
*[[CSC/ECE 517 Fall 2017/E17AA Nomination for Badges]]
*[[CSC/ECE 517 Fall 2017/E1790 Text metrics]]
*[[CSC/ECE 517 Fall 2017/E17A1 Expert Review.rb]]

'''Writing Assignment 2'''
*[[CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team]]
*[[CSC/ECE_517_Fall_2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb]]
*[[CSC/ECE_517_Fall_2017/E1774 Metareview fixes and improvements.rb]]
*[[CSC/ECE_517_Fall_2017/E1788 OSS project Maroon Heatmap fixes]]
*[[CSC/ECE 517 Fall 2017/E1781 Topic Management]]
*[[CSC/ECE_517_Fall_2017/E1745_Refactor_response_controller.rb]]
*[[CSC/ECE_517_Fall_2017/E1752 Refactor assignments controller]]
*[[CSC/ECE_517_Fall_2017/E1776_Enhance_Imports]]
*[[CSC/ECE_517_Fall_2017/E1756 TLD Refactor response.rb]]
*[[CSC/ECE_517_Fall_2017/E1772_Refactor reputation_web_service_controller.rb]]
*[[CSC/ECE_517_Fall_2017/M1753_OffscreenCanvas API]]
*[[CSC/ECE_517_Fall_2017/M1754_Mutation Testing on Servo]]
*[[CSC/ECE_517_Fall_2017/E1753 OSS project bidding tests]]
*[[CSC/ECE_517_Fall_2017/E1766_Test team functionality]]
*[[CSC/ECE 517 Fall 2017/E1767 Improve imports]]
*[[CSC/ECE_517_Fall_2017/E1786_OSS project Juniper Bookmark Enhancements]]
*[[CSC/ECE_517_Fall_2017/E1787_OSS project Bronze Score calculations]]
*[[CSC/ECE_517_Fall_2017/E1763 Fix Staggered-Deadline Assignments]]
*[[CSC/ECE 517 Fall 2017/E1757 Introduce a Student View for instructors]]
*[[CSC/ECE 517 Fall 2017/E1769_Refactor assignment_form.rb]]
*[[CSC/ECE 517 Fall 2017/E1754_Feature_test_of_rubric_advice]]
*[[CSC/ECE 517 Fall 2017/E1782 OSS Project Red Assignment Directories]]
*[[CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list]]
*[[CSC/ECE 517 Fall 2017/E1761 Test First Development Refactor assignment.rb]]
*[[CSC/ECE_517_Fall_2017/E1780_OSS_Project_Teal_Email_Notification_Enhancements]]
*[[CSC/ECE_517_Fall_2017/E1762 Test various kinds of response-map hierarchies]]
*[[CSC/ECE_517_Fall_2017/E1759 ]]
*[[CSC/ECE_517_Fall_2017/E1749_Test First Development Refactor questionnaire_controller.rb]]
*[[CSC/ECE 517 Fall 2017/E1777 Coherent specification of review requirements.rb]]
*[[CSC/ECE 517 Fall 2017/E1771_Refactor_team.rb]]
*[[CSC/ECE 517 Fall 2017/E1784 Fix mass assignments reported by Brakeman.rb]]

CSC/ECE 517 Fall 2017

2017-11-28T04:23:36Z

Ygui2:

'''Design Project Documentation'''
*[[CSC/ECE 517 Fall 2017/E17A2 Lightweight Badging System]]
*[[CSC/ECE 517 Fall 2017/E17A8. Use a profiler to identify the problems / pages that take some time to load & fix them]]
*[[CSC/ECE 517 Fall 2017/E1793__Team2607 Help students find teams to join]]
*[[CSC/ECE 517 Fall 2017/E17A4 Allow calibration to be part of an assignment]]
*[[CSC/ECE 517 Fall 2017/E17A0 Team-based reviewing]]
*[[CSC/ECE 517 Fall 2017/E1793. Help students find teams to join_Team1964]]
*[[CSC/ECE 517 Fall 2017/E1791. Track the time that students look at the other submissions - logging improvement]]
*[[CSC/ECE 517 Fall 2017/E1799 Improve self-review Link peer review & self-review to derive grades]]
*[[CSC/ECE_517_Fall_2017/E1797_Timestamps_for_students_submissions]]
*[[CSC/ECE_517_Fall_2017/E17A1|CSC/ECE_517_Fall_2017/E17A1 - Let experts as well as students do reviews]]
*[[CSC/ECE_517_Fall_2017/M1753_OffscreenCanvas]]
*[[CSC/ECE 517 Fall 2017/M1754_Mutation_Testing]]
*[[CSC/ECE 517 Fall 2017/E1794. Student-generated questions added to rubric]]
*[[CSC/ECE 517 Fall 2017/E1795 Single signon for Peerlogic web services (WS intergration)]]
*[[CSC/ECE 517 Fall 2017/E17A6. Fix account creation over web to work reasonably]]
*[[CSC/ECE 517 Fall 2017/E1792 OSS Visualizations for instructors]]
*[[CSC/ECE 517 Fall 2017/E17A4 Allow calibration to be part of an assignment_Team34]]
*[[CSC/ECE 517 Fall 2017/E17A7_Allow_Reviewers_to_bid_on_what_to_review]]
*[[CSC/ECE 517 Fall 2017/E17A9 Lazy loading (infinite scroll) for assignments courses questionnaires and user lists with Jscroll]]
*[[CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages]]
*[[CSC/ECE 517 Fall 2017/E17A5 Allow users to create an account and submit work to an "assignment" (e.g., for conference reviewing)]]
*[[CSC/ECE 517 Fall 2017/E17A3 Upgrade review input UI and sanitize text input]]
*[[CSC/ECE 517 Fall 2017/E17AA Nomination for Badges]]
*[[CSC/ECE 517 Fall 2017/E1790 Text metrics]]
*[[CSC/ECE 517 Fall 2017/E17A1 Expert Review.rb]]

'''Writing Assignment 2'''
*[[CSC/ECE 517 Fall 2017/E1779. Fix teammate advertisements and requests to join a team]]
*[[CSC/ECE_517_Fall_2017/E1773 Investigate and Fix Expertiza Production Version Runtime Exceptions.rb]]
*[[CSC/ECE_517_Fall_2017/E1774 Metareview fixes and improvements.rb]]
*[[CSC/ECE_517_Fall_2017/E1788 OSS project Maroon Heatmap fixes]]
*[[CSC/ECE 517 Fall 2017/E1781 Topic Management]]
*[[CSC/ECE_517_Fall_2017/E1745_Refactor_response_controller.rb]]
*[[CSC/ECE_517_Fall_2017/E1752 Refactor assignments controller]]
*[[CSC/ECE_517_Fall_2017/E1776_Enhance_Imports]]
*[[CSC/ECE_517_Fall_2017/E1756 TLD Refactor response.rb]]
*[[CSC/ECE_517_Fall_2017/E1772_Refactor reputation_web_service_controller.rb]]
*[[CSC/ECE_517_Fall_2017/M1753_OffscreenCanvas API]]
*[[CSC/ECE_517_Fall_2017/M1754_Mutation Testing on Servo]]
*[[CSC/ECE_517_Fall_2017/E1753 OSS project bidding tests]]
*[[CSC/ECE_517_Fall_2017/E1766_Test team functionality]]
*[[CSC/ECE 517 Fall 2017/E1767 Improve imports]]
*[[CSC/ECE_517_Fall_2017/E1786_OSS project Juniper Bookmark Enhancements]]
*[[CSC/ECE_517_Fall_2017/E1787_OSS project Bronze Score calculations]]
*[[CSC/ECE_517_Fall_2017/E1763 Fix Staggered-Deadline Assignments]]
*[[CSC/ECE 517 Fall 2017/E1757 Introduce a Student View for instructors]]
*[[CSC/ECE 517 Fall 2017/E1769_Refactor assignment_form.rb]]
*[[CSC/ECE 517 Fall 2017/E1754_Feature_test_of_rubric_advice]]
*[[CSC/ECE 517 Fall 2017/E1782 OSS Project Red Assignment Directories]]
*[[CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list]]
*[[CSC/ECE 517 Fall 2017/E1761 Test First Development Refactor assignment.rb]]
*[[CSC/ECE_517_Fall_2017/E1780_OSS_Project_Teal_Email_Notification_Enhancements]]
*[[CSC/ECE_517_Fall_2017/E1762 Test various kinds of response-map hierarchies]]
*[[CSC/ECE_517_Fall_2017/E1759 ]]
*[[CSC/ECE_517_Fall_2017/E1749_Test First Development Refactor questionnaire_controller.rb]]
*[[CSC/ECE 517 Fall 2017/E1777 Coherent specification of review requirements.rb]]
*[[CSC/ECE 517 Fall 2017/E1771_Refactor_team.rb]]
*[[CSC/ECE 517 Fall 2017/E1784 Fix mass assignments reported by Brakeman.rb]]

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-28T04:21:28Z

Ygui2: /* Screenshots of new feature */

==Introduction==
==='''Problem Statement'''===
For team-based assignments, it always takes time to find suitable team members. We already have bidding, which could help you to join in a team with other team members hold similar bidding preferences. However, you may not be satisfied with automated team formation and want to switch to another team. In this project, we will build a new feature to help students find teams to join.

Currently, there are 2 ways to find other students to join your team:

1.If your team is not full, you could invite people by inputting his/her UnityID. It will send an invitation to certain user. If s/he accept your invitation,s/he will leave original team and join your team.
2.You could create an advisement by clicking “Your team” link and then clicking “Create” link under “Advertisement for teammates” section. Then your advertisement will appear the last column of the signup sheet page with a horn icon. In this way, all classmates could see your advisement. Someone could send a request to join your team. If you accept their request, s/he will leave original team and join in your team.

It would be better for students who do not have team yet or whose team is not full yet to be able to see a list of students who don’t already have teams. So too for instructors.

== Task Description ==

Fix the second way to find other students to join your team.

Currently, after you create an advertisement, the horn icon does not appear in the the last column of the signup sheet.

For student end:

Display a list of students who do not have a team with invitation links in student_teams#view page
You could invite students to your team by clicking invitation links. If s/he accept your invitation,s/he will leave original team and join in your team. It will be more straightforward than typing UnityID.

For instructor end:

Display a list of students who do not have team in teams#list page

Write feature tests to verify your modifications:

Create team_invitation_spec.rb file in spec/features folder

==Modified Files ==
1)app/views/student_teams/view.html.erb

2)app/views/join_team_requests/_list_received.erb

3)app/controllers/join_team_requests_controller.rb

4)app/models/join_team_request.rb

5)app/models/sign_up_sheet.rb

6)app/views/sign_up_sheet/_table_line.html.erb

7)app/views/sign_up_sheet/_all_actions.html.erb

8)app/views/teams/list.html.erb

=='''Approach taken to resolve the issues'''==

===Issue1===
When someone creates an ad ,the horny icon does not appear in the the last column of the signup sheet.the code that show horny icon is below:

<% if SignUpSheet.has_teammate_ads?(topic.id) %>
<%= link_to image_tag('ad.png', :border => 0, :title => 'Ad', :align => 'middle', :style => 'width: 24px; height:24px'), :controller=>'sign_up_sheet',
:action=> 'show_team',assignment_id=>@assignment.id, :id=>topic.id%>
<% end %>

After debugging ,I found even if you create an ad before ,the if block of code will not be executed. Therefore something must be wrong with has_teammate_ads? method.Then I rewrite that method.Signupteam has an attribute:advertise_for_partner ,it will be set true after team members create an ad for their team.i return this attribute to the has_teammate_ads? method and the horny icon appears.This method code is below:
def self.has_teammate_ads?(topic_id)
@ads_exsit=false
@result=SignedUpTeam.where("topic_id = ?", topic_id.to_s)
@result.each do |result|
team=result.team
@ads_exsit=team.advertise_for_partner
end
@ads_exsit
end

===Issue2===
I found currently when you sent join team request in the ad,the team received that request would see invite and decline button on their student teams#view page.if they are willing to add the student who send request as member ,they have to send invitation and wait for reply. This is not reasonable and convenient. what should happen is that when the student send join team request,the team members could see accept and decline button ,After they click accept button ,the student would leave his/her original team and join the new team.
What I have done is that I add accept method in join team request controller.The method is below:

def accept
unless JoinTeamRequest.accept_invite(params[:team_id], @inviter_userid, @invited_userid, @assignment_id)
flash[:error] = 'The system failed to add you to the team that invited you.'
end
redirect_to view_student_teams_path student_id: params[:student_id]
end

Here @invited_userid is acquired from the student who sent join team request. inviter_userid is from the team members who received the request. team_id is invited student's team id.

===Issue3===

We build a new feature to help students find teams to join. Students who do not have teams or whose team is not full are able to see a list of students who do not haven a team.The code for this issue is showed below:
<% if @student.user_id!=nil %>
<%if @student.assignment.max_team_size > 1 %>
<% if @student.team==nil|| !@student.team.full? %>
Students without teams
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
<%if @student.team==nil
@teamid="0"
else
@teamid=@student.team.id
end%>
<td><%= form_tag :controller => 'invitations', :action => 'create' do %>
<%= hidden_field_tag 'team_id', @teamid %>
<%= hidden_field_tag 'student_id', @student.id %>
<%= hidden_field_tag 'session[:dummy][:assignment_id]', @student.parent_id %>
<%= hidden_field_tag 'user[name]', participant.user.name%>
<%= submit_tag "invite"%>
<% end %>
</td>
<% end %>
<% end %>
<% end %>
<% end %>
<% end %>
</table>
<% end %>
<% end %>

In the code above, if @student.assignment.max_team_size > 1 we then execute the below code ,this is because our new feature is only available when assignment team size greater than 1.we use if @student.team==nil|| !@student.team.full? to allow students who have no team or whose team is not full to see this list.Next we found all participants ,we use if statement to sample those who has no team , their role are students and they won't see themselves if they do not have teams.We then put these sampled participants on the list .these achieved by the code below
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
We also need to add invitation links next to students without teams,before adding links , we need to know whether students who want to invite the students on the list have team or not .if they do not have their own teams. we will automatically create a team for them ,this mechanism is called team lazy initialization.the code for this part is below
<%if @student.team==nil
@teamid="0"
else
@teamid=@student.team.id
end%>
def check_inviterteam_before_invitation
@student = AssignmentParticipant.find(params[:student_id])
@team_id=params[:team_id]
if @team_id=="0"
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@team_id=team.id
end
end
Finally we just use form_tag to create invite button which is related to invitation controller and create method in it .

===Issue4===
we also display a list of students who do not have team in teams#list page for instructor.This part of code is showed below.
<% @assignment.participants.each do |participant| %> 
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<td><%= participant.user.name %></td>
<% end %>
<% end %>
<% end %>

==Screenshots of new feature==
1)The horny icons appear in the the last column of the signup sheet.
[[File:30.png]]
[[File:31.png]]

2)Received request from advertisement and the changed team members after clicking accept button.
[[File:32.png]]
[[File:33.png]]

3)For student end ,the list of students who do not have a team with invitation links
[[File:35.png]]

4)For instructor end ,the list of students who do not have a team.
[[File:36.png]]

File:36.png

2017-11-28T04:21:02Z

Ygui2:

File:35.png

2017-11-28T04:15:19Z

Ygui2:

File:34.png

2017-11-28T04:13:09Z

Ygui2:

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-28T04:09:43Z

Ygui2: /* Screenshots of new feature */

File:33.png

2017-11-28T04:08:33Z

Ygui2:

File:32.png

2017-11-28T04:07:32Z

Ygui2:

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-28T03:50:25Z

Ygui2: /* Issue3 */

==Introduction==
==='''Problem Statement'''===
For team-based assignments, it always takes time to find suitable team members. We already have bidding, which could help you to join in a team with other team members hold similar bidding preferences. However, you may not be satisfied with automated team formation and want to switch to another team. In this project, we will build a new feature to help students find teams to join.

Currently, there are 2 ways to find other students to join your team:

1.If your team is not full, you could invite people by inputting his/her UnityID. It will send an invitation to certain user. If s/he accept your invitation,s/he will leave original team and join your team.
2.You could create an advisement by clicking “Your team” link and then clicking “Create” link under “Advertisement for teammates” section. Then your advertisement will appear the last column of the signup sheet page with a horn icon. In this way, all classmates could see your advisement. Someone could send a request to join your team. If you accept their request, s/he will leave original team and join in your team.

It would be better for students who do not have team yet or whose team is not full yet to be able to see a list of students who don’t already have teams. So too for instructors.

== Task Description ==

Fix the second way to find other students to join your team.

Currently, after you create an advertisement, the horn icon does not appear in the the last column of the signup sheet.

For student end:

Display a list of students who do not have a team with invitation links in student_teams#view page
You could invite students to your team by clicking invitation links. If s/he accept your invitation,s/he will leave original team and join in your team. It will be more straightforward than typing UnityID.

For instructor end:

Display a list of students who do not have team in teams#list page

Write feature tests to verify your modifications:

Create team_invitation_spec.rb file in spec/features folder

==Modified Files ==
1)app/views/student_teams/view.html.erb

2)app/views/join_team_requests/_list_received.erb

3)app/controllers/join_team_requests_controller.rb

4)app/models/join_team_request.rb

5)app/models/sign_up_sheet.rb

6)app/views/sign_up_sheet/_table_line.html.erb

7)app/views/sign_up_sheet/_all_actions.html.erb

8)app/views/teams/list.html.erb

=='''Approach taken to resolve the issues'''==

===Issue1===
When someone creates an ad ,the horny icon does not appear in the the last column of the signup sheet.the code that show horny icon is below:

<% if SignUpSheet.has_teammate_ads?(topic.id) %>
<%= link_to image_tag('ad.png', :border => 0, :title => 'Ad', :align => 'middle', :style => 'width: 24px; height:24px'), :controller=>'sign_up_sheet',
:action=> 'show_team',assignment_id=>@assignment.id, :id=>topic.id%>
<% end %>

After debugging ,I found even if you create an ad before ,the if block of code will not be executed. Therefore something must be wrong with has_teammate_ads? method.Then I rewrite that method.Signupteam has an attribute:advertise_for_partner ,it will be set true after team members create an ad for their team.i return this attribute to the has_teammate_ads? method and the horny icon appears.This method code is below:
def self.has_teammate_ads?(topic_id)
@ads_exsit=false
@result=SignedUpTeam.where("topic_id = ?", topic_id.to_s)
@result.each do |result|
team=result.team
@ads_exsit=team.advertise_for_partner
end
@ads_exsit
end

===Issue2===
I found currently when you sent join team request in the ad,the team received that request would see invite and decline button on their student teams#view page.if they are willing to add the student who send request as member ,they have to send invitation and wait for reply. This is not reasonable and convenient. what should happen is that when the student send join team request,the team members could see accept and decline button ,After they click accept button ,the student would leave his/her original team and join the new team.
What I have done is that I add accept method in join team request controller.The method is below:

def accept
unless JoinTeamRequest.accept_invite(params[:team_id], @inviter_userid, @invited_userid, @assignment_id)
flash[:error] = 'The system failed to add you to the team that invited you.'
end
redirect_to view_student_teams_path student_id: params[:student_id]
end

Here @invited_userid is acquired from the student who sent join team request. inviter_userid is from the team members who received the request. team_id is invited student's team id.

===Issue3===

We build a new feature to help students find teams to join. Students who do not have teams or whose team is not full are able to see a list of students who do not haven a team.The code for this issue is showed below:
<% if @student.user_id!=nil %>
<%if @student.assignment.max_team_size > 1 %>
<% if @student.team==nil|| !@student.team.full? %>
Students without teams
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
<%if @student.team==nil
@teamid="0"
else
@teamid=@student.team.id
end%>
<td><%= form_tag :controller => 'invitations', :action => 'create' do %>
<%= hidden_field_tag 'team_id', @teamid %>
<%= hidden_field_tag 'student_id', @student.id %>
<%= hidden_field_tag 'session[:dummy][:assignment_id]', @student.parent_id %>
<%= hidden_field_tag 'user[name]', participant.user.name%>
<%= submit_tag "invite"%>
<% end %>
</td>
<% end %>
<% end %>
<% end %>
<% end %>
<% end %>
</table>
<% end %>
<% end %>

In the code above, if @student.assignment.max_team_size > 1 we then execute the below code ,this is because our new feature is only available when assignment team size greater than 1.we use if @student.team==nil|| !@student.team.full? to allow students who have no team or whose team is not full to see this list.Next we found all participants ,we use if statement to sample those who has no team , their role are students and they won't see themselves if they do not have teams.We then put these sampled participants on the list .these achieved by the code below
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
We also need to add invitation links next to students without teams,before adding links , we need to know whether students who want to invite the students on the list have team or not .if they do not have their own teams. we will automatically create a team for them ,this mechanism is called team lazy initialization.the code for this part is below
<%if @student.team==nil
@teamid="0"
else
@teamid=@student.team.id
end%>
def check_inviterteam_before_invitation
@student = AssignmentParticipant.find(params[:student_id])
@team_id=params[:team_id]
if @team_id=="0"
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@team_id=team.id
end
end
Finally we just use form_tag to create invite button which is related to invitation controller and create method in it .

===Issue4===
we also display a list of students who do not have team in teams#list page for instructor.This part of code is showed below.
<% @assignment.participants.each do |participant| %> 
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<td><%= participant.user.name %></td>
<% end %>
<% end %>
<% end %>

==Screenshots of new feature==
1)The horny icons appear in the the last column of the signup sheet.
[[File:30.png]]
[[File:31.png]]

2)For student end ,the list of students who do not have a team with invitation links

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-28T03:46:18Z

Ygui2: /* Issue3 */

==Introduction==
==='''Problem Statement'''===
For team-based assignments, it always takes time to find suitable team members. We already have bidding, which could help you to join in a team with other team members hold similar bidding preferences. However, you may not be satisfied with automated team formation and want to switch to another team. In this project, we will build a new feature to help students find teams to join.

Currently, there are 2 ways to find other students to join your team:

1.If your team is not full, you could invite people by inputting his/her UnityID. It will send an invitation to certain user. If s/he accept your invitation,s/he will leave original team and join your team.
2.You could create an advisement by clicking “Your team” link and then clicking “Create” link under “Advertisement for teammates” section. Then your advertisement will appear the last column of the signup sheet page with a horn icon. In this way, all classmates could see your advisement. Someone could send a request to join your team. If you accept their request, s/he will leave original team and join in your team.

It would be better for students who do not have team yet or whose team is not full yet to be able to see a list of students who don’t already have teams. So too for instructors.

== Task Description ==

Fix the second way to find other students to join your team.

Currently, after you create an advertisement, the horn icon does not appear in the the last column of the signup sheet.

For student end:

Display a list of students who do not have a team with invitation links in student_teams#view page
You could invite students to your team by clicking invitation links. If s/he accept your invitation,s/he will leave original team and join in your team. It will be more straightforward than typing UnityID.

For instructor end:

Display a list of students who do not have team in teams#list page

Write feature tests to verify your modifications:

Create team_invitation_spec.rb file in spec/features folder

==Modified Files ==
1)app/views/student_teams/view.html.erb

2)app/views/join_team_requests/_list_received.erb

3)app/controllers/join_team_requests_controller.rb

4)app/models/join_team_request.rb

5)app/models/sign_up_sheet.rb

6)app/views/sign_up_sheet/_table_line.html.erb

7)app/views/sign_up_sheet/_all_actions.html.erb

8)app/views/teams/list.html.erb

=='''Approach taken to resolve the issues'''==

===Issue1===
When someone creates an ad ,the horny icon does not appear in the the last column of the signup sheet.the code that show horny icon is below:

<% if SignUpSheet.has_teammate_ads?(topic.id) %>
<%= link_to image_tag('ad.png', :border => 0, :title => 'Ad', :align => 'middle', :style => 'width: 24px; height:24px'), :controller=>'sign_up_sheet',
:action=> 'show_team',assignment_id=>@assignment.id, :id=>topic.id%>
<% end %>

After debugging ,I found even if you create an ad before ,the if block of code will not be executed. Therefore something must be wrong with has_teammate_ads? method.Then I rewrite that method.Signupteam has an attribute:advertise_for_partner ,it will be set true after team members create an ad for their team.i return this attribute to the has_teammate_ads? method and the horny icon appears.This method code is below:
def self.has_teammate_ads?(topic_id)
@ads_exsit=false
@result=SignedUpTeam.where("topic_id = ?", topic_id.to_s)
@result.each do |result|
team=result.team
@ads_exsit=team.advertise_for_partner
end
@ads_exsit
end

===Issue2===
I found currently when you sent join team request in the ad,the team received that request would see invite and decline button on their student teams#view page.if they are willing to add the student who send request as member ,they have to send invitation and wait for reply. This is not reasonable and convenient. what should happen is that when the student send join team request,the team members could see accept and decline button ,After they click accept button ,the student would leave his/her original team and join the new team.
What I have done is that I add accept method in join team request controller.The method is below:

def accept
unless JoinTeamRequest.accept_invite(params[:team_id], @inviter_userid, @invited_userid, @assignment_id)
flash[:error] = 'The system failed to add you to the team that invited you.'
end
redirect_to view_student_teams_path student_id: params[:student_id]
end

Here @invited_userid is acquired from the student who sent join team request. inviter_userid is from the team members who received the request. team_id is invited student's team id.

===Issue3===

We build a new feature to help students find teams to join. Students who do not have teams or whose team is not full are able to see a list of students who do not haven a team.The code for this issue is showed below:
<% if @student.user_id!=nil %>
<%if @student.assignment.max_team_size > 1 %>
<% if @student.team==nil|| !@student.team.full? %>
Students without teams
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
<%if @student.team==nil
@teamid="0"
else
@teamid=@student.team.id
end%>
<td><%= form_tag :controller => 'invitations', :action => 'create' do %>
<%= hidden_field_tag 'team_id', @teamid %>
<%= hidden_field_tag 'student_id', @student.id %>
<%= hidden_field_tag 'session[:dummy][:assignment_id]', @student.parent_id %>
<%= hidden_field_tag 'user[name]', participant.user.name%>
<%= submit_tag "invite"%>
<% end %>
</td>
<% end %>
<% end %>
<% end %>
<% end %>
<% end %>
</table>
<% end %>
<% end %>

In the code above, if @student.assignment.max_team_size > 1 we then execute the below code ,this is because our new feature is only available when assignment team size greater than 1.we use if @student.team==nil|| !@student.team.full? to allow students who have no team or whose team is not full to see this list.Next we found all participants ,we use if statement to sample those who has no team , their role are students and they won't see themselves if they do not have teams.We then put these sampled participants on the list .these achieved by the code below
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
We also need to add invitation links next to students without teams,before adding links , we need to know whether students who want to invite the students on the list have team or not .if they do not have their own teams. we will automatically create a team for them ,this mechanism is called team lazy initialization.the code for this part is below
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
Finally we just use form_tag to create invite button which is related to invitation controller and create method in it .

===Issue4===
we also display a list of students who do not have team in teams#list page for instructor.This part of code is showed below.
<% @assignment.participants.each do |participant| %> 
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<td><%= participant.user.name %></td>
<% end %>
<% end %>
<% end %>

==Screenshots of new feature==
1)The horny icons appear in the the last column of the signup sheet.
[[File:30.png]]
[[File:31.png]]

2)For student end ,the list of students who do not have a team with invitation links

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T23:16:17Z

Ygui2: /* Screenshots of new feature */

==Introduction==
==='''Problem Statement'''===
For team-based assignments, it always takes time to find suitable team members. We already have bidding, which could help you to join in a team with other team members hold similar bidding preferences. However, you may not be satisfied with automated team formation and want to switch to another team. In this project, we will build a new feature to help students find teams to join.

Currently, there are 2 ways to find other students to join your team:

1.If your team is not full, you could invite people by inputting his/her UnityID. It will send an invitation to certain user. If s/he accept your invitation,s/he will leave original team and join your team.
2.You could create an advisement by clicking “Your team” link and then clicking “Create” link under “Advertisement for teammates” section. Then your advertisement will appear the last column of the signup sheet page with a horn icon. In this way, all classmates could see your advisement. Someone could send a request to join your team. If you accept their request, s/he will leave original team and join in your team.

It would be better for students who do not have team yet or whose team is not full yet to be able to see a list of students who don’t already have teams. So too for instructors.

== Task Description ==

Fix the second way to find other students to join your team.

Currently, after you create an advertisement, the horn icon does not appear in the the last column of the signup sheet.

For student end:

Display a list of students who do not have a team with invitation links in student_teams#view page
You could invite students to your team by clicking invitation links. If s/he accept your invitation,s/he will leave original team and join in your team. It will be more straightforward than typing UnityID.

For instructor end:

Display a list of students who do not have team in teams#list page

Write feature tests to verify your modifications:

Create team_invitation_spec.rb file in spec/features folder

==Modified Files ==
1)app/views/student_teams/view.html.erb

2)app/views/join_team_requests/_list_received.erb

3)app/controllers/join_team_requests_controller.rb

4)app/models/join_team_request.rb

5)app/models/sign_up_sheet.rb

6)app/views/sign_up_sheet/_table_line.html.erb

7)app/views/sign_up_sheet/_all_actions.html.erb

8)app/views/teams/list.html.erb

=='''Approach taken to resolve the issues'''==

===Issue1===
When someone creates an ad ,the horny icon does not appear in the the last column of the signup sheet.the code that show horny icon is below:

<% if SignUpSheet.has_teammate_ads?(topic.id) %>
<%= link_to image_tag('ad.png', :border => 0, :title => 'Ad', :align => 'middle', :style => 'width: 24px; height:24px'), :controller=>'sign_up_sheet',
:action=> 'show_team',assignment_id=>@assignment.id, :id=>topic.id%>
<% end %>

After debugging ,I found even if you create an ad before ,the if block of code will not be executed. Therefore something must be wrong with has_teammate_ads? method.Then I rewrite that method.Signupteam has an attribute:advertise_for_partner ,it will be set true after team members create an ad for their team.i return this attribute to the has_teammate_ads? method and the horny icon appears.This method code is below:
def self.has_teammate_ads?(topic_id)
@ads_exsit=false
@result=SignedUpTeam.where("topic_id = ?", topic_id.to_s)
@result.each do |result|
team=result.team
@ads_exsit=team.advertise_for_partner
end
@ads_exsit
end

===Issue2===
I found currently when you sent join team request in the ad,the team received that request would see invite and decline button on their student teams#view page.if they are willing to add the student who send request as member ,they have to send invitation and wait for reply. This is not reasonable and convenient. what should happen is that when the student send join team request,the team members could see accept and decline button ,After they click accept button ,the student would leave his/her original team and join the new team.
What I have done is that I add accept method in join team request controller.The method is below:

def accept
unless JoinTeamRequest.accept_invite(params[:team_id], @inviter_userid, @invited_userid, @assignment_id)
flash[:error] = 'The system failed to add you to the team that invited you.'
end
redirect_to view_student_teams_path student_id: params[:student_id]
end

Here @invited_userid is acquired from the student who sent join team request. inviter_userid is from the team members who received the request. team_id is invited student's team id.

===Issue3===

We build a new feature to help students find teams to join. Students who do not have teams or whose team is not full are able to see a list of students who do not haven a team.The code for this issue is showed below:
<% if @student.user_id!=nil %>
<%if @student.assignment.max_team_size > 1 %>
<% if @student.team==nil|| !@student.team.full? %>
Students without teams
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
else
@teamid=@student.team.id
end%>
<td><%= form_tag :controller => 'invitations', :action => 'create' do %>
<%= hidden_field_tag 'team_id', @teamid %>
<%= hidden_field_tag 'student_id', @student.id %>
<%= hidden_field_tag 'session[:dummy][:assignment_id]', @student.parent_id %>
<%= hidden_field_tag 'user[name]', participant.user.name%>
<%= submit_tag "invite"%>
<% end %>
</td>
<% end %>
<% end %>
<% end %>
<% end %>
<% end %>
</table>
<% end %>
<% end %>

In the code above, if @student.assignment.max_team_size > 1 we then execute the below code ,this is because our new feature is only available when assignment team size greater than 1.we use if @student.team==nil|| !@student.team.full? to allow students who have no team or whose team is not full to see this list.Next we found all participants ,we use if statement to sample those who has no team , their role are students and they won't see themselves if they do not have teams.We then put these sampled participants on the list .these achieved by the code below
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
We also need to add invitation links next to students without teams,before adding links , we need to know whether students who want to invite the students on the list have team or not .if they do not have their own teams. we will automatically create a team for them ,this mechanism is called team lazy initialization.the code for this part is below
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
Finally we just use form_tag to create invite button which is related to invitation controller and create method in it .

===Issue4===
we also display a list of students who do not have team in teams#list page for instructor.This part of code is showed below.
<% @assignment.participants.each do |participant| %> 
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<td><%= participant.user.name %></td>
<% end %>
<% end %>
<% end %>

==Screenshots of new feature==
1)The horny icons appear in the the last column of the signup sheet.
[[File:30.png]]
[[File:31.png]]

2)For student end ,the list of students who do not have a team with invitation links

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T23:09:30Z

Ygui2: /* Screenshots of new feature */

==Introduction==
==='''Problem Statement'''===
For team-based assignments, it always takes time to find suitable team members. We already have bidding, which could help you to join in a team with other team members hold similar bidding preferences. However, you may not be satisfied with automated team formation and want to switch to another team. In this project, we will build a new feature to help students find teams to join.

Currently, there are 2 ways to find other students to join your team:

1.If your team is not full, you could invite people by inputting his/her UnityID. It will send an invitation to certain user. If s/he accept your invitation,s/he will leave original team and join your team.
2.You could create an advisement by clicking “Your team” link and then clicking “Create” link under “Advertisement for teammates” section. Then your advertisement will appear the last column of the signup sheet page with a horn icon. In this way, all classmates could see your advisement. Someone could send a request to join your team. If you accept their request, s/he will leave original team and join in your team.

It would be better for students who do not have team yet or whose team is not full yet to be able to see a list of students who don’t already have teams. So too for instructors.

== Task Description ==

Fix the second way to find other students to join your team.

Currently, after you create an advertisement, the horn icon does not appear in the the last column of the signup sheet.

For student end:

Display a list of students who do not have a team with invitation links in student_teams#view page
You could invite students to your team by clicking invitation links. If s/he accept your invitation,s/he will leave original team and join in your team. It will be more straightforward than typing UnityID.

For instructor end:

Display a list of students who do not have team in teams#list page

Write feature tests to verify your modifications:

Create team_invitation_spec.rb file in spec/features folder

==Modified Files ==
1)app/views/student_teams/view.html.erb

2)app/views/join_team_requests/_list_received.erb

3)app/controllers/join_team_requests_controller.rb

4)app/models/join_team_request.rb

5)app/models/sign_up_sheet.rb

6)app/views/sign_up_sheet/_table_line.html.erb

7)app/views/sign_up_sheet/_all_actions.html.erb

8)app/views/teams/list.html.erb

=='''Approach taken to resolve the issues'''==

===Issue1===
When someone creates an ad ,the horny icon does not appear in the the last column of the signup sheet.the code that show horny icon is below:

<% if SignUpSheet.has_teammate_ads?(topic.id) %>
<%= link_to image_tag('ad.png', :border => 0, :title => 'Ad', :align => 'middle', :style => 'width: 24px; height:24px'), :controller=>'sign_up_sheet',
:action=> 'show_team',assignment_id=>@assignment.id, :id=>topic.id%>
<% end %>

After debugging ,I found even if you create an ad before ,the if block of code will not be executed. Therefore something must be wrong with has_teammate_ads? method.Then I rewrite that method.Signupteam has an attribute:advertise_for_partner ,it will be set true after team members create an ad for their team.i return this attribute to the has_teammate_ads? method and the horny icon appears.This method code is below:
def self.has_teammate_ads?(topic_id)
@ads_exsit=false
@result=SignedUpTeam.where("topic_id = ?", topic_id.to_s)
@result.each do |result|
team=result.team
@ads_exsit=team.advertise_for_partner
end
@ads_exsit
end

===Issue2===
I found currently when you sent join team request in the ad,the team received that request would see invite and decline button on their student teams#view page.if they are willing to add the student who send request as member ,they have to send invitation and wait for reply. This is not reasonable and convenient. what should happen is that when the student send join team request,the team members could see accept and decline button ,After they click accept button ,the student would leave his/her original team and join the new team.
What I have done is that I add accept method in join team request controller.The method is below:

def accept
unless JoinTeamRequest.accept_invite(params[:team_id], @inviter_userid, @invited_userid, @assignment_id)
flash[:error] = 'The system failed to add you to the team that invited you.'
end
redirect_to view_student_teams_path student_id: params[:student_id]
end

Here @invited_userid is acquired from the student who sent join team request. inviter_userid is from the team members who received the request. team_id is invited student's team id.

===Issue3===

We build a new feature to help students find teams to join. Students who do not have teams or whose team is not full are able to see a list of students who do not haven a team.The code for this issue is showed below:
<% if @student.user_id!=nil %>
<%if @student.assignment.max_team_size > 1 %>
<% if @student.team==nil|| !@student.team.full? %>
Students without teams
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
else
@teamid=@student.team.id
end%>
<td><%= form_tag :controller => 'invitations', :action => 'create' do %>
<%= hidden_field_tag 'team_id', @teamid %>
<%= hidden_field_tag 'student_id', @student.id %>
<%= hidden_field_tag 'session[:dummy][:assignment_id]', @student.parent_id %>
<%= hidden_field_tag 'user[name]', participant.user.name%>
<%= submit_tag "invite"%>
<% end %>
</td>
<% end %>
<% end %>
<% end %>
<% end %>
<% end %>
</table>
<% end %>
<% end %>

In the code above, if @student.assignment.max_team_size > 1 we then execute the below code ,this is because our new feature is only available when assignment team size greater than 1.we use if @student.team==nil|| !@student.team.full? to allow students who have no team or whose team is not full to see this list.Next we found all participants ,we use if statement to sample those who has no team , their role are students and they won't see themselves if they do not have teams.We then put these sampled participants on the list .these achieved by the code below
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
We also need to add invitation links next to students without teams,before adding links , we need to know whether students who want to invite the students on the list have team or not .if they do not have their own teams. we will automatically create a team for them ,this mechanism is called team lazy initialization.the code for this part is below
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
Finally we just use form_tag to create invite button which is related to invitation controller and create method in it .

===Issue4===
we also display a list of students who do not have team in teams#list page for instructor.This part of code is showed below.
<% @assignment.participants.each do |participant| %> 
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<td><%= participant.user.name %></td>
<% end %>
<% end %>
<% end %>

==Screenshots of new feature==
1)The horny icons appear in the the last column of the signup sheet.
[[File:30.png]]
[[File:31.png]]

File:31.png

2017-11-27T23:08:57Z

Ygui2:

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T23:07:21Z

Ygui2: /* Screenshots of new feature */

==Introduction==
==='''Problem Statement'''===
For team-based assignments, it always takes time to find suitable team members. We already have bidding, which could help you to join in a team with other team members hold similar bidding preferences. However, you may not be satisfied with automated team formation and want to switch to another team. In this project, we will build a new feature to help students find teams to join.

Currently, there are 2 ways to find other students to join your team:

1.If your team is not full, you could invite people by inputting his/her UnityID. It will send an invitation to certain user. If s/he accept your invitation,s/he will leave original team and join your team.
2.You could create an advisement by clicking “Your team” link and then clicking “Create” link under “Advertisement for teammates” section. Then your advertisement will appear the last column of the signup sheet page with a horn icon. In this way, all classmates could see your advisement. Someone could send a request to join your team. If you accept their request, s/he will leave original team and join in your team.

It would be better for students who do not have team yet or whose team is not full yet to be able to see a list of students who don’t already have teams. So too for instructors.

== Task Description ==

Fix the second way to find other students to join your team.

Currently, after you create an advertisement, the horn icon does not appear in the the last column of the signup sheet.

For student end:

Display a list of students who do not have a team with invitation links in student_teams#view page
You could invite students to your team by clicking invitation links. If s/he accept your invitation,s/he will leave original team and join in your team. It will be more straightforward than typing UnityID.

For instructor end:

Display a list of students who do not have team in teams#list page

Write feature tests to verify your modifications:

Create team_invitation_spec.rb file in spec/features folder

==Modified Files ==
1)app/views/student_teams/view.html.erb

2)app/views/join_team_requests/_list_received.erb

3)app/controllers/join_team_requests_controller.rb

4)app/models/join_team_request.rb

5)app/models/sign_up_sheet.rb

6)app/views/sign_up_sheet/_table_line.html.erb

7)app/views/sign_up_sheet/_all_actions.html.erb

8)app/views/teams/list.html.erb

=='''Approach taken to resolve the issues'''==

===Issue1===
When someone creates an ad ,the horny icon does not appear in the the last column of the signup sheet.the code that show horny icon is below:

<% if SignUpSheet.has_teammate_ads?(topic.id) %>
<%= link_to image_tag('ad.png', :border => 0, :title => 'Ad', :align => 'middle', :style => 'width: 24px; height:24px'), :controller=>'sign_up_sheet',
:action=> 'show_team',assignment_id=>@assignment.id, :id=>topic.id%>
<% end %>

After debugging ,I found even if you create an ad before ,the if block of code will not be executed. Therefore something must be wrong with has_teammate_ads? method.Then I rewrite that method.Signupteam has an attribute:advertise_for_partner ,it will be set true after team members create an ad for their team.i return this attribute to the has_teammate_ads? method and the horny icon appears.This method code is below:
def self.has_teammate_ads?(topic_id)
@ads_exsit=false
@result=SignedUpTeam.where("topic_id = ?", topic_id.to_s)
@result.each do |result|
team=result.team
@ads_exsit=team.advertise_for_partner
end
@ads_exsit
end

===Issue2===
I found currently when you sent join team request in the ad,the team received that request would see invite and decline button on their student teams#view page.if they are willing to add the student who send request as member ,they have to send invitation and wait for reply. This is not reasonable and convenient. what should happen is that when the student send join team request,the team members could see accept and decline button ,After they click accept button ,the student would leave his/her original team and join the new team.
What I have done is that I add accept method in join team request controller.The method is below:

def accept
unless JoinTeamRequest.accept_invite(params[:team_id], @inviter_userid, @invited_userid, @assignment_id)
flash[:error] = 'The system failed to add you to the team that invited you.'
end
redirect_to view_student_teams_path student_id: params[:student_id]
end

Here @invited_userid is acquired from the student who sent join team request. inviter_userid is from the team members who received the request. team_id is invited student's team id.

===Issue3===

We build a new feature to help students find teams to join. Students who do not have teams or whose team is not full are able to see a list of students who do not haven a team.The code for this issue is showed below:
<% if @student.user_id!=nil %>
<%if @student.assignment.max_team_size > 1 %>
<% if @student.team==nil|| !@student.team.full? %>
Students without teams
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
else
@teamid=@student.team.id
end%>
<td><%= form_tag :controller => 'invitations', :action => 'create' do %>
<%= hidden_field_tag 'team_id', @teamid %>
<%= hidden_field_tag 'student_id', @student.id %>
<%= hidden_field_tag 'session[:dummy][:assignment_id]', @student.parent_id %>
<%= hidden_field_tag 'user[name]', participant.user.name%>
<%= submit_tag "invite"%>
<% end %>
</td>
<% end %>
<% end %>
<% end %>
<% end %>
<% end %>
</table>
<% end %>
<% end %>

In the code above, if @student.assignment.max_team_size > 1 we then execute the below code ,this is because our new feature is only available when assignment team size greater than 1.we use if @student.team==nil|| !@student.team.full? to allow students who have no team or whose team is not full to see this list.Next we found all participants ,we use if statement to sample those who has no team , their role are students and they won't see themselves if they do not have teams.We then put these sampled participants on the list .these achieved by the code below
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
We also need to add invitation links next to students without teams,before adding links , we need to know whether students who want to invite the students on the list have team or not .if they do not have their own teams. we will automatically create a team for them ,this mechanism is called team lazy initialization.the code for this part is below
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
Finally we just use form_tag to create invite button which is related to invitation controller and create method in it .

===Issue4===
we also display a list of students who do not have team in teams#list page for instructor.This part of code is showed below.
<% @assignment.participants.each do |participant| %> 
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<td><%= participant.user.name %></td>
<% end %>
<% end %>
<% end %>

==Screenshots of new feature==
1)The horny icons appear in the the last column of the signup sheet.
[[File:30.png]]

File:30.png

2017-11-27T23:06:49Z

Ygui2: uploaded a new version of "File:30.png"

File:30.png

2017-11-27T23:00:43Z

Ygui2:

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T22:06:45Z

Ygui2: /* Issue4 */

==Introduction==
==='''Problem Statement'''===
For team-based assignments, it always takes time to find suitable team members. We already have bidding, which could help you to join in a team with other team members hold similar bidding preferences. However, you may not be satisfied with automated team formation and want to switch to another team. In this project, we will build a new feature to help students find teams to join.

Currently, there are 2 ways to find other students to join your team:

1.If your team is not full, you could invite people by inputting his/her UnityID. It will send an invitation to certain user. If s/he accept your invitation,s/he will leave original team and join your team.
2.You could create an advisement by clicking “Your team” link and then clicking “Create” link under “Advertisement for teammates” section. Then your advertisement will appear the last column of the signup sheet page with a horn icon. In this way, all classmates could see your advisement. Someone could send a request to join your team. If you accept their request, s/he will leave original team and join in your team.

It would be better for students who do not have team yet or whose team is not full yet to be able to see a list of students who don’t already have teams. So too for instructors.

== Task Description ==

Fix the second way to find other students to join your team.

Currently, after you create an advertisement, the horn icon does not appear in the the last column of the signup sheet.

For student end:

Display a list of students who do not have a team with invitation links in student_teams#view page
You could invite students to your team by clicking invitation links. If s/he accept your invitation,s/he will leave original team and join in your team. It will be more straightforward than typing UnityID.

For instructor end:

Display a list of students who do not have team in teams#list page

Write feature tests to verify your modifications:

Create team_invitation_spec.rb file in spec/features folder

==Modified Files ==
1)app/views/student_teams/view.html.erb

2)app/views/join_team_requests/_list_received.erb

3)app/controllers/join_team_requests_controller.rb

4)app/models/join_team_request.rb

5)app/models/sign_up_sheet.rb

6)app/views/sign_up_sheet/_table_line.html.erb

7)app/views/sign_up_sheet/_all_actions.html.erb

8)app/views/teams/list.html.erb

=='''Approach taken to resolve the issues'''==

===Issue1===
When someone creates an ad ,the horny icon does not appear in the the last column of the signup sheet.the code that show horny icon is below:

<% if SignUpSheet.has_teammate_ads?(topic.id) %>
<%= link_to image_tag('ad.png', :border => 0, :title => 'Ad', :align => 'middle', :style => 'width: 24px; height:24px'), :controller=>'sign_up_sheet',
:action=> 'show_team',assignment_id=>@assignment.id, :id=>topic.id%>
<% end %>

After debugging ,I found even if you create an ad before ,the if block of code will not be executed. Therefore something must be wrong with has_teammate_ads? method.Then I rewrite that method.Signupteam has an attribute:advertise_for_partner ,it will be set true after team members create an ad for their team.i return this attribute to the has_teammate_ads? method and the horny icon appears.This method code is below:
def self.has_teammate_ads?(topic_id)
@ads_exsit=false
@result=SignedUpTeam.where("topic_id = ?", topic_id.to_s)
@result.each do |result|
team=result.team
@ads_exsit=team.advertise_for_partner
end
@ads_exsit
end

===Issue2===
I found currently when you sent join team request in the ad,the team received that request would see invite and decline button on their student teams#view page.if they are willing to add the student who send request as member ,they have to send invitation and wait for reply. This is not reasonable and convenient. what should happen is that when the student send join team request,the team members could see accept and decline button ,After they click accept button ,the student would leave his/her original team and join the new team.
What I have done is that I add accept method in join team request controller.The method is below:

def accept
unless JoinTeamRequest.accept_invite(params[:team_id], @inviter_userid, @invited_userid, @assignment_id)
flash[:error] = 'The system failed to add you to the team that invited you.'
end
redirect_to view_student_teams_path student_id: params[:student_id]
end

Here @invited_userid is acquired from the student who sent join team request. inviter_userid is from the team members who received the request. team_id is invited student's team id.

===Issue3===

We build a new feature to help students find teams to join. Students who do not have teams or whose team is not full are able to see a list of students who do not haven a team.The code for this issue is showed below:
<% if @student.user_id!=nil %>
<%if @student.assignment.max_team_size > 1 %>
<% if @student.team==nil|| !@student.team.full? %>
Students without teams
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
else
@teamid=@student.team.id
end%>
<td><%= form_tag :controller => 'invitations', :action => 'create' do %>
<%= hidden_field_tag 'team_id', @teamid %>
<%= hidden_field_tag 'student_id', @student.id %>
<%= hidden_field_tag 'session[:dummy][:assignment_id]', @student.parent_id %>
<%= hidden_field_tag 'user[name]', participant.user.name%>
<%= submit_tag "invite"%>
<% end %>
</td>
<% end %>
<% end %>
<% end %>
<% end %>
<% end %>
</table>
<% end %>
<% end %>

In the code above, if @student.assignment.max_team_size > 1 we then execute the below code ,this is because our new feature is only available when assignment team size greater than 1.we use if @student.team==nil|| !@student.team.full? to allow students who have no team or whose team is not full to see this list.Next we found all participants ,we use if statement to sample those who has no team , their role are students and they won't see themselves if they do not have teams.We then put these sampled participants on the list .these achieved by the code below
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
We also need to add invitation links next to students without teams,before adding links , we need to know whether students who want to invite the students on the list have team or not .if they do not have their own teams. we will automatically create a team for them ,this mechanism is called team lazy initialization.the code for this part is below
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
Finally we just use form_tag to create invite button which is related to invitation controller and create method in it .

===Issue4===
we also display a list of students who do not have team in teams#list page for instructor.This part of code is showed below.
<% @assignment.participants.each do |participant| %> 
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<td><%= participant.user.name %></td>
<% end %>
<% end %>
<% end %>

==Screenshots of new feature==

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T22:04:30Z

Ygui2: /* Issue3 */

==Introduction==
==='''Problem Statement'''===
For team-based assignments, it always takes time to find suitable team members. We already have bidding, which could help you to join in a team with other team members hold similar bidding preferences. However, you may not be satisfied with automated team formation and want to switch to another team. In this project, we will build a new feature to help students find teams to join.

Currently, there are 2 ways to find other students to join your team:

1.If your team is not full, you could invite people by inputting his/her UnityID. It will send an invitation to certain user. If s/he accept your invitation,s/he will leave original team and join your team.
2.You could create an advisement by clicking “Your team” link and then clicking “Create” link under “Advertisement for teammates” section. Then your advertisement will appear the last column of the signup sheet page with a horn icon. In this way, all classmates could see your advisement. Someone could send a request to join your team. If you accept their request, s/he will leave original team and join in your team.

It would be better for students who do not have team yet or whose team is not full yet to be able to see a list of students who don’t already have teams. So too for instructors.

== Task Description ==

Fix the second way to find other students to join your team.

Currently, after you create an advertisement, the horn icon does not appear in the the last column of the signup sheet.

For student end:

Display a list of students who do not have a team with invitation links in student_teams#view page
You could invite students to your team by clicking invitation links. If s/he accept your invitation,s/he will leave original team and join in your team. It will be more straightforward than typing UnityID.

For instructor end:

Display a list of students who do not have team in teams#list page

Write feature tests to verify your modifications:

Create team_invitation_spec.rb file in spec/features folder

==Modified Files ==
1)app/views/student_teams/view.html.erb

2)app/views/join_team_requests/_list_received.erb

3)app/controllers/join_team_requests_controller.rb

4)app/models/join_team_request.rb

5)app/models/sign_up_sheet.rb

6)app/views/sign_up_sheet/_table_line.html.erb

7)app/views/sign_up_sheet/_all_actions.html.erb

8)app/views/teams/list.html.erb

=='''Approach taken to resolve the issues'''==

===Issue1===
When someone creates an ad ,the horny icon does not appear in the the last column of the signup sheet.the code that show horny icon is below:

<% if SignUpSheet.has_teammate_ads?(topic.id) %>
<%= link_to image_tag('ad.png', :border => 0, :title => 'Ad', :align => 'middle', :style => 'width: 24px; height:24px'), :controller=>'sign_up_sheet',
:action=> 'show_team',assignment_id=>@assignment.id, :id=>topic.id%>
<% end %>

After debugging ,I found even if you create an ad before ,the if block of code will not be executed. Therefore something must be wrong with has_teammate_ads? method.Then I rewrite that method.Signupteam has an attribute:advertise_for_partner ,it will be set true after team members create an ad for their team.i return this attribute to the has_teammate_ads? method and the horny icon appears.This method code is below:
def self.has_teammate_ads?(topic_id)
@ads_exsit=false
@result=SignedUpTeam.where("topic_id = ?", topic_id.to_s)
@result.each do |result|
team=result.team
@ads_exsit=team.advertise_for_partner
end
@ads_exsit
end

===Issue2===
I found currently when you sent join team request in the ad,the team received that request would see invite and decline button on their student teams#view page.if they are willing to add the student who send request as member ,they have to send invitation and wait for reply. This is not reasonable and convenient. what should happen is that when the student send join team request,the team members could see accept and decline button ,After they click accept button ,the student would leave his/her original team and join the new team.
What I have done is that I add accept method in join team request controller.The method is below:

def accept
unless JoinTeamRequest.accept_invite(params[:team_id], @inviter_userid, @invited_userid, @assignment_id)
flash[:error] = 'The system failed to add you to the team that invited you.'
end
redirect_to view_student_teams_path student_id: params[:student_id]
end

Here @invited_userid is acquired from the student who sent join team request. inviter_userid is from the team members who received the request. team_id is invited student's team id.

===Issue3===

We build a new feature to help students find teams to join. Students who do not have teams or whose team is not full are able to see a list of students who do not haven a team.The code for this issue is showed below:
<% if @student.user_id!=nil %>
<%if @student.assignment.max_team_size > 1 %>
<% if @student.team==nil|| !@student.team.full? %>
Students without teams
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
else
@teamid=@student.team.id
end%>
<td><%= form_tag :controller => 'invitations', :action => 'create' do %>
<%= hidden_field_tag 'team_id', @teamid %>
<%= hidden_field_tag 'student_id', @student.id %>
<%= hidden_field_tag 'session[:dummy][:assignment_id]', @student.parent_id %>
<%= hidden_field_tag 'user[name]', participant.user.name%>
<%= submit_tag "invite"%>
<% end %>
</td>
<% end %>
<% end %>
<% end %>
<% end %>
<% end %>
</table>
<% end %>
<% end %>

In the code above, if @student.assignment.max_team_size > 1 we then execute the below code ,this is because our new feature is only available when assignment team size greater than 1.we use if @student.team==nil|| !@student.team.full? to allow students who have no team or whose team is not full to see this list.Next we found all participants ,we use if statement to sample those who has no team , their role are students and they won't see themselves if they do not have teams.We then put these sampled participants on the list .these achieved by the code below
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
We also need to add invitation links next to students without teams,before adding links , we need to know whether students who want to invite the students on the list have team or not .if they do not have their own teams. we will automatically create a team for them ,this mechanism is called team lazy initialization.the code for this part is below
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
Finally we just use form_tag to create invite button which is related to invitation controller and create method in it .

===Issue4===
we also display a list of students who do not have team in teams#list page for instructor.This part of code is showed below.
<% @assignment.participants.each do |participant| %> 
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<td><%= participant.user.name %></td>
<% end %>
<% end %>
<% end %>

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T21:58:21Z

Ygui2: /* Issue3 */

==Introduction==
==='''Problem Statement'''===
For team-based assignments, it always takes time to find suitable team members. We already have bidding, which could help you to join in a team with other team members hold similar bidding preferences. However, you may not be satisfied with automated team formation and want to switch to another team. In this project, we will build a new feature to help students find teams to join.

Currently, there are 2 ways to find other students to join your team:

1.If your team is not full, you could invite people by inputting his/her UnityID. It will send an invitation to certain user. If s/he accept your invitation,s/he will leave original team and join your team.
2.You could create an advisement by clicking “Your team” link and then clicking “Create” link under “Advertisement for teammates” section. Then your advertisement will appear the last column of the signup sheet page with a horn icon. In this way, all classmates could see your advisement. Someone could send a request to join your team. If you accept their request, s/he will leave original team and join in your team.

It would be better for students who do not have team yet or whose team is not full yet to be able to see a list of students who don’t already have teams. So too for instructors.

== Task Description ==

Fix the second way to find other students to join your team.

Currently, after you create an advertisement, the horn icon does not appear in the the last column of the signup sheet.

For student end:

Display a list of students who do not have a team with invitation links in student_teams#view page
You could invite students to your team by clicking invitation links. If s/he accept your invitation,s/he will leave original team and join in your team. It will be more straightforward than typing UnityID.

For instructor end:

Display a list of students who do not have team in teams#list page

Write feature tests to verify your modifications:

Create team_invitation_spec.rb file in spec/features folder

==Modified Files ==
1)app/views/student_teams/view.html.erb

2)app/views/join_team_requests/_list_received.erb

3)app/controllers/join_team_requests_controller.rb

4)app/models/join_team_request.rb

5)app/models/sign_up_sheet.rb

6)app/views/sign_up_sheet/_table_line.html.erb

7)app/views/sign_up_sheet/_all_actions.html.erb

8)app/views/teams/list.html.erb

=='''Approach taken to resolve the issues'''==

===Issue1===
When someone creates an ad ,the horny icon does not appear in the the last column of the signup sheet.the code that show horny icon is below:

<% if SignUpSheet.has_teammate_ads?(topic.id) %>
<%= link_to image_tag('ad.png', :border => 0, :title => 'Ad', :align => 'middle', :style => 'width: 24px; height:24px'), :controller=>'sign_up_sheet',
:action=> 'show_team',assignment_id=>@assignment.id, :id=>topic.id%>
<% end %>

After debugging ,I found even if you create an ad before ,the if block of code will not be executed. Therefore something must be wrong with has_teammate_ads? method.Then I rewrite that method.Signupteam has an attribute:advertise_for_partner ,it will be set true after team members create an ad for their team.i return this attribute to the has_teammate_ads? method and the horny icon appears.This method code is below:
def self.has_teammate_ads?(topic_id)
@ads_exsit=false
@result=SignedUpTeam.where("topic_id = ?", topic_id.to_s)
@result.each do |result|
team=result.team
@ads_exsit=team.advertise_for_partner
end
@ads_exsit
end

===Issue2===
I found currently when you sent join team request in the ad,the team received that request would see invite and decline button on their student teams#view page.if they are willing to add the student who send request as member ,they have to send invitation and wait for reply. This is not reasonable and convenient. what should happen is that when the student send join team request,the team members could see accept and decline button ,After they click accept button ,the student would leave his/her original team and join the new team.
What I have done is that I add accept method in join team request controller.The method is below:

def accept
unless JoinTeamRequest.accept_invite(params[:team_id], @inviter_userid, @invited_userid, @assignment_id)
flash[:error] = 'The system failed to add you to the team that invited you.'
end
redirect_to view_student_teams_path student_id: params[:student_id]
end

Here @invited_userid is acquired from the student who sent join team request. inviter_userid is from the team members who received the request. team_id is invited student's team id.

===Issue3===

We build a new feature to help students find teams to join. Students who do not have teams or whose team is not full are able to see a list of students who do not haven a team.The code for this issue is showed below:
<% if @student.user_id!=nil %>
<%if @student.assignment.max_team_size > 1 %>
<% if @student.team==nil|| !@student.team.full? %>
Students without teams
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
else
@teamid=@student.team.id
end%>
<td><%= form_tag :controller => 'invitations', :action => 'create' do %>
<%= hidden_field_tag 'team_id', @teamid %>
<%= hidden_field_tag 'student_id', @student.id %>
<%= hidden_field_tag 'session[:dummy][:assignment_id]', @student.parent_id %>
<%= hidden_field_tag 'user[name]', participant.user.name%>
<%= submit_tag "invite"%>
<% end %>
</td>
<% end %>
<% end %>
<% end %>
<% end %>
<% end %>
</table>
<% end %>
<% end %>

In the code above, if @student.assignment.max_team_size > 1 we then execute the below code ,this is because our new feature is only available when assignment team size greater than 1.we use if @student.team==nil|| !@student.team.full? to allow students who have no team or whose team is not full to see this list.Next we found all participants ,we use if statement to sample those who has no team , their role are students and they won't see themselves if they do not have teams.We then put these sampled participants on the list .these achieved by the code below
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
We also need to add invitation links next to students without teams,before adding links , we need to know whether students who want to invite the students on the list have team or not .if they do not have their own teams. we will automatically create a team for them ,this mechanism is called team lazy initialization.the code for this part is below
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
Finally we just use form_tag to create invite button which is related to invitation controller and create method in it .

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T21:25:07Z

Ygui2: /* Issue3 */

==Introduction==
==='''Problem Statement'''===
For team-based assignments, it always takes time to find suitable team members. We already have bidding, which could help you to join in a team with other team members hold similar bidding preferences. However, you may not be satisfied with automated team formation and want to switch to another team. In this project, we will build a new feature to help students find teams to join.

Currently, there are 2 ways to find other students to join your team:

1.If your team is not full, you could invite people by inputting his/her UnityID. It will send an invitation to certain user. If s/he accept your invitation,s/he will leave original team and join your team.
2.You could create an advisement by clicking “Your team” link and then clicking “Create” link under “Advertisement for teammates” section. Then your advertisement will appear the last column of the signup sheet page with a horn icon. In this way, all classmates could see your advisement. Someone could send a request to join your team. If you accept their request, s/he will leave original team and join in your team.

It would be better for students who do not have team yet or whose team is not full yet to be able to see a list of students who don’t already have teams. So too for instructors.

== Task Description ==

Fix the second way to find other students to join your team.

Currently, after you create an advertisement, the horn icon does not appear in the the last column of the signup sheet.

For student end:

Display a list of students who do not have a team with invitation links in student_teams#view page
You could invite students to your team by clicking invitation links. If s/he accept your invitation,s/he will leave original team and join in your team. It will be more straightforward than typing UnityID.

For instructor end:

Display a list of students who do not have team in teams#list page

Write feature tests to verify your modifications:

Create team_invitation_spec.rb file in spec/features folder

==Modified Files ==
1)app/views/student_teams/view.html.erb

2)app/views/join_team_requests/_list_received.erb

3)app/controllers/join_team_requests_controller.rb

4)app/models/join_team_request.rb

5)app/models/sign_up_sheet.rb

6)app/views/sign_up_sheet/_table_line.html.erb

7)app/views/sign_up_sheet/_all_actions.html.erb

8)app/views/teams/list.html.erb

=='''Approach taken to resolve the issues'''==

===Issue1===
When someone creates an ad ,the horny icon does not appear in the the last column of the signup sheet.the code that show horny icon is below:

<% if SignUpSheet.has_teammate_ads?(topic.id) %>
<%= link_to image_tag('ad.png', :border => 0, :title => 'Ad', :align => 'middle', :style => 'width: 24px; height:24px'), :controller=>'sign_up_sheet',
:action=> 'show_team',assignment_id=>@assignment.id, :id=>topic.id%>
<% end %>

After debugging ,I found even if you create an ad before ,the if block of code will not be executed. Therefore something must be wrong with has_teammate_ads? method.Then I rewrite that method.Signupteam has an attribute:advertise_for_partner ,it will be set true after team members create an ad for their team.i return this attribute to the has_teammate_ads? method and the horny icon appears.This method code is below:
def self.has_teammate_ads?(topic_id)
@ads_exsit=false
@result=SignedUpTeam.where("topic_id = ?", topic_id.to_s)
@result.each do |result|
team=result.team
@ads_exsit=team.advertise_for_partner
end
@ads_exsit
end

===Issue2===
I found currently when you sent join team request in the ad,the team received that request would see invite and decline button on their student teams#view page.if they are willing to add the student who send request as member ,they have to send invitation and wait for reply. This is not reasonable and convenient. what should happen is that when the student send join team request,the team members could see accept and decline button ,After they click accept button ,the student would leave his/her original team and join the new team.
What I have done is that I add accept method in join team request controller.The method is below:

def accept
unless JoinTeamRequest.accept_invite(params[:team_id], @inviter_userid, @invited_userid, @assignment_id)
flash[:error] = 'The system failed to add you to the team that invited you.'
end
redirect_to view_student_teams_path student_id: params[:student_id]
end

Here @invited_userid is acquired from the student who sent join team request. inviter_userid is from the team members who received the request. team_id is invited student's team id.

===Issue3===

We build a new feature to help students find teams to join. Students who do not have teams or whose team is not full are able to see a list of students who do not haven a team.The code for this issue is showed below:
<% if @student.user_id!=nil %>
<%if @student.assignment.max_team_size > 1 %>
<% if @student.team==nil|| !@student.team.full? %>
Students without teams
<%@student.assignment.participants.each do |participant| %>
<% if participant.team==nil %>
<% if User.find(participant.user_id).role.name=="Student" %>
<% if participant.user.name!=@student.name %>
<td><%= participant.user.name %></td>
<%if @student.team==nil
team = AssignmentTeam.create_team_and_node(@student.parent_id)
user = User.find(@student.user_id)
# create TeamsUser and TeamUserNode
teamuser = ApplicationController.helpers.create_team_users(user, team.id)
@teamid=team.id
else
@teamid=@student.team.id
end%>
<td><%= form_tag :controller => 'invitations', :action => 'create' do %>
<%= hidden_field_tag 'team_id', @teamid %>
<%= hidden_field_tag 'student_id', @student.id %>
<%= hidden_field_tag 'session[:dummy][:assignment_id]', @student.parent_id %>
<%= hidden_field_tag 'user[name]', participant.user.name%>
<%= submit_tag "invite"%>
<% end %>
</td>
<% end %>
<% end %>
<% end %>
<% end %>
<% end %>
</table>
<% end %>
<% end %>

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T20:40:28Z

Ygui2: /* Issue2 */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T18:29:04Z

Ygui2: /* Issue2 */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T17:06:51Z

Ygui2: /* Issue1 */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T16:44:44Z

Ygui2: /* Issue1 */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T16:43:56Z

Ygui2: /* Approach taken to resolve the issues */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T16:39:14Z

Ygui2: /* Approach taken to resolve the issues */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T16:03:16Z

Ygui2: /* Modified Files */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T15:50:48Z

Ygui2: /* Modified Files */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T15:49:33Z

Ygui2: /* UI Design */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-27T15:19:32Z

Ygui2: /* Task Description */

File:29.png

2017-11-05T21:11:41Z

Ygui2:

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-05T21:10:48Z

Ygui2: /* UI Design */

File:28.png

2017-11-05T21:09:02Z

Ygui2: uploaded a new version of "File:28.png"

File:28.png

2017-11-05T21:08:26Z

Ygui2:

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-05T21:05:08Z

Ygui2: /* UI Design */

File:27.png

2017-11-05T21:04:56Z

Ygui2:

File:26.png

2017-11-05T21:02:40Z

Ygui2: uploaded a new version of "File:26.png"

File:26.png

2017-11-05T21:00:26Z

Ygui2: uploaded a new version of "File:26.png"

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-05T20:53:38Z

Ygui2: /* UI Design */

File:26.png

2017-11-05T20:53:12Z

Ygui2: uploaded a new version of "File:26.png"

File:26.png

2017-11-05T20:52:36Z

Ygui2:

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-05T20:45:09Z

Ygui2: /* Task Description */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-05T16:04:11Z

Ygui2: /* Task Description */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-05T15:59:18Z

Ygui2: /* Introduction */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-05T15:34:58Z

Ygui2: /* Problem Statement */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-05T15:30:46Z

Ygui2: /* Introduction */

CSC/ECE 517 Fall 2017/E1793. Help students find teams to join

2017-11-05T15:24:28Z

Ygui2: /* Introduction */