Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T04:21:04Z

Xchen33: /* New Implementation */

== Introduction ==

Expertiza includes the functionality of notifying instructors when a conflict occurs in review scores for a submission. Currently, when two reviews for the same submission differ significantly, an email is sent to the instructor of the course, but there is no link to the review that caused the conflict. This improvement will allow the professor to have links to the reviews that caused the conflict and will be formatted better to help the instructor understand the conflict.

=== Issues with previous submission ===

# The functionality is good but the UI of conflict report needs work.
# The UI needs to be cleaned up a little. When charts have only one or two bars, the chart can be compressed. The reviewer whose scores deviate from the threshold can be displayed in a different colored bar.
# Tests need to be refactored.
# They included their debug code in their pull request.
# They have included a lot of logic in the views.
# Shallow tests: one or more of their test expectations only focus on the return value not being `nil`, `empty` or not equal to `0` without testing the `real` value.

== Proposed Solution ==

The previous team implemented new logic to determine if a review is in conflict with another and created a new page to link the instructors to in the email. Because their functionality was good, we will mainly be focused on improving the UI of the conflict reports. Furthermore, there is a lot of logic that lives in the views that can be refactored and moved to controllers. Additionally, there is debug code that can be removed and tests that can be fleshed out.

=== UI Imporvements ===

File: app/views/reports/_review_conflict_metric.html.erb

The UI can be improved for the conflict metric to give more information on the conflicted reviews.

=== Logic in Views ===
File: app/views/reports/_review_conflict_metric.html.erb

The logic to determine if answers are within or outside of the tolerance limits can be moved to functions outside of the .erb file.

== UML Activity Diagram ==
[[File:517 Final Project Student UML.jpg]]
[[File:517 Final Project Instructor UML.jpg]]

== Test Plan==

=== Manual Test Plan ===

To verify the conflict notification is working correctly, a mock assignment will be created and two reviews will be entered that should trigger a conflict. Successful retrieval of the email and verification of the links included in the email will provide sufficient verification that the changes were successful.

=== File Changes ===
File: spec/models/answer_spec.rb

Currently, tests only check if the values are not empty. More tests can be written to make sure the actual value is being returned correctly.

File: spec/controllers/reports_controller_spec.rb

More tests can be written to ensure correct names and values are written.

== Implemented Solution ==

=== Refactoring ===

Moved following methods from review_mapping_helper.rb to report_formatter_helper.rb

* average_of_round
* std_of_round
* review_score_helper_for_team
* review_score_for_team

=== New Implementation ===
Adding base_url from the controller as this method is not accessible from model
<pre> @response.notify_instructor_on_difference(request.base_url) if (@map.is_a? ReviewResponseMap)
&& @response.is_submitted && @response.significant_difference?
</pre>
<pre> if (@map.is_a? ReviewResponseMap) && (was_submitted == false && @response.is_submitted) && @response.significant_difference?
@response.notify_instructor_on_difference
@response.notify_instructor_on_difference(request.base_url)
@response.email
end
</pre>
This method generates statistics (average, standard deviation, tolerance limits) for each round. This method was created to move logic that was previously contained in a view to a helper class.
<pre>def review_statistics(id, team_name)
res = []
question_answers = review_score_for_team(id, team_name)
question_answers.each do |question_answer|
round = {}
round[:question_answer] = question_answer
round[:average] = average_of_round(question_answer)
round[:std] = std_of_round(round[:average], question_answer)
round[:upper_tolerance_limit] = (round[:average]+(2*round[:std])).round(2)
round[:lower_tolerance_limit] = (round[:average]-(2*round[:std])).round(2)
res.push(round)
end
res
end
</pre>
This logic highlights all reviews' score in red which is out of limit range, and all other background color will be green.
<pre> if answer > upper_tolerance_limit or answer < lower_tolerance_limit
colors << "rgba(255,99,132,0.8)" # red
end
else
colors << "rgba(77, 175, 124, 1)" # green
end
</pre>
Passing the colors to bar background.
<pre>backgroundColor: colors</pre>
comprising the chart height for how much it need to clearly display all data.
<pre> height: 4*question_answer.size() + 14 </pre>

=== UI Improvements ===

Based on the previous changes from last group, the notification email triggered will send to the instructor whenever a new review is significantly different from other people's review, who has the same submission team (the threshold is specified in the "Notification limit" on the Rubric tab of assignment creation).
The graph showing below is the previous team email UI.

[[File:afteremail.JPG|1000px]]

On the email notification, the formatting can be improved to make it more readable and clear as to which links relate to what actions and what caused the conflict to trigger.

The previous group of snapshot for the view which the instructor receives

[[File:afterfix.PNG|1000px]]

On the 'review for mail check' page, more information can be added to indicate if a review has a conflict. We will add indicators beside each review that have conflicts. We added a link for review_conflict_report_url, which will let instructor to access the review conflict report page by the email he received.

[[File:E2087 Conflict Notification.png|1000px]]

Chart before improvements.
<br>

[[File:Chart before.png|1000px]]

Chart after improvements.

<br>
<br>
[[File:Chart after.png|1000px]]

The improved chart has the student name on the y-axis, scaled chart sizes, and more intuitive highlighting with red bars indicating an out of limits score. This is a great improvement to the previous implementation where only the student name was highlighted to indicate an out of limit score.

== Relevant Links ==
GitHub - https://github.com/salmonandrew/expertiza <br>
Pull Request - https://github.com/expertiza/expertiza/pull/1840 <br>
Demo Video - https://youtu.be/D_e80coRkLk

== Team ==
'''Mentor: '''Sanket Pai (sgpai2@ncsu.edu)

*Yen-An Jou (yjou@ncsu.edu)
*Xiwen Chen (xchen33@ncsu.edu)
*Andrew Hirasawa (achirasa@ncsu.edu)
*Derrick Li (xli56@ncsu.edu)

== References / Previous Implementation ==

*Previous Wikipedia page - [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification E1865 Conflict Notification Fall 2018]

*Previous Final Video - [https://drive.google.com/drive/folders/1Z8rqRxdmXJYbOZzoptmBLP0kM7Bdul2Q Final Video]

*Previous Pull Request -[https://github.com/expertiza/expertiza/pull/1445 Pull Request 1445]

*Previous Github Repo - [https://github.com/cshinde57/expertiza Github Repo]
{{reflist}}

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T04:17:48Z

Xchen33: /* Conflict Report Chart Improvements */

== Introduction ==

Expertiza includes the functionality of notifying instructors when a conflict occurs in review scores for a submission. Currently, when two reviews for the same submission differ significantly, an email is sent to the instructor of the course, but there is no link to the review that caused the conflict. This improvement will allow the professor to have links to the reviews that caused the conflict and will be formatted better to help the instructor understand the conflict.

=== Issues with previous submission ===

# The functionality is good but the UI of conflict report needs work.
# The UI needs to be cleaned up a little. When charts have only one or two bars, the chart can be compressed. The reviewer whose scores deviate from the threshold can be displayed in a different colored bar.
# Tests need to be refactored.
# They included their debug code in their pull request.
# They have included a lot of logic in the views.
# Shallow tests: one or more of their test expectations only focus on the return value not being `nil`, `empty` or not equal to `0` without testing the `real` value.

== Proposed Solution ==

The previous team implemented new logic to determine if a review is in conflict with another and created a new page to link the instructors to in the email. Because their functionality was good, we will mainly be focused on improving the UI of the conflict reports. Furthermore, there is a lot of logic that lives in the views that can be refactored and moved to controllers. Additionally, there is debug code that can be removed and tests that can be fleshed out.

=== UI Imporvements ===

File: app/views/reports/_review_conflict_metric.html.erb

The UI can be improved for the conflict metric to give more information on the conflicted reviews.

=== Logic in Views ===
File: app/views/reports/_review_conflict_metric.html.erb

The logic to determine if answers are within or outside of the tolerance limits can be moved to functions outside of the .erb file.

== UML Activity Diagram ==
[[File:517 Final Project Student UML.jpg]]
[[File:517 Final Project Instructor UML.jpg]]

== Test Plan==

=== Manual Test Plan ===

To verify the conflict notification is working correctly, a mock assignment will be created and two reviews will be entered that should trigger a conflict. Successful retrieval of the email and verification of the links included in the email will provide sufficient verification that the changes were successful.

=== File Changes ===
File: spec/models/answer_spec.rb

Currently, tests only check if the values are not empty. More tests can be written to make sure the actual value is being returned correctly.

File: spec/controllers/reports_controller_spec.rb

More tests can be written to ensure correct names and values are written.

== Implemented Solution ==

=== Refactoring ===

Moved following methods from review_mapping_helper.rb to report_formatter_helper.rb

* average_of_round
* std_of_round
* review_score_helper_for_team
* review_score_for_team

=== New Implementation ===
Adding base_url from the controller as this method is not accessible from model
<pre> @response.notify_instructor_on_difference(request.base_url) if (@map.is_a? ReviewResponseMap)
&& @response.is_submitted && @response.significant_difference?
</pre>
<pre> if (@map.is_a? ReviewResponseMap) && (was_submitted == false && @response.is_submitted) && @response.significant_difference?
@response.notify_instructor_on_difference
@response.notify_instructor_on_difference(request.base_url)
@response.email
end
</pre>
This method generates statistics (average, standard deviation, tolerance limits) for each round. This method was created to move logic that was previously contained in a view to a helper class.
<pre>def review_statistics(id, team_name)
res = []
question_answers = review_score_for_team(id, team_name)
question_answers.each do |question_answer|
round = {}
round[:question_answer] = question_answer
round[:average] = average_of_round(question_answer)
round[:std] = std_of_round(round[:average], question_answer)
round[:upper_tolerance_limit] = (round[:average]+(2*round[:std])).round(2)
round[:lower_tolerance_limit] = (round[:average]-(2*round[:std])).round(2)
res.push(round)
end
res
end
</pre>
This logic highlights all reviews' score in red which is out of limit range.
<pre> if answer > upper_tolerance_limit or answer < lower_tolerance_limit
colors << "rgba(255,99,132,0.8)" # red
end
else
colors << "rgba(77, 175, 124, 1)" # green
end
</pre>
Passing the colors to bar background.
<pre>backgroundColor: colors</pre>
comprising the chart height for how much it need to clearly display all data.
<pre> height: 4*question_answer.size() + 14 </pre>

=== UI Improvements ===

Based on the previous changes from last group, the notification email triggered will send to the instructor whenever a new review is significantly different from other people's review, who has the same submission team (the threshold is specified in the "Notification limit" on the Rubric tab of assignment creation).
The graph showing below is the previous team email UI.

[[File:afteremail.JPG|1000px]]

On the email notification, the formatting can be improved to make it more readable and clear as to which links relate to what actions and what caused the conflict to trigger.

The previous group of snapshot for the view which the instructor receives

[[File:afterfix.PNG|1000px]]

On the 'review for mail check' page, more information can be added to indicate if a review has a conflict. We will add indicators beside each review that have conflicts. We added a link for review_conflict_report_url, which will let instructor to access the review conflict report page by the email he received.

[[File:E2087 Conflict Notification.png|1000px]]

Chart before improvements.
<br>

[[File:Chart before.png|1000px]]

Chart after improvements.

<br>
<br>
[[File:Chart after.png|1000px]]

The improved chart has the student name on the y-axis, scaled chart sizes, and more intuitive highlighting with red bars indicating an out of limits score. This is a great improvement to the previous implementation where only the student name was highlighted to indicate an out of limit score.

== Relevant Links ==
GitHub - https://github.com/salmonandrew/expertiza <br>
Pull Request - https://github.com/expertiza/expertiza/pull/1840 <br>
Demo Video - https://youtu.be/D_e80coRkLk

== Team ==
'''Mentor: '''Sanket Pai (sgpai2@ncsu.edu)

*Yen-An Jou (yjou@ncsu.edu)
*Xiwen Chen (xchen33@ncsu.edu)
*Andrew Hirasawa (achirasa@ncsu.edu)
*Derrick Li (xli56@ncsu.edu)

== References / Previous Implementation ==

*Previous Wikipedia page - [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification E1865 Conflict Notification Fall 2018]

*Previous Final Video - [https://drive.google.com/drive/folders/1Z8rqRxdmXJYbOZzoptmBLP0kM7Bdul2Q Final Video]

*Previous Pull Request -[https://github.com/expertiza/expertiza/pull/1445 Pull Request 1445]

*Previous Github Repo - [https://github.com/cshinde57/expertiza Github Repo]
{{reflist}}

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T04:08:29Z

Xchen33: /* UI Changes */

== Introduction ==

Expertiza includes the functionality of notifying instructors when a conflict occurs in review scores for a submission. Currently, when two reviews for the same submission differ significantly, an email is sent to the instructor of the course, but there is no link to the review that caused the conflict. This improvement will allow the professor to have links to the reviews that caused the conflict and will be formatted better to help the instructor understand the conflict.

=== Issues with previous submission ===

# The functionality is good but the UI of conflict report needs work.
# The UI needs to be cleaned up a little. When charts have only one or two bars, the chart can be compressed. The reviewer whose scores deviate from the threshold can be displayed in a different colored bar.
# Tests need to be refactored.
# They included their debug code in their pull request.
# They have included a lot of logic in the views.
# Shallow tests: one or more of their test expectations only focus on the return value not being `nil`, `empty` or not equal to `0` without testing the `real` value.

== Proposed Solution ==

The previous team implemented new logic to determine if a review is in conflict with another and created a new page to link the instructors to in the email. Because their functionality was good, we will mainly be focused on improving the UI of the conflict reports. Furthermore, there is a lot of logic that lives in the views that can be refactored and moved to controllers. Additionally, there is debug code that can be removed and tests that can be fleshed out.

=== UI Imporvements ===

File: app/views/reports/_review_conflict_metric.html.erb

The UI can be improved for the conflict metric to give more information on the conflicted reviews.

=== Logic in Views ===
File: app/views/reports/_review_conflict_metric.html.erb

The logic to determine if answers are within or outside of the tolerance limits can be moved to functions outside of the .erb file.

== UML Activity Diagram ==
[[File:517 Final Project Student UML.jpg]]
[[File:517 Final Project Instructor UML.jpg]]

== Test Plan==

=== Manual Test Plan ===

To verify the conflict notification is working correctly, a mock assignment will be created and two reviews will be entered that should trigger a conflict. Successful retrieval of the email and verification of the links included in the email will provide sufficient verification that the changes were successful.

=== File Changes ===
File: spec/models/answer_spec.rb

Currently, tests only check if the values are not empty. More tests can be written to make sure the actual value is being returned correctly.

File: spec/controllers/reports_controller_spec.rb

More tests can be written to ensure correct names and values are written.

== Implemented Solution ==

=== Refactoring ===

Moved following methods from review_mapping_helper.rb to report_formatter_helper.rb

* average_of_round
* std_of_round
* review_score_helper_for_team
* review_score_for_team

=== New Implementation ===
Adding base_url from the controller as this method is not accessible from model
<pre> @response.notify_instructor_on_difference(request.base_url) if (@map.is_a? ReviewResponseMap)
&& @response.is_submitted && @response.significant_difference?
</pre>
<pre> if (@map.is_a? ReviewResponseMap) && (was_submitted == false && @response.is_submitted) && @response.significant_difference?
@response.notify_instructor_on_difference
@response.notify_instructor_on_difference(request.base_url)
@response.email
end
</pre>
This method generates statistics (average, standard deviation, tolerance limits) for each round. This method was created to move logic that was previously contained in a view to a helper class.
<pre>def review_statistics(id, team_name)
res = []
question_answers = review_score_for_team(id, team_name)
question_answers.each do |question_answer|
round = {}
round[:question_answer] = question_answer
round[:average] = average_of_round(question_answer)
round[:std] = std_of_round(round[:average], question_answer)
round[:upper_tolerance_limit] = (round[:average]+(2*round[:std])).round(2)
round[:lower_tolerance_limit] = (round[:average]-(2*round[:std])).round(2)
res.push(round)
end
res
end
</pre>
This logic highlights all reviews' score in red which is out of limit range.
<pre> if answer > upper_tolerance_limit or answer < lower_tolerance_limit
colors << "rgba(255,99,132,0.8)" # red
end
else
colors << "rgba(77, 175, 124, 1)" # green
end
</pre>
Passing the colors to bar background.
<pre>backgroundColor: colors</pre>
comprising the chart height for how much it need to clearly display all data.
<pre> height: 4*question_answer.size() + 14 </pre>

=== Conflict Report Chart Improvements ===

[[File:Chart before.png|1000px]]

Chart before improvements.

<br>
<br>
[[File:Chart after.png|1000px]]

Chart after improvements.

The improved chart has the student name on the y-axis, scaled chart sizes, and more intuitive highlighting with red bars indicating an out of limits score. This is a great improvement to the previous implementation where only the student name was highlighted to indicate an out of limit score.

== Relevant Links ==
GitHub - https://github.com/salmonandrew/expertiza <br>
Pull Request - https://github.com/expertiza/expertiza/pull/1840 <br>
Demo Video - https://youtu.be/D_e80coRkLk

== Team ==
'''Mentor: '''Sanket Pai (sgpai2@ncsu.edu)

*Yen-An Jou (yjou@ncsu.edu)
*Xiwen Chen (xchen33@ncsu.edu)
*Andrew Hirasawa (achirasa@ncsu.edu)
*Derrick Li (xli56@ncsu.edu)

== References / Previous Implementation ==

*Previous Wikipedia page - [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2018-_Project_E1865._Conflict_Notification E1865 Conflict Notification Fall 2018]

*Previous Final Video - [https://drive.google.com/drive/folders/1Z8rqRxdmXJYbOZzoptmBLP0kM7Bdul2Q Final Video]

*Previous Pull Request -[https://github.com/expertiza/expertiza/pull/1445 Pull Request 1445]

*Previous Github Repo - [https://github.com/cshinde57/expertiza Github Repo]
{{reflist}}

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-11-17T01:03:05Z

Xchen33: /* Relevant Links */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T22:17:31Z

Xchen33: /* UI Changes */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T22:12:40Z

Xchen33: /* Test Plan */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T21:43:40Z

Xchen33: /* Previous Flow charts */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T21:39:36Z

Xchen33: /* Relevant Links */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T21:39:10Z

Xchen33: /* References / Previous Implementation */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T21:37:49Z

Xchen33: /* References / Previous Implementation */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T21:37:22Z

Xchen33: /* References / Previous Implementation */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T21:36:55Z

Xchen33: /* References / Previous Implementation */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T21:35:56Z

Xchen33: /* References */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-28T21:34:30Z

Xchen33: /* References */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:22:11Z

Xchen33: /* Test */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:21:33Z

Xchen33: /* Previous Flow charts */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:21:17Z

Xchen33: /* Previous Flow charts */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:19:15Z

Xchen33: /* Current UML Diagram */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:18:57Z

Xchen33: /* Current UML Diagram */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:18:42Z

Xchen33: /* Current UML Diagram */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:18:29Z

Xchen33: /* Current UML Diagram */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:17:55Z

Xchen33: /* Current Logic Flow Charts */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:16:11Z

Xchen33: /* Previous Flow charts */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:12:33Z

Xchen33: /* Previous Flow charts */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:12:15Z

Xchen33: /* Introduction */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:08:09Z

Xchen33: /* References */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T19:04:42Z

Xchen33: /* References */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:57:11Z

Xchen33:

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:55:03Z

Xchen33:

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:52:31Z

Xchen33: /* Issues with previous submission */

CSC/ECE 517 Fall 2020 - E2087. Conflict notification. Improve Search Facility In Expertiza

2020-10-22T18:48:47Z

Xchen33:

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T06:14:46Z

Xchen33: /* RSpec test */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

*Fixing app/views/student_task/list.html.erb

*app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the original code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

*Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

*Fixing spec/features/assignment_submission_spec.rb

*Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

*First, we modified '''spec/features/airbrake_expection_errors_feature_tests_spec.rb'''. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

*Second, we modified '''spec/features/assignment_submission_spec.rb'''. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for testing needed, and test the necessary function from the student_task/list page.

:- The def function we added is showing below.

<pre>
def list_page
user = User.find_by(name: "student2064")
login_as(user.name)
stub_current_user(user, user.role.name, user.role)
visit '/student_task/list'
visit '/sign_up_sheet/sign_up?id=1&topic_id=1' # signup topic
visit '/student_task/list'
end
</pre>

:- Later on, we will use this list_page function on our test cases. It will show if the student_task/list page has the assignment name( ''Assignment1684'' ) that we putted on the database. Also, since there are an assignment assigned to the student, we will expect page to have course table information (''eg. Assignment, Submission Grade, Topic, Current Stage, Stage Deadline, Publishing Rights'' ). Since the assignment was not being graded yet, on the submission Grade column it will show a <q>N/A</q>. We are using student <q>student2064</q> as our user. Therefore, the page should show <q>student2064</q>. We also assigned the student to team up with CSC517, test ( ''student_id, user type. user type will be test #random number''), and on the page it should show <q>Students who have teamed with you CSC517, test#{n}</q>. Next, the page should not contain other course name. Testing code is showing below.

<pre>
#test for student_task/list page to have the right content
it "have the right content" do
list_page
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badges")
expect(page).to have_no_content("Review Grade")
expect(page).to have_content("Assignment")
expect(page).to have_content("Submission Grade")
expect(page).to have_content("Topic")
expect(page).to have_content("Current Stage")
expect(page).to have_content("Stage Deadline")
expect(page).to have_content("Publishing Rights")
expect(page).to have_content("Assignment1684")
expect(page).to have_content("student2064")
expect(page).to have_content("CSC517, test")
expect(page).to have_content("N/A")
expect(page).to have_no_content("CSC 517 Fall 2010")
end
</pre>

*Next, we added a new file '''spec/features/student_task_spec.rb'''. We included spec/features/helpers/instructor_interface_helper.rb on the test file. instructor_interface_helper set up the instructor6 log in page for us already. However, instructor_interface_helper did not help us to sign up an assignment to the user. Therefore, we will testing if the user have not been signed up for an assignment, and the student_task/list page will only show the first div part. The course information table will not appear on the page.

<pre>
include InstructorInterfaceHelperSpec

describe "Student_task, list page" do
before(:each) do
assignment_setup
end

describe "Instructor login at student_task, list page" do
it "has current contents" do
login_as("instructor6")
visit '/menu/student_task'
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badge")
expect(page).to have_no_content("Review Grade")
expect(page). to have_content("assignment")
end
end
end
</pre>

==='''Travis CI Passing Screenshot'''===
Our Rspec test is able to pass Travis CI testing.
[[File:TravisCI.JPG |1000px]]

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T06:03:52Z

Xchen33: /* RSpec test */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

*Fixing app/views/student_task/list.html.erb

*app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the original code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

*Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

*Fixing spec/features/assignment_submission_spec.rb

*Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

*First, we modified '''spec/features/airbrake_expection_errors_feature_tests_spec.rb'''. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

*Second, we modified '''spec/features/assignment_submission_spec.rb'''. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for testing needed, and test the necessary function from the student_task/list page.

:- The def function we added is showing below.

<pre>
def list_page
user = User.find_by(name: "student2064")
login_as(user.name)
stub_current_user(user, user.role.name, user.role)
visit '/student_task/list'
visit '/sign_up_sheet/sign_up?id=1&topic_id=1' # signup topic
visit '/student_task/list'
end
</pre>

:- Later on, we will use this list_page function on our test cases. It will show if the student_task/list page has the assignment name( ''Assignment1684'' ) that we putted on the database. Also, since there are an assignment assigned to the student, we will expect page to have course table information (''eg. Assignment, Submission Grade, Topic, Current Stage, Stage Deadline, Publishing Rights'' ). Since the assignment was not being graded yet, on the submission Grade column it will show a <q>N/A</q>. We are using student <q>student2064</q> as our user. Therefore, the page should show <q>student2064</q>. We also assigned the student to team up with CSC517, test42 ( ''student_id, user type''), and on the page it should show <q>Students who have teamed with you CSC517, test42</q>. Next, the page should not contain other course name. Testing code is showing below.

<pre>
#test for student_task/list page to have the right content
it "have the right content" do
list_page
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badges")
expect(page).to have_no_content("Review Grade")
expect(page).to have_content("Assignment")
expect(page).to have_content("Submission Grade")
expect(page).to have_content("Topic")
expect(page).to have_content("Current Stage")
expect(page).to have_content("Stage Deadline")
expect(page).to have_content("Publishing Rights")
expect(page).to have_content("Assignment1684")
expect(page).to have_content("student2064")
expect(page).to have_content("CSC517, test42")
expect(page).to have_content("N/A")
expect(page).to have_no_content("CSC 517 Fall 2010")
end
</pre>

*Next, we added a new file '''spec/features/student_task_spec.rb'''. We included spec/features/helpers/instructor_interface_helper.rb on the test file. instructor_interface_helper set up the instructor6 log in page for us already. However, instructor_interface_helper did not help us to sign up an assignment to the user. Therefore, we will testing if the user have not been signed up for an assignment, and the student_task/list page will only show the first div part. The course information table will not appear on the page.

<pre>
include InstructorInterfaceHelperSpec

describe "Student_task, list page" do
before(:each) do
assignment_setup
end

describe "Instructor login at student_task, list page" do
it "has current contents" do
login_as("instructor6")
visit '/menu/student_task'
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badge")
expect(page).to have_no_content("Review Grade")
expect(page). to have_content("assignment")
end
end
end
</pre>

==='''Travis CI Passing Screenshot'''===
Our Rspec test is able to pass Travis CI testing.
[[File:TravisCI.JPG |1000px]]

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T05:42:00Z

Xchen33: /* RSpec test */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

*Fixing app/views/student_task/list.html.erb

*app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the original code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

*Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

*Fixing spec/features/assignment_submission_spec.rb

*Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

*First, we modified '''spec/features/airbrake_expection_errors_feature_tests_spec.rb'''. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

*Second, we modified '''spec/features/assignment_submission_spec.rb'''. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for testing needed, and test the necessary function from the student_task/list page.

:- The def function we added is showing below.

<pre>
def list_page
user = User.find_by(name: "student2064")
login_as(user.name)
stub_current_user(user, user.role.name, user.role)
visit '/student_task/list'
visit '/sign_up_sheet/sign_up?id=1&topic_id=1' # signup topic
visit '/student_task/list'
end
</pre>

:- Later on, we will use this list_page function on our test cases. It will show if the student_task/list page has the assignment name( ''Assignment1684'' ) that we putted on the database. Also, since there are an assignment assigned to the student, we will expect page to have course table information (''eg. Assignment, Submission Grade, Topic, Current Stage, Stage Deadline, Publishing Rights'' ). Since the assignment was not being graded yet, on the submission Grade column it will show a <q>N/A</q>. We also did not put this assignment inside of a course. Therefore, on the course table head, it will show <q> No Course Assigned Yet </q>. Next, the page should not contain other course name. Testing code is showing below.

<pre>
#test for student_task/list page to have the right content
it "have the right content" do
list_page
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badges")
expect(page).to have_no_content("Review Grade")
expect(page).to have_content("Assignment")
expect(page).to have_content("Submission Grade")
expect(page).to have_content("Topic")
expect(page).to have_content("Current Stage")
expect(page).to have_content("Stage Deadline")
expect(page).to have_content("Publishing Rights")
expect(page).to have_content("Assignment1684")
expect(page).to have_content("No Course Assigned Yet")
expect(page).to have_content("N/A")
expect(page).to have_no_content("CSC 517 Fall 2010")
end
</pre>

*Next, we added a new file '''spec/features/student_task_spec.rb'''. We included spec/features/helpers/instructor_interface_helper.rb on the test file. instructor_interface_helper set up the instructor6 log in page for us already. However, instructor_interface_helper did not help us to sign up an assignment to the user. Therefore, we will testing if the user have not been signed up for an assignment, and the student_task/list page will only show the first div part. The course information table will not appear on the page.

<pre>
include InstructorInterfaceHelperSpec

describe "Student_task, list page" do
before(:each) do
assignment_setup
end

describe "Instructor login at student_task, list page" do
it "has current contents" do
login_as("instructor6")
visit '/menu/student_task'
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badge")
expect(page).to have_no_content("Review Grade")
expect(page). to have_content("assignment")
end
end
end
</pre>

==='''Travis CI Passing Screenshot'''===
Our Rspec test is able to pass Travis CI testing.
[[File:TravisCI.JPG |1000px]]

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T05:21:29Z

Xchen33: /* RSpec test */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

*Fixing app/views/student_task/list.html.erb

*app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the original code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

*Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

*Fixing spec/features/assignment_submission_spec.rb

*Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

*First, we modified '''spec/features/airbrake_expection_errors_feature_tests_spec.rb'''. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

*Second, we modified '''spec/features/assignment_submission_spec.rb'''. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for testing needed, and test the necessary function from the student_task/list page.

:- The def function we added is showing below.

<pre>
def list_page
user = User.find_by(name: "student2064")
login_as(user.name)
stub_current_user(user, user.role.name, user.role)
visit '/student_task/list'
visit '/sign_up_sheet/sign_up?id=1&topic_id=1' # signup topic
visit '/student_task/list'
end
</pre>

:- Later on, we will use this list_page function on our test cases. Testing code is showing below.

<pre>
#test for student_task/list page to have the right content
it "have the right content" do
list_page
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badges")
expect(page).to have_no_content("Review Grade")
expect(page).to have_content("Assignment")
expect(page).to have_content("Submission Grade")
expect(page).to have_content("Topic")
expect(page).to have_content("Current Stage")
expect(page).to have_content("Stage Deadline")
expect(page).to have_content("Publishing Rights")
expect(page).to have_content("Assignment1684")
end
</pre>

*Next, we added a new file '''spec/features/student_task_spec.rb'''. We included spec/features/helpers/instructor_interface_helper.rb on the test file. instructor_interface_helper set up the instructor6 log in page for us already. However, instructor_interface_helper did not help us to sign up an assignment to the user. Therefore, we will testing if the user have not been signed up for an assignment, and the student_task/list page will only show the first div part. The course information table will not appear on the page.

<pre>
include InstructorInterfaceHelperSpec

describe "Student_task, list page" do
before(:each) do
assignment_setup
end

describe "Instructor login at student_task, list page" do
it "has current contents" do
login_as("instructor6")
visit '/menu/student_task'
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badge")
expect(page).to have_no_content("Review Grade")
expect(page). to have_content("assignment")

end
end
end
</pre>

==='''Travis CI Passing Screenshot'''===
Our Rspec test is able to pass Travis CI testing.
[[File:TravisCI.JPG |1000px]]

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T05:06:52Z

Xchen33: /* Problems that need to be fixed */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

*Fixing app/views/student_task/list.html.erb

*app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the original code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

*Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

*Fixing spec/features/assignment_submission_spec.rb

*Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

*First, we modified '''spec/features/airbrake_expection_errors_feature_tests_spec.rb'''. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

*Second, we modified '''spec/features/assignment_submission_spec.rb'''. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for testing needed, and test the necessary function from the student_task/list page.

:- The def function we added is showing below.

<pre>
def list_page
user = User.find_by(name: "student2064")
login_as(user.name)
stub_current_user(user, user.role.name, user.role)
visit '/student_task/list'
visit '/sign_up_sheet/sign_up?id=1&topic_id=1' # signup topic
visit '/student_task/list'
end
</pre>

:- Later on, we will use this list_page function on our test cases. Testing code is showing below.

<pre>
#test for student_task/list page to have the right content
it "have the right content" do
list_page
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badges")
expect(page).to have_no_content("Review Grade")
expect(page).to have_content("Assignment")
expect(page).to have_content("Submission Grade")
expect(page).to have_content("Topic")
expect(page).to have_content("Current Stage")
expect(page).to have_content("Stage Deadline")
expect(page).to have_content("Publishing Rights")
expect(page).to have_content("Assignment1684")
end
</pre>

==='''Travis CI Passing Screenshot'''===
Our Rspec test is able to pass Travis CI testing.
[[File:TravisCI.JPG |1000px]]

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T05:04:55Z

Xchen33: /* Problem 2, submission grade display */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

*Fixing app/views/student_task/list.html.erb

*app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the original code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

*Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

*Fixing spec/features/assignment_submission_spec.rb

*Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

*First, we modified '''spec/features/airbrake_expection_errors_feature_tests_spec.rb'''. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

*Second, we modified '''spec/features/assignment_submission_spec.rb'''. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for testing needed, and test the necessary function from the student_task/list page.

:- The def function we added is showing below.

<pre>
def list_page
user = User.find_by(name: "student2064")
login_as(user.name)
stub_current_user(user, user.role.name, user.role)
visit '/student_task/list'
visit '/sign_up_sheet/sign_up?id=1&topic_id=1' # signup topic
visit '/student_task/list'
end
</pre>

:- Later on, we will use this list_page function on our test cases. Testing code is showing below.

<pre>
#test for student_task/list page to have the right content
it "have the right content" do
list_page
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badges")
expect(page).to have_no_content("Review Grade")
expect(page).to have_content("Assignment")
expect(page).to have_content("Submission Grade")
expect(page).to have_content("Topic")
expect(page).to have_content("Current Stage")
expect(page).to have_content("Stage Deadline")
expect(page).to have_content("Publishing Rights")
expect(page).to have_content("Assignment1684")
end
</pre>

==='''Travis CI Passing Screenshot'''===
Our Rspec test is able to pass Travis CI testing.
[[File:TravisCI.JPG |1000px]]

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T05:03:23Z

Xchen33: /* Travis CI Passing Screenshot */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

Fixing app/views/student_task/list.html.erb

app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the orignal code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

*Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

*Fixing spec/features/assignment_submission_spec.rb

*Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

*First, we modified '''spec/features/airbrake_expection_errors_feature_tests_spec.rb'''. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

*Second, we modified '''spec/features/assignment_submission_spec.rb'''. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for testing needed, and test the necessary function from the student_task/list page.

:- The def function we added is showing below.

<pre>
def list_page
user = User.find_by(name: "student2064")
login_as(user.name)
stub_current_user(user, user.role.name, user.role)
visit '/student_task/list'
visit '/sign_up_sheet/sign_up?id=1&topic_id=1' # signup topic
visit '/student_task/list'
end
</pre>

:- Later on, we will use this list_page function on our test cases. Testing code is showing below.

<pre>
#test for student_task/list page to have the right content
it "have the right content" do
list_page
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badges")
expect(page).to have_no_content("Review Grade")
expect(page).to have_content("Assignment")
expect(page).to have_content("Submission Grade")
expect(page).to have_content("Topic")
expect(page).to have_content("Current Stage")
expect(page).to have_content("Stage Deadline")
expect(page).to have_content("Publishing Rights")
expect(page).to have_content("Assignment1684")
end
</pre>

==='''Travis CI Passing Screenshot'''===
Our Rspec test is able to pass Travis CI testing.
[[File:TravisCI.JPG |1000px]]

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T05:03:03Z

Xchen33: /* Travis CI Passing Screenshot */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

Fixing app/views/student_task/list.html.erb

app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the orignal code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

*Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

*Fixing spec/features/assignment_submission_spec.rb

*Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

*First, we modified '''spec/features/airbrake_expection_errors_feature_tests_spec.rb'''. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

*Second, we modified '''spec/features/assignment_submission_spec.rb'''. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for testing needed, and test the necessary function from the student_task/list page.

:- The def function we added is showing below.

<pre>
def list_page
user = User.find_by(name: "student2064")
login_as(user.name)
stub_current_user(user, user.role.name, user.role)
visit '/student_task/list'
visit '/sign_up_sheet/sign_up?id=1&topic_id=1' # signup topic
visit '/student_task/list'
end
</pre>

:- Later on, we will use this list_page function on our test cases. Testing code is showing below.

<pre>
#test for student_task/list page to have the right content
it "have the right content" do
list_page
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badges")
expect(page).to have_no_content("Review Grade")
expect(page).to have_content("Assignment")
expect(page).to have_content("Submission Grade")
expect(page).to have_content("Topic")
expect(page).to have_content("Current Stage")
expect(page).to have_content("Stage Deadline")
expect(page).to have_content("Publishing Rights")
expect(page).to have_content("Assignment1684")
end
</pre>

==='''Travis CI Passing Screenshot'''===
Our Rspec test is able to pass Travis CI testing.
[[File:TravisCI.JPG]]

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

File:TravisCI.JPG

2020-10-19T05:02:34Z

Xchen33:

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T05:01:51Z

Xchen33: /* RSpec test */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

Fixing app/views/student_task/list.html.erb

app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the orignal code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

*Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

*Fixing spec/features/assignment_submission_spec.rb

*Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

*First, we modified '''spec/features/airbrake_expection_errors_feature_tests_spec.rb'''. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

*Second, we modified '''spec/features/assignment_submission_spec.rb'''. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for testing needed, and test the necessary function from the student_task/list page.

:- The def function we added is showing below.

<pre>
def list_page
user = User.find_by(name: "student2064")
login_as(user.name)
stub_current_user(user, user.role.name, user.role)
visit '/student_task/list'
visit '/sign_up_sheet/sign_up?id=1&topic_id=1' # signup topic
visit '/student_task/list'
end
</pre>

:- Later on, we will use this list_page function on our test cases. Testing code is showing below.

<pre>
#test for student_task/list page to have the right content
it "have the right content" do
list_page
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badges")
expect(page).to have_no_content("Review Grade")
expect(page).to have_content("Assignment")
expect(page).to have_content("Submission Grade")
expect(page).to have_content("Topic")
expect(page).to have_content("Current Stage")
expect(page).to have_content("Stage Deadline")
expect(page).to have_content("Publishing Rights")
expect(page).to have_content("Assignment1684")
end
</pre>

==='''Travis CI Passing Screenshot'''===
Our Rspec test is able to pass Travis CI testing.

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T05:01:08Z

Xchen33: /* RSpec test */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

Fixing app/views/student_task/list.html.erb

app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the orignal code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

Fixing spec/features/assignment_submission_spec.rb

Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

*First, we modified '''spec/features/airbrake_expection_errors_feature_tests_spec.rb'''. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

*Second, we modified '''spec/features/assignment_submission_spec.rb'''. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for testing needed, and test the necessary function from the student_task/list page.

:- The def function we added is showing below.

<pre>
def list_page
user = User.find_by(name: "student2064")
login_as(user.name)
stub_current_user(user, user.role.name, user.role)
visit '/student_task/list'
visit '/sign_up_sheet/sign_up?id=1&topic_id=1' # signup topic
visit '/student_task/list'
end
</pre>

:- Later on, we will use this list_page function on our test cases. Testing code is showing below.

<pre>
#test for student_task/list page to have the right content
it "have the right content" do
list_page
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badges")
expect(page).to have_no_content("Review Grade")
expect(page).to have_content("Assignment")
expect(page).to have_content("Submission Grade")
expect(page).to have_content("Topic")
expect(page).to have_content("Current Stage")
expect(page).to have_content("Stage Deadline")
expect(page).to have_content("Publishing Rights")
expect(page).to have_content("Assignment1684")
end
</pre>

==='''Travis CI Passing Screenshot'''===
Our Rspec test is able to pass Travis CI testing.

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T04:56:46Z

Xchen33: /* RSpec test */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

Fixing app/views/student_task/list.html.erb

app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the orignal code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

Fixing spec/features/assignment_submission_spec.rb

Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

*First, we modified '''spec/features/airbrake_expection_errors_feature_tests_spec.rb'''. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

*Second, we modified '''spec/features/assignment_submission_spec.rb'''. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for testing needed, and test the necessary function from the student_task/list page.

**The def function we added is showing below.

<pre>
def list_page
user = User.find_by(name: "student2064")
login_as(user.name)
stub_current_user(user, user.role.name, user.role)
visit '/student_task/list'
visit '/sign_up_sheet/sign_up?id=1&topic_id=1' # signup topic
visit '/student_task/list'
end
</pre>

**Later on, we will use this list_page function on our test cases. Testing code is showing below.

<pre>
#test for student_task/list page to have the right content
it "have the right content" do
list_page
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badges")
expect(page).to have_no_content("Review Grade")
expect(page).to have_content("Assignment")
expect(page).to have_content("Submission Grade")
expect(page).to have_content("Topic")
expect(page).to have_content("Current Stage")
expect(page).to have_content("Stage Deadline")
expect(page).to have_content("Publishing Rights")
expect(page).to have_content("Assignment1684")
end
</pre>

==='''Travis CI Passing Screenshot'''===
Our Rspec test is able to pass Travis CI testing.

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T04:54:46Z

Xchen33: /* RSpec test */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

Fixing app/views/student_task/list.html.erb

app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the orignal code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

Fixing spec/features/assignment_submission_spec.rb

Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

*First, we modified '''spec/features/airbrake_expection_errors_feature_tests_spec.rb'''. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

*Second, we modified '''spec/features/assignment_submission_spec.rb'''. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for testing needed, and test the necessary function from the student_task/list page.

The def function we added is showing below.

<pre>
def list_page
user = User.find_by(name: "student2064")
login_as(user.name)
stub_current_user(user, user.role.name, user.role)
visit '/student_task/list'
visit '/sign_up_sheet/sign_up?id=1&topic_id=1' # signup topic
visit '/student_task/list'
end
</pre>

Later on, we will use this list_page function on our test cases. Testing code is showing below.

<pre>
#test for student_task/list page to have the right content
it "have the right content" do
list_page
expect(page).to have_content("Assignments")
expect(page).to have_no_content("badges")
expect(page).to have_no_content("Review Grade")
expect(page).to have_content("Assignment")
expect(page).to have_content("Submission Grade")
expect(page).to have_content("Topic")
expect(page).to have_content("Current Stage")
expect(page).to have_content("Stage Deadline")
expect(page).to have_content("Publishing Rights")
expect(page).to have_content("Assignment1684")
end
</pre>

==='''Travis CI Passing Screenshot'''===
Our Rspec test is able to pass Travis CI testing.

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T00:30:28Z

Xchen33: /* RSpec test */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

Fixing app/views/student_task/list.html.erb

app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the orignal code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===

Fixing spec/features/airbrake_expection_errors_feature_tests_spec.rb

Fixing spec/features/assignment_submission_spec.rb

Fixing spec/features/student_task_spec.rb

According to the modification of each problem, we write test separately to test whether its function is realized or not.

First, we modified spec/features/airbrake_expection_errors_feature_tests_spec.rb. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

Second, we modified spec/features/assignment_submission_spec.rb. In order to use the content inside of the original test file, we added a def function. The function is able to set up the database for test needed, and bring us to the

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T00:23:53Z

Xchen33: /* Deployment */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

Fixing app/views/student_task/list.html.erb

app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the orignal code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===
According to the modification of each problem, we write test separately to test whether its function is realized or not.

First, we modified spec/features/airbrake_expection_errors_feature_tests_spec.rb. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.7.98.249:8080/ E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.7.98.249:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T00:19:15Z

Xchen33: /* Test */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

Fixing app/views/student_task/list.html.erb

app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the orignal code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

=='''Test'''==

==='''RSpec test'''===
According to the modification of each problem, we write test separately to test whether its function is realized or not.

First, we modified spec/features/airbrake_expection_errors_feature_tests_spec.rb. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.46.19.28:8080 E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.46.19.28:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-19T00:17:49Z

Xchen33: /* Files Involved */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

*spec/features/assignment_submission_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

Fixing app/views/student_task/list.html.erb

app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the orignal code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>
=='''Test'''==

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

==='''RSpec test'''===
According to the modification of each problem, we write test separately to test whether its function is realized or not.

First, we modified spec/features/airbrake_expection_errors_feature_tests_spec.rb. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.46.19.28:8080 E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.46.19.28:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-17T01:10:53Z

Xchen33: /* Problem 2, submission grade display */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

Fixing app/views/student_task/list.html.erb

app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the orignal code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>
=='''Test'''==

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

==='''RSpec test'''===
According to the modification of each problem, we write test separately to test whether its function is realized or not.

First, we modified spec/features/airbrake_expection_errors_feature_tests_spec.rb. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.46.19.28:8080 E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.46.19.28:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]

CSC/ECE 517 Fall 2020 - E2065. Fix view in student task/list page

2020-10-17T01:10:34Z

Xchen33: /* Problem 2, submission grade display */

=='''Team Members'''==
*Junyan Li jli56@ncsu.edu

*Ruoyun Ma rma9@ncsu.edu

*Xiwen Chen xchen33@ncsu.edu

*'''Mentor''': Saurabh Shingte (svshingt@ncsu.edu)

=='''Problem Statement'''==
==='''Background'''===

The student_task/list page is the page displayed to a student after logging in into expertiza.

It has mainly two div(s), one to show the upcoming tasks including 2 parts:

* Information about tasks. It shows the projects that need to be completed and how long they are close to the deadline, and marks specific revisions prompts.

* Show the record of each group collaborator(s) for each course.

Another div is to display all the assignments and their information, include Assignment, Course, Topic, Current Stage, Review Grade, Badges, Stage Deadline, Copyright Grants and Make Public.

Original page before modifying showing below, all the courses and all the assignments are displaying in the same table, and badges have own column.

[[File:Orignal.JPG|1000px]]
[[File:Originalcourse.JPG|1000px]]

==='''Files Involved'''===

*app/helpers/student_task_helper.rb

*app/views/student_task/list.html.erb

*spec/features/airbrake_expection_errors_feature_tests_spec.rb

*spec/features/student_task_spec.rb

==='''Problems that need to be fixed'''===

Here are some existing problems and unclear parts of the page：

*'''Problem1''': Consider the cases where a student might be enrolled in assignments from more than one course. In this case, assignments should be grouped by course, with the course name given before the listing of the first assignment.

*'''Problem2''': Remove the column for Review Grade because it makes no sense, change Review Grade to Submission Grade. Show the actual score and show the blue button. If you hover over your mouse at the blue button, should also show the commands about grades.

*'''Problem3''': Delete the badges column, and if the Assignment has a badge, mark it directly next to the assignment name under the assignment column.

*'''Problem4''': There is an unnecessary gap between the two div. It needs to be rearranged to be more beautiful.

=='''Solutions'''==
==='''Problem 1, group the course and display on different tables'''===

Fixing app/views/student_task/list.html.erb

original code of how to display course are showing below
<pre>
<div class="topictable">
<table class="table table-striped" cellpadding="2">
<tr class="taskheader">
<th>Assignment</th>
<th>Course</th>
<th>Topic</th>
<th>Current Stage</th>
<th>Review Grade</th>
<th>Badges</th>
<th>Stage Deadline <img src="/assets/info.png" title="You can change 'Preferred Time Zone' in 'Profile' in the banner."/></th>
<th>Publishing Rights</th>
</tr>
<% @student_tasks.each do |student_task| %>
<% participant = student_task.participant %>
<% if student_task.assignment %>
<tr class="listingRow">

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b></td>

<td><%= student_task.course.try :name %></td>

<% topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id) %>
<% if SignUpTopic.exists?(topic_id) %>
<td><%= SignUpTopic.find(topic_id).try :topic_name %></td>
<% else %>
<td>-</td>
<% end %>

<td>
<% if participant.assignment.link_for_current_stage(topic_id)!= nil && participant.assignment.link_for_current_stage(topic_id).length!=0%>
<%= link_to participant.assignment.current_stage_name(topic_id), participant.assignment.link_for_current_stage(topic_id) %>
<% else %>
<%= participant.assignment.current_stage_name(topic_id) %>
<% end %>
</td>

<td><%= get_review_grade_info(participant) %></td>

<td><%= get_awarded_badges(participant) %></td>

<td><%= student_task.stage_deadline.in_time_zone(session[:user].timezonepref) %></td>

<td align=center><%= participant.permission_granted ? "granted" : "denied" %></td>
</tr>
<% end %>
<% end %>
</table>
</pre>

In order to group the courses, we added a group_by method to find out which courses does this assignment belongs to, and group the assignments that has the same courses name at one table. The modified code is showing below.

<pre>
<% group = @student_tasks.group_by(&:course).each do | course, student_tasks|%>
<% if course%>
<%end %>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">

<% if !student_tasks.first.course %>
<h1>No Course Assigned Yet</h1>
<%else%>
<h1><%=student_tasks.first.course.try :name %></h1>
<%end%>
</pre>

We will print out the course name as each table head, group the assignments, and we take down Course coloum from table content since the course name is already showing as table head. Also, for the assignments that have not assigned to a course, we will print out <q>No Course Assigned Yet</q>.

==='''Problem 2, submission grade display'''===

Fixing app/views/student_task/list.html.erb
app/helpers/student_task_helper.rb

For this problem, first, we change Review Grade to Submission grade, which only need to modify
<pre>
<th>Review Grade</th>
</pre>
to
<pre>
<th>Submission Grade</th>
</pre>
on list.html.erb.

Second, we change how we display the score. Instead of showing a blue button, we added how much scores they got (e.g. 32/40), which make users easier to see what scores they got. We modified get_review_grade_info(participant) function inside of student_task_helper.rb.

Original code is showing below
<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/100\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = "<img src = '/assets/info.png' title = '" + info + "'>"
end
result.html_safe
end
</pre>

In the orignal code, each grade is assigned to /100, which is not correct because not every assignment has 10 reviews (one review count for 10 point). Instead of using /100, we use num_reviews_allowed, it will give us the maximum reviews that each assignments are allowed. Since we need to display the current score on the page, we need an array to carry the current score and display it on the result. The modified code showing below.

<pre>
def get_review_grade_info(participant)
info = ''
if participant.try(:review_grade).try(:grade_for_reviewer).nil? ||
participant.try(:review_grade).try(:comment_for_reviewer).nil?
result = "N/A"
else
score = participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s
info = "Score: " + participant.try(:review_grade).try(:grade_for_reviewer).to_s + "/" + (participant.assignment.num_reviews_allowed*10).to_s + "\n"
info += "Comment: " + participant.try(:review_grade).try(:comment_for_reviewer).to_s
info = truncate(info, length: 1500, omission: '...')
result = score + "<img src = '/assets/info.png' title = '" + info + "'>"
end
</pre>

==='''Problem 3, badges showing location fixing'''===

Fixing app/views/student_task/list.html.erb

Since not too many assignments are able to get badges, that make badges column barely have contents. Therefore, we display it after the assignment name and delete Badges coloum. If one student gets a badge, it will display a small picture after the badged assignment. Hover over your mouse on it, and it will display the information about this badge.

<pre>

<td><b><%= link_to student_task.assignment.name, :action => 'view', :id => participant %></b><p><%= get_awarded_badges(participant) %></p></td>
</pre>

==='''Problem 4, unnecessary white space'''===
Fixing app/views/student_task/list.html.erb
Our main purpose of this project is to make the student_task/list page looks better. For problem 4, we fixed unnecessary white space between two divs. We changed two div's style to style = <q>width:18</q> and style = <q>width:80</q>, so two div will display on the same lines.
<pre>
<div class="taskbox" style="width:18%; display: inline-block; float:left; margin-right: 10px;" >
</pre>

<pre>
<div class="topictable" style="float: right;width: 80%;margin-bottom: 10px; display: inline-block; border: 1px solid #000000">
</pre>
=='''Test'''==

==='''Page Change Display'''===

Page showing right now
[[File:Coursedisplay.PNG|1000px]]

[[File:Differentgroup.JPG|1000px]]

==='''RSpec test'''===
According to the modification of each problem, we write test separately to test whether its function is realized or not.

First, we modified spec/features/airbrake_expection_errors_feature_tests_spec.rb. Since when no assignment was assigned to the student, it should not show the table content on the page. Change from
<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).to have_content('Review Grade')
expect(page).to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

to

<pre>
it "can access to '/student_task/list' after login as a student" do
stu = create(:student)
login_as stu.name
visit '/tree_display/list'
expect(page).to have_current_path('/student_task/list')
expect(page).to have_content('Assignments')
expect(page).to have_content('Tasks not yet started')
expect(page).to have_content('Students who have teamed with you')
expect(page).not_to have_content('Review Grade')
expect(page).not_to have_content('Publishing Rights')
expect(page).not_to have_content('Welcome!')
expect(page).not_to have_content('User Name')
expect(page).not_to have_content('Password')
expect(page).not_to have_content('SIGN IN')
end
</pre>

==='''Deployment'''===

We deploy this part of the program on VCL to test UI and other functions. The link to the website is as follows:
[http://152.46.19.28:8080 E2065 Repo Link]

Using the following account to log in for testing：

Username: instructor6

Password: password

And then click [http://152.46.19.28:8080/student_task/list 'Assignments'] to the fixed page.

=='''References'''==
*[https://github.com/expertiza/expertiza Expertiza on GitHub]
*[http://expertiza.ncsu.edu/ The live Expertiza website]
*[http://research.csc.ncsu.edu/efg/expertiza Expertiza project Details]
*[https://www.youtube.com/channel/UCdKXzox7hrWjfOMML6FzTWg Expertiza YouTube Channel]