Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-11-07T22:26:29Z

Wfu4: /* Instructor End */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.17.70:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
[[File:student-table.png ]]

[[File:Student-detail.png]]

* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>
[[File:Student-feedback.png]]

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>
===Instructor End===

* Create new method view_instructor for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view_instructor
@response = Response.find(params[:id])
@map = @response.map
set_content_instructor
render "response/view"
end
......
# sets content in instructor end
def set_content_instructor(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@assignment = @participant.assignment
questionnaires = @assignment.questionnaires
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
# retrieves questions for questionnaires
def retrieve_questions(questionnaires, assignment_id)
questions = {}
questionnaires.each do |questionnaire|
round = AssignmentQuestionnaire.where(assignment_id: assignment_id, questionnaire_id: questionnaire.id).first.used_in_round
questionnaire_symbol = if !round.nil?
(questionnaire.symbol.to_s + round.to_s).to_sym
else
questionnaire.symbol
end
questions[questionnaire_symbol] = questionnaire.questions
end
questions
end
</pre>

* change the url jumping to after clicking to a certain reviewer.
''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view_instructor?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>" data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>
</pre>

* render grades/tabbed_reviews for review details at instructor end
''' app/views/response/view.html.erb '''
<pre>

<% if controller.action_name != "view_instructor" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round according to which round user click at instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view_instructor"%>
<% next if round.to_s != @round.to_s %>
<% end %>
......
<% end %>
</pre>

* Create construct_instructor_htm_helper in respond model in order to not show review number
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% prefix = "instructor" if controller.action_name == "view_instructor" %>
</pre>

''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor_html_helper identifier, self_id, count
......
def construct_instructor_html_helper identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view_instructor"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
......
<% end %>
</pre>
[[File:instructorend.png ]]

=='''Test Plans'''==
*The rspec test plan is written such that each requirement(for student-end and instructor-end) will have at least 1 different test.
*The test plan is also used as a check of bug fix implementation. It ensures that each required function is implemented and each bug is well fixed.
*The test file can be manually executed the by running "rspec ./spec/features/tabbed_reviews_spec.rb" on rails terminal.
*Use Unit test to test all the codes mentioned above with respect to views, models and controllers.

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (wfu4@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1951. Remove multiple topics at a time

2019-10-30T14:15:46Z

Wfu4: /* Problem Statement */

This wiki page is for the description of E1951. Remove multiple topics at a time (Issue #1409).

=='''Introduction'''==
The Expertiza project is software to create reusable learning objects through peer review. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages.

=='''Problem Statement'''==
If an instructor or a TA wants to delete topics, he has to delete one topic at a time and has to wait for the page to refresh and then (s)he can proceed to delete the next topic, topics can only be deleted one by one.

===To fix the problem:===
1.There should be a checkbox column, along with other columns in “Topics” tab, where a user can select the topics (s)he wants to delete.

2.There should be a delete button/link at the end of the topic table with the name “delete selected topics” to delete the selected topics after a confirmation, prompted post clicking the button/link.

3.There should be a button/link alongside “delete selected topics” by the name “Select all” so that a user can select all and delete them in one go after clicking on “delete selected topics”.

=='''Solution'''==

===1.Modify view===
File: app/views/sign_up_sheet/_add_topics.html.erb

Add bottoms of 'Delete select topics' and 'Select all'
<pre>
<input type="button" value="Delete select topics" onclick="deleteTopics()" />|

<a id="select all " onclick="checkAll()">Select all</a> |
</pre>

File: app/views/sign_up_sheet/_table_header.html.erb

Add 'Select' header
<pre>
<th width="5%">Select?</th>
</pre>

File: app/views/sign_up_sheet/_table_line.html.erb

Add selected checkbox
<pre>
<td><input type="checkbox" name="query_mySelectBox"></td>
</pre>

===2.'Select All' function===
File: app/assets/javascripts/signup.js

Select All function checks all checkbox of topics.
<pre>
function selectAll(source) {
checkboxes = document.getElementsByName('mySelectBox');
for (var i = 0, n = checkboxes.length; i < n; i++) {
checkboxes[i].checked = source.checked;
}
}
</pre>

===3.'Delete' function===
File: app/controllers/sign_up_sheet_controller.rb

Define delete all and get selected topics methods.
<pre>
# This deletes all selected topics
def delete_all_selected_topics
load_all_selected_topics
@stopics.each(&:destroy)
flash[:success] = "All selected topics have been deleted successfully."
respond_to do |format|
format.html { redirect_to edit_assignment_path(params[:a_id]) + "#tabs-2" }
format.js {}
end
end

# This get all selected topics
def load_all_selected_topics
@stopics = SignUpTopic.where(assignment_id: params[:a_id], topic_identifier: params[:idents])
end
</pre>

File: app/views/sign_up_sheet/_add_signup_topics.html.erb

<pre>
#change <table class="table table-striped"> to
<table class="table table-striped" id="Table1">
</pre>

File: app/views/sign_up_sheet/_add_topics.html.erb

Delete function destroys all selected topics.
<pre>
<script>
function deleteTopics() {
var msg = 'Are you sure? It will destroy all selected topics';
if (confirm(msg)) {
var identifiers = []
$("#Table1 input[type=checkbox]:checked").each(function() {
var ient = $(this).closest('tr').find('#ident').text();
identifiers.push(ient);
});
jQuery.ajax({
url: '/sign_up_sheet/delete_all_selected_topics',
method: 'POST',
data: {
idents: identifiers,
a_id: <%= @assignment.id %>
},
success: function() {
location.reload();
}
});
} else {
window.location.href = '<%= edit_assignment_path(@assignment.id) + "#tabs-2" %>';
}
}
</script>
</pre>

File: app/views/sign_up_sheet/_table_line.html.erb

<pre>
#change <td><%= topic.topic_identifier %></td> to
<td id='ident'><%= topic.topic_identifier %></td>
</pre>

File: config/routes.rb

Add url.
<pre>
post :delete_all_selected_topics
</pre>

=='''Result'''==
Before clicking 'Select all' bottom, there are checkboxes that could select each topic.
[[File:Before_select.png]]
After clicking 'Select all' bottom, all checkboxes are selected.

[[File:After_select.png]]
After pushing 'Deleted selected topics', there's a confirmation alert. After clicking yes could delete all topics.

[[File:Confirm_deletion.png]]
=='''Test'''==
File: spec/controllers/sign_up_sheet_controller_spec.rb

Select assignment with id '834' and topic with id ['E1732'] as params. Post params to delete_all_selected_topics. Expect success flash with 'All selected topics have been deleted successfully.' and redirect to '/assignments/834/edit#tabs-2'.
<pre>
describe '#delete_all_selected_topics' do
it 'delete_all_selected_topics and redirects to edit assignment page' do
allow(SignUpTopic).to receive(:find).with(assignment_id: '834',topic_identifier: ['E1732']).and_return(topic)
params = {assignment_id: 834, idents: ['E1732']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
expect(response).to redirect_to('/assignments/834/edit#tabs-2')
end
end
</pre>

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-30T00:33:23Z

Wfu4: /* Test Plans */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.17.70:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
[[File:student-table.png ]]

[[File:Student-detail.png]]

* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>
[[File:Student-feedback.png]]

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>
===Instructor End===

* Create new method view_instructor for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view_instructor
@response = Response.find(params[:id])
@map = @response.map
set_content_instructor
render "response/view"
end
......
def set_content_instructor(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@assignment = @participant.assignment
questionnaires = @assignment.questionnaires
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
def retrieve_questions(questionnaires, assignment_id)
questions = {}
questionnaires.each do |questionnaire|
round = AssignmentQuestionnaire.where(assignment_id: assignment_id, questionnaire_id: questionnaire.id).first.used_in_round
questionnaire_symbol = if !round.nil?
(questionnaire.symbol.to_s + round.to_s).to_sym
else
questionnaire.symbol
end
questions[questionnaire_symbol] = questionnaire.questions
end
questions
end
</pre>

* change the url jumping to after clicking to a certain reviewer.
''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view_instructor?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>" data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>
</pre>

* render grades/tabbed_reviews for review details at instructor end
''' app/views/response/view.html.erb '''
<pre>

<% if controller.action_name != "view_instructor" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round according to which round user click at instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view_instructor"%>
<% next if round.to_s != @round.to_s %>
<% end %>
......
<% end %>
</pre>

* Create construct_instructor_htm_helper in respond model in order to not show review number
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% prefix = "instructor" if controller.action_name == "view_instructor" %>
</pre>

''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor_html_helper identifier, self_id, count
......
def construct_instructor_html_helper identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view_instructor"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
......
<% end %>
</pre>
[[File:instructorend.png ]]

=='''Test Plans'''==
*The rspec test plan is written such that each requirement(for student-end and instructor-end) will have at least 1 different test.
*The test plan is also used as a check of bug fix implementation. It ensures that each required function is implemented and each bug is well fixed.
*The test file can be manually executed the by running "rspec ./spec/features/tabbed_reviews_spec.rb" on rails terminal.
*Use Unit test to test all the codes mentioned above with respect to views, models and controllers.

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (wfu4@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-30T00:32:48Z

Wfu4: /* Test Plans */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.17.70:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
[[File:student-table.png ]]

[[File:Student-detail.png]]

* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>
[[File:Student-feedback.png]]

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>
===Instructor End===

* Create new method view_instructor for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view_instructor
@response = Response.find(params[:id])
@map = @response.map
set_content_instructor
render "response/view"
end
......
def set_content_instructor(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@assignment = @participant.assignment
questionnaires = @assignment.questionnaires
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
def retrieve_questions(questionnaires, assignment_id)
questions = {}
questionnaires.each do |questionnaire|
round = AssignmentQuestionnaire.where(assignment_id: assignment_id, questionnaire_id: questionnaire.id).first.used_in_round
questionnaire_symbol = if !round.nil?
(questionnaire.symbol.to_s + round.to_s).to_sym
else
questionnaire.symbol
end
questions[questionnaire_symbol] = questionnaire.questions
end
questions
end
</pre>

* change the url jumping to after clicking to a certain reviewer.
''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view_instructor?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>" data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>
</pre>

* render grades/tabbed_reviews for review details at instructor end
''' app/views/response/view.html.erb '''
<pre>

<% if controller.action_name != "view_instructor" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round according to which round user click at instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view_instructor"%>
<% next if round.to_s != @round.to_s %>
<% end %>
......
<% end %>
</pre>

* Create construct_instructor_htm_helper in respond model in order to not show review number
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% prefix = "instructor" if controller.action_name == "view_instructor" %>
</pre>

''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor_html_helper identifier, self_id, count
......
def construct_instructor_html_helper identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view_instructor"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
......
<% end %>
</pre>
[[File:instructorend.png ]]

=='''Test Plans'''==
*The rspec test plan is written such that each requirement(for student-end and instructor-end) will have at least 1 different test.
*The test plan is also used as a check of bug fix implementation. It ensures that each required function is implemented and each bug is well fixed.
*The test file can be manually executed the by running "rspec ./spec/features/tabbed_reviews_spec.rb" on rails terminal.
*Use Unit test to test all the function mentioned above with respect to views, models and controllers.

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (wfu4@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-30T00:32:38Z

Wfu4: /* Test Plans */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.17.70:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
[[File:student-table.png ]]

[[File:Student-detail.png]]

* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>
[[File:Student-feedback.png]]

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>
===Instructor End===

* Create new method view_instructor for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view_instructor
@response = Response.find(params[:id])
@map = @response.map
set_content_instructor
render "response/view"
end
......
def set_content_instructor(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@assignment = @participant.assignment
questionnaires = @assignment.questionnaires
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
def retrieve_questions(questionnaires, assignment_id)
questions = {}
questionnaires.each do |questionnaire|
round = AssignmentQuestionnaire.where(assignment_id: assignment_id, questionnaire_id: questionnaire.id).first.used_in_round
questionnaire_symbol = if !round.nil?
(questionnaire.symbol.to_s + round.to_s).to_sym
else
questionnaire.symbol
end
questions[questionnaire_symbol] = questionnaire.questions
end
questions
end
</pre>

* change the url jumping to after clicking to a certain reviewer.
''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view_instructor?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>" data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>
</pre>

* render grades/tabbed_reviews for review details at instructor end
''' app/views/response/view.html.erb '''
<pre>

<% if controller.action_name != "view_instructor" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round according to which round user click at instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view_instructor"%>
<% next if round.to_s != @round.to_s %>
<% end %>
......
<% end %>
</pre>

* Create construct_instructor_htm_helper in respond model in order to not show review number
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% prefix = "instructor" if controller.action_name == "view_instructor" %>
</pre>

''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor_html_helper identifier, self_id, count
......
def construct_instructor_html_helper identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view_instructor"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
......
<% end %>
</pre>
[[File:instructorend.png ]]

=='''Test Plans'''==
*The rspec test plan is written such that each requirement(for student-end and instructor-end) will have at least 1 different test.
*The test plan is also used as a check of bug fix implementation. It ensures that each required function is implemented and each bug is well fixed.
*The test file can be manually executed the by running "rspec ./spec/features/tabbed_reviews_spec.rb" on rails terminal.
*We need use Unit test to test all the function mentioned above with respect to views, models and controllers.

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (wfu4@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-30T00:30:26Z

Wfu4: /* Test Plans */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.17.70:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
[[File:student-table.png ]]

[[File:Student-detail.png]]

* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>
[[File:Student-feedback.png]]

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>
===Instructor End===

* Create new method view_instructor for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view_instructor
@response = Response.find(params[:id])
@map = @response.map
set_content_instructor
render "response/view"
end
......
def set_content_instructor(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@assignment = @participant.assignment
questionnaires = @assignment.questionnaires
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
def retrieve_questions(questionnaires, assignment_id)
questions = {}
questionnaires.each do |questionnaire|
round = AssignmentQuestionnaire.where(assignment_id: assignment_id, questionnaire_id: questionnaire.id).first.used_in_round
questionnaire_symbol = if !round.nil?
(questionnaire.symbol.to_s + round.to_s).to_sym
else
questionnaire.symbol
end
questions[questionnaire_symbol] = questionnaire.questions
end
questions
end
</pre>

* change the url jumping to after clicking to a certain reviewer.
''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view_instructor?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>" data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>
</pre>

* render grades/tabbed_reviews for review details at instructor end
''' app/views/response/view.html.erb '''
<pre>

<% if controller.action_name != "view_instructor" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round according to which round user click at instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view_instructor"%>
<% next if round.to_s != @round.to_s %>
<% end %>
......
<% end %>
</pre>

* Create construct_instructor_htm_helper in respond model in order to not show review number
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% prefix = "instructor" if controller.action_name == "view_instructor" %>
</pre>

''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor_html_helper identifier, self_id, count
......
def construct_instructor_html_helper identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view_instructor"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
......
<% end %>
</pre>
[[File:instructorend.png ]]

=='''Test Plans'''==
*The rspec test plan is written such that each requirement(for student-end and instructor-end) will have at least 1 different test.
*The test plan is also used as a check of bug fix implementation. It ensures that each required function is implemented and each bug is well fixed.
*The test file can be manually executed the by running "rspec ./spec/features/tabbed_reviews_spec.rb" on rails terminal.
*We need to test all the function mentioned above with respect to views, models and controllers.

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (wfu4@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-29T23:43:02Z

Wfu4: /* Instructor End */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.17.70:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
[[File:student-table.png ]]

[[File:Student-detail.png]]

* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>
[[File:Student-feedback.png]]

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>
===Instructor End===

* Create new method view_instructor for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view_instructor
@response = Response.find(params[:id])
@map = @response.map
set_content_instructor
render "response/view"
end
......
def set_content_instructor(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@assignment = @participant.assignment
questionnaires = @assignment.questionnaires
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
def retrieve_questions(questionnaires, assignment_id)
questions = {}
questionnaires.each do |questionnaire|
round = AssignmentQuestionnaire.where(assignment_id: assignment_id, questionnaire_id: questionnaire.id).first.used_in_round
questionnaire_symbol = if !round.nil?
(questionnaire.symbol.to_s + round.to_s).to_sym
else
questionnaire.symbol
end
questions[questionnaire_symbol] = questionnaire.questions
end
questions
end
</pre>

* change the url jumping to after clicking to a certain reviewer.
''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view_instructor?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>" data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>
</pre>

* render grades/tabbed_reviews for review details at instructor end
''' app/views/response/view.html.erb '''
<pre>

<% if controller.action_name != "view_instructor" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round according to which round user click at instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view_instructor"%>
<% next if round.to_s != @round.to_s %>
<% end %>
......
<% end %>
</pre>

* Create construct_instructor_htm_helper in respond model in order to not show review number
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% prefix = "instructor" if controller.action_name == "view_instructor" %>
</pre>

''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor_html_helper identifier, self_id, count
......
def construct_instructor_html_helper identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view_instructor"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
......
<% end %>
</pre>
[[File:instructorend.png ]]

=='''Test Plans'''==
*The rspec test plan is written such that each requirement(for student-end and instructor-end) will have at least 1 different test.
*The test plan is also used as a check of bug fix implementation. It ensures that each required function is implemented and each bug is well fixed.
*The test file can be manually executed the by running "rspec ./spec/features/tabbed_reviews_spec.rb" on rails terminal.

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (wfu4@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-29T23:37:59Z

Wfu4: /* Instructor End */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.17.70:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
[[File:student-table.png ]]

[[File:Student-detail.png]]

* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>
[[File:Student-feedback.png]]

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>
===Instructor End===

* Create new method view_instructor for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view_instructor
@response = Response.find(params[:id])
@map = @response.map
set_content_instructor
render "response/view"
end
......
def set_content_instructor(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@assignment = @participant.assignment
questionnaires = @assignment.questionnaires
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
def retrieve_questions(questionnaires, assignment_id)
questions = {}
questionnaires.each do |questionnaire|
round = AssignmentQuestionnaire.where(assignment_id: assignment_id, questionnaire_id: questionnaire.id).first.used_in_round
questionnaire_symbol = if !round.nil?
(questionnaire.symbol.to_s + round.to_s).to_sym
else
questionnaire.symbol
end
questions[questionnaire_symbol] = questionnaire.questions
end
questions
end
</pre>

* change the url jumping to after clicking to a certain reviewer.
''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>" data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>
</pre>

* render grades/tabbed_reviews for review details at instructor end
''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round according to which round user click at instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
......
<% end %>
</pre>

* Create construct_instructor2_html in respond model in order to not show review number
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
......
<% end %>
</pre>
[[File:instructorend.png ]]

=='''Test Plans'''==
*The rspec test plan is written such that each requirement(for student-end and instructor-end) will have at least 1 different test.
*The test plan is also used as a check of bug fix implementation. It ensures that each required function is implemented and each bug is well fixed.
*The test file can be manually executed the by running "rspec ./spec/features/tabbed_reviews_spec.rb" on rails terminal.

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (wfu4@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-29T03:28:51Z

Wfu4: /* Team Information */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.7.98.106:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
[[File:student-table.png ]]

[[File:Student-detail.png]]

* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>
[[File:Student-feedback.png]]

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>
===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@assignment = @participant.assignment
questionnaires = @assignment.questionnaires
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
def retrieve_questions(questionnaires, assignment_id)
questions = {}
questionnaires.each do |questionnaire|
round = AssignmentQuestionnaire.where(assignment_id: assignment_id, questionnaire_id: questionnaire.id).first.used_in_round
questionnaire_symbol = if !round.nil?
(questionnaire.symbol.to_s + round.to_s).to_sym
else
questionnaire.symbol
end
questions[questionnaire_symbol] = questionnaire.questions
end
questions
end
</pre>

* change the url jumping to after clicking to a certain reviewer.
''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>" data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>
</pre>

* render grades/tabbed_reviews for review details at instructor end
''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round according to which round user click at instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
......
<% end %>
</pre>

* Create construct_instructor2_html in respond model in order to not show review number
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
......
<% end %>
</pre>
[[File:instructorend.png ]]

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (wfu4@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-29T00:23:24Z

Wfu4: /* Instructor End */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>

===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@assignment = @participant.assignment
questionnaires = @assignment.questionnaires
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
def retrieve_questions(questionnaires, assignment_id)
questions = {}
questionnaires.each do |questionnaire|
round = AssignmentQuestionnaire.where(assignment_id: assignment_id, questionnaire_id: questionnaire.id).first.used_in_round
questionnaire_symbol = if !round.nil?
(questionnaire.symbol.to_s + round.to_s).to_sym
else
questionnaire.symbol
end
questions[questionnaire_symbol] = questionnaire.questions
end
questions
end
</pre>

* change the url jumping to after clicking to a certain reviewer.
''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>" data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>
</pre>

* render grades/tabbed_reviews for review details at instructor end
''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round according to which round user click at instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
......
<% end %>
</pre>

* Create construct_instructor2_html in respond model in order to not show review number
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
......
<% end %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-29T00:21:19Z

Wfu4: /* Instructor End */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>

===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@assignment = @participant.assignment
questionnaires = @assignment.questionnaires
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
def retrieve_questions(questionnaires, assignment_id)
questions = {}
questionnaires.each do |questionnaire|
round = AssignmentQuestionnaire.where(assignment_id: assignment_id, questionnaire_id: questionnaire.id).first.used_in_round
questionnaire_symbol = if !round.nil?
(questionnaire.symbol.to_s + round.to_s).to_sym
else
questionnaire.symbol
end
questions[questionnaire_symbol] = questionnaire.questions
end
questions
end
</pre>

* change the url jumping to after clicking to a certain reviewer.
''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>" data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>
</pre>

* render grades/tabbed_reviews for review details at instructor end
''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round according to which round user click at instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
......
<% end %>
</pre>

* Create construct_instructor2_html in respond model in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
......
<% end %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-29T00:17:41Z

Wfu4: /* Instructor End */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>

===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@assignment = @participant.assignment
questionnaires = @assignment.questionnaires
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
def retrieve_questions(questionnaires, assignment_id)
questions = {}
questionnaires.each do |questionnaire|
round = AssignmentQuestionnaire.where(assignment_id: assignment_id, questionnaire_id: questionnaire.id).first.used_in_round
questionnaire_symbol = if !round.nil?
(questionnaire.symbol.to_s + round.to_s).to_sym
else
questionnaire.symbol
end
questions[questionnaire_symbol] = questionnaire.questions
end
questions
end
</pre>

* change the url jumping to after clicking to a certain reviewer.
''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>" data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>
</pre>

* render grades/tabbed_reviews for review details at instructor end
''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round according to which round user click at instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in respond model in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
......
<% end %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-29T00:16:13Z

Wfu4: /* Instructor End */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>

===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@assignment = @participant.assignment
questionnaires = @assignment.questionnaires
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
def retrieve_questions(questionnaires, assignment_id)
questions = {}
questionnaires.each do |questionnaire|
round = AssignmentQuestionnaire.where(assignment_id: assignment_id, questionnaire_id: questionnaire.id).first.used_in_round
questionnaire_symbol = if !round.nil?
(questionnaire.symbol.to_s + round.to_s).to_sym
else
questionnaire.symbol
end
questions[questionnaire_symbol] = questionnaire.questions
end
questions
end
</pre>

* change the url jumping to after clicking to a certain reviewer.
''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>" data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>
</pre>

* render grades/tabbed_reviews for review details at instructor end
''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round according to which round user click at instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in respond model in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
......
<% end %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-29T00:03:57Z

Wfu4: /* Issue details */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

How to get the view of reviewers, scores and review details on student end? Click "Alternate View" button, and click "show reviews" link. The reviewers and scores pop up on the top and review details are below them.
How to get the view of reviewers, scores and review details on instructor end? Click "Scores" for a certain assignment and choose a team. Click "Statistics" tab and then reviewers and scores table show up. Click "Reviews" tab and then click one of students' name link in the table head. And a new page pops up with review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Where to find Give Feedback link? On student end, click "Alternate View" button and click "show reviews" link. At the bottom of a certain review, a give feedback link shows up.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>

===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
......
@participant = @map.reviewer
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@@ -264,7 +273,9 @@ def set_content(new_response = false)
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% prefix = nil %>
......
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
<% end %>
</table><hr>
<% end %>
</pre>

''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>"
data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>

</pre>

''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round for instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
elsif prefix # has prefix means view_score page in instructor end
self_id = prefix + '_' + self.id.to_s
code = construct_instructor_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s + '_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<% end %>
<% end %>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
@@ -37,6 +39,7 @@
<% review_feedback = nil %>
<% count = count + 1 %>
<% prefix = nil %>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
@@ -33,8 +35,13 @@
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
<% if controller.action_name != "view2"%>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% end %>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
<tr><td>
<% review_feedback = nil %>
<% count = count + 1 %>
@@ -72,7 +79,9 @@
</td></tr>
<% end %>
<% end %>
<% if controller.action_name != "view2"%>
</table><hr>
<% end %>
<% end %>
<% else %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before(:each) do
# assignment and topic
create(:assignment,
name: "Test Assignment",
directory_path: "Test Assignment",
rounds_of_reviews: 2,
staggered_deadline: true,
max_team_size: 1,
allow_selecting_additional_reviews_after_1st_round: true)
create_list(:participant, 3)
create(:topic, topic_name: "Topic_1")
create(:topic, topic_name: "Topic_2")
create(:topic, topic_name: "Topic_3")
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
# rubric
create(:questionnaire, name: "TestQuestionnaire1")
create(:questionnaire, name: "TestQuestionnaire2")
create(:question, txt: "Question1", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, type: "Criterion")
create(:question, txt: "Question2", questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, type: "Criterion")
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire1').first, used_in_round: 1)
create(:assignment_questionnaire, questionnaire: ReviewQuestionnaire.where(name: 'TestQuestionnaire2').first, used_in_round: 2)
questionnaire_id = ReviewQuestionnaire.first.id.to_s

# deadline type
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')

create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
visit "response/view2?id=#{questionnaire_id}&&team=1&&round=1&&assignment=#{assignment_id}"
end

it "can go to review details" do
expect(page).to have_content "Toggle navigation"
expect(page).to have_content "Papers on Expertiza"
expect(page).to have_content "response"
end

end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-28T23:51:50Z

Wfu4: /* Student End */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student-end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor-end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>

===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
......
@participant = @map.reviewer
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@@ -264,7 +273,9 @@ def set_content(new_response = false)
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% prefix = nil %>
......
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
<% end %>
</table><hr>
<% end %>
</pre>

''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>"
data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>

</pre>

''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round for instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
elsif prefix # has prefix means view_score page in instructor end
self_id = prefix + '_' + self.id.to_s
code = construct_instructor_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s + '_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<% end %>
<% end %>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
@@ -37,6 +39,7 @@
<% review_feedback = nil %>
<% count = count + 1 %>
<% prefix = nil %>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
@@ -33,8 +35,13 @@
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
<% if controller.action_name != "view2"%>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% end %>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
<tr><td>
<% review_feedback = nil %>
<% count = count + 1 %>
@@ -72,7 +79,9 @@
</td></tr>
<% end %>
<% end %>
<% if controller.action_name != "view2"%>
</table><hr>
<% end %>
<% end %>
<% else %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before (:each) do
create(:instructor)
create(:assignment, course: nil, name: 'Test Assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

assignment_team = create(:assignment_team)

create(:team_user)
login_as 'instructor6'
visit "/grades/view?id=#{assignment_id}"

end

it "shows summary report" do
expect(page).to have_content "Summary report for Test Assignment"
expect(page).to have_content "Show all teams"
page.first(:xpath, "//a[contains(@href,'#')]").click

end

end

describe "test for instructor" do
before (:each) do
create(:instructor)
@assignment = create(:assignment, name: "Test Assignment", directory_path: 'test_assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id
assignment_team = create(:assignment_team)
create(:team_user)
team_id = AssignmentTeam.first.id.to_s
create(:topic)
create(:topic, topic_name: "TestReview")
create(:assignment_questionnaire)
create(:question)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
#create(:review)
#review_id = Review.first.id.to_s
#create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
login_as 'instructor6'
#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
login_as 'instructor6'
visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
end
end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-28T23:49:39Z

Wfu4: /* Student End */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student-end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor-end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if rscore and rscore[:assessments].length > 0 %>
<%flag_varying_rubrics=false%>

@@ -25,6 +29,9 @@
<%if flag_varying_rubrics==false%>
<%= render :partial => 'grades/review_table', :locals => { :ctrl => 'review', :caction => 'view_review', :symbol => "review".to_sym, :prefix => prefix, :assignment => participant.assignment, :reviews => rscore[:assessments], :collabel => "Review", :rowlabel => "Reviewer" }%>
<%end%>
</td>
</tr>
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>

===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
......
@participant = @map.reviewer
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@@ -264,7 +273,9 @@ def set_content(new_response = false)
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% prefix = nil %>
......
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
<% end %>
</table><hr>
<% end %>
</pre>

''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>"
data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>

</pre>

''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round for instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
elsif prefix # has prefix means view_score page in instructor end
self_id = prefix + '_' + self.id.to_s
code = construct_instructor_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s + '_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<% end %>
<% end %>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
@@ -37,6 +39,7 @@
<% review_feedback = nil %>
<% count = count + 1 %>
<% prefix = nil %>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
@@ -33,8 +35,13 @@
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
<% if controller.action_name != "view2"%>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% end %>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
<tr><td>
<% review_feedback = nil %>
<% count = count + 1 %>
@@ -72,7 +79,9 @@
</td></tr>
<% end %>
<% end %>
<% if controller.action_name != "view2"%>
</table><hr>
<% end %>
<% end %>
<% else %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before (:each) do
create(:instructor)
create(:assignment, course: nil, name: 'Test Assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

assignment_team = create(:assignment_team)

create(:team_user)
login_as 'instructor6'
visit "/grades/view?id=#{assignment_id}"

end

it "shows summary report" do
expect(page).to have_content "Summary report for Test Assignment"
expect(page).to have_content "Show all teams"
page.first(:xpath, "//a[contains(@href,'#')]").click

end

end

describe "test for instructor" do
before (:each) do
create(:instructor)
@assignment = create(:assignment, name: "Test Assignment", directory_path: 'test_assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id
assignment_team = create(:assignment_team)
create(:team_user)
team_id = AssignmentTeam.first.id.to_s
create(:topic)
create(:topic, topic_name: "TestReview")
create(:assignment_questionnaire)
create(:question)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
#create(:review)
#review_id = Review.first.id.to_s
#create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
login_as 'instructor6'
#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
login_as 'instructor6'
visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
end
end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-28T23:48:08Z

Wfu4: /* Student End */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student-end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor-end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistics view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
</pre>
'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if rscore and rscore[:assessments].length > 0 %>
<%flag_varying_rubrics=false%>

@@ -25,6 +29,9 @@
<%if flag_varying_rubrics==false%>
<%= render :partial => 'grades/review_table', :locals => { :ctrl => 'review', :caction => 'view_review', :symbol => "review".to_sym, :prefix => prefix, :assignment => participant.assignment, :reviews => rscore[:assessments], :collabel => "Review", :rowlabel => "Reviewer" }%>
<%end%>
</td>
</tr>
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>

===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
......
@participant = @map.reviewer
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@@ -264,7 +273,9 @@ def set_content(new_response = false)
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% prefix = nil %>
......
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
<% end %>
</table><hr>
<% end %>
</pre>

''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>"
data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>

</pre>

''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round for instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
elsif prefix # has prefix means view_score page in instructor end
self_id = prefix + '_' + self.id.to_s
code = construct_instructor_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s + '_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<% end %>
<% end %>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
@@ -37,6 +39,7 @@
<% review_feedback = nil %>
<% count = count + 1 %>
<% prefix = nil %>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
@@ -33,8 +35,13 @@
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
<% if controller.action_name != "view2"%>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% end %>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
<tr><td>
<% review_feedback = nil %>
<% count = count + 1 %>
@@ -72,7 +79,9 @@
</td></tr>
<% end %>
<% end %>
<% if controller.action_name != "view2"%>
</table><hr>
<% end %>
<% end %>
<% else %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before (:each) do
create(:instructor)
create(:assignment, course: nil, name: 'Test Assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

assignment_team = create(:assignment_team)

create(:team_user)
login_as 'instructor6'
visit "/grades/view?id=#{assignment_id}"

end

it "shows summary report" do
expect(page).to have_content "Summary report for Test Assignment"
expect(page).to have_content "Show all teams"
page.first(:xpath, "//a[contains(@href,'#')]").click

end

end

describe "test for instructor" do
before (:each) do
create(:instructor)
@assignment = create(:assignment, name: "Test Assignment", directory_path: 'test_assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id
assignment_team = create(:assignment_team)
create(:team_user)
team_id = AssignmentTeam.first.id.to_s
create(:topic)
create(:topic, topic_name: "TestReview")
create(:assignment_questionnaire)
create(:question)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
#create(:review)
#review_id = Review.first.id.to_s
#create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
login_as 'instructor6'
#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
login_as 'instructor6'
visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
end
end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-28T23:44:46Z

Wfu4: /* Solution */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student-end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor-end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/team_review_statistics.html.erb for reviewers and scores. The other one is grades/tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/team_review_statistics and grades/tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistic view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
</pre>
'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if rscore and rscore[:assessments].length > 0 %>
<%flag_varying_rubrics=false%>

@@ -25,6 +29,9 @@
<%if flag_varying_rubrics==false%>
<%= render :partial => 'grades/review_table', :locals => { :ctrl => 'review', :caction => 'view_review', :symbol => "review".to_sym, :prefix => prefix, :assignment => participant.assignment, :reviews => rscore[:assessments], :collabel => "Review", :rowlabel => "Reviewer" }%>
<%end%>
</td>
</tr>
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>

===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
......
@participant = @map.reviewer
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@@ -264,7 +273,9 @@ def set_content(new_response = false)
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% prefix = nil %>
......
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
<% end %>
</table><hr>
<% end %>
</pre>

''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>"
data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>

</pre>

''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round for instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
elsif prefix # has prefix means view_score page in instructor end
self_id = prefix + '_' + self.id.to_s
code = construct_instructor_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s + '_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<% end %>
<% end %>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
@@ -37,6 +39,7 @@
<% review_feedback = nil %>
<% count = count + 1 %>
<% prefix = nil %>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
@@ -33,8 +35,13 @@
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
<% if controller.action_name != "view2"%>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% end %>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
<tr><td>
<% review_feedback = nil %>
<% count = count + 1 %>
@@ -72,7 +79,9 @@
</td></tr>
<% end %>
<% end %>
<% if controller.action_name != "view2"%>
</table><hr>
<% end %>
<% end %>
<% else %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before (:each) do
create(:instructor)
create(:assignment, course: nil, name: 'Test Assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

assignment_team = create(:assignment_team)

create(:team_user)
login_as 'instructor6'
visit "/grades/view?id=#{assignment_id}"

end

it "shows summary report" do
expect(page).to have_content "Summary report for Test Assignment"
expect(page).to have_content "Show all teams"
page.first(:xpath, "//a[contains(@href,'#')]").click

end

end

describe "test for instructor" do
before (:each) do
create(:instructor)
@assignment = create(:assignment, name: "Test Assignment", directory_path: 'test_assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id
assignment_team = create(:assignment_team)
create(:team_user)
team_id = AssignmentTeam.first.id.to_s
create(:topic)
create(:topic, topic_name: "TestReview")
create(:assignment_questionnaire)
create(:question)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
#create(:review)
#review_id = Review.first.id.to_s
#create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
login_as 'instructor6'
#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
login_as 'instructor6'
visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
end
end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-28T23:41:29Z

Wfu4: /* Student End */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student-end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor-end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/_team_review_statistics.html.erb for reviewers and scores. The other one is grades/_tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/_team_review_statistics and grades/_tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, render grades/team_review_statistics and grades/tabbed_reviews two partial files instead of grades/reviews partial file.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% rounds.each do |round| %>
<h3>Round <%= round %></h3>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s +
'_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<tr><td>
<% review_feedback = nil %>
<%= display_directory_tree(@participant, files, true).html_safe %>
<% end %>
<% end %>
<%= review.display_as_html(prefix, index + 1, nil, true) %>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</table><hr>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistic view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
</pre>
'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if rscore and rscore[:assessments].length > 0 %>
<%flag_varying_rubrics=false%>

@@ -25,6 +29,9 @@
<%if flag_varying_rubrics==false%>
<%= render :partial => 'grades/review_table', :locals => { :ctrl => 'review', :caction => 'view_review', :symbol => "review".to_sym, :prefix => prefix, :assignment => participant.assignment, :reviews => rscore[:assessments], :collabel => "Review", :rowlabel => "Reviewer" }%>
<%end%>
</td>
</tr>
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>

===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
......
@participant = @map.reviewer
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@@ -264,7 +273,9 @@ def set_content(new_response = false)
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% prefix = nil %>
......
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
<% end %>
</table><hr>
<% end %>
</pre>

''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>"
data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>

</pre>

''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round for instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
elsif prefix # has prefix means view_score page in instructor end
self_id = prefix + '_' + self.id.to_s
code = construct_instructor_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s + '_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<% end %>
<% end %>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
@@ -37,6 +39,7 @@
<% review_feedback = nil %>
<% count = count + 1 %>
<% prefix = nil %>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
@@ -33,8 +35,13 @@
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
<% if controller.action_name != "view2"%>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% end %>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
<tr><td>
<% review_feedback = nil %>
<% count = count + 1 %>
@@ -72,7 +79,9 @@
</td></tr>
<% end %>
<% end %>
<% if controller.action_name != "view2"%>
</table><hr>
<% end %>
<% end %>
<% else %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before (:each) do
create(:instructor)
create(:assignment, course: nil, name: 'Test Assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

assignment_team = create(:assignment_team)

create(:team_user)
login_as 'instructor6'
visit "/grades/view?id=#{assignment_id}"

end

it "shows summary report" do
expect(page).to have_content "Summary report for Test Assignment"
expect(page).to have_content "Show all teams"
page.first(:xpath, "//a[contains(@href,'#')]").click

end

end

describe "test for instructor" do
before (:each) do
create(:instructor)
@assignment = create(:assignment, name: "Test Assignment", directory_path: 'test_assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id
assignment_team = create(:assignment_team)
create(:team_user)
team_id = AssignmentTeam.first.id.to_s
create(:topic)
create(:topic, topic_name: "TestReview")
create(:assignment_questionnaire)
create(:question)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
#create(:review)
#review_id = Review.first.id.to_s
#create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
login_as 'instructor6'
#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
login_as 'instructor6'
visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
end
end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-28T23:36:10Z

Wfu4: /* Solution */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student-end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor-end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
For student end, split reviews.html.erb into two partial files. One is grades/_team_review_statistics.html.erb for reviewers and scores. The other one is grades/_tabbed_reviews.html.erb for review details.
For instructor end, it used to use response model methods to construct html files for review details, now we use grades/tabbed_reviews.html.erb to display review details.
So student end and instructor end both use grades/_team_review_statistics and grades/_tabbed_reviews to display reviewers, scores and review details.
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, add render partial to tabbed reviews.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10"><%= render :partial=>'grades/reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %></TD>
<TD COLSPAN="10"><%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %></TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% rounds.each do |round| %>
<h3>Round <%= round %></h3>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s +
'_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<tr><td>
<% review_feedback = nil %>
<%= display_directory_tree(@participant, files, true).html_safe %>
<% end %>
<% end %>
<%= review.display_as_html(prefix, index + 1, nil, true) %>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</table><hr>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistic view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
</pre>
'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if rscore and rscore[:assessments].length > 0 %>
<%flag_varying_rubrics=false%>

@@ -25,6 +29,9 @@
<%if flag_varying_rubrics==false%>
<%= render :partial => 'grades/review_table', :locals => { :ctrl => 'review', :caction => 'view_review', :symbol => "review".to_sym, :prefix => prefix, :assignment => participant.assignment, :reviews => rscore[:assessments], :collabel => "Review", :rowlabel => "Reviewer" }%>
<%end%>
</td>
</tr>
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
......
@participant = @map.reviewer
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@@ -264,7 +273,9 @@ def set_content(new_response = false)
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% prefix = nil %>
......
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
<% end %>
</table><hr>
<% end %>
</pre>

''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>"
data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>

</pre>

''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round for instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
elsif prefix # has prefix means view_score page in instructor end
self_id = prefix + '_' + self.id.to_s
code = construct_instructor_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s + '_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<% end %>
<% end %>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
@@ -37,6 +39,7 @@
<% review_feedback = nil %>
<% count = count + 1 %>
<% prefix = nil %>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
@@ -33,8 +35,13 @@
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
<% if controller.action_name != "view2"%>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% end %>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
<tr><td>
<% review_feedback = nil %>
<% count = count + 1 %>
@@ -72,7 +79,9 @@
</td></tr>
<% end %>
<% end %>
<% if controller.action_name != "view2"%>
</table><hr>
<% end %>
<% end %>
<% else %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before (:each) do
create(:instructor)
create(:assignment, course: nil, name: 'Test Assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

assignment_team = create(:assignment_team)

create(:team_user)
login_as 'instructor6'
visit "/grades/view?id=#{assignment_id}"

end

it "shows summary report" do
expect(page).to have_content "Summary report for Test Assignment"
expect(page).to have_content "Show all teams"
page.first(:xpath, "//a[contains(@href,'#')]").click

end

end

describe "test for instructor" do
before (:each) do
create(:instructor)
@assignment = create(:assignment, name: "Test Assignment", directory_path: 'test_assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id
assignment_team = create(:assignment_team)
create(:team_user)
team_id = AssignmentTeam.first.id.to_s
create(:topic)
create(:topic, topic_name: "TestReview")
create(:assignment_questionnaire)
create(:question)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
#create(:review)
#review_id = Review.first.id.to_s
#create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
login_as 'instructor6'
#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
login_as 'instructor6'
visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
end
end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-28T23:28:23Z

Wfu4: /* What to do */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student-end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor-end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end. So we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details for both student-end and instructor-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, add render partial to tabbed reviews.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10"><%= render :partial=>'grades/reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %></TD>
<TD COLSPAN="10"><%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %></TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% rounds.each do |round| %>
<h3>Round <%= round %></h3>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s +
'_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<tr><td>
<% review_feedback = nil %>
<%= display_directory_tree(@participant, files, true).html_safe %>
<% end %>
<% end %>
<%= review.display_as_html(prefix, index + 1, nil, true) %>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</table><hr>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistic view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
</pre>
'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if rscore and rscore[:assessments].length > 0 %>
<%flag_varying_rubrics=false%>

@@ -25,6 +29,9 @@
<%if flag_varying_rubrics==false%>
<%= render :partial => 'grades/review_table', :locals => { :ctrl => 'review', :caction => 'view_review', :symbol => "review".to_sym, :prefix => prefix, :assignment => participant.assignment, :reviews => rscore[:assessments], :collabel => "Review", :rowlabel => "Reviewer" }%>
<%end%>
</td>
</tr>
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
......
@participant = @map.reviewer
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@@ -264,7 +273,9 @@ def set_content(new_response = false)
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% prefix = nil %>
......
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
<% end %>
</table><hr>
<% end %>
</pre>

''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>"
data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>

</pre>

''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round for instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
elsif prefix # has prefix means view_score page in instructor end
self_id = prefix + '_' + self.id.to_s
code = construct_instructor_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s + '_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<% end %>
<% end %>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
@@ -37,6 +39,7 @@
<% review_feedback = nil %>
<% count = count + 1 %>
<% prefix = nil %>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
@@ -33,8 +35,13 @@
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
<% if controller.action_name != "view2"%>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% end %>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
<tr><td>
<% review_feedback = nil %>
<% count = count + 1 %>
@@ -72,7 +79,9 @@
</td></tr>
<% end %>
<% end %>
<% if controller.action_name != "view2"%>
</table><hr>
<% end %>
<% end %>
<% else %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before (:each) do
create(:instructor)
create(:assignment, course: nil, name: 'Test Assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

assignment_team = create(:assignment_team)

create(:team_user)
login_as 'instructor6'
visit "/grades/view?id=#{assignment_id}"

end

it "shows summary report" do
expect(page).to have_content "Summary report for Test Assignment"
expect(page).to have_content "Show all teams"
page.first(:xpath, "//a[contains(@href,'#')]").click

end

end

describe "test for instructor" do
before (:each) do
create(:instructor)
@assignment = create(:assignment, name: "Test Assignment", directory_path: 'test_assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id
assignment_team = create(:assignment_team)
create(:team_user)
team_id = AssignmentTeam.first.id.to_s
create(:topic)
create(:topic, topic_name: "TestReview")
create(:assignment_questionnaire)
create(:question)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
#create(:review)
#review_id = Review.first.id.to_s
#create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
login_as 'instructor6'
#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
login_as 'instructor6'
visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
end
end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-28T23:27:41Z

Wfu4: /* Issue details */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student-end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor-end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, add render partial to tabbed reviews.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10"><%= render :partial=>'grades/reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %></TD>
<TD COLSPAN="10"><%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %></TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% rounds.each do |round| %>
<h3>Round <%= round %></h3>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s +
'_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<tr><td>
<% review_feedback = nil %>
<%= display_directory_tree(@participant, files, true).html_safe %>
<% end %>
<% end %>
<%= review.display_as_html(prefix, index + 1, nil, true) %>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</table><hr>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistic view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
</pre>
'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if rscore and rscore[:assessments].length > 0 %>
<%flag_varying_rubrics=false%>

@@ -25,6 +29,9 @@
<%if flag_varying_rubrics==false%>
<%= render :partial => 'grades/review_table', :locals => { :ctrl => 'review', :caction => 'view_review', :symbol => "review".to_sym, :prefix => prefix, :assignment => participant.assignment, :reviews => rscore[:assessments], :collabel => "Review", :rowlabel => "Reviewer" }%>
<%end%>
</td>
</tr>
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
......
@participant = @map.reviewer
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@@ -264,7 +273,9 @@ def set_content(new_response = false)
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% prefix = nil %>
......
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
<% end %>
</table><hr>
<% end %>
</pre>

''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>"
data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>

</pre>

''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round for instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
elsif prefix # has prefix means view_score page in instructor end
self_id = prefix + '_' + self.id.to_s
code = construct_instructor_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s + '_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<% end %>
<% end %>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
@@ -37,6 +39,7 @@
<% review_feedback = nil %>
<% count = count + 1 %>
<% prefix = nil %>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
@@ -33,8 +35,13 @@
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
<% if controller.action_name != "view2"%>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% end %>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
<tr><td>
<% review_feedback = nil %>
<% count = count + 1 %>
@@ -72,7 +79,9 @@
</td></tr>
<% end %>
<% end %>
<% if controller.action_name != "view2"%>
</table><hr>
<% end %>
<% end %>
<% else %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before (:each) do
create(:instructor)
create(:assignment, course: nil, name: 'Test Assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

assignment_team = create(:assignment_team)

create(:team_user)
login_as 'instructor6'
visit "/grades/view?id=#{assignment_id}"

end

it "shows summary report" do
expect(page).to have_content "Summary report for Test Assignment"
expect(page).to have_content "Show all teams"
page.first(:xpath, "//a[contains(@href,'#')]").click

end

end

describe "test for instructor" do
before (:each) do
create(:instructor)
@assignment = create(:assignment, name: "Test Assignment", directory_path: 'test_assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id
assignment_team = create(:assignment_team)
create(:team_user)
team_id = AssignmentTeam.first.id.to_s
create(:topic)
create(:topic, topic_name: "TestReview")
create(:assignment_questionnaire)
create(:question)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
#create(:review)
#review_id = Review.first.id.to_s
#create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
login_as 'instructor6'
#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
login_as 'instructor6'
visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
end
end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-28T23:26:13Z

Wfu4: /* Issue details */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student-end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor-end, it uses Response model methods to construct html file for review pages. We need to use the same kinds of partials in instructor-end and student-end, so we decide to use grades/_team_statistics.html.erb to display reviewers and scores and to use grades/_tabbed_reviews.html.erb to display review details.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.
Give Feedback link at view_my_score should appear at the bottom of expanded view.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, add render partial to tabbed reviews.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10"><%= render :partial=>'grades/reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %></TD>
<TD COLSPAN="10"><%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %></TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% rounds.each do |round| %>
<h3>Round <%= round %></h3>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s +
'_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<tr><td>
<% review_feedback = nil %>
<%= display_directory_tree(@participant, files, true).html_safe %>
<% end %>
<% end %>
<%= review.display_as_html(prefix, index + 1, nil, true) %>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</table><hr>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistic view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
</pre>
'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if rscore and rscore[:assessments].length > 0 %>
<%flag_varying_rubrics=false%>

@@ -25,6 +29,9 @@
<%if flag_varying_rubrics==false%>
<%= render :partial => 'grades/review_table', :locals => { :ctrl => 'review', :caction => 'view_review', :symbol => "review".to_sym, :prefix => prefix, :assignment => participant.assignment, :reviews => rscore[:assessments], :collabel => "Review", :rowlabel => "Reviewer" }%>
<%end%>
</td>
</tr>
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
......
@participant = @map.reviewer
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@@ -264,7 +273,9 @@ def set_content(new_response = false)
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% prefix = nil %>
......
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
<% end %>
</table><hr>
<% end %>
</pre>

''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>"
data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>

</pre>

''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round for instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
elsif prefix # has prefix means view_score page in instructor end
self_id = prefix + '_' + self.id.to_s
code = construct_instructor_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s + '_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<% end %>
<% end %>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
@@ -37,6 +39,7 @@
<% review_feedback = nil %>
<% count = count + 1 %>
<% prefix = nil %>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
@@ -33,8 +35,13 @@
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
<% if controller.action_name != "view2"%>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% end %>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
<tr><td>
<% review_feedback = nil %>
<% count = count + 1 %>
@@ -72,7 +79,9 @@
</td></tr>
<% end %>
<% end %>
<% if controller.action_name != "view2"%>
</table><hr>
<% end %>
<% end %>
<% else %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before (:each) do
create(:instructor)
create(:assignment, course: nil, name: 'Test Assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

assignment_team = create(:assignment_team)

create(:team_user)
login_as 'instructor6'
visit "/grades/view?id=#{assignment_id}"

end

it "shows summary report" do
expect(page).to have_content "Summary report for Test Assignment"
expect(page).to have_content "Show all teams"
page.first(:xpath, "//a[contains(@href,'#')]").click

end

end

describe "test for instructor" do
before (:each) do
create(:instructor)
@assignment = create(:assignment, name: "Test Assignment", directory_path: 'test_assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id
assignment_team = create(:assignment_team)
create(:team_user)
team_id = AssignmentTeam.first.id.to_s
create(:topic)
create(:topic, topic_name: "TestReview")
create(:assignment_questionnaire)
create(:question)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
#create(:review)
#review_id = Review.first.id.to_s
#create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
login_as 'instructor6'
#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
login_as 'instructor6'
visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
end
end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1966. Tabbed reviews partial file refactor for displaying the alternate view of reviews

2019-10-28T23:12:01Z

Wfu4: /* Issue details */

== '''About Expertiza''' ==

Expertiza is a open source project currently for CSC517 instructor and students forming groups, submit work, review, and view grades. The project is based on Ruby on Rails framework and the code is on Github: https://github.com/expertiza/expertiza. Expertiza serves wiki page, collecting information of all internal information and updates of all versions.

== '''Problem Statement''' ==
===Issue details===

1) On student-end, Expertiza uses grades/_reviews.html.erb partial file to display reviewers, scores and review details; on instructor-end, it uses response controller and model to construct html file for review pages. (the tables and charts are generated by grades/_team_statistics.html.erb (display reviewers and scores) in Statistics tab). We need to use the same kinds of partials in instructor-end and student-end, either _reviews partial or tabbed_reviews partial.

2) Give Feedback link at view_my_score at student-end should not appear at folded view.

===What to do===
1) We need to use the same kinds of partials in instructor-end and student-end.

2) Give Feedback link at view_my_score should appear at the bottom of expanded view.

== '''Solution''' ==
===Deploy Link===
[http://152.46.19.149:8080 Our project is deployed at VCL ]
===Student End===

* In student end, add render partial to tabbed reviews.

'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10"><%= render :partial=>'grades/reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %></TD>
<TD COLSPAN="10"><%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %></TD>
</TR>
</pre>
* Add feed back link in student end view.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% rounds.each do |round| %>
<h3>Round <%= round %></h3>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s +
'_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<tr><td>
<% review_feedback = nil %>
<%= display_directory_tree(@participant, files, true).html_safe %>
<% end %>
<% end %>
<%= review.display_as_html(prefix, index + 1, nil, true) %>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
</table><hr>
</pre>

* Add javascript to tabbed review so it can be hidden or shown by clicking the show/hide reviews.

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<script type="text/javascript">
toggle_tag_prompt = function() {
$('.tag_prompt_container').toggle();
};
$( document ).ready(function() {
$('#tag_prompt_toggler').click(function () {
if ($('#tag_prompt_toggler').text() == "hide tags")
$('#tag_prompt_toggler').text("show tags")
else
$('#tag_prompt_toggler').text("hide tags")
});
});
</script>
</pre>

* Add statistic view to student end by using the team_review_statistics.html.erb file.
'''app/views/grades/_participant.html.erb '''
<pre>
<TR id="<%= prefix %>_reviews" style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/team_review_statistics', :locals => {:prefix => 'user', :participant => participant, :pscore => pscore} %>
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => participant, :rscore => pscore[:review]} %>
</TD>
</TR>
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
</pre>
'''app/views/grades/_team_review_statistics.html.erb'''
<pre>
<% if controller.action_name != "view_my_scores"%>
<tr>
<td colspan="10">
<% end %>

<% if rscore and rscore[:assessments].length > 0 %>
<%flag_varying_rubrics=false%>

@@ -25,6 +29,9 @@
<%if flag_varying_rubrics==false%>
<%= render :partial => 'grades/review_table', :locals => { :ctrl => 'review', :caction => 'view_review', :symbol => "review".to_sym, :prefix => prefix, :assignment => participant.assignment, :reviews => rscore[:assessments], :collabel => "Review", :rowlabel => "Reviewer" }%>
<%end%>
</td>
</tr>
<% end %>

<% if controller.action_name != "view_my_scores"%>
</td>
</tr>
<% end %>
</pre>
===Instructor End===

* Create new method view2 for response_controller

''' app/controllers/response_controller.rb '''
<pre>
def view2
@response = Response.find(params[:id])
@map = @response.map
set_content2
render "response/view"
end
......
......
@participant = @map.reviewer
......
def set_content2(new_response = false)
@contributor = @map.contributor
members = TeamsUser.where(team_id: params[:team])
@user = members.first
@participant = AssignmentParticipant.where(user_id: @user.user_id, parent_id: params[:assignment]).first
@@ -264,7 +273,9 @@ def set_content(new_response = false)
@questions = retrieve_questions questionnaires, @assignment.id
# @pscore has the newest versions of response for each response map, and only one for each response map (unless it is vary rubric by round)
@pscore = @participant.scores(@questions)
@reviewer = @map.reviewer
@round = params[:round]
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb '''
<pre>
<% prefix = nil %>
......
<% if controller.action_name == "view_my_scores"%>

<% map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: participant.id).first
review_feedbacks = map.try :response %>
<% if review_feedbacks && !review_feedbacks.empty? %>
<%= link_to "View", :controller => 'response', :action => 'view', :id => review_feedbacks.first.id %> or
<%= link_to "Edit", :controller => 'response', :action => 'edit', :id => review_feedbacks.first.id, :return => "feedback" %> feedback for Review <%= count %>
<% else %>
<%= link_to "Give feedback", :controller => 'response', :action => 'new_feedback', :id => review.id %> for Review <%= count %>
<% end %>
</td></tr>
<% end %>
<% end %>
</table><hr>
<% end %>
</pre>

''' app/views/grades/_view_heatgrid.html.erb '''
<pre>
<th class="sorter-false"> <a target="_blank" href="../response/view2?id=<%= review.id.to_s %>&&team=<%= @team.id %>&&round=<%= vm.round.to_s %>&&assignment=<%= @assignment.id %>"
data-toggle="tooltip" data-placement="right" title="Click to see details"><%= user_name.to_s %></a> </th>

</pre>

''' app/views/response/view.html.erb '''
<pre>
<% if controller.action_name != "view2" %>
<% file_url = nil %>
<%= @response.display_as_html(nil, nil, file_url) %>
<br/>
<% else %>
<TR style="display:none; background-color: white;">
<TD COLSPAN="10">
<%= render :partial=>'grades/tabbed_reviews', :locals => {:prefix => 'user', :participant => @participant, :rscore => @pscore[:review], :reviewer => @reviewer, :round => @round} %>
</TD>
</TR>
<% end %>
</pre>

* show right round for instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% next if round.to_s != @round.to_s %>
</pre>

* Create construct_instructor2_html in order to not show review number
''' app/models/response.rb '''
<pre>
if prefix == "instructor"
self_id = self.id.to_s
code = construct_instructor2_html identifier, self_id, count
elsif prefix # has prefix means view_score page in instructor end
self_id = prefix + '_' + self.id.to_s
code = construct_instructor_html identifier, self_id, count
......
def construct_instructor2_html identifier, self_id, count
identifier += '<table width="100%">'\
'<tr>'\
'<td align="left" width="70%"><b>Review ' + '</b>   '\
'<a href="#" name= "review_' + self_id + 'Link" onClick="toggleElement(' + "'review_" + self_id + "','review'" + ');return false;">hide review</a>'\
'</td>'\
'<td align="left"><b>Last Reviewed:</b>'\
"<span>#{(self.updated_at.nil? ? 'Not available' : self.updated_at.strftime('%A %B %d %Y, %I:%M%p'))}</span></td>"\
'</tr></table>'
end
</pre>

'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
<a href="#" name= <%= participant.id.to_s + '_' + round.to_s + "Link" %> onClick="toggleElement('<%= participant.id.to_s + '_' + round.to_s %>','round <%= round.to_s%> reviews');return false;">show round <%= round.to_s%> reviews</a>
<% end %>
<% end %>
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
@@ -37,6 +39,7 @@
<% review_feedback = nil %>
<% count = count + 1 %>
<% prefix = nil %>
<% prefix = "instructor" if controller.action_name == "view2" %>
</pre>

* Show just one review in instructor-end
'''app/views/grades/_tabbed_reviews.html.erb'''
<pre>
<% rounds.each do |round| %>
<% if controller.action_name == "view2"%>
<% next if round.to_s != @round.to_s %>
<% end %>
<% if controller.action_name != "view2"%>
<h3>Round <%= round %></h3>
<% if controller.action_name != "view_my_scores" %>
@@ -33,8 +35,13 @@
<% if @assignment.is_answer_tagging_allowed %>
<span class="spn_qsttog" id="tag_prompt_toggler" title="Click to display/hide tags" onclick="toggle_tag_prompt()">hide tags</span>
<% end %>
<% if controller.action_name != "view2"%>
<table class="table table-striped" id=<%= participant.id.to_s + '_' + round.to_s %> <%= style="display: none;" if controller.action_name != "view_my_scores"%>>
<% end %>
<% rscore[:assessments].select{|response| response.round == round}.reverse.uniq{|response| response.map_id}.sort_by{|response| response.map_id}.each_with_index do |review, index| %>
<% if controller.action_name == "view2"%>
<% next if review.reviewer != @reviewer || count > 0 %>
<% end %>
<tr><td>
<% review_feedback = nil %>
<% count = count + 1 %>
@@ -72,7 +79,9 @@
</td></tr>
<% end %>
<% end %>
<% if controller.action_name != "view2"%>
</table><hr>
<% end %>
<% end %>
<% else %>
</pre>

=='''Test files'''==

*tabbed_review_spec.rb created and added 3 test cases for alternate view of reviews
'''spec/features/tabbed_review_spec.rb'''
<pre>
require "spec_helper"
require 'rspec'
describe "alternate view of reviews" do
before(:each) do
assignment1 = create(:assignment, name: "111", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
# create(:review_response_map, reviewer_id: User.where(role_id: 2).second.id, reviewee: AssignmentTeam.second)
# sleep(10000)
end

def load_alternate
login_as('student2064')
expect(page).to have_content "User: student2064"
expect(page).to have_content "111"

click_link "111"
expect(page).to have_content "Submit or Review work for 111"
expect(page).to have_content "Alternate View"

click_link "Alternate View"
expect(page).to have_content "Contributor"
end

it "shows the correct alternate view" do
# Load questionnaire with generic setup
load_alternate
expect(page).to have_content "Contributor"
expect(page).to have_content "Stats"
expect(page).to have_content "Submitted work"
expect(page).to have_content "Author Feedback"
expect(page).to have_content "Teammate Review"
expect(page).to have_content "Final Score"
expect(page).to have_content "Range"
expect(page).to have_content "Average"
expect(page).to have_content "student2064"

expect(page).to have_css "a[href='#']", text: 'hide stats'
expect(page).to have_css "a[href='#']", text: 'show submission'
#expect(page).to have_css "a[href='#']", text: 'show reviews'
#page.should have_selector('table tr', text: 'show reviews')
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#expect(page).to have_content "Writeup"
end
#describe "grades/participant", :type => :view do
#it 'exists' do
#find(:xpath, "//tr[contains(.,'show reviews')]/td/a", :text => 'show reviews').click
#end
#end
end

describe "test for instructor" do
before (:each) do
create(:instructor)
create(:assignment, course: nil, name: 'Test Assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id

assignment_team = create(:assignment_team)

create(:team_user)
login_as 'instructor6'
visit "/grades/view?id=#{assignment_id}"

end

it "shows summary report" do
expect(page).to have_content "Summary report for Test Assignment"
expect(page).to have_content "Show all teams"
page.first(:xpath, "//a[contains(@href,'#')]").click

end

end

describe "test for instructor" do
before (:each) do
create(:instructor)
@assignment = create(:assignment, name: "Test Assignment", directory_path: 'test_assignment')
assignment_id = Assignment.where(name: 'Test Assignment')[0].id
assignment_team = create(:assignment_team)
create(:team_user)
team_id = AssignmentTeam.first.id.to_s
create(:topic)
create(:topic, topic_name: "TestReview")
create(:assignment_questionnaire)
create(:question)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
#create(:review)
#review_id = Review.first.id.to_s
#create(:review_response_map, reviewer_id: User.where(role_id: 2).third.id)
login_as 'instructor6'
#visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
login_as 'instructor6'
visit "/response/view2?id=#{review_id}&&team=#{team_id}&&round=1&&assignment=#{assignment_id}"
end
it "can go to review details" do
end
end
</pre>

=='''Team Information'''==
#[https://github.com/aranne/expertiza Forked Issue on Github]
#Weiran Fu (@ncsu.edu)
#Qingyan Wang (qwang20@ncsu.edu)
#Hongli Wang (hwang85@ncsu.edu)
#'''Mentor:''' Mohit Jain (mjain6@ncsu.edu)

=='''References'''==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]
#[https://github.com/WintersLt/expertiza GitHub Project Repository Fork]
#[http://bit.ly/myexpertiza Demo link]
#[https://relishapp.com/rspec Rspec Documentation]