Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T19:01:00Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

==='''Code Changes===
In the assignments_controller.rb controller, under the function create, we created a condition or blocking it from saving and then updating all the tabs with the assignment id it needs.

if params[:button]
if @assignment_form.save
@assignment_form.create_assignment_node
existAssignment = Assignment.find_by_name(@assignment_form.assignment.name)
assignment_form_params[:assignment][:id] = existAssignment.id.to_s
quesparams = assignment_form_params
questArray = quesparams[:assignment_questionnaire]
dueArray = quesparams[:due_date]
questArray.each do |curquestionnaire|
curquestionnaire[:assignment_id] = existAssignment.id.to_s
end
dueArray.each do |curDue|
curDue[:parent_id] = existAssignment.id.to_s
end
quesparams[:assignment_questionnaire] = questArray
quesparams[:due_date] = dueArray
@assignment_form.update(quesparams,current_user)
aid = Assignment.find_by_name(@assignment_form.assignment.name).id
redirect_to edit_assignment_path aid
return
undo_link("Assignment \"#{@assignment_form.assignment.name}\" has been created successfully. ")
else
flash.now[:error] = "Failed to create assignment"
render 'new'
end
end

In the general.html.erb for ajax view if there is an error or if the saved changes are updated then it shows a flash message.

$("#flash").html('<%= j render partial: "shared/notice_banner" %>');
<div id="flash">
<% if notice.present? %>
<%= render partial: "shared/notice_banner" %>
<% end %>
</div>

In the edit.html.erb following code changes were made. Setting the remote to true ensures that the following is an ajax request and not and html request.

<%= form_for @assignment_form.assignment, html: { id: 'assignment_form', :remote=>true } do %>
<%= render "layouts/flash_notices" %>

The following code was added in the assignment.rb for validation of our page. The below implementation ensures that there are no special characters in the submission directory field, course_id is unique and name is always present.

validates :name, presence: true
validates :name, uniqueness: {scope: :course_id}
validate :valid_num_review
validates :directory_path, format: {with: /\A[a-zA-Z0-9]+\Z/ , message: "Please follow the guidelines" }, presence:true

In general.html.erb for ajax view, the following code is rendered for displaying the flash messages.

$("#flash").html('<%= j render partial: "shared/notice_banner" %>');

<div id="flash">
<% if notice.present? %>
<%= render partial: "shared/notice_banner" %>
<% end %>
</div>

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Tooltips Functionality==

The Tooltips functionalities are throughly checked in various browsers and the following screenshots show that they are supported across various browsers.
The images show in Firefox and Internet Explorer browsers.
[[Image:Check11.jpg]]
[[Image:Check13.jpg]]

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T09:12:46Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

==='''Code Changes===
In the assignments_controller.rb controller, under the function create, we created a condition or blocking it from saving and then updating all the tabs with the assignment id it needs.

if params[:button]
if @assignment_form.save
@assignment_form.create_assignment_node
existAssignment = Assignment.find_by_name(@assignment_form.assignment.name)
assignment_form_params[:assignment][:id] = existAssignment.id.to_s
quesparams = assignment_form_params
questArray = quesparams[:assignment_questionnaire]
dueArray = quesparams[:due_date]
questArray.each do |curquestionnaire|
curquestionnaire[:assignment_id] = existAssignment.id.to_s
end
dueArray.each do |curDue|
curDue[:parent_id] = existAssignment.id.to_s
end
quesparams[:assignment_questionnaire] = questArray
quesparams[:due_date] = dueArray
@assignment_form.update(quesparams,current_user)
aid = Assignment.find_by_name(@assignment_form.assignment.name).id
redirect_to edit_assignment_path aid
return
undo_link("Assignment \"#{@assignment_form.assignment.name}\" has been created successfully. ")
else
flash.now[:error] = "Failed to create assignment"
render 'new'
end
end

In the general.html.erb for ajax view if there is an error or if the saved changes are updated then it shows a flash message.

$("#flash").html('<%= j render partial: "shared/notice_banner" %>');
<div id="flash">
<% if notice.present? %>
<%= render partial: "shared/notice_banner" %>
<% end %>
</div>

In the edit.html.erb following code changes were made. Setting the remote to true ensures that the following is an ajax request and not and html request.

<%= form_for @assignment_form.assignment, html: { id: 'assignment_form', :remote=>true } do %>
<%= render "layouts/flash_notices" %>

The following code was added in the assignment.rb for validation of our page. The below implementation ensures that there are no special characters in the submission directory field, course_id is unique and name is always present.

validates :name, presence: true
validates :name, uniqueness: {scope: :course_id}
validate :valid_num_review
validates :directory_path, format: {with: /\A[a-zA-Z0-9]+\Z/ , message: "Please follow the guidelines" }, presence:true

In general.html.erb for ajax view, the following code is rendered for displaying the flash messages.

$("#flash").html('<%= j render partial: "shared/notice_banner" %>');

<div id="flash">
<% if notice.present? %>
<%= render partial: "shared/notice_banner" %>
<% end %>
</div>

New.html.erb

<h1>Create New <% if params[:private] == "1" %>Private <% else %>Public <% end %>Assignment</h1>

<%= form_for @assignment_form.assignment, html: { id: 'assignment_form'} do %>
<div class= "chart-table" id="tabs">
<ul>
<li><a href="#tabs-1" id="General">General</a></li>
<li><a href="#tabs-2" id="Rubrics">Rubrics</a></li>
<li><a href="#tabs-3" id="ReviewStrategy">Review strategy</a></li>
<li><a href="#tabs-4" id="DueDates">Due dates</a></li>
<%if @assignment_form.assignment.is_calibrated%>
<li><a href="#tabs-5" id="Calibration">Calibration</a></li>
<%end%>
</ul>
<div id="tabs-1">
<%= render 'assignments/edit/general' %>
</div>
<div id="tabs-2">
<%= render 'assignments/edit/rubrics' %>
</div>
<div id="tabs-3">
<%= render 'assignments/edit/review_strategy' %>
</div>
<div id="tabs-4">
<%= render 'assignments/edit/due_dates' %>
</div>
<%if @assignment_form.assignment.is_calibrated%>
<div id="tabs-5">
<%= render 'assignments/edit/calibration' %>
</div>
<%end%>
<%= button_tag "Save", :id => 'submit_btn' %> | <%= render :partial => '/shared_scripts/back' %>
</div>
<script>
var useBookmarkChanged = function () {
jQuery("#questionnaire_table_BookmarkRatingQuestionnaire").remove()
var bookmark_checkbox = jQuery('#assignment_form_assignment_use_bookmark');
if (bookmark_checkbox.is(':checked')) {
addQuestionnaireTableRow(
'BookmarkRatingQuestionnaire',
null,
<%= questionnaire(@assignment_form.assignment, 'BookmarkRatingQuestionnaire',nil).to_json.html_safe %>,
<%= assignment_questionnaire(@assignment_form.assignment, 'BookmarkRatingQuestionnaire',nil).to_json.html_safe %>,
<%= questionnaire_options(@assignment_form.assignment, 'BookmarkRatingQuestionnaire',nil).to_json.html_safe %>
);
}
}
jQuery(document).ready(function () {
jQuery("#submit_btn").click(function(e) {
var max_team_size = jQuery('#assignment_form_assignment_max_team_size').val();
if (max_team_size == '1' && jQuery('#team_assignment').is(':checked')) {
alert("Maxinum number of members per team must be greater than 1!");
e.preventDefault()
}
})
jQuery("#tabs").tabs({
beforeActivate: function (event, ui) {
var deleteTeam = 0;
var frm = jQuery("#assignment_form");
var max_team_size = jQuery('#assignment_form_assignment_max_team_size').val();
if (max_team_size == '1' && jQuery('#team_assignment').is(':checked')) {
deleteTeam = 1;
alert("Maxinum number of members per team must be greater than 1!");
}
if (deleteTeam == 0) {
jQuery.ajax({
url: frm.attr('action'),
method: frm.attr('method'),
data: frm.serialize(),
})
} else {
event.preventDefault();
}
}
});
if (<%= params[:tab]=='tab3'%>) {
$('#ReviewStrategy').click();
}
});

$('#go_to_tabs2').click(function(){
$('#Rubrics').click();
});
</script>
<% end %>

 

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Tooltips Functionality==

The Tooltips functionalities are throughly checked in various browsers and the following screenshots show that they are supported across various browsers.
The images show in Firefox and Internet Explorer browsers.
[[Image:Check11.jpg]]
[[Image:Check13.jpg]]

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T09:11:23Z

Uagrawa:

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T09:06:04Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

==='''Code Changes===
In the assignments_controller.rb controller, under the function create, we created a condition or blocking it from saving and then updating all the tabs with the assignment id it needs.

if params[:button]
if @assignment_form.save
@assignment_form.create_assignment_node
existAssignment = Assignment.find_by_name(@assignment_form.assignment.name)
assignment_form_params[:assignment][:id] = existAssignment.id.to_s
quesparams = assignment_form_params
questArray = quesparams[:assignment_questionnaire]
dueArray = quesparams[:due_date]
questArray.each do |curquestionnaire|
curquestionnaire[:assignment_id] = existAssignment.id.to_s
end
dueArray.each do |curDue|
curDue[:parent_id] = existAssignment.id.to_s
end
quesparams[:assignment_questionnaire] = questArray
quesparams[:due_date] = dueArray
@assignment_form.update(quesparams,current_user)
aid = Assignment.find_by_name(@assignment_form.assignment.name).id
redirect_to edit_assignment_path aid
return
undo_link("Assignment \"#{@assignment_form.assignment.name}\" has been created successfully. ")
else
flash.now[:error] = "Failed to create assignment"
render 'new'
end
end

In the general.html.erb for ajax view if there is an error or if the saved changes are updated then it shows a flash message.

$("#flash").html('<%= j render partial: "shared/notice_banner" %>');
<div id="flash">
<% if notice.present? %>
<%= render partial: "shared/notice_banner" %>
<% end %>
</div>

In the edit.html.erb following code changes were made. Setting the remote to true ensures that the following is an ajax request and not and html request.

<%= form_for @assignment_form.assignment, html: { id: 'assignment_form', :remote=>true } do %>
<%= render "layouts/flash_notices" %>

The following code was added in the assignment.rb for validation of our page. The below implementation ensures that there are no special characters in the submission directory field, course_id is unique and name is always present.

validates :name, presence: true
validates :name, uniqueness: {scope: :course_id}
validate :valid_num_review
validates :directory_path, format: {with: /\A[a-zA-Z0-9]+\Z/ , message: "Please follow the guidelines" }, presence:true

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Tooltips Functionality==

The Tooltips functionalities are throughly checked in various browsers and the following screenshots show that they are supported across various browsers.
The images show in Firefox and Internet Explorer browsers.
[[Image:Check11.jpg]]
[[Image:Check13.jpg]]

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T08:57:26Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

==='''Code Changes===
In the assignments_controller.rb controller, under the function create, we created a condition or blocking it from saving and then updating all the tabs with the assignment id it needs.

if params[:button]
if @assignment_form.save
@assignment_form.create_assignment_node
existAssignment = Assignment.find_by_name(@assignment_form.assignment.name)
assignment_form_params[:assignment][:id] = existAssignment.id.to_s
quesparams = assignment_form_params
questArray = quesparams[:assignment_questionnaire]
dueArray = quesparams[:due_date]
questArray.each do |curquestionnaire|
curquestionnaire[:assignment_id] = existAssignment.id.to_s
end
dueArray.each do |curDue|
curDue[:parent_id] = existAssignment.id.to_s
end
quesparams[:assignment_questionnaire] = questArray
quesparams[:due_date] = dueArray
@assignment_form.update(quesparams,current_user)
aid = Assignment.find_by_name(@assignment_form.assignment.name).id
redirect_to edit_assignment_path aid
return
undo_link("Assignment \"#{@assignment_form.assignment.name}\" has been created successfully. ")
else
flash.now[:error] = "Failed to create assignment"
render 'new'
end
end

In the general.html.erb for ajax view if there is an error or if the saved changes are updated then it shows a flash message.

$("#flash").html('<%= j render partial: "shared/notice_banner" %>');
<div id="flash">
<% if notice.present? %>
<%= render partial: "shared/notice_banner" %>
<% end %>
</div>

The following code was added in the assignment.rb for validation of our page. The below implementation ensures that there are no special characters in the submission directory field, course_id is unique and name is always present.

validates :name, presence: true
validates :name, uniqueness: {scope: :course_id}
validate :valid_num_review
validates :directory_path, format: {with: /\A[a-zA-Z0-9]+\Z/ , message: "Please follow the guidelines" }, presence:true

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Tooltips Functionality==

The Tooltips functionalities are throughly checked in various browsers and the following screenshots show that they are supported across various browsers.
The images show in Firefox and Internet Explorer browsers.
[[Image:Check11.jpg]]
[[Image:Check13.jpg]]

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T08:56:05Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

==='''Code Changes===
In the assignments_controller.rb controller, under the function create, we created a condition or blocking it from saving and then updating all the tabs with the assignment id it needs.

if params[:button]
if @assignment_form.save
@assignment_form.create_assignment_node
existAssignment = Assignment.find_by_name(@assignment_form.assignment.name)
assignment_form_params[:assignment][:id] = existAssignment.id.to_s
quesparams = assignment_form_params
questArray = quesparams[:assignment_questionnaire]
dueArray = quesparams[:due_date]
questArray.each do |curquestionnaire|
curquestionnaire[:assignment_id] = existAssignment.id.to_s
end
dueArray.each do |curDue|
curDue[:parent_id] = existAssignment.id.to_s
end
quesparams[:assignment_questionnaire] = questArray
quesparams[:due_date] = dueArray
@assignment_form.update(quesparams,current_user)
aid = Assignment.find_by_name(@assignment_form.assignment.name).id
redirect_to edit_assignment_path aid
return
undo_link("Assignment \"#{@assignment_form.assignment.name}\" has been created successfully. ")
else
flash.now[:error] = "Failed to create assignment"
render 'new'
end
end

In the general.html.erb for ajax view if there is an error or if the saved changes are updated then it shows a flash message.

$("#flash").html('<%= j render partial: "shared/notice_banner" %>');
<div id="flash">
<% if notice.present? %>
<%= render partial: "shared/notice_banner" %>
<% end %>
</div>

The following code was added in the assignment.rb for validation of our page. The below implementation ensures that there are no special characters in the path, course_id is unique and name is always present.

validates :name, presence: true
validates :name, uniqueness: {scope: :course_id}
validate :valid_num_review
validates :directory_path, format: {with: /\A[a-zA-Z0-9]+\Z/ , message: "Please follow the guidelines" }, presence:true

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Tooltips Functionality==

The Tooltips functionalities are throughly checked in various browsers and the following screenshots show that they are supported across various browsers.
The images show in Firefox and Internet Explorer browsers.
[[Image:Check11.jpg]]
[[Image:Check13.jpg]]

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T08:52:24Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

==='''Code Changes===
In the assignments_controller.rb controller, under the function create, we created a condition or blocking it from saving and then updating all the tabs with the assignment id it needs.

if params[:button]
if @assignment_form.save
@assignment_form.create_assignment_node
existAssignment = Assignment.find_by_name(@assignment_form.assignment.name)
assignment_form_params[:assignment][:id] = existAssignment.id.to_s
quesparams = assignment_form_params
questArray = quesparams[:assignment_questionnaire]
dueArray = quesparams[:due_date]
questArray.each do |curquestionnaire|
curquestionnaire[:assignment_id] = existAssignment.id.to_s
end
dueArray.each do |curDue|
curDue[:parent_id] = existAssignment.id.to_s
end
quesparams[:assignment_questionnaire] = questArray
quesparams[:due_date] = dueArray
@assignment_form.update(quesparams,current_user)
aid = Assignment.find_by_name(@assignment_form.assignment.name).id
redirect_to edit_assignment_path aid
return
undo_link("Assignment \"#{@assignment_form.assignment.name}\" has been created successfully. ")
else
flash.now[:error] = "Failed to create assignment"
render 'new'
end
end

In the general.html.erb for ajax view if there is an error or if the saved changes are updated then it shows a flash message.

$("#flash").html('<%= j render partial: "shared/notice_banner" %>');
<div id="flash">
<% if notice.present? %>
<%= render partial: "shared/notice_banner" %>
<% end %>
</div>

The following code was added in the assignment.rb for validation of our page.

validates :name, presence: true
validates :name, uniqueness: {scope: :course_id}
validate :valid_num_review
validates :directory_path, format: {with: /\A[a-zA-Z0-9]+\Z/ , message: "Please follow the guidelines" }, presence:true

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Tooltips Functionality==

The Tooltips functionalities are throughly checked in various browsers and the following screenshots show that they are supported across various browsers.
The images show in Firefox and Internet Explorer browsers.
[[Image:Check11.jpg]]
[[Image:Check13.jpg]]

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T08:48:28Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

==='''Code Changes===
In the assignments_controller.rb controller, under the function create, we created a condition or blocking it from saving and then updating all the tabs with the assignment id it needs.

if params[:button]
if @assignment_form.save
@assignment_form.create_assignment_node
existAssignment = Assignment.find_by_name(@assignment_form.assignment.name)
assignment_form_params[:assignment][:id] = existAssignment.id.to_s
quesparams = assignment_form_params
questArray = quesparams[:assignment_questionnaire]
dueArray = quesparams[:due_date]
questArray.each do |curquestionnaire|
curquestionnaire[:assignment_id] = existAssignment.id.to_s
end
dueArray.each do |curDue|
curDue[:parent_id] = existAssignment.id.to_s
end
quesparams[:assignment_questionnaire] = questArray
quesparams[:due_date] = dueArray
@assignment_form.update(quesparams,current_user)
aid = Assignment.find_by_name(@assignment_form.assignment.name).id
redirect_to edit_assignment_path aid
return
undo_link("Assignment \"#{@assignment_form.assignment.name}\" has been created successfully. ")
else
flash.now[:error] = "Failed to create assignment"
render 'new'
end
end

In the general.html.erb for ajax view if there is an error or if the saved changes are updated then it shows a flash message.

$("#flash").html('<%= j render partial: "shared/notice_banner" %>');
<div id="flash">
<% if notice.present? %>
<%= render partial: "shared/notice_banner" %>
<% end %>
</div>

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Tooltips Functionality==

The Tooltips functionalities are throughly checked in various browsers and the following screenshots show that they are supported across various browsers.
The images show in Firefox and Internet Explorer browsers.
[[Image:Check11.jpg]]
[[Image:Check13.jpg]]

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T08:47:32Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

==='''Code Changes===
In the assignments_controller.rb controller, under the function create, we created a condition or blocking it from saving and then updating all the tabs with the assignment id it needs.

if params[:button]
if @assignment_form.save
@assignment_form.create_assignment_node
existAssignment = Assignment.find_by_name(@assignment_form.assignment.name)
assignment_form_params[:assignment][:id] = existAssignment.id.to_s
quesparams = assignment_form_params
questArray = quesparams[:assignment_questionnaire]
dueArray = quesparams[:due_date]
questArray.each do |curquestionnaire|
curquestionnaire[:assignment_id] = existAssignment.id.to_s
end
dueArray.each do |curDue|
curDue[:parent_id] = existAssignment.id.to_s
end
quesparams[:assignment_questionnaire] = questArray
quesparams[:due_date] = dueArray
@assignment_form.update(quesparams,current_user)
aid = Assignment.find_by_name(@assignment_form.assignment.name).id
redirect_to edit_assignment_path aid
return
undo_link("Assignment \"#{@assignment_form.assignment.name}\" has been created successfully. ")
else
flash.now[:error] = "Failed to create assignment"
render 'new'
end
end

In the general.html.erb for ajax view if there is an error or if the saved changes are updated then it shows a flash message.

$("#flash").html('<%= j render partial: "shared/notice_banner" %>');

<div id="flash">
<% if notice.present? %>
<%= render partial: "shared/notice_banner" %>
<% end %>
</div>

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Tooltips Functionality==

The Tooltips functionalities are throughly checked in various browsers and the following screenshots show that they are supported across various browsers.
The images show in Firefox and Internet Explorer browsers.
[[Image:Check11.jpg]]
[[Image:Check13.jpg]]

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T07:12:05Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

==='''Code Changes===
In the assignments_controller.rb controller, under the function create, we created a condition or blocking it from saving and then updating all the tabs with the assignment id it needs.

if params[:button]
if @assignment_form.save
@assignment_form.create_assignment_node
existAssignment = Assignment.find_by_name(@assignment_form.assignment.name)
assignment_form_params[:assignment][:id] = existAssignment.id.to_s
quesparams = assignment_form_params
questArray = quesparams[:assignment_questionnaire]
dueArray = quesparams[:due_date]
questArray.each do |curquestionnaire|
curquestionnaire[:assignment_id] = existAssignment.id.to_s
end
dueArray.each do |curDue|
curDue[:parent_id] = existAssignment.id.to_s
end
quesparams[:assignment_questionnaire] = questArray
quesparams[:due_date] = dueArray
@assignment_form.update(quesparams,current_user)
aid = Assignment.find_by_name(@assignment_form.assignment.name).id
redirect_to edit_assignment_path aid
return
undo_link("Assignment \"#{@assignment_form.assignment.name}\" has been created successfully. ")
else
flash.now[:error] = "Failed to create assignment"
render 'new'
end
end

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Tooltips Functionality==

The Tooltips functionalities are throughly checked in various browsers and the following screenshots show that they are supported across various browsers.
The images show in Firefox and Internet Explorer browsers.
[[Image:Check11.jpg]]
[[Image:Check13.jpg]]

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T07:09:01Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

==='''Code Changes===
In the assignments_controller.rb controller, under the function create, we created a condition or blocking it from saving and then updating all the tabs with the assignment id it needs.

if params[:button]
if @assignment_form.save
@assignment_form.create_assignment_node
existAssignment = Assignment.find_by_name(@assignment_form.assignment.name)
assignment_form_params[:assignment][:id] = existAssignment.id.to_s
quesparams = assignment_form_params
questArray = quesparams[:assignment_questionnaire]
dueArray = quesparams[:due_date]
questArray.each do |curquestionnaire|
curquestionnaire[:assignment_id] = existAssignment.id.to_s
end
dueArray.each do |curDue|
curDue[:parent_id] = existAssignment.id.to_s
end
quesparams[:assignment_questionnaire] = questArray
quesparams[:due_date] = dueArray
@assignment_form.update(quesparams,current_user)
aid = Assignment.find_by_name(@assignment_form.assignment.name).id
redirect_to edit_assignment_path aid
return
undo_link("Assignment \"#{@assignment_form.assignment.name}\" has been created successfully. ")
else
flash.now[:error] = "Failed to create assignment"
render 'new'
end
end

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T07:03:56Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

==='''Code Changes===
assignments_controller.rb
def create
@assignment_form = AssignmentForm.new(assignment_form_params)
if params[:button]
if @assignment_form.save
@assignment_form.create_assignment_node
existAssignment = Assignment.find_by_name(@assignment_form.assignment.name)
assignment_form_params[:assignment][:id] = existAssignment.id.to_s
quesparams = assignment_form_params
questArray = quesparams[:assignment_questionnaire]
dueArray = quesparams[:due_date]
questArray.each do |curquestionnaire|
curquestionnaire[:assignment_id] = existAssignment.id.to_s
end
dueArray.each do |curDue|
curDue[:parent_id] = existAssignment.id.to_s
end
quesparams[:assignment_questionnaire] = questArray
quesparams[:due_date] = dueArray
@assignment_form.update(quesparams,current_user)
aid = Assignment.find_by_name(@assignment_form.assignment.name).id
redirect_to edit_assignment_path aid
return
undo_link("Assignment \"#{@assignment_form.assignment.name}\" has been created successfully. ")
else
flash.now[:error] = "Failed to create assignment"
render 'new'
end
end

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T07:00:37Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

==='''Code Changes===

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T06:42:22Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

In the present implementation of the project, under the edit assignment page, even if we change the tab or click a tab a save request is sent in the background and the metrics are being saved. So, in this case when we have to save a view for a assignment page, we cannot actually do that because on every tab or every change of tab it needs an assignment id. But in case of new assignment page, we do not have an assignment id yet and we did not create the assignment.

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-12-13T06:28:25Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

===Introduction===
Expertiza is an open source project based on Ruby on Rails framework. It is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). It is used in select courses at NC State and by professors at several other colleges and universities. It also supports team projects, and the submission of almost any document type, including URLs and wiki pages. Expertiza enables the instructor to create new and customize existing assignments. It also enables the instructor to create a list of topics the students can sign up for as part of a project. Students can form teams in Expertiza to work on various projects and assignments. Expertiza supports submission across various document types, including the URLs and wiki pages.

==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics. Also, when we press the save button while creating or editing an assignment it goes to HTML form request, instead it should be changed to AJAX request so that the page does not need to get refreshed every time user saves the changes. Few other minor issues are validating the user entries and fixing tooltips so that they are supported across all the browsers.( Chrome, Safari, Firefox etc.)

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
 Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
 When an Instructor creates a new assignment, he should be able to see a table to set DueDates, Review Strategy options and Rubrics associated with the assignments. These options are currently available to the instructor while editing an assignment. We will be adding options to be set during creation of new assignment. Fields to add suggested topics will be excluded for new assignment creation.
 Validating the user entries which is submission directory. It states that it is mandatory field and there should be no spaces but does it actually validate.
 Fixes to tooltips so that it is supported across all the browsers
 Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Use Case Diagram:==

[[File:Assignment_use_case.png]]

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

=='''Implementation==
New assignment creation form will render forms to set Due Dates, Review Strategy and Rubrics as a table. Currently application ID is required to edit these options for an application. We will modify application/views and application controller to support adding these options while creation without application ID without breaking existing edit functionality.

In the present implementation the save button is handled by JQuery but only until a point where necessary attribute checks are done. Now, we need to prevent the page from reloading which can be done by mentioning a remote value as true in the form tag for the edit assignment page.

In the improved view of New Assignment instructor will be able to specify details under four tabs as shown in the below screenshots
[[Image:New_View_New_Assignment_General.png]]

In the General tab the instructor is now able to see all the options from the old view.

[[Image:New_View_New_Assignment_Assign_Rubrics.png]]

In the improved view, in addition to supporting the General tab, now there are new tabs like "Rubrics".
This tab allows the instructor to select the various rubrics for the new assignment. This page also allows the setting of different rubrics for each round of the assignment.

[[Image:New_View_New_Assignment_Assign_Review_Strategy.png]]

In the improved view, there will be an additional new tab titled "Review Strategy".
This tab allows the instructor to set the various policies for review of the new assignment. This page also allows assigning manual review strategies.

[[Image:New_View_New_Assignment_Assign_DueDates.png]]

The new view also renders tab a titled "Due Dates" where the instructor can select the deadlines for various rounds of the selected rubrics. This tab also allows the instructor to select the late penalty policy
The instructor can also choose to make a new late policy instead of selecting an existing policy created by the same instructor.

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Files Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb
 assignment_creation_spec.rb
 assignments_controller_spec.rb

=='''Test Plan==
Manual and automated testing to be done for below cases.
 As an Instructor, clicking on Manage->Assignments should display all created assignments with correct directory, creation date, updation date, instructor id, and actions.
 As an Instructor, clicking on Manage->Assignments->actions of an assignment should successfully redirect to action page.
 As an Instructor, clicking on Manage->Assignments->new public assignment,will redirected to "Create New Public Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new private assignment,will redirected to "Create New Private Assignment" Page.
 As an Instructor, clicking on Manage->Assignments->new public/private assignment, "Create New Public/Private Assignment" should render a table with tabs "General", "Rubrics, "Review Strategy", "Due Dates".
 As an Instructor, clicking on "Rubrics" tab from "Create New Public/Private Assignment" page, the tab should display table to select Questionnaire, menu type, display style, weight and notification limit.
 As an Instructor, select review type, author feedback type, and Teammate review option from the drop down from "Rubrics" tab.
 As an Instructor, select Review Strategy from drop down on "Rubrics" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews done by each student on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set minimum number of reviews done for each submission on "Review Strategy" tab from "Create New Public/Private Assignment".
 As an Instructor, Set both calibrated and uncalibrated artifacts on "Review Strategy" tab.
 As an Instructor, select Anonymous Review option on "Review Strategy" tab.
 As an Instructor, select allow self review on "Review Strategy" tab.
 As an Instructor, set due dates on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of submissions allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of reviews allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, set number of teammate review allowed on "Due Date" tab from "Create New Public/Private Assignment".
 As an Instructor, after updating the fields on all tabs and clicking on save should create an assignment form in database.
 As an Instructor, after saving the new assignment, redirect to edit page to update Signup topics.
 As an instructor, save should not reload the page while creating a new assignment.
 Test when instructor creates a empty template for assignment form.
 Test when name of the assignment is not unique.
 Test when late policy is not created for instructor, and instructor tries to create a new assignment.
 All Users should be able to see tooltip of respective actions on all Browsers.
 As an instructor, delete an assignment.
 Form submission validates the attributes of all associated models.

Below are some of the test cases added

it "is able show tab review strategy" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
expect(page).to have_content("Review Strategy")
end

it "is able show tab due deadlines" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Due date').click
expect(page).to have_content("Deadline type")
end

it "set the deadline for an assignment review" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
click_link 'Due date'
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end

it "is able show tab rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "is able show attributes in rubrics" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('Rubrics').click
expect(page).to have_content("rubric varies by round")
end

it "sets attributes for review strategy auto selects" do
login_as("instructor6")
visit '/assignments/new?private=0'
fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
find_link('ReviewStrategy').click
select "Auto-Selected", from: 'assignment_form_assignment_review_assignment_strategy'
fill_in 'assignment_form_assignment_review_topic_threshold', with: 3
fill_in 'assignment_form_assignment_max_reviews_per_submission', with: 10
click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
review_assignment_strategy: 'Auto-Selected',
review_topic_threshold: 3,
max_reviews_per_submission: 10
)
end
end

describe "deadlines", js: true do
before(:each) do
@assignment = create(:assignment, name: 'public assignment for test')
login_as("instructor6")
visit "/assignments/#{@assignment.id}/edit"
click_link 'Due date'
end
# instructor can set deadline for review and taking quiz
it "set the deadline for an assignment review" do
fill_in 'assignment_form_assignment_rounds_of_reviews', with: '1'
fill_in 'datetimepicker_submission_round_1', with: (Time.now.in_time_zone + 1.day).strftime("%Y/%m/%d %H:%M")
fill_in 'datetimepicker_review_round_1', with: (Time.now.in_time_zone + 10.days).strftime("%Y/%m/%d %H:%M")
click_button 'submit_btn'
submission_type_id = DeadlineType.where(name: 'submission')[0].id
review_type_id = DeadlineType.where(name: 'review')[0].id
submission_due_date = DueDate.find(1)
review_due_date = DueDate.find(2)
expect(submission_due_date).to have_attributes(
deadline_type_id: submission_type_id,
type: 'AssignmentDueDate'
)
expect(review_due_date).to have_attributes(
deadline_type_id: review_type_id,
type: 'AssignmentDueDate'
)
end
end

Test cases which were modified

it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
+ allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by_name).with('test assignment').and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end

context 'when assignment_form is saved successfully' do
it 'redirets to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
+ allow(existAssignment).to receive(:id).and_return(1)
+ allow(Assignment).to receive(:find_by_name).with('test assignment').and_return([double('Assignment', id: 1)])
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
- post :create, @params
+ params = {button: 1}
+ post :create, params
expect(response).to render_template(:new)
end
end

File:!Firefox test.png

2017-12-13T05:34:47Z

Uagrawa:

File:Firefox test.png

2017-12-13T05:04:16Z

Uagrawa:

File:Firefox.png

2017-12-13T04:58:51Z

Uagrawa:

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-11-15T03:59:19Z

Uagrawa: /* Approach */

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-11-15T03:51:55Z

Uagrawa:

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-11-08T03:27:31Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

The current new assignment UI is a Rails based From, while the Assignment Edit Form is a multi level JavasScript based form (view/assignment/edit/.*) that consists of multiple inputs and user interactions. When an instructor creates a new assignment, there are only a limited parameters that he can set in the creation page, then (s)he needs to edit the assignment to define the rest of the parameters. This is confusing and needs to be unified. One solution could be ditching the new assignment form (views/assignment/new.html.erb)
==Introduction:==
==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics.

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
Fixes to tooltips so that it is supported across all the browsers
Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
 2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Files to be Modified==
view/assignment/edit/.*
 views/assignment/new.html.erb
 views/assignment/*
 controller/assignment_controller.rb

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-11-08T03:25:46Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

The current new assignment UI is a Rails based From, while the Assignment Edit Form is a multi level JavasScript based form (view/assignment/edit/.*) that consists of multiple inputs and user interactions. When an instructor creates a new assignment, there are only a limited parameters that he can set in the creation page, then (s)he needs to edit the assignment to define the rest of the parameters. This is confusing and needs to be unified. One solution could be ditching the new assignment form (views/assignment/new.html.erb)
==Introduction:==
==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics.

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
Fixes to tooltips so that it is supported across all the browsers
Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture2.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Files to be Modified==
view/assignment/edit/.*
views/assignment/new.html.erb
views/assignment/*
controller/assignment_controller.rb

File:Picture2.png

2017-11-08T03:25:16Z

Uagrawa: uploaded a new version of "File:Picture2.png"

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-11-08T03:23:40Z

Uagrawa:

E1796. Unify Create Assignment and Edit Assignment pages

The current new assignment UI is a Rails based From, while the Assignment Edit Form is a multi level JavasScript based form (view/assignment/edit/.*) that consists of multiple inputs and user interactions. When an instructor creates a new assignment, there are only a limited parameters that he can set in the creation page, then (s)he needs to edit the assignment to define the rest of the parameters. This is confusing and needs to be unified. One solution could be ditching the new assignment form (views/assignment/new.html.erb)
==Introduction:==
==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics.

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
Fixes to tooltips so that it is supported across all the browsers
Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture1.png]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

[[File:Picture1.png]]

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Files to be Modified==
view/assignment/edit/.*
views/assignment/new.html.erb
views/assignment/*
controller/assignment_controller.rb

CSC/ECE 517 Fall 2017/E1796. Unify Create Assignment and Edit Assignment pages

2017-11-08T03:21:24Z

Uagrawa:

[[File:[[File:Example.jpg]]<nowiki>Insert non-formatted text here</nowiki>]]E1796. Unify Create Assignment and Edit Assignment pages

The current new assignment UI is a Rails based From, while the Assignment Edit Form is a multi level JavasScript based form (view/assignment/edit/.*) that consists of multiple inputs and user interactions. When an instructor creates a new assignment, there are only a limited parameters that he can set in the creation page, then (s)he needs to edit the assignment to define the rest of the parameters. This is confusing and needs to be unified. One solution could be ditching the new assignment form (views/assignment/new.html.erb)
==Introduction:==
==Problem Statement:==
In the Expertiza portal presently when an instructor wants to create a new assignment then as he selects a new assignment option only a few metrics are asked for while for mentioning the other metrics the professor needs to edit assignment and then under that he is shown the options to edit all the other metrics.

==Scope of this Project: ==
Specific Improvements to assignment creation by navigating the user for creating a new assignment to edit assignment page(view/assignment/edit_assignment).
Making sure the edit assignment has blank fields in case of new assignment and saved fields in case of editing.
Fixes to tooltips so that it is supported across all the browsers
Change the save button to AJAX request instead of HTML form submission so that the page doesn’t need to get refreshed every time the user save the changes.

==Current Flow:==
This page is displayed in the present system when a professor wants to create a new assignment as we can see there are only very few metrics on this page which are being displayed.

[[File:Picture1|thumb|Caption]]

While under Edit assignment the professor can now mention all the various metrics regarding the assignment on this page.

=='''Design Pattern==
1.MVC – The project is implemented in Ruby on Rails that uses MVC architecture. It separates an application’s data model, user interface, and control logic into three distinct components (model, view and controller, respectively).
2.Dry Principle – We are trying to reuse the existing functionalities in Expertiza, thus avoiding code duplication. Whenever possible, code modification based on the existing classes, controllers, or tables will be done instead of creating the new one.

=='''Files to be Modified==
view/assignment/edit/.*
views/assignment/new.html.erb
views/assignment/*
controller/assignment_controller.rb

File:Picture1.png

2017-11-08T03:13:01Z

Uagrawa: uploaded a new version of "File:Picture1.png"

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-29T22:47:27Z

Uagrawa: /* Drawbacks and solutions */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

__TOC__

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
If a student is a participant of an assignment and has not submitted the assignment before the assignment due date/deadline, then the assignment is considered as a past due/overdue assignment for that student. These past due assignments are not present in the task list and we have added this functionality to the existing system.

*Highlighting next due dates.
Different To do tasks in the task list with different due dates are highlighted with different shades of red color. An assignment that has to be submitted earlier has a redder color than assignments that have later due dates.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Results===

The task list before and after the changes are shown below.

====Before Changes====

[[File:Before changes.png]]

====After Changes====

[[File:After changes.png]]

The student in the example above is a participant in 6 current assignments that are displayed in the task not yet started section of the task list. Each of those is highlighted with colours as described.

The student has failed to submit 6 other assignments before their respective due dates and they appear in the past-due assignments section of the task list.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password). The testing has to be done manually.

'''Following are a few test cases with respect to our code changes that can be tried from UI:'''

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

5. Assign the student being tested as a participant to the created assignment.

6. Login as the student and check the task list after the due date for the assignment has passed.

7. The new assignment will be in the Past Due assignment section.

'''To check if the Tasks not yet started section has assignments highlighted with colours: '''

1. Login as a student and check if there are any assignments in tasks not started section.

2. If no assignments are present, the student is not involved with any current assignments.

3. Log in as an instructor and add the student as a participant to few assignments.

4. Log in as the student and now see that the assignments in tasks not yet started section are highlighted with colours as described in the wiki.

'''Edge Cases'''

The edge case for when there are no past due assignments for a student has been handled. In this case, no past due assignments are displayed.

The edge case for when there is only one assignment in the tasks not yet started section has been handled. In this case, the assignment is highlighted with a dark red colour.

===References===

#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://rubyonrails.org/ The Ruby on Rails website]

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-29T22:46:28Z

Uagrawa: /* Testing from UI */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

__TOC__

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
If a student is a participant of an assignment and has not submitted the assignment before the assignment due date/deadline, then the assignment is considered as a past due/overdue assignment for that student. These past due assignments are not present in the task list and we have added this functionality to the existing system.

*Highlighting next due dates.
Different To do tasks in the task list with different due dates are highlighted with different shades of red color. An assignment that has to be submitted earlier has a redder color than assignments that have later due dates.

====Drawbacks and solutions====

* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Results===

The task list before and after the changes are shown below.

====Before Changes====

[[File:Before changes.png]]

====After Changes====

[[File:After changes.png]]

The student in the example above is a participant in 6 current assignments that are displayed in the task not yet started section of the task list. Each of those is highlighted with colours as described.

The student has failed to submit 6 other assignments before their respective due dates and they appear in the past-due assignments section of the task list.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password). The testing has to be done manually.

'''Following are a few test cases with respect to our code changes that can be tried from UI:'''

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

5. Assign the student being tested as a participant to the created assignment.

6. Login as the student and check the task list after the due date for the assignment has passed.

7. The new assignment will be in the Past Due assignment section.

'''To check if the Tasks not yet started section has assignments highlighted with colours: '''

1. Login as a student and check if there are any assignments in tasks not started section.

2. If no assignments are present, the student is not involved with any current assignments.

3. Log in as an instructor and add the student as a participant to few assignments.

4. Log in as the student and now see that the assignments in tasks not yet started section are highlighted with colours as described in the wiki.

'''Edge Cases'''

The edge case for when there are no past due assignments for a student has been handled. In this case, no past due assignments are displayed.

The edge case for when there is only one assignment in the tasks not yet started section has been handled. In this case, the assignment is highlighted with a dark red colour.

===References===

#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://rubyonrails.org/ The Ruby on Rails website]

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-29T22:42:39Z

Uagrawa: /* Testing from UI */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

__TOC__

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
If a student is a participant of an assignment and has not submitted the assignment before the assignment due date/deadline, then the assignment is considered as a past due/overdue assignment for that student. These past due assignments are not present in the task list and we have added this functionality to the existing system.

*Highlighting next due dates.
Different To do tasks in the task list with different due dates are highlighted with different shades of red color. An assignment that has to be submitted earlier has a redder color than assignments that have later due dates.

====Drawbacks and solutions====

* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Results===

The task list before and after the changes are shown below.

====Before Changes====

[[File:Before changes.png]]

====After Changes====

[[File:After changes.png]]

The student in the example above is a participant in 6 current assignments that are displayed in the task not yet started section of the task list. Each of those is highlighted with colours as described.

The student has failed to submit 6 other assignments before their respective due dates and they appear in the past-due assignments section of the task list.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

'''Following are a few test cases with respect to our code changes that can be tried from UI:'''

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

5. Assign the student being tested as a participant to the created assignment.

6. Login as the student and check the task list after the due date for the assignment has passed.

7. The new assignment will be in the Past Due assignment section.

'''To check if the Tasks not yet started section has assignments highlighted with colours: '''

1. Login as a student and check if there are any assignments in tasks not started section.

2. If no assignments are present, the student is not involved with any current assignments.

3. Log in as an instructor and add the student as a participant to few assignments.

4. Log in as the student and now see that the assignments in tasks not yet started section are highlighted with colours as described in the wiki.

'''Edge Cases'''

The edge case for when there are no past due assignments for a student has been handled. In this case, no past due assignments are displayed.

The edge case for when there is only one assignment in the tasks not yet started section has been handled. In this case, the assignment is highlighted with a dark red colour.

===References===

#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://rubyonrails.org/ The Ruby on Rails website]

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-29T22:42:13Z

Uagrawa: /* Testing from UI */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

__TOC__

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
If a student is a participant of an assignment and has not submitted the assignment before the assignment due date/deadline, then the assignment is considered as a past due/overdue assignment for that student. These past due assignments are not present in the task list and we have added this functionality to the existing system.

*Highlighting next due dates.
Different To do tasks in the task list with different due dates are highlighted with different shades of red color. An assignment that has to be submitted earlier has a redder color than assignments that have later due dates.

====Drawbacks and solutions====

* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Results===

The task list before and after the changes are shown below.

====Before Changes====

[[File:Before changes.png]]

====After Changes====

[[File:After changes.png]]

The student in the example above is a participant in 6 current assignments that are displayed in the task not yet started section of the task list. Each of those is highlighted with colours as described.

The student has failed to submit 6 other assignments before their respective due dates and they appear in the past-due assignments section of the task list.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

'''Following are a few test cases with respect to our code changes that can be tried from UI:'''

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

5. Assign the student being tested as a participant to the created assignment.

6. Login as the student and check the task list after the due date for the assignment has passed.

7. The new assignment will be in the Past Due assignment section.

'''To check if the Tasks not yet started section has assignments highlighted with colours: '''

1. Login as a student and check if there are any assignments in tasks not started section.

2. If no assignments are present, the student is not involved with any current assignments.

3. Log in as an instructor and add the student as a participant to few assignments.

4. Log in as the student and now see that the assignments in tasks not yet started section are highlighted with colours as described in the wiki.

'''Edge Cases'''

The edge case for when there are no past due assignments for a student has been handled. In this case, no past due assignments are displayed.

The edge case for when there is only one assignment in the tasks not yet started section has been handled. In this case, the assignment is highlighted with a dark red colour.

===References===

#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://rubyonrails.org/ The Ruby on Rails website]

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-29T22:34:42Z

Uagrawa: /* Testing from UI */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

__TOC__

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
If a student is a participant of an assignment and has not submitted the assignment before the assignment due date/deadline, then the assignment is considered as a past due/overdue assignment for that student. These past due assignments are not present in the task list and we have added this functionality to the existing system.

*Highlighting next due dates.
Different To do tasks in the task list with different due dates are highlighted with different shades of red color. An assignment that has to be submitted earlier has a redder color than assignments that have later due dates.

====Drawbacks and solutions====

* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Results===

The task list before and after the changes are shown below.

====Before Changes====

[[File:Before changes.png]]

====After Changes====

[[File:After changes.png]]

The student in the example above is a participant in 6 current assignments that are displayed in the task not yet started section of the task list. Each of those is highlighted with colours as described.

The student has failed to submit 6 other assignments before their respective due dates and they appear in the past-due assignments section of the task list.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

'''Following are a few test cases with respect to our code changes that can be tried from UI:'''

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

5. Assign the student being tested as a participant to the created assignment.

6. Login as the student and check the task list after the due date for the assignment has passed.

7. The new assignment will be in the Past Due assignment section.

'''To check if the Tasks not yet started section has assignments highlighted with colours: '''

1. Login as a student and check if there are any assignments in tasks not started section.

2. If no assignments are present, the student is not involved with any current assignments.

3. Log in as an instructor and add the student as a participant to few assignments.

4. Log in as the student and now see that the assignments in tasks not yet started section are highlighted with colours as described in the wiki.

===References===

#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://rubyonrails.org/ The Ruby on Rails website]

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-29T22:33:36Z

Uagrawa: /* Testing from UI */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

__TOC__

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
If a student is a participant of an assignment and has not submitted the assignment before the assignment due date/deadline, then the assignment is considered as a past due/overdue assignment for that student. These past due assignments are not present in the task list and we have added this functionality to the existing system.

*Highlighting next due dates.
Different To do tasks in the task list with different due dates are highlighted with different shades of red color. An assignment that has to be submitted earlier has a redder color than assignments that have later due dates.

====Drawbacks and solutions====

* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Results===

The task list before and after the changes are shown below.

====Before Changes====

[[File:Before changes.png]]

====After Changes====

[[File:After changes.png]]

The student in the example above is a participant in 6 current assignments that are displayed in the task not yet started section of the task list. Each of those is highlighted with colours as described.

The student has failed to submit 6 other assignments before their respective due dates and they appear in the past-due assignments section of the task list.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

Following are a few test cases with respect to our code changes that can be tried from UI:

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

5. Assign the student being tested as a participant to the created assignment.

6. Login as the student and check the task list after the due date for the assignment has passed.

7. The new assignment will be in the Past Due assignment section.

To check if the Tasks not yet started section has assignments highlighted with colours:

1. Login as a student and check if there are any assignments in tasks not started section.

2. If no assignments are present, the student is not involved with any current assignments.

3. Log in as an instructor and add the student as a participant to few assignments.

4. Log in as the student and now see that the assignments in tasks not yet started section are highlighted with colours as described in the wiki.

===References===

#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://rubyonrails.org/ The Ruby on Rails website]

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-29T22:18:43Z

Uagrawa: /* Results */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

__TOC__

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
If a student is a participant of an assignment and has not submitted the assignment before the assignment due date/deadline, then the assignment is considered as a past due/overdue assignment for that student. These past due assignments are not present in the task list and we have added this functionality to the existing system.

*Highlighting next due dates.
Different To do tasks in the task list with different due dates are highlighted with different shades of red color. An assignment that has to be submitted earlier has a redder color than assignments that have later due dates.

====Drawbacks and solutions====

* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Results===

The task list before and after the changes are shown below.

====Before Changes====

[[File:Before changes.png]]

====After Changes====

[[File:After changes.png]]

The student in the example above is a participant in 6 current assignments that are displayed in the task not yet started section of the task list. Each of those is highlighted with colours as described.

The student has failed to submit 6 other assignments before their respective due dates and they appear in the past-due assignments section of the task list.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

Following are a few test cases with respect to our code changes that can be tried from UI:

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

5. Assign the student being tested as a participant to the created assignment.

6. Logout from Expertiza.

7. Login as the student and check the task list after the due date for the assignment has passed.

8. The new assignment will be in the Past Due assignment section.

===References===

#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://rubyonrails.org/ The Ruby on Rails website]

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-29T22:18:31Z

Uagrawa: /* Results */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

__TOC__

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
If a student is a participant of an assignment and has not submitted the assignment before the assignment due date/deadline, then the assignment is considered as a past due/overdue assignment for that student. These past due assignments are not present in the task list and we have added this functionality to the existing system.

*Highlighting next due dates.
Different To do tasks in the task list with different due dates are highlighted with different shades of red color. An assignment that has to be submitted earlier has a redder color than assignments that have later due dates.

====Drawbacks and solutions====

* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Results===

The task list before and after the changes are shown below

====Before Changes====

[[File:Before changes.png]]

====After Changes====

[[File:After changes.png]]

The student in the example above is a participant in 6 current assignments that are displayed in the task not yet started section of the task list. Each of those is highlighted with colours as described.

The student has failed to submit 6 other assignments before their respective due dates and they appear in the past-due assignments section of the task list.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

Following are a few test cases with respect to our code changes that can be tried from UI:

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

5. Assign the student being tested as a participant to the created assignment.

6. Logout from Expertiza.

7. Login as the student and check the task list after the due date for the assignment has passed.

8. The new assignment will be in the Past Due assignment section.

===References===

#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://rubyonrails.org/ The Ruby on Rails website]

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-29T22:17:50Z

Uagrawa: /* New Implementation */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

__TOC__

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
If a student is a participant of an assignment and has not submitted the assignment before the assignment due date/deadline, then the assignment is considered as a past due/overdue assignment for that student. These past due assignments are not present in the task list and we have added this functionality to the existing system.

*Highlighting next due dates.
Different To do tasks in the task list with different due dates are highlighted with different shades of red color. An assignment that has to be submitted earlier has a redder color than assignments that have later due dates.

====Drawbacks and solutions====

* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Results===

The task list before and after the changes are shown below

====Before Changes====

[[File:Before changes.png]]

====After Changes====

[[File:After changes.png]]

The student in the example above is a participant in 6 current assignments that are displayed in the task not yet started section of the task list. Each of those is highlighted with colours as described.

The student has failed to submit 6 other assignments before their respective due dates and they appear in the past-due assignments section of the task list.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

Following are a few test cases with respect to our code changes that can be tried from UI:

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

5. Assign the student being tested as a participant to the created assignment.

6. Logout from Expertiza.

7. Login as the student and check the task list after the due date for the assignment has passed.

8. The new assignment will be in the Past Due assignment section.

===References===

#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://rubyonrails.org/ The Ruby on Rails website]

File:After changes.png

2017-10-29T22:08:54Z

Uagrawa:

File:Before changes.png

2017-10-29T22:07:57Z

Uagrawa:

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-29T21:33:44Z

Uagrawa: /* Functionality */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

__TOC__

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
If a student is a participant of an assignment and has not submitted the assignment before the assignment due date/deadline, then the assignment is considered as a past due/overdue assignment for that student. These past due assignments are not present in the task list and we have added this functionality to the existing system.

*Highlighting next due dates.
Different To do tasks in the task list with different due dates are highlighted with different shades of red color. An assignment that has to be submitted earlier has a redder color than assignments that have later due dates.

====Drawbacks and solutions====

* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

Following are a few test cases with respect to our code changes that can be tried from UI:

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

5. Assign the student being tested as a participant to the created assignment.

6. Logout from Expertiza.

7. Login as the student and check the task list after the due date for the assignment has passed.

8. The new assignment will be in the Past Due assignment section.

===References===

#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://rubyonrails.org/ The Ruby on Rails website]

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-29T21:30:27Z

Uagrawa: /* Functionality */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

__TOC__

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
If a student is a participant of an assignment and has not submitted the assignment before the assignment due date/deadline, then the assignment is considered as a past due assignment for that student. These past due assignments are not present in the task list and we have added this functionality to the existing system.

*Highlighting next due dates.
Different To do tasks in the task list with different due dates are highlighted with different shades of red color. An assignment that has to be submitted earlier has a redder color than assignments that have later due dates.

====Drawbacks and solutions====

* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

Following are a few test cases with respect to our code changes that can be tried from UI:

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

5. Assign the student being tested as a participant to the created assignment.

6. Logout from Expertiza.

7. Login as the student and check the task list after the due date for the assignment has passed.

8. The new assignment will be in the Past Due assignment section.

===References===

#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://rubyonrails.org/ The Ruby on Rails website]

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-28T01:30:09Z

Uagrawa: /* E1748. Adding past due assignments to the task list */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

__TOC__

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
The assignments which student is a part of but they have not been submitted and are past the deadline are not present in the task list of the user. Currently only those tasks which are not yet started are added in the task list.
*Next due date.
Currently it is difficult to distinguish between the assignments which have the next immediate due date.

====Drawbacks and solutions====

* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

Following are a few test cases with respect to our code changes that can be tried from UI:

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

5. Assign the student being tested as a participant to the created assignment.

6. Logout from Expertiza.

7. Login as the student and check the task list after the due date for the assignment has passed.

8. The new assignment will be in the Past Due assignment section.

===References===

#[http://expertiza.ncsu.edu/ The live Expertiza website]
#[http://rubyonrails.org/ The Ruby on Rails website]

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-28T01:23:55Z

Uagrawa:

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

_TOC_

===About Expertiza===

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

===Problem Statement===

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

===Current Implementation===

====Functionality====

* Past Due assignments are not present in the task list.
The assignments which student is a part of but they have not been submitted and are past the deadline are not present in the task list of the user. Currently only those tasks which are not yet started are added in the task list.
*Next due date.
Currently it is difficult to distinguish between the assignments which have the next immediate due date.

====Drawbacks and solutions====

* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

===New Implementation===
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

Following are a few test cases with respect to our code changes that can be tried from UI:

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

4. Assign the student being tested as a participant to the created assignment.

5. Logout from Expertiza.

6. Login as the student and check the task list after the due date for the assignment has passed.

7. The new assignment will be in the Past Due assignment section.

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-28T01:21:16Z

Uagrawa: /* E1748. Adding past due assignments to the task list */

==E1748. Adding past due assignments to the task list==

This page provides a description of the Expertiza based OSS project for Fall 2017.

_TOC_

'''About Expertiza'''

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

'''Problem Statement'''

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

'''Current Implementation'''

Functionality

* Past Due assignments are not present in the task list.
The assignments which student is a part of but they have not been submitted and are past the deadline are not present in the task list of the user. Currently only those tasks which are not yet started are added in the task list.
*Next due date.
Currently it is difficult to distinguish between the assignments which have the next immediate due date.

'''Drawbacks and solutions'''
* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

'''New Implementation'''
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

Following are a few test cases with respect to our code changes that can be tried from UI:

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

4. Assign the student being tested as a participant to the created assignment.

5. Logout from Expertiza.

6. Login as the student and check the task list after the due date for the assignment has passed.

7. The new assignment will be in the Past Due assignment section.

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-28T01:20:47Z

Uagrawa:

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-28T01:19:26Z

Uagrawa: /* Testing from UI */

'''About Expertiza'''

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

'''Problem Statement'''

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

'''Current Implementation'''

Functionality

* Past Due assignments are not present in the task list.
The assignments which student is a part of but they have not been submitted and are past the deadline are not present in the task list of the user. Currently only those tasks which are not yet started are added in the task list.
*Next due date.
Currently it is difficult to distinguish between the assignments which have the next immediate due date.

'''Drawbacks and solutions'''
* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

'''New Implementation'''
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

Following are a few test cases with respect to our code changes that can be tried from UI:

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a date and time few minutes from the current date and time.

4. Assign the student being tested as a participant to the created assignment.

5. Logout from Expertiza.

6. Login as the student and check the task list after the due date for the assignment has passed.

7. The new assignment will be in the Past Due assignment section.

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-28T01:16:10Z

Uagrawa: /* Testing from UI */

'''About Expertiza'''

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

'''Problem Statement'''

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

'''Current Implementation'''

Functionality

* Past Due assignments are not present in the task list.
The assignments which student is a part of but they have not been submitted and are past the deadline are not present in the task list of the user. Currently only those tasks which are not yet started are added in the task list.
*Next due date.
Currently it is difficult to distinguish between the assignments which have the next immediate due date.

'''Drawbacks and solutions'''
* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

'''New Implementation'''
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Testing from UI===

TODO: Get proper steps with username and password. (Example Logins (username/password) : student5000/password and instructor6/password)

Following are a few test cases with respect to our code changes that can be tried from UI:

1. Login as student and check if past due assignments section is present on the task list.

2. If no such section is present, the student does not have any past due assignments.

3. Log in as an instructor and create a new assignment.

4. Set the deadline for the assignment to a past date.

4. Assign the student being tested as a participant to the created assignment.

5. Logout from expertiza.

6. Login as the student and check the task list to see the new assignment in the Past Due assignment section.

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-28T01:06:20Z

Uagrawa:

'''About Expertiza'''

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

'''Problem Statement'''

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

'''Current Implementation'''

Functionality

* Past Due assignments are not present in the task list.
The assignments which student is a part of but they have not been submitted and are past the deadline are not present in the task list of the user. Currently only those tasks which are not yet started are added in the task list.
*Next due date.
Currently it is difficult to distinguish between the assignments which have the next immediate due date.

'''Drawbacks and solutions'''
* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

'''New Implementation'''
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.

   <%= @pastdueassignments.size.to_s %>  Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  » <%= student_task.assignment.name + " " + student_task.current_stage %> (<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>

*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Testing from UI===
TODO: Get proper steps with user name and password
Following are a few testcases with respect to our code changes that can be tried from UI:
1. Log in as instructor 1 and create a new rubric.

2. Log in as another instructor. Go to [ Edit] page for the rubric and try to edit the questions.

3. Re log in as a student. Go to [ Edit] page for the rubric and try to edit the questions.

3. Re log in as instructor 1. Go to [ Edit] page for the rubric and try to edit the questions.

4. Re log in as a super administrator / admininstrator. Go to [ Edit] page for the rubric and try to edit the questions.

5. TODO: Add steps for import/export reuse

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-28T01:05:12Z

Uagrawa:

'''About Expertiza'''

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

'''Problem Statement'''

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

'''Current Implementation'''

Functionality

* Past Due assignments are not present in the task list.
The assignments which student is a part of but they have not been submitted and are past the deadline are not present in the task list of the user. Currently only those tasks which are not yet started are added in the task list.
*Next due date.
Currently it is difficult to distinguish between the assignments which have the next immediate due date.

'''Drawbacks and solutions'''
* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

'''New Implementation'''
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.
   <%= @pastdueassignments.size.to_s %> Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  »
<%= student_task.assignment.name + " " + student_task.current_stage %>
(<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>
*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
student_task controller.rb
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Testing from UI===
TODO: Get proper steps with user name and password
Following are a few testcases with respect to our code changes that can be tried from UI:
1. Log in as student.

2. Check the task list. There should be extra past due assignment section.

3. Re log in as a student. Go to [ Edit] page for the rubric and try to edit the questions.

3. Re log in as instructor 1. Go to [ Edit] page for the rubric and try to edit the questions.

4. Re log in as a super administrator / admininstrator. Go to [ Edit] page for the rubric and try to edit the questions.

5. TODO: Add steps for import/export reuse

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-28T00:58:53Z

Uagrawa:

'''About Expertiza'''

[https://expertiza.ncsu.edu/ Expertiza] is an open source project. It is based on [http://rubyonrails.org/ Ruby on Rails] framework. The expertiza project is supported by National Science Foundation. Expertiza is a web application which allows instructors to create new assignments, list of topics which students can sign up for. It allows students to submit and peer-review learning object like articles, code, web sites etc. Students can also form teams for various assignments and projects. It is used in select courses by professors at NC State and various other universities.

'''Problem Statement'''

The following tasks were required to be completed in this project:
*Issue #80: Add past-due assignments to task list.
*Highlight with specific colors current and next due dates.

'''Current Implementation'''

Functionality

* Past Due assignments are not present in the task list.
The assignments which student is a part of but they have not been submitted and are past the deadline are not present in the task list of the user. Currently only those tasks which are not yet started are added in the task list.
*Next due date.
Currently it is difficult to distinguish between the assignments which have the next immediate due date.

'''Drawbacks and solutions'''
* '''Problem1''': If a student has an assignment which he has not submitted and the deadline has passed it does not show in his task list.

'''New Implementation'''
*The function overdue_tasks? is added in the model student_task.rb file to fetch those tasks with current stage set as finished and which were not started by the student.
def overdue_task?
current_stage == 'Finished' && !started?
end
*In the list.html.erb file we used the tasks not started section as a template to construct the past due assignments section.
   <%= @pastdueassignments.size.to_s %> Past Due Assignments 
<% @pastdueassignments.each do |student_task|
participant = student_task.participant
stage = student_task.current_stage
topic_id = SignedUpTeam.topic_id(participant.parent_id, participant.user_id)
duedate = participant.assignment.stage_deadline(topic_id)
%>
  »
<%= student_task.assignment.name + " " + student_task.current_stage %>
(<%= student_task.relative_deadline %> Past Deadline )
 
<% end %>
*The past due assignments variable from the controller contains the list of past due assignments as its contents which are looped through with a do each loop. The participant, stage and topic_id are used to obtain the due date of the assignment. Then the assignment name and its deadline are displayed.
student_task controller.rb
@pastdueassignments = @student_tasks.select(&:overdue_tasks?)
* To highlight with specific colors current and next due dates we made several changes to the currently existing list.html.erb file.
<% r=255 %>
<% if @tasknotstarted.size > 0 %>
<% step = (255/ @tasknotstarted.size).floor %>
<%end %>
<%= link_to student_task.assignment.name + " " + student_task.current_stage, {:controller => controller, :action => action, :id => participant.id},
{:style=> "color: rgb(" + r.to_s + ",0,0);" } %>
(<%= student_task.relative_deadline %> left)
<% r= r-step %>
The rgb() style color attribute is used to set the color of a html tag. A variable r is used to set the red color parameter in rgb function. Initially it is set to 255 which is the Darkest shade of red that is possible. Then a variable step is used to determine by what value the r variable must decrease to lessen the intensity of the red color. The size of the task list is used to initialize the step value. An if condition is used to make sure that step is initialized only when there are tasks to be completed.

===Testing from UI===
TODO: Get proper steps with user name and password
Following are a few testcases with respect to our code changes that can be tried from UI:
1. Log in as instructor 1 and create a new rubric.

2. Log in as another instructor. Go to [ Edit] page for the rubric and try to edit the questions.

3. Re log in as a student. Go to [ Edit] page for the rubric and try to edit the questions.

3. Re log in as instructor 1. Go to [ Edit] page for the rubric and try to edit the questions.

4. Re log in as a super administrator / admininstrator. Go to [ Edit] page for the rubric and try to edit the questions.

5. TODO: Add steps for import/export reuse

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-28T00:50:54Z

Uagrawa:

CSC/ECE 517 Fall 2017/E1748 Add past-due assignments to task list

2017-10-28T00:48:02Z

Uagrawa: