Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments

2020-11-17T23:28:51Z

Tyeh3:

== Project Overview ==
=== Background ===
The Expertiza project takes advantage of peer review among students to allow them to learn from each other. Tracking the time that a student spends on each submitted resource is meaningful for instructors to study and improve the teaching experience, and also in evaluating the quality/sincerity of the reviews.

'''Previous work done in Fall 2019 enables tracking time between successive time tag assignment.''' 
[[File:Tagging1993.png|1000px]]

However, there are several problems with their solution:
* There is no automated tests using mocked data to test their implementation.
* The previous team added a tagging interval chart to each row (representing each participant) in the Answer Tagging report. However, the chart will be hard to read if there hundreds of tagging interval.

=== Objective ===
* Display the tagging interval information as a number alongside the graph in order to make it more intuitive to read
* Add test cases regarding new changes

'''Example Mockup of Added Column''' 
[[File:ECE517Project4 Mockup.png]]

=== Other possible changes to be made ===
* Refactor code from the previous implementation
* Display intervals using a different type of graph (bar graph, line graph, etc)
'''For loops that could be implemented into a separate method''' 
[[File:ECE517Project4 ForLoops.png]]

=== File Involved ===
* helpers/report_formatter_helper.rb
* helpers/review_mapping_helper.rb
* models/tag_prompt_deployment.rb
* models/vm_user_answer_tagging.rb
* views/reports/_answer_tagging_report.html.erb

=== Previous Work ===
The following links are the deliverables from the original implementation in Fall 2019.
 
* [http://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1993_Track_Time_Between_Successive_Tag_Assignments CSC/ECE 517 Fall 2019 - E1993 Track Time Between Successive Tag Assignments]
* [https://www.youtube.com/watch?v=YxR9sitpZcs&feature=youtu.be&ab_channel=HackOverFlow Youtube Explanation]
* [https://github.com/Galactis/expertiza Git Repository]
* [https://github.com/expertiza/expertiza/pull/1642 Git Pull Request]

=== Team ===
Joshua Aaron Horwitz (jahorwit)
 
Varun Varadarajan (vvarada2)
 
Nicholas Viado (ndviado)
 
Tsu-Hsin Yeh (tyeh3)
 
'''Mentor:''' Kai Xiao (yxiao28)

== Design ==

We propose a method that aims to perform:

1. Query the database for details on reviews and their tags

2. Update the existing chart logic to process these numbers

3. Update the report format to include these times

4. Add tests for internal logic and manual UI-testing too

HOW: We'll create an independent method for our logic and append it to the existing logic without necessarily modifying it

== Test Plan ==
To manually reproduce the scenario on the UI and test the results on our new/modified time reports

1. Manually impersonate the process of tagging reviews for a dummy assignment

2. Test that the tag times are recorded and displayed properly

3. Compare it with previous logic to check that values/logic is consistent

4. Regression test just to see that the existing charts aren't broken

=== Manual Testing ===
1. Logged in as Instructor 6 with username = instructor6 and password = password

2. Click "Manage..." -> "Assignments" from the top-left menu item

[[File:E2082_MT1.png|200px]]

3. Create a new assignment by clicking the + button

[[File:E2082_MT2.png|600px]]

4. Filling the necessary information in "General", "Rubrics", and "Due Dates" sections indicated in the following screenshots. Then click Create button.

[[File:E2082_MT3.png|600px]]

[[File:E2082_MT4.png|600px]]

[[File:E2082_MT5.png|600px]]

5. Edit Tagging Assignment and click add new.. under Tag prompt dropdown list

[[File:E2082_MT6.png|600px]]

6. Click the green + on the top-right of the popup window. Enter the value for prompt and desc as shown in the screenshot below. Click green + button at the right most column.

[[File:E2082_MT7.png|600px]]

7. Select Criterion for apply to question type. Click Save button.

[[File:E2082_MT8.png|600px]]

8. Click the Add Participants button, then add student7339 and student7430.

[[File:E2082_MT9.png|600px]]

9. Logged in as student7339 with password=password and make a submission from Your work

[[File:E2082_MT10.png|600px]]

10. Logged in as instructor6 and modify Tagging Assignment due date for Round 1: Submission to be two days before today.

[[File:E2082_MT11.png|400px]]

11. Logged in as student7430 with password=password and submit review from Others' work

[[File:E2082_MT12_5.png|600px]]
[[File:E2082_MT12.png|400px]]

12. Logged in as instructor6 and modify Tagging Assignment due date for Round 1: Review to be one day before today.
[[File:E2082_MT13.png|400px]]

13. Logged in as student7339 and tag the review from <Your scores>

[[File:E2082_MT14.png|600px]]

[[File:E2082_MT15.png|600px]]

14. Logged in as instructor6. Go to manage...->Assignment and click View Reports button.

[[File:E2082_MT16.png|600px]]

15. Select Answer Tagging Report and click View button.

[[File:E2082_MT17.png|600px]]

16. The highlighted column in blue rectangle is the new feature we added

=== Unit Tests ===

Tests were added to test the accuracy of calculating the statistics of the timings we have tracked in this project.
The comprehensive test can test all the math logic involved in our design.

[[File:Test_cases2.png]]

== Other Information ==
=== Pull Request ===
https://github.com/expertiza/expertiza/pull/1848

=== Video URL ===

CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments

2020-11-17T01:45:36Z

Tyeh3: /* Test Plan */

== Project Overview ==
=== Background ===
The Expertiza project takes advantage of peer review among students to allow them to learn from each other. Tracking the time that a student spends on each submitted resource is meaningful for instructors to study and improve the teaching experience, and also in evaluating the quality/sincerity of the reviews.

'''Previous work done in Fall 2019 enables tracking time between successive time tag assignment.''' 
[[File:Tagging1993.png|1000px]]

However, there are several problems with their solution:
* There is no automated tests using mocked data to test their implementation.
* The previous team added a tagging interval chart to each row (representing each participant) in the Answer Tagging report. However, the chart will be hard to read if there hundreds of tagging interval.

=== Objective ===
* Display the tagging interval information as a number alongside the graph in order to make it more intuitive to read
* Add test cases regarding new changes

'''Example Mockup of Added Column''' 
[[File:ECE517Project4 Mockup.png]]

=== Other possible changes to be made ===
* Refactor code from the previous implementation
* Display intervals using a different type of graph (bar graph, line graph, etc)
'''For loops that could be implemented into a separate method''' 
[[File:ECE517Project4 ForLoops.png]]

=== File Involved ===
* helpers/report_formatter_helper.rb
* helpers/review_mapping_helper.rb
* models/tag_prompt_deployment.rb
* models/vm_user_answer_tagging.rb
* views/reports/_answer_tagging_report.html.erb

=== Previous Work ===
The following links are the deliverables from the original implementation in Fall 2019.
 
* [http://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2019_-_E1993_Track_Time_Between_Successive_Tag_Assignments CSC/ECE 517 Fall 2019 - E1993 Track Time Between Successive Tag Assignments]
* [https://www.youtube.com/watch?v=YxR9sitpZcs&feature=youtu.be&ab_channel=HackOverFlow Youtube Explanation]
* [https://github.com/Galactis/expertiza Git Repository]
* [https://github.com/expertiza/expertiza/pull/1642 Git Pull Request]

=== Team ===
Joshua Aaron Horwitz (jahorwit)
 
Varun Varadarajan (vvarada2)
 
Nicholas Viado (ndviado)
 
Tsu-Hsin Yeh (tyeh3)
 
'''Mentor:''' Kai Xiao (yxiao28)

== Design ==

'''[PLAN]''': We propose a method that aims to perform:

1. Query the database for details on reviews and their tags

2. Update the existing chart logic to process these numbers

3. Update the report format to include these times

4. Add tests for internal logic and manual UI-testing too

== Implementation ==

'''[PLAN]''': We propose to create an independent method for our logic and append it to the existing logic without necessarily modifying it (unless the goal is to refactor old code)

'''NOTE: CODE REVIEW WILL BE PASTED HERE AS WE REACH THE FINAL CODE SUBMISSION DEADLINE'''

== Test Plan ==
'''[PLAN]''': To manually reproduce the scenario on the UI and test the results on our new/modified time reports

1. Manually impersonate the process of tagging reviews for a dummy assignment

2. Test that the tag times are recorded and displayed properly

3. Compare it with previous logic to check that values/logic is consistent

4. Regression test just to see that the existing charts aren't broken

'''NOTE: TESTING CODE WILL BE PASTED HERE AS WE REACH THE FINAL CODE SUBMISSION DEADLINE'''

=== Manual Testing ===
1. Logged in as Instructor 6 with username = instructor6 and password = password

2. Click "Manage..." -> "Assignments" from the top-left menu item

[[File:E2082_MT1.png|200px]]

3. Create a new assignment by clicking the + button

[[File:E2082_MT2.png|600px]]

4. Filling the necessary information in "General", "Rubrics", and "Due Dates" sections indicated in the following screenshots. Then click Create button.

[[File:E2082_MT3.png|600px]]

[[File:E2082_MT4.png|600px]]

[[File:E2082_MT5.png|600px]]

5. Edit Tagging Assignment and click add new.. under Tag prompt dropdown list

[[File:E2082_MT6.png|600px]]

6. Click the green + on the top-right of the popup window. Enter the value for prompt and desc as shown in the screenshot below. Click green + button at the right most column.

[[File:E2082_MT7.png|600px]]

7. Select Criterion for apply to question type. Click Save button.

[[File:E2082_MT8.png|600px]]

8. Click the Add Participants button, then add student7339 and student7430.

[[File:E2082_MT9.png|600px]]

9. Logged in as student7339 with password=password and make a submission from Your work

[[File:E2082_MT10.png|600px]]

10. Logged in as instructor6 and modify Tagging Assignment due date for Round 1: Submission to be two days before today.

[[File:E2082_MT11.png|400px]]

11. Logged in as student7430 with password=password and submit review from Others' work

[[File:E2082_MT12_5.png|600px]]
[[File:E2082_MT12.png|400px]]

12. Logged in as instructor6 and modify Tagging Assignment due date for Round 1: Review to be one day before today.
[[File:E2082_MT13.png|400px]]

13. Logged in as student7339 and tag the review from <Your scores>

[[File:E2082_MT14.png|600px]]

[[File:E2082_MT15.png|600px]]

14. Logged in as instructor6. Go to manage...->Assignment and click View Reports button.

[[File:E2082_MT16.png|600px]]

15. Select Answer Tagging Report and click View button.

[[File:E2082_MT17.png|600px]]

16. The highlighted column in blue rectangle is the new feature we added

File:E2082 MT17.png

2020-11-17T01:44:48Z

Tyeh3:

File:E2082 MT16.png

2020-11-17T01:44:41Z

Tyeh3: Tyeh3 uploaded a new version of File:E2082 MT16.png

File:E2082 MT16.png

2020-11-17T01:41:29Z

Tyeh3:

File:E2082 MT15.png

2020-11-17T01:38:40Z

Tyeh3:

File:E2082 MT12 5.png

2020-11-17T01:37:07Z

Tyeh3:

File:E2082 MT14.png

2020-11-17T01:34:37Z

Tyeh3:

File:E2082 MT13.png

2020-11-17T01:31:05Z

Tyeh3:

File:E2082 MT11.png

2020-11-17T01:30:53Z

Tyeh3: Tyeh3 uploaded a new version of File:E2082 MT11.png

File:E2082 MT12.png

2020-11-17T01:27:46Z

Tyeh3:

File:E2082 MT11.png

2020-11-17T01:25:32Z

Tyeh3: Tyeh3 uploaded a new version of File:E2082 MT11.png

File:E2082 MT11.png

2020-11-17T01:24:40Z

Tyeh3:

File:E2082 MT10.png

2020-11-17T01:21:32Z

Tyeh3:

File:E2082 MT9.png

2020-11-17T01:12:38Z

Tyeh3:

File:E2082 MT8.png

2020-11-17T01:09:51Z

Tyeh3: Tyeh3 uploaded a new version of File:E2082 MT8.png

File:E2082 MT8.png

2020-11-17T00:59:30Z

Tyeh3:

File:E2082 MT7.png

2020-11-17T00:55:57Z

Tyeh3: Tyeh3 uploaded a new version of File:E2082 MT7.png

File:E2082 MT7.png

2020-11-17T00:54:54Z

Tyeh3: Tyeh3 uploaded a new version of File:E2082 MT7.png

File:E2082 MT7.png

2020-11-17T00:54:23Z

Tyeh3:

File:E2082 MT6.png

2020-11-17T00:50:26Z

Tyeh3:

File:E2082 MT5.png

2020-11-17T00:44:49Z

Tyeh3: Tyeh3 uploaded a new version of File:E2082 MT5.png

File:E2082 MT5.png

2020-11-17T00:38:45Z

Tyeh3:

File:E2082 MT4.png

2020-11-17T00:38:32Z

Tyeh3:

File:E2082 MT3.png

2020-11-17T00:38:21Z

Tyeh3:

File:E2082 MT2.png

2020-11-17T00:32:25Z

Tyeh3:

File:E2082 MT1.png

2020-11-17T00:27:52Z

Tyeh3:

CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments

2020-10-21T23:07:24Z

Tyeh3: /* Objective */

CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments

2020-10-21T23:06:33Z

Tyeh3: /* File Involved */

CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments

2020-10-21T22:48:58Z

Tyeh3: /* Background */

CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments

2020-10-21T21:35:27Z

Tyeh3: /* Previous Work */

CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments

2020-10-21T21:35:18Z

Tyeh3: /* Background */

CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments

2020-10-21T21:32:38Z

Tyeh3: /* Previous Work */

CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments

2020-10-21T21:25:11Z

Tyeh3: /* Background */

CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments

2020-10-21T21:11:02Z

Tyeh3: Created page with "== Project Overview == === Background === === Objective === === File Involved === === Previous Work === === Team === Joshua Aaron Horwitz (jahorwit) Varun Varadarajan (vv..."

== Project Overview ==
=== Background ===
=== Objective ===
=== File Involved ===
=== Previous Work ===
=== Team ===
Joshua Aaron Horwitz (jahorwit)
 
Varun Varadarajan (vvarada2)
 
Nicholas Viado (ndviado)
 
Tsu-Hsin Yeh (tyeh3)
 
'''Mentor:''' Kai Xiao (yxiao28)
== Design ==
== Implementation ==
== Test Plan ==

CSC/ECE 517 Fall 2020

2020-10-21T20:49:02Z

Tyeh3: /* Final Project Design Documents */

== Writing Assignments ==
* [[CSC/ECE 517 Fall 2020 - E2070. Refactor response_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2068. Refactor quiz_questionnaires_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2062. Add test cases to review_mapping_helper.rb]]
* [[CSC/ECE 517 Fall 2020 - E2063. Refactor tree-display.js and tree_display_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2064. Refactor reputation_web_service_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2065. Fix view in student_task/list page]]
* [[CSC/ECE 517 Fall 2020 - E2066. Refactor lottery controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2067. Refactor student_teams_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2073. Refactor course_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2057. Restrict TAs’ ability to change their own grade and limit file-size upload]]
* [[CSC/ECE 517 Fall 2020 - E2052. Remove multiple topics at a time]]
* [[CSC/ECE 517 Fall 2020 - E2052. Remove multiple topics at a time]]
* [[CSC/ECE 517 Fall 2020 - E2056 Account_Request_Controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2059. Email notification to reviewers and instructors.rb]]
* [[CSC/ECE 517 Fall 2020 - E2058. Two issues related to assignment management]]
* [[CSC/ECE 517 Fall 2020 - E2071. Improve assessment360_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2054. Auto generate submission directory names based on assignment names]]

== Final Project Design Documents ==
* [[CSC/ECE 517 Fall 2020 - E2082. Track time between successive tag assignments]]
* [[CSC/ECE 517 Fall 2020 - E2078. Improve self-review Link peer review & self-review to derive grades]]
* [[CSC/ECE 517 Fall 2020 - E2083. Revision_planning_tool_E2016]]
* [[CSC/ECE 517 Fall 2020 - E2085. Allow reviewers to bid on what to review]]
* [[CSC/ECE 517 Fall 2020 - E2086. Let course staff as well as students do reviews]]
* [[CSC/ECE 517 Fall 2020 - SQLFE. Refactor Submission.java]]

CSC/ECE 517 Fall 2020 - E2067. Refactor student teams controller.rb

2020-10-12T21:03:02Z

Tyeh3: /* Future Work */

==Introduction==
===Background===
The '''student_teams_controller.rb''' controller used in Expertiza to manipulate teams that are created for assignments. Primary functions that this controller provides is create a new team, update team name and delete members from a team.

===Motivation===
The motivation of our work is to improve the maintainability and readability of '''student_teams_controller.rb''' Controller. Furthermore, we also fix several occasions where the '''student_teams_controller.rb''' contains code snippets that actually belongs to the model classes. This will help enforce single responsibility principle and model-view-controller pattern.

===Task Identified===
* Move '''return unless current_user_id? student.user_id''' into '''action_allowed method'''
* Refactor code from '''view function''' into may or may not be necessary to add a method to the '''DueDates class'''
* Remove variable '''current_team'''
* Add comment for '''@users_on_waiting_list''' and also simplify the condition
* Refactor '''@teammate_review_allowed''' into '''due_date.rb'''
* Rename '''existing_assignments?''' to '''existing_teams'''
* Add method comment for the '''update method'''
* Change '''(matching_teams[0].name <=> team.name).zero?''' to '''(matching_teams[0].name == team.name)?'''
* Add method comment for '''Advertise_for_partners''' and '''remove_advertisement'''
* Rename '''sign_up''' into '''signup'''
* Refactor code from '''remove_participant''' into '''waitlist.rb'''
* Add method comment for the '''review method'''

===Affected Classes===
*/controllers/student_teams_controller.rb
*/models/waitlist.rb
*/models/due_date.rb

==Code Review==
The purpose of this section is to provide the before and after change comparison so the developer can perform code review to ensure the correctness of the change.

=== Move '''return unless current_user_id? student.user_id''' into '''action_allowed method''' ===
* Objective
The action_allowed method determines whether an action is permissible, depending on the privileges of the user who is performing it. In the view method, there is a clause that says, return unless current_user_id? student.user_id. This needs to be moved to the when 'view' clause in the action_allowed method.
* Change Comparison
''Student_teams_controller.rb'': 
'''action_allowed method''' 
[[File:Issue1 fix.png|1000px]] 
'''view method''' 
[[File:Issue1 fix2.png|1000px]]
* Change Explanation
Deleted 'return unless current_user_id? student.user_id' in the view method, and added it to a if clause under the when 'view' clause in the action_allowed method. So that every time before view method is called, this sentence in the action_allowed method will run first.

=== Refactor code from '''view function''' into may or may not be necessary to add a method to the '''DueDates class''' ===
* Objective
The code beginning at line 44 deals with due_dates, which are part of the “business logic” and should be moved to an appropriate model method. Thus, @student.assignment.due_dates.each do |due_date| should invoke an appropriate method in due_date.rb. It may or may not be necessary to add a method to the DueDates class.
* Change Comparison
 
''Student_teams_controller.rb'':
[[File:current_due_date_comparison.PNG]]
 
 
''due_date.rb'': 
[[File:due_date_method_added.PNG]]
* Change Explanation
The code in the first image uses logic associated with due dates to assign a variable called '@current_due_date'. This logic was moved to a new method in the model due_dates.rb, shown in the second image. This logic was moved to to simplify the controller but also because the logic is specific to due dates and is more reasonable to be located in the due dates model.

=== Remove variable '''current_team''' ===
* Objective
The variable current_team seems unnecessary; it only saves one character vs. @student.team. Consider removing it.
* Change Comparison
[[File:current_team_change_comparison.PNG]]

* Change Explanation
In the red line 51 above, the variable 'current_team' is used. This variable is unnecessary as it is not significantly shorter or more descriptive. As shown in the changes between red line 53 and green line 49, the 'current_team' variable was removed and replaced with '@student.team'.

=== Add comment for '''@users_on_waiting_list''' and also simplify the condition ===
* Objective
The code on Line 53 (@users_on_waiting_list ...) is not clear at all. Needs at least a comment, and also the condition should not be so complicated.
* Change Comparison
[[File:updated_comment_waiting_list.PNG]]
[[File:added_requirements_method.PNG]]

* Change Explanation
The '@users_on_waiting_list' line of code needed a comment to clarify its function. The original line had a complex conditional that made the code hard to read. This conditional was moved to a new method in which it was refactored and commented to be more understandable and readable.

=== Refactor '''@teammate_review_allowed''' into '''due_date.rb''' ===
* Objective
In line 55, the @teammate_review_allowed: condition is way too complex, uses magic constants, and belongs in code in another model class (maybe due_date.rb); no way should it be in the controller!
* Change Comparison
[[File:Issue5 fix.png|1000px]]
 
''Student_teams_controller.rb'': 
[[File:Issue5 fix2.png|1000px]]

* Change Explanation
Moved '''@teammate_review_allowed''' 's condition to '''due_date.rb''' so the code is more readable.

=== Rename '''existing_assignments?''' to '''existing_teams''' ===
* Objective
Line 59: existing_assignments is evidently a team! So why is the variable name existing_assignments? It should perhaps be changed to existing_teams.
* Change Comparison
[[File:existing_assignments_comparison.PNG]]

* Change Explanation
The variable 'existing_assignments' was actually a team. To better reflect the purpose of the variable and function of the code, the name was changed from 'existing_assignments' to 'existing_teams'.

=== Add method comment for the '''update method''' ===
* Objective
The update method needs comments about what it is doing.
* Change Comparison (commit 7a9e39)
[[File:E2067_Issue7_Fix.png|1000px]]
* Change Explanation
The '''if''' condition checks if the new team name is NOT already exist, if so then update the team name. The '''elsif''' condition checks if the new team name is the same the current one, if so then nothing is changed. The '''else''' covers the case where the new team name is already in use, then print an error message and not changing the team name.
=== Change '''(matching_teams[0].name <=> team.name).zero?''' to '''(matching_teams[0].name == team.name)?''' ===
* Objective
Line 95: Why isn’t (matching_teams[0].name <=> team.name).zero? just (matching_teams[0].name == team.name)?
* Change Comparison (commit d60d92)
[[File:E2067_Issue8_Fix.png|1000px]]
* Change Explanation
This change is straight forward to satisfy the objective of the task.

=== Add method comment for '''Advertise_for_partners''' and '''remove_advertisement''' ===
* Objective
Line 108: advertise_for_partners needs a method comment. Since its body is only 1 line, does it make sense to have a separate method for this? It makes sense only if having a separate method improves readability. Ditto for the remove_advertisement method at line 112.
* Change Comparison
[[File:Issue9 fix.png|1000px]]
* Change Explanation
Both '''advertise_for_partners''' and '''remove_advertisement''' are necessary in terms of readability.

=== Rename '''sign_up''' into '''signup''' ===
* Objective
The name sign_up needs to be signup; it is being used as a noun (sign_up would suggest a verb, the action of signing up).
* Change Comparison (commit e393ba)
[[File:E2067_Issue10_Fix.png|1000px]]
* Change Explanation
I performed a file search on '''sign_up''' and it only appears in the places shown in the screenshot. I replaced them with signup according to the objective.
=== Refactor code from '''remove_participant''' into '''waitlist.rb''' ===
* Objective
remove_participant is generally good code, but handling of waitlists is again model activity, and should be moved to a model class, perhaps waitlist.rb.
* Change Comparison (commit 504f84)
[[File:E2067_Issue11_Fix1.png|1000px]]
[[File:E2067_Issue11_Fix2.png|1000px]]
* Change Explanation
Line 127~142 in '''student_teams_controller.rb''' are moved to Line 14~29 in '''waitlist.rb'''. The only input to the new function '''remove_from_waitlists''' in '''waitlist.rb''' requires '''params[:team_id]''' from '''student_teams_controller.rb'''.
=== Add method comment for the '''review method''' ===
* Objective
Line 169: The review method needs a method comment; its purpose is not clear.
* Change Comparison
[[File:Issue12 fix.png|1000px]]

* Change Explanation
Clarified what review method intends to do.

==Test==
File: spec/controllers/student_teams_controller_spec.rb

<pre>
describe StudentTeamsController do
let (:student_teams_controller) { StudentTeamsController.new }
let(:student) { double "student" }
describe '#view' do
it 'sets the student' do
allow(AssignmentParticipant).to receive(:find).with('12345').and_return student
allow(student_teams_controller).to receive(:current_user_id?)
allow(student_teams_controller).to receive(:params).and_return(student_id: '12345')
allow(student).to receive(:user_id)
student_teams_controller.view
end
end
end
</pre>

==Future Work==
* In the update method of student_teams_controller.rb, the 'elsif' needs a comment to explain its purpose. It is unclear as to why this conditional is present.
* For student_teams_controller update method, simplify the condition logic by combining elsif and else into a single statement

CSC/ECE 517 Fall 2020 - E2067. Refactor student teams controller.rb

2020-10-11T18:18:11Z

Tyeh3: /* Motivation */

CSC/ECE 517 Fall 2020 - E2067. Refactor student teams controller.rb

2020-10-11T18:14:20Z

Tyeh3:

File:E2067 Issue11 Fix2.png

2020-10-11T18:03:07Z

Tyeh3:

File:E2067 Issue11 Fix1.png

2020-10-11T18:01:31Z

Tyeh3:

File:E2067 Issue7 Fix.png

2020-10-11T17:53:43Z

Tyeh3:

File:E2067 Issue8 Fix.png

2020-10-11T17:45:15Z

Tyeh3: Tyeh3 uploaded a new version of File:E2067 Issue8 Fix.png

File:E2067 Issue10 Fix.png

2020-10-11T17:39:59Z

Tyeh3:

File:E2067 Issue10 After.png

2020-10-11T17:33:02Z

Tyeh3:

File:E2067 Issue10 Before.png

2020-10-11T17:32:52Z

Tyeh3:

CSC/ECE 517 Fall 2020 - E2067. Refactor student teams controller.rb

2020-10-11T16:26:09Z

Tyeh3: Added Sections to the page and completed the introduction section.

File:E2067 Issue8 Fix.png

2020-10-11T16:20:00Z

Tyeh3:

CSC/ECE 517 Fall 2020

2020-10-10T14:17:44Z

Tyeh3: Added new link to the E2067 Doc

* [[Dummy URL]]
* [[Dummy Url2]]
* [[CSC/ECE 517 Fall 2020 - E2068. Refactor quiz_questionnaires_controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2062. Add test cases to review_mapping_helper.rb]]
* [[CSC/ECE 517 Fall 2020 - E2066. Refactor lottery controller.rb]]
* [[CSC/ECE 517 Fall 2020 - E2067. Refactor student_teams_controller.rb]]