Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-29T19:32:09Z

Tmainka: /* External Links */

'''E1458: Expertiza - Refactoring ResponseController'''

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. It supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions, finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Expertiza project with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the model's responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

Edit method:
<pre>
def edit
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find(params[:id])
return if redirect_when_disallowed(@response)

@map = @response.map
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
for element in @prev
if (element.map_id==@map.map_id)
array_not_empty=1
@review_scores << element
end
end
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
@response = Response.where(map_id: @map.map_id, version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
get_content
@review_scores = Array.new
@question_type = Array.new
@questions.each do |question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
@question_type << QuestionType.find_by_question_id(question.id)
end
# Check whether this is a custom rubric
if @map.questionnaire.section.eql? "Custom"
@next_action = "custom_update"
render :action => 'custom_response'
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
</pre>

New_feedback method:
<pre>
def new_feedback
review = Response.find(params[:id])
if review
reviewer = AssignmentParticipant.where(user_id: session[:user].id, parent_id: review.map.assignment.id).first
map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: reviewer.id).first
if map.nil?
map = FeedbackResponseMap.create(:reviewed_object_id => review.id, :reviewer_id => reviewer.id, :reviewee_id => review.map.reviewer.id)
end
redirect_to :action => 'new', :id => map.map_id, :return => "feedback"
else
redirect_to :back
end
end
</pre>
View method:
<pre>
def view
@response = Response.find(params[:id])
return if redirect_when_disallowed(@response)
@map = @response.map
get_content
@review_scores = Array.new
@question_type = Array.new
@questions.each do |question|
@review_scores << Score.where(response_id: @map.response_id, question_id: question.id).first
@question_type << QuestionType.find_by_question_id(question.id)
end
end
</pre>

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added two methods named 'handle_jace_kludge' and 'check_user_name_jace?'

<pre>
def check_user_name_jace?
return @assignment.instructor_id == User.find_by_name("jace_smith").id
end
</pre>

<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

* Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

==Results==
Although ResponseController is a complex class, we managed to improve its code significantly through refactoring. We made use of [https://codeclimate.com/ Code Climate] in order to run analysis of our changes against the original Expertiza code. We have managed to reduce the overall complexity of this class from 719 to 581 and duplication from 685 to 410.
Also one of the major refactoring was performed on "rereview" method. We have managed to reduce its complexity from 129 to 91 by extracting methods.

'''Original ResponseController on Codeclimate:'''<ref>https://codeclimate.com/github/expertiza/expertiza/ResponseController</ref>

[[File:EXP-original.png]]
[[File:rereview-original.png]]

'''ResponseController on Codeclimate after Refactoring:'''

[[File:EXP-new.png]]
[[File:rereview-new.png]]

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.46.19.211:3000/ VCL Link]

:3. [https://github.com/sjoshi6/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

==References==
<references/>

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-29T19:31:09Z

Tmainka: /* External Links */

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-29T19:30:36Z

Tmainka: /* External Links */

2014-10-29T19:07:13Z

Tmainka: uploaded a new version of "File:Rereview-new.png": Reverted to version as of 19:05, 29 October 2014

File:Rereview-new.png

2014-10-29T19:06:58Z

Tmainka: uploaded a new version of "File:Rereview-new.png"

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-29T19:06:15Z

2014-10-29T18:43:28Z

Tmainka:

'''E1458: Expertiza - Refactoring ResponseController'''

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. It supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions, finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Expertiza project with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the model's responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

Edit method:
<pre>
def edit
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find(params[:id])
return if redirect_when_disallowed(@response)

@map = @response.map
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
for element in @prev
if (element.map_id==@map.map_id)
array_not_empty=1
@review_scores << element
end
end
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
@response = Response.where(map_id: @map.map_id, version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
get_content
@review_scores = Array.new
@question_type = Array.new
@questions.each do |question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
@question_type << QuestionType.find_by_question_id(question.id)
end
# Check whether this is a custom rubric
if @map.questionnaire.section.eql? "Custom"
@next_action = "custom_update"
render :action => 'custom_response'
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
</pre>

New_feedback method:
<pre>
def new_feedback
review = Response.find(params[:id])
if review
reviewer = AssignmentParticipant.where(user_id: session[:user].id, parent_id: review.map.assignment.id).first
map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: reviewer.id).first
if map.nil?
map = FeedbackResponseMap.create(:reviewed_object_id => review.id, :reviewer_id => reviewer.id, :reviewee_id => review.map.reviewer.id)
end
redirect_to :action => 'new', :id => map.map_id, :return => "feedback"
else
redirect_to :back
end
end
</pre>
View method:
<pre>
def view
@response = Response.find(params[:id])
return if redirect_when_disallowed(@response)
@map = @response.map
get_content
@review_scores = Array.new
@question_type = Array.new
@questions.each do |question|
@review_scores << Score.where(response_id: @map.response_id, question_id: question.id).first
@question_type << QuestionType.find_by_question_id(question.id)
end
end
</pre>

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added two methods named 'handle_jace_kludge' and 'check_user_name_jace?'

<pre>
def check_user_name_jace?
return @assignment.instructor_id == User.find_by_name("jace_smith").id
end
</pre>

<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

* Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

==Results==

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.46.19.211:3000/ VCL Link]

:3. [https://github.com/sjoshi6/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-29T14:47:35Z

Tmainka: /* Results */

'''E1458: Expertiza - Refactoring ResponseController'''

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. It supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions, finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Expertiza project with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the model's responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

Edit method:
<pre>
def edit
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find(params[:id])
return if redirect_when_disallowed(@response)

@map = @response.map
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
for element in @prev
if (element.map_id==@map.map_id)
array_not_empty=1
@review_scores << element
end
end
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
@response = Response.where(map_id: @map.map_id, version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
get_content
@review_scores = Array.new
@question_type = Array.new
@questions.each do |question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
@question_type << QuestionType.find_by_question_id(question.id)
end
# Check whether this is a custom rubric
if @map.questionnaire.section.eql? "Custom"
@next_action = "custom_update"
render :action => 'custom_response'
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
</pre>

New_feedback method:
<pre>
def new_feedback
review = Response.find(params[:id])
if review
reviewer = AssignmentParticipant.where(user_id: session[:user].id, parent_id: review.map.assignment.id).first
map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: reviewer.id).first
if map.nil?
map = FeedbackResponseMap.create(:reviewed_object_id => review.id, :reviewer_id => reviewer.id, :reviewee_id => review.map.reviewer.id)
end
redirect_to :action => 'new', :id => map.map_id, :return => "feedback"
else
redirect_to :back
end
end
</pre>
View method:
<pre>
def view
@response = Response.find(params[:id])
return if redirect_when_disallowed(@response)
@map = @response.map
get_content
@review_scores = Array.new
@question_type = Array.new
@questions.each do |question|
@review_scores << Score.where(response_id: @map.response_id, question_id: question.id).first
@question_type << QuestionType.find_by_question_id(question.id)
end
end
</pre>

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added two methods named 'handle_jace_kludge' and 'check_user_name_jace?'

<pre>
def check_user_name_jace?
return @assignment.instructor_id == User.find_by_name("jace_smith").id
end
</pre>

<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

* Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.46.19.211:3000/ VCL Link]

:3. [https://github.com/sjoshi6/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

File:Expertiza-original.png

2014-10-29T14:43:23Z

Tmainka:

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-29T14:39:56Z

Tmainka:

'''E1458: Expertiza - Refactoring ResponseController'''

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. It supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions, finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Expertiza project with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the model's responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

Edit method:
<pre>
def edit
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find(params[:id])
return if redirect_when_disallowed(@response)

@map = @response.map
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
for element in @prev
if (element.map_id==@map.map_id)
array_not_empty=1
@review_scores << element
end
end
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
@response = Response.where(map_id: @map.map_id, version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
get_content
@review_scores = Array.new
@question_type = Array.new
@questions.each do |question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
@question_type << QuestionType.find_by_question_id(question.id)
end
# Check whether this is a custom rubric
if @map.questionnaire.section.eql? "Custom"
@next_action = "custom_update"
render :action => 'custom_response'
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
</pre>

New_feedback method:
<pre>
def new_feedback
review = Response.find(params[:id])
if review
reviewer = AssignmentParticipant.where(user_id: session[:user].id, parent_id: review.map.assignment.id).first
map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: reviewer.id).first
if map.nil?
map = FeedbackResponseMap.create(:reviewed_object_id => review.id, :reviewer_id => reviewer.id, :reviewee_id => review.map.reviewer.id)
end
redirect_to :action => 'new', :id => map.map_id, :return => "feedback"
else
redirect_to :back
end
end
</pre>
View method:
<pre>
def view
@response = Response.find(params[:id])
return if redirect_when_disallowed(@response)
@map = @response.map
get_content
@review_scores = Array.new
@question_type = Array.new
@questions.each do |question|
@review_scores << Score.where(response_id: @map.response_id, question_id: question.id).first
@question_type << QuestionType.find_by_question_id(question.id)
end
end
</pre>

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added two methods named 'handle_jace_kludge' and 'check_user_name_jace?'

<pre>
def check_user_name_jace?
return @assignment.instructor_id == User.find_by_name("jace_smith").id
end
</pre>

<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

* Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

==Results==
== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.46.19.211:3000/ VCL Link]

:3. [https://github.com/sjoshi6/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T04:01:49Z

Tmainka: /* External Links */

'''E1458: Expertiza - Refactoring ResponseController'''

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Expertiza project with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the model's responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

Edit method:
<pre>
def edit
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find(params[:id])
return if redirect_when_disallowed(@response)

@map = @response.map
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
for element in @prev
if (element.map_id==@map.map_id)
array_not_empty=1
@review_scores << element
end
end
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
@response = Response.where(map_id: @map.map_id, version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
get_content
@review_scores = Array.new
@question_type = Array.new
@questions.each do |question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
@question_type << QuestionType.find_by_question_id(question.id)
end
# Check whether this is a custom rubric
if @map.questionnaire.section.eql? "Custom"
@next_action = "custom_update"
render :action => 'custom_response'
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
</pre>

New_feedback method:
<pre>
def new_feedback
review = Response.find(params[:id])
if review
reviewer = AssignmentParticipant.where(user_id: session[:user].id, parent_id: review.map.assignment.id).first
map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: reviewer.id).first
if map.nil?
map = FeedbackResponseMap.create(:reviewed_object_id => review.id, :reviewer_id => reviewer.id, :reviewee_id => review.map.reviewer.id)
end
redirect_to :action => 'new', :id => map.map_id, :return => "feedback"
else
redirect_to :back
end
end
</pre>
View method:
<pre>
def view
@response = Response.find(params[:id])
return if redirect_when_disallowed(@response)
@map = @response.map
get_content
@review_scores = Array.new
@question_type = Array.new
@questions.each do |question|
@review_scores << Score.where(response_id: @map.response_id, question_id: question.id).first
@question_type << QuestionType.find_by_question_id(question.id)
end
end
</pre>

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added two methods named 'handle_jace_kludge' and 'check_user_name_jace?'

<pre>
def check_user_name_jace?
return @assignment.instructor_id == User.find_by_name("jace_smith").id
end
</pre>

<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.46.19.211:3000/ VCL Link]

:3. [https://github.com/sjoshi6/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T03:54:50Z

Tmainka: /* Removal of redundant methods */

'''E1458: Expertiza - Refactoring ResponseController'''

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Expertiza project with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the model's responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

Edit method:
<pre>
def edit
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find(params[:id])
return if redirect_when_disallowed(@response)

@map = @response.map
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
for element in @prev
if (element.map_id==@map.map_id)
array_not_empty=1
@review_scores << element
end
end
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
@response = Response.where(map_id: @map.map_id, version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
get_content
@review_scores = Array.new
@question_type = Array.new
@questions.each do |question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
@question_type << QuestionType.find_by_question_id(question.id)
end
# Check whether this is a custom rubric
if @map.questionnaire.section.eql? "Custom"
@next_action = "custom_update"
render :action => 'custom_response'
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
</pre>

New_feedback method:
<pre>
def new_feedback
review = Response.find(params[:id])
if review
reviewer = AssignmentParticipant.where(user_id: session[:user].id, parent_id: review.map.assignment.id).first
map = FeedbackResponseMap.where(reviewed_object_id: review.id, reviewer_id: reviewer.id).first
if map.nil?
map = FeedbackResponseMap.create(:reviewed_object_id => review.id, :reviewer_id => reviewer.id, :reviewee_id => review.map.reviewer.id)
end
redirect_to :action => 'new', :id => map.map_id, :return => "feedback"
else
redirect_to :back
end
end
</pre>
View method:
<pre>
def view
@response = Response.find(params[:id])
return if redirect_when_disallowed(@response)
@map = @response.map
get_content
@review_scores = Array.new
@question_type = Array.new
@questions.each do |question|
@review_scores << Score.where(response_id: @map.response_id, question_id: question.id).first
@question_type << QuestionType.find_by_question_id(question.id)
end
end
</pre>

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added two methods named 'handle_jace_kludge' and 'check_user_name_jace?'

<pre>
def check_user_name_jace?
return @assignment.instructor_id == User.find_by_name("jace_smith").id
end
</pre>

<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T03:50:14Z

Tmainka:

'''E1458: Expertiza - Refactoring ResponseController'''

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Expertiza project with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the model's responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added two methods named 'handle_jace_kludge' and 'check_user_name_jace?'

<pre>
def check_user_name_jace?
return @assignment.instructor_id == User.find_by_name("jace_smith").id
end
</pre>

<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:56:20Z

Tmainka: /* Moved methods from Response Controller to appropriate models */

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Expertiza project with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the model's responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added two methods named 'handle_jace_kludge' and 'check_user_name_jace?'

<pre>
def check_user_name_jace?
return @assignment.instructor_id == User.find_by_name("jace_smith").id
end
</pre>

<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:55:25Z

Tmainka: /* Creation of a Kludge */

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Expertiza project with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the model's responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added two methods named 'handle_jace_kludge' and 'check_user_name_jace?'

<pre>
def check_user_name_jace?
return @assignment.instructor_id == User.find_by_name("jace_smith").id
end
</pre>

<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:54:37Z

Tmainka: /* Creation of a Kludge */

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Expertiza project with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the model's responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.

<pre>
def check_user_name_jace?
return @assignment.instructor_id == User.find_by_name("jace_smith").id
end
</pre>

<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:49:10Z

Tmainka: /* Project Description */

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Expertiza project with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the model's responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:48:18Z

Tmainka: /* Background */

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Expertiza project with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:44:48Z

Tmainka: /* Refactoring carried out */

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Open Source Software project Expertiza with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was handled by denying incorrect access using the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:43:45Z

Tmainka: /* Refactoring carried out */

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Open Source Software project Expertiza with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:43:19Z

Tmainka: /* Refactoring carried out */

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Open Source Software project Expertiza with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method.
It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations.
* For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:39:50Z

Tmainka: /* Creation of a Kludge */

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Open Source Software project Expertiza with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jace’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:38:10Z

Tmainka: /* Perform Authorization correctly */

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Open Source Software project Expertiza with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was done incorrectly via the redirect_when_disallowed method. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response is applied to, or if they are an instructor or Teaching Assistant for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor and neither the Teaching Assistant for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? method which does the authorization check and allows the user to perform the action only if he/she has the correct permissions.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jen’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:13:59Z

Tmainka:

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Open Source Software project Expertiza with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was not checked correctly. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response applied to, or if they are an instructor or TA for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor or TA for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? Method which does the authorization check and allows the user to perform the action if it is allowed.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jen’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:13:39Z

Tmainka:

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
Expertiza[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Open Source Software project Expertiza with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was not checked correctly. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response applied to, or if they are an instructor or TA for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor or TA for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? Method which does the authorization check and allows the user to perform the action if it is allowed.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jen’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T01:12:29Z

Tmainka: /* Expertiza - Refactoring ResponseController */

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
Expertiza[1] is a peer review based course management system. Expertiza supports project submission,team creation, and review of the submitted material including URLs and wiki pages. Students can manage teammates and can conduct reviews on other's topics and projects.
Expertiza is an open source project based on Ruby on Rails.

== Background==
As a part of the OSS project 1 we were expected to refactor the Response Controller of Expertiza. Response Controller is responsible for managing the review versions and finding the latest responses and fetching the review scores. This wiki provides a detailed walk through of our contributions to the Open Source Software project Expertiza with a focus on refactoring.

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was not checked correctly. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response applied to, or if they are an instructor or TA for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor or TA for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? Method which does the authorization check and allows the user to perform the action if it is allowed.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jen’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T00:55:59Z

Tmainka: /* Expertiza - Refactoring ResponseController */

=Expertiza - Refactoring ResponseController=

__TOC__

==Expertiza==
==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was not checked correctly. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response applied to, or if they are an instructor or TA for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor or TA for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? Method which does the authorization check and allows the user to perform the action if it is allowed.

Before Refactoring:

'''redirect_when_disallowed''' Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

We replaced the '''redirect_when_disallowed''' Method by '''action_allowed?''' Method.
<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jen’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

== External Links ==

:1. [http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza]

:2. [http://152.7.99.43:3000/ VCL Link]

:3. [https://github.com/nixtish/expertiza Git repository]

:4. [https://docs.google.com/a/ncsu.edu/document/d/1Z0xjFZu-Zy-xm73YyUVUgFCtfWgRwhN1rZuThoyF-U0/edit Steps to setup Expertiza]

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T00:17:58Z

Tmainka: /* Moved methods from Response Controller to appropriate models */

=Expertiza - Refactoring ResponseController=

__TOC__

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was not checked correctly. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response applied to, or if they are an instructor or TA for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor or TA for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? Method which does the authorization check and allows the user to perform the action if it is allowed.

Before Refactoring:

redirect_when_disallowed Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jen’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; So we moved it to the '''Response model'''.

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>

Similarly, the logic for determining whether a review is current or not(i.e., the review was done during the current assignment phase) is not a controller's responsibility and thus was moved to the '''Response model'''.
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T00:12:58Z

Tmainka: /* Moved methods from Response Controller to appropriate models */

=Expertiza - Refactoring ResponseController=

__TOC__

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was not checked correctly. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response applied to, or if they are an instructor or TA for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor or TA for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? Method which does the authorization check and allows the user to perform the action if it is allowed.

Before Refactoring:

redirect_when_disallowed Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jen’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* Sorting review versions is not a controller responsibility; SO we moved it to the '''Response model'''. Similarly, the logic for determining whether a review is current or not(i.e., was done during the current assignment phase) was moved to the Response model from the controller. This is a query that is made about a review (actually, about a response, which may be a review, author feedback, etc.). It should be placed in the appropriate model class.*/

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-27T00:01:32Z

Tmainka: /* Moved methods from Response Controller to appropriate models */

=Expertiza - Refactoring ResponseController=

__TOC__

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was not checked correctly. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response applied to, or if they are an instructor or TA for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor or TA for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? Method which does the authorization check and allows the user to perform the action if it is allowed.

Before Refactoring:

redirect_when_disallowed Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jen’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* /*TODO for wiki Sorting review versions is not a controller responsibility; it would be better to do this in a model class (which class?) Ditto for determining whether a review is current (i.e., was done during the current assignment phase). This is a query that is made about a review (actually, about a response, which may be a review, author feedback, etc.). It should be placed in the appropriate model class.*/

<pre>
def self.getAllResponseVersions
#get all previous versions of responses for the response map.
@review_scores=Array.new
@prev=Response.where(map_id: @map.id)

@prev.each do |element|
@review_scores << element
end

return @review_scores
end
</pre>
<pre>
def self.get_largest_version_number(review_scores)
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
end
</pre>

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-26T23:58:56Z

Tmainka: /* Cleaning up of the rereview moethod */

=Expertiza - Refactoring ResponseController=

__TOC__

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was not checked correctly. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response applied to, or if they are an instructor or TA for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor or TA for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? Method which does the authorization check and allows the user to perform the action if it is allowed.

Before Refactoring:

redirect_when_disallowed Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is '''81''' lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jen’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* /*TODO for wiki Sorting review versions is not a controller responsibility; it would be better to do this in a model class (which class?) Ditto for determining whether a review is current (i.e., was done during the current assignment phase). This is a query that is made about a review (actually, about a response, which may be a review, author feedback, etc.). It should be placed in the appropriate model class.*/

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-26T23:52:16Z

Tmainka: /* Creation of a Kludge */

=Expertiza - Refactoring ResponseController=

__TOC__

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was not checked correctly. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response applied to, or if they are an instructor or TA for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor or TA for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? Method which does the authorization check and allows the user to perform the action if it is allowed.

Before Refactoring:

redirect_when_disallowed Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is ___ lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jen’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
def handle_jace_kludge
# ** if assignment belongs to Jace handle it depending on the assignment id **
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
end
</pre>

===Moved methods from Response Controller to appropriate models===

* /*TODO for wiki Sorting review versions is not a controller responsibility; it would be better to do this in a model class (which class?) Ditto for determining whether a review is current (i.e., was done during the current assignment phase). This is a query that is made about a review (actually, about a response, which may be a review, author feedback, etc.). It should be placed in the appropriate model class.*/

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-26T23:51:28Z

Tmainka: /* Cleaning up of the rereview moethod */

=Expertiza - Refactoring ResponseController=

__TOC__

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was not checked correctly. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response applied to, or if they are an instructor or TA for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor or TA for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? Method which does the authorization check and allows the user to perform the action if it is allowed.

Before Refactoring:

redirect_when_disallowed Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is ___ lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

@review_scores=response.getAllResponseVersions
#sort all the available versions in descending order.
if @prev.present?
@largest_version_num = Response.get_largest_version_number(@review_scores)
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])

@sorted_deadlines = DueDate.sort_deadlines(due_dates)
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.where(map_id: params[:id], version_num: @largest_version_num.version_num).first
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.where(response_id: @response.response_id, question_id: question.id).first
}
#**********************

# Check whether this is Jace's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end

else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (check_user_name_jace? && @title == "Review")
handle_jace_kludge
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end

</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jen’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
Code snippet
</pre>

===Moved methods from Response Controller to appropriate models===

* /*TODO for wiki Sorting review versions is not a controller responsibility; it would be better to do this in a model class (which class?) Ditto for determining whether a review is current (i.e., was done during the current assignment phase). This is a query that is made about a review (actually, about a response, which may be a review, author feedback, etc.). It should be placed in the appropriate model class.*/

CSC/ECE 517 Fall 2014/oss E1458 sst

2014-10-26T23:46:09Z

Tmainka: /* Perform Authorization correctly */

=Expertiza - Refactoring ResponseController=

__TOC__

==Project Description==

The response controller allows the user to create and edit responses to questionnaires such as performing a review, rating a teammate or giving feedback to a reviewer.
Our project requirement was to perform the following changes :
* Perform authorization properly.
* Remove the duplicated methods.
* Reduce the complexity of the rereview method.
* Move the functionality incorporated in the controller, to the model, as it is the models responsibility to implement this functionality.

==Refactoring carried out==

The following changes have been made in the project, as described in the requirements document.

===Perform Authorization correctly===

* Authorization to perform actions was not checked correctly. It is supposed to be done through the action_allowed? method at the beginning of the class definition. Different authorizations are required for different operations. For example, someone should be allowed to view a response if they wrote the response, or they are the person or on the team whose work the response applied to, or if they are an instructor or TA for the class. The person who wrote a response should be allowed to edit it, but not the person/team who was being reviewed, nor the instructor or TA for the class.
* Earlier, the authorization was denied by the redirect_when_disallowed method, which was a more error-prone way of controlling access. This method has now been removed, and now the class has an action_allowed? Method which does the authorization check and allows the user to perform the action if it is allowed.

Before Refactoring:

redirect_when_disallowed Method was used for authorization purposes.

<pre>
def redirect_when_disallowed(response)
# For author feedback, participants need to be able to read feedback submitted by other teammates.
# If response is anything but author feedback, only the person who wrote feedback should be able to see it.
if response.map.read_attribute(:type) == 'FeedbackResponseMap' && response.map.assignment.team_assignment?
team = response.map.reviewer.team
unless team.has_user session[:user]
redirect_to '/denied?reason=You are not on the team that wrote this feedback'
else
return false
end
response.map.read_attribute(:type)
end
!current_user_id?(response.map.reviewer.user_id)
end
</pre>

After Refactoring:

<pre>
def action_allowed?
case params[:action]
when 'view', 'edit', 'delete', 'rereview', 'update'
if response.map.read_attribute(:type) == 'FeedbackResponseMap'
team = response.map.reviewer.team
if team.has_user session[:user]
flag= true
else
flag=false
end
end
else
flag=true
end
return flag
end
</pre>

===Removal of redundant methods===

* There were two copies of the '''edit, new_feedback and view methods'''. The second being the newer one, and, according to the rules for method definition, is the one that is currently in use because the latest version overrides the previous versions. We refactored the code by removing the redundant methods for edit, new_feedback and view.

===Cleaning up of the rereview moethod===
* The rereview method was 98 lines long. We refactored the code by turning several parts of it into methods. Now the code is ___ lines long.

Before Refactoring:

<pre>
def rereview
@map=ResponseMap.find(params[:id])
get_content
array_not_empty=0
@review_scores=Array.new
@prev=Response.all
#get all versions and find the latest version
for element in @prev
if (element.map.id==@map.map.id)
array_not_empty=1
@review_scores << element
end
end

latestResponseVersion
#sort all the available versions in descending order.
if @prev.present?
@sorted=@review_scores.sort { |m1, m2| (m1.version_num and m2.version_num) ? m2.version_num <=> m1.version_num : (m1.version_num ? -1 : 1) }
@largest_version_num=@sorted[0]
@latest_phase=@largest_version_num.created_at
due_dates = DueDate.where(["assignment_id = ?", @assignment.id])
@sorted_deadlines=Array.new
@sorted_deadlines=due_dates.sort { |m1, m2| (m1.due_at and m2.due_at) ? m1.due_at <=> m2.due_at : (m1.due_at ? -1 : 1) }
current_time=Time.new.getutc
#get the highest version numbered review
next_due_date=@sorted_deadlines[0]
#check in which phase the latest review was done.
for deadline_version in @sorted_deadlines
if (@largest_version_num.created_at < deadline_version.due_at)
break
end
end
for deadline_time in @sorted_deadlines
if (current_time < deadline_time.due_at)
break
end
end
end
#check if the latest review is done in the current phase.
#if latest review is in current phase then edit the latest one.
#else create a new version and update it.
# editing the latest review
if (deadline_version.due_at== deadline_time.due_at)
#send it to edit here
@header = "Edit"
@next_action = "update"
@return = params[:return]
@response = Response.find_by_map_id_and_version_num(params[:id], @largest_version_num.version_num)
return if redirect_when_disallowed(@response)
@modified_object = @response.response_id
@map = @response.map
get_content
@review_scores = Array.new
@questions.each {
|question|
@review_scores << Score.find_by_response_id_and_question_id(@response.response_id, question.id)
}
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
else
#else create a new version and update it.
@header = "New"
@next_action = "create"
@feedback = params[:feedback]
@map = ResponseMap.find(params[:id])
@return = params[:return]
@modified_object = @map.map_id
get_content
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "create"
render :action => 'custom_response'
else
@next_action = "create"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
end
end
</pre>

After Refactoring:

<pre>
Code snippet
</pre>

===Creation of a Kludge===

* The rereview method contained a special code to check whether an assignment is “Jen’s assignment”; this was the first assignment that was ever created with a multipart rubric. It was hard-coded into the system, rather than working on a rubric that was created in the normal way. It is impossible to remove this code without breaking that assignment. It is now implemented as a separate method named handle_jace_kludge.

Before Refactoring:

The following code was present in the rereview method.
<pre>
#**********************
# Check whether this is Jen's assgt. & if so, use her rubric
if (@assignment.instructor_id == User.find_by_name("jace_smith").id) && @title == "Review"
if @assignment.id < 469
@next_action = "update"
render :action => 'custom_response'
else
@next_action = "update"
render :action => 'custom_response_2011'
end
else
# end of special code (except for the end below, to match the if above)
#**********************
render :action => 'response'
end
</pre>

After Refactoring:

We added a method named 'handle_jace_kludge'.
<pre>
Code snippet
</pre>

===Moved methods from Response Controller to appropriate models===

* /*TODO for wiki Sorting review versions is not a controller responsibility; it would be better to do this in a model class (which class?) Ditto for determining whether a review is current (i.e., was done during the current assignment phase). This is a query that is made about a review (actually, about a response, which may be a review, author feedback, etc.). It should be placed in the appropriate model class.*/

CSC/ECE 517 Fall 2014

2014-10-26T23:16:27Z

Tmainka:

*[[CSC/ECE_517_Fall_2014/sample_page]]
*[[CSC/ECE_517_Fall_2014/ch1a 22 as]]
*[[CSC/ECE 517 Fall 2014/ch1a 19 mx]]
*[[CSC/ECE 517 Fall 2014/ch1a 3 zq]]
*[[CSC/ECE 517 Fall 2014/ch1a 4 lf]]
*[[CSC/ECE 517 Fall 2014/ch1a 4 wl]]
*[[CSC/ECE 517 Fall 2014/ch1a a7 ch]]
*[[CSC/ECE 517 Fall 2014/ch1a 25 rs]]
*[[CSC/ECE 517 Fall 2014/ch1a 25 jf]]
*[[CSC/ECE 517 Fall 2014/ch1a 8 os]]
*[[CSC/ECE 517 Fall 2014/ch1a 8 sn]]
*[[CSC/ECE 517 Fall 2014/ch1a 15 gs]]
*[[CSC/ECE 517 Fall 2014/ch1a 10 hu]]
*[[CSC/ECE 517 Fall 2014/ch1a 20 kv]]
*[[CSC/ECE 517 Fall 2014/ch1a 21 as]]
*[[CSC/ECE 517 Fall 2014/ch1a 24 sa]]
*[[CSC/ECE 517 Fall 2014/ch1a 26 sn]]
*[[CSC/ECE 517 Fall 2014/ch1a 6 rl]]
*[[CSC/ECE 517 Fall 2014/ch1a 2 ss]]
*[[CSC/ECE 517 Fall 2014/ch1a 16 av]]
*[[CSC/ECE 517 Fall 2014/ch1a 1 rm]]
*[[CSC/ECE 517 Fall 2014/ch1a 1 sj]]
*[[CSC/ECE 517 Fall 2014/ch1a 23 ss]]
*[[CSC/ECE 517 Fall 2014/ch1a 20 rn]]
*[[CSC/ECE 517 Fall 2014/ch1a 22 sp]]
*[[CSC/ECE 517 Fall 2014/ch1a 26 gn]]

*[[CSC/ECE 517 Fall 2014/ch1a 13 va]]
*[[CSC/ECE 517 Fall 2014/ch1a 9 aa]]
*[[CSC/ECE 517 Fall 2014/ch1a 9 kn]]
*[[CSC/ECE 517 Fall 2014/ch1a 11 ap]]
*[[CSC/ECE 517 Fall 2014/ch1a 25 ks]]
*[[CSC/ECE 517 Fall 2014/ch1a 7 kz]]
*[[CSC/ECE_517_Fall_2014/ch1a_6_bn]]
*[[CSC/ECE_517_Fall_2014/ch1a 10 zz]]
*[[CSC/ECE_517_Fall_2014/ch1a 16 va]]
*[[CSC/ECE_517_Fall_2014/ch1a F1415 rv]]
*[[CSC/ECE_517_Fall_2014/ch1a_3_cp]]
*[[CSC/ECE 517 Fall 2014/ch1b 26 sa]]
*[[CSC/ECE_517_Fall_2014/ch1b_28_cg]]
*[[CSC/ECE_517_Fall_2014/ch1b 29 ry]]
*[[CSC/ECE_517_Fall_2014/ch1b 30 cs]]
*[[CSC/ECE_517_Fall_2014/ch1b_33_jy]]
*[[CSC/ECE_517_Fall_2014/ch1b_27_js]]
*[[CSC/ECE 517 Fall 2014/oss E1465 oak]]
*[[CSC/ECE 517 Fall 2014/oss_M1456_kdv]]
*[[CSC/ECE 517 Fall 2014/oss_E1456_akk]]
*[[CSC/ECE_517_Fall_2014/oss_M1455_asa]]
*[[CSC/ECE_517_Fall_2014/oss_E1458_sst]]

CSC/ECE 517 Fall 2014

2014-10-26T23:03:28Z

Tmainka: