Expertiza_Wiki - User contributions [en]

CSC/E1869 GRADING AUDIT TRAIL

2018-12-08T04:04:50Z

Syu10:

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade / comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create a entry saves into database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controllers/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''
* app/views/assignments/list_submissions.html.erb
'''Add code to support view changes for Grade Record'''
* app/views/review_mapping/_review_report.html.erb
'''Add code to support view changes for Grade Record'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as instructor

2.Navigate to Manage -> Assignments

3.Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details whill show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Actual Implementation'''==
===Actual View===
Actual view for submission list
[[File:E1869-Actual-1.JPG]]

Actual view for review report
[[File:E1869-Actual-3.png]]

Actual view for submission grade record
[[File:E1869-Actual-2.JPG]]

Actual view for review grade record
[[File:E1869-Actual-4.png]]
=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

File:E1869-Actual-4.png

2018-12-08T04:00:35Z

Syu10:

File:E1869-Actual-3.png

2018-12-08T04:00:22Z

Syu10:

File:E1869-Actual-2.JPG

2018-12-08T04:00:10Z

Syu10:

File:E1869-Actual-1.JPG

2018-12-08T03:59:47Z

Syu10:

CSC/E1869 GRADING AUDIT TRAIL

2018-11-20T17:45:00Z

Syu10:

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade / comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create a entry saves into database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controllers/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''
* app/views/assignments/list_submissions.html.erb
'''Add code to support view changes for Grade Record'''
* app/views/review_mapping/_review_report.html.erb
'''Add code to support view changes for Grade Record'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as instructor

2.Navigate to Manage -> Assignments

3.Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details whill show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

CSC/E1869 GRADING AUDIT TRAIL

2018-11-20T17:36:38Z

Syu10:

=='''Introduction'''==

===Problem Statement===
After an instructor gave a grade to an assignment, there is no way to track who gave the grade.
A grading audit trail must be created and the following information needs to be stored:
:1. When a grade is assigned by an instructor, there needs to be an indication of who did it and when it was done.
:2. Comments previously provided by other instructors must also be preserved.

This information needs to be stored every time an instructor edits a grade / comment and clicks the save button.

Currently, there are two places need to add grading audit trail:
:1. '''Review grade''': Log in as instructor -> Manage -> Assignments -> View Review Report
:2. '''Submission grade''': Log in as instructor -> Manage -> Assignments -> View submissions

=='''Proposed Solution'''==

===Design===
We will create a database called grading_history in the system contains elements instructor id, assignment id, grade type, student id, grade, comment, and timestamp.

We will use MVC design to create a model, a controller, and a view for both of '''Review Grade''' and '''Submission Grade'''.

:Model: grading_history.rb. Has a list of attributes contains instructor id, assignment id, grade type, student id, grade, comment, and timestamp.
:Controller: grading_history_controller.rb. Saves a new entry into database every time a review grade or submission grade is saved
:View: index_html.erb. Displays current submission or review's grading history. An existing example of this is submission record in the system.

We also need to modified grades controller, so that every time, a grade is submitted or edited, grading_history_controller.rb will call a method to create a entry saves into database.

===Expected View===
Expected view for submission list
[[File:E1869-Screenshot-1.jpg]]

Expected view for review report
[[File:E1869-Screenshot-2.jpg]]

Expected view for grade record
[[File:E1869-Screenshot-3.jpg]]
===Diagram===
[[File:E1869_Grading_Audit_Trails_UML.jpg]]

=='''Files Changed'''==

===Files Added===
*app/models/grading_history.rb
'''This is a model for grading audit trail, containing attributes of grading history'''
*app/controllers/grading_history_controller.rb
'''This is a controller for grading audit trail, it can add grading history into the system'''
*app/views/grading_history/index_html.erb
'''This is a view for grading audit trail, it will display all grading histories of a submission/review'''

===Files Modified===
* app/controller/grades_controller.rb
'''Add code to call methods in grading_history_controller.rb to create new grading history'''

=='''Testing Plan'''==

Functional testing:

For “Review grade”:

1.Log in as instructon

2.Navigate to Manage -> Assignments

3.Click on Review Report

A report with following details will show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

For “Submission grade”:

1.Log in as instructor

2. Navigate to Manage -> Assignments

3.Click on View Submission -> History

A report with following details whill show up:
Timestamp, Instructor Id, Assignment id, Grade type, Student id, Grade, Comment

4.Every time an instructor edits or comments on the grade the report is updated with the new entry and timestamp.

=='''Reference'''==
[https://expertiza.ncsu.edu/ Expertiza]

[http://wiki.expertiza.ncsu.edu/index.php/Main_Page Expertiza_wiki]

[http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation Expertiza Documentation]

[https://github.com/expertiza/expertiza Expertiza Github]

File:E1869-Screenshot-3.jpg

2018-11-20T17:32:12Z

Syu10:

File:E1869-Screenshot-2.jpg

2018-11-20T17:31:01Z

Syu10:

File:E1869-Screenshot-1.jpg

2018-11-20T17:30:09Z

Syu10:

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-14T20:08:21Z

Syu10:

==Introduction==
===Background===
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the students to peer review other students submission. It also allows Participant of a Team to provide feedback for the review. Apart from that, it allows the instructor to view the summary report of reviews received and feedbacks given by each participant of a team.

===Motivation===
In current system the author feedback is send by individual team members. It
would be better if one team send one single rejoinder to the review and all members
could see and edit it. Also there are real usability issues with regards to how students can
even navigate to the place where feedback can be given to reviewers. The UI needs to
be more user friendly.

In Summary report for assignment for instructors, the author feedback
section lists feedback from all team members. You should change this to list the team’s
collective feedback to its reviewers to a particular assignment

===Tasks Identified===

* Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.
* Refactor all the actions in response controllers to pass the participant id.
* Refactor author feedback tab in summary report view for the instructor.
* Change in the summary report of assignment for the instructor to display teams feedbacks.
* In the author-feedback tab on the heat grid, fixed reviewers names on top row.
* Summary reports navigation to the page where feedbacks are given to reviewers.

====Classes====
1.Team rejoinder.
* controllers/response_controller.rb
*views/grades/_reviews.html.erb
*views/response/response.html.erb
*models/vm_question_response.rb
*models/assignment_participant.rb

2.Navigation Issue fixes
*views/response/view.html.erb

3.Author feedback tab of summary report:
*models/response_map.rb
*models/team.rb
*helpers/grades_helper.rb
*views/grades/_author_feedback_tab.html.erb

4.Heatgrid top raw reviewer name fix:
*views/grades/_view_heatgrid.html.erb

====Solutions Implemented and Delivered====

*Changed per participant feedback display author feedback view to per team:

[[File:author_feedback.jpg]]

*Added "give feedback" and edit feedback functionality in the review view.
[[File:view_feedback.jpg]]

*Edited grade helper to use a questionnaire to use team ID for reviews in case of a feedback.
[[File:grades_helper.jpg]]

*Refactored new_feedback method to add team ID as the reviewer Id in the response map.

[[File:New_feedback.jpg]]

*Fixed a bug where a wrong assessment was being returned for a feedback because the map was searched on participant id instead of reviewee id.
So added a new method which will return a feedback assessment.

[[File:response_map.jpg]]

===Testing===

Fixed the existing test cases for the review feedback by a team instead of a team member.
====Test Plan====
*Should test that if there is no rejoinder for the review then it redirects to new author feedback page.

*Tests that the other teammate is able to edit.

*The page is redirecting back to the View->review.

*Tests that the rejoinder by a participant of a team is saved properly.

====ScrennShot====
'''Issue #622'''

1. Click Manage-Impersonate User, type username “student559”, then click impersonate.

2. Choose assignment Test Test, go to Your score, and click Review 1, like the screenshot show, the feedback commit shows "TESTING Feedback".
[[File:Response-view-1.png]]
3. Now, impersonate user “student567”, choose assignment Test Test, go to Your score, and click Review 1, you can see the same feedback commit "TESTING Feedback".
[[File:Response-view-2.png]]

'''Issue#895'''

1. Click Manage-Assignment, under assignment Test Test, click view scores.

2. Choose Team 1, and click Author Feedback, you can see the feedback is given by the team, not individual student.
[[File:Grades-view.png]]

====Tests====

Context 'when current response is nil' do
it 'redirects to response#new page' do
allow(FeedbackResponseMap).to receive(:where).with(reviewed_object_id: 1, reviewer_id: 1).and_return([])
params = {id: 1, participant_id: 1}
session = {user: instructor}
get :new_feedback, params, session
expect(response).to redirect_to('/response/new?id=2&participant_id=1&return=feedback')
end
end

describe '#feedback' do
it 'returns corrsponding author feedback responses given by current participant' do
allow(FeedbackResponseMap).to receive(:get_feedback_assessments_for).with(participant.team).and_return([response])
expect(participant.feedback).to eq([response])
end
end

CSC/ECE 517 Fall 2018 E1832. OSS Project Orange: Author feedback (rejoinder) enhancements

2018-11-14T20:07:22Z

Syu10:

==Introduction==
===Background===
Expertiza is an open source project based on Ruby on Rails framework. Expertiza allows the students to peer review other students submission. It also allows Participant of a Team to provide feedback for the review. Apart from that, it allows the instructor to view the summary report of reviews received and feedbacks given by each participant of a team.

===Motivation===
In current system the author feedback is send by individual team members. It
would be better if one team send one single rejoinder to the review and all members
could see and edit it. Also there are real usability issues with regards to how students can
even navigate to the place where feedback can be given to reviewers. The UI needs to
be more user friendly.

In Summary report for assignment for instructors, the author feedback
section lists feedback from all team members. You should change this to list the team’s
collective feedback to its reviewers to a particular assignment

===Tasks Identified===

* Refactor “new_feedback” actions for adding team as reviewer for Rejoinder.
* Refactor all the actions in response controllers to pass the participant id.
* Refactor author feedback tab in summary report view for the instructor.
* Change in the summary report of assignment for the instructor to display teams feedbacks.
* In the author-feedback tab on the heat grid, fixed reviewers names on top row.
* Summary reports navigation to the page where feedbacks are given to reviewers.

====Classes====
1.Team rejoinder.
* controllers/response_controller.rb
*views/grades/_reviews.html.erb
*views/response/response.html.erb
*models/vm_question_response.rb
*models/assignment_participant.rb

2.Navigation Issue fixes
*views/response/view.html.erb

3.Author feedback tab of summary report:
*models/response_map.rb
*models/team.rb
*helpers/grades_helper.rb
*views/grades/_author_feedback_tab.html.erb

4.Heatgrid top raw reviewer name fix:
*views/grades/_view_heatgrid.html.erb

====Solutions Implemented and Delivered====

*Changed per participant feedback display author feedback view to per team:

[[File:author_feedback.jpg]]

*Added "give feedback" and edit feedback functionality in the review view.
[[File:view_feedback.jpg]]

*Edited grade helper to use a questionnaire to use team ID for reviews in case of a feedback.
[[File:grades_helper.jpg]]

*Refactored new_feedback method to add team ID as the reviewer Id in the response map.

[[File:New_feedback.jpg]]

*Fixed a bug where a wrong assessment was being returned for a feedback because the map was searched on participant id instead of reviewee id.
So added a new method which will return a feedback assessment.

[[File:response_map.jpg]]

===Testing===

Fixed the existing test cases for the review feedback by a team instead of a team member.
====Test Plan====
*Should test that if there is no rejoinder for the review then it redirects to new author feedback page.

*Tests that the other teammate is able to edit.

*The page is redirecting back to the View->review.

*Tests that the rejoinder by a participant of a team is saved properly.

====ScrennShot====
'''Issue #622'''

1. Click Manage-Impersonate User, type username “student559”, then click impersonate
2. Choose assignment Test Test, go to Your score, and click Review 1, like the screenshot show, the feedback commit shows "TESTING Feedback".
[[File:Response-view-1.png]]
3. Now, impersonate user “student567”, choose assignment Test Test, go to Your score, and click Review 1, you can see the same feedback commit "TESTING Feedback".
[[File:Response-view-2.png]]

'''Issue#895'''

1. Click Manage-Assignment, under assignment Test Test, click view scores
2. Choose Team 1, and click Author Feedback, you can see the feedback is given by the team, not individual student
[[File:Grades-view.png]]

====Tests====

Context 'when current response is nil' do
it 'redirects to response#new page' do
allow(FeedbackResponseMap).to receive(:where).with(reviewed_object_id: 1, reviewer_id: 1).and_return([])
params = {id: 1, participant_id: 1}
session = {user: instructor}
get :new_feedback, params, session
expect(response).to redirect_to('/response/new?id=2&participant_id=1&return=feedback')
end
end

describe '#feedback' do
it 'returns corrsponding author feedback responses given by current participant' do
allow(FeedbackResponseMap).to receive(:get_feedback_assessments_for).with(participant.team).and_return([response])
expect(participant.feedback).to eq([response])
end
end

File:Grades-view.png

2018-11-14T20:05:57Z

Syu10:

File:Response-view-2.png

2018-11-14T20:04:40Z

Syu10:

File:Response-view-1.png

2018-11-14T19:59:30Z

Syu10:

CSC/E1869 GRADING AUDIT TRAIL

2018-11-14T02:51:46Z

Syu10: