Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T04:29:57Z

Speredd:

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Design Pattern''' ==
Design patterns are not applicable as our task involved just modification of existing methods.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background:===
An instructor can edit an assignment and can choose whether to have metareview in it or not. He can do so by following the below steps:

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===

As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to the below two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb file:

There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. The code snippet below shows the existing code:

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on click of the 'Use metareview deadline' checkbox. Now we implemented two new functions which are invoked inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox, the new code will invoke the 'removeOrAddMetareview()' function which indirectly invokes the two new functions.
Now let us look at the implementation of the two new functions, we used a local storage variable called 'meta'.So based on the status of the checkbox a value is assigned to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and if the 'Use metareview deadline' checkbox is Unchecked we assign with the value 'hide' to the local storage variable. Now after storing the respective values for the local storage variable, the storage event is triggered by these functions. The below code snippet shows the implementation of the two new functions:

[[File:Metareview3.PNG]]

In _review_strategy.html.erb file:

Small modifications have been made to the existing code that is the display of the table row with id 'meta' is given 'none' by default and also the status of the 'Has Meta-review Limit?' checkbox is changed to false. The below code snippet shows the modifications made:

[[File:Metareview5.PNG]]

we wrote a javascript code that handles the event triggered when the 'Use metareview deadline' checkbox has been checked or unchecked. In this javascript, the event triggered is handled by calling the 'onStorageEvent(storageEvent)' function. In this 'onStorageEvent' function we check the value in the local storage variable and based on that value we change the status of the display for the table row with id 'meta'.

[[File:Metareview4.PNG]]

Finally, the null value to the 'Has Meta-review Limit?' can be assigned during the creation of the table and on clicking the 'Has Meta-review Limit?' checkbox the UI displays '3' in the allowed number of metareviews that is num_metareviews_allowed variable is assigned '3'.

===Test Plan===
1. Ensure that when an assignment is created, the number of meta-reviews is set to null.

2. Ensure that the meta-review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in the Due dates tab.

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T04:25:36Z

Speredd: /* Issue3 */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background:===
An instructor can edit an assignment and can choose whether to have metareview in it or not. He can do so by following the below steps:

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===

As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to the below two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb file:

There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. The code snippet below shows the existing code:

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on click of the 'Use metareview deadline' checkbox. Now we implemented two new functions which are invoked inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox, the new code will invoke the 'removeOrAddMetareview()' function which indirectly invokes the two new functions.
Now let us look at the implementation of the two new functions, we used a local storage variable called 'meta'.So based on the status of the checkbox a value is assigned to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and if the 'Use metareview deadline' checkbox is Unchecked we assign with the value 'hide' to the local storage variable. Now after storing the respective values for the local storage variable, the storage event is triggered by these functions. The below code snippet shows the implementation of the two new functions:

[[File:Metareview3.PNG]]

In _review_strategy.html.erb file:

Small modifications have been made to the existing code that is the display of the table row with id 'meta' is given 'none' by default and also the status of the 'Has Meta-review Limit?' checkbox is changed to false. The below code snippet shows the modifications made:

[[File:Metareview5.PNG]]

we wrote a javascript code that handles the event triggered when the 'Use metareview deadline' checkbox has been checked or unchecked. In this javascript, the event triggered is handled by calling the 'onStorageEvent(storageEvent)' function. In this 'onStorageEvent' function we check the value in the local storage variable and based on that value we change the status of the display for the table row with id 'meta'.

[[File:Metareview4.PNG]]

Finally, the null value to the 'Has Meta-review Limit?' can be assigned during the creation of the table and on clicking the 'Has Meta-review Limit?' checkbox the UI displays '3' in the allowed number of metareviews that is num_metareviews_allowed variable is assigned '3'.

===Test Plan===
1. Ensure that when an assignment is created, the number of meta-reviews is set to null.

2. Ensure that the meta-review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in the Due dates tab.

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T04:22:01Z

Speredd: /* Issue3 */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background:===
An instructor can edit an assignment and can choose whether to have metareview in it or not. He can do so by following the below steps:

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===

As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to the below two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb file:

There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. The code snippet below shows the existing code:

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on click of the 'Use metareview deadline' checkbox. Now we implemented two new functions which are invoked inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox, the new code will invoke the 'removeOrAddMetareview()' function which indirectly invokes the two new functions.
Now let us look at the implementation of the two new functions, we used a local storage variable called 'meta'.So based on the status of the checkbox a value is assigned to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and if the 'Use metareview deadline' checkbox is Unchecked we assign with the value 'hide' to the local storage variable. Now after storing the respective values for the local storage variable, the storage event is triggered by these functions. The below code snippet shows the implementation of the two new functions:

[[File:Metareview3.PNG]]

In _review_strategy.html.erb:

Small modifications have been made to the existing code that is the display of the table row with id 'meta' is given 'none' by default and also the status of the 'Has Meta-review Limit?' checkbox is changed to false. The below code snippet shows the modifications made:

[[File:Metareview5.PNG]]

we wrote a javascript code that handles the event triggered when the 'Use metareview deadline' checkbox has been checked or unchecked. In this javascript, the event triggered is handled by calling the 'onStorageEvent(storageEvent)' function. In this 'onStorageEvent' function we check the value in the local storage variable and based on that value we change the status of the display for the table row with id 'meta'.

[[File:Metareview4.PNG]]

Finally, the null value to the 'Has Meta-review Limit?' can be assigned during the creation of the table and on clicking the 'Has Meta-review Limit?' checkbox the UI displays '3' in the allowed number of metareviews that is num_metareviews_allowed variable is assigned '3'.

===Test Plan===
1. Ensure that when an assignment is created, the number of meta-reviews is set to null.

2. Ensure that the meta-review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in the Due dates tab.

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T04:20:25Z

Speredd: /* Solution and Code Modification */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background:===
An instructor can edit an assignment and can choose whether to have metareview in it or not. He can do so by following the below steps:

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===

As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to the below two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb file:

There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. The code snippet below shows the existing code:

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on click of the 'Use metareview deadline' checkbox. Now we implemented two new functions which are invoked inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox, the new code will invoke the 'removeOrAddMetareview()' function which indirectly invokes the two new functions.
Now let us look at the implementation of the two new functions, we used a local storage variable called 'meta'.So based on the status of the checkbox a value is assigned to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and if the 'Use metareview deadline' checkbox is Unchecked we assign with the value 'hide' to the local storage variable. Now after storing the respective values for the local storage variable, the storage event is triggered by these functions. The below code snippet shows the implementation of the two new functions:

[[File:Metareview3.PNG]]

In _review_strategy.html.erb:

Small modifications have been made to the existing code that is the display of the table row with id 'meta' is given 'none' by default and also the status of the 'Has Meta-review Limit?' checkbox is changed to false. The below code snippet shows the modifications made:

[[File:Metareview5.PNG]]

we wrote a javascript code that handles the event triggered when the 'Use metareview deadline' checkbox has been checked or unchecked. In this javascript, the event triggered is handled by calling the 'onStorageEvent(storageEvent)' function. In this 'onStorageEvent' function we check the value in the local storage variable and based on that value we change the status of the display for the table row with id 'meta'.

[[File:Metareview4.PNG]]

Finally, the null value to the 'Has Meta-review Limit?' can be assigned during the creation of the table and on clicking the 'Has Meta-review Limit?' checkbox the UI displays '3' in the allowed number of metareviews.

===Test Plan===
1. Ensure that when an assignment is created, the number of meta-reviews is set to null.

2. Ensure that the meta-review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in the Due dates tab.

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T04:17:41Z

Speredd: /* Test Plan */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background:===
An instructor can edit an assignment and can choose whether to have metareview in it or not. He can do so by following the below steps:

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===

As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to the below two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb file:

There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. The code snippet below shows the existing code:

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on click of the 'Use metareview deadline' checkbox. Now we implemented two new functions which are invoked inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox, the new code will invoke the 'removeOrAddMetareview()' function which indirectly invokes the two new functions.
Now let us look at the implementation of the two new functions, we used a local storage variable called 'meta'.So based on the status of the checkbox a value is assigned to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and if the 'Use metareview deadline' checkbox is Unchecked we assign with the value 'hide' to the local storage variable. Now after storing the respective values for the local storage variable, the storage event is triggered by these functions. The below code snippet shows the implementation of the two new functions:

[[File:Metareview3.PNG]]

In _review_strategy.html.erb:

Small modifications have been made to the existing code that is the display of the table row with id 'meta' is given 'none' by default and also the status of the 'Has Meta-review Limit?' checkbox is changed to false. The below code snippet shows the modifications made:

[[File:Metareview5.PNG]]

we wrote a javascript code that handles the event triggered when the 'Use metareview deadline' checkbox has been checked or unchecked. In this javascript, the event triggered is handled by calling the 'onStorageEvent(storageEvent)' function. In this 'onStorageEvent' function we check the value in the local storage variable and based on that value we change the status of the display for the table row with id 'meta'.

[[File:Metareview4.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta-reviews is set to null.

2. Ensure that the meta-review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in the Due dates tab.

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T04:17:09Z

Speredd: /* Solution and Code Modification */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background:===
An instructor can edit an assignment and can choose whether to have metareview in it or not. He can do so by following the below steps:

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===

As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to the below two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb file:

There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. The code snippet below shows the existing code:

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on click of the 'Use metareview deadline' checkbox. Now we implemented two new functions which are invoked inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox, the new code will invoke the 'removeOrAddMetareview()' function which indirectly invokes the two new functions.
Now let us look at the implementation of the two new functions, we used a local storage variable called 'meta'.So based on the status of the checkbox a value is assigned to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and if the 'Use metareview deadline' checkbox is Unchecked we assign with the value 'hide' to the local storage variable. Now after storing the respective values for the local storage variable, the storage event is triggered by these functions. The below code snippet shows the implementation of the two new functions:

[[File:Metareview3.PNG]]

In _review_strategy.html.erb:

Small modifications have been made to the existing code that is the display of the table row with id 'meta' is given 'none' by default and also the status of the 'Has Meta-review Limit?' checkbox is changed to false. The below code snippet shows the modifications made:

[[File:Metareview5.PNG]]

we wrote a javascript code that handles the event triggered when the 'Use metareview deadline' checkbox has been checked or unchecked. In this javascript, the event triggered is handled by calling the 'onStorageEvent(storageEvent)' function. In this 'onStorageEvent' function we check the value in the local storage variable and based on that value we change the status of the display for the table row with id 'meta'.

[[File:Metareview4.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta-reviews is set to null.
2. Ensure that the meta-review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in the Due dates tab.

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T04:14:34Z

Speredd: /* Solution and Code Modification */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background:===
An instructor can edit an assignment and can choose whether to have metareview in it or not. He can do so by following the below steps:

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===

As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to the below two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb file:

There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. The code snippet below shows the existing code:

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on click of the 'Use metareview deadline' checkbox. Now we implemented two new functions which are invoked inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox, the new code will invoke the 'removeOrAddMetareview()' function which indirectly invokes the two new functions.
Now let us look at the implementation of the two new functions, we used a local storage variable called 'meta'.So based on the status of the checkbox a value is assigned to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and if the 'Use metareview deadline' checkbox is Unchecked we assign with the value 'hide' to the local storage variable. Now after storing the respective values for the local storage variable, the storage event is triggered by these functions. The below code snippet shows the implementation of the two new functions:

[[File:Metareview3.PNG]]

In _review_strategy.html.erb:

Small modifications have been made to the existing code that is the display of the table row with id 'meta' is given 'none' by default and also the status of the 'Has Meta-review Limit?' checkbox is changed to false. The below code snippet shows the modifications made:

[[File:Metareview4.PNG]]

we wrote a javascript code that handles the event triggered when the 'Use metareview deadline' checkbox has been checked or unchecked. In this javascript, the event triggered is handled by calling the 'onStorageEvent(storageEvent)' function. In this 'onStorageEvent' function we check the value in the local storage variable and based on that value we change the status of the display for the table row with id 'meta'.

[[File:Metareview5.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta-reviews is set to null.
2. Ensure that the meta-review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in the Due dates tab.

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T04:13:57Z

Speredd: /* Solution and Code Modification */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background:===
An instructor can edit an assignment and can choose whether to have metareview in it or not. He can do so by following the below steps:

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===

As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to the below two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb file:

There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. The code snippet below shows the existing code:

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on click of the 'Use metareview deadline' checkbox. Now we implemented two function calls which are invoked inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox, the new code will invoke the 'removeOrAddMetareview()' function which indirectly invokes the two new functions.
Now let us look at the implementation of the two new functions, we used a local storage variable called 'meta'.So based on the status of the checkbox a value is assigned to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and if the 'Use metareview deadline' checkbox is Unchecked we assign with the value 'hide' to the local storage variable. Now after storing the respective values for the local storage variable, the storage event is triggered by these functions. The below code snippet shows the implementation of the two new functions:

[[File:Metareview3.PNG]]

In _review_strategy.html.erb:

Small modifications have been made to the existing code that is the display of the table row with id 'meta' is given 'none' by default and also the status of the 'Has Meta-review Limit?' checkbox is changed to false. The below code snippet shows the modifications made:

[[File:Metareview4.PNG]]

we wrote a javascript code that handles the event triggered when the 'Use metareview deadline' checkbox has been checked or unchecked. In this javascript, the event triggered is handled by calling the 'onStorageEvent(storageEvent)' function. In this 'onStorageEvent' function we check the value in the local storage variable and based on that value we change the status of the display for the table row with id 'meta'.

[[File:Metareview5.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta-reviews is set to null.
2. Ensure that the meta-review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in the Due dates tab.

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T04:12:33Z

Speredd: /* Issue3 */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background:===
An instructor can edit an assignment and can choose whether to have metareview in it or not. He can do so by following the below steps:

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===

As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to the below two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb file:

There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. The code snippet below shows the existing code:

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on change of the status of the 'Use metareview deadline' checkbox. Now we implemented two function calls which are invoked inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox, the new code will invoke the 'removeOrAddMetareview()' function which indirectly invokes the two new functions.
Now let us look at the implementation of the two new functions, we used a local storage variable called 'meta'.So based on the status of the checkbox a value is assigned to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and if the 'Use metareview deadline' checkbox is Unchecked we assign with the value 'hide' to the local storage variable. Now after storing the respective values for the local storage variable, the storage event is triggered by these functions. The below code snippet shows the implementation of the two new functions:

[[File:Metareview3.PNG]]

In _review_strategy.html.erb:

Small modifications have been made to the existing code that is the display of the table row with id 'meta' is given 'none' by default and also the status of the 'Has Meta-review Limit?' checkbox is changed to false. The below code snippet shows the modifications made:

[[File:Metareview4.PNG]]

we wrote a javascript code that handles the event triggered when the 'Use metareview deadline' checkbox has been checked or unchecked. In this javascript, the event triggered is handled by calling the 'onStorageEvent(storageEvent)' function. In this 'onStorageEvent' function we check the value in the local storage variable and based on that value we change the status of the display for the table row with id 'meta'.

[[File:Metareview5.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta-reviews is set to null.
2. Ensure that the meta-review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in the Due dates tab.

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T04:06:41Z

Speredd: /* Solution and Code Modification */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
An instructor can edit an assignment and chose whether to have metareview in it or not. He can do so by navigating to

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===
As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb:

There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. The code snippet below shows the existing code:

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on change of the status of the 'Use metareview deadline' checkbox. Now we implemented two function calls which are invoked inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox, the new code will invoke the removeOrAddMetareview()' function which indirectly invokes the two new functions.
Now let us look at the implementation of the two new functions, we used a local storage variable called 'meta'.So based on the status of the checkbox a value is assigned to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and if the 'Use metareview deadline' checkbox is Unchecked we assign with the value 'hide' to the local storage variable. Now after storing the respective values for the local storage variable, the storage event is triggered by these functions. The below code snippet shows the implementation of the two new functions.

[[File:Metareview3.PNG]]

In _review_strategy.html.erb:

Small modifications have been made to the existing code that is the display of the table row with id 'meta' is given none by default and also the status of the 'Has Meta-review Limit?' checkbox is changed to false. The below code snippet shows the modifications made:

[[File:Metareview4.PNG]]

we wrote a javascript code that handles the event triggered when the 'Use metareview deadline' checkbox has been checked or unchecked. In this javascript, the event triggered is handled by calling the 'onStorageEvent(storageEvent)' function. In this onStorageEvent function we check the value in the local storage variable and based on that value we change the status of the display for the table row with id 'meta'.
[[File:Metareview5.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T03:50:11Z

Speredd: /* Solution and Code Modification */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
An instructor can edit an assignment and chose whether to have metareview in it or not. He can do so by navigating to

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===
As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb:

There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. The code snippet below shows the existing code:

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on change of the status of the 'Use metareview deadline' checkbox. Now we implemented two function calls which are invoked inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox will invoke the removeOrAddMetareview()' function which indirectly invokes the two new functions.
Now let us look at the implementation of the two new functions, we used a local storage variable called 'meta'.So based on the status of the checkbox a value is assigned to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and if the 'Use metareview deadline' checkbox is Unchecked we assign with the value 'hide'.
Now after storing the respective values, the storage event is triggered by these functions. The below code snippet shows the implementation of the two new functions.

[[File:Metareview3.PNG]]

[[File:Metareview4.PNG]]
[[File:Metareview5.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T03:42:26Z

Speredd: /* Solution and Code Modification */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
An instructor can edit an assignment and chose whether to have metareview in it or not. He can do so by navigating to

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===
As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb: There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. We made use of this function to call two new functions. The code snippet below shows the existing code

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on change of the status of the 'Use metareview deadline' checkbox. Now there are two function calls written inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox will invoke the removeOrAddMetareview()' function which indirectly invokes the two new functions. Now looking at the implementation of the two new functions, we use a local storage variable called 'meta' so based on the status of the checkbox value is given to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and vice versa.
[[File:Metareview3.PNG]]
[[File:Metareview4.PNG]]
[[File:Metareview5.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T03:41:36Z

Speredd: /* Solution and Code Modification */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
An instructor can edit an assignment and chose whether to have metareview in it or not. He can do so by navigating to

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===
As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb

2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb: There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is invoked. We made use of this function to call two new functions. The code snippet below shows the existing code

[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on change of the status of the 'Use metareview deadline' checkbox. Now there are two function calls written inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet

[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox will invoke the removeOrAddMetareview()' function which indirectly invokes the two new functions. Now looking at the implementation of the two new functions, we use a local storage variable called 'meta' so based on the status of the checkbox value is given to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and vice versa.
[[File:Metareview3.PNG]]
[[File:Metareview4.PNG]]
[[File:Metareview5.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T03:40:35Z

Speredd: /* Solution and Code Modification */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
An instructor can edit an assignment and chose whether to have metareview in it or not. He can do so by navigating to

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===
As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic, so we used the concept of local storage and event listener.

we have made changes to two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb
2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb: There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is called. We made use of this function to call two new functions. The code snippet below shows the existing code
[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on change of the status of the 'Use metareview deadline' checkbox. Now there are two function calls written inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet
[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox will invoke the removeOrAddMetareview()' function which indirectly invokes the two new functions. Now looking at the implementation of the two new functions, we use a local storage variable called 'meta' so based on the status of the checkbox value is given to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and vice versa.
[[File:Metareview3.PNG]]
[[File:Metareview4.PNG]]
[[File:Metareview5.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T03:39:20Z

Speredd: /* Issue3 */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
An instructor can edit an assignment and chose whether to have metareview in it or not. He can do so by navigating to

1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===
As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic so we used the concept of local storage and event listener.

we have made changes to two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb
2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb: There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is called. We made use of this function to call two new functions. The code snippet below shows the existing code
[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on change of the status of the 'Use metareview deadline' checkbox. Now there are two function calls written inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet
[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox will invoke the removeOrAddMetareview()' function which indirectly invokes the two new functions. Now looking at the implementation of the two new functions, we use a local storage variable called 'meta' so based on the status of the checkbox value is given to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and vice versa.
[[File:Metareview3.PNG]]
[[File:Metareview4.PNG]]
[[File:Metareview5.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T03:38:26Z

Speredd:

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===
As the checkbox and the content to be displayed on clicking the checkbox are located on different pages we cannot use the regular checkbox logic so we used the concept of local storage and event listener.

we have made changes to two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb
2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb: There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is called. We made use of this function to call two new functions. The code snippet below shows the existing code
[[File:Metareview1.PNG]]

The 'removeOrAddMetareview()' is called on change of the status of the 'Use metareview deadline' checkbox. Now there are two function calls written inside this function they are 'hideMetaReviewLimit()' and 'showMetaReviewLimit()'. This can be seen in the below code snippet
[[File:Metareview2.PNG]]

Now on clicking the 'Use metareview deadline' checkbox will invoke the removeOrAddMetareview()' function which indirectly invokes the two new functions. Now looking at the implementation of the two new functions, we use a local storage variable called 'meta' so based on the status of the checkbox value is given to the local storage variable. For example, if the 'Use metareview deadline' checkbox is checked then the local storage variable is initialized with the value 'show' and vice versa.
[[File:Metareview3.PNG]]
[[File:Metareview4.PNG]]
[[File:Metareview5.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T03:28:08Z

Speredd:

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===
As the checkbox and the content to be displayed on clicking the checkbox we used the concept of local storage and event listener.

we have made changes to two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb
2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb: There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is called. We made use of this function to call two new functions.

[[File:Metareview1.PNG]]
[[File:Metareview2.PNG]]
[[File:Metareview3.PNG]]
[[File:Metareview4.PNG]]
[[File:Metareview5.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

File:Metareview5.PNG

2019-12-06T03:27:19Z

Speredd:

File:Metareview4.PNG

2019-12-06T03:27:06Z

Speredd:

File:Metareview3.PNG

2019-12-06T03:26:38Z

Speredd:

File:Metareview2.PNG

2019-12-06T03:26:20Z

Speredd:

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T03:25:58Z

Speredd:

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===
As the checkbox and the content to be displayed on clicking the checkbox we used the concept of local storage and event listener.

we have made changes to two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb
2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb: There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is called. We made use of this function to call two new functions.

[[File:Metareview1.PNG]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T03:23:47Z

Speredd:

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===
As the checkbox and the content to be displayed on clicking the checkbox we used the concept of local storage and event listener.

we have made changes to two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb
2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb: There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is called. We made use of this function to call two new functions.

[[File:Metareview1.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T03:23:05Z

Speredd:

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===
As the checkbox and the content to be displayed on clicking the checkbox we used the concept of local storage and event listener.

we have made changes to two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb
2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb: There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is called. We made use of this function to call two new functions.

[[File:metareview1.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

File:Metareview1.PNG

2019-12-06T03:21:53Z

Speredd:

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T03:18:27Z

Speredd: /* Issue3 */

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meta-review deadline below.

3) Under the “Review Strategy” tab of edit assignment, the instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta-reviews are not enabled for that assignment. The checkbox is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting it.

===Solution and Code Modification===
As the checkbox and the content to be displayed on clicking the checkbox we used the concept of local storage and event listener.

we have made changes to two files:

1)/expertiza/app/views/assignments/edit/_due_dates.html.erb
2)/expertiza/app/views/assignments/edit/_review_strategy.html.erb

In the _due_dates.html.erb: There is an existing code where on clicking the checkbox 'Use metareview deadline', a function called 'removeOrAddMetareview()' is called. We made use of this function to call two new functions.

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-12-06T03:07:28Z

Speredd:

== '''Overview of Project''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
1. Log in as instructor6, click on Manage...-> Assignments

2. Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox

3. Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types

4. Navigate back to Assignment Tree View and click on "Add participant"

5. Add couple of students(say student1 and student2) to the assignment

6. Impersonate/login as student1 and make a submission

7. Impersonate/login as student2 and Request for a new review under others work, submit the review

8. Impersonate/login back as student1 and Request for a new meta review

9. When Begin is clicked following will be displayed 

[[File:Expertiza project3 Issue1 E1997.png]]

10. A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement the above two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==
===Background===
1) From Manage>Assignments, click on the Edit Assignment button for the appropriate assignment.

2) On the Due Date tab, the instructor can select if (s)he wants to have meta-reviews done for the assignment, by clicking on the “Use meta-review deadline” checkbox and setting a meat-review deadline below. Refer to below image

3) Under the “Review Strategy” tab of edit assignment, instructor can set Allowed and Required number of meta-reviews per reviewer by checking the Has meta-review Limit? checkbox.(refer to below image)

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta reviews are not enabled for that assignment. The check box is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting.

===Design strategy===
A boolean style variable, named say 'isMetaEnabled' which reflects the metareview enabled/disabled status is needed. When user checks 'Use metareview deadline' in Due dates tab, the isMetaEnabled will be set to true and vice versa.

This isMetaEnabled shall reside and gets initialized to 'True'(metareview enabled) in the assignments_controller.rb
When user toggles the checkbox, the isMetaEnabled value shall be toggled accordingly.

In the Review Strategy tab, the metareview fields(3 of them) are conditioned to be displayed only if isMetaEnabled is set to true.

Pictorial representation of above explanation

[[File:issue3_design.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-11T21:40:03Z

Speredd: /* Design strategy For Issue1 and Issue 2 */

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-11T21:39:20Z

Speredd: /* Problem Background */

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-11T21:38:09Z

Speredd: /* Problem statement */

== '''Problem Background''' ==

In Expertiza, meta-review is a feature that enables a third party to evaluate the quality of feedback that a reviewer gives a reviewee. meta-review is an important feature that can help students become better reviewers for their peers by providing detailed feedback that is actionable and positively formulated. Unfortunately, this feature is broken and the following issues were identified.

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
<li>Log in as instructor6, click on manage...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked following will be displayed 
[[File:Expertiza project3 Issue1 E1997.png]]
<li>A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement these two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta reviews are not enabled for that assignment. The check box is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting.

===Design strategy===
A boolean style variable, named say 'isMetaEnabled' which reflects the metareview enabled/disabled status is needed. When user checks 'Use metareview deadline' in Due dates tab, the isMetaEnabled will be set to true and vice versa.

This isMetaEnabled shall reside and gets initialized to 'True'(metareview enabled) in the assignments_controller.rb
When user toggles the checkbox, the isMetaEnabled value shall be toggled accordingly.

In the Review Strategy tab, the metareview fields(3 of them) are conditioned to be displayed only if isMetaEnabled is set to true.

Pictorial representation of above explanation

[[File:issue3_design.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-11T21:37:07Z

Speredd: /* Design strategy For Issue1 and Issue 2 */

== '''Problem statement''' ==

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
<li>Log in as instructor6, click on manage...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked following will be displayed 
[[File:Expertiza project3 Issue1 E1997.png]]
<li>A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

The flow chart below describes the design we choose to implement these two issues

[[File:E1997_1.PNG]]

== '''Issue3''' ==

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta reviews are not enabled for that assignment. The check box is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting.

===Design strategy===
A boolean style variable, named say 'isMetaEnabled' which reflects the metareview enabled/disabled status is needed. When user checks 'Use metareview deadline' in Due dates tab, the isMetaEnabled will be set to true and vice versa.

This isMetaEnabled shall reside and gets initialized to 'True'(metareview enabled) in the assignments_controller.rb
When user toggles the checkbox, the isMetaEnabled value shall be toggled accordingly.

In the Review Strategy tab, the metareview fields(3 of them) are conditioned to be displayed only if isMetaEnabled is set to true.

Pictorial representation of above explanation

[[File:issue3_design.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-11T21:31:57Z

Speredd:

== '''Problem statement''' ==

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Test Plan===
<li>Log in as instructor6, click on manage...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked following will be displayed 
[[File:Expertiza project3 Issue1 E1997.png]]
<li>A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Design strategy For Issue1 and Issue 2''' ==

[[File:E1997_1.PNG]]

== '''Issue3''' ==

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta reviews are not enabled for that assignment. The check box is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting.

===Design strategy===
A boolean style variable, named say 'isMetaEnabled' which reflects the metareview enabled/disabled status is needed. When user checks 'Use metareview deadline' in Due dates tab, the isMetaEnabled will be set to true and vice versa.

This isMetaEnabled shall reside and gets initialized to 'True'(metareview enabled) in the assignments_controller.rb
When user toggles the checkbox, the isMetaEnabled value shall be toggled accordingly.

In the Review Strategy tab, the metareview fields(3 of them) are conditioned to be displayed only if isMetaEnabled is set to true.

Pictorial representation of above explanation

[[File:issue3_design.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-11T21:30:21Z

Speredd:

== '''Problem statement''' ==

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on manage...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked following will be displayed 
[[File:Expertiza project3 Issue1 E1997.png]]
<li>A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

[[File:E1997_1.PNG]]

== '''Issue3''' ==

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta reviews are not enabled for that assignment. The check box is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting.

===Design strategy===
A boolean style variable, named say 'isMetaEnabled' which reflects the metareview enabled/disabled status is needed. When user checks 'Use metareview deadline' in Due dates tab, the isMetaEnabled will be set to true and vice versa.

This isMetaEnabled shall reside and gets initialized to 'True'(metareview enabled) in the assignments_controller.rb
When user toggles the checkbox, the isMetaEnabled value shall be toggled accordingly.

In the Review Strategy tab, the metareview fields(3 of them) are conditioned to be displayed only if isMetaEnabled is set to true.

Pictorial representation of above explanation

[[File:issue3_design.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

File:E1997 1.PNG

2019-11-11T21:28:27Z

Speredd: MetaReview

MetaReview

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-11T21:26:26Z

Speredd:

== '''Problem statement''' ==

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on manage...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked following will be displayed 
[[File:Expertiza project3 Issue1 E1997.png]]
<li>A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Issue3''' ==

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta reviews are not enabled for that assignment. The check box is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting.

===Design strategy===
A boolean style variable, named say 'isMetaEnabled' which reflects the metareview enabled/disabled status is needed. When user checks 'Use metareview deadline' in Due dates tab, the isMetaEnabled will be set to true and vice versa.

This isMetaEnabled shall reside and gets initialized to 'True'(metareview enabled) in the assignments_controller.rb
When user toggles the checkbox, the isMetaEnabled value shall be toggled accordingly.

In the Review Strategy tab, the metareview fields(3 of them) are conditioned to be displayed only if isMetaEnabled is set to true.

Pictorial representation of above explanation

[[File:issue3_design.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-11T21:25:53Z

Speredd: /* Files to be modified */

== '''Problem statement''' ==

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on manage...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked following will be displayed 
[[File:Expertiza project3 Issue1 E1997.png]]
<li>A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

[[File:issue12.png]]

== '''Issue3''' ==

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta reviews are not enabled for that assignment. The check box is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting.

===Design strategy===
A boolean style variable, named say 'isMetaEnabled' which reflects the metareview enabled/disabled status is needed. When user checks 'Use metareview deadline' in Due dates tab, the isMetaEnabled will be set to true and vice versa.

This isMetaEnabled shall reside and gets initialized to 'True'(metareview enabled) in the assignments_controller.rb
When user toggles the checkbox, the isMetaEnabled value shall be toggled accordingly.

In the Review Strategy tab, the metareview fields(3 of them) are conditioned to be displayed only if isMetaEnabled is set to true.

Pictorial representation of above explanation

[[File:issue3_design.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-11T21:25:33Z

Speredd: /* Files to be modified */

== '''Problem statement''' ==

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on manage...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked following will be displayed 
[[File:Expertiza project3 Issue1 E1997.png]]
<li>A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

[[File:issue12.png|200px|thumb|left|alt text]]

== '''Issue3''' ==

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta reviews are not enabled for that assignment. The check box is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting.

===Design strategy===
A boolean style variable, named say 'isMetaEnabled' which reflects the metareview enabled/disabled status is needed. When user checks 'Use metareview deadline' in Due dates tab, the isMetaEnabled will be set to true and vice versa.

This isMetaEnabled shall reside and gets initialized to 'True'(metareview enabled) in the assignments_controller.rb
When user toggles the checkbox, the isMetaEnabled value shall be toggled accordingly.

In the Review Strategy tab, the metareview fields(3 of them) are conditioned to be displayed only if isMetaEnabled is set to true.

Pictorial representation of above explanation

[[File:issue3_design.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-11T21:24:27Z

Speredd:

== '''Problem statement''' ==

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on manage...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked following will be displayed 
[[File:Expertiza project3 Issue1 E1997.png]]
<li>A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

[[File:issue12.png]]

== '''Issue3''' ==

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta reviews are not enabled for that assignment. The check box is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting.

===Design strategy===
A boolean style variable, named say 'isMetaEnabled' which reflects the metareview enabled/disabled status is needed. When user checks 'Use metareview deadline' in Due dates tab, the isMetaEnabled will be set to true and vice versa.

This isMetaEnabled shall reside and gets initialized to 'True'(metareview enabled) in the assignments_controller.rb
When user toggles the checkbox, the isMetaEnabled value shall be toggled accordingly.

In the Review Strategy tab, the metareview fields(3 of them) are conditioned to be displayed only if isMetaEnabled is set to true.

Pictorial representation of above explanation

[[File:issue3_design.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

File:Issue12.PNG

2019-11-11T21:23:21Z

Speredd: E1997

E1997

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-11T21:21:16Z

Speredd: /* Files to be modified */

== '''Problem statement''' ==

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on manage...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked following will be displayed 
[[File:Expertiza project3 Issue1 E1997.png]]
<li>A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

== '''Issue3''' ==

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta reviews are not enabled for that assignment. The check box is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting.

===Design strategy===
A boolean style variable, named say 'isMetaEnabled' which reflects the metareview enabled/disabled status is needed. When user checks 'Use metareview deadline' in Due dates tab, the isMetaEnabled will be set to true and vice versa.

This isMetaEnabled shall reside and gets initialized to 'True'(metareview enabled) in the assignments_controller.rb
When user toggles the checkbox, the isMetaEnabled value shall be toggled accordingly.

In the Review Strategy tab, the metareview fields(3 of them) are conditioned to be displayed only if isMetaEnabled is set to true.

Pictorial representation of above explanation

[[File:issue3_design.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-11T21:20:50Z

Speredd:

== '''Problem statement''' ==

== '''Issue1''' ==

===Issue Description===
When a user requests a new meta-review, (s)he should be able to click on the Begin button, which should redirect him/her to the meta-review questionnaire and when the user returns back (to the page where he can view the reviews and meta-reviews, by clicking on Others’ work in his/her assignment), (s)he should be then able to see view and update links for the meta-reviews (s)he has performed.

But the issue is Begin and Edit are not working for the given scenario.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on manage...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all of the following: Submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked following will be displayed 
[[File:Expertiza project3 Issue1 E1997.png]]
<li>A template must be added to fix the broken link

===Files to be modified===
response.html.erb

== '''Issue2''' ==

===Issue Description===
The number of meta-reviews(refer to the snapshot below),should decrease when a user requests a meta-review.Also, the button to request a new meta-review should not disappear until the total number of reviews assigned has reached the allowed limit.

===Design strategy===

===Test Plan===
<li>Log in as instructor6, click on mange...-> Assignments
<li>Click on edit assignment, navigate to Due Dates and check "Use meta-review deadline" checkbox
<li>Select "Yes" for all submission allowed, Review allowed and Meta-review allowed in all of the deadline types
<li>Navigate back to Assignment Tree View and click on "Add participant"
<li>Add couple of students(say student1 and student2) to the assignment
<li>Impersonate/login as student1 and make a submission
<li>Impersonate/login as student2 and Request for a new review under others work, submit the review
<li>Impersonate/login back as student1 and Request for a new meta review
<li>When Begin is clicked, the meta-review count should be decremented

===Files to be modified===
<li>List.html.erb

[[File:OODD.png]]

== '''Issue3''' ==

===Issue Description===
For an assignment, when 'Use Metareview Deadline' is unchecked, it means meta reviews are not enabled for that assignment. The check box is as below

[[File:issue3_1.png]]

As said, when this box is unchecked, it means there is no meta reviewing system for this assignment. The issue is, there are some meta review related fields that show up even if the above box is unchecked. Like in below image

[[File:issue3_2.png]]

Also, when a new issue is created, the default # of meta-reviews allowed and required should be null. As soon as someone checks the Has meta-review Limit box on the “Review Strategy” tab, the UI should fill in 3 and 3 as the required and allowed number. Of course, the user can change this number before submitting.

===Design strategy===
A boolean style variable, named say 'isMetaEnabled' which reflects the metareview enabled/disabled status is needed. When user checks 'Use metareview deadline' in Due dates tab, the isMetaEnabled will be set to true and vice versa.

This isMetaEnabled shall reside and gets initialized to 'True'(metareview enabled) in the assignments_controller.rb
When user toggles the checkbox, the isMetaEnabled value shall be toggled accordingly.

In the Review Strategy tab, the metareview fields(3 of them) are conditioned to be displayed only if isMetaEnabled is set to true.

Pictorial representation of above explanation

[[File:issue3_design.png]]

===Test Plan===
1. Ensure that when an assignment is created, the number of meta reviews is set to null.
2. Ensure that the meta review fields in the review strategy tab are visible only when 'Use metareview deadline' is enabled in Due dates tab.

===Files to be modified===
1. _review_strategy.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_review_strategy.html.erb

2. _due_dates.html.erb
Source file: https://github.com/expertiza/expertiza/blob/master/app/views/assignments/edit/_due_dates.html.erb

3. assignments_controller.rb
Source file: https://github.com/expertiza/expertiza/blob/master/app/controllers/assignments_controller.rb

File:OODD.PNG

2019-11-11T21:18:38Z

Speredd: CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-10T21:44:36Z

Speredd:

== '''Problem statement''' ==

== '''Issue1''' ==

===Issue Description===

===Design strategy===

===Test Plan===

===Files to be modified===

== '''Issue2''' ==

===Issue Description===

===Design strategy===

===Test Plan===

===Files to be modified===

== '''Issue3''' ==

===Issue Description===

===Design strategy===

===Test Plan===

===Files to be modified===

CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing

2019-11-10T21:41:50Z

Speredd: Created page with "== '''Problem statement''' == == '''Issue1''' == === Design strategy ==="

== '''Problem statement''' ==

== '''Issue1''' ==

=== Design strategy ===

CSC/ECE 517 Fall 2019

2019-11-10T21:40:43Z

Speredd:

* [[CSC/ECE 517 Fall 2019 - Project E1947. Refactor quiz_questionnaire_controller.rb]]
* [[CSC/ECE 517 Fall 2019 - Project E1965. Review report should link to the usual view for reviews]]
* [[CSC/ECE 517 Fall 2019 - Project E1943. Refactor sign up sheet controller.rb]]
* [[CSC/ECE 517 Fall 2019 - E1972. OSS project J. Skellington: Accessing Assignment Rubrics]]
* [[CSC/ECE 517 Fall 2019 - E1961. Email notification to reviewers and instructors]]
* [[CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions]]
* [[CSC/ECE 517 Fall 2019 - E1953. Tagging report for student]]
* [[CSC/ECE 517 Fall 2019 - E1955.Write unit tests for student_task.rb]]
* [[CSC/ECE 517 Fall 2019 - E1954. Auto-generate submission directory names based on assignment names]]
* [[CSC/ECE 517 Fall 2019 - E1958. Two issues related to assignment management]]
* [[CSC/ECE 517 Fall 2019 - E1948. Refactor review_mapping_helper.rb]]
* [[CSC/ECE 517 Fall 2019 - E1959. Intelligent copying of assignments without topics]]
* [[CSC/ECE 517 Fall 2019 - E1968. Fixes for adding members to teams]]
* [[CSC/ECE 517 Fall 2019 - E1969. Fixes for reviews not being available]]
* [[CSC/ECE 517 Fall 2019 - E1951. Remove multiple topics at a time]]
* [[CSC/ECE 517 Fall 2019 - E1957. Time travel Not Allowed..!!! Restrict TAs’ ability to change their own grade + limit file-size upload]]
* [[CSC/ECE 517 Fall 2019 - E1963. Changing assignment participant role]]
* [[CSC/ECE 517 Fall 2019 - E1941. Issues related to topic deadlines]]
* [[CSC/ECE 517 Fall 2019 - E1966. Tabbed_reviews partial file refactor for displaying the alternate view of reviews]]
* [[CSC/ECE 517 Fall 2019 - E1962. Email notification upon account creation]]
* [[CSC/ECE 517 Fall 2019 - E1967. Fix glitches in author feedback]]
* [[CSC/ECE 517 Fall 2019 - E1960. Create new late policy successfully and fixing "Back" link]]
* [[CSC/ECE 517 Fall 2019 - E1939. OSS Project Juniper: Bookmark enhancements]]
* [[CSC/ECE 517 Fall 2019 - M1950. Support Asynchronous Web Assembly Compilation]]
* [[CSC/ECE 517 Fall 2019 - E1938. OSS project Duke Blue: Fix import glitches]]
* [[CSC/ECE 517 Fall 2019 - M1951. Implement missing OffscreenCanvas APIs]]
* [[CSC/ECE 517 Fall 2019 - E1940. Improving email notification]]
* [[CSC/ECE 517 Fall 2019 - E1956. There is no shortcut to get free review points: Review Assignment Bug]]
* [[CSC/ECE 517 Fall 2019 - E1942. Refactor stage deadlines in assignment.rb]]
* [[CSC/ECE 517 Fall 2019 - M1952. Missing DOM features project]]
* [[CSC/ECE 517 Fall 2019 - E1945. Refactor users_controller.rb]]
* [[CSC/ECE 517 Fall 2019 - E1964. Export review scores for projects]]
* [[CSC/ECE 517 Fall 2019 - E1949. Write Unit Tests for Importing assignment participants and import glitches]]
* [[CSC/ECE 517 Fall 2019 - E1944. Refactor review mapping controller]]
* [[CSC/ECE 517 Fall 2019 - E1946. Refactor Questionnaire controller]]
* [[CSC/ECE 517 Fall 2019 - E1982. Regulate changing of rubrics while projects are in progress]]
* [[CSC/ECE 517 Fall 2019 - E1989. Track the time students look at other submissions]]
* [[CSC/ECE 517 Fall 2019 - E1990. Integrate suggestion detection algorithm]]
* [[CSC/ECE 517 Fall 2019 - E1995. Tests for email functionality]]
* [[CSC/ECE 517 Fall 2019 - E1993 Track Time Between Successive Tag Assignments]]
* [[CSC/ECE 517 Fall 2019 - E1979. Completion/Progress view]]
* [[CSC/ECE 517 Fall 2019 - E1995. Weights in grade calculation]]
* [[CSC/ECE 517 Fall 2019 - E1980. Sort instructor reports by name, ID, score, etc.]]
* [[CSC/ECE 517 Fall 2019 - E1984. Improve self-review Link peer review & self-review to derive grades]]
* [[CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics]]
* [[CSC/ECE 517 Fall 2019 - E1997. Issues related to meta-reviewing]]

CSC/ECE 517 Fall 2019 - E1959. Intelligent copying of assignments without topics

2019-11-06T22:41:52Z

Speredd:

== '''Introduction''' ==

[http://expertiza.ncsu.edu/ Expertiza] is an open source web application project developed using Ruby on Rails framework. Let us list some of the functionalities that Expertiza allows us to do under different roles:

As an Instructor:

We can create new assignments, edit the existing assignments, copy the assignments and also delete the assignment. The instructor can also add participants, reviewers to a particular assignment.

As a Student:

They can form teams to work on various projects and also bid for the projects they would like to work on. They can also review other student's work and can give feedback on them. They can also submit various types of documents including the URLs and wiki pages for their project or assignment submission.

=='''Design Pattern'''==
Design patterns are not applicable as our task involved just modification of existing methods.

== '''Problem Statement''' ==

===Background===
When an instructor or a TA logs in to expertiza, s(he) can see a list of assignments under the assignment tab. An instructor or a TA can copy an assignment to use the same event in another course or as another assignment. When the user copies the assignment, the assignment is being copied without providing required flexibility to the users. Majorly, we are focused on implementing two features that shall add flexibility to the copy functionality.

===Issues===
Issue 1:
While copying an assignment, the user (instructor or TA) is not asked whether they wants to copy the topics along with the assignment or not. Currently, it is copying the topics, without providing any choice for user to not have the topics.

Issue 2:
While copying an assignment, the teams/students assigned to each topic are not getting copied. The user might want to copy the teams/students mapped to the topics as well.

===Steps to generate the issue <Existing system, without our implementation> <Requires Instructor credentials>===
1) Login to expertiza.ncsu.edu using instructor credentials.

2) Navigate to Assignments section. (Hover on Manage Tab -> Click on Assignments)

3) Copy the assignment of your choice by clicking copy icon located on the right side of the specific assignment.

Above steps copy the assignment. Remember that this process did not give you the flexibility of choosing whether to copy/not copy.

1) Topics linked to assignment.

2) Students/Teams linked to each topic.

Present system copies the topics but doesn't copy the students, even if you don't want it this way. Our implementation is to provide the user with the functionality to choose to copy/not copy topics linked to an assignment and students/teams linked to each topic.

== '''Solution & Code Modification''' ==
We have modified 5 files and mainly we have modified code in two classes they are:
#apps/controllers/assignments_controller.rb and
#apps/models/assignment_form.rb.

=== Solution ===
So before we made any changes, the flow was, when an assignment is copied: <tt>def copy</tt> in controllers/assignments_controller.rb is called which calls a function <tt>def self.copy</tt> in models/assignment_form.rb. To solve the issue, we have created a new web page that is triggered on clicking the copy icon for the assignment. The view page is the checktopicscopy.html.erb under the views/assignments folder. This page asks the user to select from 3 options, which are:
#Copy without Topics. (Blank Assignment)
#Copy with Topics. (Assignment with only topics)
#Copy with Topics and Teams. (Assignment with topics and teams)

Based on the option chosen by the user, this option is passed by the <tt>def copy</tt> in controllers/assignments_controller.rb to <tt>def self.copy</tt> in models/assignment_form.rb.
<pre>
def checktopicscopy
@assignment_id = params[:id]
end
</pre>
<pre>
new_assign_id = AssignmentForm.copy(params[:id], params[:copyoption], @user) #Line 115 in original file has been updated to Line 119 in modified file.
</pre>

The <tt>def self.copy</tt> in models/assignment_form.rb now receives this value and creates a duplicate of the assignment without copying the teams and topics originally. If the user chosen the option to just copy a blank assignment (i.e. without the topics or teams, the execution does not enter into any of the <tt>if</tt> conditions. If the user wants to copy the assignment with only the topics (but not the teams), then it goes into the first <tt>if</tt> (Line 330 [refer code below]) and copies the topics as well but does not enter the next <tt>if</tt> (Line 335 [refer code below]). If the user wants to copy the assignment with the topics as well as the teams, the code will enter the first as well as the second <tt>if</tt> condition and copy the topics as well as the teams.
<pre>
def self.copy(assignment_id, copyoption, user) #Line 313 in the original file has been modified.

..... (Skipped Lines)

if copyoption != 'copyWithoutTopics' #Line 330 in modified file.
topics = SignUpTopic.where(assignment_id: old_assign.id)
topics.each do |topic|
new_sign_up_topic = SignUpTopic.create(
topic_name: topic.topic_name,
assignment_id: new_assign_id,
max_choosers: topic.max_choosers,
category: topic.category,
topic_identifier: topic.topic_identifier,
micropayment: topic.micropayment
)

if copyoption == 'copyWithTopicsTeams' #Line 335 in modified file.
old_signed_up_teams = SignedUpTeam.where(topic_id: topic.id)
old_signed_up_teams.each do |old_signed_up_team|
new_signed_up_team = old_signed_up_team.dup
new_signed_up_team.update_attribute('topic_id', new_sign_up_topic.id)
new_signed_up_team.save
end
end
end
</pre>

The code modifications and their coverage have been covered in the following section.

== '''Testing (Test Plan)''' ==

=== Automated Testing using RSpec ===

We have made changes to the test cases and both the models/assignment_form.rb and also the controllers/assignments_controller.rb have passed all the test cases. The tests can be executed <tt>rpec spec</tt> and the results for the 2 main files we have modified are shown below:
<pre>
#rspec ./spec/models/assignment_form_spec.rb
Finished in 1 minute 32.18 seconds (files took 20.22 seconds to load)
29 examples, 0 failures
.
.
.
#rspec ./spec/controllers/assignments_controller_spec.rb
Finished in 2 minutes 2.3 seconds (files took 1 minute 13.49 seconds to load)
23 examples, 0 failures
</pre>
See the detailed coverage report below.
 
'''1. models/assignment_form.rb'''
 In this file, the coverage has increased from 61.39% to 85.65% after modification.
 '''Original file:'''
[[File:Og_model_coverage.PNG]]
 '''Modified file:'''
[[File:new_model_coverage.PNG]]
 
In the modified file, the following code has been added,
<pre>
def self.copy(assignment_id, copyoption, user) #Line 313 in the original file has been modified.
</pre>
<pre>
if copyoption != 'copyWithoutTopics' #Line 330 in modified file.
topics = SignUpTopic.where(assignment_id: old_assign.id)
topics.each do |topic|
new_sign_up_topic = SignUpTopic.create(
topic_name: topic.topic_name,
assignment_id: new_assign_id,
max_choosers: topic.max_choosers,
category: topic.category,
topic_identifier: topic.topic_identifier,
micropayment: topic.micropayment
)

if copyoption == 'copyWithTopicsTeams'
old_signed_up_teams = SignedUpTeam.where(topic_id: topic.id)
old_signed_up_teams.each do |old_signed_up_team|
new_signed_up_team = old_signed_up_team.dup
new_signed_up_team.update_attribute('topic_id', new_sign_up_topic.id)
new_signed_up_team.save
end
end
end
</pre>
 
'''2. controllers/assignments_controller.rb'''
 In this file, the coverage has increased from 88.66% to 88.8% after modification.
 '''Original file:'''
[[File:Og_controller_coverage.PNG]]
 '''Modified file:'''
[[File:new_controller_coverage.PNG]]
 
In the modified file, the following code has been added,
<pre>
def checktopicscopy
@assignment_id = params[:id]
end
</pre>
<pre>
new_assign_id = AssignmentForm.copy(params[:id], params[:copyoption], @user) #Line 115 in original file has been updated to Line 119 in modified file.
</pre>

== Manual Testing from UI (For Reviewers) ==

By following the below stated process, you can test the implementation that we worked on, which is:
Target 1: Provide the user with the option to select copy/not copy topics linked to an assignment.
Target 2: Provide the user with the option to select copy/not copy students/teams linked to a topic.

'''Step 1''': Visit http://152.46.17.204:8080/ . Enter the credentials:
 Username: instructor6
 Password: password

'''Step 2''': On the top, hover on Manage tab. Click Assignments.

'''Step 3''': Choose an assignment that you want to copy. We would recommend you choosing a robust assignment that has Topics and students/teams associated with topics. OSS Projects generally have these. [Please make sure that you are under the Assignments tab or select the assignment besides the course]

If you want to check and see if an assignment has topics or not, click on Edit (pencil icon) on the right.
- If this assignment has topics, you will see a tab named Topics on the right of General tab. If there are no topics, you won't see Topics tab.
- On clicking the Topics tab, you can see the list of topics. If students/teams are assigned to topics, you will see student names (alias representations, like student1234 student2343) under each Topic name in 'Topic name(s) column'. If you don't see any such, it means that teams/students are not assigned to topics.

'''Step 4''': After you chose the assignment that you want to copy, click on the copy icon on the right of the corresponding assignment.

Where is the copy button located? Check the image below.
[[File: Copy oss.PNG|frame|center]]

'''Step 5''': Clicking the copy button will take you to copy options page, where you can select the options for copying. The page looks like this:
[[File: oss_copy6.PNG|frame|center]]

'''Step 6''': Choose the option you wish to test. Click create. Now the assignment shall be copied with the options you provided.

'''Step 7''': After copying, the application takes you to 'Edit' page for the assignment where you can edit/view the details pertaining to the assignment. Here, you can test our implementation.
In step 6, if you chose to

- copy without topics: You won't see 'Topics' tab near General tab.

- copy with topics: You will see 'Topics' tab near General tab(As shown in image below). Navigate to Topics tab where you can see and check that the respective topics have been copied. You won't see students under each topic in 'Topic Name(s)' column(If there are topics under Topics tab in original assignment from which you created this copy).

- copy with topics and students: You will see 'Topics' tab near General tab(As shown in image below). Navigate to Topics tab where you can see and check that the respective topics have been copied. You will see students under each topic in 'Topic Name(s)' column(If there are topics and students under Topics tab in original assignment from which you created this copy).

[[File: oss_copy7.PNG|frame|center]]

'''Step 8''': Please rename the assignment to some random string of your choice. Having it as 'Copy of'.. is creating issues of duplicate names when creating a new copy (more details in the section below, named 'Our Recommendation for a separate issue'. Not required for students). If not changed, the next tester might face difficulty while testing(which we don't want to see happening :)).

'''Step 9''': This completes the testing. Reiterate from step 2, if you wish to test again.

== '''Our Work''' ==
The code we created can be found below.
*[https://github.com/subhasekhar/expertiza GitHub Repository]
*[https://github.com/expertiza/expertiza/pull/1524 Pull Request]
*[http://152.46.17.204:8080/ Deployed URL]

The project could be run locally by cloning the [https://github.com/subhasekhar/expertiza GitHub Repository] and then running the following commands sequentially.

<pre>
bundle install
rake db:create:all
rake db:migrate
rails s
</pre>

== '''Our Recommendation for a Separate Issue''' (For Instructors only) ==

In the current system, we identified an issue and would like to bring it to your notice.

=== Existing System ===

When a user attempts to copy an assignment, the code creates a duplicate ‘assignment’ object, renames it as ‘copy of’ + <name of existing assignment>, saves the object and redirects to the ‘edit’ page where user is supposed to rename the assignment to something meaningful.

=== Issue ===

The current naming scheme as ‘copy of’ + <name of existing assignment> is creating an issue. Say you are creating a copy for some assignment named ‘OSS Project’, the copy object will be named as ‘copy of OSS Project’, saved and redirected to edit page. Had there been an existing assignment names ‘copy of OSS Project’ (which is likely), the copy attempt shall fail, putting a flash message on the screen like:

The assignment was not able to be copied. Please check the original assignment for missing information.

The above error message is in no relevance to the real reason for the error. Even though the save attempt failed, a copy is being inserted into the assignments table in the database.

=== Proposed Recommendation ===

Current naming scheme must be changed to have randomness. The name of the assignment can be given a random string, or a string like ‘copy of ’ + <name of existing assignment> + <5 digit random code>.

The user is anyway supposed to edit the information in the edit page (where the application is redirected after copying is successful). So, here, he can change the name to have some meaningful string.

== '''Team Information''' ==
# Sai Vishnu Muvvala (smuvval)
# Rohan Pillai (rspillai)
# Subha Sekhar Reddy Pereddy (speredd)

Mentor: Yashad Trivedi (ytrived)
 Professor: Dr. Edward F. Gehringer (efg)
 Special shoutout to TA Suraj Siddharudh (ssiddha) for clearing my doubts regarding RSpec Tests.
===References===

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://relishapp.com/rspec RSpec Documentation]

CSC/ECE 517 Fall 2019 - E1959. Intelligent copying of assignments without topics

2019-11-06T22:25:54Z

Speredd: /* Steps to generate the issue */

== '''Introduction''' ==

[http://expertiza.ncsu.edu/ Expertiza] is an open source web application project developed using Ruby on Rails framework. Let us list some of the functionalities that Expertiza allows us to do under different roles:

As an Instructor:

We can create new assignments, edit the existing assignments, copy the assignments and also delete the assignment. The instructor can also add participants, reviewers to a particular assignment.

As a Student:

They can form teams to work on various projects and also bid for the projects they would like to work on. They can also review other student's work and can give feedback on them. They can also submit various types of documents including the URLs and wiki pages for their project or assignment submission.

=='''Design Pattern'''==
Design patterns are not applicable as our task involved just modification of existing methods.

== '''Problem Statement''' ==

===Background===
When an instructor or a TA logs in to expertiza, s(he) can see a list of assignments under the assignment tab. An instructor or a TA can copy an assignment to use the same event in another course or as another assignment. When the user copies the assignment, the assignment is being copied without providing required flexibility to the users. Majorly, we are focused on implementing two features that shall add flexibility to the copy functionality.

===Issues===
Issue 1:
While copying an assignment, the user (instructor or TA) is not asked whether they wants to copy the topics along with the assignment or not. Currently, it is copying the topics, without providing any choice for user to not have the topics.

Issue 2:
While copying an assignment, the teams/students assigned to each topic are not getting copied. The user might want to copy the teams/students mapped to the topics as well.

===Steps to generate the issue <Existing system, without our implementation> <Requires Instructor credentials>===
1) Login to expertiza.ncsu.edu using instructor credentials.

2) Navigate to Assignments section. (Hover on Manage Tab -> Click on Assignments)

3) Copy the assignment of your choice by clicking copy icon located on the right side of the specific assignment.

Above steps copy the assignment. Remember that this process did not give you the flexibility of choosing whether to copy/not copy.

1) Topics linked to assignment.

2) Students/Teams linked to each topic.

Present system copies the topics but doesn't copy the students, even if you don't want it this way. Our implementation is to provide the user with the functionality to choose to copy/not copy topics linked to an assignment and students/teams linked to each topic.

== '''Solution & Code Modification''' ==
We have modified 5 files and mainly we have modified code in two classes they are:
#apps/controllers/assignments_controller.rb and
#apps/models/assignment_form.rb.

=== Solution ===
So before we made any changes, the flow was, when an assignment is copied: <tt>def copy</tt> in controllers/assignments_controller.rb is called which calls a function <tt>def self.copy</tt> in models/assignment_form.rb. To solve the issue, we have created a new web page that is triggered on clicking the copy icon for the assignment. The view page is the checktopicscopy.html.erb under the views/assignments folder. This page asks the user to select from 3 options, which are:
#Copy without Topics. (Blank Assignment)
#Copy with Topics. (Assignment with only topics)
#Copy with Topics and Teams. (Assignment with topics and teams)

Based on the option chosen by the user, this option is passed by the <tt>def copy</tt> in controllers/assignments_controller.rb to <tt>def self.copy</tt> in models/assignment_form.rb.
<pre>
def checktopicscopy
@assignment_id = params[:id]
end
</pre>
<pre>
new_assign_id = AssignmentForm.copy(params[:id], params[:copyoption], @user) #Line 115 in original file has been updated to Line 119 in modified file.
</pre>

The <tt>def self.copy</tt> in models/assignment_form.rb now receives this value and creates a duplicate of the assignment without copying the teams and topics originally. If the user chosen the option to just copy a blank assignment (i.e. without the topics or teams, the execution does not enter into any of the <tt>if</tt> conditions. If the user wants to copy the assignment with only the topics (but not the teams), then it goes into the first <tt>if</tt> (Line 330 [refer code below]) and copies the topics as well but does not enter the next <tt>if</tt> (Line 335 [refer code below]). If the user wants to copy the assignment with the topics as well as the teams, the code will enter the first as well as the second <tt>if</tt> condition and copy the topics as well as the teams.
<pre>
def self.copy(assignment_id, copyoption, user) #Line 313 in the original file has been modified.

..... (Skipped Lines)

if copyoption != 'copyWithoutTopics' #Line 330 in modified file.
topics = SignUpTopic.where(assignment_id: old_assign.id)
topics.each do |topic|
new_sign_up_topic = SignUpTopic.create(
topic_name: topic.topic_name,
assignment_id: new_assign_id,
max_choosers: topic.max_choosers,
category: topic.category,
topic_identifier: topic.topic_identifier,
micropayment: topic.micropayment
)

if copyoption == 'copyWithTopicsTeams' #Line 335 in modified file.
old_signed_up_teams = SignedUpTeam.where(topic_id: topic.id)
old_signed_up_teams.each do |old_signed_up_team|
new_signed_up_team = old_signed_up_team.dup
new_signed_up_team.update_attribute('topic_id', new_sign_up_topic.id)
new_signed_up_team.save
end
end
end
</pre>

The code modifications and their coverage have been covered in the following section.

== '''Testing (Test Plan)''' ==

=== Automated Testing using RSpec ===

We have made changes to the test cases and both the models/assignment_form.rb and also the controllers/assignments_controller.rb have passed all the test cases. The tests can be executed <tt>rpec spec</tt> and the results for the 2 main files we have modified are shown below:
<pre>
#rspec ./spec/models/assignment_form_spec.rb
Finished in 1 minute 32.18 seconds (files took 20.22 seconds to load)
29 examples, 0 failures
.
.
.
#rspec ./spec/controllers/assignments_controller_spec.rb
Finished in 2 minutes 2.3 seconds (files took 1 minute 13.49 seconds to load)
23 examples, 0 failures
</pre>
See the detailed coverage report below.
 
'''1. models/assignment_form.rb'''
 In this file, the coverage has increased from 61.39% to 85.65% after modification.
 '''Original file:'''
[[File:Og_model_coverage.PNG]]
 '''Modified file:'''
[[File:new_model_coverage.PNG]]
 
In the modified file, the following code has been added,
<pre>
def self.copy(assignment_id, copyoption, user) #Line 313 in the original file has been modified.
</pre>
<pre>
if copyoption != 'copyWithoutTopics' #Line 330 in modified file.
topics = SignUpTopic.where(assignment_id: old_assign.id)
topics.each do |topic|
new_sign_up_topic = SignUpTopic.create(
topic_name: topic.topic_name,
assignment_id: new_assign_id,
max_choosers: topic.max_choosers,
category: topic.category,
topic_identifier: topic.topic_identifier,
micropayment: topic.micropayment
)

if copyoption == 'copyWithTopicsTeams'
old_signed_up_teams = SignedUpTeam.where(topic_id: topic.id)
old_signed_up_teams.each do |old_signed_up_team|
new_signed_up_team = old_signed_up_team.dup
new_signed_up_team.update_attribute('topic_id', new_sign_up_topic.id)
new_signed_up_team.save
end
end
end
</pre>
 
'''2. controllers/assignments_controller.rb'''
 In this file, the coverage has increased from 88.66% to 88.8% after modification.
 '''Original file:'''
[[File:Og_controller_coverage.PNG]]
 '''Modified file:'''
[[File:new_controller_coverage.PNG]]
 
In the modified file, the following code has been added,
<pre>
def checktopicscopy
@assignment_id = params[:id]
end
</pre>
<pre>
new_assign_id = AssignmentForm.copy(params[:id], params[:copyoption], @user) #Line 115 in original file has been updated to Line 119 in modified file.
</pre>

=== Manual Testing from UI (For Reviewers) ===

By following the below stated process, you can test the implementation that we worked on, which is:
Target 1: Provide the user with the option to select copy/not copy topics linked to an assignment.
Target 2: Provide the user with the option to select copy/not copy students/teams linked to a topic.

'''Step 1''': Visit http://152.46.17.204:8080/ . Enter the credentials:
 Username: instructor6
 Password: password

'''Step 2''': On the top, hover on Manage tab. Click Assignments.

'''Step 3''': Choose an assignment that you want to copy. We would recommend you choosing a robust assignment that has Topics and students/teams associated with topics. OSS Projects generally have these. [Please make sure that you are under the Assignments tab or select the assignment besides the course]

If you want to check and see if an assignment has topics or not, click on Edit (pencil icon) on the right.
- If this assignment has topics, you will see a tab named Topics on the right of General tab. If there are no topics, you won't see Topics tab.
- On clicking the Topics tab, you can see the list of topics. If students/teams are assigned to topics, you will see student names (alias representations, like student1234 student2343) under each Topic name in 'Topic name(s) column'. If you don't see any such, it means that teams/students are not assigned to topics.

'''Step 4''': After you chose the assignment that you want to copy, click on the copy icon on the right of the corresponding assignment.

Where is the copy button located? Check the image below.
[[File: Copy oss.PNG|frame|center]]

'''Step 5''': Clicking the copy button will take you to copy options page, where you can select the options for copying. The page looks like this:
[[File: oss_copy6.PNG|frame|center]]

'''Step 6''': Choose the option you wish to test. Click create. Now the assignment shall be copied with the options you provided.

'''Step 7''': After copying, the application takes you to 'Edit' page for the assignment where you can edit/view the details pertaining to the assignment. Here, you can test our implementation.
In step 6, if you chose to

- copy without topics: You won't see 'Topics' tab near General tab.

- copy with topics: You will see 'Topics' tab near General tab(As shown in image below). Navigate to Topics tab where you can see and check that the respective topics have been copied. You won't see students under each topic in 'Topic Name(s)' column(If there are topics under Topics tab in original assignment from which you created this copy).

- copy with topics and students: You will see 'Topics' tab near General tab(As shown in image below). Navigate to Topics tab where you can see and check that the respective topics have been copied. You will see students under each topic in 'Topic Name(s)' column(If there are topics and students under Topics tab in original assignment from which you created this copy).

[[File: oss_copy7.PNG|frame|center]]

'''Step 8''': Please rename the assignment to some random string of your choice. Having it as 'Copy of'.. is creating issues of duplicate names when creating a new copy (more details in the section below, named 'Our Recommendation for a separate issue'. Not required for students). If not changed, the next tester might face difficulty while testing(which we don't want to see happening :)).

'''Step 9''': This completes the testing. Reiterate from step 2, if you wish to test again.

== '''Our Work''' ==
The code we created can be found below. We have also linked the video of our tests running with coverage to showcase the work we have done.
*[https://github.com/subhasekhar/expertiza GitHub Repository]
*[https://github.com/expertiza/expertiza/pull/1524 Pull Request]
*[http://152.46.17.204:8080/ Deployed URL]

The project could be run locally by cloning the [https://github.com/subhasekhar/expertiza GitHub Repository] and then running the following commands sequentially.

<pre>
bundle install
rake db:create:all
rake db:migrate
rails s
</pre>

== '''Our Recommendation for a Separate Issue''' (For Instructors only) ==

In the current system, we identified an issue and would like to bring it to your notice.

=== Existing System ===

When a user attempts to copy an assignment, the code creates a duplicate ‘assignment’ object, renames it as ‘copy of’ + <name of existing assignment>, saves the object and redirects to the ‘edit’ page where user is supposed to rename the assignment to something meaningful.

=== Issue ===

The current naming scheme as ‘copy of’ + <name of existing assignment> is creating an issue. Say you are creating a copy for some assignment named ‘OSS Project’, the copy object will be named as ‘copy of OSS Project’, saved and redirected to edit page. Had there been an existing assignment names ‘copy of OSS Project’ (which is likely), the copy attempt shall fail, putting a flash message on the screen like:

The assignment was not able to be copied. Please check the original assignment for missing information.

The above error message is in no relevance to the real reason for the error. Even though the save attempt failed, a copy is being inserted into the assignments table in the database.

=== Proposed Recommendation ===

Current naming scheme must be changed to have randomness. The name of the assignment can be given a random string, or a string like ‘copy of ’ + <name of existing assignment> + <5 digit random code>.

The user is anyway supposed to edit the information in the edit page (where the application is redirected after copying is successful). So, here, he can change the name to have some meaningful string.

== '''Team Information''' ==
# Sai Vishnu Muvvala (smuvval)
# Rohan Pillai (rspillai)
# Subha Sekhar Reddy Pereddy (speredd)

Mentor: Yashad Trivedi (ytrived)
 Professor: Dr. Edward F. Gehringer (efg)
 Special shoutout to TA Suraj Siddharudh (ssiddha) for clearing my doubts regarding RSpec Tests.
===References===

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://relishapp.com/rspec RSpec Documentation]

CSC/ECE 517 Fall 2019 - E1959. Intelligent copying of assignments without topics

2019-11-06T22:18:34Z

Speredd:

== '''Introduction''' ==

[http://expertiza.ncsu.edu/ Expertiza] is an open source web application project developed using Ruby on Rails framework. Let us list some of the functionalities that Expertiza allows us to do under different roles:

As an Instructor:

We can create new assignments, edit the existing assignments, copy the assignments and also delete the assignment. The instructor can also add participants, reviewers to a particular assignment.

As a Student:

They can form teams to work on various projects and also bid for the projects they would like to work on. They can also review other student's work and can give feedback on them. They can also submit various types of documents including the URLs and wiki pages for their project or assignment submission.

=='''Design Pattern'''==
Design patterns are not applicable as our task involved just modification of existing methods.

== '''Problem Statement''' ==

===Background===
When an instructor or a TA logs in to expertiza, s(he) can see a list of assignments under the assignment tab. An instructor or a TA can copy an assignment to use the same event in another course or as another assignment. When the user copies the assignment, the assignment is being copied without providing required flexibility to the users. Majorly, we are focused on implementing two features that shall add flexibility to the copy functionality.

===Issues===
Issue 1:
While copying an assignment, the user (instructor or TA) is not asked whether they wants to copy the topics along with the assignment or not. Currently, it is copying the topics, without providing any choice for user to not have the topics.

Issue 2:
While copying an assignment, the teams/students assigned to each topic are not getting copied. The user might want to copy the teams/students mapped to the topics as well.

===Steps to generate the issue <Existing system, without our implementation> <Requires Instructor credentials>===
1) Login to expertiza.ncsu.edu using instructor credentials.

2) Navigate to Assignments section. (Hover on Manage Tab -> Click on Assignments)

3) Copy the assignment of your choice by clicking copy icon located on the right side the specific assignment.

Above steps copy the assignment. Remember that this process did not give you the flexibility of choosing whether to copy/not copy.

1) Topics linked to assignment.

2) Students/Teams linked to each topic.

Present system copies the topics but doesn't copy the students, even if you don't want it this way. Our implementation is to provide the user with the functionality to choose to copy/not copy topics linked to an assignment and students/teams linked to each topic.

== '''Solution & Code Modification''' ==
We have modified 5 files and mainly we have modified code in two classes they are:
#apps/controllers/assignments_controller.rb and
#apps/models/assignment_form.rb.

=== Solution ===
So before we made any changes, the flow was, when an assignment is copied: <tt>def copy</tt> in controllers/assignments_controller.rb is called which calls a function <tt>def self.copy</tt> in models/assignment_form.rb. To solve the issue, we have created a new web page that is triggered on clicking the copy icon for the assignment. The view page is the checktopicscopy.html.erb under the views/assignments folder. This page asks the user to select from 3 options, which are:
#Copy without Topics. (Blank Assignment)
#Copy with Topics. (Assignment with only topics)
#Copy with Topics and Teams. (Assignment with topics and teams)

Based on the option chosen by the user, this option is passed by the <tt>def copy</tt> in controllers/assignments_controller.rb to <tt>def self.copy</tt> in models/assignment_form.rb.
<pre>
def checktopicscopy
@assignment_id = params[:id]
end
</pre>
<pre>
new_assign_id = AssignmentForm.copy(params[:id], params[:copyoption], @user) #Line 115 in original file has been updated to Line 119 in modified file.
</pre>

The <tt>def self.copy</tt> in models/assignment_form.rb now receives this value and creates a duplicate of the assignment without copying the teams and topics originally. If the user chosen the option to just copy a blank assignment (i.e. without the topics or teams, the execution does not enter into any of the <tt>if</tt> conditions. If the user wants to copy the assignment with only the topics (but not the teams), then it goes into the first <tt>if</tt> (Line 330 [refer code below]) and copies the topics as well but does not enter the next <tt>if</tt> (Line 335 [refer code below]). If the user wants to copy the assignment with the topics as well as the teams, the code will enter the first as well as the second <tt>if</tt> condition and copy the topics as well as the teams.
<pre>
def self.copy(assignment_id, copyoption, user) #Line 313 in the original file has been modified.

..... (Skipped Lines)

if copyoption != 'copyWithoutTopics' #Line 330 in modified file.
topics = SignUpTopic.where(assignment_id: old_assign.id)
topics.each do |topic|
new_sign_up_topic = SignUpTopic.create(
topic_name: topic.topic_name,
assignment_id: new_assign_id,
max_choosers: topic.max_choosers,
category: topic.category,
topic_identifier: topic.topic_identifier,
micropayment: topic.micropayment
)

if copyoption == 'copyWithTopicsTeams' #Line 335 in modified file.
old_signed_up_teams = SignedUpTeam.where(topic_id: topic.id)
old_signed_up_teams.each do |old_signed_up_team|
new_signed_up_team = old_signed_up_team.dup
new_signed_up_team.update_attribute('topic_id', new_sign_up_topic.id)
new_signed_up_team.save
end
end
end
</pre>

The code modifications and their coverage have been covered in the following section.

== '''Testing (Test Plan)''' ==

=== Automated Testing using RSpec ===

We have made changes to the test cases and both the models/assignment_form.rb and also the controllers/assignments_controller.rb have passed all the test cases. The tests can be executed <tt>rpec spec</tt> and the results for the 2 main files we have modified are shown below:
<pre>
#rspec ./spec/models/assignment_form_spec.rb
Finished in 1 minute 32.18 seconds (files took 20.22 seconds to load)
29 examples, 0 failures
.
.
.
#rspec ./spec/controllers/assignments_controller_spec.rb
Finished in 2 minutes 2.3 seconds (files took 1 minute 13.49 seconds to load)
23 examples, 0 failures
</pre>
See the detailed coverage report below.
 
'''1. models/assignment_form.rb'''
 In this file, the coverage has increased from 61.39% to 85.65% after modification.
 '''Original file:'''
[[File:Og_model_coverage.PNG]]
 '''Modified file:'''
[[File:new_model_coverage.PNG]]
 
In the modified file, the following code has been added,
<pre>
def self.copy(assignment_id, copyoption, user) #Line 313 in the original file has been modified.
</pre>
<pre>
if copyoption != 'copyWithoutTopics' #Line 330 in modified file.
topics = SignUpTopic.where(assignment_id: old_assign.id)
topics.each do |topic|
new_sign_up_topic = SignUpTopic.create(
topic_name: topic.topic_name,
assignment_id: new_assign_id,
max_choosers: topic.max_choosers,
category: topic.category,
topic_identifier: topic.topic_identifier,
micropayment: topic.micropayment
)

if copyoption == 'copyWithTopicsTeams'
old_signed_up_teams = SignedUpTeam.where(topic_id: topic.id)
old_signed_up_teams.each do |old_signed_up_team|
new_signed_up_team = old_signed_up_team.dup
new_signed_up_team.update_attribute('topic_id', new_sign_up_topic.id)
new_signed_up_team.save
end
end
end
</pre>
 
'''2. controllers/assignments_controller.rb'''
 In this file, the coverage has increased from 88.66% to 88.8% after modification.
 '''Original file:'''
[[File:Og_controller_coverage.PNG]]
 '''Modified file:'''
[[File:new_controller_coverage.PNG]]
 
In the modified file, the following code has been added,
<pre>
def checktopicscopy
@assignment_id = params[:id]
end
</pre>
<pre>
new_assign_id = AssignmentForm.copy(params[:id], params[:copyoption], @user) #Line 115 in original file has been updated to Line 119 in modified file.
</pre>

=== Manual Testing from UI (For Reviewers) ===

By following the below stated process, you can test the implementation that we worked on, which is:
Target 1: Provide the user with the option to select copy/not copy topics linked to an assignment.
Target 2: Provide the user with the option to select copy/not copy students/teams linked to a topic.

'''Step 1''': Visit http://152.46.17.204:8080/ . Enter the credentials:
 Username: instructor6
 Password: password

'''Step 2''': On the top, hover on Manage tab. Click Assignments.

'''Step 3''': Choose an assignment that you want to copy. We would recommend you choosing a robust assignment that has Topics and students/teams associated with topics. OSS Projects generally have these. [Please make sure that you are under the Assignments tab or select the assignment besides the course]

If you want to check and see if an assignment has topics or not, click on Edit (pencil icon) on the right.
- If this assignment has topics, you will see a tab named Topics on the right of General tab. If there are no topics, you won't see Topics tab.
- On clicking the Topics tab, you can see the list of topics. If students/teams are assigned to topics, you will see student names (alias representations, like student1234 student2343) under each Topic name in 'Topic name(s) column'. If you don't see any such, it means that teams/students are not assigned to topics.

'''Step 4''': After you chose the assignment that you want to copy, click on the copy icon on the right of the corresponding assignment.

Where is the copy button located? Check the image below.
[[File: Copy oss.PNG|frame|center]]

'''Step 5''': Clicking the copy button will take you to copy options page, where you can select the options for copying. The page looks like this:
[[File: oss_copy6.PNG|frame|center]]

'''Step 6''': Choose the option you wish to test. Click create. Now the assignment shall be copied with the options you provided.

'''Step 7''': After copying, the application takes you to 'Edit' page for the assignment where you can edit/view the details pertaining to the assignment. Here, you can test our implementation.
In step 6, if you chose to

- copy without topics: You won't see 'Topics' tab near General tab.

- copy with topics: You will see 'Topics' tab near General tab(As shown in image below). Navigate to Topics tab where you can see and check that the respective topics have been copied. You won't see students under each topic in 'Topic Name(s)' column(If there are topics under Topics tab in original assignment from which you created this copy).

- copy with topics and students: You will see 'Topics' tab near General tab(As shown in image below). Navigate to Topics tab where you can see and check that the respective topics have been copied. You will see students under each topic in 'Topic Name(s)' column(If there are topics and students under Topics tab in original assignment from which you created this copy).

[[File: oss_copy7.PNG|frame|center]]

'''Step 8''': Please rename the assignment to some random string of your choice. Having it as 'Copy of'.. is creating issues of duplicate names when creating a new copy (more details in the section below, named 'Our Recommendation for a separate issue'. Not required for students). If not changed, the next tester might face difficulty while testing(which we don't want to see happening :)).

'''Step 9''': This completes the testing. Reiterate from step 2, if you wish to test again.

== '''Our Work''' ==
The code we created can be found below. We have also linked the video of our tests running with coverage to showcase the work we have done.
*[https://github.com/subhasekhar/expertiza GitHub Repository]
*[https://github.com/expertiza/expertiza/pull/1524 Pull Request]
*[http://152.46.17.204:8080/ Deployed URL]

The project could be run locally by cloning the [https://github.com/subhasekhar/expertiza GitHub Repository] and then running the following commands sequentially.

<pre>
bundle install
rake db:create:all
rake db:migrate
rails s
</pre>

== '''Our Recommendation for a Separate Issue''' (For Instructors only) ==

In the current system, we identified an issue and would like to bring it to your notice.

=== Existing System ===

When a user attempts to copy an assignment, the code creates a duplicate ‘assignment’ object, renames it as ‘copy of’ + <name of existing assignment>, saves the object and redirects to the ‘edit’ page where user is supposed to rename the assignment to something meaningful.

=== Issue ===

The current naming scheme as ‘copy of’ + <name of existing assignment> is creating an issue. Say you are creating a copy for some assignment named ‘OSS Project’, the copy object will be named as ‘copy of OSS Project’, saved and redirected to edit page. Had there been an existing assignment names ‘copy of OSS Project’ (which is likely), the copy attempt shall fail, putting a flash message on the screen like:

The assignment was not able to be copied. Please check the original assignment for missing information.

The above error message is in no relevance to the real reason for the error. Even though the save attempt failed, a copy is being inserted into the assignments table in the database.

=== Proposed Recommendation ===

Current naming scheme must be changed to have randomness. The name of the assignment can be given a random string, or a string like ‘copy of ’ + <name of existing assignment> + <5 digit random code>.

The user is anyway supposed to edit the information in the edit page (where the application is redirected after copying is successful). So, here, he can change the name to have some meaningful string.

== '''Team Information''' ==
# Sai Vishnu Muvvala (smuvval)
# Rohan Pillai (rspillai)
# Subha Sekhar Reddy Pereddy (speredd)

Mentor: Yashad Trivedi (ytrived)
 Professor: Dr. Edward F. Gehringer (efg)
 Special shoutout to TA Suraj Siddharudh (ssiddha) for clearing my doubts regarding RSpec Tests.
===References===

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://relishapp.com/rspec RSpec Documentation]

CSC/ECE 517 Fall 2019 - E1959. Intelligent copying of assignments without topics

2019-10-31T03:19:59Z

Speredd: /* Design Pattern */

== '''Wiki Page Description''' ==
This wiki page describes about the E1959. Intelligent copying of assignments without topics (Issue #1341). We will explain about the issue and also the steps to resolve the issue.

== '''Introduction''' ==

Expertiza is an open source web application project developed using Ruby on Rails framework. Let us list some of the functionalities that Expertiza allows us to do under different roles:

As an Instructor:

We can create new assignments, edit the existing assignments, copy the assignments and also delete the assignment. The instructor can also add participants, reviewers to a particular assignment.

As a Student:

They can form teams to work on various projects and also bid for the projects they would like to work on. They can also review other student's work and can give feedback on them. They can also submit various types of documents including the URLs and wiki pages for their project or assignment submission.

=='''Design Pattern'''==
Design patterns are not applicable as our task involved just modification of existing methods.

== '''Problem Statement''' ==

===Background===
When an instructor or a TA logs in to expertiza, s(he) can see a list of assignments under the assignment tab. An instructor or a TA can copy an assignment to use the same event in another course or as another assignment. When the user copies the assignment, the assignment is being copied without providing required flexibility to the users. Majorly, we are focused on implementing two features that shall add flexibility to the copy functionality.

===Issues===
Issue 1:
While copying an assignment, the user (instructor or TA) is not asked whether they wants to copy the topics along with the assignment or not. Currently, it is copying the topics, without providing any choice for user to not have the topics.

Issue 2:
While copying an assignment, the teams/students assigned to each topic are not getting copied. The user might want to copy the teams/students mapped to the topics as well.

===Steps to generate the issue <Existing system, without our implementation> <Requires Instructor credentials>===
1) Login to expertiza.ncsu.edu using instructor credentials.

2) Navigate to Assignments section. (Hover on Manage Tab -> Click on Assignments)

3) Copy the assignment of your choice by clicking copy icon located on the right side the specific assignment.

Above steps copy the assignment. Remember that this process did not give you the flexibility of choosing whether to copy/not copy.

1) Topics linked to assignment.

2) Students/Teams linked to each topic.

Present system copies the topics but doesn't copy the students, even if you don't want it this way. Our implementation is to provide the user with the functionality to choose to copy/not copy topics linked to an assignment and students/teams linked to each topic.

== Testing our work ==
By following the below stated process, you can test the implementation that we worked on, which is:
Target 1: Provide the user with the option to select copy/not copy topics linked to an assignment.
Target 2: Provide the user with the option to select copy/not copy students/teams linked to a topic.

'''Step 1''': Visit http://152.46.17.204:8080/ . Enter the credentials:
 Username: instructor6
 Password: password

'''Step 2''': On the top, hover on Manage tab. Click Assignments.

'''Step 3''': Choose an assignment that you want to copy. We would recommend you choosing a robust assignment that has Topics and students/teams associated with topics. OSS Projects generally have these. [Please make sure that you are under the Assignments tab or select the assignment besides the course]

If you want to check and see if an assignment has topics or not, click on Edit (pencil icon) on the right.
- If this assignment has topics, you will see a tab named Topics on the right of General tab. If there are no topics, you won't see Topics tab.
- On clicking the Topics tab, you can see the list of topics. If students/teams are assigned to topics, you will see student names (alias representations, like student1234 student2343) under each Topic name in 'Topic name(s) column'. If you don't see any such, it means that teams/students are not assigned to topics.

'''Step 4''': After you chose the assignment that you want to copy, click on the copy icon on the right of the corresponding assignment.

Where is the copy button located? Check the image below.
[[File: Copy oss.PNG|frame|center]]

'''Step 5''': Clicking the copy button will take you to copy options page, where you can select the options for copying. The page looks like this:
[[File: oss_copy6.PNG|frame|center]]

'''Step 6''': Choose the option you wish to test. Click create. Now the assignment shall be copied with the options you provided.

'''Step 7''': After copying, the application takes you to 'Edit' page for the assignment where you can edit/view the details pertaining to the assignment. Here, you can test our implementation.
In step 6, if you chose to

- copy without topics: You won't see 'Topics' tab near General tab.

- copy with topics: You will see 'Topics' tab near General tab(As shown in image below). Navigate to Topics tab where you can see and check that the respective topics have been copied. You won't see students under each topic in 'Topic Name(s)' column(If there are topics under Topics tab in original assignment from which you created this copy).

- copy with topics and students: You will see 'Topics' tab near General tab(As shown in image below). Navigate to Topics tab where you can see and check that the respective topics have been copied. You will see students under each topic in 'Topic Name(s)' column(If there are topics and students under Topics tab in original assignment from which you created this copy).

[[File: oss_copy7.PNG|frame|center]]

'''Step 8''': Please rename the assignment to some random string of your choice. Having it as 'Copy of'.. is creating issues of duplicate names when creating a new copy (more details in the section below, named 'Our Recommendation for a separate issue'. Not required for students). If not changed, the next tester might face difficulty while testing(which we don't want to see happening :)).

'''Step 9''': This completes the testing. Reiterate from step 2, if you wish to test again.

== Code Modification ==
We have modified 5 files and mainly we have modified code in two classes they are:
assignments_controller.rb under the apps/controllers
assignment_form.rb under the apps/models

We have created a new web page that is triggered on clicking the copy icon for the assignment. The view page is the checktopicscopy.html.erb under the views/assignments folder.

== For the reviewers ==
1) Please log in using the instructor credentials they are:
 Username: instructor6
 Password: password

2) Then select the assignment tab under manage.

3) The assignment page opens and then select the copy button of the desired assignment. [NOTE: Before copying see that the assignment already has the topics or not by selecting the edit icon of the assignment]

4) If that particular assignment does not have the topics, choose another assignment which has topics to test our functionality.

5) On clicking the copy icon you will be redirected to the web page which has options, select one of the desired options and select the create button.

5) On clicking the Create button you will be redirected to the edit page of the newly created assignment. In the edit page if the topics tab appears it means that the topics are copied and you can check whether the students under the topics are copied or not. [NOTE: if the topics tab is absent beside the General Tab it indicates that the topics are not copied with assignment]

6) Check the new assignment based on the choice you selected while creating a copy of an assignment.

== Testing (Test Plan) ==

=== Automated Testing using RSpec ===

We have made changes to the test cases and both the assignment_form.rb in models and also the assignments_controller.rb in controllers have passed all the test cases.

== Our Work ==
The code we created can be found below. We have also linked the video of our tests running with coverage to showcase the work we have done.
*[https://github.com/subhasekhar/expertiza GitHub Repo]
*[https://github.com/expertiza/expertiza/pull/1524 Pull request]
*[http://152.46.17.204:8080/ Deployed URL]

== Our Recommendation for a Separate Issue <For Instructors only>==

In the current system, we identified an issue and would like to bring it to your notice.

=== Existing System ===

When a user attempts to copy an assignment, the code creates a duplicate ‘assignment’ object, renames it as ‘copy of’ + <name of existing assignment>, saves the object and redirects to the ‘edit’ page where user is supposed to rename the assignment to something meaningful.

=== Issue ===

The current naming scheme as ‘copy of’ + <name of existing assignment> is creating an issue. Say you are creating a copy for some assignment named ‘OSS Project’, the copy object will be named as ‘copy of OSS Project’, saved and redirected to edit page. Had there been an existing assignment names ‘copy of OSS Project’ (which is likely), the copy attempt shall fail, putting a flash message on the screen like:

The assignment was not able to be copied. Please check the original assignment for missing information.

The above error message is in no relevance to the real reason for the error. Even though the save attempt failed, a copy is being inserted into the assignments table in the database.

=== Proposed Recommendation ===

Current naming scheme must be changed to have randomness. The name of the assignment can be given a random string, or a string like ‘copy of ’ + <name of existing assignment> + <5 digit random code>.

The user is anyway supposed to edit the information in the edit page (where the application is redirected after copying is successful). So, here, he can change the name to have some meaningful string.

== Team Information ==
1) Sai Vishnu Muvvala (smuvval)

2) Rohan Pillai (rspillai)

3) Subha Sekhar Reddy Pereddy (speredd)

Mentor: Yashad Trivedi

CSC/ECE 517 Fall 2019 - E1959. Intelligent copying of assignments without topics

2019-10-31T03:19:43Z

Speredd: /* Introduction */

== '''Wiki Page Description''' ==
This wiki page describes about the E1959. Intelligent copying of assignments without topics (Issue #1341). We will explain about the issue and also the steps to resolve the issue.

== '''Introduction''' ==

Expertiza is an open source web application project developed using Ruby on Rails framework. Let us list some of the functionalities that Expertiza allows us to do under different roles:

As an Instructor:

We can create new assignments, edit the existing assignments, copy the assignments and also delete the assignment. The instructor can also add participants, reviewers to a particular assignment.

As a Student:

They can form teams to work on various projects and also bid for the projects they would like to work on. They can also review other student's work and can give feedback on them. They can also submit various types of documents including the URLs and wiki pages for their project or assignment submission.

=='''Design Pattern'''==
Design patterns are not applicable as our task involved just modification of existing methods methods.

== '''Problem Statement''' ==

===Background===
When an instructor or a TA logs in to expertiza, s(he) can see a list of assignments under the assignment tab. An instructor or a TA can copy an assignment to use the same event in another course or as another assignment. When the user copies the assignment, the assignment is being copied without providing required flexibility to the users. Majorly, we are focused on implementing two features that shall add flexibility to the copy functionality.

===Issues===
Issue 1:
While copying an assignment, the user (instructor or TA) is not asked whether they wants to copy the topics along with the assignment or not. Currently, it is copying the topics, without providing any choice for user to not have the topics.

Issue 2:
While copying an assignment, the teams/students assigned to each topic are not getting copied. The user might want to copy the teams/students mapped to the topics as well.

===Steps to generate the issue <Existing system, without our implementation> <Requires Instructor credentials>===
1) Login to expertiza.ncsu.edu using instructor credentials.

2) Navigate to Assignments section. (Hover on Manage Tab -> Click on Assignments)

3) Copy the assignment of your choice by clicking copy icon located on the right side the specific assignment.

Above steps copy the assignment. Remember that this process did not give you the flexibility of choosing whether to copy/not copy.

1) Topics linked to assignment.

2) Students/Teams linked to each topic.

Present system copies the topics but doesn't copy the students, even if you don't want it this way. Our implementation is to provide the user with the functionality to choose to copy/not copy topics linked to an assignment and students/teams linked to each topic.

== Testing our work ==
By following the below stated process, you can test the implementation that we worked on, which is:
Target 1: Provide the user with the option to select copy/not copy topics linked to an assignment.
Target 2: Provide the user with the option to select copy/not copy students/teams linked to a topic.

'''Step 1''': Visit http://152.46.17.204:8080/ . Enter the credentials:
 Username: instructor6
 Password: password

'''Step 2''': On the top, hover on Manage tab. Click Assignments.

'''Step 3''': Choose an assignment that you want to copy. We would recommend you choosing a robust assignment that has Topics and students/teams associated with topics. OSS Projects generally have these. [Please make sure that you are under the Assignments tab or select the assignment besides the course]

If you want to check and see if an assignment has topics or not, click on Edit (pencil icon) on the right.
- If this assignment has topics, you will see a tab named Topics on the right of General tab. If there are no topics, you won't see Topics tab.
- On clicking the Topics tab, you can see the list of topics. If students/teams are assigned to topics, you will see student names (alias representations, like student1234 student2343) under each Topic name in 'Topic name(s) column'. If you don't see any such, it means that teams/students are not assigned to topics.

'''Step 4''': After you chose the assignment that you want to copy, click on the copy icon on the right of the corresponding assignment.

Where is the copy button located? Check the image below.
[[File: Copy oss.PNG|frame|center]]

'''Step 5''': Clicking the copy button will take you to copy options page, where you can select the options for copying. The page looks like this:
[[File: oss_copy6.PNG|frame|center]]

'''Step 6''': Choose the option you wish to test. Click create. Now the assignment shall be copied with the options you provided.

'''Step 7''': After copying, the application takes you to 'Edit' page for the assignment where you can edit/view the details pertaining to the assignment. Here, you can test our implementation.
In step 6, if you chose to

- copy without topics: You won't see 'Topics' tab near General tab.

- copy with topics: You will see 'Topics' tab near General tab(As shown in image below). Navigate to Topics tab where you can see and check that the respective topics have been copied. You won't see students under each topic in 'Topic Name(s)' column(If there are topics under Topics tab in original assignment from which you created this copy).

- copy with topics and students: You will see 'Topics' tab near General tab(As shown in image below). Navigate to Topics tab where you can see and check that the respective topics have been copied. You will see students under each topic in 'Topic Name(s)' column(If there are topics and students under Topics tab in original assignment from which you created this copy).

[[File: oss_copy7.PNG|frame|center]]

'''Step 8''': Please rename the assignment to some random string of your choice. Having it as 'Copy of'.. is creating issues of duplicate names when creating a new copy (more details in the section below, named 'Our Recommendation for a separate issue'. Not required for students). If not changed, the next tester might face difficulty while testing(which we don't want to see happening :)).

'''Step 9''': This completes the testing. Reiterate from step 2, if you wish to test again.

== Code Modification ==
We have modified 5 files and mainly we have modified code in two classes they are:
assignments_controller.rb under the apps/controllers
assignment_form.rb under the apps/models

We have created a new web page that is triggered on clicking the copy icon for the assignment. The view page is the checktopicscopy.html.erb under the views/assignments folder.

== For the reviewers ==
1) Please log in using the instructor credentials they are:
 Username: instructor6
 Password: password

2) Then select the assignment tab under manage.

3) The assignment page opens and then select the copy button of the desired assignment. [NOTE: Before copying see that the assignment already has the topics or not by selecting the edit icon of the assignment]

4) If that particular assignment does not have the topics, choose another assignment which has topics to test our functionality.

5) On clicking the copy icon you will be redirected to the web page which has options, select one of the desired options and select the create button.

5) On clicking the Create button you will be redirected to the edit page of the newly created assignment. In the edit page if the topics tab appears it means that the topics are copied and you can check whether the students under the topics are copied or not. [NOTE: if the topics tab is absent beside the General Tab it indicates that the topics are not copied with assignment]

6) Check the new assignment based on the choice you selected while creating a copy of an assignment.

== Testing (Test Plan) ==

=== Automated Testing using RSpec ===

We have made changes to the test cases and both the assignment_form.rb in models and also the assignments_controller.rb in controllers have passed all the test cases.

== Our Work ==
The code we created can be found below. We have also linked the video of our tests running with coverage to showcase the work we have done.
*[https://github.com/subhasekhar/expertiza GitHub Repo]
*[https://github.com/expertiza/expertiza/pull/1524 Pull request]
*[http://152.46.17.204:8080/ Deployed URL]

== Our Recommendation for a Separate Issue <For Instructors only>==

In the current system, we identified an issue and would like to bring it to your notice.

=== Existing System ===

When a user attempts to copy an assignment, the code creates a duplicate ‘assignment’ object, renames it as ‘copy of’ + <name of existing assignment>, saves the object and redirects to the ‘edit’ page where user is supposed to rename the assignment to something meaningful.

=== Issue ===

The current naming scheme as ‘copy of’ + <name of existing assignment> is creating an issue. Say you are creating a copy for some assignment named ‘OSS Project’, the copy object will be named as ‘copy of OSS Project’, saved and redirected to edit page. Had there been an existing assignment names ‘copy of OSS Project’ (which is likely), the copy attempt shall fail, putting a flash message on the screen like:

The assignment was not able to be copied. Please check the original assignment for missing information.

The above error message is in no relevance to the real reason for the error. Even though the save attempt failed, a copy is being inserted into the assignments table in the database.

=== Proposed Recommendation ===

Current naming scheme must be changed to have randomness. The name of the assignment can be given a random string, or a string like ‘copy of ’ + <name of existing assignment> + <5 digit random code>.

The user is anyway supposed to edit the information in the edit page (where the application is redirected after copying is successful). So, here, he can change the name to have some meaningful string.

== Team Information ==
1) Sai Vishnu Muvvala (smuvval)

2) Rohan Pillai (rspillai)

3) Subha Sekhar Reddy Pereddy (speredd)

Mentor: Yashad Trivedi