Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Spring 2018- Project E1824: Let course staff as well as students do reviews

2018-04-30T08:00:56Z

Smshetty: More details

== '''Introduction''' ==

The way Expertiza is set up right now is that only peers can review your work. However, there are cases when the course staff (Instructor/ TAs) would want to submit reviews as well. This project aims to implement this feature by allowing course staff to review the project on the same metrics as other students who review the project.

== '''Problem Statement''' ==

Peer review is a great way for students to learn about how well they have developed their application. However there are some problems with this:
* Sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development.
* The reviewer might not know how well they are reviewing the peers work. They might not entirely know as to what tone to use or what suggestions to put forward.

By letting course staff perform reviews as well, the reviewer and the reviewee are both benefited, which can improve the overall learning experience.

=== Current scenario ===

This is how some of the pages we are concerned with, currently look.

==== Submissions page for an assignment in Instructor View ====

[[File: Submissions_instr.jpeg | center]]

==== A typical Scores table in a Student View ====

[[File: Grades_view_team_current.png | center]]

== '''Proposed Solutions and Implementation''' ==

We performed the following changes to let staff perform reviews as well:

'''Step 1: Add a way for the instructors to perform a review.'''

To do this, we added links for performing/viewing/editing/updating a review in the assignment submissions view.
When the instructor/TA reviews a work for the first time, he is added as a participant and a review response mapping is created.

Files edited:
* '''View: ''' ''app/views/assignments/list_submissions.html.erb'' - To add links in the instructor view
* '''Controller: ''' ''app/controllers/review_mapping_controller.rb'' - Method: add_instructor_as_reviewer

Code snippet from the controller:
<pre>
def add_instructor_as_reviewer
assignment_team = AssignmentTeam.find(params[:team_id])
reviewer = AssignmentParticipant.where(user_id: params[:reviewer_id], parent_id: assignment_team.parent_id).first
if reviewer.nil?
reviewer = AssignmentParticipant.create(parent_id: assignment_team.parent_id, user_id: session[:user].id, can_submit: false, can_review: true,
can_take_quiz: false, handle: 'handle')

end
@review_map_id=ReviewResponseMap.where(reviewee_id: assignment_team.id, reviewer_id: reviewer.id,
reviewed_object_id: params[:assignment_id]).first
@review_map_id=assignment_team.assign_reviewer(reviewer) if @review_map_id.nil?
redirect_to controller: 'response', action: 'new', id: @review_map_id.map_id
end
</pre>

[[File:Instructor review view.PNG | center]]

In the second case, we can see a 'Perform review' link. This is the initial state when instructor review has not been added to the submission.
Once the instructor adds a review and submits it, we can see the 'View review'. In case he just saves the review, an 'Edit review' link will appear.
If the review deadline of one round is passed, the 'Edit review' link becomes 'Update review' link. This follows in line with what the student sees while performing a review. However, the course staff will be allowed to perform a review even if the deadline for reviewing has passed.

'''Step 2: Add the instructor review in ''Your Scores'' table in case he has reviewed your work. Provide a highlight/way to make it look distinct.'''

Files edited:
* '''Assets: ''' ''app/assets/stylesheets/grades.scss'' - To make an instructor performed review distinct from other reviews
* '''View: ''' ''app/views/grades/view_team.html.erb'' - Modified the "Others work" page to include the instructor review as well as ensure the score is not used.
* '''Models: '''
** ''app/models/answer.rb'' - Method: compute_scores | Modification in logic to ensure instructor review scores are not counted in the overall score of the student.
** ''app/models/vm_question_response_score_cell.rb'' - Included a new variable called 'is_instructor_review' to identify an instructor review
** ''app/models/vm_question_response_row.rb'' - Change in average_score_for_row method to not include an instructor review score
** ''app/models/vm_question_response.rb'' - Modified the add_answer method to include the is_instructor_review to each row_score object

Code snippet from the add_answer method:
<pre>
participant= Participant.find(ResponseMap.find(Response.find(response_id).map_id).reviewer_id)
user_id = participant.user_id
course = Course.find(@assignment.course_id)
row.score_row.push(VmQuestionResponseScoreCell.new(answer.answer, color_code, answer.comments,
course.is_ta_or_instructor?(user_id), vm_tag_prompts))
</pre>

[[File:View_team.PNG | center]]

A student should be able to make out if an instructor has reviewed his/his team's work. In case the instructor performs a review on the team's work, it will highlight the instructor's review with a golden border as seen in the round two score table along with explicitly stating that it is an 'Instructor review'.
The average peer review score for the team has been modified to exclude the instructor's scores. Same has been taken into account for the average score calculated for each row.

Additional Files modified:
* '''Controllers: '''
** ''app/controllers/response_controller.rb'' - Change in re-directions in case of an instructor taking him back to the submissions page.
* '''Models: '''
** ''app/models/assignment.rb'' - Method: number_of_current_round_for_instructor | To allow an instructor to review an assignment even after the due date
** ''app/models/course.rb'' - Method: is_ta_or_instructor? | To identify whether the user is a TA or an instructor of the current course

Code snippet from the controller:
<pre>
def is_ta_or_instructor?(user_id)
instructors = TaMapping.where(course_id: self.id).collect { |x| x.ta_id}
instructors.push(self.instructor_id)
return user_id.in?(instructors)
end
</pre>

== '''Test Plan''' ==

'''Features testing:''' Many of our changes would be reflected on views (user interface). Following is the list of tests that should be conducted with rspec/capybara.

# it "should let instructor/TAs perform a review for the submission of latest finished round if instructor/TAs has not started a review for the submission yet"
# it "should let instructor/TAs save a review"
# it "should let instructor/TAs review a previously saved review"
# it "should let instructor/TAs edit a previously saved review"
# it "should let instructor/TAs update a review for the submission of latest finished round if instructor/TAs performed and saved a review for the previous round"
# it "should allow instructor/TAs perform a review after the deadline for reviewing has passed"
# it "should show "Instructor review" when a student views feedback on his/her submission if an instructor/TA has reviewed his/his team's work"
# it "should exclude the instructor's/TA's review score when calculating the average peer review score for the team"
# it "should exclude the instructor's/TA's review score when calculating the average score for each question in the review"

<pre>
describe "instructor review testing" do
before(:each) do
create(:assignment, name: "TestAssignment", directory_path: 'test_assignment')
create_list(:participant, 3)
create(:assignment_node)
create(:deadline_type, name: "submission")
create(:deadline_type, name: "review")
create(:deadline_type, name: "metareview")
create(:deadline_type, name: "drop_topic")
create(:deadline_type, name: "signup")
create(:deadline_type, name: "team_formation")
create(:deadline_right)
create(:deadline_right, name: 'Late')
create(:deadline_right, name: 'OK')
create(:assignment_due_date, deadline_type: DeadlineType.where(name: 'review').first, due_at: Time.now.in_time_zone + 1.day)
create(:topic)
create(:topic, topic_name: "TestReview")
create(:team_user, user: User.where(role_id: 2).first)
create(:team_user, user: User.where(role_id: 2).second)
create(:assignment_team)
create(:team_user, user: User.where(role_id: 2).third, team: AssignmentTeam.second)
create(:signed_up_team)
create(:signed_up_team, team_id: 2, topic: SignUpTopic.second)
create(:assignment_questionnaire)
create(:question)
create(:review_response_map, reviewer_id: User.find_by(name: "instructor6").id, reviewee: AssignmentTeam.second)
end

it "lets instructor perform a review and saves" do
assignment = Assignment.first
login_as("instructor6")
visit "/assignments/list_submissions?id=#{assignment.id}"
expect(page).to have_content 'Perform review'
all(:link, 'Perform review')[1].click
fill_in "responses[0][comment]", with: "DRY"
select 5, from: "responses[0][score]"
click_button "Save Review"
expect(page).to have_content "Your response was successfully saved."
end

it "lets instructor view a saved review" do
assignment = Assignment.first
login_as("instructor6")
visit "/assignments/list_submissions?id=#{assignment.id}"
all(:link, 'Perform review')[1].click
fill_in "responses[0][comment]", with: "Hello world"
click_button "Save Review"
visit "/assignments/list_submissions?id=#{assignment.id}"
expect(page).to have_content 'View review'
click_link "View review"
expect(page).to have_content "show review"
end

it "lets instructor edit a saved review and saves" do
assignment = Assignment.first
login_as("instructor6")
visit "/assignments/list_submissions?id=#{assignment.id}"
all(:link, 'Perform review')[1].click
fill_in "responses[0][comment]", with: "Good job"
click_button "Save Review"
visit "/assignments/list_submissions?id=#{assignment.id}"
expect(page).to have_content 'Edit review'
click_link "Edit review"
expect(page).to have_text "Good job"
fill_in "review[comments]", with: "Excellent work"
click_button "Save Review"
expect(page.current_path).to eq "/student_review/list"
end
end
</pre>

'''Controllers testing:''' review_mapping_controller#add_instructor_as_reviewer

<pre>
describe '#add_instructor_as_reviewer' do
context 'when instructor is not a participant for the assignment and review_response_map has not been created' do
it 'adds instructor as a participant for the assignment and creates review_response_map and redirects to responses#new' do
allow(AssignmentTeam).to receive(:find).with('1').and_return(team2)
allow(AssignmentParticipant).to receive_message_chain(:where, :first)
.with(user_id: 1, parent_id: '1').with(no_args).and_return(nil)
allow(AssignmentParticipant).to receive(:create)
.with(parent_id: '1', user_id: 1, can_submit: false, can_review: true, can_take_quiz: false, handle: 'handle').and_return(participant)
allow(ReviewResponseMap).to receive_message_chain(:where, :first)
.with(reviewee_id: '1', reviewer_id: 1, reviewed_object_id: '1').with(no_args).and_return(nil)
allow(team2).to receive(:assign_reviewer)
.with(participant).and_return(review_response_map)
params = {id: 1, team_id: 1, assignment_id: 1}
session = {user: build(:instructor, id: 1)}
get :add_instructor_as_reviewer, params, session
expect(response).to redirect_to '/response/new?id=1'
end
end

context 'when instructor is already a participant for the assignment and review_response_map has been created' do
it 'does not need to add instructor as a participant for the assignment or create review_repsonse_map and redirects to response#new' do
allow(AssignmentTeam).to receive(:find).with('1').and_return(team2)
allow(AssignmentParticipant).to receive_message_chain(:where, :first)
.with(user_id: 1, parent_id: '1').with(no_args).and_return(participant)
allow(ReviewResponseMap).to receive_message_chain(:where, :first)
.with(reviewee_id: '1', reviewer_id: 1, reviewed_object_id: '1').with(no_args).and_return(review_response_map)
params = {id: 1, team_id: 1, assignment_id: 1}
session = {user: build(:instructor, id: 1)}
get :add_instructor_as_reviewer, params, session
expect(response).to redirect_to '/response/new?id=1'
end
end
end
</pre>

== '''External Links''' ==
* Forked Repository: https://github.com/kushalnawalakha/expertiza
* Pull Request: https://github.com/expertiza/expertiza/pull/1182
* Deployment: http://ec2-13-59-7-94.us-east-2.compute.amazonaws.com:3000/

== '''Team Members''' ==
*Ashis Sahoo
*Satvik Shetty
*Xiaohui Ellis
*Kushal Nawalakha

== '''References''' ==

Expertiza
* https://expertiza.ncsu.edu/

Expertiza Github
* https://github.com/expertiza/expertiza

Expertiza Documentation
* http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation

File:Instructor review view.PNG

2018-04-30T06:39:57Z

Smshetty: uploaded a new version of "File:Instructor review view.PNG"

File:Instructor review view.PNG

2018-04-30T06:37:06Z

Smshetty: uploaded a new version of "File:Instructor review view.PNG"

CSC/ECE 517 Spring 2018- Project E1824: Let course staff as well as students do reviews

2018-04-08T22:47:42Z

Smshetty: /* Proposed Solutions */

== '''Introduction''' ==

The way Expertiza is set up right now is that only peers can review your work. However, there are cases when the instructor would want to submit reviews as well. This project aims to implement this feature by allowing instructors to review the project on the same metrics as other students who review the project.

== '''Problem Statement''' ==

Peer review is a great way for students to learn about how well they have developed their application. However there are some problems with this:
* Sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development.
* The reviewer might not know how well they are reviewing the peer's work. They might not entirely know as to what tone to use or what suggestions to put forward.

By letting course staff perform reviews as well, the reviewer and the reviewee are both benefited, which can improve the overall learning experience.

=== Current scenario ===

This is how some of the pages we are concerned with, currently look.

==== Submissions page for an assignment in Instructor View ====

[[File: Submissions_instr.jpeg | center]]

==== A typical Scores table in a Student View ====

[[File: Grades_view_team_current.png | center]]

==== Others work reviewed in a Student View ====

[[File: Others_work_current.jpeg | center]]

== '''Proposed Solutions''' ==

We propose to perform the following changes to let staff perform reviews as well:

'''Step 1: Add a ''Perform review'' link in the assignment submissions page view for the instructors.'''

Files to be edited:
* '''View: ''' ''app/views/assignments/list_submissions.html.erb''
* '''Controller: ''' ''app/controllers/response_controller.rb'' - Add authorization for instructors to perform review

[[File: Submissions_instr_new.jpeg | center]]

In the first case, there is a ''Perform Review'' as well as ''Assign Grade'' link if the final submission date has passed. The course staff will be allowed to perform a review even if the deadline for reviewing has passed.

In the second case, an intermediate submission deadline has passed and hence there is a link only for performing a review.

In the third case, if no submission deadline has passed, there won't be a link for Performing a review nor assigning a grade.

'''Step 2: Add instructor review in ''Your Scores'' table in case he has reviewed your work. Provide a highlight/way to make it look distinct.'''

Files to be edited:
* '''View: ''' ''app/views/grades/view_team.html.erb''
* '''Controller: ''' ''app/controllers/grades_controller.rb'' - Method: view_team

[[File: Grades_view_team_instr.png | center]]

A student should be able to make out if an instructor has reviewed his/his team's work. In case the instructor performs a review on the team's work, it will highlight the intructor's review.

'''Step 3: If instructor has reviewed the same work as you have reviewed, provide a way to show his review as well in ''Others work'''''

Files to be edited:
* '''View: ''' ''app/views/student_review/list.html.erb''
* '''Controller: ''' ''app/controllers/student_review_controller.rb'' - Method: view_team

[[File: Others_work_proposed.jpeg | center]]

If the instructor has reviewed the work of a team you have reviewed, there will be a link to view how the instructor has reviewed the same work. In case the instructor has not reviewed the work (like in case of review 4), there won't be any ''Instructor's Review'' link

== '''Test Plan''' ==

Many of our changes would be reflected on views (user interface). Following is the list of tests that should be conducted with rspec/capybara:

# it "should see the Perform Review link (beside Assign Grade link) for each submission after a list of submissions are pulled up by an instructor if the final due date for the assignment has passed"
# it "should see the Perform Review link only for each submission after a list of submissions are pulled up by an instructor if the final due date for the assignment has not passed and review period has started and review deadline has not passed"
# it "should see neither Perform Review link nor Assign Grade link after a list of submissions are pulled up by an instructor if the final due date for the assignment has not passed and review period has not started"
# it "should pull up a review page for the submission of the team after the Perform Review link is clicked on by an instructor"
# it "should show highlighted reviews done by instructors when a student views feedback on his/her submission"
# it "should pull up a calibration report when a student wants to see the difference between his/her reviews on other's submission and the instructor's"

== '''External Links''' ==
* Forked Repository: https://github.com/kushalnawalakha/expertiza
* Deployment: http://ec2-13-59-7-94.us-east-2.compute.amazonaws.com:3000/

== '''Team Members''' ==
*Ashis Sahoo
*Satvik Shetty
*Xiaohui Ellis
*Kushal Nawalakha

== '''References''' ==

Expertiza
* https://expertiza.ncsu.edu/

Expertiza Github
* https://github.com/expertiza/expertiza

Expertiza Documentation
* http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation

CSC/ECE 517 Spring 2018- Project E1824: Let course staff as well as students do reviews

2018-04-08T22:41:56Z

Smshetty: Details about the proposed design.

== '''Introduction''' ==

The way Expertiza is set up right now is that only peers can review your work. However, there are cases when the instructor would want to submit reviews as well. This project aims to implement this feature by allowing instructors to review the project on the same metrics as other students who review the project.

== '''Problem Statement''' ==

Peer review is a great way for students to learn about how well they have developed their application. However there are some problems with this:
* Sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development.
* The reviewer might not know how well they are reviewing the peer's work. They might not entirely know as to what tone to use or what suggestions to put forward.

By letting course staff perform reviews as well, the reviewer and the reviewee are both benefited, which can improve the overall learning experience.

=== Current scenario ===

This is how some of the pages we are concerned with, currently look.

==== Submissions page for an assignment in Instructor View ====

[[File: Submissions_instr.jpeg | center]]

==== A typical Scores table in a Student View ====

[[File: Grades_view_team_current.png | center]]

==== Others work reviewed in a Student View ====

[[File: Others_work_current.jpeg | center]]

== '''Proposed Solutions''' ==

We propose to perform the following changes to let staff perform reviews as well:

* Step 1: Add a "Perform review" link in the assignment submissions page view for the instructors. ===

Files to be edited:
* '''View: ''' ''app/views/assignments/list_submissions.html.erb''
* '''Controller: ''' ''app/controllers/response_controller.rb'' - Add authorization for instructors to perform review

[[File: Submissions_instr_new.jpeg | center]]

In the first case, there is a "Perform Review" as well as "Assign Grade" link if the final submission date has passed. The course staff will be allowed to perform a review even if the deadline for reviewing has passed.

In the second case, an intermediate submission deadline has passed and hence there is a link only for performing a review.

In the third case, if no submission deadline has passed, there won't be a link for Performing a review nor assigning a grade.

* Step 2: Add instructor review in "Your Scores" table in case he has reviewed your work. Provide a highlight/way to make it look distinct. ===

Files to be edited:
* '''View: ''' ''app/views/grades/view_team.html.erb''
* '''Controller: ''' ''app/controllers/grades_controller.rb'' - Method: view_team

[[File: Grades_view_team_instr.png | center]]

A student should be able to make out if an instructor has reviewed his/his team's work. In case the instructor performs a review on the team's work, it will highlight the intructor's review.

* Step 3: If instructor has reviewed the same work as you have reviewed, provide a way to show his review as well in "Others work" ===

Files to be edited:
* '''View: ''' ''app/views/student_review/list.html.erb''
* '''Controller: ''' ''app/controllers/student_review_controller.rb'' - Method: view_team

[[File: Others_work_proposed.jpeg | center]]

If the instructor has reviewed the work of a team you have reviewed, there will be a link to view how the instructor has reviewed the same work.

== '''Test Plan''' ==

Many of our changes would be reflected on views (user interface). Following is the list of tests that should be conducted with rspec/capybara:

# it "should see the Perform Review link (beside Assign Grade link) for each submission after a list of submissions are pulled up by an instructor if the final due date for the assignment has passed"
# it "should see the Perform Review link only for each submission after a list of submissions are pulled up by an instructor if the final due date for the assignment has not passed and review period has started and review deadline has not passed"
# it "should see neither Perform Review link nor Assign Grade link after a list of submissions are pulled up by an instructor if the final due date for the assignment has not passed and review period has not started"
# it "should pull up a review page for the submission of the team after the Perform Review link is clicked on by an instructor"
# it "should show highlighted reviews done by instructors when a student views feedback on his/her submission"
# it "should pull up a calibration report when a student wants to see the difference between his/her reviews on other's submission and the instructor's"

== '''External Links''' ==
* Forked Repository: https://github.com/kushalnawalakha/expertiza
* Deployment: http://ec2-13-59-7-94.us-east-2.compute.amazonaws.com:3000/

== '''Team Members''' ==
*Ashis Sahoo
*Satvik Shetty
*Xiaohui Ellis
*Kushal Nawalakha

== '''References''' ==

Expertiza
* https://expertiza.ncsu.edu/

Expertiza Github
* https://github.com/expertiza/expertiza

Expertiza Documentation
* http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation

CSC/ECE 517 Spring 2018- Project E1824: Let course staff as well as students do reviews

2018-04-08T22:27:26Z

Smshetty: Added external links

== '''Introduction''' ==

The way Expertiza is set up right now is that only peers can review your work. However, there are cases when the instructor would want to submit reviews as well. This project aims to implement this feature by allowing instructors to review the project on the same metrics as other students who review the project.

== '''Problem Statement''' ==

Peer review is a great way for students to learn about how well they have developed their application. However there are some problems with this:
* Sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development.
* The reviewer might not know how well they are reviewing the peer's work. They might not entirely know as to what tone to use or what suggestions to put forward.

By letting course staff perform reviews as well, the reviewer and the reviewee are both benefited, which can improve the overall learning experience.

=== Current scenario ===

This is how some of the pages we are concerned with, currently look.

==== Submissions page for an assignment in Instructor View ====

[[File: Submissions_instr.jpeg | center]]

==== A typical Scores table in a Student View ====

[[File: Grades_view_team_current.png | center]]

==== Others work reviewed in a Student View ====

[[File: Others_work_current.jpeg | center]]

== '''Proposed Solutions''' ==

We propose to perform the following changes to let staff perform reviews as well:

* Step 1: Add a "Perform review" link in the assignment submissions page view for the instructors. ===

Files to be edited:
* '''View: ''' ''app/views/assignments/list_submissions.html.erb''
* '''Controller: ''' ''app/controllers/response_controller.rb'' - Add authorization for instructors to perform review

[[File: Submissions_instr_new.jpeg | center]]

* Step 2: Add instructor review in "Your Scores" table in case he has reviewed your work. Provide a highlight/way to make it look distinct. ===

Files to be edited:
* '''View: ''' ''app/views/grades/view_team.html.erb''
* '''Controller: ''' ''app/controllers/grades_controller.rb'' - Method: view_team

[[File: Grades_view_team_instr.png | center]]

* Step 3: If instructor has reviewed the same work as you have reviewed, provide a way to show his review as well in "Others work" ===

Files to be edited:
* '''View: ''' ''app/views/student_review/list.html.erb''
* '''Controller: ''' ''app/controllers/student_review_controller.rb'' - Method: view_team

[[File: Others_work_proposed.jpeg | center]]

== '''Test Plan''' ==

Many of our changes would be reflected on views (user interface). Following is the list of tests that should be conducted with rspec/capybara:

# it "should see the Perform Review link (beside Assign Grade link) for each submission after a list of submissions are pulled up by an instructor if the final due date for the assignment has passed"
# it "should see the Perform Review link only for each submission after a list of submissions are pulled up by an instructor if the final due date for the assignment has not passed and review period has started and review deadline has not passed"
# it "should see neither Perform Review link nor Assign Grade link after a list of submissions are pulled up by an instructor if the final due date for the assignment has not passed and review period has not started"
# it "should pull up a review page for the submission of the team after the Perform Review link is clicked on by an instructor"
# it "should show highlighted reviews done by instructors when a student views feedback on his/her submission"
# it "should pull up a calibration report when a student wants to see the difference between his/her reviews on other's submission and the instructor's"

== '''External Links''' ==
* Forked Repository:
* Deployment: http://ec2-13-59-7-94.us-east-2.compute.amazonaws.com:3000/

== '''Team Members''' ==
*Ashis Sahoo
*Satvik Shetty
*Xiaohui Ellis
*Kushal Nawalakha

== '''References''' ==

Expertiza
* https://expertiza.ncsu.edu/

Expertiza Github
* https://github.com/expertiza/expertiza

Expertiza Documentation
* http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation

CSC/ECE 517 Spring 2018- Project E1824: Let course staff as well as students do reviews

2018-04-08T22:24:49Z

Smshetty: Design document for this project

== '''Introduction''' ==

The way Expertiza is set up right now is that only peers can review your work. However, there are cases when the instructor would want to submit reviews as well. This project aims to implement this feature by allowing instructors to review the project on the same metrics as other students who review the project.

== '''Problem Statement''' ==

Peer review is a great way for students to learn about how well they have developed their application. However there are some problems with this:
* Sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development.
* The reviewer might not know how well they are reviewing the peer's work. They might not entirely know as to what tone to use or what suggestions to put forward.

By letting course staff perform reviews as well, the reviewer and the reviewee are both benefited, which can improve the overall learning experience.

=== Current scenario ===

This is how some of the pages we are concerned with, currently look.

==== Submissions page for an assignment in Instructor View ====

[[File: Submissions_instr.jpeg | center]]

==== A typical Scores table in a Student View ====

[[File: Grades_view_team_current.png | center]]

==== Others work reviewed in a Student View ====

[[File: Others_work_current.jpeg | center]]

== '''Proposed Solutions''' ==

We propose to perform the following changes to let staff perform reviews as well:

* Step 1: Add a "Perform review" link in the assignment submissions page view for the instructors. ===

Files to be edited:
* '''View: ''' ''app/views/assignments/list_submissions.html.erb''
* '''Controller: ''' ''app/controllers/response_controller.rb'' - Add authorization for instructors to perform review

[[File: Submissions_instr_new.jpeg | center]]

* Step 2: Add instructor review in "Your Scores" table in case he has reviewed your work. Provide a highlight/way to make it look distinct. ===

Files to be edited:
* '''View: ''' ''app/views/grades/view_team.html.erb''
* '''Controller: ''' ''app/controllers/grades_controller.rb'' - Method: view_team

[[File: Grades_view_team_instr.png | center]]

* Step 3: If instructor has reviewed the same work as you have reviewed, provide a way to show his review as well in "Others work" ===

Files to be edited:
* '''View: ''' ''app/views/student_review/list.html.erb''
* '''Controller: ''' ''app/controllers/student_review_controller.rb'' - Method: view_team

[[File: Others_work_proposed.jpeg | center]]

== '''Test Plan''' ==

Many of our changes would be reflected on views (user interface). Following is the list of tests that should be conducted with rspec/capybara:

# it "should see the Perform Review link (beside Assign Grade link) for each submission after a list of submissions are pulled up by an instructor if the final due date for the assignment has passed"
# it "should see the Perform Review link only for each submission after a list of submissions are pulled up by an instructor if the final due date for the assignment has not passed"
# it "should pull up a review page for the submission of the team after the Perform Review link is clicked on by an instructor"
# it "should show highlighted reviews done by instructors when a student views feedback on his/her submission"
# it "should pull up a calibration report when a student wants to see the difference between his/her reviews on other's submission and the instructor's"

== '''Team Members''' ==
*Ashis Sahoo
*Satvik Shetty
*Xiaohui Ellis
*Kushal Nawalakha

== '''References''' ==

Expertiza
* https://expertiza.ncsu.edu/

Expertiza Github
* https://github.com/expertiza/expertiza

Expertiza Documentation
* http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation

File:Others work proposed.jpeg

2018-04-08T22:21:23Z

Smshetty: Proposed design for others work

Proposed design for others work

File:Others work current.jpeg

2018-04-08T22:18:45Z

Smshetty: The current view for other's work in a student's view

The current view for other's work in a student's view

CSC/ECE 517 Spring 2018- Project E1824: Let course staff as well as students do reviews

2018-04-08T22:12:56Z

Smshetty: Added details related to problem statement and proposed solutions

File:Submissions instr new.jpeg

2018-04-08T22:06:08Z

Smshetty: Proposed view for an instructor with a link to perform reviews

Proposed view for an instructor with a link to perform reviews

File:Submissions instr.jpeg

2018-04-08T22:04:20Z

Smshetty: Current submissions view for an instructor

Current submissions view for an instructor

File:Grades view team instr.png

2018-04-08T21:45:05Z

Smshetty: Proposed design for view after adding staff review

Proposed design for view after adding staff review

CSC/ECE 517 Spring 2018- Project E1824: Let course staff as well as students do reviews

2018-04-08T21:41:47Z

Smshetty: /* Problem Statement */

== '''Introduction''' ==

The way Expertiza is set up right now is that only peers can review your work. However, there are cases when the instructor would want to submit reviews as well. This project aims to implement this feature.

== '''Problem Statement''' ==

Peer review is a great way for students to learn about how well they have developed their application. However there are some problems with this:
* Sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development.
* The reviewer might not know how well they are reviewing the peer's work. They might not entirely know as to what tone to use or what suggestions to put forward.

Currently this is how a typical review table looks like:

[[File: Grades_view_team_current.png]]

By letting course staff perform reviews as well, the reviewer and the reviewee are both benefited, which can improve the overall learning experience.

== '''Proposed Solutions''' ==

== '''Test Plan''' ==

== '''Team Members''' ==
*Ashis Sahoo
*Satvik Shetty
*Xiaohui Ellis
*Kushal Nawalakha

== '''References''' ==

Expertiza
* https://expertiza.ncsu.edu/

Expertiza Github
* https://github.com/expertiza/expertiza

Expertiza Documentation
* http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation

File:Grades view team current.png

2018-04-08T21:40:18Z

Smshetty: Current view for review grades

Current view for review grades

CSC/ECE 517 Spring 2018- Project E1824: Let course staff as well as students do reviews

2018-04-08T21:04:40Z

Smshetty: Initial Draft

== '''Introduction''' ==

The way Expertiza is set up right now is that only peers can review your work. However, there are cases when the instructor would want to submit reviews as well. This project aims to implement this feature.

== '''Problem Statement''' ==

Peer review is a great way for students to learn about how well they have developed their application. However there are some problems with this:
* Sometimes, the peer reviews may not be thorough and the team/person's work reviewed might not reflect the actual status of the development.
* The reviewer might not know how well they are reviewing the peer's work. They might not entirely know as to what tone to use or what suggestions to put forward.

By letting course staff perform reviews as well, the reviewer and the reviewee are both benefited, which can improve the overall learning experience.

== '''Proposed Solutions''' ==

== '''Test Plan''' ==

== '''Team Members''' ==
*Ashis Sahoo
*Satvik Shetty
*Xiaohui Ellis
*Kushal Nawalakha

== '''References''' ==

Expertiza
* https://expertiza.ncsu.edu/

Expertiza Github
* https://github.com/expertiza/expertiza

Expertiza Documentation
* http://wiki.expertiza.ncsu.edu/index.php/Expertiza_documentation