Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-30T05:00:10Z

Sdsayani:

== Project Background ==
Heatgrid is the page where instructor can visit and view the work done by participant using Reviews, Author Feedbacks and Meta Reviews. This one web page displays all the evaluations done by peers of the participant for his project. The page is displayed in the format of table with colors. The columns in the table can be sorted with the requirement of the project. Heatgrid shows scores assigned by reviewers on individual rubric items for participant.

===What is wrong with it===
HeatGrid page is called from Instructor's "Assign Grades" function and student's view scores functions.

There are two issues assigned to us:-

* The first is that the column name "metric-1" in the heatgrid is not self-explanatory and needs to be changed. Also, we need to change it in such a way that in later stages if the instructor wants to add a new metric for the assignment, he/she should be add it with just a minor changes.
*The problem in the second issue is when an instructor tries to Assign Grades to a student 9277 for Madeup Problem 3, he/she is not able see the Round-1 Reviews. However, with the databases (old database) we were provided with do not have any student with Student id: 9277, and the assignment Madeup Problem 3 hasn't even existed. Also,

=Issue 1869=
== Problem Definition ==
Notes that there is a “metric-1” column in the review report, but it doesn’t say what the metric is. Please figure out what the metric is, and change the column header accordingly. However, the intent was that eventually an instructor would be allowed to select a metric to be shown on the heatgrid. So, somewhere in the UI for creating/editing an assignment, there should be a way for the instructor to select a metric from a dropdown list. You don’t have to add any more metrics to this list other than the one that is currently displayed, just create a mechanism for adding metrics in the future.

== Current Implementation ==

=== Overview ===
In the current implementation, the columns in the heatgrid table are static. The "metric-1" column in the table represents the count of comments for the respective question which have a word count greater than 10. On hovering over the column name, the correct information is displayed but the name itself does not make the information apparent at first glance.

=== UI Screenshots ===
The following image captures how the heatgrid is currently being displayed:

[[File:Summary Report.png|1200px|thumb|center]]

== Plan of work ==

=== Current Implementation Detail ===
* In the view_team.html.erb and instead of pre-assigned value to be metric-1, a dropdown will be populated and the instructor can choose the metric for the review. By default in the dropdown, there will be only one metric to count the verbose comments.

* Now, if the instructor wants to add any new metric, he/she just need to add the method for the metric in the app/views/assignment/edit/_general.html.erb file and that value will be stored in the database as a string in the heatgrid_metric variable and the same will be populated in the view of the heatgrid.

=== Implementation Control Flow ===
[[File:1869CF.drawio.png|1200px|thumb|center]]

=== Proposed Control Flow For Adding a Metric ===
[[File:1869NewCF.png|1200px|thumb|center]]

== Detailed Implementation==
* In the database in the assignments table, one column named "heatgrid_metric" is added which will store the value of the dropdown menu.
* app/views/assignments/edit/_general.html.erb:- In this file we have added the dropdown which takes the metric from the instructor and sets the metric accordingly. The code we added is mentioned below:-
<pre>
<tr>
<td style='padding:5px' id='assignment_metrics_field'>
<%= label_tag('assignment_form[assignment][heatgrid_metric]', 'Select a Metric to be displayed in the Report Heatgrid:') %>
<%= select('assignment_form[assignment]', 'heatgrid_metric', [['--', ''], %w[Verbose-Comment-Count countofcomments]],
{ :selected => @assignment_form.assignment.heatgrid_metric}, { :class => 'form-control', :style => 'width: 100px'}) %>
</td>
</tr>
</pre>

We have added assigned two values to the dropdown:- '--' and 'Verbose-Comment-Count'. This is how it looks after adding this dropdown on the expertiza:-

[[File: Assignment General page.png]]

* app/views/grades/view_team.html.erb:- In this file, there is a view for the heatgrid, so when the instructor clicks on Assign Grades, the view from this file is rendered. So, the column name is changed here from "metric-1" to "countofcomments" variable, which will take the store the value of the dropdown selected.

The code that we have changed is:-

<pre>

<% case @assignment.heatgrid_metric %>
<% when 'countofcomments' %>
<th class="sorter-false">
 10. The purpose of this metric is to represent how many comments for the question are
of a substantial length to provide quality feedback.">Verbose Comment Count
</th>
<%end%>
</pre>

This is how it now looks on expertiza:

[[File:Heatgrid-metric.png]]

== Test Plan ==
* Capybara Test cases for the heat grid view are added to select the value from the dropdown menu. Both the 'Verbose-Comment-Count' and '--' are added.
<pre>
it "is able to create a public assignment with countofcomments metric" do
login_as("instructor6")
visit "/assignments/new?private=0"

fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
fill_in 'assignment_form_assignment_spec_location', with: 'testLocation'
check("assignment_form_assignment_microtask")
check("assignment_form_assignment_reviews_visible_to_all")
check("assignment_form_assignment_is_calibrated")
uncheck("assignment_form_assignment_availability_flag")
expect(page).to have_select("assignment_form[assignment][reputation_algorithm]", options: %w[-- Hamer Lauw])
select "Verbose-Comment-Count", from: 'countsofcomment'

click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
name: 'public assignment for test',
course_id: Course.find_by(name: 'Course 2').id,
directory_path: 'testDirectory',
spec_location: 'testLocation',
microtask: true,
is_calibrated: true,
availability_flag: false,
heatgrid_metric: 'countofcomments'
)
end

it "is able to create a public assignment with no metrics expected" do
login_as("instructor6")
visit "/assignments/new?private=0"

fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
fill_in 'assignment_form_assignment_spec_location', with: 'testLocation'
check("assignment_form_assignment_microtask")
check("assignment_form_assignment_reviews_visible_to_all")
check("assignment_form_assignment_is_calibrated")
uncheck("assignment_form_assignment_availability_flag")
expect(page).to have_select("assignment_form[assignment][reputation_algorithm]", options: %w[-- Hamer Lauw])
select "--", from: 'countsofcomment'

click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
name: 'public assignment for test',
course_id: Course.find_by(name: 'Course 2').id,
directory_path: 'testDirectory',
spec_location: 'testLocation',
microtask: true,
is_calibrated: true,
availability_flag: false,
heatgrid_metric: ''
)
end
</pre>
Spec test cases are added for the grades controller should be added to verify the responses returned from the controller.
<pre>
describe '#create with countofcomments' do
before(:each) do
allow(AssignmentForm).to receive(:new).with(any_args).and_return(assignment_form)
@params = {
button: '',
assignment_form: {
assignment_questionnaire: [{"assignment_id" => "1", "questionnaire_id" => "666", "dropdown" => "true",
"questionnaire_weight" => "100", "notification_limit" => "15", "used_in_round" => "1"}],
due_date: [{"id" => "", "parent_id" => "", "round" => "1", "deadline_type_id" => "1", "due_at" => "2017/12/05 00:00", "submission_allowed_id" => "3", "review_allowed_id" => "1", "teammate_review_allowed_id" => "3", "review_of_review_allowed_id" => "1", "threshold" => "1"},
{"id" => "", "parent_id" => "", "round" => "1", "deadline_type_id" => "2", "due_at" => "2017/12/02 00:00", "submission_allowed_id" => "1", "review_allowed_id" => "3", "teammate_review_allowed_id" => "3", "review_of_review_allowed_id" => "1", "threshold" => "1"}],
assignment: {
instructor_id: 2,
course_id: 1,
max_team_size: 1,
id: 1,
name: 'test assignment',
directory_path: '/test',
spec_location: '',
private: false,
show_teammate_reviews: false,
require_quiz: false,
num_quiz_questions: 0,
staggered_deadline: false,
microtask: false,
reviews_visible_to_all: false,
is_calibrated: false,
availability_flag: true,
reputation_algorithm: 'Lauw',
heatgrid_metric: 'countofcomments',
simicheck: -1,
simicheck_threshold: 100
}
}
}
end
context 'when assignment_form is saved successfully' do
it 'redirects to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by).with(id: 1).and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
post :create, @params
expect(response).to render_template(:new)
end
end
end
</pre>
* Unit test cases are added to verify the logic of the number_of_comments_greater_than_10_words method of the vm_question_response model.
<pre>
describe '#heatgrid_metric' do
it 'returns countofcomments by default' do
assignment = create(:assignment)
expect(assignment.heatgrid_metric).to eq('countofcomments')
end

it 'none value can be selected' do
assignment = build(:assignment, heatgrid_metric: '')
expect(assignment.heatgrid_metric).to eq('')
end
end
</pre>

=Issue 2019=
== Problem Definition ==
When an instructor is trying to Assign a Grade for student 9277, he/she is not able to see Reviews for Round-1. However, we were not able to reproduce the same issue, as the student with id-9277 does not exist in our database.

== Current Implementation ==

=== Overview ===
In the current review system implementation, the instructor has the ability to select or deselect the "Review rubric varies by round?" checkbox from the "Rubrics" tab of the Edit Assignment page. On selecting this checkbox, the reviewer is able to see all Rounds of Reviews.

=== UI Screenshots ===
The following images show how this functionality works currently:

[[File:Rubrics-page.png ]]

[[File:Heatgrid-metric.png]]

As you can see, the instructor is able to see both the Round of reviews.

Now, if we deselect it, then the heatgrid metric view page looks as follows:-

[[File:Heatgrid-wrong.png]]

== Implementation ==
So, as mentioned above, it works as intended, so if the instructor wants to see all the rounds of reviews, he/she have to mark the checkbox "Review rubric varies by round?" to true, then only it can be done. So, for that we have added a fix, we have set the value of the assignment to be true. For that, we created one migration that will set the value to true. Code looks as below:-

<pre>
class UpdateVaryByRoundToAssignments < ActiveRecord::Migration
def change
change_column :assignments, :vary_by_round, :boolean, :default => true
end
end
</pre>

= Important Links =
* GitHub repository link: https://github.com/ShlokSayani/expertiza
* GitHub repository PR link: https://github.com/expertiza/expertiza/pull/2125/files
* Project Description Document: https://docs.google.com/document/d/1slx4HPIbgTH-psIKMSCF-HDF9brxf-FuYhzVT9ZiIrM/edit#heading=h.tqdrrd12xs4x
* GitHub Issue #1869: https://github.com/expertiza/expertiza/issues/1869
* Video Link for Issue #1869: https://www.youtube.com/watch?v=UAc_wI8ojkU
* GitHub Issue #2019: https://github.com/expertiza/expertiza/issues/2019

= Team =

* Shlok Sayani (sdsayani)

* Hardik Udeshi (hvudeshi)

* Isha Gupta (igupta)

* Manish Shinde (msshinde)

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-30T04:59:29Z

Sdsayani: /* Plan of work */

== Project Background ==
Heatgrid is the page where instructor can visit and view the work done by participant using Reviews, Author Feedbacks and Meta Reviews. This one web page displays all the evaluations done by peers of the participant for his project. The page is displayed in the format of table with colors. The columns in the table can be sorted with the requirement of the project. Heatgrid shows scores assigned by reviewers on individual rubric items for participant.

===What is wrong with it===
HeatGrid page is called from Instructor's "Assign Grades" function and student's view scores functions.

There are two issues assigned to us:-

* The first is that the column name "metric-1" in the heatgrid is not self-explanatory and needs to be changed. Also, we need to change it in such a way that in later stages if the instructor wants to add a new metric for the assignment, he/she should be add it with just a minor changes.
*The problem in the second issue is when an instructor tries to Assign Grades to a student 9277 for Madeup Problem 3, he/she is not able see the Round-1 Reviews. However, with the databases (old database) we were provided with do not have any student with Student id: 9277, and the assignment Madeup Problem 3 hasn't even existed. Also,

=Issue 1869=
== Problem Definition ==
Notes that there is a “metric-1” column in the review report, but it doesn’t say what the metric is. Please figure out what the metric is, and change the column header accordingly. However, the intent was that eventually an instructor would be allowed to select a metric to be shown on the heatgrid. So, somewhere in the UI for creating/editing an assignment, there should be a way for the instructor to select a metric from a dropdown list. You don’t have to add any more metrics to this list other than the one that is currently displayed, just create a mechanism for adding metrics in the future.

== Current Implementation ==

=== Overview ===
In the current implementation, the columns in the heatgrid table are static. The "metric-1" column in the table represents the count of comments for the respective question which have a word count greater than 10. On hovering over the column name, the correct information is displayed but the name itself does not make the information apparent at first glance.

=== UI Screenshots ===
The following image captures how the heatgrid is currently being displayed:

[[File:Summary Report.png|1200px|thumb|center]]

== Plan of work ==

=== Current Implementation Detail ===
* In the view_team.html.erb and instead of pre-assigned value to be metric-1, a dropdown will be populated and the instructor can choose the metric for the review. By default in the dropdown, there will be only one metric to count the verbose comments.

* Now, if the instructor wants to add any new metric, he/she just need to add the method for the metric in the app/views/assignment/edit/_general.html.erb file and that value will be stored in the database as a string in the heatgrid_metric variable and the same will be populated in the view of the heatgrid.

=== Implementation Control Flow ===
[[File:1869CF.drawio.png|1200px|thumb|center]]

=== Proposed Control Flow For Adding a Metric ===
[[File:1869NewCF.png|1200px|thumb|center]]

== Detailed Implementation==
* In the database in the assignments table, one column named "heatgrid_metric" is added which will store the value of the dropdown menu.
* app/views/assignments/edit/_general.html.erb:- In this file we have added the dropdown which takes the metric from the instructor and sets the metric accordingly. The code we added is mentioned below:-
<pre>
<tr>
<td style='padding:5px' id='assignment_metrics_field'>
<%= label_tag('assignment_form[assignment][heatgrid_metric]', 'Select a Metric to be displayed in the Report Heatgrid:') %>
<%= select('assignment_form[assignment]', 'heatgrid_metric', [['--', ''], %w[Verbose-Comment-Count countofcomments]],
{ :selected => @assignment_form.assignment.heatgrid_metric}, { :class => 'form-control', :style => 'width: 100px'}) %>
</td>
</tr>
</pre>

We have added assigned two values to the dropdown:- '--' and 'Verbose-Comment-Count'. This is how it looks after adding this dropdown on the expertiza:-

[[File: Assignment General page.png]]

* app/views/grades/view_team.html.erb:- In this file, there is a view for the heatgrid, so when the instructor clicks on Assign Grades, the view from this file is rendered. So, the column name is changed here from "metric-1" to "countofcomments" variable, which will take the store the value of the dropdown selected.

The code that we have changed is:-

<pre>

<% case @assignment.heatgrid_metric %>
<% when 'countofcomments' %>
<th class="sorter-false">
 10. The purpose of this metric is to represent how many comments for the question are
of a substantial length to provide quality feedback.">Verbose Comment Count
</th>
<%end%>
</pre>

This is how it now looks on expertiza:

[[File:Heatgrid-metric.png]]

== Test Plan ==
* Capybara Test cases for the heat grid view are added to select the value from the dropdown menu. Both the 'Verbose-Comment-Count' and '--' are added.
<pre>
it "is able to create a public assignment with countofcomments metric" do
login_as("instructor6")
visit "/assignments/new?private=0"

fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
fill_in 'assignment_form_assignment_spec_location', with: 'testLocation'
check("assignment_form_assignment_microtask")
check("assignment_form_assignment_reviews_visible_to_all")
check("assignment_form_assignment_is_calibrated")
uncheck("assignment_form_assignment_availability_flag")
expect(page).to have_select("assignment_form[assignment][reputation_algorithm]", options: %w[-- Hamer Lauw])
select "Verbose-Comment-Count", from: 'countsofcomment'

click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
name: 'public assignment for test',
course_id: Course.find_by(name: 'Course 2').id,
directory_path: 'testDirectory',
spec_location: 'testLocation',
microtask: true,
is_calibrated: true,
availability_flag: false,
heatgrid_metric: 'countofcomments'
)
end

it "is able to create a public assignment with no metrics expected" do
login_as("instructor6")
visit "/assignments/new?private=0"

fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
fill_in 'assignment_form_assignment_spec_location', with: 'testLocation'
check("assignment_form_assignment_microtask")
check("assignment_form_assignment_reviews_visible_to_all")
check("assignment_form_assignment_is_calibrated")
uncheck("assignment_form_assignment_availability_flag")
expect(page).to have_select("assignment_form[assignment][reputation_algorithm]", options: %w[-- Hamer Lauw])
select "--", from: 'countsofcomment'

click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
name: 'public assignment for test',
course_id: Course.find_by(name: 'Course 2').id,
directory_path: 'testDirectory',
spec_location: 'testLocation',
microtask: true,
is_calibrated: true,
availability_flag: false,
heatgrid_metric: ''
)
end
</pre>
Spec test cases are added for the grades controller should be added to verify the responses returned from the controller.
<pre>
describe '#create with countofcomments' do
before(:each) do
allow(AssignmentForm).to receive(:new).with(any_args).and_return(assignment_form)
@params = {
button: '',
assignment_form: {
assignment_questionnaire: [{"assignment_id" => "1", "questionnaire_id" => "666", "dropdown" => "true",
"questionnaire_weight" => "100", "notification_limit" => "15", "used_in_round" => "1"}],
due_date: [{"id" => "", "parent_id" => "", "round" => "1", "deadline_type_id" => "1", "due_at" => "2017/12/05 00:00", "submission_allowed_id" => "3", "review_allowed_id" => "1", "teammate_review_allowed_id" => "3", "review_of_review_allowed_id" => "1", "threshold" => "1"},
{"id" => "", "parent_id" => "", "round" => "1", "deadline_type_id" => "2", "due_at" => "2017/12/02 00:00", "submission_allowed_id" => "1", "review_allowed_id" => "3", "teammate_review_allowed_id" => "3", "review_of_review_allowed_id" => "1", "threshold" => "1"}],
assignment: {
instructor_id: 2,
course_id: 1,
max_team_size: 1,
id: 1,
name: 'test assignment',
directory_path: '/test',
spec_location: '',
private: false,
show_teammate_reviews: false,
require_quiz: false,
num_quiz_questions: 0,
staggered_deadline: false,
microtask: false,
reviews_visible_to_all: false,
is_calibrated: false,
availability_flag: true,
reputation_algorithm: 'Lauw',
heatgrid_metric: 'countofcomments',
simicheck: -1,
simicheck_threshold: 100
}
}
}
end
context 'when assignment_form is saved successfully' do
it 'redirects to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by).with(id: 1).and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
post :create, @params
expect(response).to render_template(:new)
end
end
end
</pre>
* Unit test cases are added to verify the logic of the number_of_comments_greater_than_10_words method of the vm_question_response model.
<pre>
describe '#heatgrid_metric' do
it 'returns countofcomments by default' do
assignment = create(:assignment)
expect(assignment.heatgrid_metric).to eq('countofcomments')
end

it 'none value can be selected' do
assignment = build(:assignment, heatgrid_metric: '')
expect(assignment.heatgrid_metric).to eq('')
end
end
</pre>

=Issue 2019=
== Problem Definition ==
When an instructor is trying to Assign a Grade for student 9277, he/she is not able to see Reviews for Round-1. However, we were not able to reproduce the same issue, as the student with id-9277 does not exist in our database.

== Current Implementation ==

=== Overview ===
In the current review system implementation, the instructor has the ability to select or deselect the "Review rubric varies by round?" checkbox from the "Rubrics" tab of the Edit Assignment page. On selecting this checkbox, the reviewer is able to see all Rounds of Reviews.

=== UI Screenshots ===
The following images show how this functionality works currently:

[[File:Rubrics-page.png ]]

[[File:Heatgrid-metric.png]]

As you can see, the instructor is able to see both the Round of reviews.

Now, if we deselect it, then the heatgrid metric view page looks as follows:-

[[File:Heatgrid-wrong.png]]

== Implementation ==
So, as mentioned above, it works as intended, so if the instructor wants to see all the rounds of reviews, he/she have to mark the checkbox "Review rubric varies by round?" to true, then only it can be done. So, for that we have added a fix, we have set the value of the assignment to be true. For that, we created one migration that will set the value to true. Code looks as below:-

<pre>
class UpdateVaryByRoundToAssignments < ActiveRecord::Migration
def change
change_column :assignments, :vary_by_round, :boolean, :default => true
end
end
</pre>

= Important Links =
* GitHub repository link: https://github.com/ShlokSayani/expertiza
* Project Description Document: https://docs.google.com/document/d/1slx4HPIbgTH-psIKMSCF-HDF9brxf-FuYhzVT9ZiIrM/edit#heading=h.tqdrrd12xs4x
* GitHub Issue #1869: https://github.com/expertiza/expertiza/issues/1869
* Video Link for Issue #1869: https://www.youtube.com/watch?v=UAc_wI8ojkU
* GitHub Issue #2019: https://github.com/expertiza/expertiza/issues/2019

= Team =

* Shlok Sayani (sdsayani)

* Hardik Udeshi (hvudeshi)

* Isha Gupta (igupta)

* Manish Shinde (msshinde)

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-30T04:58:54Z

Sdsayani: /* Plan of work */

== Project Background ==
Heatgrid is the page where instructor can visit and view the work done by participant using Reviews, Author Feedbacks and Meta Reviews. This one web page displays all the evaluations done by peers of the participant for his project. The page is displayed in the format of table with colors. The columns in the table can be sorted with the requirement of the project. Heatgrid shows scores assigned by reviewers on individual rubric items for participant.

===What is wrong with it===
HeatGrid page is called from Instructor's "Assign Grades" function and student's view scores functions.

There are two issues assigned to us:-

* The first is that the column name "metric-1" in the heatgrid is not self-explanatory and needs to be changed. Also, we need to change it in such a way that in later stages if the instructor wants to add a new metric for the assignment, he/she should be add it with just a minor changes.
*The problem in the second issue is when an instructor tries to Assign Grades to a student 9277 for Madeup Problem 3, he/she is not able see the Round-1 Reviews. However, with the databases (old database) we were provided with do not have any student with Student id: 9277, and the assignment Madeup Problem 3 hasn't even existed. Also,

=Issue 1869=
== Problem Definition ==
Notes that there is a “metric-1” column in the review report, but it doesn’t say what the metric is. Please figure out what the metric is, and change the column header accordingly. However, the intent was that eventually an instructor would be allowed to select a metric to be shown on the heatgrid. So, somewhere in the UI for creating/editing an assignment, there should be a way for the instructor to select a metric from a dropdown list. You don’t have to add any more metrics to this list other than the one that is currently displayed, just create a mechanism for adding metrics in the future.

== Current Implementation ==

=== Overview ===
In the current implementation, the columns in the heatgrid table are static. The "metric-1" column in the table represents the count of comments for the respective question which have a word count greater than 10. On hovering over the column name, the correct information is displayed but the name itself does not make the information apparent at first glance.

=== UI Screenshots ===
The following image captures how the heatgrid is currently being displayed:

[[File:Summary Report.png|1200px|thumb|center]]

== Plan of work ==

=== Current Implemented Detail ===
* In the view_team.html.erb and instead of pre-assigned value to be metric-1, a dropdown will be populated and the instructor can choose the metric for the review. By default in the dropdown, there will be only one metric to count the verbose comments.

* Now, if the instructor wants to add any new metric, he/she just need to add the method for the metric in the app/views/assignment/edit/_general.html.erb file and that value will be stored in the database as a string in the heatgrid_metric variable and the same will be populated in the view of the heatgrid.

=== Proposed Control Flow ===
[[File:1869CF.drawio.png|1200px|thumb|center]]

=== Proposed Control Flow For Adding a Metric ===
[[File:1869NewCF.png|1200px|thumb|center]]

== Detailed Implementation==
* In the database in the assignments table, one column named "heatgrid_metric" is added which will store the value of the dropdown menu.
* app/views/assignments/edit/_general.html.erb:- In this file we have added the dropdown which takes the metric from the instructor and sets the metric accordingly. The code we added is mentioned below:-
<pre>
<tr>
<td style='padding:5px' id='assignment_metrics_field'>
<%= label_tag('assignment_form[assignment][heatgrid_metric]', 'Select a Metric to be displayed in the Report Heatgrid:') %>
<%= select('assignment_form[assignment]', 'heatgrid_metric', [['--', ''], %w[Verbose-Comment-Count countofcomments]],
{ :selected => @assignment_form.assignment.heatgrid_metric}, { :class => 'form-control', :style => 'width: 100px'}) %>
</td>
</tr>
</pre>

We have added assigned two values to the dropdown:- '--' and 'Verbose-Comment-Count'. This is how it looks after adding this dropdown on the expertiza:-

[[File: Assignment General page.png]]

* app/views/grades/view_team.html.erb:- In this file, there is a view for the heatgrid, so when the instructor clicks on Assign Grades, the view from this file is rendered. So, the column name is changed here from "metric-1" to "countofcomments" variable, which will take the store the value of the dropdown selected.

The code that we have changed is:-

<pre>

<% case @assignment.heatgrid_metric %>
<% when 'countofcomments' %>
<th class="sorter-false">
 10. The purpose of this metric is to represent how many comments for the question are
of a substantial length to provide quality feedback.">Verbose Comment Count
</th>
<%end%>
</pre>

This is how it now looks on expertiza:

[[File:Heatgrid-metric.png]]

== Test Plan ==
* Capybara Test cases for the heat grid view are added to select the value from the dropdown menu. Both the 'Verbose-Comment-Count' and '--' are added.
<pre>
it "is able to create a public assignment with countofcomments metric" do
login_as("instructor6")
visit "/assignments/new?private=0"

fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
fill_in 'assignment_form_assignment_spec_location', with: 'testLocation'
check("assignment_form_assignment_microtask")
check("assignment_form_assignment_reviews_visible_to_all")
check("assignment_form_assignment_is_calibrated")
uncheck("assignment_form_assignment_availability_flag")
expect(page).to have_select("assignment_form[assignment][reputation_algorithm]", options: %w[-- Hamer Lauw])
select "Verbose-Comment-Count", from: 'countsofcomment'

click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
name: 'public assignment for test',
course_id: Course.find_by(name: 'Course 2').id,
directory_path: 'testDirectory',
spec_location: 'testLocation',
microtask: true,
is_calibrated: true,
availability_flag: false,
heatgrid_metric: 'countofcomments'
)
end

it "is able to create a public assignment with no metrics expected" do
login_as("instructor6")
visit "/assignments/new?private=0"

fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
fill_in 'assignment_form_assignment_spec_location', with: 'testLocation'
check("assignment_form_assignment_microtask")
check("assignment_form_assignment_reviews_visible_to_all")
check("assignment_form_assignment_is_calibrated")
uncheck("assignment_form_assignment_availability_flag")
expect(page).to have_select("assignment_form[assignment][reputation_algorithm]", options: %w[-- Hamer Lauw])
select "--", from: 'countsofcomment'

click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
name: 'public assignment for test',
course_id: Course.find_by(name: 'Course 2').id,
directory_path: 'testDirectory',
spec_location: 'testLocation',
microtask: true,
is_calibrated: true,
availability_flag: false,
heatgrid_metric: ''
)
end
</pre>
Spec test cases are added for the grades controller should be added to verify the responses returned from the controller.
<pre>
describe '#create with countofcomments' do
before(:each) do
allow(AssignmentForm).to receive(:new).with(any_args).and_return(assignment_form)
@params = {
button: '',
assignment_form: {
assignment_questionnaire: [{"assignment_id" => "1", "questionnaire_id" => "666", "dropdown" => "true",
"questionnaire_weight" => "100", "notification_limit" => "15", "used_in_round" => "1"}],
due_date: [{"id" => "", "parent_id" => "", "round" => "1", "deadline_type_id" => "1", "due_at" => "2017/12/05 00:00", "submission_allowed_id" => "3", "review_allowed_id" => "1", "teammate_review_allowed_id" => "3", "review_of_review_allowed_id" => "1", "threshold" => "1"},
{"id" => "", "parent_id" => "", "round" => "1", "deadline_type_id" => "2", "due_at" => "2017/12/02 00:00", "submission_allowed_id" => "1", "review_allowed_id" => "3", "teammate_review_allowed_id" => "3", "review_of_review_allowed_id" => "1", "threshold" => "1"}],
assignment: {
instructor_id: 2,
course_id: 1,
max_team_size: 1,
id: 1,
name: 'test assignment',
directory_path: '/test',
spec_location: '',
private: false,
show_teammate_reviews: false,
require_quiz: false,
num_quiz_questions: 0,
staggered_deadline: false,
microtask: false,
reviews_visible_to_all: false,
is_calibrated: false,
availability_flag: true,
reputation_algorithm: 'Lauw',
heatgrid_metric: 'countofcomments',
simicheck: -1,
simicheck_threshold: 100
}
}
}
end
context 'when assignment_form is saved successfully' do
it 'redirects to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by).with(id: 1).and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
post :create, @params
expect(response).to render_template(:new)
end
end
end
</pre>
* Unit test cases are added to verify the logic of the number_of_comments_greater_than_10_words method of the vm_question_response model.
<pre>
describe '#heatgrid_metric' do
it 'returns countofcomments by default' do
assignment = create(:assignment)
expect(assignment.heatgrid_metric).to eq('countofcomments')
end

it 'none value can be selected' do
assignment = build(:assignment, heatgrid_metric: '')
expect(assignment.heatgrid_metric).to eq('')
end
end
</pre>

=Issue 2019=
== Problem Definition ==
When an instructor is trying to Assign a Grade for student 9277, he/she is not able to see Reviews for Round-1. However, we were not able to reproduce the same issue, as the student with id-9277 does not exist in our database.

== Current Implementation ==

=== Overview ===
In the current review system implementation, the instructor has the ability to select or deselect the "Review rubric varies by round?" checkbox from the "Rubrics" tab of the Edit Assignment page. On selecting this checkbox, the reviewer is able to see all Rounds of Reviews.

=== UI Screenshots ===
The following images show how this functionality works currently:

[[File:Rubrics-page.png ]]

[[File:Heatgrid-metric.png]]

As you can see, the instructor is able to see both the Round of reviews.

Now, if we deselect it, then the heatgrid metric view page looks as follows:-

[[File:Heatgrid-wrong.png]]

== Implementation ==
So, as mentioned above, it works as intended, so if the instructor wants to see all the rounds of reviews, he/she have to mark the checkbox "Review rubric varies by round?" to true, then only it can be done. So, for that we have added a fix, we have set the value of the assignment to be true. For that, we created one migration that will set the value to true. Code looks as below:-

<pre>
class UpdateVaryByRoundToAssignments < ActiveRecord::Migration
def change
change_column :assignments, :vary_by_round, :boolean, :default => true
end
end
</pre>

= Important Links =
* GitHub repository link: https://github.com/ShlokSayani/expertiza
* Project Description Document: https://docs.google.com/document/d/1slx4HPIbgTH-psIKMSCF-HDF9brxf-FuYhzVT9ZiIrM/edit#heading=h.tqdrrd12xs4x
* GitHub Issue #1869: https://github.com/expertiza/expertiza/issues/1869
* Video Link for Issue #1869: https://www.youtube.com/watch?v=UAc_wI8ojkU
* GitHub Issue #2019: https://github.com/expertiza/expertiza/issues/2019

= Team =

* Shlok Sayani (sdsayani)

* Hardik Udeshi (hvudeshi)

* Isha Gupta (igupta)

* Manish Shinde (msshinde)

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-30T04:58:26Z

Sdsayani: /* Proposed Control Flow */

== Project Background ==
Heatgrid is the page where instructor can visit and view the work done by participant using Reviews, Author Feedbacks and Meta Reviews. This one web page displays all the evaluations done by peers of the participant for his project. The page is displayed in the format of table with colors. The columns in the table can be sorted with the requirement of the project. Heatgrid shows scores assigned by reviewers on individual rubric items for participant.

===What is wrong with it===
HeatGrid page is called from Instructor's "Assign Grades" function and student's view scores functions.

There are two issues assigned to us:-

* The first is that the column name "metric-1" in the heatgrid is not self-explanatory and needs to be changed. Also, we need to change it in such a way that in later stages if the instructor wants to add a new metric for the assignment, he/she should be add it with just a minor changes.
*The problem in the second issue is when an instructor tries to Assign Grades to a student 9277 for Madeup Problem 3, he/she is not able see the Round-1 Reviews. However, with the databases (old database) we were provided with do not have any student with Student id: 9277, and the assignment Madeup Problem 3 hasn't even existed. Also,

=Issue 1869=
== Problem Definition ==
Notes that there is a “metric-1” column in the review report, but it doesn’t say what the metric is. Please figure out what the metric is, and change the column header accordingly. However, the intent was that eventually an instructor would be allowed to select a metric to be shown on the heatgrid. So, somewhere in the UI for creating/editing an assignment, there should be a way for the instructor to select a metric from a dropdown list. You don’t have to add any more metrics to this list other than the one that is currently displayed, just create a mechanism for adding metrics in the future.

== Current Implementation ==

=== Overview ===
In the current implementation, the columns in the heatgrid table are static. The "metric-1" column in the table represents the count of comments for the respective question which have a word count greater than 10. On hovering over the column name, the correct information is displayed but the name itself does not make the information apparent at first glance.

=== UI Screenshots ===
The following image captures how the heatgrid is currently being displayed:

[[File:Summary Report.png|1200px|thumb|center]]

== Plan of work ==

=== Current Implemented Detail ===
* In the view_team.html.erb and instead of pre-assigned value to be metric-1, a dropdown will be populated and the instructor can choose the metric for the review. By default in the dropdown, there will be only one metric to count the verbose comments.

* Now, if the instructor wants to add any new metric, he/she just need to add the method for the metric in the app/views/assignment/edit/_general.html.erb file and that value will be stored in the database as a string in the heatgrid_metric variable and the same will be populated in the view of the heatgrid.

=== Proposed Control Flow ===
[[File:1869CF.drawio.png|1200px|thumb|center]]

== Detailed Implementation==
* In the database in the assignments table, one column named "heatgrid_metric" is added which will store the value of the dropdown menu.
* app/views/assignments/edit/_general.html.erb:- In this file we have added the dropdown which takes the metric from the instructor and sets the metric accordingly. The code we added is mentioned below:-
<pre>
<tr>
<td style='padding:5px' id='assignment_metrics_field'>
<%= label_tag('assignment_form[assignment][heatgrid_metric]', 'Select a Metric to be displayed in the Report Heatgrid:') %>
<%= select('assignment_form[assignment]', 'heatgrid_metric', [['--', ''], %w[Verbose-Comment-Count countofcomments]],
{ :selected => @assignment_form.assignment.heatgrid_metric}, { :class => 'form-control', :style => 'width: 100px'}) %>
</td>
</tr>
</pre>

We have added assigned two values to the dropdown:- '--' and 'Verbose-Comment-Count'. This is how it looks after adding this dropdown on the expertiza:-

[[File: Assignment General page.png]]

* app/views/grades/view_team.html.erb:- In this file, there is a view for the heatgrid, so when the instructor clicks on Assign Grades, the view from this file is rendered. So, the column name is changed here from "metric-1" to "countofcomments" variable, which will take the store the value of the dropdown selected.

The code that we have changed is:-

<pre>

<% case @assignment.heatgrid_metric %>
<% when 'countofcomments' %>
<th class="sorter-false">
 10. The purpose of this metric is to represent how many comments for the question are
of a substantial length to provide quality feedback.">Verbose Comment Count
</th>
<%end%>
</pre>

This is how it now looks on expertiza:

[[File:Heatgrid-metric.png]]

== Test Plan ==
* Capybara Test cases for the heat grid view are added to select the value from the dropdown menu. Both the 'Verbose-Comment-Count' and '--' are added.
<pre>
it "is able to create a public assignment with countofcomments metric" do
login_as("instructor6")
visit "/assignments/new?private=0"

fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
fill_in 'assignment_form_assignment_spec_location', with: 'testLocation'
check("assignment_form_assignment_microtask")
check("assignment_form_assignment_reviews_visible_to_all")
check("assignment_form_assignment_is_calibrated")
uncheck("assignment_form_assignment_availability_flag")
expect(page).to have_select("assignment_form[assignment][reputation_algorithm]", options: %w[-- Hamer Lauw])
select "Verbose-Comment-Count", from: 'countsofcomment'

click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
name: 'public assignment for test',
course_id: Course.find_by(name: 'Course 2').id,
directory_path: 'testDirectory',
spec_location: 'testLocation',
microtask: true,
is_calibrated: true,
availability_flag: false,
heatgrid_metric: 'countofcomments'
)
end

it "is able to create a public assignment with no metrics expected" do
login_as("instructor6")
visit "/assignments/new?private=0"

fill_in 'assignment_form_assignment_name', with: 'public assignment for test'
select('Course 2', from: 'assignment_form_assignment_course_id')
fill_in 'assignment_form_assignment_directory_path', with: 'testDirectory'
fill_in 'assignment_form_assignment_spec_location', with: 'testLocation'
check("assignment_form_assignment_microtask")
check("assignment_form_assignment_reviews_visible_to_all")
check("assignment_form_assignment_is_calibrated")
uncheck("assignment_form_assignment_availability_flag")
expect(page).to have_select("assignment_form[assignment][reputation_algorithm]", options: %w[-- Hamer Lauw])
select "--", from: 'countsofcomment'

click_button 'Create'
assignment = Assignment.where(name: 'public assignment for test').first
expect(assignment).to have_attributes(
name: 'public assignment for test',
course_id: Course.find_by(name: 'Course 2').id,
directory_path: 'testDirectory',
spec_location: 'testLocation',
microtask: true,
is_calibrated: true,
availability_flag: false,
heatgrid_metric: ''
)
end
</pre>
Spec test cases are added for the grades controller should be added to verify the responses returned from the controller.
<pre>
describe '#create with countofcomments' do
before(:each) do
allow(AssignmentForm).to receive(:new).with(any_args).and_return(assignment_form)
@params = {
button: '',
assignment_form: {
assignment_questionnaire: [{"assignment_id" => "1", "questionnaire_id" => "666", "dropdown" => "true",
"questionnaire_weight" => "100", "notification_limit" => "15", "used_in_round" => "1"}],
due_date: [{"id" => "", "parent_id" => "", "round" => "1", "deadline_type_id" => "1", "due_at" => "2017/12/05 00:00", "submission_allowed_id" => "3", "review_allowed_id" => "1", "teammate_review_allowed_id" => "3", "review_of_review_allowed_id" => "1", "threshold" => "1"},
{"id" => "", "parent_id" => "", "round" => "1", "deadline_type_id" => "2", "due_at" => "2017/12/02 00:00", "submission_allowed_id" => "1", "review_allowed_id" => "3", "teammate_review_allowed_id" => "3", "review_of_review_allowed_id" => "1", "threshold" => "1"}],
assignment: {
instructor_id: 2,
course_id: 1,
max_team_size: 1,
id: 1,
name: 'test assignment',
directory_path: '/test',
spec_location: '',
private: false,
show_teammate_reviews: false,
require_quiz: false,
num_quiz_questions: 0,
staggered_deadline: false,
microtask: false,
reviews_visible_to_all: false,
is_calibrated: false,
availability_flag: true,
reputation_algorithm: 'Lauw',
heatgrid_metric: 'countofcomments',
simicheck: -1,
simicheck_threshold: 100
}
}
}
end
context 'when assignment_form is saved successfully' do
it 'redirects to assignment#edit page' do
allow(assignment_form).to receive(:assignment).and_return(assignment)
allow(assignment_form).to receive(:save).and_return(true)
allow(assignment_form).to receive(:update).with(any_args).and_return(true)
allow(assignment_form).to receive(:create_assignment_node).and_return(double('node'))
allow(assignment).to receive(:id).and_return(1)
allow(Assignment).to receive(:find_by).with(id: 1).and_return(assignment)
allow_any_instance_of(AssignmentsController).to receive(:undo_link)
.with('Assignment "test assignment" has been created successfully. ').and_return(true)
post :create, @params
expect(response).to redirect_to('/assignments/1/edit')
end
end

context 'when assignment_form is not saved successfully' do
it 'renders assignment#new page' do
allow(assignment_form).to receive(:save).and_return(false)
post :create, @params
expect(response).to render_template(:new)
end
end
end
</pre>
* Unit test cases are added to verify the logic of the number_of_comments_greater_than_10_words method of the vm_question_response model.
<pre>
describe '#heatgrid_metric' do
it 'returns countofcomments by default' do
assignment = create(:assignment)
expect(assignment.heatgrid_metric).to eq('countofcomments')
end

it 'none value can be selected' do
assignment = build(:assignment, heatgrid_metric: '')
expect(assignment.heatgrid_metric).to eq('')
end
end
</pre>

=Issue 2019=
== Problem Definition ==
When an instructor is trying to Assign a Grade for student 9277, he/she is not able to see Reviews for Round-1. However, we were not able to reproduce the same issue, as the student with id-9277 does not exist in our database.

== Current Implementation ==

=== Overview ===
In the current review system implementation, the instructor has the ability to select or deselect the "Review rubric varies by round?" checkbox from the "Rubrics" tab of the Edit Assignment page. On selecting this checkbox, the reviewer is able to see all Rounds of Reviews.

=== UI Screenshots ===
The following images show how this functionality works currently:

[[File:Rubrics-page.png ]]

[[File:Heatgrid-metric.png]]

As you can see, the instructor is able to see both the Round of reviews.

Now, if we deselect it, then the heatgrid metric view page looks as follows:-

[[File:Heatgrid-wrong.png]]

== Implementation ==
So, as mentioned above, it works as intended, so if the instructor wants to see all the rounds of reviews, he/she have to mark the checkbox "Review rubric varies by round?" to true, then only it can be done. So, for that we have added a fix, we have set the value of the assignment to be true. For that, we created one migration that will set the value to true. Code looks as below:-

<pre>
class UpdateVaryByRoundToAssignments < ActiveRecord::Migration
def change
change_column :assignments, :vary_by_round, :boolean, :default => true
end
end
</pre>

= Important Links =
* GitHub repository link: https://github.com/ShlokSayani/expertiza
* Project Description Document: https://docs.google.com/document/d/1slx4HPIbgTH-psIKMSCF-HDF9brxf-FuYhzVT9ZiIrM/edit#heading=h.tqdrrd12xs4x
* GitHub Issue #1869: https://github.com/expertiza/expertiza/issues/1869
* Video Link for Issue #1869: https://www.youtube.com/watch?v=UAc_wI8ojkU
* GitHub Issue #2019: https://github.com/expertiza/expertiza/issues/2019

= Team =

* Shlok Sayani (sdsayani)

* Hardik Udeshi (hvudeshi)

* Isha Gupta (igupta)

* Manish Shinde (msshinde)

File:1869NewCF.png

2021-11-30T04:58:20Z

Sdsayani:

File:1869CF.drawio.png

2021-11-30T04:57:48Z

Sdsayani:

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-08T21:25:11Z

Sdsayani:

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-08T21:22:20Z

Sdsayani:

File:Issue2CF.png

2021-11-08T21:19:47Z

Sdsayani:

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-04T03:34:38Z

Sdsayani:

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-04T03:31:39Z

Sdsayani:

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-04T01:54:11Z

Sdsayani:

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-04T01:52:18Z

Sdsayani:

File:Issue1CF.png

2021-11-04T01:50:59Z

Sdsayani:

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-04T01:30:19Z

Sdsayani:

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-04T01:24:33Z

Sdsayani:

File:Summary Report.png

2021-11-04T00:36:10Z

Sdsayani: Sdsayani uploaded a new version of File:Summary Report.png

File:AssignReviewer.png

2021-11-04T00:35:47Z

Sdsayani:

File:SelfReviewCheckbox.png

2021-11-04T00:35:27Z

Sdsayani:

CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements

2021-11-03T21:11:22Z

Sdsayani: Created page with "== Project Background == Peer-review systems like Expertiza utilize a lot of students’ input to determine each other’s performance. At the same time, students learn from t..."

== Project Background ==
Peer-review systems like Expertiza utilize a lot of students’ input to determine each other’s performance. At the same time, students learn from the reviews they receive to improve their own performance. In order to make this happen, it would be good to have everyone give quality reviews instead of generic ones. Currently, Expertiza has a few classifiers that can detect useful features of review comments, such as whether they contain suggestions. The suggestion-detection algorithm has been coded as a web service, and other detection algorithms, such as problem detection and sentiment analysis, also exist as newer web services. We need to make the UI more intuitive by allowing users to view the feedback of specific review comments and the code needs to be refactored to remove redundancy to follow the DRY principle.

=Issue 1=
== Problem Definition ==

== Current Implementation ==

=== Overview ===

=== UI Screenshots ===

=== Control Flow ===

== Observations ==

== Test Plan ==

== Files to be Edited ==

=Issue 2=
== Problem Definition ==

== Current Implementation ==

=== Overview ===

=== UI Screenshots ===

=== Control Flow ===

== Refactoring ==

== Files to be Edited ==

== Test Plan ==

= Important Links =

= Team =

* Shlok Sayani (sdsayani)

* Hardik Udeshi (hvudeshi)

* Isha Gupta (igupta)

* Manish Shinde (msshinde)

CSC/ECE 517 Fall 2021

2021-11-03T20:58:29Z

Sdsayani:

== OSS Projects ==

* [[CSC/ECE 517 Fall 2021 - E2117. Refactor questionaires_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2128. Refactor student_quizzes_controller.rb & late_policies_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2129. Refactor auth_controller.rb & password_retrieval_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2132. Add tests cases for review mapping helper.rb]]
* [[CSC/ECE 517 Fall 2021 - E2134. Write unit tests for admin_controller.rb and institution_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2138. Auto-generate submission directory names based on assignment]]
* [[CSC/ECE 517 Fall 2021 - E2142. Improve e-mail notifications]]
* [[CSC/ECE 517 Fall 2021 - E2133. Write tests for popup_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2120. Refactor reputation_web_service_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2139. Remove multiple topics at a time]]
* [[CSC/ECE 517 Fall 2021 - E2131. Improve assessment360_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2121. Refactor suggestion_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2122. Refactor impersonate_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2123. Refactor sign_up_sheet_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2126. Refactor account_request_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2124. Refactor review_mapping_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2125. Refactor review_mapping_helper.rb]]
* [[CSC/ECE 517 Fall 2021 - E2127. Refactor teams_controller]]
* [[CSC/ECE 517 Fall 2021 - E2130. Refactor submitted_content_controller.rb]]
* [[CSC/ECE 517 Fall 2021 - E2140. Create new late policy successfully and fix Bank link]]
* [[CSC/ECE 517 Fall 2021 - E2141. OSS project Finklestein: Instructors & Institutions]]
* [[CSC/ECE 517 Fall 2021 - E2144. Refactor delayed mailer and scheduled task]]
* [[CSC/ECE 517 Fall 2021 - E2147. Role-based reviewing]]
* [[CSC/ECE 517 Fall 2021 - E2145. OSS Project Beige]]
* [[CSC/ECE 517 Fall 2021 - E2146. Introduce a Student View for instructors]]
* [[CSC/ECE 517 Fall 2021 - Refactor Evaluation of SQL Queries]]
* [[CSC/ECE 517 Fall 2021 - E2135. Email notification to reviewers and instructors]]
* [[CSC/ECE 517 Fall 2021 - E2168. Testing - Reputations]]
* [[CSC/ECE 517 Fall 2021 - E2149. Finish Github metrics integration - Reputations]]

== Final Projects ==
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2166._Testing_-_Scoring_%26_Grades#Description_about_project CSC/ECE 517 Fall 2021 - E2166. Testing - Scoring_and_Grades]
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2150._Integrate_suggestion_detection_algorithm#Description_about_project CSC/ECE 517 Fall 2021 - E2150. Integrate suggestion detection algorithm]
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2151._Allow_reviewers_to_bid_on_what_to_review CSC/ECE 517 Fall 2021 - E2151. Allow reviewers to bid on what to review]
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2152._Revision_planning_tool#Description_about_project CSC/ECE 517 Fall 2021 - E2152. Revision_planning_tool]
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2170._Testing_-_Response_Maps#Description_about_project CSC/ECE 517 Fall 2021 - E2170. Testing - Response Maps]
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2153._Improving_search_facility_in_Expertiza#Description_about_project CSC/ECE 517 Fall 2021 - E2153. Improving search facility in Expertiza]
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2162._Further_refactoring_and_improvement_of_review_mapping_helper CSC/ECE 517 Fall 2021 - E2162. Further refactoring and improvement of review mapping helper]
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2165._Fix_teammate-review_view CSC/ECE 517 Fall 2021 - E2165. Fix teammate review view ]
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2155._Calibration_submissions_should_be_copied_along_with_calibration_assignments CSC/ECE 517 Fall 2021 - E2155. Calibration submissions should be copied along with calibration assignments]
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2148._Completion/Progress_View CSC/ECE 517 Fall 2021 - E2148. Completion/Progress view]
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2158._Grading_audit_trail CSC/ECE 517 Fall 2021 - E2158. Grading audit trail ]
*[https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2159._Expertiza_internationalization CSC/ECE 517 Fall 2021 - E2159. Expertiza internationalization]
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2160._Implementing_and_testing_import_export_controllers#Description_about_project CSC/ECE 517 Fall 2021 - E2160. Implementing and testing import and export controllers]
* [https://expertiza.csc.ncsu.edu/index.php/CSC/ECE_517_Fall_2021_-_E2164._Heatgrid_fixes_and_improvements#Description_about_project CSC/ECE 517 Fall 2021 - E2164. Heatgrid fixes and improvements]

CSC/ECE 517 Fall 2021 - E2139. Remove multiple topics at a time

2021-10-19T23:50:05Z

Sdsayani:

==About Expertiza==
Expertiza is a Ruby on Rails based open source project that allows users to submit a variety of document types, including URLs and wiki pages.
It allows the instructor to create and customize new or existing assignments as well as a list of topics for which students can sign up.
Expertiza allows students to form groups to work on various projects and assignments. It also allows students to peer review the work of other students.

==Project Description==
Expertiza has Assignment objects, which represent an assignment that is done by a number of users. For some assignments, students need to select a topic before submitting work. For deleting a topic, there is a checkbox beside each topic that can be selected and then the instructor or TA can delete the selected topics from the assignment. The feature needs to be tested thoroughly for various scenarios where different kinds of flags for the assignment are checked like staggered deadline, private assignment, micro task assignment. Also, we need to test the feature when all topics are deleted, some topics are deleted and only one topic is deleted.

===Team Members===
<li> Divyang Doshi </li>
<li> Hardik Udeshi </li>
<li> Shlok Sayani </li>

===Files Involved===
spec/controllers/sign_up_sheet_controller_spec.rb

===Running test cases===
<pre>
run the command :- rspec spec/controllers/sign_up_sheet_controller_spec.rb
</pre>

==Testing scenarios==
<ol>

<li> When the assignment is a microtask and all other flags are False. </li>
<ol>
<li>Testing deleting all topics for microtask assignment. We test the delete all functionality by creating few topics associated with a microtask assignment and then do a post request on delete_all_selected_topics. We then expect the number of topics related to this assignment should be 0. We also assert that redirect to edit assignment page is successful after deletion of topics.</li>
<pre>
it 'delete_all_selected_topics for a microtask assignment and redirects to edit assignment page with single topic selected' do
create(:topic, id: 6000, assignment_id: 6000, topic_identifier: 'topic6000')
params = {assignment_id: 6000, topic_ids: ['topic6000']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 6000).count
expect(topics_exist).to be_eql 0
expect(response).to redirect_to('/assignments/6000/edit#tabs-2')
end
</pre>

<li>Testing deleting multiple topics for microtask assignment. We test the delete multiple functionality by creating few topics associated with a microtask assignment and then do a post request on delete_all_selected_topics. We then expect the number of topics related to this assignment should be number of topics created - number of topics deleted. We also assert that redirect to edit assignment page is successful after deletion of topics.</li>
<pre>
it 'delete_all_selected_topics for not microtask assignment and redirects to edit assignment page with multiple topic selected' do
create(:topic, id: 6000, assignment_id: 7000, topic_identifier: 'topic6000')
create(:topic, id: 7000, assignment_id: 7000, topic_identifier: 'topic7000')
create(:topic, id: 8000, assignment_id: 7000, topic_identifier: 'topic8000')
params = {assignment_id: 7000, topic_ids: ['topic6000', 'topic7000']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 7000).count
expect(topics_exist).to be_eql 1
expect(response).to redirect_to('/assignments/7000/edit#tabs-2')

params = {assignment_id: 7000, topic_ids: ['topic8000']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 7000).count
expect(topics_exist).to be_eql 0
expect(response).to redirect_to('/assignments/7000/edit#tabs-2')
end
</pre>
</ol>

<li> When the assignment is a staggered deadline and microtask and private flags are False. </li>
<ol>
<li> Deleting single topic of staggered deadline assignments. We first create a topic that is to be deleted afterward. Then, assign this topic to a staggered deadline assignment. Then, we pass this topic to delete_all_selected_topics. As of now, this topic needs to be deleted by the method, we fire a query to check the topic with the same topic_id exists in the database or not. If it is successfully deleted, the count should be returned 0 by the query. We also assert that redirect to edit assignment page is successful after deletion of topics.
</li>
<pre>
it 'create topic and delete_all_selected_topics for a staggered deadline assignment and redirects to edit assignment page with single topic selected' do
create(:topic, id: 40, assignment_id: 40, topic_identifier: 'E1733')
params = {assignment_id: 40, topic_ids: ['E1733']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 40).count
expect(topics_exist).to be_eql 0
expect(response).to redirect_to('/assignments/40/edit#tabs-2')
end
</pre>

<li> Deleting multiple topics of staggered deadline assignments. We first create some topics that are to be deleted afterward. Then, assign these topics to a staggered deadline assignment. Then, we pass these topics multiple at a time to the delete_all_selected_topics method. As of now, these topics need to be deleted by the method, we fire a query to check the topics with the same topic_ids exist in the database or not. If it is successfully deleted, the count should be returned with the topic remaining by the query. We also assert that redirect to edit assignment page is successful after deletion of topics.
</li>
<pre>
it 'create topic and delete_all_selected_topics for a staggered deadline assignment and redirects to edit assignment page with multiple topic selected' do
create(:topic, id: 30, assignment_id: 40, topic_identifier: 'E1735')
create(:topic, id: 40, assignment_id: 40, topic_identifier: 'E1736')
create(:topic, id: 50, assignment_id: 40, topic_identifier: 'E1737')
create(:topic, id: 60, assignment_id: 40, topic_identifier: 'E1738')
create(:topic, id: 70, assignment_id: 40, topic_identifier: 'E1739')
params = {assignment_id: 40, topic_ids: ['E1735', 'E1736']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 40).count
expect(topics_exist).to be_eql 3
expect(response).to redirect_to('/assignments/40/edit#tabs-2')

params = {assignment_id: 40, topic_ids: ['E1737', 'E1738']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 40).count
expect(topics_exist).to be_eql 1
expect(response).to redirect_to('/assignments/40/edit#tabs-2')

params = {assignment_id: 40, topic_ids: ['E1739']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 40).count
expect(topics_exist).to be_eql 0
expect(response).to redirect_to('/assignments/40/edit#tabs-2')
end
</pre>
<li> Deleting all topics of staggered deadline assignments. We first create some topics that are to be deleted afterward. Then, assign these topics to a staggered deadline assignment. Then, we pass these topics all at a time to the delete_all_topics_for_assignment method. As of now, these topics need to be deleted by the method, we fire a query to check the topics with the same topic_ids exist in the database or not. If it is successfully deleted, the count should be returned with 0 by the query. We also assert that redirect to edit assignment page is successful after deletion of topics.
</li>
<pre>
it 'deletes all topics for the staggered deadline assignment and redirects to edit assignment page' do
create(:topic, id: 30, assignment_id: 40, topic_identifier: 'E1740')
create(:topic, id: 40, assignment_id: 40, topic_identifier: 'E1741')
create(:topic, id: 50, assignment_id: 40, topic_identifier: 'E1742')
params = {assignment_id: 40}
post :delete_all_topics_for_assignment, params
topics_exist = SignUpTopic.where(assignment_id: 40).count
expect(topics_exist).to be_eql 0
expect(flash[:success]).to eq('All topics have been deleted successfully.')
expect(response).to redirect_to('/assignments/40/edit')
end
</pre>
</ol>
<li> When the assignment is a non-staggered deadline and microtask and private flags are True. </li>
<ol>
<li> Deleting single topic of non-staggered deadline assignments. We first create a topic that is to be deleted afterward. Then, assign this topic to a non-staggered deadline assignment. Then, we pass this topic to delete_all_selected_topics. As of now, this topic needs to be deleted by the method, we fire a query to check the topic with the same topic_id exists in the database or not. If it is successfully deleted, the count should be returned 0 by the query. We also assert that redirect to edit assignment page is successful after deletion of topics.
</li>
<pre>
it 'create topic and delete_all_selected_topics for not a staggered deadline assignment and redirects to edit assignment page with single topic selected' do
create(:topic, id: 30, assignment_id: 30, topic_identifier: 'E1734')
params = {assignment_id: 30, topic_ids: ['E1734']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 30).count
expect(topics_exist).to be_eql 0
expect(response).to redirect_to('/assignments/30/edit#tabs-2')
end
</pre>

<li> Deleting multiple topics of non-staggered deadline assignments. We first create some topics that are to be deleted afterward. Then, assign these topics to a non-staggered deadline assignment. Then, we pass these topics multiple at a time to the delete_all_selected_topics method. As of now, these topics need to be deleted by the method, we fire a query to check the topics with the same topic_ids exist in the database or not. If it is successfully deleted, the count should be returned with the topic remaining by the query. We also assert that redirect to edit assignment page is successful after deletion of topics.
</li>
<pre>
it 'create topic and delete_all_selected_topics for not a staggered deadline assignment and redirects to edit assignment page with multiple topic selected' do
create(:topic, id: 30, assignment_id: 30, topic_identifier: 'E1735')
create(:topic, id: 40, assignment_id: 30, topic_identifier: 'E1736')
create(:topic, id: 50, assignment_id: 30, topic_identifier: 'E1737')
create(:topic, id: 60, assignment_id: 30, topic_identifier: 'E1738')
create(:topic, id: 70, assignment_id: 30, topic_identifier: 'E1739')
params = {assignment_id: 30, topic_ids: ['E1735', 'E1736']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 30).count
expect(topics_exist).to be_eql 3
expect(response).to redirect_to('/assignments/30/edit#tabs-2')

params = {assignment_id: 30, topic_ids: ['E1737', 'E1738']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 30).count
expect(topics_exist).to be_eql 1
expect(response).to redirect_to('/assignments/30/edit#tabs-2')

params = {assignment_id: 30, topic_ids: ['E1739']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 30).count
expect(topics_exist).to be_eql 0
expect(response).to redirect_to('/assignments/30/edit#tabs-2')
end
</pre>

<li> Deleting all topics of non-staggered deadline assignments. We first create some topics that are to be deleted afterward. Then, assign these topics to a non-staggered deadline assignment. Then, we pass these topics all at a time to the delete_all_topics_for_assignment method. As of now, these topics need to be deleted by the method, we fire a query to check the topics with the same topic_ids exist in the database or not. If it is successfully deleted, the count should be returned with 0 by the query. We also assert that redirect to edit assignment page is successful after deletion of topics.
</li>
<pre>
it 'deletes all topics for the non-staggered deadline assignment and redirects to edit assignment page' do
create(:topic, id: 30, assignment_id: 30, topic_identifier: 'E1740')
create(:topic, id: 40, assignment_id: 30, topic_identifier: 'E1741')
create(:topic, id: 50, assignment_id: 30, topic_identifier: 'E1742')
params = {assignment_id: 30}
post :delete_all_topics_for_assignment, params
topics_exist = SignUpTopic.where(assignment_id: 30).count
expect(topics_exist).to be_eql 0
expect(flash[:success]).to eq('All topics have been deleted successfully.')
expect(response).to redirect_to('/assignments/30/edit')
end
</pre>

</ol>

<li> When the assignment is private and other flags are False. </li>
<ol>
<li> Test deleting a single topic in private assignments. We first create a topic that is to be deleted afterwards. Then, assign this topic to a private assignment. Then, we pass this topic to delete_all_selected_topics. As of now, this topic needs to be deleted by the method, we fire a query to check the topic with the same topic_id exists in the database or not. If it is successfully deleted, the count should be returned 0 by the query. We also assert that redirect to edit assignment page is successful after deletion of topics.
</li>
<pre>
it 'delete_all_selected_topics for a private assignment and redirects to edit assignment page with single topic selected' do
create(:topic, id: 2, assignment_id: 2, topic_identifier: 'topic2')
params = {assignment_id: 2, topic_ids: ['topic2']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 2).count
expect(topics_exist).to be_eql 0
expect(response).to redirect_to('/assignments/2/edit#tabs-2')
end
</pre>

<li> Deleting multiple topics of private assignments. We first create some topics that are to be deleted afterward. Then, assign these topics to a private assignment. Then, we pass these topics multiple at a time to the delete_all_selected_topics method. As of now, these topics need to be deleted by the method, we fire a query to check the topics with the same topic_ids exist in the database or not. If it is successfully deleted, the count should be returned with the topic remaining by the query. We also assert that redirect to edit assignment page is successful after deletion of topics.
</li>
<pre>
it 'delete_all_selected_topics for a private assignment and redirects to edit assignment page with multiple topic selected' do
create(:topic, id: 2, assignment_id: 2, topic_identifier: 'topic2')
create(:topic, id: 3, assignment_id: 2, topic_identifier: 'topic3')
create(:topic, id: 4, assignment_id: 2, topic_identifier: 'topic4')
params = {assignment_id: 2, topic_ids: ['topic2', 'topic3']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 2).count
expect(topics_exist).to be_eql 1
expect(response).to redirect_to('/assignments/2/edit#tabs-2')

params = {assignment_id: 2, topic_ids: ['topic4']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 2).count
expect(topics_exist).to be_eql 0
expect(response).to redirect_to('/assignments/2/edit#tabs-2')
end
</pre>
<li> Deleting all topics of private assignments. We first create some topics that are to be deleted afterward. Then, assign these topics to a private assignment. Then, we pass these topics all at a time to the delete_all_topics_for_assignment method. As of now, these topics need to be deleted by the method, we fire a query to check the topics with the same topic_ids exist in the database or not. If it is successfully deleted, the count should be returned with 0 by the query. We also assert that redirect to edit assignment page is successful after deletion of topics.
</li>
<pre>
it 'deletes all topics for the private assignment and redirects to edit assignment page' do
create(:topic, id: 2, assignment_id: 2)
create(:topic, id: 3, assignment_id: 2)
params = {assignment_id: 2}
post :delete_all_topics_for_assignment, params.merge(format: :html)
topics_exist = SignUpTopic.where(assignment_id: 2).count
expect(topics_exist).to be_eql 0
expect(flash[:success]).to eq('All topics have been deleted successfully.')
expect(response).to redirect_to('/assignments/2/edit')
end
</pre>
</ol>
<li> When the assignment is non-private and other flags are True. </li>
<ol>
<li> Deleting single topic of non-private assignments. We first create a topic that is to be deleted afterward. Then, assign this topic to a non-private assignment. Then, we pass this topic to delete_all_selected_topics. As of now, this topic needs to be deleted by the method, we fire a query to check the topic with the same topic_id exists in the database or not. If it is successfully deleted, the count should be returned 0 by the query. We also assert that redirect to edit assignment page is successful after deletion of topics.
</li>
<pre>
it 'delete_all_selected_topics for a non private assignment and redirects to edit assignment page with single topic selected' do
create(:topic, id: 2, assignment_id: 3, topic_identifier: 'topic2')
params = {assignment_id: 3, topic_ids: ['topic2']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 3).count
expect(topics_exist).to be_eql 0
expect(response).to redirect_to('/assignments/3/edit#tabs-2')
end
</pre>

<li> Deleting multiple topics of non-private assignments. We first create some topics that are to be deleted afterward. Then, assign these topics to a non-private assignment. Then, we pass these topics multiple at a time to the delete_all_selected_topics method. As of now, these topics need to be deleted by the method, we fire a query to check the topics with the same topic_ids exist in the database or not. If it is successfully deleted, the count should be returned with the topic remaining by the query. We also assert that redirect to edit assignment page is successful after deletion of topics.
</li>
<pre>
it 'delete_all_selected_topics for a non private assignment and redirects to edit assignment page with multiple topic selected' do
create(:topic, id: 2, assignment_id: 3, topic_identifier: 'topic2')
create(:topic, id: 3, assignment_id: 3, topic_identifier: 'topic3')
create(:topic, id: 8, assignment_id: 3, topic_identifier: 'topic4')
params = {assignment_id: 3, topic_ids: ['topic2', 'topic3']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 3).count
expect(topics_exist).to be_eql 1
expect(response).to redirect_to('/assignments/3/edit#tabs-2')

params = {assignment_id: 3, topic_ids: ['topic4']}
post :delete_all_selected_topics, params
expect(flash[:success]).to eq('All selected topics have been deleted successfully.')
topics_exist = SignUpTopic.where(assignment_id: 3).count
expect(topics_exist).to be_eql 0
expect(response).to redirect_to('/assignments/3/edit#tabs-2')
end
</pre>

<li> Deleting all topics of non-private assignments. We first create some topics that are to be deleted afterward. Then, assign these topics to a non-private assignment. Then, we pass these topics all at a time to the delete_all_topics_for_assignment method. As of now, these topics need to be deleted by the method, we fire a query to check the topics with the same topic_ids exist in the database or not. If it is successfully deleted, the count should be returned with 0 by the query. We also assert that redirect to edit assignment page is successful after deletion of topics.
</li>
<pre>
it 'deletes all topics for non private assignment and redirects to edit assignment page' do
create(:topic, id: 2, assignment_id: 3)
create(:topic, id: 3, assignment_id: 3)
params = {assignment_id: 3}
post :delete_all_topics_for_assignment, params.merge(format: :html)
topics_exist = SignUpTopic.where(assignment_id: 3).count
expect(topics_exist).to be_eql 0
expect(flash[:success]).to eq('All topics have been deleted successfully.')
expect(response).to redirect_to('/assignments/3/edit')
end
</pre>

</ol>

</ol>

==Test Results==

==Repository Link==

https://github.com/hvudeshi/expertiza/tree/beta