Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics

2019-12-18T03:33:11Z

Rwu5: /* Links to the project */

== '''Problem Statement''' ==
For assignments with topics, like the OSS project, mentors are associated with topics, and then whichever team is assigned to the topic inherits the mentor for that topic However, for assignments without topics (like Program 2), there is no good way to “automatically” assign mentors to projects. The instructor needs to watch teams being formed, and every time a new team is formed, a new mentor needs to be assigned, outside of Expertiza. This leads to a lot of work for the instructor, as well as sometimes long delays before a team is assigned a mentor.

== '''Links to the project''' ==
Github Pull Request: https://github.com/expertiza/expertiza/pull/1651
 
Video Presentations:
https://youtu.be/fyAiyzUsHH4
https://youtu.be/KBdiqPe-wLE
https://youtu.be/avjdLbw28K8
 
Deployment: http://152.46.18.18:8080

== '''The goal behind this project:''' ==

Develop a trigger that: 
1) Is activated when any team has been formed that has k members, where k is greater than 50% of the maximum team capacity 
*ex) max members = 4, trigger activated when the team size reaches 3
2) Assign a mentor to the team 
*Mentors should be evenly assigned to teams, so a good strategy is to assign the mentor who has the fewest teams to mentor so far.
3) Notify the mentor via email that they are now assigned to a specific team, and provide the email addresses of the team members. 
4) Possibly notify the team members that they have been assigned the mentor with contact information (further discussion here) 

== '''Design Pattern''' ==
Since the trigger we implemented would need multiple handlers and each of them responses in different actions, we decide to use Chain of Responsibility as the design pattern. Chain of Responsibility is a behavioral design pattern that lets you pass requests along a chain of handlers. Upon receiving a request, each handler decides either to process the request or to pass it to the next handler in the chain. 
[[File:Chain of Responsibility.png]]
 Implementation for our project 
[[File:CoR.png]]
== '''Project Description''' ==

=== Old version: ===
For assignments without a topic, there is no way to assign a mentor to the team on Expertiza system but to manually assigned one via Email out of the system.
[[File:Assign Mentor.png]]
 In the above case, there is no mentor role for the current Expertiza system, only to assign mentor manually
=== New version: ===
Assignments with or without a topic could be assigned with mentors automatically 
[[File:AddMentor.png]]
 Also, mentor and team members will be notified by Emails (Results showing in UI Test).

== '''Design Diagrams''' ==

=== Workflow Diagram ===
General workflow and specific add member workflow 
[[File:usecases.png]][[File:specific_workflow.png]]

== '''Proposed Solution''' ==

'''The solution we proposed generally follow the chain of responsibility and the work flow''' 
'''The solution will follow steps list here:'''
*Allow instructor to assign mentors for assignments without a topic
*Check the topic of assignment and number of team members whether reach the requirement or not
*Assign mentor for the team automatically
*Notificate both mentor and student
*Team member added after the mentor assignment will also get a email notification about mentor

== '''Code Implementation & Explanation''' ==
Since we implemented a whole new feature and kept the original work flow unchanged at the meantime, most modifications are in models: 
Models:
*app/models/assignment_team.rb
*app/models/assignment_participants.rb
*app/models/team.rb
*app/models/team_users.rb
*...
 
Views:
*app/views/student_task/view
*app/views/student_teams/view
*app/views/shared_scripts/_add_individual
*app/views/participants/_participant
*... 
Here we present some essential codes with explanation 
[[File:Mentor_role.png]]
 First, add mentor role for assignment. Set authorization for mentor which could not do review, take quiz or submit. 

[[File:Add_mentor_view.png]]

 Add a mentor role for instructor/admin when add participant for assignment 

[[File:Mentor_requirement.png]]
 To assign a mentor, there are several requirements:
*There should be at least one mentor in this assignment
*The current team size is greater than half of max size
*The team do not have a mentor yet
 

[[File:Assign_algorithm.png]]
 Always assign mentor with lowest number of mentoring teams, in order to do so:
*First, get all mentors for this assignment
*Traverse all mentors and calculate how many teams he/she mentored, store the one with lowest number
*Return mentor with lowest number of team she/he mentored 

[[File:Assign_algorithm.png]]
 Use Mailer class to send email notification about mentor and team members information(method used to send email notification for student is similar to this). 
== '''Test Plan''' ==
To make sure the refactor code can work correctly, we need to run the original rspec test code and add some new test. Besides, we are plaining to test from UI to make sure all the features work. The test results are shown below.

*Run and pass existing RSpec Tests after Modification
*Develop New RSpec Tests for the new features
*UI testing on the deployed project
==RSpec Test==
1. Add new participant type mentor in factories.rb 
[[File:Mentor_factory.png]] 

2.Test new added method in team_respec, like half, add_member, size... 
[[File:Add_member.png]] 
[[File:Half.png]] 

==UI Test==
1. Instructor/Admin add mentor for specific assignment 
[[File:AddMentor.png]] 
2. Student create team and invite others 
3. When team size greater than half of max size, assign mentor and send emails 
[[File:Members_email.png]]
[[File:Mentor_email.png]] 
4. When student accept from a team which has already been assigned with mentor, he/she would receive a email 
[[File:New_member_email.png]] 

5. Also we extend our work to make all teams visible to mentors 
[[File:Extend_work.png]] 

== '''Future Work''' ==
1. Mentor could not see teams' submissions since authorization control is working on the view assignment page and mentor does not have rights to submit 
2. Rspec Test for email functions

== '''Team Member''' ==
Our team members: (Sorted in Alphabetical order) 
*Hongli Wang, hwang85@ncsu.edu
*Minghao Liu, mliu25@ncsu.edu
*Ruiwen Wu, rwu5@ncsu.edu
*Siwei Wen, swen4@ncsu.edu

Mentor: Mrs. Carmen Aiken Bentley

CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics

2019-12-18T03:13:04Z

Rwu5: /* Links to the project */

== '''Problem Statement''' ==
For assignments with topics, like the OSS project, mentors are associated with topics, and then whichever team is assigned to the topic inherits the mentor for that topic However, for assignments without topics (like Program 2), there is no good way to “automatically” assign mentors to projects. The instructor needs to watch teams being formed, and every time a new team is formed, a new mentor needs to be assigned, outside of Expertiza. This leads to a lot of work for the instructor, as well as sometimes long delays before a team is assigned a mentor.

== '''Links to the project''' ==
Github Pull Request: https://github.com/expertiza/expertiza/pull/1651
 
Video Presentations:
https://youtu.be/kWQcB21n538
https://youtu.be/qE1dqVp-zDA
 
Deployment: http://152.46.18.18:8080

== '''The goal behind this project:''' ==

Develop a trigger that: 
1) Is activated when any team has been formed that has k members, where k is greater than 50% of the maximum team capacity 
*ex) max members = 4, trigger activated when the team size reaches 3
2) Assign a mentor to the team 
*Mentors should be evenly assigned to teams, so a good strategy is to assign the mentor who has the fewest teams to mentor so far.
3) Notify the mentor via email that they are now assigned to a specific team, and provide the email addresses of the team members. 
4) Possibly notify the team members that they have been assigned the mentor with contact information (further discussion here) 

== '''Design Pattern''' ==
Since the trigger we implemented would need multiple handlers and each of them responses in different actions, we decide to use Chain of Responsibility as the design pattern. Chain of Responsibility is a behavioral design pattern that lets you pass requests along a chain of handlers. Upon receiving a request, each handler decides either to process the request or to pass it to the next handler in the chain. 
[[File:Chain of Responsibility.png]]
 Implementation for our project 
[[File:CoR.png]]
== '''Project Description''' ==

=== Old version: ===
For assignments without a topic, there is no way to assign a mentor to the team on Expertiza system but to manually assigned one via Email out of the system.
[[File:Assign Mentor.png]]
 In the above case, there is no mentor role for the current Expertiza system, only to assign mentor manually
=== New version: ===
Assignments with or without a topic could be assigned with mentors automatically 
[[File:AddMentor.png]]
 Also, mentor and team members will be notified by Emails (Results showing in UI Test).

== '''Design Diagrams''' ==

=== Workflow Diagram ===
General workflow and specific add member workflow 
[[File:usecases.png]][[File:specific_workflow.png]]

== '''Proposed Solution''' ==

'''The solution we proposed generally follow the chain of responsibility and the work flow''' 
'''The solution will follow steps list here:'''
*Allow instructor to assign mentors for assignments without a topic
*Check the topic of assignment and number of team members whether reach the requirement or not
*Assign mentor for the team automatically
*Notificate both mentor and student
*Team member added after the mentor assignment will also get a email notification about mentor

== '''Code Implementation & Explanation''' ==
Since we implemented a whole new feature and kept the original work flow unchanged at the meantime, most modifications are in models: 
Models:
*app/models/assignment_team.rb
*app/models/assignment_participants.rb
*app/models/team.rb
*app/models/team_users.rb
*...
 
Views:
*app/views/student_task/view
*app/views/student_teams/view
*app/views/shared_scripts/_add_individual
*app/views/participants/_participant
*... 
Here we present some essential codes with explanation 
[[File:Mentor_role.png]]
 First, add mentor role for assignment. Set authorization for mentor which could not do review, take quiz or submit. 

[[File:Add_mentor_view.png]]

 Add a mentor role for instructor/admin when add participant for assignment 

[[File:Mentor_requirement.png]]
 To assign a mentor, there are several requirements:
*There should be at least one mentor in this assignment
*The current team size is greater than half of max size
*The team do not have a mentor yet
 

[[File:Assign_algorithm.png]]
 Always assign mentor with lowest number of mentoring teams, in order to do so:
*First, get all mentors for this assignment
*Traverse all mentors and calculate how many teams he/she mentored, store the one with lowest number
*Return mentor with lowest number of team she/he mentored 

[[File:Assign_algorithm.png]]
 Use Mailer class to send email notification about mentor and team members information(method used to send email notification for student is similar to this). 
== '''Test Plan''' ==
To make sure the refactor code can work correctly, we need to run the original rspec test code and add some new test. Besides, we are plaining to test from UI to make sure all the features work. The test results are shown below.

*Run and pass existing RSpec Tests after Modification
*Develop New RSpec Tests for the new features
*UI testing on the deployed project
==RSpec Test==
1. Add new participant type mentor in factories.rb 
[[File:Mentor_factory.png]] 

2.Test new added method in team_respec, like half, add_member, size... 
[[File:Add_member.png]] 
[[File:Half.png]] 

==UI Test==
1. Instructor/Admin add mentor for specific assignment 
[[File:AddMentor.png]] 
2. Student create team and invite others 
3. When team size greater than half of max size, assign mentor and send emails 
[[File:Members_email.png]]
[[File:Mentor_email.png]] 
4. When student accept from a team which has already been assigned with mentor, he/she would receive a email 
[[File:New_member_email.png]] 

5. Also we extend our work to make all teams visible to mentors 
[[File:Extend_work.png]] 

== '''Future Work''' ==
1. Mentor could not see teams' submissions since authorization control is working on the view assignment page and mentor does not have rights to submit 
2. Rspec Test for email functions

== '''Team Member''' ==
Our team members: (Sorted in Alphabetical order) 
*Hongli Wang, hwang85@ncsu.edu
*Minghao Liu, mliu25@ncsu.edu
*Ruiwen Wu, rwu5@ncsu.edu
*Siwei Wen, swen4@ncsu.edu

Mentor: Mrs. Carmen Aiken Bentley

CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics

2019-12-06T23:49:40Z

Rwu5: /* Links to the project */

== '''Problem Statement''' ==
For assignments with topics, like the OSS project, mentors are associated with topics, and then whichever team is assigned to the topic inherits the mentor for that topic However, for assignments without topics (like Program 2), there is no good way to “automatically” assign mentors to projects. The instructor needs to watch teams being formed, and every time a new team is formed, a new mentor needs to be assigned, outside of Expertiza. This leads to a lot of work for the instructor, as well as sometimes long delays before a team is assigned a mentor.

== '''Links to the project''' ==
Github Pull Request: https://github.com/expertiza/expertiza/pull/1651
 
Video Presentations:
https://youtu.be/kWQcB21n538
https://youtu.be/qE1dqVp-zDA

== '''The goal behind this project:''' ==

Develop a trigger that: 
1) Is activated when any team has been formed that has k members, where k is greater than 50% of the maximum team capacity 
*ex) max members = 4, trigger activated when the team size reaches 3
2) Assign a mentor to the team 
*Mentors should be evenly assigned to teams, so a good strategy is to assign the mentor who has the fewest teams to mentor so far.
3) Notify the mentor via email that they are now assigned to a specific team, and provide the email addresses of the team members. 
4) Possibly notify the team members that they have been assigned the mentor with contact information (further discussion here) 

== '''Design Pattern''' ==
Since the trigger we implemented would need multiple handlers and each of them responses in different actions, we decide to use Chain of Responsibility as the design pattern. Chain of Responsibility is a behavioral design pattern that lets you pass requests along a chain of handlers. Upon receiving a request, each handler decides either to process the request or to pass it to the next handler in the chain. 
[[File:Chain of Responsibility.png]]
 Implementation for our project 
[[File:CoR.png]]
== '''Project Description''' ==

=== Old version: ===
For assignments without a topic, there is no way to assign a mentor to the team on Expertiza system but to manually assigned one via Email out of the system.
[[File:Assign Mentor.png]]
 In the above case, there is no mentor role for the current Expertiza system, only to assign mentor manually
=== New version: ===
Assignments with or without a topic could be assigned with mentors automatically 
[[File:AddMentor.png]]
 Also, mentor and team members will be notified by Emails(Results showing in UI Test).

== '''Design Diagrams''' ==

=== Workflow Diagram ===
General workflow and specific add member workflow 
[[File:usecases.png]][[File:specific_workflow.png]]

== '''Proposed Solution''' ==

'''The solution we proposed generally follow the chain of responsibility and the work flow''' 
'''The solution will follow steps list here:'''
*Allow instructor to assign mentors for assignments without a topic
*Check the topic of assignment and number of team members whether reach the requirement or not
*Assign mentor for the team automatically
*Notificate both mentor and student
*Team member added after the mentor assignment will also get a email notification about mentor

== '''Code Implementation & Explanation''' ==
Since we implemented a whole new feature and kept the original work flow unchanged at the meantime, most modifications are in models: 
Models:
*app/models/assignment_team.rb
*app/models/assignment_participants.rb
*app/models/team.rb
*app/models/team_users.rb
*...
 
Views:
*app/views/student_task/view
*app/views/student_teams/view
*app/views/shared_scripts/_add_individual
*app/views/participants/_participant
*... 
Here we present some essential codes with explanation 
[[File:Mentor_role.png]]
 First, add mentor role for assignment. Set authorization for mentor which could not do review, take quiz or submit. 

[[File:Add_mentor_view.png]]

 Add a mentor role for instructor/admin when add participant for assignment 

[[File:Mentor_requirement.png]]
 To assign a mentor, there are several requirements:
*There should be at least one mentor in this assignment
*The current team size is greater than half of max size
*The team do not have a mentor yet
 

[[File:Assign_algorithm.png]]
 Always assign mentor with lowest number of mentoring teams, in order to do so:
*First, get all mentors for this assignment
*Traverse all mentors and calculate how many teams he/she mentored, store the one with lowest number
*Return mentor with lowest number of team she/he mentored 

[[File:Assign_algorithm.png]]
 Use Mailer class to send email notification about mentor and team members information(method used to send email notification for student is similar to this). 
== '''Test Plan''' ==
To make sure the refactor code can work correctly, we need to run the original rspec test code and add some new test. Besides, we are plaining to test from UI to make sure all the features work. The test results are shown below.

*Run and pass existing RSpec Tests after Modification
*Develop New RSpec Tests for the new features
*UI testing on the deployed project
==RSpec Test==
1. Add new participant type mentor in factories.rb 
[[File:Mentor_factory.png]] 

2.Test new added method in team_respec, like half, add_member, size... 
[[File:Add_member.png]] 
[[File:Half.png]] 

==UI Test==
1. Instructor/Admin add mentor for specific assignment 
[[File:AddMentor.png]] 
2. Student create team and invite others 
3. When team size greater than half of max size, assign mentor and send emails 
[[File:Members_email.png]]
[[File:Mentor_email.png]] 
4. When student accept from a team which has already been assigned with mentor, he/she would receive a email 
[[File:New_member_email.png]] 

5. Also we extend our work to make all teams visible to mentors 
[[File:Extend_work.png]] 

== '''Future Work''' ==
1. Mentor could not see teams' submissions since authorization control is working on the view assignment page and mentor does not have rights to submit 
2. Rspec Test for email functions

== '''Team Member''' ==
Our team members: (Sorted in Alphabetical order) 
*Hongli Wang, hwang85@ncsu.edu
*Minghao Liu, mliu25@ncsu.edu
*Ruiwen Wu, rwu5@ncsu.edu
*Siwei Wen, swen4@ncsu.edu

Mentor: Mrs. Carmen Aiken Bentley

CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics

2019-12-06T23:43:47Z

Rwu5: /* Links to the project */

== '''Problem Statement''' ==
For assignments with topics, like the OSS project, mentors are associated with topics, and then whichever team is assigned to the topic inherits the mentor for that topic However, for assignments without topics (like Program 2), there is no good way to “automatically” assign mentors to projects. The instructor needs to watch teams being formed, and every time a new team is formed, a new mentor needs to be assigned, outside of Expertiza. This leads to a lot of work for the instructor, as well as sometimes long delays before a team is assigned a mentor.

== '''Links to the project''' ==
Github Pull Request: https://github.com/expertiza/expertiza/pull/1651
 
Video Presentations:
https://youtu.be/kWQcB21n538
https://youtu.be/S7-psdWwRLc

== '''The goal behind this project:''' ==

Develop a trigger that: 
1) Is activated when any team has been formed that has k members, where k is greater than 50% of the maximum team capacity 
*ex) max members = 4, trigger activated when the team size reaches 3
2) Assign a mentor to the team 
*Mentors should be evenly assigned to teams, so a good strategy is to assign the mentor who has the fewest teams to mentor so far.
3) Notify the mentor via email that they are now assigned to a specific team, and provide the email addresses of the team members. 
4) Possibly notify the team members that they have been assigned the mentor with contact information (further discussion here) 

== '''Design Pattern''' ==
Since the trigger we implemented would need multiple handlers and each of them responses in different actions, we decide to use Chain of Responsibility as the design pattern. Chain of Responsibility is a behavioral design pattern that lets you pass requests along a chain of handlers. Upon receiving a request, each handler decides either to process the request or to pass it to the next handler in the chain. 
[[File:Chain of Responsibility.png]]
 Implementation for our project 
[[File:CoR.png]]
== '''Project Description''' ==

=== Old version: ===
For assignments without a topic, there is no way to assign a mentor to the team on Expertiza system but to manually assigned one via Email out of the system.
[[File:Assign Mentor.png]]
 In the above case, there is no mentor role for the current Expertiza system, only to assign mentor manually
=== New version: ===
Assignments with or without a topic could be assigned with mentors automatically 
[[File:AddMentor.png]]
 Also, mentor and team members will be notified by Emails(Results showing in UI Test).

== '''Design Diagrams''' ==

=== Workflow Diagram ===
General workflow and specific add member workflow 
[[File:usecases.png]][[File:specific_workflow.png]]

== '''Proposed Solution''' ==

'''The solution we proposed generally follow the chain of responsibility and the work flow''' 
'''The solution will follow steps list here:'''
*Allow instructor to assign mentors for assignments without a topic
*Check the topic of assignment and number of team members whether reach the requirement or not
*Assign mentor for the team automatically
*Notificate both mentor and student
*Team member added after the mentor assignment will also get a email notification about mentor

== '''Code Implementation & Explanation''' ==
Since we implemented a whole new feature and kept the original work flow unchanged at the meantime, most modifications are in models: 
Models:
*app/models/assignment_team.rb
*app/models/assignment_participants.rb
*app/models/team.rb
*app/models/team_users.rb
*...
 
Views:
*app/views/student_task/view
*app/views/student_teams/view
*app/views/shared_scripts/_add_individual
*app/views/participants/_participant
*... 
Here we present some essential codes with explanation 
[[File:Mentor_role.png]]
 First, add mentor role for assignment. Set authorization for mentor which could not do review, take quiz or submit. 

[[File:Add_mentor_view.png]]

 Add a mentor role for instructor/admin when add participant for assignment 

[[File:Mentor_requirement.png]]
 To assign a mentor, there are several requirements:
*There should be at least one mentor in this assignment
*The current team size is greater than half of max size
*The team do not have a mentor yet
 

[[File:Assign_algorithm.png]]
 Always assign mentor with lowest number of mentoring teams, in order to do so:
*First, get all mentors for this assignment
*Traverse all mentors and calculate how many teams he/she mentored, store the one with lowest number
*Return mentor with lowest number of team she/he mentored 

[[File:Assign_algorithm.png]]
 Use Mailer class to send email notification about mentor and team members information(method used to send email notification for student is similar to this). 
== '''Test Plan''' ==
To make sure the refactor code can work correctly, we need to run the original rspec test code and add some new test. Besides, we are plaining to test from UI to make sure all the features work. The test results are shown below.

*Run and pass existing RSpec Tests after Modification
*Develop New RSpec Tests for the new features
*UI testing on the deployed project
==RSpec Test==
1. Add new participant type mentor in factories.rb 
[[File:Mentor_factory.png]] 

2.Test new added method in team_respec, like half, add_member, size... 
[[File:Add_member.png]] 
[[File:Half.png]] 

==UI Test==
1. Instructor/Admin add mentor for specific assignment 
[[File:AddMentor.png]] 
2. Student create team and invite others 
3. When team size greater than half of max size, assign mentor and send emails 
[[File:Members_email.png]]
[[File:Mentor_email.png]] 
4. When student accept from a team which has already been assigned with mentor, he/she would receive a email 
[[File:New_member_email.png]] 

5. Also we extend our work to make all teams visible to mentors 
[[File:Extend_work.png]] 

== '''Team Member''' ==
Our team members: (Sorted in Alphabetical order) 
*Hongli Wang, hwang85@ncsu.edu
*Minghao Liu, mliu25@ncsu.edu
*Ruiwen Wu, rwu5@ncsu.edu
*Siwei Wen, swen4@ncsu.edu

Mentor: Mrs. Carmen Aiken Bentley

CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics

2019-12-06T23:43:25Z

Rwu5: /* Links to the project */

== '''Problem Statement''' ==
For assignments with topics, like the OSS project, mentors are associated with topics, and then whichever team is assigned to the topic inherits the mentor for that topic However, for assignments without topics (like Program 2), there is no good way to “automatically” assign mentors to projects. The instructor needs to watch teams being formed, and every time a new team is formed, a new mentor needs to be assigned, outside of Expertiza. This leads to a lot of work for the instructor, as well as sometimes long delays before a team is assigned a mentor.

== '''Links to the project''' ==
Github Pull Request: https://github.com/expertiza/expertiza/pull/1651
 
Video Presentations:
https://youtu.be/S7-psdWwRLc
https://youtu.be/kWQcB21n538

== '''The goal behind this project:''' ==

Develop a trigger that: 
1) Is activated when any team has been formed that has k members, where k is greater than 50% of the maximum team capacity 
*ex) max members = 4, trigger activated when the team size reaches 3
2) Assign a mentor to the team 
*Mentors should be evenly assigned to teams, so a good strategy is to assign the mentor who has the fewest teams to mentor so far.
3) Notify the mentor via email that they are now assigned to a specific team, and provide the email addresses of the team members. 
4) Possibly notify the team members that they have been assigned the mentor with contact information (further discussion here) 

== '''Design Pattern''' ==
Since the trigger we implemented would need multiple handlers and each of them responses in different actions, we decide to use Chain of Responsibility as the design pattern. Chain of Responsibility is a behavioral design pattern that lets you pass requests along a chain of handlers. Upon receiving a request, each handler decides either to process the request or to pass it to the next handler in the chain. 
[[File:Chain of Responsibility.png]]
 Implementation for our project 
[[File:CoR.png]]
== '''Project Description''' ==

=== Old version: ===
For assignments without a topic, there is no way to assign a mentor to the team on Expertiza system but to manually assigned one via Email out of the system.
[[File:Assign Mentor.png]]
 In the above case, there is no mentor role for the current Expertiza system, only to assign mentor manually
=== New version: ===
Assignments with or without a topic could be assigned with mentors automatically 
[[File:AddMentor.png]]
 Also, mentor and team members will be notified by Emails(Results showing in UI Test).

== '''Design Diagrams''' ==

=== Workflow Diagram ===
General workflow and specific add member workflow 
[[File:usecases.png]][[File:specific_workflow.png]]

== '''Proposed Solution''' ==

'''The solution we proposed generally follow the chain of responsibility and the work flow''' 
'''The solution will follow steps list here:'''
*Allow instructor to assign mentors for assignments without a topic
*Check the topic of assignment and number of team members whether reach the requirement or not
*Assign mentor for the team automatically
*Notificate both mentor and student
*Team member added after the mentor assignment will also get a email notification about mentor

== '''Code Implementation & Explanation''' ==
Since we implemented a whole new feature and kept the original work flow unchanged at the meantime, most modifications are in models: 
Models:
*app/models/assignment_team.rb
*app/models/assignment_participants.rb
*app/models/team.rb
*app/models/team_users.rb
*...
 
Views:
*app/views/student_task/view
*app/views/student_teams/view
*app/views/shared_scripts/_add_individual
*app/views/participants/_participant
*... 
Here we present some essential codes with explanation 
[[File:Mentor_role.png]]
 First, add mentor role for assignment. Set authorization for mentor which could not do review, take quiz or submit. 

[[File:Add_mentor_view.png]]

 Add a mentor role for instructor/admin when add participant for assignment 

[[File:Mentor_requirement.png]]
 To assign a mentor, there are several requirements:
*There should be at least one mentor in this assignment
*The current team size is greater than half of max size
*The team do not have a mentor yet
 

[[File:Assign_algorithm.png]]
 Always assign mentor with lowest number of mentoring teams, in order to do so:
*First, get all mentors for this assignment
*Traverse all mentors and calculate how many teams he/she mentored, store the one with lowest number
*Return mentor with lowest number of team she/he mentored 

[[File:Assign_algorithm.png]]
 Use Mailer class to send email notification about mentor and team members information(method used to send email notification for student is similar to this). 
== '''Test Plan''' ==
To make sure the refactor code can work correctly, we need to run the original rspec test code and add some new test. Besides, we are plaining to test from UI to make sure all the features work. The test results are shown below.

*Run and pass existing RSpec Tests after Modification
*Develop New RSpec Tests for the new features
*UI testing on the deployed project
==RSpec Test==
1. Add new participant type mentor in factories.rb 
[[File:Mentor_factory.png]] 

2.Test new added method in team_respec, like half, add_member, size... 
[[File:Add_member.png]] 
[[File:Half.png]] 

==UI Test==
1. Instructor/Admin add mentor for specific assignment 
[[File:AddMentor.png]] 
2. Student create team and invite others 
3. When team size greater than half of max size, assign mentor and send emails 
[[File:Members_email.png]]
[[File:Mentor_email.png]] 
4. When student accept from a team which has already been assigned with mentor, he/she would receive a email 
[[File:New_member_email.png]] 

5. Also we extend our work to make all teams visible to mentors 
[[File:Extend_work.png]] 

== '''Team Member''' ==
Our team members: (Sorted in Alphabetical order) 
*Hongli Wang, hwang85@ncsu.edu
*Minghao Liu, mliu25@ncsu.edu
*Ruiwen Wu, rwu5@ncsu.edu
*Siwei Wen, swen4@ncsu.edu

Mentor: Mrs. Carmen Aiken Bentley

CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics

2019-12-06T23:43:14Z

Rwu5: /* Links to the project */

== '''Problem Statement''' ==
For assignments with topics, like the OSS project, mentors are associated with topics, and then whichever team is assigned to the topic inherits the mentor for that topic However, for assignments without topics (like Program 2), there is no good way to “automatically” assign mentors to projects. The instructor needs to watch teams being formed, and every time a new team is formed, a new mentor needs to be assigned, outside of Expertiza. This leads to a lot of work for the instructor, as well as sometimes long delays before a team is assigned a mentor.

== '''Links to the project''' ==
Github Pull Request: https://github.com/expertiza/expertiza/pull/1651
Video Presentations:
https://youtu.be/S7-psdWwRLc
https://youtu.be/kWQcB21n538

== '''The goal behind this project:''' ==

Develop a trigger that: 
1) Is activated when any team has been formed that has k members, where k is greater than 50% of the maximum team capacity 
*ex) max members = 4, trigger activated when the team size reaches 3
2) Assign a mentor to the team 
*Mentors should be evenly assigned to teams, so a good strategy is to assign the mentor who has the fewest teams to mentor so far.
3) Notify the mentor via email that they are now assigned to a specific team, and provide the email addresses of the team members. 
4) Possibly notify the team members that they have been assigned the mentor with contact information (further discussion here) 

== '''Design Pattern''' ==
Since the trigger we implemented would need multiple handlers and each of them responses in different actions, we decide to use Chain of Responsibility as the design pattern. Chain of Responsibility is a behavioral design pattern that lets you pass requests along a chain of handlers. Upon receiving a request, each handler decides either to process the request or to pass it to the next handler in the chain. 
[[File:Chain of Responsibility.png]]
 Implementation for our project 
[[File:CoR.png]]
== '''Project Description''' ==

=== Old version: ===
For assignments without a topic, there is no way to assign a mentor to the team on Expertiza system but to manually assigned one via Email out of the system.
[[File:Assign Mentor.png]]
 In the above case, there is no mentor role for the current Expertiza system, only to assign mentor manually
=== New version: ===
Assignments with or without a topic could be assigned with mentors automatically 
[[File:AddMentor.png]]
 Also, mentor and team members will be notified by Emails(Results showing in UI Test).

== '''Design Diagrams''' ==

=== Workflow Diagram ===
General workflow and specific add member workflow 
[[File:usecases.png]][[File:specific_workflow.png]]

== '''Proposed Solution''' ==

'''The solution we proposed generally follow the chain of responsibility and the work flow''' 
'''The solution will follow steps list here:'''
*Allow instructor to assign mentors for assignments without a topic
*Check the topic of assignment and number of team members whether reach the requirement or not
*Assign mentor for the team automatically
*Notificate both mentor and student
*Team member added after the mentor assignment will also get a email notification about mentor

== '''Code Implementation & Explanation''' ==
Since we implemented a whole new feature and kept the original work flow unchanged at the meantime, most modifications are in models: 
Models:
*app/models/assignment_team.rb
*app/models/assignment_participants.rb
*app/models/team.rb
*app/models/team_users.rb
*...
 
Views:
*app/views/student_task/view
*app/views/student_teams/view
*app/views/shared_scripts/_add_individual
*app/views/participants/_participant
*... 
Here we present some essential codes with explanation 
[[File:Mentor_role.png]]
 First, add mentor role for assignment. Set authorization for mentor which could not do review, take quiz or submit. 

[[File:Add_mentor_view.png]]

 Add a mentor role for instructor/admin when add participant for assignment 

[[File:Mentor_requirement.png]]
 To assign a mentor, there are several requirements:
*There should be at least one mentor in this assignment
*The current team size is greater than half of max size
*The team do not have a mentor yet
 

[[File:Assign_algorithm.png]]
 Always assign mentor with lowest number of mentoring teams, in order to do so:
*First, get all mentors for this assignment
*Traverse all mentors and calculate how many teams he/she mentored, store the one with lowest number
*Return mentor with lowest number of team she/he mentored 

[[File:Assign_algorithm.png]]
 Use Mailer class to send email notification about mentor and team members information(method used to send email notification for student is similar to this). 
== '''Test Plan''' ==
To make sure the refactor code can work correctly, we need to run the original rspec test code and add some new test. Besides, we are plaining to test from UI to make sure all the features work. The test results are shown below.

*Run and pass existing RSpec Tests after Modification
*Develop New RSpec Tests for the new features
*UI testing on the deployed project
==RSpec Test==
1. Add new participant type mentor in factories.rb 
[[File:Mentor_factory.png]] 

2.Test new added method in team_respec, like half, add_member, size... 
[[File:Add_member.png]] 
[[File:Half.png]] 

==UI Test==
1. Instructor/Admin add mentor for specific assignment 
[[File:AddMentor.png]] 
2. Student create team and invite others 
3. When team size greater than half of max size, assign mentor and send emails 
[[File:Members_email.png]]
[[File:Mentor_email.png]] 
4. When student accept from a team which has already been assigned with mentor, he/she would receive a email 
[[File:New_member_email.png]] 

5. Also we extend our work to make all teams visible to mentors 
[[File:Extend_work.png]] 

== '''Team Member''' ==
Our team members: (Sorted in Alphabetical order) 
*Hongli Wang, hwang85@ncsu.edu
*Minghao Liu, mliu25@ncsu.edu
*Ruiwen Wu, rwu5@ncsu.edu
*Siwei Wen, swen4@ncsu.edu

Mentor: Mrs. Carmen Aiken Bentley

CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics

2019-11-11T00:08:51Z

Rwu5: /* Code Modified & Added */

CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics

2019-11-10T23:54:58Z

Rwu5: /* The goal behind this project: */

CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics

2019-11-10T23:54:50Z

Rwu5: /* The goal behind this project: */

CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics

2019-11-10T23:54:18Z

Rwu5: /* The goal behind this project: */

CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics

2019-11-10T23:53:59Z

Rwu5: /* The goal behind this project: */

CSC/ECE 517 Fall 2019 - E1994. Mentor management for assignments without topics

2019-11-10T23:49:12Z

Rwu5: /* User Story */

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-30T20:45:00Z

Rwu5: /* Project Deployment */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' render action: 'new'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task2-2-new.png]]

==Test==
====Test for Task1====
We created 4 institutions and check if they are alphabetically sorted in the selection box
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
We tried to create a new instructor6 with a new institution name
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''233''''' it 'save successfully with a new institution' do
'''''234''''' session = {user: admin}
'''''235''''' params = {
'''''236''''' user: {name: 'instructor6',
'''''237''''' crypted_password: 'password',
'''''238''''' role_id: 2,
'''''239''''' password_salt: 1,
'''''240''''' fullname: '6, instructor',
'''''241''''' email: 'yzhu48@ncsu.edu',
'''''242''''' parent_id: 1,
'''''243''''' private_by_default: false,
'''''244''''' mru_directory_path: nil,
'''''245''''' email_on_review: true,
'''''246''''' email_on_submission: true,
'''''247''''' email_on_review_of_review: true,
'''''248''''' is_new_user: false,
'''''249''''' master_permission_granted: 0,
'''''250''''' handle: 'handle',
'''''251''''' digital_certificate: nil,
'''''252''''' timezonepref: 'Eastern Time (US & Canada)',
'''''253''''' public_key: nil,
'''''254''''' copy_of_emails: nil,
'''''255''''' institution_id: 666,
'''''256''''' institution: {
'''''257''''' name: 'yzhu48'
'''''258''''' }
'''''259''''' }
'''''260''''' }
'''''261''''' post :create, params, session
'''''262''''' allow_any_instance_of(User).to receive(:undo_link).with('The user "instructor6" has been successfully created. ').and_return(true)
'''''263''''' expect(flash[:success]).to eq "A new password has been sent to new user's e-mail address."
'''''264''''' expect(response).to redirect_to('http://test.host/users/list')
'''''265''''' end

====Test for Task3====
We tested if the Institution column was on the page
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' create(:superadmin, name: 'super_administrator2')
'''''20''''' login_as('super_administrator2')
'''''21''''' visit "/users/list"
'''''22''''' expect(page.has_content?("Institution")).to eq(true)
'''''23''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.17.133:8080/ Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-30T20:44:51Z

Rwu5: /* Project Deployment */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' render action: 'new'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task2-2-new.png]]

==Test==
====Test for Task1====
We created 4 institutions and check if they are alphabetically sorted in the selection box
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
We tried to create a new instructor6 with a new institution name
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''233''''' it 'save successfully with a new institution' do
'''''234''''' session = {user: admin}
'''''235''''' params = {
'''''236''''' user: {name: 'instructor6',
'''''237''''' crypted_password: 'password',
'''''238''''' role_id: 2,
'''''239''''' password_salt: 1,
'''''240''''' fullname: '6, instructor',
'''''241''''' email: 'yzhu48@ncsu.edu',
'''''242''''' parent_id: 1,
'''''243''''' private_by_default: false,
'''''244''''' mru_directory_path: nil,
'''''245''''' email_on_review: true,
'''''246''''' email_on_submission: true,
'''''247''''' email_on_review_of_review: true,
'''''248''''' is_new_user: false,
'''''249''''' master_permission_granted: 0,
'''''250''''' handle: 'handle',
'''''251''''' digital_certificate: nil,
'''''252''''' timezonepref: 'Eastern Time (US & Canada)',
'''''253''''' public_key: nil,
'''''254''''' copy_of_emails: nil,
'''''255''''' institution_id: 666,
'''''256''''' institution: {
'''''257''''' name: 'yzhu48'
'''''258''''' }
'''''259''''' }
'''''260''''' }
'''''261''''' post :create, params, session
'''''262''''' allow_any_instance_of(User).to receive(:undo_link).with('The user "instructor6" has been successfully created. ').and_return(true)
'''''263''''' expect(flash[:success]).to eq "A new password has been sent to new user's e-mail address."
'''''264''''' expect(response).to redirect_to('http://test.host/users/list')
'''''265''''' end

====Test for Task3====
We tested if the Institution column was on the page
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' create(:superadmin, name: 'super_administrator2')
'''''20''''' login_as('super_administrator2')
'''''21''''' visit "/users/list"
'''''22''''' expect(page.has_content?("Institution")).to eq(true)
'''''23''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.17.133:8080/:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-30T00:00:07Z

Rwu5: /* Test for Task3 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' render action: 'new'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task2-2-new.png]]

==Test==
====Test for Task1====
We created 4 institutions and check if they are alphabetically sorted in the selection box
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
We tried to create a new instructor6 with a new institution name
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''233''''' it 'save successfully with a new institution' do
'''''234''''' session = {user: admin}
'''''235''''' params = {
'''''236''''' user: {name: 'instructor6',
'''''237''''' crypted_password: 'password',
'''''238''''' role_id: 2,
'''''239''''' password_salt: 1,
'''''240''''' fullname: '6, instructor',
'''''241''''' email: 'yzhu48@ncsu.edu',
'''''242''''' parent_id: 1,
'''''243''''' private_by_default: false,
'''''244''''' mru_directory_path: nil,
'''''245''''' email_on_review: true,
'''''246''''' email_on_submission: true,
'''''247''''' email_on_review_of_review: true,
'''''248''''' is_new_user: false,
'''''249''''' master_permission_granted: 0,
'''''250''''' handle: 'handle',
'''''251''''' digital_certificate: nil,
'''''252''''' timezonepref: 'Eastern Time (US & Canada)',
'''''253''''' public_key: nil,
'''''254''''' copy_of_emails: nil,
'''''255''''' institution_id: 666,
'''''256''''' institution: {
'''''257''''' name: 'yzhu48'
'''''258''''' }
'''''259''''' }
'''''260''''' }
'''''261''''' post :create, params, session
'''''262''''' allow_any_instance_of(User).to receive(:undo_link).with('The user "instructor6" has been successfully created. ').and_return(true)
'''''263''''' expect(flash[:success]).to eq "A new password has been sent to new user's e-mail address."
'''''264''''' expect(response).to redirect_to('http://test.host/users/list')
'''''265''''' end

====Test for Task3====
We tested if the Institution column was on the page
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' create(:superadmin, name: 'super_administrator2')
'''''20''''' login_as('super_administrator2')
'''''21''''' visit "/users/list"
'''''22''''' expect(page.has_content?("Institution")).to eq(true)
'''''23''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T23:59:31Z

Rwu5: /* Test for Task2 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' render action: 'new'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task2-2-new.png]]

==Test==
====Test for Task1====
We created 4 institutions and check if they are alphabetically sorted in the selection box
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
We tried to create a new instructor6 with a new institution name
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''233''''' it 'save successfully with a new institution' do
'''''234''''' session = {user: admin}
'''''235''''' params = {
'''''236''''' user: {name: 'instructor6',
'''''237''''' crypted_password: 'password',
'''''238''''' role_id: 2,
'''''239''''' password_salt: 1,
'''''240''''' fullname: '6, instructor',
'''''241''''' email: 'yzhu48@ncsu.edu',
'''''242''''' parent_id: 1,
'''''243''''' private_by_default: false,
'''''244''''' mru_directory_path: nil,
'''''245''''' email_on_review: true,
'''''246''''' email_on_submission: true,
'''''247''''' email_on_review_of_review: true,
'''''248''''' is_new_user: false,
'''''249''''' master_permission_granted: 0,
'''''250''''' handle: 'handle',
'''''251''''' digital_certificate: nil,
'''''252''''' timezonepref: 'Eastern Time (US & Canada)',
'''''253''''' public_key: nil,
'''''254''''' copy_of_emails: nil,
'''''255''''' institution_id: 666,
'''''256''''' institution: {
'''''257''''' name: 'yzhu48'
'''''258''''' }
'''''259''''' }
'''''260''''' }
'''''261''''' post :create, params, session
'''''262''''' allow_any_instance_of(User).to receive(:undo_link).with('The user "instructor6" has been successfully created. ').and_return(true)
'''''263''''' expect(flash[:success]).to eq "A new password has been sent to new user's e-mail address."
'''''264''''' expect(response).to redirect_to('http://test.host/users/list')
'''''265''''' end

====Test for Task3====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' create(:superadmin, name: 'super_administrator2')
'''''20''''' login_as('super_administrator2')
'''''21''''' visit "/users/list"
'''''22''''' expect(page.has_content?("Institution")).to eq(true)
'''''23''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T23:58:56Z

Rwu5: /* Test for Task1 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' render action: 'new'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task2-2-new.png]]

==Test==
====Test for Task1====
We created 4 institutions and check if they are alphabetically sorted in the selection box
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''233''''' it 'save successfully with a new institution' do
'''''234''''' session = {user: admin}
'''''235''''' params = {
'''''236''''' user: {name: 'instructor6',
'''''237''''' crypted_password: 'password',
'''''238''''' role_id: 2,
'''''239''''' password_salt: 1,
'''''240''''' fullname: '6, instructor',
'''''241''''' email: 'yzhu48@ncsu.edu',
'''''242''''' parent_id: 1,
'''''243''''' private_by_default: false,
'''''244''''' mru_directory_path: nil,
'''''245''''' email_on_review: true,
'''''246''''' email_on_submission: true,
'''''247''''' email_on_review_of_review: true,
'''''248''''' is_new_user: false,
'''''249''''' master_permission_granted: 0,
'''''250''''' handle: 'handle',
'''''251''''' digital_certificate: nil,
'''''252''''' timezonepref: 'Eastern Time (US & Canada)',
'''''253''''' public_key: nil,
'''''254''''' copy_of_emails: nil,
'''''255''''' institution_id: 666,
'''''256''''' institution: {
'''''257''''' name: 'yzhu48'
'''''258''''' }
'''''259''''' }
'''''260''''' }
'''''261''''' post :create, params, session
'''''262''''' allow_any_instance_of(User).to receive(:undo_link).with('The user "instructor6" has been successfully created. ').and_return(true)
'''''263''''' expect(flash[:success]).to eq "A new password has been sent to new user's e-mail address."
'''''264''''' expect(response).to redirect_to('http://test.host/users/list')
'''''265''''' end

====Test for Task3====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' create(:superadmin, name: 'super_administrator2')
'''''20''''' login_as('super_administrator2')
'''''21''''' visit "/users/list"
'''''22''''' expect(page.has_content?("Institution")).to eq(true)
'''''23''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T23:54:46Z

Rwu5: /* Task3 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' render action: 'new'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task2-2-new.png]]

==Test==
====Test for Task1====
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''233''''' it 'save successfully with a new institution' do
'''''234''''' session = {user: admin}
'''''235''''' params = {
'''''236''''' user: {name: 'instructor6',
'''''237''''' crypted_password: 'password',
'''''238''''' role_id: 2,
'''''239''''' password_salt: 1,
'''''240''''' fullname: '6, instructor',
'''''241''''' email: 'yzhu48@ncsu.edu',
'''''242''''' parent_id: 1,
'''''243''''' private_by_default: false,
'''''244''''' mru_directory_path: nil,
'''''245''''' email_on_review: true,
'''''246''''' email_on_submission: true,
'''''247''''' email_on_review_of_review: true,
'''''248''''' is_new_user: false,
'''''249''''' master_permission_granted: 0,
'''''250''''' handle: 'handle',
'''''251''''' digital_certificate: nil,
'''''252''''' timezonepref: 'Eastern Time (US & Canada)',
'''''253''''' public_key: nil,
'''''254''''' copy_of_emails: nil,
'''''255''''' institution_id: 666,
'''''256''''' institution: {
'''''257''''' name: 'yzhu48'
'''''258''''' }
'''''259''''' }
'''''260''''' }
'''''261''''' post :create, params, session
'''''262''''' allow_any_instance_of(User).to receive(:undo_link).with('The user "instructor6" has been successfully created. ').and_return(true)
'''''263''''' expect(flash[:success]).to eq "A new password has been sent to new user's e-mail address."
'''''264''''' expect(response).to redirect_to('http://test.host/users/list')
'''''265''''' end

====Test for Task3====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' create(:superadmin, name: 'super_administrator2')
'''''20''''' login_as('super_administrator2')
'''''21''''' visit "/users/list"
'''''22''''' expect(page.has_content?("Institution")).to eq(true)
'''''23''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T03:43:51Z

Rwu5: /* Task2 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' render action: 'new'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''233''''' it 'save successfully with a new institution' do
'''''234''''' session = {user: admin}
'''''235''''' params = {
'''''236''''' user: {name: 'instructor6',
'''''237''''' crypted_password: 'password',
'''''238''''' role_id: 2,
'''''239''''' password_salt: 1,
'''''240''''' fullname: '6, instructor',
'''''241''''' email: 'yzhu48@ncsu.edu',
'''''242''''' parent_id: 1,
'''''243''''' private_by_default: false,
'''''244''''' mru_directory_path: nil,
'''''245''''' email_on_review: true,
'''''246''''' email_on_submission: true,
'''''247''''' email_on_review_of_review: true,
'''''248''''' is_new_user: false,
'''''249''''' master_permission_granted: 0,
'''''250''''' handle: 'handle',
'''''251''''' digital_certificate: nil,
'''''252''''' timezonepref: 'Eastern Time (US & Canada)',
'''''253''''' public_key: nil,
'''''254''''' copy_of_emails: nil,
'''''255''''' institution_id: 666,
'''''256''''' institution: {
'''''257''''' name: 'yzhu48'
'''''258''''' }
'''''259''''' }
'''''260''''' }
'''''261''''' post :create, params, session
'''''262''''' allow_any_instance_of(User).to receive(:undo_link).with('The user "instructor6" has been successfully created. ').and_return(true)
'''''263''''' expect(flash[:success]).to eq "A new password has been sent to new user's e-mail address."
'''''264''''' expect(response).to redirect_to('http://test.host/users/list')
'''''265''''' end

====Test for Task3====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' create(:superadmin, name: 'super_administrator2')
'''''20''''' login_as('super_administrator2')
'''''21''''' visit "/users/list"
'''''22''''' expect(page.has_content?("Institution")).to eq(true)
'''''23''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T03:36:04Z

Rwu5: /* Test for Task2 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''233''''' it 'save successfully with a new institution' do
'''''234''''' session = {user: admin}
'''''235''''' params = {
'''''236''''' user: {name: 'instructor6',
'''''237''''' crypted_password: 'password',
'''''238''''' role_id: 2,
'''''239''''' password_salt: 1,
'''''240''''' fullname: '6, instructor',
'''''241''''' email: 'yzhu48@ncsu.edu',
'''''242''''' parent_id: 1,
'''''243''''' private_by_default: false,
'''''244''''' mru_directory_path: nil,
'''''245''''' email_on_review: true,
'''''246''''' email_on_submission: true,
'''''247''''' email_on_review_of_review: true,
'''''248''''' is_new_user: false,
'''''249''''' master_permission_granted: 0,
'''''250''''' handle: 'handle',
'''''251''''' digital_certificate: nil,
'''''252''''' timezonepref: 'Eastern Time (US & Canada)',
'''''253''''' public_key: nil,
'''''254''''' copy_of_emails: nil,
'''''255''''' institution_id: 666,
'''''256''''' institution: {
'''''257''''' name: 'yzhu48'
'''''258''''' }
'''''259''''' }
'''''260''''' }
'''''261''''' post :create, params, session
'''''262''''' allow_any_instance_of(User).to receive(:undo_link).with('The user "instructor6" has been successfully created. ').and_return(true)
'''''263''''' expect(flash[:success]).to eq "A new password has been sent to new user's e-mail address."
'''''264''''' expect(response).to redirect_to('http://test.host/users/list')
'''''265''''' end

====Test for Task3====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' create(:superadmin, name: 'super_administrator2')
'''''20''''' login_as('super_administrator2')
'''''21''''' visit "/users/list"
'''''22''''' expect(page.has_content?("Institution")).to eq(true)
'''''23''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T03:34:38Z

Rwu5: /* Test for Task2 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''233'''''it 'save successfully with a new institution' do
'''''234''''' session = {user: admin}
'''''235''''' params = {
'''''236''''' user: {name: 'instructor6',
'''''237''''' crypted_password: 'password',
'''''238''''' role_id: 2,
'''''239''''' password_salt: 1,
'''''240''''' fullname: '6, instructor',
'''''241''''' email: 'yzhu48@ncsu.edu',
'''''242''''' parent_id: 1,
'''''243''''' private_by_default: false,
'''''244''''' mru_directory_path: nil,
'''''245''''' email_on_review: true,
'''''246''''' email_on_submission: true,
'''''247''''' email_on_review_of_review: true,
'''''248''''' is_new_user: false,
'''''249''''' master_permission_granted: 0,
'''''250''''' handle: 'handle',
'''''251''''' digital_certificate: nil,
'''''252''''' timezonepref: 'Eastern Time (US & Canada)',
'''''253''''' public_key: nil,
'''''254''''' copy_of_emails: nil,
'''''255''''' institution_id: 666,
'''''256''''' institution: {
'''''257''''' name: 'yzhu48'
'''''258''''' }
'''''259''''' }
'''''260''''' }
'''''261''''' post :create, params, session
'''''262''''' allow_any_instance_of(User).to receive(:undo_link).with('The user "instructor6" has been successfully created. ').and_return(true)
'''''263''''' expect(flash[:success]).to eq "A new password has been sent to new user's e-mail address."
'''''264''''' expect(response).to redirect_to('http://test.host/users/list')
'''''265'''''end

====Test for Task3====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' create(:superadmin, name: 'super_administrator2')
'''''20''''' login_as('super_administrator2')
'''''21''''' visit "/users/list"
'''''22''''' expect(page.has_content?("Institution")).to eq(true)
'''''23''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T03:30:01Z

Rwu5: /* Test for Task3 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''234''''' session = {user: admin}
'''''235''''' params = {
'''''236''''' user: {name: 'instructor6',
'''''237''''' crypted_password: 'password',
'''''238''''' role_id: 2,
'''''239''''' password_salt: 1,
'''''240''''' fullname: '6, instructor',
'''''241''''' email: 'yzhu48@ncsu.edu',
'''''242''''' parent_id: 1,
'''''243''''' private_by_default: false,
'''''244''''' mru_directory_path: nil,
'''''245''''' email_on_review: true,
'''''246''''' email_on_submission: true,
'''''247''''' email_on_review_of_review: true,
'''''248''''' is_new_user: false,
'''''249''''' master_permission_granted: 0,
'''''250''''' handle: 'handle',
'''''251''''' digital_certificate: nil,
'''''252''''' timezonepref: 'Eastern Time (US & Canada)',
'''''253''''' public_key: nil,
'''''254''''' copy_of_emails: nil,
'''''255''''' institution_id: 666,
'''''256''''' institution: {
'''''257''''' name: 'yzhu48'
'''''258''''' }
'''''259''''' }
'''''260''''' }
'''''261''''' post :create, params, session
'''''262''''' allow_any_instance_of(User).to receive(:undo_link).with('The user "instructor6" has been successfully created. ').and_return(true)
'''''263''''' expect(flash[:success]).to eq "A new password has been sent to new user's e-mail address."
'''''264''''' expect(response).to redirect_to('http://test.host/users/list')

====Test for Task3====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' create(:superadmin, name: 'super_administrator2')
'''''20''''' login_as('super_administrator2')
'''''21''''' visit "/users/list"
'''''22''''' expect(page.has_content?("Institution")).to eq(true)
'''''23''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T03:29:45Z

Rwu5: /* Test for Task3 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''234''''' session = {user: admin}
'''''235''''' params = {
'''''236''''' user: {name: 'instructor6',
'''''237''''' crypted_password: 'password',
'''''238''''' role_id: 2,
'''''239''''' password_salt: 1,
'''''240''''' fullname: '6, instructor',
'''''241''''' email: 'yzhu48@ncsu.edu',
'''''242''''' parent_id: 1,
'''''243''''' private_by_default: false,
'''''244''''' mru_directory_path: nil,
'''''245''''' email_on_review: true,
'''''246''''' email_on_submission: true,
'''''247''''' email_on_review_of_review: true,
'''''248''''' is_new_user: false,
'''''249''''' master_permission_granted: 0,
'''''250''''' handle: 'handle',
'''''251''''' digital_certificate: nil,
'''''252''''' timezonepref: 'Eastern Time (US & Canada)',
'''''253''''' public_key: nil,
'''''254''''' copy_of_emails: nil,
'''''255''''' institution_id: 666,
'''''256''''' institution: {
'''''257''''' name: 'yzhu48'
'''''258''''' }
'''''259''''' }
'''''260''''' }
'''''261''''' post :create, params, session
'''''262''''' allow_any_instance_of(User).to receive(:undo_link).with('The user "instructor6" has been successfully created. ').and_return(true)
'''''263''''' expect(flash[:success]).to eq "A new password has been sent to new user's e-mail address."
'''''264''''' expect(response).to redirect_to('http://test.host/users/list')

====Test for Task3====
'''Changed files:''' spec/controllers/users_controller_spec.rb
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' create(:superadmin, name: 'super_administrator2')
'''''20''''' login_as('super_administrator2')
'''''21''''' visit "/users/list"
'''''22''''' expect(page.has_content?("Institution")).to eq(true)
'''''23''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T03:26:20Z

Rwu5: /* Test for Task2 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
'''Changed files:''' spec/controllers/users_controller_spec.rb

'''''234''''' session = {user: admin}
'''''235''''' params = {
'''''236''''' user: {name: 'instructor6',
'''''237''''' crypted_password: 'password',
'''''238''''' role_id: 2,
'''''239''''' password_salt: 1,
'''''240''''' fullname: '6, instructor',
'''''241''''' email: 'yzhu48@ncsu.edu',
'''''242''''' parent_id: 1,
'''''243''''' private_by_default: false,
'''''244''''' mru_directory_path: nil,
'''''245''''' email_on_review: true,
'''''246''''' email_on_submission: true,
'''''247''''' email_on_review_of_review: true,
'''''248''''' is_new_user: false,
'''''249''''' master_permission_granted: 0,
'''''250''''' handle: 'handle',
'''''251''''' digital_certificate: nil,
'''''252''''' timezonepref: 'Eastern Time (US & Canada)',
'''''253''''' public_key: nil,
'''''254''''' copy_of_emails: nil,
'''''255''''' institution_id: 666,
'''''256''''' institution: {
'''''257''''' name: 'yzhu48'
'''''258''''' }
'''''259''''' }
'''''260''''' }
'''''261''''' post :create, params, session
'''''262''''' allow_any_instance_of(User).to receive(:undo_link).with('The user "instructor6" has been successfully created. ').and_return(true)
'''''263''''' expect(flash[:success]).to eq "A new password has been sent to new user's e-mail address."
'''''264''''' expect(response).to redirect_to('http://test.host/users/list')

====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T03:09:34Z

Rwu5: /* Test for Task1 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T03:09:27Z

Rwu5: /* Test for Task1 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
'''Changed files:''' spec/features/course_creation_spec.rb

'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T03:09:18Z

Rwu5: /* Test for Task1 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
'''Changed files:''' spec/features/course_creation_spec.rb
'''''13''''' it "check if the courses are sorted alphabetically" do
'''''14''''' create(:superadmin, name: 'super_administrator2')
'''''15''''' login_as('super_administrator2')
'''''16''''' visit "/course/new?private=1"
'''''17''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[1]").text).to eq("A")
'''''18''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[2]").text).to eq("B")
'''''19''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[3]").text).to eq("C")
'''''20''''' expect(page.find(:xpath, "//*[@id=\"course_institutions_id\"]/option[4]").text).to eq("D")
'''''21''''' end

====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-29T03:06:12Z

Rwu5: /* Task3 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T22:03:50Z

Rwu5: /* Project Deployment */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>
==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[http://152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T22:03:09Z

Rwu5: /* Project Deployment */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>
==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T22:03:00Z

Rwu5: /* Project Deployment */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>
==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
[152.46.18.195:8080 Expertiza_Team_4430]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T22:02:34Z

Rwu5: /* E1971. OSS project Finklestein: Instructors & Institutions */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>
==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Project Deployment==
152.46.18.195:8080

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

File:Task2-2-new.png

2019-10-28T03:41:54Z

Rwu5: uploaded a new version of "File:Task2-2-new.png"

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:41:19Z

Rwu5: /* Task2 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>
==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
[[File:Task2-2-new.png]]

====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

File:Task2-2-new.png

2019-10-28T03:41:03Z

Rwu5:

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:35:45Z

Rwu5: /* Task Demonstration */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>
==Task Demonstration==
====Task1====
[[File:Task1-new.png]]
====Task2====
[[File:Task2-new.png]]
====Task3====
[[File:Task1-new.png]]

==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:35:18Z

Rwu5: /* Task Demonstration */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>
==Task Demonstration==
Task1:
[[File:Task1-new.png]]
Task2:
[[File:Task2-new.png]]
Task3:
[[File:Task1-new.png]]

==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:33:37Z

Rwu5: /* E1971. OSS project Finklestein: Instructors & Institutions */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>
==Task Demonstration==
[[File:Task1-new.png]]
[[File:Task2-new.png]]
[[File:Task1-new.png]]
==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

File:Task2-new.png

2019-10-28T03:33:28Z

Rwu5:

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:30:57Z

Rwu5: /* Problem Statement */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:30:43Z

Rwu5: /* Task2 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:30:26Z

Rwu5: /* E1971. OSS project Finklestein: Instructors & Institutions */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

===Task2===
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>
==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

File:Task1-new.png

2019-10-28T03:27:06Z

Rwu5:

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:24:03Z

Rwu5: /* E1971. OSS project Finklestein: Instructors & Institutions */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

===Task2===
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

==Test==
====Test for Task1====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
====Test for Task2====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
====Test for Task3====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

==Process Video==
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

==Team Information==
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

==References==

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:22:48Z

Rwu5: /* Task2 */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

===Task1===
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

===Task2===
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

===Test===
=====Test for Task1=====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
=====Test for Task2=====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
=====Test for Task3=====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

===Process Video===
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

===Team Information===
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

===References===

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:22:33Z

Rwu5: /* E1971. OSS project Finklestein: Instructors & Institutions */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

==Introduction==

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

==Problem Statement==
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

===Task1===
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

===Task2===
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

===Test===
=====Test for Task1=====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
=====Test for Task2=====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
=====Test for Task3=====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

===Process Video===
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

===Team Information===
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

===References===

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:21:49Z

Rwu5: /* Process Video */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

===Introduction===

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

===Problem Statement===
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

===Test===
=====Test for Task1=====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
=====Test for Task2=====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
=====Test for Task3=====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

===Process Video===
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

===Team Information===
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

===References===

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:21:36Z

Rwu5: /* Process Video */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

===Introduction===

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

===Problem Statement===
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

===Test===
=====Test for Task1=====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
=====Test for Task2=====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
=====Test for Task3=====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

===Process Video===
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]
Video Demonstration for Testing Task2: [https://youtu.be/3BIsI2UpNRo Task2-Video]
Video Demonstration for Testing Task3: [https://youtu.be/ZmLfvYLmLTo Task3-Video]

===Team Information===
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

===References===

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:20:24Z

Rwu5: /* Test */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

===Introduction===

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

===Problem Statement===
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

===Test===
=====Test for Task1=====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
=====Test for Task2=====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''254''''' end
=====Test for Task3=====
'''''17''''' describe "View users" do
'''''18''''' it "check if instructors show their institutions on the same line as their new feature" do
'''''19''''' require 'pp'
'''''20''''' driver = Selenium::WebDriver.for :firefox
'''''21''''' driver.get("http://localhost:3000/")
'''''22''''' driver.find_element(:id, "login_name").send_keys("instructor6")
'''''23''''' driver.find_element(:id, "login_password").send_keys("password")
'''''24''''' driver.find_element(:name, "commit").click()
'''''25''''' driver.get("http://localhost:3000/users/list")
'''''26'''''
'''''27''''' has_institution = false
'''''28''''' if driver.find_element(xpath: "/html/body/div[1]/div[1]/div/div/div/div/table/tbody/tr[2]/th[3]").text == "Institution"
'''''29''''' has_institution = true
'''''30''''' expect(has_institution).to be(true)
'''''31''''' end
'''''32''''' expect(has_institution).to be(true)
'''''33''''' end
'''''34''''' end

===Process Video===
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]

===Team Information===
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

===References===

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]

CSC/ECE 517 Fall 2019 - E1971. OSS project Finklestein: Instructors & Institutions

2019-10-28T03:14:20Z

Rwu5: /* Test */

=E1971. OSS project Finklestein: Instructors & Institutions=

[http://expertiza.ncsu.edu/ Expertiza] is an open-source project based on [http://rubyonrails.org/ Ruby on Rails] framework. Expertiza allows instructors to manager courses and assignments for students. Students can form up teams in Expertiza to work on different projects and assignments and do peer review about other students' submissions.

__TOC__

===Introduction===

* E1971 Project aims to fix the associations problems between the Institution and Instructor class.

* The forked git repository for this project can be found [https://github.com/YongjianZhu/expertiza Expertiza-E1971]

===Problem Statement===
The following tasks were accomplished in E1971 project:

* Task1: The institution list should be sorted alphabetically.
** Details: When creating a course, the drop-down list for selecting the institution does not show in alphabetical order.
[[File:E1971-Task1.png]]

* Task2: Adding a new institution during creation of an instructor profile.
** Details: The admin can attempt to create a new institution when creating a new instructor. But, after one types in the name of the institution & clicks create, it crashes.
[[File:E1971-Task2.png]]

* Task3: Listing of instructors should show their institutions on the same line as their new feature.
** Details: When listing users, there is currently no column to display the user’s associated institution.
[[File:E1971-Task3.png]]

====Task1====
As the issue is the Institution drop-down list is not alphabetically sorted. We simply added a step of sort when the Institution list was retrieved from the Database.
'''Changed files:''' _course.html.erb

'''''line3''''' <%= select("course", "institutions_id", Institution.all.order(:name).collect{ |c| [ c.name, c.id] }) %>

====Task2====
The issue occurs when the admin trying to create a new instructor with a new institution name. To fix this problem, we added a function to create a new institution and a confirmation prompt to alert the admin.

'''Changed files:''' app/controllers/users_controller.rb

'''''116''''' # if the user name already exists, register the user by email address
'''''117''''' check = User.find_by(name: params[:user][:name])
'''''118''''' params[:user][:name] = params[:user][:email] unless check.nil?
'''''119''''' if params[:user][:institution_id].empty?
'''''120''''' institution = Institution.find_or_create_by(name: params[:institution][:name])
'''''121''''' params[:user][:institution_id] = institution.id
'''''122''''' end
'''''123''''' @user = User.new(user_params)
'''''124''''' @user.institution_id = params[:user][:institution_id]
-------------------------------------------------------------------------------------------------
'''''142''''' else
'''''143''''' foreign
<del>'''''144''''' render action: 'new'</del>
'''''144''''' flash[:error] = "Create Instructor Error!"
'''''145''''' redirect_to '/admin/list_instructors'
'''''146''''' end

'''Changed files:''' app/views/users/new.html.erb

'''''8''''' <ρ style="color: red; font-weight: bold">* Please Make Sure All Information is Correct</ρ>
'''''9''''' <%= submit_tag "Create" %>

====Task3====
The issue is that the user page is not displaying the user's associated institution. To fix this issue, we added an 'institution' column in the HTML file retrieving the institution names of each user.
'''Changed files:''' app/models/user.rb

'''''111''''' def institution(ip_address = nil)
'''''112''''' if User.anonymized_view?(ip_address)
'''''113''''' self.role.name + ', ' + self.id.to_s
'''''114''''' else
'''''115''''' if self[:role_id] == 2
'''''116''''' self[:institution_id].nil? ? "" : Institution.find(self[:institution_id]).name
'''''117''''' end
'''''118''''' end
'''''119''''' end

'''Changed files:''' app/views/users/list.html.erb

'''''20''''' <tr>
'''''21''''' <th class="head">Name</th>
'''''22''''' <th class="head">Full Name</th>
'''''23''''' <th class="head">Institution</th>
'''''24''''' <th class="head">Email Address</th>
'''''25''''' <th class="head">Role</th>
'''''26''''' <th class="head">Parent</th>
'''''27''''' <th class="head">Review</th>
'''''28''''' <th class="head">Submission</th>
'''''29''''' <th class="head">Metareview</th>
'''''30''''' </tr>
'''''31''''' <% for user in @users %>
'''''32''''' <% if ((params[:show] != 'true' && !user.name(session[:ip]).include?("_hidden")) || params[:show] == 'true')%>
'''''33''''' <tr class="exp">
'''''34''''' <td><%= link_to user.name(session[:ip]), impersonate_impersonate_path(:user => {:name => user.name(session[:ip])}), :method => :post %></td>
'''''35''''' <td><%= link_to user.fullname(session[:ip]), :controller=> 'users', :action => 'show', :id => user.id %></td>
'''''36''''' <td><%= user.institution(session[:ip]) %></td>
'''''37''''' <td><%= user.email(session[:ip]) %></td>
'''''38''''' <td><%= link_to user.role.name, :controller => 'roles', :action => 'show', :id => user.role.id %></td>
'''''39''''' <td align="center"><%= user.parent.try :name %></td>
'''''40''''' <td><%= User.yesorno(user.email_on_review) %></td>
'''''41''''' <td><%= User.yesorno(user.email_on_submission) %></td>
'''''42''''' <td><%= User.yesorno(user.email_on_review_of_review) %></td>
'''''43''''' </tr>
'''''44''''' <% end %>
'''''45''''' <% end -%>

===Test===
=====Test for Task1=====
''''' 8''''' it "check if the courses are sorted alphabetically" do
''''' 9''''' driver = Selenium::WebDriver.for :firefox
'''''10''''' driver.get("http://localhost:3000/")
'''''11''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''12''''' driver.find_element(:id, "login_password").send_keys("password")
'''''13''''' driver.find_element(:name, "commit").click()
'''''14''''' driver.get("http://localhost:3000/course/new?private=1")
'''''15''''' institutions_eles = driver.find_element(:id, "course_institutions_id")
'''''16''''' options = institutions_eles.find_elements(:tag_name, 'option')
'''''17''''' result = true
'''''18''''' for x in 0..options.size-2
'''''19''''' if (options[x].text.downcase <=> options[x+1].text.downcase) > 0
'''''20''''' result = false
'''''21''''' break
'''''22''''' end
'''''23''''' end
'''''24''''' expect(result).to be(true)
'''''25''''' end
=====Test for Task2=====
'''''233''''' it 'save successfully with a new institution' do
'''''234''''' driver = Selenium::WebDriver.for :firefox
'''''235''''' driver.get("http://localhost:3000/")
'''''236''''' driver.find_element(:id, "login_name").send_keys("super_administrator2")
'''''237''''' driver.find_element(:id, "login_password").send_keys("password")
'''''238''''' driver.find_element(:name, "commit").click()
'''''239''''' driver.get("http://localhost:3000/users/new?utf8=%E2%9C%93&role=Instructor&commit=New+Instructor")
'''''240''''' driver.find_element(:id, "user_name").send_keys("yzhu48")
'''''241''''' driver.find_element(:id, "user_fullname").send_keys("yzhu48")
'''''242''''' driver.find_element(:id, "user_email").send_keys("yzhu48@ncsu.com")
'''''243''''' driver.find_element(:id, "user_password").send_keys("111111")
'''''244''''' driver.find_element(:id, "user_password_confirmation").send_keys("111111")
'''''245'''''
'''''246''''' institutionMenu = driver.find_element(:id, 'user_institution_id')
'''''247''''' option = Selenium::WebDriver::Support::Select.new(institutionMenu)
'''''248''''' option.select_by(:text, 'Other')
'''''249'''''
'''''250''''' driver.find_element(:id, "institution_name").send_keys("yzhu48")
'''''251'''''
'''''252''''' driver.find_element(:name, "commit").click()
'''''253''''' expect(response.status).to eq(200)
'''''255''''' end

===Process Video===
Video Demonstration for Testing Task1: [https://youtu.be/FXQu1fcbM20 Task1-Video]

===Team Information===
'''Team_4430:'''
Ruiwen Wu (rwu5@ncsu.edu)
Yongjian Zhu (yzhu48@ncsu.edu)
Ling Li (lli46@ncsu.edu)
'''Mentor:''' Carmen Bentley (cnaiken@ncsu.edu)

===References===

[https://github.com/expertiza/expertiza Expertiza on GitHub]

[http://expertiza.ncsu.edu/ Expertiza website]

[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza project documentation wiki]

[https://github.com/YongjianZhu/expertiza GitHub Project Repository Fork]

[https://relishapp.com/rspec Rspec Documentation]