Expertiza_Wiki - User contributions [en]

CSC/ECE 517 Fall 2015 E1579 Instructor account creation over the web

2015-11-14T03:44:59Z

Rravill: /* Files to be changed */

== '''Introduction''' ==

Introduction to Expertiza:

Expertiza is a project developed using Ruby on Rails. It provides features like peer review, team assignments and submission of projects. This can be achieved by submitting code base, URL of hosted code on remote server and Wiki submissions. It is an open source application and the code can be cloned from GitHub. This application provides an efficient way to manage assignments, grades and reviews. This makes the process easier and faster when the class strength is large.

== '''Purpose''' ==

The purpose of this project is to allow new users to access the system and experiment with all the features of Expertiza and make a “Demo like” feel for the new user where the user can experiment with it. This project adds a new feature of Instructor Creation over the web which is completely different from the previous way the user and instructor accounts were created by existing super administrators, instructors or TAs. Code will be restructured to convey readability, handle exceptions.

== '''Scope''' ==

The scope of this project will involve adding a new View/Page that would input all the new user(Instructor) Details which would be a signup page.The signup page will be designed in a way which would have security feature as Captchas embedded into it. There would be another new View/Page created that would act as the landing page for the newly created Demo_instructor which would contain specific instructions/ Video on how to add assignments, add students to the assignments. Also an email is sent soon after a successful creation of such user. The project also deals with providing limited access to all the features, which could be extended manually by a super admin.The code will also be tested well to ensure the robustness of newly added functionality without compromising the existing working functionalities.

=='''Implementation'''==

==== What needs to be done ====

*Allow people to request instructor accounts over the web.
**Add a Link in Main Screen “Instructor Account request”.
**Create a New Page where the User Fills the details wrt to a new Instructor Privileged access.
**Include Captcha Functionality and other necessary features for a secure Sign Up.

*Upon Successful Creation of Instructor Account.
**Redirect the New Instructor back to the Login Page.
**Send an email to the super Admin notifying him of a new Instructor that has been created over the web

*Upon Successful Login of the New Instructor
**Redirect the User to a New Landing Page/Instruction Page which gives information on how to create an assignments and register students for it and other basic information needed. Basically a Placeholder page that can be used for providing information.
**Provide a Button that would redirect him to the main Expertiza page.
**Make sure that he does not see any Public entities( assignments, Courses) created by any other TA's, Admins or Super Admins.
**Should have a general access to Expertiza and should be able to perform basic actions like adding a course, adding an assignment and assigning students for the created assignments.

==== Files to be changed ====

'''A role named Demo-Instructor is added to the added to the role.rb model with the following code:'''

def self.demo_instructor
@@instructor_role ||= find_by_name 'Demo-Instructor'
end

def demo_instructor?
name['Demo-Instructor']
end

Various controller and model files containing action_allowed? should be updated as

def action_allowed?
['Instructor', 'Teaching Assistant', 'Administrator', 'Super-Administrator', 'Student', 'Demo-Instructor'].include? current_role_name
end

roles table will be updated will be updated by the super-administrator from the new.html.erb form associated with the new action of roles_controller
 

'''For the creation of Demo Instructor experimenting with the features of expertiza
'''
 

In the controller admin_controller.rb, the new actions to be added and their purpose is explained below.

Action added: new_demo_instructor 
Purpose: Linked to the Signup form for creating an instructor to allow the experimenting with expertiza features

Action added: create_demo_instructor 
Purpose: the save operation for the instructor created into the database

Action added: list_demo_instructors 
Purpose: To list them

Action added : remove_demo_instructor 
Purpose: For the super administrator to remove the instructor

The corresponding views for the new_demo_instructor, list_demo_instructors, remove_demo_instructor are added manually.
 

'''Upon Demo Instructor Login into the account created
'''
 
In the tree_display_controller.rb, goto_instructions action is added and instructions.html.erb view is created for this action. instructions.html.erb contains the instructions required for the creation of courses, assignments, adding participants to assignments, etc.

== '''Requirements''' ==

The main objective for the project is to add the new signup functionality for the new User and also to clarify and improve code quality. Although specific implementation details will change through this process, the functionality of the system will remain intact. The overall requirements to the system will therefore not change. We need to make sure that the new demo instructor will not be able to see all the public entities of other instructors, TA's. need to implement and change all the necessary files to make sure unnecessary items are not showcased to the demo instructor.

== '''Mock Ups ''' ==

The Expertiza Login page with the Instructor Account Request Link.

[[File: Homepage.PNG]]

The PlaceHolder page will have few instructions and a Simple Video Tutorial.

[[File: Placehlder.PNG]]

The home page for demo instructor excluding public entities.

[[File: Instructor_default_page_(1).PNG]]

== '''Use Cases''' ==

'''1.Sign-up as new Instructor''': New users can signup to view all features(except the public entities).

'''2.View instructions page''': New instructor can view an instructions page for a walk through of the features.

'''3.Super-admin gives access:''' Super-admin gives access to all public entities for the newly created instructor.

'''4.New instructor-private items''' The demo instructor can access all the private items.

== ''' References ''' ==
[https://expertiza.ncsu.edu/ Expertiza home page] 
[http://research.csc.ncsu.edu/efg/expertiza/papers Papers on Expertiza]

CSC/ECE 517 Fall 2015 E1579 Instructor account creation over the web

2015-11-14T03:38:18Z

Rravill: /* Files to be changed */

== '''Introduction''' ==

Introduction to Expertiza:

Expertiza is a project developed using Ruby on Rails. It provides features like peer review, team assignments and submission of projects. This can be achieved by submitting code base, URL of hosted code on remote server and Wiki submissions. It is an open source application and the code can be cloned from GitHub. This application provides an efficient way to manage assignments, grades and reviews. This makes the process easier and faster when the class strength is large.

== '''Purpose''' ==

The purpose of this project is to allow new users to access the system and experiment with all the features of Expertiza and make a “Demo like” feel for the new user where the user can experiment with it. This project adds a new feature of Instructor Creation over the web which is completely different from the previous way the user and instructor accounts were created by existing super administrators, instructors or TAs. Code will be restructured to convey readability, handle exceptions.

== '''Scope''' ==

The scope of this project will involve adding a new View/Page that would input all the new user(Instructor) Details which would be a signup page.The signup page will be designed in a way which would have security feature as Captchas embedded into it. There would be another new View/Page created that would act as the landing page for the newly created Demo_instructor which would contain specific instructions/ Video on how to add assignments, add students to the assignments. Also an email is sent soon after a successful creation of such user. The project also deals with providing limited access to all the features, which could be extended manually by a super admin.The code will also be tested well to ensure the robustness of newly added functionality without compromising the existing working functionalities.

=='''Implementation'''==

==== What needs to be done ====

*Allow people to request instructor accounts over the web.
**Add a Link in Main Screen “Instructor Account request”.
**Create a New Page where the User Fills the details wrt to a new Instructor Privileged access.
**Include Captcha Functionality and other necessary features for a secure Sign Up.

*Upon Successful Creation of Instructor Account.
**Redirect the New Instructor back to the Login Page.
**Send an email to the super Admin notifying him of a new Instructor that has been created over the web

*Upon Successful Login of the New Instructor
**Redirect the User to a New Landing Page/Instruction Page which gives information on how to create an assignments and register students for it and other basic information needed. Basically a Placeholder page that can be used for providing information.
**Provide a Button that would redirect him to the main Expertiza page.
**Make sure that he does not see any Public entities( assignments, Courses) created by any other TA's, Admins or Super Admins.
**Should have a general access to Expertiza and should be able to perform basic actions like adding a course, adding an assignment and assigning students for the created assignments.

==== Files to be changed ====

'''A role named Demo-Instructor is added to the added to the role.rb model with the following code:'''

def self.demo_instructor
@@instructor_role ||= find_by_name 'Demo-Instructor'
end

def demo_instructor?
name['Demo-Instructor']
end

Various controller and model files containing action_allowed? should be updated as

def action_allowed?
['Instructor', 'Teaching Assistant', 'Administrator', 'Super-Administrator', 'Student', 'Demo-Instructor'].include? current_role_name
end

roles table will be updated will be updated by the super-administrator from the new.html.erb form associated with the new action of roles_controller

'''For the creation of Demo Instructor experimenting with the features of expertiza
'''
In the controller admin_controller.rb, the new methods to be added and their purpose is explained below.

Method: new_demo_instructor 
Purpose: Linked to the Signup form for creating an instructor to allow the experimenting with expertiza features

Method: create_demo_instructor 
Purpose: the save operation for the instructor created into the database

Method: list_demo_instructors 
Purpose: To list them

Method : remove_demo_instructor 
Purpose: For the super administrator to remove the instructor
 
The corresponding views for the new_demo_instructor, list_demo_instructors, remove_demo_instructor are added manually.
 
'''Upon Demo Instructor Login into the account created'''

In the tree_display_controller.rb, goto_instructions action is added and instructions.html.erb view is created for this action. instructions.html.erb contains the instructions required for the creation of courses, assignments, adding participants to assignments, etc.

== '''Requirements''' ==

The main objective for the project is to add the new signup functionality for the new User and also to clarify and improve code quality. Although specific implementation details will change through this process, the functionality of the system will remain intact. The overall requirements to the system will therefore not change. We need to make sure that the new demo instructor will not be able to see all the public entities of other instructors, TA's. need to implement and change all the necessary files to make sure unnecessary items are not showcased to the demo instructor.

== '''Mock Ups ''' ==

The Expertiza Login page with the Instructor Account Request Link.

[[File: Homepage.PNG]]

The PlaceHolder page will have few instructions and a Simple Video Tutorial.

[[File: Placehlder.PNG]]

The home page for demo instructor excluding public entities.

[[File: Instructor_default_page_(1).PNG]]

== '''Use Cases''' ==

'''1.Sign-up as new Instructor''': New users can signup to view all features(except the public entities).

'''2.View instructions page''': New instructor can view an instructions page for a walk through of the features.

'''3.Super-admin gives access:''' Super-admin gives access to all public entities for the newly created instructor.

'''4.New instructor-private items''' The demo instructor can access all the private items.

== ''' References ''' ==
[https://expertiza.ncsu.edu/ Expertiza home page] 
[http://research.csc.ncsu.edu/efg/expertiza/papers Papers on Expertiza]

CSC/ECE 517 Fall 2015 E1579 Instructor account creation over the web

2015-11-14T03:37:50Z

Rravill: /* Files to be changed */

== '''Introduction''' ==

Introduction to Expertiza:

Expertiza is a project developed using Ruby on Rails. It provides features like peer review, team assignments and submission of projects. This can be achieved by submitting code base, URL of hosted code on remote server and Wiki submissions. It is an open source application and the code can be cloned from GitHub. This application provides an efficient way to manage assignments, grades and reviews. This makes the process easier and faster when the class strength is large.

== '''Purpose''' ==

The purpose of this project is to allow new users to access the system and experiment with all the features of Expertiza and make a “Demo like” feel for the new user where the user can experiment with it. This project adds a new feature of Instructor Creation over the web which is completely different from the previous way the user and instructor accounts were created by existing super administrators, instructors or TAs. Code will be restructured to convey readability, handle exceptions.

== '''Scope''' ==

The scope of this project will involve adding a new View/Page that would input all the new user(Instructor) Details which would be a signup page.The signup page will be designed in a way which would have security feature as Captchas embedded into it. There would be another new View/Page created that would act as the landing page for the newly created Demo_instructor which would contain specific instructions/ Video on how to add assignments, add students to the assignments. Also an email is sent soon after a successful creation of such user. The project also deals with providing limited access to all the features, which could be extended manually by a super admin.The code will also be tested well to ensure the robustness of newly added functionality without compromising the existing working functionalities.

=='''Implementation'''==

==== What needs to be done ====

*Allow people to request instructor accounts over the web.
**Add a Link in Main Screen “Instructor Account request”.
**Create a New Page where the User Fills the details wrt to a new Instructor Privileged access.
**Include Captcha Functionality and other necessary features for a secure Sign Up.

*Upon Successful Creation of Instructor Account.
**Redirect the New Instructor back to the Login Page.
**Send an email to the super Admin notifying him of a new Instructor that has been created over the web

*Upon Successful Login of the New Instructor
**Redirect the User to a New Landing Page/Instruction Page which gives information on how to create an assignments and register students for it and other basic information needed. Basically a Placeholder page that can be used for providing information.
**Provide a Button that would redirect him to the main Expertiza page.
**Make sure that he does not see any Public entities( assignments, Courses) created by any other TA's, Admins or Super Admins.
**Should have a general access to Expertiza and should be able to perform basic actions like adding a course, adding an assignment and assigning students for the created assignments.

==== Files to be changed ====

'''A role named Demo-Instructor is added to the added to the role.rb model with the following code:'''

def self.demo_instructor
@@instructor_role ||= find_by_name 'Demo-Instructor'
end

def demo_instructor?
name['Demo-Instructor']
end

Various controller and model files containing action_allowed? should be updated as

def action_allowed?
['Instructor', 'Teaching Assistant', 'Administrator', 'Super-Administrator', 'Student', 'Demo-Instructor'].include? current_role_name
end

roles table will be updated will be updated by the super-administrator from the new.html.erb form associated with the new action of roles_controller

'''For the creation of Demo Instructor experimenting with the features of expertiza
'''
In the controller admin_controller.rb, the new methods to be added and their purpose is explained below.

Method: new_demo_instructor 
Purpose: Linked to the Signup form for creating an instructor to allow the experimenting with expertiza features

Method: create_demo_instructor 
Purpose: the save operation for the instructor created into the database

Method: list_demo_instructors 
Purpose: To list them

Method : remove_demo_instructor 
Purpose: For the super administrator to remove the instructor

The corresponding views for the new_demo_instructor, list_demo_instructors, remove_demo_instructor are added manually.
 
'''Upon Demo Instructor Login into the account created'''

In the tree_display_controller.rb, goto_instructions action is added and instructions.html.erb view is created for this action. instructions.html.erb contains the instructions required for the creation of courses, assignments, adding participants to assignments, etc.

== '''Requirements''' ==

The main objective for the project is to add the new signup functionality for the new User and also to clarify and improve code quality. Although specific implementation details will change through this process, the functionality of the system will remain intact. The overall requirements to the system will therefore not change. We need to make sure that the new demo instructor will not be able to see all the public entities of other instructors, TA's. need to implement and change all the necessary files to make sure unnecessary items are not showcased to the demo instructor.

== '''Mock Ups ''' ==

The Expertiza Login page with the Instructor Account Request Link.

[[File: Homepage.PNG]]

The PlaceHolder page will have few instructions and a Simple Video Tutorial.

[[File: Placehlder.PNG]]

The home page for demo instructor excluding public entities.

[[File: Instructor_default_page_(1).PNG]]

== '''Use Cases''' ==

'''1.Sign-up as new Instructor''': New users can signup to view all features(except the public entities).

'''2.View instructions page''': New instructor can view an instructions page for a walk through of the features.

'''3.Super-admin gives access:''' Super-admin gives access to all public entities for the newly created instructor.

'''4.New instructor-private items''' The demo instructor can access all the private items.

== ''' References ''' ==
[https://expertiza.ncsu.edu/ Expertiza home page] 
[http://research.csc.ncsu.edu/efg/expertiza/papers Papers on Expertiza]

CSC/ECE 517 Fall 2015 E1579 Instructor account creation over the web

2015-11-14T03:32:49Z

Rravill: /* Files to be changed */

== '''Introduction''' ==

Introduction to Expertiza:

Expertiza is a project developed using Ruby on Rails. It provides features like peer review, team assignments and submission of projects. This can be achieved by submitting code base, URL of hosted code on remote server and Wiki submissions. It is an open source application and the code can be cloned from GitHub. This application provides an efficient way to manage assignments, grades and reviews. This makes the process easier and faster when the class strength is large.

== '''Purpose''' ==

The purpose of this project is to allow new users to access the system and experiment with all the features of Expertiza and make a “Demo like” feel for the new user where the user can experiment with it. This project adds a new feature of Instructor Creation over the web which is completely different from the previous way the user and instructor accounts were created by existing super administrators, instructors or TAs. Code will be restructured to convey readability, handle exceptions.

== '''Scope''' ==

The scope of this project will involve adding a new View/Page that would input all the new user(Instructor) Details which would be a signup page.The signup page will be designed in a way which would have security feature as Captchas embedded into it. There would be another new View/Page created that would act as the landing page for the newly created Demo_instructor which would contain specific instructions/ Video on how to add assignments, add students to the assignments. Also an email is sent soon after a successful creation of such user. The project also deals with providing limited access to all the features, which could be extended manually by a super admin.The code will also be tested well to ensure the robustness of newly added functionality without compromising the existing working functionalities.

=='''Implementation'''==

==== What needs to be done ====

*Allow people to request instructor accounts over the web.
**Add a Link in Main Screen “Instructor Account request”.
**Create a New Page where the User Fills the details wrt to a new Instructor Privileged access.
**Include Captcha Functionality and other necessary features for a secure Sign Up.

*Upon Successful Creation of Instructor Account.
**Redirect the New Instructor back to the Login Page.
**Send an email to the super Admin notifying him of a new Instructor that has been created over the web

*Upon Successful Login of the New Instructor
**Redirect the User to a New Landing Page/Instruction Page which gives information on how to create an assignments and register students for it and other basic information needed. Basically a Placeholder page that can be used for providing information.
**Provide a Button that would redirect him to the main Expertiza page.
**Make sure that he does not see any Public entities( assignments, Courses) created by any other TA's, Admins or Super Admins.
**Should have a general access to Expertiza and should be able to perform basic actions like adding a course, adding an assignment and assigning students for the created assignments.

==== Files to be changed ====

'''A role named Demo-Instructor is added to the added to the role.rb model with the following code:'''

def self.demo_instructor
@@instructor_role ||= find_by_name 'Demo-Instructor'
end

def demo_instructor?
name['Demo-Instructor']
end

Various controller and model files containing action_allowed? should be updated as

def action_allowed?
['Instructor', 'Teaching Assistant', 'Administrator', 'Super-Administrator', 'Student', 'Demo-Instructor'].include? current_role_name
end

roles table will be updated will be updated by the super-administrator from the new.html.erb form associated with the new action of roles_controller

'''For the creation of Demo Instructor experimenting with the features of expertiza
'''
In the controller admin_controller.rb, the new methods to be added and their purpose is explained below.

Method: new_demo_instructor
Purpose: Linked to the Signup form for creating an instructor to allow the experimenting with expertiza features

Method: create_demo_instructor
Purpose: the save operation for the instructor created into the database

Method: list_demo_instructors
Purpose: To list them

Method : remove_demo_instructor
Purpose: For the super administrator to remove the instructor

The corresponding views for the new_demo_instructor, list_demo_instructors, remove_demo_instructor are added manually.

'''Upon Demo Instructor Login into the account created'''

In the tree_display_controller.rb, goto_instructions action is added and instructions.html.erb view is created for this action. instructions.html.erb contains the instructions required for the creation of courses, assignments, adding participants to assignments, etc.

== '''Requirements''' ==

The main objective for the project is to add the new signup functionality for the new User and also to clarify and improve code quality. Although specific implementation details will change through this process, the functionality of the system will remain intact. The overall requirements to the system will therefore not change. We need to make sure that the new demo instructor will not be able to see all the public entities of other instructors, TA's. need to implement and change all the necessary files to make sure unnecessary items are not showcased to the demo instructor.

== '''Mock Ups ''' ==

The Expertiza Login page with the Instructor Account Request Link.

[[File: Homepage.PNG]]

The PlaceHolder page will have few instructions and a Simple Video Tutorial.

[[File: Placehlder.PNG]]

The home page for demo instructor excluding public entities.

[[File: Instructor_default_page_(1).PNG]]

== '''Use Cases''' ==

'''1.Sign-up as new Instructor''': New users can signup to view all features(except the public entities).

'''2.View instructions page''': New instructor can view an instructions page for a walk through of the features.

'''3.Super-admin gives access:''' Super-admin gives access to all public entities for the newly created instructor.

'''4.New instructor-private items''' The demo instructor can access all the private items.

== ''' References ''' ==
[https://expertiza.ncsu.edu/ Expertiza home page] 
[http://research.csc.ncsu.edu/efg/expertiza/papers Papers on Expertiza]

CSC/ECE 517 Fall 2015 E1579 Instructor account creation over the web

2015-11-14T03:32:34Z

Rravill: /* Files to be changed */

== '''Introduction''' ==

Introduction to Expertiza:

Expertiza is a project developed using Ruby on Rails. It provides features like peer review, team assignments and submission of projects. This can be achieved by submitting code base, URL of hosted code on remote server and Wiki submissions. It is an open source application and the code can be cloned from GitHub. This application provides an efficient way to manage assignments, grades and reviews. This makes the process easier and faster when the class strength is large.

== '''Purpose''' ==

The purpose of this project is to allow new users to access the system and experiment with all the features of Expertiza and make a “Demo like” feel for the new user where the user can experiment with it. This project adds a new feature of Instructor Creation over the web which is completely different from the previous way the user and instructor accounts were created by existing super administrators, instructors or TAs. Code will be restructured to convey readability, handle exceptions.

== '''Scope''' ==

The scope of this project will involve adding a new View/Page that would input all the new user(Instructor) Details which would be a signup page.The signup page will be designed in a way which would have security feature as Captchas embedded into it. There would be another new View/Page created that would act as the landing page for the newly created Demo_instructor which would contain specific instructions/ Video on how to add assignments, add students to the assignments. Also an email is sent soon after a successful creation of such user. The project also deals with providing limited access to all the features, which could be extended manually by a super admin.The code will also be tested well to ensure the robustness of newly added functionality without compromising the existing working functionalities.

=='''Implementation'''==

==== What needs to be done ====

*Allow people to request instructor accounts over the web.
**Add a Link in Main Screen “Instructor Account request”.
**Create a New Page where the User Fills the details wrt to a new Instructor Privileged access.
**Include Captcha Functionality and other necessary features for a secure Sign Up.

*Upon Successful Creation of Instructor Account.
**Redirect the New Instructor back to the Login Page.
**Send an email to the super Admin notifying him of a new Instructor that has been created over the web

*Upon Successful Login of the New Instructor
**Redirect the User to a New Landing Page/Instruction Page which gives information on how to create an assignments and register students for it and other basic information needed. Basically a Placeholder page that can be used for providing information.
**Provide a Button that would redirect him to the main Expertiza page.
**Make sure that he does not see any Public entities( assignments, Courses) created by any other TA's, Admins or Super Admins.
**Should have a general access to Expertiza and should be able to perform basic actions like adding a course, adding an assignment and assigning students for the created assignments.

==== Files to be changed ====

'''A role named Demo-Instructor is added to the added to the role.rb model with the following code:'''

def self.demo_instructor
@@instructor_role ||= find_by_name 'Demo-Instructor'
end

def demo_instructor?
name['Demo-Instructor']
end

Various controller and model files containing action_allowed? should be updated as

.
.
def action_allowed?
['Instructor', 'Teaching Assistant', 'Administrator', 'Super-Administrator', 'Student', 'Demo-Instructor'].include? current_role_name
end
.
.

roles table will be updated will be updated by the super-administrator from the new.html.erb form associated with the new action of roles_controller

'''For the creation of Demo Instructor experimenting with the features of expertiza
'''
In the controller admin_controller.rb, the new methods to be added and their purpose is explained below.

Method: new_demo_instructor
Purpose: Linked to the Signup form for creating an instructor to allow the experimenting with expertiza features

Method: create_demo_instructor
Purpose: the save operation for the instructor created into the database

Method: list_demo_instructors
Purpose: To list them

Method : remove_demo_instructor
Purpose: For the super administrator to remove the instructor

The corresponding views for the new_demo_instructor, list_demo_instructors, remove_demo_instructor are added manually.

'''Upon Demo Instructor Login into the account created'''

In the tree_display_controller.rb, goto_instructions action is added and instructions.html.erb view is created for this action. instructions.html.erb contains the instructions required for the creation of courses, assignments, adding participants to assignments, etc.

== '''Requirements''' ==

The main objective for the project is to add the new signup functionality for the new User and also to clarify and improve code quality. Although specific implementation details will change through this process, the functionality of the system will remain intact. The overall requirements to the system will therefore not change. We need to make sure that the new demo instructor will not be able to see all the public entities of other instructors, TA's. need to implement and change all the necessary files to make sure unnecessary items are not showcased to the demo instructor.

== '''Mock Ups ''' ==

The Expertiza Login page with the Instructor Account Request Link.

[[File: Homepage.PNG]]

The PlaceHolder page will have few instructions and a Simple Video Tutorial.

[[File: Placehlder.PNG]]

The home page for demo instructor excluding public entities.

[[File: Instructor_default_page_(1).PNG]]

== '''Use Cases''' ==

'''1.Sign-up as new Instructor''': New users can signup to view all features(except the public entities).

'''2.View instructions page''': New instructor can view an instructions page for a walk through of the features.

'''3.Super-admin gives access:''' Super-admin gives access to all public entities for the newly created instructor.

'''4.New instructor-private items''' The demo instructor can access all the private items.

== ''' References ''' ==
[https://expertiza.ncsu.edu/ Expertiza home page] 
[http://research.csc.ncsu.edu/efg/expertiza/papers Papers on Expertiza]

CSC/ECE 517 Fall 2015 E1579 Instructor account creation over the web

2015-11-14T03:32:12Z

Rravill: /* Files to be changed */

== '''Introduction''' ==

Introduction to Expertiza:

Expertiza is a project developed using Ruby on Rails. It provides features like peer review, team assignments and submission of projects. This can be achieved by submitting code base, URL of hosted code on remote server and Wiki submissions. It is an open source application and the code can be cloned from GitHub. This application provides an efficient way to manage assignments, grades and reviews. This makes the process easier and faster when the class strength is large.

== '''Purpose''' ==

The purpose of this project is to allow new users to access the system and experiment with all the features of Expertiza and make a “Demo like” feel for the new user where the user can experiment with it. This project adds a new feature of Instructor Creation over the web which is completely different from the previous way the user and instructor accounts were created by existing super administrators, instructors or TAs. Code will be restructured to convey readability, handle exceptions.

== '''Scope''' ==

The scope of this project will involve adding a new View/Page that would input all the new user(Instructor) Details which would be a signup page.The signup page will be designed in a way which would have security feature as Captchas embedded into it. There would be another new View/Page created that would act as the landing page for the newly created Demo_instructor which would contain specific instructions/ Video on how to add assignments, add students to the assignments. Also an email is sent soon after a successful creation of such user. The project also deals with providing limited access to all the features, which could be extended manually by a super admin.The code will also be tested well to ensure the robustness of newly added functionality without compromising the existing working functionalities.

=='''Implementation'''==

==== What needs to be done ====

*Allow people to request instructor accounts over the web.
**Add a Link in Main Screen “Instructor Account request”.
**Create a New Page where the User Fills the details wrt to a new Instructor Privileged access.
**Include Captcha Functionality and other necessary features for a secure Sign Up.

*Upon Successful Creation of Instructor Account.
**Redirect the New Instructor back to the Login Page.
**Send an email to the super Admin notifying him of a new Instructor that has been created over the web

*Upon Successful Login of the New Instructor
**Redirect the User to a New Landing Page/Instruction Page which gives information on how to create an assignments and register students for it and other basic information needed. Basically a Placeholder page that can be used for providing information.
**Provide a Button that would redirect him to the main Expertiza page.
**Make sure that he does not see any Public entities( assignments, Courses) created by any other TA's, Admins or Super Admins.
**Should have a general access to Expertiza and should be able to perform basic actions like adding a course, adding an assignment and assigning students for the created assignments.

==== Files to be changed ====

'''A role named Demo-Instructor is added to the added to the role.rb model with the following code:'''

.
.
def self.demo_instructor
@@instructor_role ||= find_by_name 'Demo-Instructor'
end

def demo_instructor?
name['Demo-Instructor']
end
.
.

Various controller and model files containing action_allowed? should be updated as

.
.
def action_allowed?
['Instructor', 'Teaching Assistant', 'Administrator', 'Super-Administrator', 'Student', 'Demo-Instructor'].include? current_role_name
end
.
.

roles table will be updated will be updated by the super-administrator from the new.html.erb form associated with the new action of roles_controller

'''For the creation of Demo Instructor experimenting with the features of expertiza
'''
In the controller admin_controller.rb, the new methods to be added and their purpose is explained below.

Method: new_demo_instructor
Purpose: Linked to the Signup form for creating an instructor to allow the experimenting with expertiza features

Method: create_demo_instructor
Purpose: the save operation for the instructor created into the database

Method: list_demo_instructors
Purpose: To list them

Method : remove_demo_instructor
Purpose: For the super administrator to remove the instructor

The corresponding views for the new_demo_instructor, list_demo_instructors, remove_demo_instructor are added manually.

'''Upon Demo Instructor Login into the account created'''

In the tree_display_controller.rb, goto_instructions action is added and instructions.html.erb view is created for this action. instructions.html.erb contains the instructions required for the creation of courses, assignments, adding participants to assignments, etc.

== '''Requirements''' ==

The main objective for the project is to add the new signup functionality for the new User and also to clarify and improve code quality. Although specific implementation details will change through this process, the functionality of the system will remain intact. The overall requirements to the system will therefore not change. We need to make sure that the new demo instructor will not be able to see all the public entities of other instructors, TA's. need to implement and change all the necessary files to make sure unnecessary items are not showcased to the demo instructor.

== '''Mock Ups ''' ==

The Expertiza Login page with the Instructor Account Request Link.

[[File: Homepage.PNG]]

The PlaceHolder page will have few instructions and a Simple Video Tutorial.

[[File: Placehlder.PNG]]

The home page for demo instructor excluding public entities.

[[File: Instructor_default_page_(1).PNG]]

== '''Use Cases''' ==

'''1.Sign-up as new Instructor''': New users can signup to view all features(except the public entities).

'''2.View instructions page''': New instructor can view an instructions page for a walk through of the features.

'''3.Super-admin gives access:''' Super-admin gives access to all public entities for the newly created instructor.

'''4.New instructor-private items''' The demo instructor can access all the private items.

== ''' References ''' ==
[https://expertiza.ncsu.edu/ Expertiza home page] 
[http://research.csc.ncsu.edu/efg/expertiza/papers Papers on Expertiza]

CSC/ECE 517 Fall 2015 E1579 Instructor account creation over the web

2015-11-12T21:34:53Z

Rravill: /* References */

== '''Introduction''' ==

Introduction to Expertiza:

Expertiza is a project developed using Ruby on Rails. It provides features like peer review, team assignments and submission of projects. This can be achieved by submitting code base, URL of hosted code on remote server and Wiki submissions. It is an open source application and the code can be cloned from GitHub. This application provides an efficient way to manage assignments, grades and reviews. This makes the process easier and faster when the class strength is large.

== '''Purpose''' ==

The purpose of this project is to allow new users to access the system and experiment with all the features of Expertiza and make a “Demo like” feel for the new user where the user can experiment with it. This project adds a new feature of Instructor Creation over the web which is completely different from the previous way the user and instructor accounts were created by existing super administrators, instructors or TAs. Code will be restructured to convey readability, handle exceptions.

== '''Scope''' ==

The scope of this project will involve adding a new View/Page that would input all the new user(Instructor) Details which would be a signup page.The signup page will be designed in a way which would have security feature as Captchas embedded into it. There would be another new View/Page created that would act as the landing page for the newly created Demo_instructor which would contain specific instructions/ Video on how to add assignments, add students to the assignments. Also an email is sent soon after a successful creation of such user. The project also deals with providing limited access to all the features, which could be extended manually by a super admin.The code will also be tested well to ensure the robustness of newly added functionality without compromising the existing working functionalities.

=='''Implementation'''==

==== What needs to be done ====

*Allow people to request instructor accounts over the web.
**Add a Link in Main Screen “Instructor Account request”.
**Create a New Page where the User Fills the details wrt to a new Instructor Privileged access.
**Include Captcha Functionality and other necessary features for a secure Sign Up.

*Upon Successful Creation of Instructor Account.
**Redirect the New Instructor back to the Login Page.
**Send an email to the super Admin notifying him of a new Instructor that has been created over the web

*Upon Successful Login of the New Instructor
**Redirect the User to a New Landing Page/Instruction Page which gives information on how to create an assignments and register students for it and other basic information needed. Basically a Placeholder page that can be used for providing information.
**Provide a Button that would redirect him to the main Expertiza page.
**Make sure that he does not see any Public entities( assignments, Courses) created by any other TA's, Admins or Super Admins.
**Should have a general access to Expertiza and should be able to perform basic actions like adding a course, adding an assignment and assigning students for the created assignments.

==== Files to be changed ====
The following are some of the files that will be changed for the implementation to work.

''Users Controller''

''login.html.erb''

''List Controller''

We will be adding a new attribute Demo_instructor to the Roles Table for implementing the new change.

== '''Requirements''' ==

The main objective for the project is to add the new signup functionality for the new User and also to clarify and improve code quality. Although specific implementation details will change through this process, the functionality of the system will remain intact. The overall requirements to the system will therefore not change. We need to make sure that the new demo instructor will not be able to see all the public entities of other instructors, TA's. need to implement and change all the necessary files to make sure unnecessary items are not showcased to the demo instructor.

== '''Mock Ups ''' ==

The Expertiza Login page with the Instructor Account Request Link.

[[File: Homepage.PNG]]

The PlaceHolder page will have few instructions and a Simple Video Tutorial.

[[File: Placehlder.PNG]]

The home page for demo instructor excluding public entities.

[[File: Instructor_default_page_(1).PNG]]

== '''Use Cases''' ==

'''1.Sign-up as new Instructor''': New users can signup to view all features(except the public entities).

'''2.View instructions page''': New instructor can view an instructions page for a walk through of the features.

'''3.Super-admin gives access:''' Super-admin gives access to all public entities for the newly created instructor.

'''4.New instructor-private items''' The demo instructor can access all the private items.

== ''' References ''' ==
[https://expertiza.ncsu.edu/ Expertiza home page] 
[http://research.csc.ncsu.edu/efg/expertiza/papers Papers on Expertiza]

CSC/ECE 517 Fall 2015 E1579 Instructor account creation over the web

2015-11-12T21:34:42Z

Rravill: /* References */

== '''Introduction''' ==

Introduction to Expertiza:

Expertiza is a project developed using Ruby on Rails. It provides features like peer review, team assignments and submission of projects. This can be achieved by submitting code base, URL of hosted code on remote server and Wiki submissions. It is an open source application and the code can be cloned from GitHub. This application provides an efficient way to manage assignments, grades and reviews. This makes the process easier and faster when the class strength is large.

== '''Purpose''' ==

The purpose of this project is to allow new users to access the system and experiment with all the features of Expertiza and make a “Demo like” feel for the new user where the user can experiment with it. This project adds a new feature of Instructor Creation over the web which is completely different from the previous way the user and instructor accounts were created by existing super administrators, instructors or TAs. Code will be restructured to convey readability, handle exceptions.

== '''Scope''' ==

The scope of this project will involve adding a new View/Page that would input all the new user(Instructor) Details which would be a signup page.The signup page will be designed in a way which would have security feature as Captchas embedded into it. There would be another new View/Page created that would act as the landing page for the newly created Demo_instructor which would contain specific instructions/ Video on how to add assignments, add students to the assignments. Also an email is sent soon after a successful creation of such user. The project also deals with providing limited access to all the features, which could be extended manually by a super admin.The code will also be tested well to ensure the robustness of newly added functionality without compromising the existing working functionalities.

=='''Implementation'''==

==== What needs to be done ====

*Allow people to request instructor accounts over the web.
**Add a Link in Main Screen “Instructor Account request”.
**Create a New Page where the User Fills the details wrt to a new Instructor Privileged access.
**Include Captcha Functionality and other necessary features for a secure Sign Up.

*Upon Successful Creation of Instructor Account.
**Redirect the New Instructor back to the Login Page.
**Send an email to the super Admin notifying him of a new Instructor that has been created over the web

*Upon Successful Login of the New Instructor
**Redirect the User to a New Landing Page/Instruction Page which gives information on how to create an assignments and register students for it and other basic information needed. Basically a Placeholder page that can be used for providing information.
**Provide a Button that would redirect him to the main Expertiza page.
**Make sure that he does not see any Public entities( assignments, Courses) created by any other TA's, Admins or Super Admins.
**Should have a general access to Expertiza and should be able to perform basic actions like adding a course, adding an assignment and assigning students for the created assignments.

==== Files to be changed ====
The following are some of the files that will be changed for the implementation to work.

''Users Controller''

''login.html.erb''

''List Controller''

We will be adding a new attribute Demo_instructor to the Roles Table for implementing the new change.

== '''Requirements''' ==

The main objective for the project is to add the new signup functionality for the new User and also to clarify and improve code quality. Although specific implementation details will change through this process, the functionality of the system will remain intact. The overall requirements to the system will therefore not change. We need to make sure that the new demo instructor will not be able to see all the public entities of other instructors, TA's. need to implement and change all the necessary files to make sure unnecessary items are not showcased to the demo instructor.

== '''Mock Ups ''' ==

The Expertiza Login page with the Instructor Account Request Link.

[[File: Homepage.PNG]]

The PlaceHolder page will have few instructions and a Simple Video Tutorial.

[[File: Placehlder.PNG]]

The home page for demo instructor excluding public entities.

[[File: Instructor_default_page_(1).PNG]]

== '''Use Cases''' ==

'''1.Sign-up as new Instructor''': New users can signup to view all features(except the public entities).

'''2.View instructions page''': New instructor can view an instructions page for a walk through of the features.

'''3.Super-admin gives access:''' Super-admin gives access to all public entities for the newly created instructor.

'''4.New instructor-private items''' The demo instructor can access all the private items.

== ''' References ''' ==
[https://expertiza.ncsu.edu/ Expertiza home page] 
[[http://research.csc.ncsu.edu/efg/expertiza/papers Papers on Expertiza]

CSC/ECE 517 Fall 2015 E1579 Instructor account creation over the web

2015-11-12T21:33:58Z

Rravill: /* References */

== '''Introduction''' ==

Introduction to Expertiza:

Expertiza is a project developed using Ruby on Rails. It provides features like peer review, team assignments and submission of projects. This can be achieved by submitting code base, URL of hosted code on remote server and Wiki submissions. It is an open source application and the code can be cloned from GitHub. This application provides an efficient way to manage assignments, grades and reviews. This makes the process easier and faster when the class strength is large.

== '''Purpose''' ==

The purpose of this project is to allow new users to access the system and experiment with all the features of Expertiza and make a “Demo like” feel for the new user where the user can experiment with it. This project adds a new feature of Instructor Creation over the web which is completely different from the previous way the user and instructor accounts were created by existing super administrators, instructors or TAs. Code will be restructured to convey readability, handle exceptions.

== '''Scope''' ==

The scope of this project will involve adding a new View/Page that would input all the new user(Instructor) Details which would be a signup page.The signup page will be designed in a way which would have security feature as Captchas embedded into it. There would be another new View/Page created that would act as the landing page for the newly created Demo_instructor which would contain specific instructions/ Video on how to add assignments, add students to the assignments. Also an email is sent soon after a successful creation of such user. The project also deals with providing limited access to all the features, which could be extended manually by a super admin.The code will also be tested well to ensure the robustness of newly added functionality without compromising the existing working functionalities.

=='''Implementation'''==

==== What needs to be done ====

*Allow people to request instructor accounts over the web.
**Add a Link in Main Screen “Instructor Account request”.
**Create a New Page where the User Fills the details wrt to a new Instructor Privileged access.
**Include Captcha Functionality and other necessary features for a secure Sign Up.

*Upon Successful Creation of Instructor Account.
**Redirect the New Instructor back to the Login Page.
**Send an email to the super Admin notifying him of a new Instructor that has been created over the web

*Upon Successful Login of the New Instructor
**Redirect the User to a New Landing Page/Instruction Page which gives information on how to create an assignments and register students for it and other basic information needed. Basically a Placeholder page that can be used for providing information.
**Provide a Button that would redirect him to the main Expertiza page.
**Make sure that he does not see any Public entities( assignments, Courses) created by any other TA's, Admins or Super Admins.
**Should have a general access to Expertiza and should be able to perform basic actions like adding a course, adding an assignment and assigning students for the created assignments.

==== Files to be changed ====
The following are some of the files that will be changed for the implementation to work.

''Users Controller''

''login.html.erb''

''List Controller''

We will be adding a new attribute Demo_instructor to the Roles Table for implementing the new change.

== '''Requirements''' ==

The main objective for the project is to add the new signup functionality for the new User and also to clarify and improve code quality. Although specific implementation details will change through this process, the functionality of the system will remain intact. The overall requirements to the system will therefore not change. We need to make sure that the new demo instructor will not be able to see all the public entities of other instructors, TA's. need to implement and change all the necessary files to make sure unnecessary items are not showcased to the demo instructor.

== '''Mock Ups ''' ==

The Expertiza Login page with the Instructor Account Request Link.

[[File: Homepage.PNG]]

The PlaceHolder page will have few instructions and a Simple Video Tutorial.

[[File: Placehlder.PNG]]

The home page for demo instructor excluding public entities.

[[File: Instructor_default_page_(1).PNG]]

== '''Use Cases''' ==

'''1.Sign-up as new Instructor''': New users can signup to view all features(except the public entities).

'''2.View instructions page''': New instructor can view an instructions page for a walk through of the features.

'''3.Super-admin gives access:''' Super-admin gives access to all public entities for the newly created instructor.

'''4.New instructor-private items''' The demo instructor can access all the private items.

== ''' References ''' ==
[https://expertiza.ncsu.edu/]
[[http://research.csc.ncsu.edu/efg/expertiza/papers]

CSC/ECE 517 Fall 2015/oss E1554 AAR

2015-11-01T05:10:51Z

Rravill:

'''E1554 Refactoring TeamsController.rb'''
This is description of the CSC/ECE 517 Fall2015 OSS project(E1554),we refactored teams_controller.rb,students_team_controller.rb,sign_up_topic.rb we extracted the duplicate code into a single function call,and we made sure when team is deleted its associated records are deleted first then the team gets deleted.We have tested using [http://rspec.info/ Rspec]

== Expertiza ==

Expertiza <ref>[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza].''expertiza project''</ref> is a project built with [https://en.wikipedia.org/wiki/Ruby_on_Rails Ruby on Rails]<ref>[http://rubyonrails.org/ RubyonRails]</ref>.It is mainly used by an instructor to provide a peer reviewing systems among the students it also supports team projects submissions wikis etc.

== What it Does ==
This class handle the basic creation and modification of student teams. There are also some complicated actions. E.g., if a team get destroyed (this may be caused by instructor force this team to be destroyed, the students all leave the team), the topic held by this team should be transferred to next team which is on the waiting list, if there is any.
These are the scenarios where topic transferring may happen:
* when instructor destroys a team
* when the last person leave this team
* when this team wants to switch topic
* when instructor wants to increase the available slots for a topic.

== Problem Statement ==
The same code for handling topic transferring used 3 times at the following places:

[scenario 1] teams_controller line 95 (if next_wait_listed_team),
[scenario 2] student_teams_controller line 139 (if first_waitlisted_team) and
[scenario 4] sign_up_topic line 117 (if next_wait_listed_team).
Scenario 3’s code is not copied, and one can find the code at line 92 in sign_up_topic.rb.

== What Needs to be Done ==
*Make topic_transfering a function call, and make sure all those 4 scenario works.
*Write tests for all those 4 scenarios.
*Record a video for those 4 scenarios, submit it to YouTube and submit the YouTube link to Expertiza.
*Delete method in teams_controller.rb is complicated, “@team.destroy” should be called latest after all the records related to this team can be deleted.
*write tests for delete method.

== Implementing the repeated code as function call ==

Before: Code repeated in teams_controller.rb, student_teams_controller.rb, SignUpTopic.rb

if next_wait_listed_team
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end

After: The repeated code implemented as a function in SignUpTopic.rb

def self.assign_to_first_waiting_team(next_wait_listed_team)
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end

==Refactoring the Order of deleting a team and its attributes==
Problem: The team is deleted even before its attributes are destroyed in teams_controller.rb
Before:

@team.destroy if @team
@signUps = SignedUpTeam.where(team_id: params[:id])
@teams_users = TeamsUser.where(team_id: params[:id])
@teams_users.destroy_all if @teams_users
if @signUps.size == 1 and @signUps.first.is_waitlisted == false #this team hold a topic

After:

@team = Team.find(params[:id])
course = Object.const_get(session[:team_type]).find(@team.parent_id)
@signUps = SignedUpTeam.where(team_id: @team.id)
@teams_users = TeamsUser.where(team_id: @team.id)
if @signUps.size == 1 and @signUps.first.is_waitlisted == false

Rspec Tests:

Rspec tests can be performed by using the following commands from expertiza directory in the terminal:

bundle exec rake db:reset RAILS_ENV=test
rspec spec/controllers/teams_controller_spec.rb

== References ==

<references />

CSC/ECE 517 Fall 2015/oss E1554 AAR

2015-11-01T05:09:35Z

Rravill:

'''E1554 Refactoring TeamsController.rb'''
This is description of the CSC/ECE 517 Fall2015 OSS project(E1554),we refactored teams_controller.rb,students_team_controller.rb,sign_up_topic.rb we extracted the duplicate code into a single function call,and we made sure when team is deleted its associated records are deleted first then the team gets deleted.We have tested using [http://rspec.info/ Rspec]

== Expertiza ==

Expertiza <ref>[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza].''expertiza project''</ref> is a project built with [https://en.wikipedia.org/wiki/Ruby_on_Rails Ruby on Rails]<ref>[http://rubyonrails.org/ RubyonRails]</ref>.It is mainly used by an instructor to provide a peer reviewing systems among the students it also supports team projects submissions wikis etc.

== What it Does ==
This class handle the basic creation and modification of student teams. There are also some complicated actions. E.g., if a team get destroyed (this may be caused by instructor force this team to be destroyed, the students all leave the team), the topic held by this team should be transferred to next team which is on the waiting list, if there is any.
These are the scenarios where topic transferring may happen:
* when instructor destroys a team
* when the last person leave this team
* when this team wants to switch topic
* when instructor wants to increase the available slots for a topic.

== Problem Statement ==
The same code for handling topic transferring used 3 times at the following places:

[scenario 1] teams_controller line 95 (if next_wait_listed_team),
[scenario 2] student_teams_controller line 139 (if first_waitlisted_team) and
[scenario 4] sign_up_topic line 117 (if next_wait_listed_team).
Scenario 3’s code is not copied, and one can find the code at line 92 in sign_up_topic.rb.

== What Needs to be Done ==
*Make topic_transfering a function call, and make sure all those 4 scenario works.
*Write tests for all those 4 scenarios.
*Record a video for those 4 scenarios, submit it to YouTube and submit the YouTube link to Expertiza.
*Delete method in teams_controller.rb is complicated, “@team.destroy” should be called latest after all the records related to this team can be deleted.
*write tests for delete method.

== Implementing the repeated code as function call ==

Before: Code repeated in teams_controller.rb, student_teams_controller.rb, SignUpTopic.rb
..
if next_wait_listed_team
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
..

After: The repeated code implemented as a function in SignUpTopic.rb

..
def self.assign_to_first_waiting_team(next_wait_listed_team)
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
..

==Refactoring the Order of deleting a team and its attributes==
Problem: The team is deleted even before its attributes are destroyed in teams_controller.rb
Before:
..
@team.destroy if @team
@signUps = SignedUpTeam.where(team_id: params[:id])
@teams_users = TeamsUser.where(team_id: params[:id])
@teams_users.destroy_all if @teams_users
if @signUps.size == 1 and @signUps.first.is_waitlisted == false #this team hold a topic
..

After:

..
@team = Team.find(params[:id])
course = Object.const_get(session[:team_type]).find(@team.parent_id)
@signUps = SignedUpTeam.where(team_id: @team.id)
@teams_users = TeamsUser.where(team_id: @team.id)
if @signUps.size == 1 and @signUps.first.is_waitlisted == false
..

Rspec Tests:

Rspec tests can be performed by using the following commands from expertiza directory in the terminal:

.
.
bundle exec rake db:reset RAILS_ENV=test
rspec spec/controllers/teams_controller_spec.rb
..
== References ==

<references />

CSC/ECE 517 Fall 2015/oss E1554 AAR

2015-11-01T05:08:22Z

Rravill:

'''E1554 Refactoring TeamsController.rb'''
This is description of the CSC/ECE 517 Fall2015 OSS project(E1554),we refactored teams_controller.rb,students_team_controller.rb,sign_up_topic.rb we extracted the duplicate code into a single function call,and we made sure when team is deleted its associated records are deleted first then the team gets deleted.We have tested using [http://rspec.info/ Rspec]

== Expertiza ==

Expertiza <ref>[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza].''expertiza project''</ref> is a project built with [https://en.wikipedia.org/wiki/Ruby_on_Rails Ruby on Rails]<ref>[http://rubyonrails.org/ RubyonRails]</ref>.It is mainly used by an instructor to provide a peer reviewing systems among the students it also supports team projects submissions wikis etc.

== What it Does ==
This class handle the basic creation and modification of student teams. There are also some complicated actions. E.g., if a team get destroyed (this may be caused by instructor force this team to be destroyed, the students all leave the team), the topic held by this team should be transferred to next team which is on the waiting list, if there is any.
These are the scenarios where topic transferring may happen:
* when instructor destroys a team
* when the last person leave this team
* when this team wants to switch topic
* when instructor wants to increase the available slots for a topic.

== Problem Statement ==
The same code for handling topic transferring used 3 times at the following places:

[scenario 1] teams_controller line 95 (if next_wait_listed_team),
[scenario 2] student_teams_controller line 139 (if first_waitlisted_team) and
[scenario 4] sign_up_topic line 117 (if next_wait_listed_team).
Scenario 3’s code is not copied, and one can find the code at line 92 in sign_up_topic.rb.

== What Needs to be Done ==
*Make topic_transfering a function call, and make sure all those 4 scenario works.
*Write tests for all those 4 scenarios.
*Record a video for those 4 scenarios, submit it to YouTube and submit the YouTube link to Expertiza.
*Delete method in teams_controller.rb is complicated, “@team.destroy” should be called latest after all the records related to this team can be deleted.
*write tests for delete method.

== Implementing the repeated code as function call ==

Before: Code repeated in teams_controller.rb, student_teams_controller.rb, SignUpTopic.rb
.
.
if next_wait_listed_team
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

After: The repeated code implemented as a function in SignUpTopic.rb

.
.
def self.assign_to_first_waiting_team(next_wait_listed_team)
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

==Refactoring the Order of deleting a team and its attributes==
Problem: The team is deleted even before its attributes are destroyed in teams_controller.rb
Before:
.
.
@team.destroy if @team
@signUps = SignedUpTeam.where(team_id: params[:id])
@teams_users = TeamsUser.where(team_id: params[:id])
@teams_users.destroy_all if @teams_users
if @signUps.size == 1 and @signUps.first.is_waitlisted == false #this team hold a topic
.
.

After:

.
.
@team = Team.find(params[:id])
course = Object.const_get(session[:team_type]).find(@team.parent_id)
@signUps = SignedUpTeam.where(team_id: @team.id)
@teams_users = TeamsUser.where(team_id: @team.id)
if @signUps.size == 1 and @signUps.first.is_waitlisted == false
.
.

Rspec Tests:

Rspec tests can be performed by using the following commands from expertiza directory in the terminal:

.
.
bundle exec rake db:reset RAILS_ENV=test
rspec spec/controllers/teams_controller_spec.rb
..
== References ==

<references />

CSC/ECE 517 Fall 2015/oss E1554 AAR

2015-11-01T00:53:53Z

Rravill: /* Refactoring the Order of deleting a team and its attributes */

'''E1554 Refactoring TeamsController.rb'''
This is description of the CSC/ECE 517 Fall2015 OSS project(E1554),we refactored teams_controller.rb,students_team_controller.rb,sign_up_topic.rb we extracted the duplicate code into a single function call,and we made sure when team is deleted its associated records are deleted first then the team gets deleted.We have tested using [http://rspec.info/ Rspec]

== Expertiza ==

Expertiza <ref>[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza].''expertiza project''</ref> is a project built with [https://en.wikipedia.org/wiki/Ruby_on_Rails Ruby on Rails]<ref>[http://rubyonrails.org/ RubyonRails]</ref>.It is mainly used by an instructor to provide a peer reviewing systems among the students it also supports team projects submissions wikis etc.

== What it Does ==
This class handle the basic creation and modification of student teams. There are also some complicated actions. E.g., if a team get destroyed (this may be caused by instructor force this team to be destroyed, the students all leave the team), the topic held by this team should be transferred to next team which is on the waiting list, if there is any.
These are the scenarios where topic transferring may happen:
* when instructor destroys a team
* when the last person leave this team
* when this team wants to switch topic
* when instructor wants to increase the available slots for a topic.

== Problem Statement ==
The same code for handling topic transferring used 3 times at the following places:

[scenario 1] teams_controller line 95 (if next_wait_listed_team),
[scenario 2] student_teams_controller line 139 (if first_waitlisted_team) and
[scenario 4] sign_up_topic line 117 (if next_wait_listed_team).
Scenario 3’s code is not copied, and one can find the code at line 92 in sign_up_topic.rb.

== What Needs to be Done ==
*Make topic_transfering a function call, and make sure all those 4 scenario works.
*Write tests for all those 4 scenarios.
*Record a video for those 4 scenarios, submit it to YouTube and submit the YouTube link to Expertiza.
*Delete method in teams_controller.rb is complicated, “@team.destroy” should be called latest after all the records related to this team can be deleted.
*write tests for delete method.

== Implementing the repeated code as function call ==

Before: Code repeated in teams_controller.rb, student_teams_controller.rb, SignUpTopic.rb
.
.
if next_wait_listed_team
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

After: The repeated code implemented as a function in SignUpTopic.rb

.
.
def self.assign_to_first_waiting_team(next_wait_listed_team)
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

==Refactoring the Order of deleting a team and its attributes==
Problem: The team is deleted even before its attributes are destroyed in teams_controller.rb
Before:
.
.
@team.destroy if @team
@signUps = SignedUpTeam.where(team_id: params[:id])
@teams_users = TeamsUser.where(team_id: params[:id])
@teams_users.destroy_all if @teams_users
if @signUps.size == 1 and @signUps.first.is_waitlisted == false #this team hold a topic
.
.

After:

.
.
@team = Team.find(params[:id])
course = Object.const_get(session[:team_type]).find(@team.parent_id)
@signUps = SignedUpTeam.where(team_id: @team.id)
@teams_users = TeamsUser.where(team_id: @team.id)
if @signUps.size == 1 and @signUps.first.is_waitlisted == false
.
.

== References ==

<references />

CSC/ECE 517 Fall 2015/oss E1554 AAR

2015-11-01T00:53:21Z

Rravill: /* Refactoring the Order of deleting a team and its attributes */

'''E1554 Refactoring TeamsController.rb'''
This is description of the CSC/ECE 517 Fall2015 OSS project(E1554),we refactored teams_controller.rb,students_team_controller.rb,sign_up_topic.rb we extracted the duplicate code into a single function call,and we made sure when team is deleted its associated records are deleted first then the team gets deleted.We have tested using [http://rspec.info/ Rspec]

== Expertiza ==

Expertiza <ref>[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza].''expertiza project''</ref> is a project built with [https://en.wikipedia.org/wiki/Ruby_on_Rails Ruby on Rails]<ref>[http://rubyonrails.org/ RubyonRails]</ref>.It is mainly used by an instructor to provide a peer reviewing systems among the students it also supports team projects submissions wikis etc.

== What it Does ==
This class handle the basic creation and modification of student teams. There are also some complicated actions. E.g., if a team get destroyed (this may be caused by instructor force this team to be destroyed, the students all leave the team), the topic held by this team should be transferred to next team which is on the waiting list, if there is any.
These are the scenarios where topic transferring may happen:
* when instructor destroys a team
* when the last person leave this team
* when this team wants to switch topic
* when instructor wants to increase the available slots for a topic.

== Problem Statement ==
The same code for handling topic transferring used 3 times at the following places:

[scenario 1] teams_controller line 95 (if next_wait_listed_team),
[scenario 2] student_teams_controller line 139 (if first_waitlisted_team) and
[scenario 4] sign_up_topic line 117 (if next_wait_listed_team).
Scenario 3’s code is not copied, and one can find the code at line 92 in sign_up_topic.rb.

== What Needs to be Done ==
*Make topic_transfering a function call, and make sure all those 4 scenario works.
*Write tests for all those 4 scenarios.
*Record a video for those 4 scenarios, submit it to YouTube and submit the YouTube link to Expertiza.
*Delete method in teams_controller.rb is complicated, “@team.destroy” should be called latest after all the records related to this team can be deleted.
*write tests for delete method.

== Implementing the repeated code as function call ==

Before: Code repeated in teams_controller.rb, student_teams_controller.rb, SignUpTopic.rb
.
.
if next_wait_listed_team
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

After: The repeated code implemented as a function in SignUpTopic.rb

.
.
def self.assign_to_first_waiting_team(next_wait_listed_team)
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

==Refactoring the Order of deleting a team and its attributes==
Problem: The team is deleted even before its attributes are destroyed in teams_controller.rb
Before:
.
.
@team.destroy if @team
@signUps = SignedUpTeam.where(team_id: params[:id])
@teams_users = TeamsUser.where(team_id: params[:id])
@teams_users.destroy_all if @teams_users
if @signUps.size == 1 and @signUps.first.is_waitlisted == false #this team hold a topic
.
.

After:

.
.
@team = Team.find(params[:id])
course = Object.const_get(session[:team_type]).find(@team.parent_id)
@signUps = SignedUpTeam.where(team_id: @team.id)
@teams_users = TeamsUser.where(team_id: @team.id)
if @signUps.size == 1 and @signUps.first.is_waitlisted == false
.
.

== References ==

<references />

CSC/ECE 517 Fall 2015/oss E1554 AAR

2015-11-01T00:51:33Z

Rravill: /* Refactoring the Order of deleting a team and its attributes */

'''E1554 Refactoring TeamsController.rb'''
This is description of the CSC/ECE 517 Fall2015 OSS project(E1554),we refactored teams_controller.rb,students_team_controller.rb,sign_up_topic.rb we extracted the duplicate code into a single function call,and we made sure when team is deleted its associated records are deleted first then the team gets deleted.We have tested using [http://rspec.info/ Rspec]

== Expertiza ==

Expertiza <ref>[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza].''expertiza project''</ref> is a project built with [https://en.wikipedia.org/wiki/Ruby_on_Rails Ruby on Rails]<ref>[http://rubyonrails.org/ RubyonRails]</ref>.It is mainly used by an instructor to provide a peer reviewing systems among the students it also supports team projects submissions wikis etc.

== What it Does ==
This class handle the basic creation and modification of student teams. There are also some complicated actions. E.g., if a team get destroyed (this may be caused by instructor force this team to be destroyed, the students all leave the team), the topic held by this team should be transferred to next team which is on the waiting list, if there is any.
These are the scenarios where topic transferring may happen:
* when instructor destroys a team
* when the last person leave this team
* when this team wants to switch topic
* when instructor wants to increase the available slots for a topic.

== Problem Statement ==
The same code for handling topic transferring used 3 times at the following places:

[scenario 1] teams_controller line 95 (if next_wait_listed_team),
[scenario 2] student_teams_controller line 139 (if first_waitlisted_team) and
[scenario 4] sign_up_topic line 117 (if next_wait_listed_team).
Scenario 3’s code is not copied, and one can find the code at line 92 in sign_up_topic.rb.

== What Needs to be Done ==
*Make topic_transfering a function call, and make sure all those 4 scenario works.
*Write tests for all those 4 scenarios.
*Record a video for those 4 scenarios, submit it to YouTube and submit the YouTube link to Expertiza.
*Delete method in teams_controller.rb is complicated, “@team.destroy” should be called latest after all the records related to this team can be deleted.
*write tests for delete method.

== Implementing the repeated code as function call ==

Before: Code repeated in teams_controller.rb, student_teams_controller.rb, SignUpTopic.rb
.
.
if next_wait_listed_team
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

After: The repeated code implemented as a function in SignUpTopic.rb

.
.
def self.assign_to_first_waiting_team(next_wait_listed_team)
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

==Refactoring the Order of deleting a team and its attributes==
Problem: The team is deleted even before its attributes are destroyed in teams_controller.rb
Before: Code repeated in teams_controller.rb, student_teams_controller.rb, SignUpTopic.rb
.
.
if next_wait_listed_team
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

After: The repeated code implemented as a function in SignUpTopic.rb

.
.
def self.assign_to_first_waiting_team(next_wait_listed_team)
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

Before:

.
.
@team.destroy if @team
@signUps = SignedUpTeam.where(team_id: params[:id])
@teams_users = TeamsUser.where(team_id: params[:id])
@teams_users.destroy_all if @teams_users
if @signUps.size == 1 and @signUps.first.is_waitlisted == false #this team hold a topic
.
.

After:

.
.
@team = Team.find(params[:id])
course = Object.const_get(session[:team_type]).find(@team.parent_id)
@signUps = SignedUpTeam.where(team_id: @team.id)
@teams_users = TeamsUser.where(team_id: @team.id)
if @signUps.size == 1 and @signUps.first.is_waitlisted == false
.
.

== References ==

<references />

CSC/ECE 517 Fall 2015/oss E1554 AAR

2015-11-01T00:50:57Z

Rravill: /* Refactoring the Order of deleting a team and its attributes */

'''E1554 Refactoring TeamsController.rb'''
This is description of the CSC/ECE 517 Fall2015 OSS project(E1554),we refactored teams_controller.rb,students_team_controller.rb,sign_up_topic.rb we extracted the duplicate code into a single function call,and we made sure when team is deleted its associated records are deleted first then the team gets deleted.We have tested using [http://rspec.info/ Rspec]

== Expertiza ==

Expertiza <ref>[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza].''expertiza project''</ref> is a project built with [https://en.wikipedia.org/wiki/Ruby_on_Rails Ruby on Rails]<ref>[http://rubyonrails.org/ RubyonRails]</ref>.It is mainly used by an instructor to provide a peer reviewing systems among the students it also supports team projects submissions wikis etc.

== What it Does ==
This class handle the basic creation and modification of student teams. There are also some complicated actions. E.g., if a team get destroyed (this may be caused by instructor force this team to be destroyed, the students all leave the team), the topic held by this team should be transferred to next team which is on the waiting list, if there is any.
These are the scenarios where topic transferring may happen:
* when instructor destroys a team
* when the last person leave this team
* when this team wants to switch topic
* when instructor wants to increase the available slots for a topic.

== Problem Statement ==
The same code for handling topic transferring used 3 times at the following places:

[scenario 1] teams_controller line 95 (if next_wait_listed_team),
[scenario 2] student_teams_controller line 139 (if first_waitlisted_team) and
[scenario 4] sign_up_topic line 117 (if next_wait_listed_team).
Scenario 3’s code is not copied, and one can find the code at line 92 in sign_up_topic.rb.

== What Needs to be Done ==
*Make topic_transfering a function call, and make sure all those 4 scenario works.
*Write tests for all those 4 scenarios.
*Record a video for those 4 scenarios, submit it to YouTube and submit the YouTube link to Expertiza.
*Delete method in teams_controller.rb is complicated, “@team.destroy” should be called latest after all the records related to this team can be deleted.
*write tests for delete method.

== Implementing the repeated code as function call ==

Before: Code repeated in teams_controller.rb, student_teams_controller.rb, SignUpTopic.rb
.
.
if next_wait_listed_team
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

After: The repeated code implemented as a function in SignUpTopic.rb

.
.
def self.assign_to_first_waiting_team(next_wait_listed_team)
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

==Refactoring the Order of deleting a team and its attributes==
Problem: The team is deleted even before its attributes are destroyed in teams_controller.rb
Before:

.
.
@team.destroy if @team
@signUps = SignedUpTeam.where(team_id: params[:id])
@teams_users = TeamsUser.where(team_id: params[:id])
@teams_users.destroy_all if @teams_users
if @signUps.size == 1 and @signUps.first.is_waitlisted == false #this team hold a topic
.
.

After:

.
.
@team = Team.find(params[:id])
course = Object.const_get(session[:team_type]).find(@team.parent_id)
@signUps = SignedUpTeam.where(team_id: @team.id)
@teams_users = TeamsUser.where(team_id: @team.id)
if @signUps.size == 1 and @signUps.first.is_waitlisted == false
.
.

== References ==

<references />

CSC/ECE 517 Fall 2015/oss E1554 AAR

2015-11-01T00:50:30Z

Rravill: /* Refactoring the Order of deleting a team and its attributes */

'''E1554 Refactoring TeamsController.rb'''
This is description of the CSC/ECE 517 Fall2015 OSS project(E1554),we refactored teams_controller.rb,students_team_controller.rb,sign_up_topic.rb we extracted the duplicate code into a single function call,and we made sure when team is deleted its associated records are deleted first then the team gets deleted.We have tested using [http://rspec.info/ Rspec]

== Expertiza ==

Expertiza <ref>[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza].''expertiza project''</ref> is a project built with [https://en.wikipedia.org/wiki/Ruby_on_Rails Ruby on Rails]<ref>[http://rubyonrails.org/ RubyonRails]</ref>.It is mainly used by an instructor to provide a peer reviewing systems among the students it also supports team projects submissions wikis etc.

== What it Does ==
This class handle the basic creation and modification of student teams. There are also some complicated actions. E.g., if a team get destroyed (this may be caused by instructor force this team to be destroyed, the students all leave the team), the topic held by this team should be transferred to next team which is on the waiting list, if there is any.
These are the scenarios where topic transferring may happen:
* when instructor destroys a team
* when the last person leave this team
* when this team wants to switch topic
* when instructor wants to increase the available slots for a topic.

== Problem Statement ==
The same code for handling topic transferring used 3 times at the following places:

[scenario 1] teams_controller line 95 (if next_wait_listed_team),
[scenario 2] student_teams_controller line 139 (if first_waitlisted_team) and
[scenario 4] sign_up_topic line 117 (if next_wait_listed_team).
Scenario 3’s code is not copied, and one can find the code at line 92 in sign_up_topic.rb.

== What Needs to be Done ==
*Make topic_transfering a function call, and make sure all those 4 scenario works.
*Write tests for all those 4 scenarios.
*Record a video for those 4 scenarios, submit it to YouTube and submit the YouTube link to Expertiza.
*Delete method in teams_controller.rb is complicated, “@team.destroy” should be called latest after all the records related to this team can be deleted.
*write tests for delete method.

== Implementing the repeated code as function call ==

Before: Code repeated in teams_controller.rb, student_teams_controller.rb, SignUpTopic.rb
.
.
if next_wait_listed_team
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

After: The repeated code implemented as a function in SignUpTopic.rb

.
.
def self.assign_to_first_waiting_team(next_wait_listed_team)
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

==Refactoring the Order of deleting a team and its attributes==
Problem: The team is deleted even before its attributes are destroyed in teams_controller.rb
Before:
.
.
@team.destroy if @team
@signUps = SignedUpTeam.where(team_id: params[:id])
@teams_users = TeamsUser.where(team_id: params[:id])
@teams_users.destroy_all if @teams_users
if @signUps.size == 1 and @signUps.first.is_waitlisted == false #this team hold a topic
.
.

After:
.
.
@team = Team.find(params[:id])
course = Object.const_get(session[:team_type]).find(@team.parent_id)
@signUps = SignedUpTeam.where(team_id: @team.id)
@teams_users = TeamsUser.where(team_id: @team.id)
if @signUps.size == 1 and @signUps.first.is_waitlisted == false
.
.

== References ==

<references />

CSC/ECE 517 Fall 2015/oss E1554 AAR

2015-11-01T00:50:04Z

Rravill:

'''E1554 Refactoring TeamsController.rb'''
This is description of the CSC/ECE 517 Fall2015 OSS project(E1554),we refactored teams_controller.rb,students_team_controller.rb,sign_up_topic.rb we extracted the duplicate code into a single function call,and we made sure when team is deleted its associated records are deleted first then the team gets deleted.We have tested using [http://rspec.info/ Rspec]

== Expertiza ==

Expertiza <ref>[http://wikis.lib.ncsu.edu/index.php/Expertiza Expertiza].''expertiza project''</ref> is a project built with [https://en.wikipedia.org/wiki/Ruby_on_Rails Ruby on Rails]<ref>[http://rubyonrails.org/ RubyonRails]</ref>.It is mainly used by an instructor to provide a peer reviewing systems among the students it also supports team projects submissions wikis etc.

== What it Does ==
This class handle the basic creation and modification of student teams. There are also some complicated actions. E.g., if a team get destroyed (this may be caused by instructor force this team to be destroyed, the students all leave the team), the topic held by this team should be transferred to next team which is on the waiting list, if there is any.
These are the scenarios where topic transferring may happen:
* when instructor destroys a team
* when the last person leave this team
* when this team wants to switch topic
* when instructor wants to increase the available slots for a topic.

== Problem Statement ==
The same code for handling topic transferring used 3 times at the following places:

[scenario 1] teams_controller line 95 (if next_wait_listed_team),
[scenario 2] student_teams_controller line 139 (if first_waitlisted_team) and
[scenario 4] sign_up_topic line 117 (if next_wait_listed_team).
Scenario 3’s code is not copied, and one can find the code at line 92 in sign_up_topic.rb.

== What Needs to be Done ==
*Make topic_transfering a function call, and make sure all those 4 scenario works.
*Write tests for all those 4 scenarios.
*Record a video for those 4 scenarios, submit it to YouTube and submit the YouTube link to Expertiza.
*Delete method in teams_controller.rb is complicated, “@team.destroy” should be called latest after all the records related to this team can be deleted.
*write tests for delete method.

== Implementing the repeated code as function call ==

Before: Code repeated in teams_controller.rb, student_teams_controller.rb, SignUpTopic.rb
.
.
if next_wait_listed_team
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

After: The repeated code implemented as a function in SignUpTopic.rb

.
.
def self.assign_to_first_waiting_team(next_wait_listed_team)
team_id = next_wait_listed_team.team_id
team = Team.find(team_id)
assignment_id = team.parent_id
next_wait_listed_team.is_waitlisted = false
next_wait_listed_team.save
Waitlist.cancel_all_waitlists(team_id, assignment_id)
end
.
.

==Refactoring the Order of deleting a team and its attributes==
Problem: The team is deleted even before its attributes are destroyed in teams_controller.rb
Before:
..
@team.destroy if @team
@signUps = SignedUpTeam.where(team_id: params[:id])
@teams_users = TeamsUser.where(team_id: params[:id])
@teams_users.destroy_all if @teams_users
if @signUps.size == 1 and @signUps.first.is_waitlisted == false #this team hold a topic
..

After:
..
@team = Team.find(params[:id])
course = Object.const_get(session[:team_type]).find(@team.parent_id)
@signUps = SignedUpTeam.where(team_id: @team.id)
@teams_users = TeamsUser.where(team_id: @team.id)
if @signUps.size == 1 and @signUps.first.is_waitlisted == false

..
== References ==

<references />

CSC/ECE 517 Fall 2015/oss E1554 AAR

2015-11-01T00:28:46Z

Rravill:

CSC/ECE 517 Fall 2015/oss E1554 AAR

2015-11-01T00:27:11Z

Rravill:

CSC/ECE 517 Fall 2015/oss E1554 AAR

2015-11-01T00:26:10Z

Rravill: