Expertiza_Wiki - User contributions [en]

E1877 Sort instructor reports by name, ID, score, etc

2018-12-11T05:43:43Z

Rbhasin: /* Issue 2 */

This wiki page describes the changes made according to the specification of E1877 OSS final project for Fall 2018.
----
== Peer Review Information ==
The following credentials are recommended for testing the changes:

* Instructor Login: Username: super_administrator2 Password: password
* Youtube Link: https://youtu.be/ZhXLnN5kpW8
* Github Pull-Request Link: https://github.com/expertiza/expertiza/pull/1287

== Introduction ==
=== Background ===
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.

=== Problem Statement ===
Expertiza allows instructors to view kinds of reports of assignments in their courses such as submissions, scores, and review reports. To improve the report views, some table columns such as team name, score, the average should be made sortable by using the same existing sort library.

===== What needs to be done? =====

* '''#issue 1:''' For “view submissions” table, sort “Topic name”, “Team name”, “Team member(s)”, “Links” alphabetically.
[[File:1_1877.png]]

* '''#issue 2:''' For “View scores” table, sort “Team” alphabetically, sort “Average” and “Range” (the first percentage) in both ascending or descending order.
[[File:2_1877.png]]

* '''#issue 3:''' For “View review report” table, “Reviewer” and “Metric” are already sortable, so we need to make other columns sortable: sort “Review done” by the first number than the second number (e.g., 0/1, 0/2, 0/3, 1/1, 1/5, 2/2...), sort “Team reviewed” alphabetically and sort “Score awarded / Avg. score” (the first percentage) in both ascending or descending order.
[[File:3_1877.png]]

* '''#issue 4:''' For “Author feedback report” table, change the header name “Review response rejoined” to “Review responded to” and “Last rejoined at” to “Last responded at”. Then, sort “Rejoinder” and “Review “Review responded to” as string (alphabetically), sort “# author feedbacks done” by the first number than the second number (same as “Review done” in the “View review report” table) and sort “Last responded at” as date.
[[File:4_1877.png]]

* '''#issue 5:''' For “Teammate review report” table, sort the first 3 columns as a string and sort the last column as a date.
[[File:5_1877.png]]

== Solution ==
We will be using tablesorter jQuery to sort the table. For table columns which have constraints on them for sorting, we will be creating custom scripts which tablesorter library supports to sort those columns. According to the problem type, we are supposed to perform three kinds of sorting. All these have one thing in common. Adding up the tablesorter script in the body before using them. After including the script, we are supposed to do some modifications in the table tag by including the class. Three types of scenario may arise:

#Sorting by columns alphabetically - To sort the columns alphabetically, the table-head attribute must include sorter-true class with it to enable the sorting alphabetically.
#Sorting by date - It includes adding of a date default format in the script to denote the sorter type that must be used to sort the column of the date.
#Sorting by the first number followed by the second number - It will require splitting up of the data into two parts separated by '/' and then sorting the first part, followed by the second part.

=== About jQuery tablesorter 2.0===
tablesorter is a jQuery plugin for turning a standard HTML table with THEAD and TBODY tags into a sortable table without page refreshes. tablesorter can successfully parse and sort many types of data including linked data in a cell. It has many useful features including:

* Multi-column sorting
* Multi-tbody sorting
* Parsers for sorting text, URIs, integers, currency, floats, IP addresses, dates (ISO, long and short formats), time. Add your own easily
* Support secondary "hidden" sorting (e.g., maintain alphabetical sort when sorting on other criteria)
* Extensibility via widget system
* Cross-browser: IE 6.0+, FF 2+, Safari 2.0+, Opera 9.0+
* Small code size

== UML Design ==
[[File:6_1877.png | center]]

== Modification of Files ==
The following files were modified:
* app/views/assignments/list_submissions.html.erb (issue 1)
* app/views/grades/_team_title.html.erb (issue 2)
* app/views/grades/_tabbing.html.erb (issue 2)
* app/views/grades/_team.html.erb (issue 2)
* app/views/grades/_team_charts.html.erb (issue 2)
* app/views/grades/_team_title.html.erb (issue 2)
* app/views/grades/view.html.erb (issue 2)
* app/assets/javascripts/grading.js (issue 2)
* app/views/review_mapping/_review_report.html.erb (issue 3)
* app/views/review_mapping/_feedback_report.html.erb (issue 4)
* app/helpers/review_mapping_helper.rb (issue 4)
* app/views/review_mapping/_teammate_review_report.html.erb (issue 5)

== Solutions Implemented ==
=== Issue 1 ===
We have modified the views/assignments/list_submissions.html.erb by adding the tablesorter class in the table tag. Then with the table head, we added suitable classes and added scripts at the top of the file to sort the table contents within the file.

Added the following script to the file.
<pre>
<script>
$(function () {
/*Function for sorting the table */
$("#submissionsTable").tablesorter({
sortList: [[0,0]] //sort First Column by default when page loads
});
});
</script>
</pre>

Then, we changed the table to this.

<pre>
<table id ="submissionsTable" class="table table-striped" style="margin-top: 50px">
<thead>
<% if @assignment.topics? %>
<th class="sorter-true" style="font-weight: bold; font-size: 15px;">Topic name</th>
<% end %>
<% if @assignment.max_team_size > 1 %>
<th class="sorter-true" style="font-weight: bold; font-size: 15px;">Team name</th>
<th class="sorter-true" style="font-weight: bold; font-size: 15px;">Team member(s)</th>
<% else %>
<th class="sorter-true" style="font-weight: bold; font-size: 15px;">Participant name</th>
<% end %>
<th class="sorter-true" style="font-weight: bold; font-size: 15px;">Links</th>
<th class="sorter-false" style="font-weight: bold; font-size: 15px;"></th>
</tr>
</pre>

[[File:new_1_1877.png]]

=== Issue 2 ===
We have modified the /view.html.erb, _teams.html.erb, _team_title.html.erb and _team.html.erb by adding the tablesorter class in the table tag. In this section, we were facing some issues and the code was highly unstructured. Also, the JavaScript was not proper in terms of usability and there were some elements which were not working properly as the code was static. We cleaned the code in these four files including the assets/javascripts/grading.js file. To make the view expandable, we made this change to the grading.js file. Also as the view which expanded on clicking of plus sign(beside Team Name) was added as a row, we made it as a columns and are expanding this column using javascript and css. We made this change as tablesorter library was sorting the expanded view as well and spoiling the table structure on sorting the table by Team name.

<pre>
//E1877: changes made to adjust width of expandables
var offsets = obj.getBoundingClientRect();
obj.style.width="calc(100vw - 103px)";
</pre>

[[File:new_2_1877.png]]

=== Issue 3 ===
We have modified the views/review_mapping/_review_report.html.erb file and also added a custom script to sort "Reviews done" and "Score awarded / Avg. score". To sort "team reviewed", we used tablesorter which is similar to the issue#1. Following script has been added for custom sort.
<pre>
<script>
$(function () {
// E1877: Function for sorting the table */
$("#report_Table").tablesorter({
// E1877: sortList: [[1, 0]], sort First Column by default when page loads
textSorter: {
3: function (value1, value2) {
//E1877: splitting by % and comparisons of values
var result1 = value1.split("%");
var result2 = value2.split("%");
if (parseInt(result1[0]) > parseInt(result2[0])) {
return 1;
}
else if (parseInt(result1[0]) < parseInt(result2[0])) {
return -1;
}
else {
return 0;
}
}
},
headers: {
2: {
sorter: 'averageParser' //E1877: custom Parser to parse Metrics data for the custom parser
}
}
});
});

</pre>

[[File:new_3_1877.png]]

=== Issue 4 ===
Initially, we referred to /views/review_mapping/_feedback_report.html.erb file for making the changes. In this, we started by renaming the column which was quite easy. Then we applied tablesorter for "Rejoinder" and “Review responded to”. For "Last responded at", we added the date feature which is set to MM/DD/YYYY format. Again for the “# author feedbacks done”, we used the same script which was used in Issue#3. The script after adding date has been added below:

<pre>
<script>
$(function () {
/*Function for sorting the table */
$("#authorFeedback").tablesorter({
dateFormat : "mmddyyyy", //E1877: set the default date format
sortList: [[0,0]] // E1877: sort First Column by default when page loads
});
});
</script>
</pre>

We have demonstrated the implementation part of the image below. You can see the arrow marks beside the table header. This has been implemented with all the other issues as well. You can refer to our YouTube video for further reference.

[[File:sol_4.png|center]]

=== Issue 5 ===
To solve this issue, we used the same tablesorter jquery plugin as used in issue 1 combined with the date data member as used in issue 4. We have modified the /views/review_mapping/_teammate_review_report.html.erb file to complete the solution.

[[File:new_5_1877.png]]

== Testing Plan ==
=== Functional Testing ===

===== For issue 1 =====
# Login as a super_admininstrator2.
# Click Assignments tab next to Courses
# Select the "View submissions" icon for the assignment for which you want to see the report of
# Sort the table by clicking on headers

===== For issue 2 =====
# Login as a super_admininstrator2.
# Click Assignments tab next to Courses
# Select the "View Scores" icon for the assignment for which you want to see the report of
# Sort the table by clicking on headers

===== For issue 3 =====
# Login as a super_admininstrator2.
# Click Assignments tab next to Courses
# Select the "View report" icon for the assignment for which you want to see the report of
# Sort the table by clicking on headers

===== For issue 4 =====
# Login as a super_admininstrator2.
# Click Assignments tab next to Courses
# Select the "View report" icon for the assignment for which you want to see the report of
# Select the "Author Feedback report" from the drop-down menu
# Sort the table by clicking on headers

===== For issue 5 =====
# Login as a super_admininstrator2.
# Click Assignments tab next to Courses
# Select the "View submissions" icon for the assignment for which you want to see the report of
# Select the "Teammate Review report" from the drop-down menu
# Sort the table by clicking on headers

== Team Information ==
#Ayush Arnav (aarnav@ncsu.edu)
#Rayan Dasoriya (rdasori@ncsu.edu)
#Rashik Bhasin (rbhasin@ncsu.edu)
#Prakshatkumar Shah (pmshah2@ncsu.edu)
#'''Mentor:''' Xiao Ma (xma21@ncsu.edu)

==References==

#[https://github.com/expertiza/expertiza Expertiza on GitHub]
#[https://github.com/expertiza/expertiza/pull/1287 GitHub Pull Request]
#[http://expertiza.ncsu.edu/ The Live Expertiza Website]
#[https://mottie.github.io/tablesorter/docs/ tablesorter jQuery]
#Clean Code: A handbook of agile software craftsmanship. Author: Robert C Martin

E1877 Sort instructor reports by name, ID, score, etc

2018-11-13T07:10:22Z

Rbhasin: /* Files modified */

E1877 Sort instructor reports by name, ID, score, etc

2018-11-13T07:09:20Z

Rbhasin: /* Solutions Implemented */

E1877 Sort instructor reports by name, ID, score, etc

2018-11-13T07:08:55Z

Rbhasin: Created page with "This wiki page describes the changes made according to the specification of E1877 OSS final project for Fall 2018. ---- == Peer Review Information == The following credentials ar..."

E1827 Topic management

2018-11-10T04:29:49Z

Rbhasin: /* Testing Plan */

This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.
----
== Peer Review Information ==
The following credentials are recommended for testing the changes:

* Instructor Login: username: instructor6 password: password
* Youtube link: https://www.youtube.com/watch?v=_0UU0r4IOf4&feature=youtu.be

== Introduction ==
=== Background ===
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.

=== Problem Statement ===
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.

===== What needs to be done?: =====

* Issue #971 Change create topic UI into AJAX.

* Issue #926 We need a way to sort topics by topic number in assignment#edit page.

* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.

== Files modified ==
The following files were modified
* app/views/sign_up_sheet/_add_signup_topics.html.erb
* app/views/sign_up_sheet/_table_header.html.erb
* app/views/sign_up_sheet/_table_line.html.erb
* app/controllers/sign_up_sheet_controller.rb
* app/views/assignments/edit.html.erb
* app/controllers/assignments_controller.rb
* app/views/suggestion/list.html.erb
* app/controllers/suggestion_controller.rb
* db/schema.rb

== Files Added ==
The following files were added
* db/migrate/20181027001119_add_feedback_to_suggestion.rb

== Solutions Implemented ==
=== Issue #971 Change create topic UI into AJAX ===
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered.

In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).

On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.
It submits a ajax request when the 'save topic button is clicked'
<pre style="color: black; border:1px;">
<div>
<table class="table table-striped">

<tr id="add_topic" style="display:none;">
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %>
<td><%= f.text_field :topic_identifier %></td>
<td><%= f.text_field :topic_name %></td>
<td><%= f.number_field :max_choosers, min: 0 %></td>
<td></td>
<td></td>
<td></td>
<td><%= f.submit %></td>
<% end %>
</tr>

</table>
</div>
<script>
function showZeroSlotWarning(){
if ($('#topic_max_choosers').val() == 0){
alert("If you create a topic with 0 slots, students cannot assign this topic.");
return false;
}
};
function addCreateTopicSection(){
$("#topic_table_header").after($("#add_topic"));
$("#add_topic").toggle();
};
</script>

</pre>

On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.
<pre style="color: black; border:1px;">
<th width="3%" align="center"><a id="myLink" title="Add"
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th>
</pre>

On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.
<pre style="color: black; border:1px;">
<% @sign_up_topic = SignUpTopic.new %>
<% @topic = @sign_up_topic %>
<% @topic.max_choosers=1 %>
</pre>

===== Topics table before changes =====

[[File:topic_3.png]]

===== Topics table after changes =====

[[File:topic_4.png]]

=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.

To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-
<pre>
<script>
$(function () {
/*Function for sorting the table */
$(".sortable").tablesorter({
sortList: [[0,0]] //sort First Column by default when page loads
});
});
</script>
</pre>

And made this change to the current table in html:-
<pre>
<table class="table table-striped sortable">
<thead>
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr>
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr>
</thead>
</pre>

Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-
<pre>
<th class="sorter-true" width="5%">Topic #</th>
</pre>

'''Sorting in ascending order''':-
[[File:Edit_ascending.png]]

'''Sorting in descending order''':-
[[File:Edit_descending.png]]

=== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===
We should allow instructors to give feedback when accepting or rejecting topic suggestions. As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.

On the file '''app/views/suggestion/list.html.erb''',added an additional editable textbox and a submit button. On click of the button the feedback provided in the text box is saved to the database in a table name suggestions, column name feedback.

<pre style="color: black; border:1px;">
<table class="general" cellpadding=5 width=100% border=1>
<tr>
<th>Title</th>
<th>Status</th>
<th>Submitter's user name</th>
<th>Action</th>

<th>Feedback</th>
<th>Save</th>
</tr>

<% for suggestion in @suggestions %>
<tr class="listingRow">


<%= form_for :suggestion, :url => update_feedback_suggestion_index_path(:suggestion_id => suggestion.id, :id => params[:id], :type => params[:type]) do |f| %>
<td style="max-width: 200px"><%=h suggestion.title %></td>
<td align="center"><%=h suggestion.status %></td>
<td align="center"><%=h suggestion.unityID %></td>
<td align="center"><%= link_to 'View', :action => 'show', :id => suggestion %></td>
<td align="center"><%= f.text_field :feedback %></td>
<td align="center"><%= f.submit 'Save Feedback' %></td>
<% end %>
</tr>
<% end %>
</table></pre>

On the file '''app/controllers/suggestion_controller.rb''' ,added an additional method to save the changes in the feedback text box to database.

<pre style="color: black; border:1px;">
# Method to save/update feedback given by the instructor in the suggestions table in feedback column
# After saving the data we redirect the user to the same page
def update_feedback
Suggestion.find(params[:suggestion_id]).update_attributes(feedback: params[:suggestion][:feedback])
redirect_to list_suggestion_index_path(:id => params[:id], :type => params[:type])
end
</pre>

On the file '''db/migrate/20181027001119_add_feedback_to_suggestion.rb''' ,added migration scripts. Script is adding a column name "feedback" in the suggestions table.

<pre style="color: black; border:1px;">
class AddFeedbackToSuggestion < ActiveRecord::Migration
def change
add_column :suggestions, :feedback, :string
end
end
</pre>

On the file '''expertiza/db/schema.rb''' ,schema changes as effect of adding column in table suggestions.

<pre style="color: black; border:1px;">
create_table "suggestions", force: :cascade do |t|
t.integer "assignment_id", limit: 4
t.string "title", limit: 255
t.text "description", limit: 65535
t.string "status", limit: 255
t.string "unityID", limit: 255
t.string "signup_preference", limit: 255
t.string "feedback", limit: 255
end
</pre>

===== Suggestions list page before changes =====

[[File:BeforeFeedbackPage.png]]

===== Suggestions list page after changes =====

[[File:AfterFeedbackPage.png]]

== Testing Plan ==
=== Functional Testing ===

===== Issue #971: Change create topic UI into AJAX =====
# Login as an instructor.
# Click Assignments tab next to Courses
# Select the assignment for which a new topic has to be added
# Click the edit icon for the assignment and go to Topics tab
# You will be able to see the topics list in a table format. Click on add icon on the right side corner of the table header
# Fill in the details and click save topic

If a user tries to set number of slots as zero, a warning pops up and prohibits the user from doing so.
===== Warning message when max_choosers is set to zero =====

[[File:topic_5.png]]

===== Issue #926 We need a way to sort topics by topic number in assignment#edit page =====
As we have shown this in video:-
# Login as an instructor.
# Click Assignments tab next to Courses
# Click the edit icon for the specific assignment and go to Topics tab
# You will be able to see the topics list in a table format sorted in ascending order by 'Topic# '.
# Click on 'Topic# ' icon to sort the table in descending order based on 'Topic# ', and if you click it again after that it sorts the table in ascending order based on 'Topic# '.

===== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions =====
# Login as an instructor.
# Click Manage -> Assignments.
# After clicking on the Assignment tab, a page will show all the assignments.
# Click the view suggestions icon on the right bottom corner.
# You will be able to see a list of suggestions given by the students for that particular topic.
# Add feedback in the feedback text box and click save feedback button to save it.
# To verify if the feedback was saved to the table, query suggestions table and match the feedback in the feedback column to the feedback given.

E1827 Topic management

2018-11-10T04:07:03Z

Rbhasin: /* Testing Plan */

This wiki page describes the changes made according to the specification of E1827 OSS assignment for Fall 2018.
----
== Peer Review Information ==
The following credentials are recommended for testing the changes:

* Instructor Login: username: instructor6 password: password
* Youtube link: https://www.youtube.com/watch?v=_0UU0r4IOf4&feature=youtu.be

== Introduction ==
=== Background ===
Expertiza is a web portal which can be used to manage assignments related to a course. It provides a platform to view assignments, manage teams, select topics and work on improvement through anonymous peer reviews.

=== Problem Statement ===
Expertiza allows the instructor to define different topics that students or teams could choose from as their assignment. Each topic can have 0 or more slots that indicate the number of students or teams that can sign up for that topic. We identified several ideas that can improve user experience when managing the topics. Thus, we would like you to introduce new features to implement these ideas.

===== What needs to be done?: =====

* Issue #971 Change create topic UI into AJAX.

* Issue #926 We need a way to sort topics by topic number in assignment#edit page.

* Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions.

== Files modified ==
The following files were modified
* app/views/sign_up_sheet/_add_signup_topics.html.erb
* app/views/sign_up_sheet/_table_header.html.erb
* app/views/sign_up_sheet/_table_line.html.erb
* app/controllers/sign_up_sheet_controller.rb
* app/views/assignments/edit.html.erb
* app/controllers/assignments_controller.rb
* app/views/suggestion/list.html.erb
* app/controllers/suggestion_controller.rb
* db/schema.rb

== Files Added ==
The following files were added
* db/migrate/20181027001119_add_feedback_to_suggestion.rb

== Solutions Implemented ==
=== Issue #971 Change create topic UI into AJAX ===
Currently, when instructors manually enter topics, they have to go back and forth between the list of the topic page (views>sign_up_sheet>_add_signup_topics.html.erb) and the create topic page (views>sign_up_sheet>new.html.erb). This should be done via AJAX so that the adding a new topic can be done through an editable grid or a popup form without leaving the list of topic page. Then and the list should be automatically updated when a new topic is entered.

In addition, when adding a topic, the default slot should be 1 instead of 0. the current warning message that shows up when the slot is 0, can't be closed properly and should be fixed (if the form is made popup in the future, the warning should be on the same page as the form e.g., highlight the field and print an instruction to change the # of slot).

On the file '''app/views/assignments/edit.html.erb''' we added an additional editable <tr> table element which is appended to the table when the add button is clicked in the topics table.
It submits a ajax request when the 'save topic button is clicked'
<pre style="color: black; border:1px;">
<div>
<table class="table table-striped">

<tr id="add_topic" style="display:none;">
<%= form_for :topic, :url => sign_up_sheet_index_path(:id => @assignment_form.assignment.id),:html => { :onsubmit => "return showZeroSlotWarning()",autocomplete: "off" } do |f| %>
<td><%= f.text_field :topic_identifier %></td>
<td><%= f.text_field :topic_name %></td>
<td><%= f.number_field :max_choosers, min: 0 %></td>
<td></td>
<td></td>
<td></td>
<td><%= f.submit %></td>
<% end %>
</tr>

</table>
</div>
<script>
function showZeroSlotWarning(){
if ($('#topic_max_choosers').val() == 0){
alert("If you create a topic with 0 slots, students cannot assign this topic.");
return false;
}
};
function addCreateTopicSection(){
$("#topic_table_header").after($("#add_topic"));
$("#add_topic").toggle();
};
</script>

</pre>

On the file '''app/views/assignments/_table_header.html.erb''' we added an additional editable <th> table element which adds a add topic button which toggles the editable row for creating topics.
<pre style="color: black; border:1px;">
<th width="3%" align="center"><a id="myLink" title="Add"
href="#" style="color: #00aa00; font-size: 26px;" onclick="addCreateTopicSection();return false;">+</a></th>
</pre>

On the file '''app/views/assignments/_add_signup_topics.html.erb''' we initialize the new topic with max_choosers as 1.
<pre style="color: black; border:1px;">
<% @sign_up_topic = SignUpTopic.new %>
<% @topic = @sign_up_topic %>
<% @topic.max_choosers=1 %>
</pre>

===== Topics table before changes =====

[[File:topic_3.png]]

===== Topics table after changes =====

[[File:topic_4.png]]

=== Issue #926 We need a way to sort topics by topic number in assignment#edit page. ===
The task is to sort the Topics according to the topic number. This functionality is added using Tablesorter css, where clicking the topic# will toggle the topics in the ascending/descending order.

To use Tablesorter in app/views/sign_up_sheet/_add_signup_topics.html.erb, we added this script:-
<pre>
<script>
$(function () {
/*Function for sorting the table */
$(".sortable").tablesorter({
sortList: [[0,0]] //sort First Column by default when page loads
});
});
</script>
</pre>

And made this change to the current table in html:-
<pre>
<table class="table table-striped sortable">
<thead>
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr>
<tr><%= render :partial => '/sign_up_sheet/table_header' %></tr>
</thead>
</pre>

Then to make Topic to be sortable, we added this in app/views/sign_up_sheet/_table_header.html.erb:-
<pre>
<th class="sorter-true" width="5%">Topic #</th>
</pre>

'''Sorting in ascending order''':-
[[File:Edit_ascending.png]]

'''Sorting in descending order''':-
[[File:Edit_descending.png]]

=== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions. ===
We should allow instructors to give feedback when accepting or rejecting topic suggestions. As it is, one can give feedback on topics suggested by students only when the instructor wants the topic to be revised, not when (s)he is approving or rejecting it. Feedback should be possible in any of these cases.

On the file '''app/views/suggestion/list.html.erb''',added an additional editable textbox and a submit button. On click of the button the feedback provided in the text box is saved to the database in a table name suggestions, column name feedback.

<pre style="color: black; border:1px;">
<table class="general" cellpadding=5 width=100% border=1>
<tr>
<th>Title</th>
<th>Status</th>
<th>Submitter's user name</th>
<th>Action</th>

<th>Feedback</th>
<th>Save</th>
</tr>

<% for suggestion in @suggestions %>
<tr class="listingRow">


<%= form_for :suggestion, :url => update_feedback_suggestion_index_path(:suggestion_id => suggestion.id, :id => params[:id], :type => params[:type]) do |f| %>
<td style="max-width: 200px"><%=h suggestion.title %></td>
<td align="center"><%=h suggestion.status %></td>
<td align="center"><%=h suggestion.unityID %></td>
<td align="center"><%= link_to 'View', :action => 'show', :id => suggestion %></td>
<td align="center"><%= f.text_field :feedback %></td>
<td align="center"><%= f.submit 'Save Feedback' %></td>
<% end %>
</tr>
<% end %>
</table></pre>

On the file '''app/controllers/suggestion_controller.rb''' ,added an additional method to save the changes in the feedback text box to database.

<pre style="color: black; border:1px;">
# Method to save/update feedback given by the instructor in the suggestions table in feedback column
# After saving the data we redirect the user to the same page
def update_feedback
Suggestion.find(params[:suggestion_id]).update_attributes(feedback: params[:suggestion][:feedback])
redirect_to list_suggestion_index_path(:id => params[:id], :type => params[:type])
end
</pre>

On the file '''db/migrate/20181027001119_add_feedback_to_suggestion.rb''' ,added migration scripts. Script is adding a column name "feedback" in the suggestions table.

<pre style="color: black; border:1px;">
class AddFeedbackToSuggestion < ActiveRecord::Migration
def change
add_column :suggestions, :feedback, :string
end
end
</pre>

On the file '''expertiza/db/schema.rb''' ,schema changes as effect of adding column in table suggestions.

<pre style="color: black; border:1px;">
create_table "suggestions", force: :cascade do |t|
t.integer "assignment_id", limit: 4
t.string "title", limit: 255
t.text "description", limit: 65535
t.string "status", limit: 255
t.string "unityID", limit: 255
t.string "signup_preference", limit: 255
t.string "feedback", limit: 255
end
</pre>

===== Suggestions list page before changes =====

[[File:BeforeFeedbackPage.png]]

===== Suggestions list page after changes =====

[[File:AfterFeedbackPage.png]]

== Testing Plan ==
=== Functional Testing ===

===== Issue #971: Change create topic UI into AJAX =====
# Login as an instructor.
# Click Assignments tab next to Courses
# Select the assignment for which a new topic has to be added
# Click the edit icon for the assignment and go to Topics tab
# You will be able to see the topics list in a table format. Click on add icon on the right side corner of the table header
# Fill in the details and click save topic

If a user tries to set number of slots as zero, a warning pops up and prohibits the user from doing so.
===== Warning message when max_choosers is set to zero =====

[[File:topic_5.png]]

===== Issue #926 We need a way to sort topics by topic number in assignment#edit page =====
# Login as an instructor.
# Click Assignments tab next to Courses
# Click the edit icon for the specific assignment and go to Topics tab
# You will be able to see the topics list in a table format sorted in ascending order by 'Topic# '.
# Click on 'Topic# ' icon to sort the table in descending order based on 'Topic# ', and if you click it again after that it sorts the table in ascending order based on 'Topic# '.

===== Issue #718 We should allow instructors to give feedback when accepting or rejecting topic suggestions =====
# Login as an instructor.
# Click Manage -> Assignments.
# After clicking on the Assignment tab, a page will show all the assignments.
# Click the view suggestions icon on the right bottom corner.
# You will be able to see a list of suggestions given by the students for that particular topic.
# Add feedback in the feedback text box and click save feedback button to save it.
# To verify if the feedback was saved to the table, query suggestions table and match the feedback in the feedback column to the feedback given.

E1827 Topic management

2018-11-02T20:08:35Z

Rbhasin: /* We should allow instructors to give feedback when accepting or rejecting topic suggestions. */

E1827 Topic management

2018-11-02T20:02:25Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

E1827 Topic management

2018-11-02T20:01:27Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

E1827 Topic management

2018-11-02T19:45:01Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

E1827 Topic management

2018-11-02T19:44:42Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

E1827 Topic management

2018-11-02T19:44:23Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

E1827 Topic management

2018-11-02T19:43:46Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

E1827 Topic management

2018-11-02T19:43:17Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

E1827 Topic management

2018-11-02T19:38:27Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

File:Edit descending.png

2018-11-02T19:37:45Z

Rbhasin: descending edit topics

descending edit topics

E1827 Topic management

2018-11-02T19:30:56Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

E1827 Topic management

2018-11-02T19:30:21Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

File:Edit ascending.png

2018-11-02T19:27:26Z

Rbhasin: Edit_ascending.png

Edit_ascending.png

E1827 Topic management

2018-11-02T19:21:08Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

E1827 Topic management

2018-11-02T19:20:27Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

E1827 Topic management

2018-11-02T19:17:36Z

Rbhasin: /* Issue #926 We need a way to sort topics by topic number in assignment#edit page. */

File:Ascending.png

2018-11-02T19:15:57Z

Rbhasin: uploaded a new version of "File:Ascending.png": ascending.png

E1827 Topic management

2018-11-02T18:39:57Z

Rbhasin: /* Files modified */