testing rspec file

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-12-03T01:18:07Z

Nsingh9: /* Testing */

=='''Introduction'''==
==='''Purpose'''===
Expertiza provides the functionality of peer reviews. The best advantage of peer review for the students is that it allows students to learn from each others' work.
#It provides a dual benefit for both the reviewer and the writer as they are introduced to a different set of eyes on the code
#It might expose edge cases not previously thought of
#It helps instructors review a project faster
#It emphasizes the importance of writing in such a way that it's easy for a third person to read and understand
In order to understand the correlation between the time spent in reviewing and the knowledge gained through reviewing submissions, we need to track the time that each student spends on peer reviewing the work. The knowledge gained can be measured by assignment score and reviewing score of the reviewer. This data can be further be utilized for research studies related to learning through peer reviews.

==='''What needs to be done'''===
#Design and implement a solution that handles the use case, where students’ submissions are hosted on an external website e.g. GitHub and Youtube use cases
#Design a database schema for logging the time a reviewer spends on each submission link
#Modify Review report (views/review_mapping/_review_report.html.erb) to display the response time summary report for each reviewer.
 

=='''Approach and Implementation'''==
==='''Types of submissions'''===

Generally, the submission links can be one of the following:
#GitHub project/repository link , GitHub Pull requests link or Deployment link
#Youtube videos
#Wikipages
#Text document/doc/pdf/ppt
#Images - png/jpg
#Downloadable contents

==='''Database Design'''===
The task is to know how much time a reviewer spent reviewing other teams.
#We earlier thought of having '''response_id''' as one of the fields which could help us identify for which response we are recording reviewing time. But, entry in the''' responses table''' is created only once the response is either saved or submitted. Since we want our response_times entry to be created before that, we did not have any '''response_id''' corresponding to the response. 
#We primarily needed reviewer and reviewee specific data. So, another parameter to help us identify this primary information was '''response_map_id''' in the '''response_maps''' table. Once the review is started , we have the '''response_map_id''' from which we can later derive both '''reviewer_id''' and '''reviewee_id'''.There can be separate links uploaded per round, hence '''round''' is also an important parameter to be recorded. We need to record '''start''' and '''end''' time per '''link'''. 
The following table '''response_times''' was created to implement a solution for this project: 

[[File:Response_times.png]]
 
 

==='''How reviewing times get recorded in the database'''===
Start and end time of each link viewed in one session needs to be recorded.

The following are the steps that will be followed to keep track of the time:
#Log the '''start time''' when a user clicks on a submitted link (a new entry in the '''response_times table''' gets created) during new review or while editing his saved review. An AJAX call is made from the view to '''ResponseTime''' controller action '''record_start_time''' to save start time details to database.
#End time of all open links (where end time has not been recorded yet) for that session get recorded in the cases mentioned below. In this, an AJAX call is made from the view to '''ResponseTime''' controller action '''record_end_time''' to save '''end time''' details to database. All these cases are handled with the help of javascript '''onbeforeunload''' property
##User logged out
##User closed the window
##User clicked on 'save' or 'submit' button
##User switched to some other view other than the page where he is currently writing the review in the same tab. Note - the user is free to switch between tabs. The end time will not get affected in this case
#Next time the reviewer opens the links again to review:
##New entry gets created in the response_times table and start time gets recorded for this new session
##The above procedure for end time remains the same
#In case there is no user activity on the expertiza reviewing page for more than 20 minutes, there will be a pop up asking the user if he is still reviewing the submission.
#As soon as the pop up is shown, the end times of all open links get updated to this time. The user has two options to cancel or to okay. If the user clicks on 'okay', then the above links for which we just updated the end time, need to be added as new entries again in this new session with start time as the current time.
#This way we have individual entries for each link corresponding to each session with both start and end times recorded in the database.
 
[[File:Popup screenshot.png]]
 
'''Behaviour Diagram''' : 
[[File:Flow_diagram_final.jpg|center]]
 

==='''Viewing the recorded times spent'''===
Instructor can now view the total times taken by reviewers in the Review report summary. This report is rendered by partial '''review_mapping/_review_report.html.erb'''. We shall modify this view to record the times spent by the reviewer per review round for each team reviewed for this particular assignment. For example - 15.32, 12.67 indicates that reviewer spent 15.32 minutes on round 1 review and 12.67 minutes on round 2 review as shown below.
 
'''Modified View''' : 
[[File:Review_report_view.png|center]]

Now, we can see that this report is simply an overview. If the instructor wishes to view fine-grained details, he can click on the reviewer link in the report. A popup is then rendered by '''popup/reviewer_details_popup.html.erb'''. This view shows reviewer details and details of time spent per link per round by that particular reviewer. Note - total time represents total time spent by the reviewer over all rounds over all links.
 
If the user clicks on "alternate view" for a particular round, a pie-chart representation of the same data for that round appears above the details table. The user can toggle this view off by clicking "hide details" and "show details".
 
[[File:Pie-chart.png]]
 
 
 

==='''Other Edge cases handled :'''===

#What happens when the user clicks on the same link twice in the same session:
##It may so happen that once the user clicked on a link, by mistake he/she closed it or lost the link and wishes to view it again. If the link is again clicked, a second entry gets created with the current time as start time.
##We account for the previous entry by updating its end time as current time.
#What happens when the user downloads the submission:
##If the user downloads any submission, the start time will be recorded on click link and end time will get recorded as above or when he submits the review
 

==='''Files modified'''===
#response_controller.rb
#response/response.html.erb
#submitted_content/_main.html.erb
#submitted_content/_hyperlink.html.erb
#response/view.html.erb
#review_mapping/_review_report.html.erb
#popup/reviewer_details_popup.html.erb
#helpers/review_mapping_helper.rb
#config/routes.rb
#application.js
 

==='''Files added'''===
#response_time_controller.rb
#response_time.rb
#review_mapping/_review_submissions_time_spent.html.erb

=='''Testing'''==
==='''Manual Testing'''===
To test if the time spent by the reviewer on the submitted links shows up in the response_report in Instructor View. 
# Login as a reviewer, for example (student5930). Click on the submitted links to start reviewing. Once review is done, the time spent is recorded in the background and saved in our database
# Login as an instructor. Click on assignments tab. Click on 'View Review Report' under actions for the particular assignment. In the view rendered we expect the total time spent by the reviewers for each to be visible
#Click on the reviewer in order to see detailed information of time spent by each reviewer
#Click on alternate view for each entry in order to see link wise time spent in form of a pie chart.

 
==='''RSpec Testing'''===
To test the two new controller methods, we wrote and ran RSpec tests for it. We have two methods in the new controller - record_start_time and record_end_time.

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-14T23:55:48Z

Nsingh9: /* Test Plan */

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-14T23:54:17Z

Nsingh9: /* Steps to follow for all external links (Github, YouTube etc) */

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-14T23:41:48Z

Nsingh9: /* Steps to follow for all external links (Github, YouTube etc) */

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-14T23:29:09Z

Nsingh9: /* Files to be modified/added */

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-14T23:01:37Z

Nsingh9: /* Test Plan */

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-14T23:01:05Z

Nsingh9: /* Steps to follow for all external links (Github, YouTube etc) */

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-14T23:00:40Z

Nsingh9: /* Steps to follow for all external links (Github, YouTube etc) */

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-14T23:00:16Z

Nsingh9: /* Steps to follow for all external links (Github, YouTube etc) */

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-14T23:00:00Z

Nsingh9: /* What needs to be done */

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-11T04:59:49Z

Nsingh9: /* Purpose */

=='''Introduction'''==
==='''Purpose'''===
Expertiza provides the functionality of peer reviews. The best advantage of peer review for the students is that it allows them to learn from each other work.
#It provides a dual benefit for both the reviewer and the writer as they are introduced to a different set of eyes on the code
#It might expose edge cases not previously thought of
#It helps instructors review a project faster
#It emphasizes the importance of writing in such a way that it's easy for a third person to read and understand
In order to help them to do this, we have to be able to track the time that students spend observing the other's work. Unfortunately, most peer assessment systems do not manage the content of students’ submission within the systems. They usually allow the authors submit external links to the submission, which makes it difficult for the system to track the time that the reviewers spend on the submissions. The purpose of the project is to be able to successfully track the time that each student spends on peer reviewing the work.

==='''What needs to be done'''===
#Design and implement a solution that handles the use case, where students’ submissions are hosted on an external website e.g. GitHub and Youtube use cases
#Modify the reviewer interface in expertiza to accommodate your solution e.g., change the link that opens submitted files in views/response/_submitted_files.html.erb so that when the user clicks on the link, it opens a popup window that shows the submission, record time when it opens and closes.
#Design a database schema for logging the time a reviewer spend on a submission
#Modify Review report (views/review_mapping/_review_report.html.erb) to show the time spent on each submission

=='''Approach'''==
==='''Types of submissions'''===

Based on each submission type, we need to handle the tracking functionalities differently. Generally, the submission links can be one of the following:
#GitHub project/repository link , GitHub Pull requests link or Deployment link
#Youtube videos
#Wikipages
#Text document/doc/pdf/ppt
#Images - png/jpg
#Downloadable contents

==='''Steps'''===
On clicking a submitted link, a new window will pop-up that will keep track of the time spent on that new window. This can be a link to any of the above-mentioned submissions. A possible solution is to embed the submissions (done on an external website) within the peer assessment system itself using e.g., IFrame or Embed tag.
 The following are the steps that will be followed to keep track of the time:
#Start the time when a user clicks on the submitted link (a new window pops-up)
#We'll pause the time in the following cases:
##User idle for more than 30sec
##User switched tabs
##User minimized the window
#Resume time when:
##User switches back to this window
##User performs some activity after being idle
#Time is saved into the database when the user saves, submits review or closes the popped-up window
##If the corresponding entry already exists, the value of the time column is updated otherwise it is created. 
'''Behaviour Diagram''' : 
[[File:Behaviour_diagram.png|center]]

==='''Edge cases'''===

Edge cases that need to be handled :

#What happens when the user refreshes the window : It will set the timer back to 0 and the time spent on that page will be reset.
#What happens when the user downloads the submission: If the user downloads any solution and then opens it in his/her local machine, then the time spent on that can't be tracked.

==='''Database Design'''===
The following table review_submission_timing will be created to implement a solution for this project: 

[[File:Database table review submission timing.png]]

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-11T04:59:24Z

Nsingh9: /* Purpose */

=='''Introduction'''==
==='''Purpose'''===
Expertiza provides the functionality of peer reviews. The best advantage of peer review for the students is that it allows them to learn from each other work.
#It provides a dual benefit for both the reviewer and the writer as they are introduced to a different set of eyes on the code
#It might expose edge cases not previously thought of
#It helps instructors review a project faster
#It emphasizes the importance of writing in such a way that it's easy for the third person to read and understand
In order to help them to do this, we have to be able to track the time that students spend observing the other's work. Unfortunately, most peer assessment systems do not manage the content of students’ submission within the systems. They usually allow the authors submit external links to the submission, which makes it difficult for the system to track the time that the reviewers spend on the submissions. The purpose of the project is to be able to successfully track the time that each student spends on peer reviewing the work.

==='''What needs to be done'''===
#Design and implement a solution that handles the use case, where students’ submissions are hosted on an external website e.g. GitHub and Youtube use cases
#Modify the reviewer interface in expertiza to accommodate your solution e.g., change the link that opens submitted files in views/response/_submitted_files.html.erb so that when the user clicks on the link, it opens a popup window that shows the submission, record time when it opens and closes.
#Design a database schema for logging the time a reviewer spend on a submission
#Modify Review report (views/review_mapping/_review_report.html.erb) to show the time spent on each submission

=='''Approach'''==
==='''Types of submissions'''===

Based on each submission type, we need to handle the tracking functionalities differently. Generally, the submission links can be one of the following:
#GitHub project/repository link , GitHub Pull requests link or Deployment link
#Youtube videos
#Wikipages
#Text document/doc/pdf/ppt
#Images - png/jpg
#Downloadable contents

==='''Steps'''===
On clicking a submitted link, a new window will pop-up that will keep track of the time spent on that new window. This can be a link to any of the above-mentioned submissions. A possible solution is to embed the submissions (done on an external website) within the peer assessment system itself using e.g., IFrame or Embed tag.
 The following are the steps that will be followed to keep track of the time:
#Start the time when a user clicks on the submitted link (a new window pops-up)
#We'll pause the time in the following cases:
##User idle for more than 30sec
##User switched tabs
##User minimized the window
#Resume time when:
##User switches back to this window
##User performs some activity after being idle
#Time is saved into the database when the user saves, submits review or closes the popped-up window
##If the corresponding entry already exists, the value of the time column is updated otherwise it is created. 
'''Behaviour Diagram''' : 
[[File:Behaviour_diagram.png|center]]

==='''Edge cases'''===

Edge cases that need to be handled :

#What happens when the user refreshes the window : It will set the timer back to 0 and the time spent on that page will be reset.
#What happens when the user downloads the submission: If the user downloads any solution and then opens it in his/her local machine, then the time spent on that can't be tracked.

==='''Database Design'''===
The following table review_submission_timing will be created to implement a solution for this project: 

[[File:Database table review submission timing.png]]

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-11T04:55:33Z

Nsingh9: /* Purpose */

=='''Introduction'''==
==='''Purpose'''===
Expertiza provides the functionality of peer reviews. The best advantage of peer review for the students is that it allows them to learn from each other work.
#It provides a dual benefit for both the reviewer and the writer as they are introduced a different set of eyes on the code
#This can expose edge cases that you hadn't thought of or invalid logic
#It helps instructors review a project faster
#It emphasizes the importance of writing in such a way that it's easy for the third person to read and understand
In order to help them to do this, we have to be able to track the time that students spend observing the other's work. Unfortunately, most peer assessment systems do not manage the content of students’ submission within the systems. They usually allow the authors submit external links to the submission, which makes it difficult for the system to track the time that the reviewers spend on the submissions. The purpose of the project is to be able to successfully track the time that each student spends on peer reviewing the work.

==='''What needs to be done'''===
#Design and implement a solution that handles the use case, where students’ submissions are hosted on an external website e.g. GitHub and Youtube use cases
#Modify the reviewer interface in expertiza to accommodate your solution e.g., change the link that opens submitted files in views/response/_submitted_files.html.erb so that when the user clicks on the link, it opens a popup window that shows the submission, record time when it opens and closes.
#Design a database schema for logging the time a reviewer spend on a submission
#Modify Review report (views/review_mapping/_review_report.html.erb) to show the time spent on each submission

=='''Approach'''==
==='''Types of submissions'''===

Based on each submission type, we need to handle the tracking functionalities differently. Generally, the submission links can be one of the following:
#GitHub project/repository link , GitHub Pull requests link or Deployment link
#Youtube videos
#Wikipages
#Text document/doc/pdf/ppt
#Images - png/jpg
#Downloadable contents

==='''Steps'''===
On clicking a submitted link, a new window will pop-up that will keep track of the time spent on that new window. This can be a link to any of the above-mentioned submissions. A possible solution is to embed the submissions (done on an external website) within the peer assessment system itself using e.g., IFrame or Embed tag.
 The following are the steps that will be followed to keep track of the time:
#Start the time when a user clicks on the submitted link (a new window pops-up)
#We'll pause the time in the following cases:
##User idle for more than 30sec
##User switched tabs
##User minimized the window
#Resume time when:
##User switches back to this window
##User performs some activity after being idle
#Time is saved into the database when the user saves, submits review or closes the popped-up window
##If the corresponding entry already exists, the value of the time column is updated otherwise it is created. 
'''Behaviour Diagram''' : 
[[File:Behaviour_diagram.png|center]]

==='''Edge cases'''===

Edge cases that need to be handled :

#What happens when the user refreshes the window : It will set the timer back to 0 and the time spent on that page will be reset.
#What happens when the user downloads the submission: If the user downloads any solution and then opens it in his/her local machine, then the time spent on that can't be tracked.

==='''Database Design'''===
The following table review_submission_timing will be created to implement a solution for this project: 

[[File:Database table review submission timing.png]]

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-09T01:36:48Z

Nsingh9: /* Steps */

=='''Introduction'''==
==='''Purpose'''===
Expertiza provides the functionality of peer reviews. The best advantage of peer review for the students is that it allows them to learn from each other work. In order to help them to do this, we have to be able to track the time that students spend observing the other's work. Unfortunately, most peer assessment systems do not manage the content of students’ submission within the systems. They usually allow the authors submit external links to the submission, which makes it difficult for the system to track the time that the reviewers spend on the submissions. The purpose of the project is to be able to successfully track the time that each student spends on peer reviewing the work.

==='''What needs to be done'''===
#Design a database schema for logging the time a reviewer spend on a submission
#Design and implement a solution that handles the use case, where students’ submissions are hosted on an external website e.g.,
#Modify the reviewer interface in expertiza to accommodate your solution e.g., change the link that opens submitted files in views/response/_submitted_files.html.erb so that when the user clicks on the link, it opens a popup window that shows the submission, record time when it opens and closes.
#Design and implement a solution that handles GitHub and Youtube use cases
#Modify Review report (views/review_mapping/_review_report.html.erb) to show the time spent on each submission

=='''Approach'''==
==='''Types of submissions'''===

Based on each submission type, we need to handle the tracking functionalities differently. Generally, the submission links can be one of the following:
#GitHub project/repository link , GitHub Pull requests link or Deployment link
#Youtube videos
#Wikipages
#Text document/doc/pdf/ppt
#Images - png/jpg
#Downloadable contents

==='''Steps'''===
On clicking a submitted link, a new window will pop-up that will keep track of the time spent on that new window. This can be a link to any of the above-mentioned submissions. Another approach of using an iframe, as mentioned in the design documents, was thought of but the non-user-friendly appearance of having to scroll through it in all directions to view the page properly was the primary reason for dropping it. The following are the steps that will be followed to keep track of the time:
#Start the time when a user clicks on the submitted link (a new window pops-up)
#We'll pause the time in the following cases:
##User idle for more than 30sec
##User switched tabs
##User minimized the window
#Resume time when:
##User switches back to this window
##User performs some activity after being idle
#Time is saved into the database when the user saves, submits or closes the popped-up window
##If the corresponding entry already exists, the value of the time column is updated otherwise it is created

==='''Edge cases'''===

Edge cases that need to be handled :

#What happens when the user refreshes the window : It will set the timer back to 0 and the time spent on that page will be reset.
#What happens when the user downloads the submission: If the user downloads any solution and then opens it in his/her local machine, then the time spent on that can't be tracked.

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-09T00:50:33Z

Nsingh9:

=='''Introduction'''==
==='''Purpose'''===
Expertiza provides the functionality of peer reviews. The best advantage of peer review for the students is that it allows them to learn from each other work. In order to help them to do this, we have to be able to track the time that students spend observing the other's work. Unfortunately, most peer assessment systems do not manage the content of students’ submission within the systems. They usually allow the authors submit external links to the submission, which makes it difficult for the system to track the time that the reviewers spend on the submissions. The purpose of the project is to be able to successfully track the time that each student spends on peer reviewing the work.

==='''What needs to be done'''===
#Design a database schema for logging the time a reviewer spend on a submission
#Design and implement a solution that handles the use case, where students’ submissions are hosted on an external website e.g.,
#Modify the reviewer interface in expertiza to accommodate your solution e.g., change the link that opens submitted files in views/response/_submitted_files.html.erb so that when the user clicks on the link, it opens a popup window that shows the submission, record time when it opens and closes.
#Design and implement a solution that handles GitHub and Youtube use cases
#Modify Review report (views/review_mapping/_review_report.html.erb) to show the time spent on each submission

=='''Approach'''==
==='''Types of submissions'''===

Based on each submission type, we need to handle the tracking functionalities differently. Generally, the submission links can be one of the following:
#GitHub project/repository link , GitHub Pull requests link or Deployment link
#Youtube videos
#Wikipages
#Text document/doc/pdf/ppt
#Images - png/jpg
#Downloadable contents

==='''Steps'''===
On clicking a submitted link, a new window will pop-up that will keep track of the time spent on that new window. This can be a link to any of the above-mentioned submissions. Another approach of using an iframe, as mentioned in the design documents, was thought of but the non-user-friendly appearance of having to scroll through it in all directions to view the page properly was the primary reason for dropping it. The following are the steps that will be followed to keep track of the time:
#Start the time when a user clicks on the submitted link (a new window pops-up)
#We'll pause the time in the following cases:
##User idle for more than 30sec
##User switched tabs
##User minimized the window
#Resume time when:
##User switches back to this window
##User performs some activity after being idle
#Stop the time when the user closes the window or submits

==='''Edge cases'''===

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-09T00:45:13Z

Nsingh9:

=='''Introduction'''==
==='''Purpose'''===
Expertiza provides the functionality of peer reviews. The best advantage of peer review for the students is that it allows them to learn from each other work. In order to help them to do this, we have to be able to track the time that students spend observing the other's work. Unfortunately, most peer assessment systems do not manage the content of students’ submission within the systems. They usually allow the authors submit external links to the submission, which makes it difficult for the system to track the time that the reviewers spend on the submissions. The purpose of the project is to be able to successfully track the time that each student spends on peer reviewing the work.

==='''What needs to be done'''===
#Design a database schema for logging the time a reviewer spend on a submission
#Design and implement a solution that handles the use case, where students’ submissions are hosted on an external website e.g.,
#Modify the reviewer interface in expertiza to accommodate your solution e.g., change the link that open submitted files in views/response/_submitted_files.html.erb so that when the user click on the link, it opens a popup window that shows the submission, record time when it opens and closes.
#Design and implement a solution that handle GitHub and Youtube use cases
#Modify Review report (views/review_mapping/_review_report.html.erb) to show the time spent on each submission

=='''Approach'''==
==='''Types of submissions'''===

Based on each submission type, we need to handle the tracking functionalities differently. Generally, the submission links can be one of the following:
#GitHub project/repository link , GitHub Pull requests link or Deployment link
#Youtube videos
#Wikipages
#Text document/doc/pdf/ppt
#Images - png/jpg
#Downloadable contents

==='''Steps'''===
On clicking a submitted link, a new window will pop-up that will keep track of the time spent on that new window. This can be a link to any of the above mentioned submissions. Another approach of using an iframe, as mentioned in the design documents, was thought of but the non-user-friendly appearance of having to scroll through it in all directions to view the page properly was primary reason of dropping it. The following are the steps that will be followed to keep track of the time:
#Start the time when a user clicks on the submitted link (a new window pops-up)
#We'll pause the time in the following cases:
##User idle for more than 30sec
##User switched tabs
##User minimized the window

==='''Edge cases'''===

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-09T00:29:24Z

Nsingh9:

=='''Introduction'''==
==='''Purpose'''===
Expertiza provides the functionality of peer reviews. The best advantage of peer review for the students is that it allows them to learn from each other work. In order to help them to do this, we have to be able to track the time that students spend observing the other's work. Unfortunately, most peer assessment systems do not manage the content of students’ submission within the systems. They usually allow the authors submit external links to the submission, which makes it difficult for the system to track the time that the reviewers spend on the submissions. The purpose of the project is to be able to successfully track the time that each student spends on peer reviewing the work.

==='''What needs to be done'''===
#Design a database schema for logging the time a reviewer spend on a submission
#Design and implement a solution that handles the use case, where students’ submissions are hosted on an external website e.g.,
#Modify the reviewer interface in expertiza to accommodate your solution e.g., change the link that open submitted files in views/response/_submitted_files.html.erb so that when the user click on the link, it opens a popup window that shows the submission, record time when it opens and closes.
#Design and implement a solution that handle GitHub and Youtube use cases
#Modify Review report (views/review_mapping/_review_report.html.erb) to show the time spent on each submission

=='''Approach'''==
==='''Types of submissions'''===
==='''Steps'''===
==='''Edge cases'''===

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-09T00:23:27Z

Nsingh9:

=='''Introduction'''==
==='''Purpose'''===
Expertiza provides the functionality of peer reviews. The best advantage of peer review for the students is that it allows them to learn from each other work. In order to help them to do this, we have to be able to track the time that students spend observing the other's work. Unfortunately, most peer assessment systems do not manage the content of students’ submission within the systems. They usually allow the authors submit external links to the submission, which makes it difficult for the system to track the time that the reviewers spend on the submissions. The purpose of the project is to be able to successfully track the time that each student spends on peer reviewing the work.

==='''What needs to be done'''===
#Design a database schema for logging the time a reviewer spend on a submission
#Design and implement a solution that handles the use case, where students’ submissions are hosted on an external website e.g.,
#Modify the reviewer interface in expertiza to accommodate your solution e.g., change the link that open submitted files in views/response/_submitted_files.html.erb so that when the user click on the link, it opens a popup window that shows the submission, record time when it opens and closes.
#Design and implement a solution that handle GitHub and Youtube use cases
#Modify Review report (views/review_mapping/_review_report.html.erb) to show the time spent on each submission

=='''Approach'''==

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-08T23:07:06Z

Nsingh9: /* Introduction */

=='''Introduction'''==
==='''Purpose'''===
Expertiza provides the functionality of peer reviews. The best advantage of peer review for the students is that it allows them to learn from each other work. In order to help them to do this, we have to be able to track the time that students spend observing the other's work. Unfortunately, most peer assessment systems do not manage the content of students’ submission within the systems. They usually allow the authors submit external links to the submission, which makes it difficult for the system to track the time that the reviewers spend on the submissions. The purpose of the project is to be able to successfully track the time that each student spends on peer reviewing the work.

==='''What needs to be done'''===
#Design a database schema for logging the time a reviewer spend on a submission
#Design and implement a solution that handles the use case, where students’ submissions are hosted on an external website e.g.,
#Modify the reviewer interface in expertiza to accommodate your solution e.g., change the link that open submitted files in views/response/_submitted_files.html.erb so that when the user click on the link, it opens a popup window that shows the submission, record time when it opens and closes.
#Design and implement a solution that handle GitHub and Youtube use cases
#Modify Review report (views/review_mapping/_review_report.html.erb) to show the time spent on each submission

CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions

2016-11-08T23:06:48Z

Nsingh9: Created page with "=='''Introduction'''== ==='''Purpose'''=== Expertiza provides the functionality of peer reviews. The best advantage of peer review for the students is that it allows them to lear..."

=='''Introduction'''==
==='''Purpose'''===
Expertiza provides the functionality of peer reviews. The best advantage of peer review for the students is that it allows them to learn from each other work. In order to help them to do this, we have to be able to track the time that students spend observing the other's work. Unfortunately, most peer assessment systems do not manage the content of students’ submission within the systems. They usually allow the authors submit external links to the submission, which makes it difficult for the system to track the time that the reviewers spend on the submissions. The purpose of the project is to be able to successfully track the time that each student spends on peer reviewing the work.

==='What needs to be done'''===
#Design a database schema for logging the time a reviewer spend on a submission
#Design and implement a solution that handles the use case, where students’ submissions are hosted on an external website e.g.,
#Modify the reviewer interface in expertiza to accommodate your solution e.g., change the link that open submitted files in views/response/_submitted_files.html.erb so that when the user click on the link, it opens a popup window that shows the submission, record time when it opens and closes.
#Design and implement a solution that handle GitHub and Youtube use cases
#Modify Review report (views/review_mapping/_review_report.html.erb) to show the time spent on each submission

CSC/ECE 517 Fall 2016

2016-11-08T22:51:33Z

Nsingh9: /* Final Project Design Document */

[http://www.example.com link title]==Calibration Assignment Submissions==
*[[Calibration Assignment Submission (Firebrick JS)]]
*[[Calibration Assignment Submission (Active Job)]]
==Writing Assignments 2==
*[[CSC/ECE 517 Fall 2016/E1666. Test team functionality]]
*[[CSC/ECE 517 Fall 2016/E1643. Refactor Suggestion controller]]
*[[CSC/ECE 517 Fall 2016/E1631. Refactoring Bidding Interface]]
*[[CSC/ECE 517 Fall 2016/E1674.Refactor leaderboard.rb and write unit tests]]
*[[CSC/ECE 517 Fall 2016/E1671. Unit Tests for participants.rb Hierarchy]]
*[[CSC/ECE 517 Fall 2016/E1668.Test e-mailing functionality]]
*[[CSC/ECE 517 Fall 2016/E1658. Refractor lottery_controller.rb and write integration tests]]
*[[CSC/ECE 517 Fall 2016/E1660. Review requirements and thresholds]]
*[[CSC/ECE 517 Fall 2016/E1650. Sort instructor views alphabetically by default]]
*[[CSC/ECE 517 Fall 2016/E1644. Refactor and test Teams Controller]]
*[[CSC/ECE 517 Fall 2016/E1645. Refactoring Tree Display Controller]]
*[[CSC/ECE 517 Fall 2016/E1659. Refactor on_the_fly_calc.rb]]
*[[CSC/ECE 517 Fall 2016/E1657. Introduce a Student View for instructors]]
*[[CSC/ECE 517 Fall 2016/E1653. Fix and improve rubric criteria]]
*[[CSC/ECE 517 Fall 2016/E1642. Refactor review_response_map.rb]]
*[[CSC/ECE 517 Fall 2016/E1633. Refactor different question types from quiz feature]]
*[[CSC/ECE_517_Fall_2016/E1664:_Feature_Test_Assignment_Creation]]
*[[CSC/ECE 517 Fall 2016/E1666. Test team functionality]]
*[[CSC/ECE_517_Fall_2016/E1654. Improve_date-picker_and_deadlines]]
*[[CSC/ECE_517_Fall_2016/E1652 Fix teammate advertisements and requests to join a team ]]
*[[CSC/ECE_517_Fall_2016/E1662. UI issues/fixes]]
*[[CSC/ECE_517_Fall_2016/E1673. Refactor question_type.rb]]
*[[CSC/ECE_517_Fall_2016/E1675. Timestamp for student file & hyperlink submissions]]
*[[CSC/ECE_517_Fall_2016/E1640. Refactor response.rb and response_helper.rb]]
*[[CSC/ECE 517 Fall 2016/E1634. Refactor and write unit test of due_date.rb and deadline_helper.rb]]
*[[CSC/ECE_517_Fall_2016/M1654._Improve_network_security_features]]
*[[CSC/ECE_517_Fall_2016/E1670._Unit_tests_for_answers.rb]]
*[[CSC/ECE_517_Fall_2016/E1641. Refactor review_mapping_controller.rb]]
*[[CSC/ECE_517_Fall_2016/M1652_Implement_ImageMap_Support_Servo]]
*[[CSC/ECE_517_Fall_2016/E1648/Add_past_due_assignment]]
*[[CSC/ECE 517 Fall 2016/E1656. Improve imports]]
*[[CSC/ECE_517_Fall_2016/M1653_Implement_HTML_form_validation]]
==Final Project Design Document==
*[[CSC/ECE 517 Fall 2016 E1696 Improve Self-Review]]
*[[CSC/ECE 517 Fall 2016 E1676 Role-based reviewing]]
*[[CSC/ECE 517 Fall 2016/E1680. Improve survey functionality]]
*[[CSC/ECE 517 Fall 2016/E1693. Drag-and-drop interface for creating rubrics]]
*[[CSC/ECE 517 Fall 2016/E1701. Accelerate RSpec testing]]
*[[CSC/ECE 517 Fall 2016/E1705. Tracking the time students look at the others' submissions]]

CSC/ECE 517 Fall 2016/E1653. Fix and improve rubric criteria

2016-11-08T02:35:40Z

Nsingh9: /* To Test if a user is able to Import/Export CSV files */

==E1653. Fix and Improve Rubric Criteria==

__TOC__

===Expertiza background===

[http://expertiza.ncsu.edu/ Expertiza] is an open source web application based on [http://rubyonrails.org/ Ruby on Rails] framework. This application facilitates submission and peer review of assignments and team projects. Students can upload their assignments and URLs linked to their work on expertiza which can be reviewed by the instructor and peer reviewed by other students. Expertiza also expedites the process of selecting/assigning topics and choosing team mates for team projects. Instructors can also create and customize assignments for students and create review rubrics which are used by students for peer reviewing others' work.

===Tasks identified===
* Change allow_action? method of questionnaires controller to restrict unauthorized access to edit review rubrics. Only those Instructors who own the rubric or their Teaching Assistants should be allowed edit them.
* Display an error message when a user who is not the owner of a questionnaire attempts to edit it and redirect him back to the page he came from.
*Fix the working of import and export methods(dumping and loading criterion) in the Questionnaire controller.
*Perform feature testing for the import and export methods of questionnaire controller.
*Remove old and unused code related to rubric import and export.
*Write feature tests for criterion advice.

===Link to deployed application===
*http://152.46.16.205:3000/

===Modified/Created files===
*questionnaires_controller.rb
*QuestionnaireHelper.rb
*Questionnaire.rb
*questionnaire_spec.rb
*spec/features/import_export_csv_oss/ (New folder created containing 3 test files)

===Summary of implementation===
====New functionality====
* An instructor can no longer change others' review rubrics but can only view them. If he attempts to do so, an error message will be displayed and he will be redirected back.
* Only those review rubrics can be modified by an instructor which are owned by him.
* A Teaching Assistant can modify only those review rubrics which are owned by the instructor under whom he works.
* A CSV file containing the questions with the correct column names can now be imported into the rubric.
* A rubric can also be exported in CSV format to a destination path on our local system.

====Changes in source code====
1. Changes in allow_action? method of the Questionnaires controller.

The action_allow? method earlier provided access to all users to modify or view any review rubric.
<pre>
# Source code before implementation.
def action_allowed?

['Super-Administrator',
'Administrator',
'Instructor',
'Teaching Assistant', 'Student'].include? current_role_name

end
</pre>
The action_allow? method now provides access to modify a rubric to those instructors who own the rubric or the Teaching Assistants who work under them. However, any user can view the contents of the review rubric.
<pre>
# Source code after implementation.
def action_allowed?
case params[:action]
when 'edit', 'update', 'delete', 'toggle_access'
#Modifications can only be done by papertrail
q= Questionnaire.find_by(id:params[:id])
owner_inst_id = q.instructor_id
if(current_user.role_id==6) #To identify teaching assistant
current_ta = current_user;
end
owner_flag= (current_user.id == owner_inst_id)

if(!current_ta.nil?)
owner_flag = (owner_flag or (current_ta.parent_id == owner_inst_id))
end
return owner_flag

else
#Allow all others
['Super-Administrator',
'Administrator',
'Instructor',
'Teaching Assistant',
'Student'].include? current_role_name
end

end
</pre>
2.
a. Modification of import method declared in the questionnaires controller.

The code initially was not using the read method to read the file data and was unable to import a file.
<pre>
#Source code before implementation
def import

@questionnaire = Questionnaire.find(params[:id])
file = params['csv']
@questionnaire.questions << QuestionnaireHelper.get_questions_from_csv(@questionnaire, file)
end
</pre>
The modified code now reads data from the file and calls the method get_questions_from_csv and passes the data to it. The method reads data in rows and saves each row as a question. It then saves each question.
<pre>
#Source code after implementation
def import
questionnaire_id = (params[:id])
begin
uploaded_io = params[:csv]
File.open(Rails.root.join('spec', 'features/import_export_csv_oss/', uploaded_io.original_filename), 'wb') do |file|
file.write(uploaded_io.read)
end
file_data = File.read(Rails.root.join('spec/features/import_export_csv_oss/'+uploaded_io.original_filename))
a = QuestionnaireHelper.get_questions_from_csv(file_data,params[:id])
redirect_to edit_questionnaire_path(questionnaire_id.to_sym), notice: "All questions have been successfully imported!"
rescue
redirect_to edit_questionnaire_path(questionnaire_id.to_sym), notice: $ERROR_INFO
end
end
</pre>

b. Removing unwanted code and modifying the get_questions_from_csv method declared in the questionnaire controller.

The method get_questions_from_csv defined in the questionnaire helper was unable to read data from the file.
<pre>
#Source code before implementation
def self.get_questions_from_csv(questionnaire, file)
questions = []
custom_rubric = questionnaire.section == "Custom"
CSV::Reader.parse(file) do |row|
unless row.empty?
i = 0
score = questionnaire.max_question_score
q = Question.new
q_type = QuestionType.new if custom_rubric
q.true_false = false
row.each do |cell|
case i
when CSV_QUESTION
q.txt = cell.strip unless cell.nil?
when CSV_TYPE
unless cell.nil?
q.true_false = cell.downcase.strip == Question::TRUE_FALSE.downcase
q_type.q_type = cell.strip if custom_rubric
end
when CSV_PARAM
if custom_rubric
q_type.parameters = cell.strip if cell
end
when CSV_WEIGHT
q.weight = cell.strip.to_i if cell
else
if score >= questionnaire.min_question_score and !cell.nil?
a = QuestionAdvice.new(score: score, advice: cell.strip) if custom_rubric
a = QuestionAdvice.new(score: questionnaire.min_question_score + i - 4, advice: cell.strip)
score -= 1
q.question_advices << a
end
end
i += 1
end
q.save
q_type.question = q if custom_rubric
q_type.save if custom_rubric
questions << q
end
end
questions
end
</pre>
The unwanted code from the get_questions_from_csv method is now removed and the modified code successfully reads data from the csv file and saves questions present in the from of rows in the rubric.
<pre>
#Source code after implementation
def self.get_questions_from_csv(file_data,id)
CSV.parse(file_data, headers: true) do |row|
questions_hash = row.to_hash
ques = Question.new(questions_hash)
ques.questionnaire_id=id
ques.save

end # end CSV.parse
end
</pre>
3. Removing dysfunctional code from the QuestionnaireHelper and adding a new method in questionnaire.rb model

The create_questionnaire_csv method was not functional and was removed from the QuestionnaireHelper
<pre>
def self.create_questionnaire_csv(questionnaire, _user_name)
csv_data = CSV.generate do |csv|
for question in questionnaire.questions
# Each row is formatted as follows
# Question, question advice (from high score to low), type, weight
row = []
row << question.txt
row << question.type

row << question.alternatives || ''
row << question.size || ''

row << question.weight

# if questionnaire.section == "Custom"
# row << QuestionType.find_by_question_id(question.id).parameters
# else
# row << ""
# end

# loop through all the question advice from highest score to lowest score
adjust_advice_size(questionnaire, question)
for advice in question.question_advices.sort {|x, y| y.score <=> x.score }
row << advice.advice
end

csv << row
end
end

csv_data
end
</pre>
The to_csv function was added in the questionnaire.rb model class which generates a CSV out of the data in the question table which can then be exported to a local machine.
<pre>
def to_csv(ques)
questions = ques
csv_data = CSV.generate do |csv|
row = ['seq','txt','type','weight','size','max_label','min_label','alternatives']
csv << row
for question in questions
row = []
row << question.seq
row << question.txt
row << question.type
row << question.weight
row << question.size || ''
row << question.max_label
row << question.min_label
row << question.alternatives

csv << row

end
end
end
</pre>

===Testing using RSpec===

A set of feature tests using the RSpec framework have been added to test the implemented functionalities. Test data from spec/features/import_export_csv_oss/ was used to run the test cases.

1. The file to be uploaded should not be an empty file. The following test case checks if the imported file is empty.
<pre>
describe 'Import questions from CSV' do

it 'should not be an empty file', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot.csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).not_to have_content('No such file')
end
</pre>

2.The following test case validates an imported CSV file. The test case passes if all the questions get successfully imported.
<pre>
it 'should be a valid CSV file', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot.csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).to have_content('All questions have been successfully imported!')

end
</pre>

3. The following test case validates the names of all columns in the imported CSV file. The following example shows that this test case passes when there's an error in the column name of the imported file. If we change this test file with the one in the above two cases, and change expect().to to expect().not_to, we can see that it does exactly what we require it to.
<pre>
it 'should have valid column names', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot (propername).csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).to have_content('unknown attribute')
end
</pre>
4. The following test case validates that no error message appears on the page while exporting.

<pre>
it 'should not display an error flash message while exporting', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
click_button "Export questions to CSV"
expect(page).not_to have_content('error')
end

end
</pre>
5.The following test case validates if a user is able to edit an advice.
<pre>
scenario 'clicks on edit advice', js: true do

#login_as("instructor6")
visit '/advice/edit_advice/1'

expect(page).to have_content("Edit an existing questionnaire's advice")
end
</pre>
6. The following test case validates that the changes made in the advice page are re-displayed.
<pre>
scenario 'reloads page successfully', js: true do

#login_as("instructor6")
visit '/questionnaires/1/edit'
click_on 'Add'
visit '/advice/edit_advice/1'
click_on 'Save and redisplay advice'
expect(page).to have_content("The advice was successfully saved!")
expect(page).to have_content("Edit an existing questionnaire's advice")

#expect(flash[:notice]).to match "The advice was successfully saved"
end
</pre>
7.The following test case validates if a user is redirected to the edit advice page after clicking on the 'Edit/View advice' button
<pre>
scenario 'redirects from questionnaire to advice', js: true do
visit '/questionnaires/1/edit'
click_on 'Edit/View advice'
expect(page).to have_content("Edit an existing questionnaire's advice")
#expect(AdviceController.save_advice).to be(true)
end

</pre>
8.The following test case validates if the changes made in the edit_advice page are saved to the database after the 'Save and redisplay advice' button is clicked.
<pre>
scenario 'saves content', js: true do
visit '/questionnaires/1/edit'
click_on 'Add'
visit '/advice/edit_advice/1'
fill_in "horizontal_1_advice" , with: "Example"
click_on 'Save and redisplay advice'
expect(QuestionAdvice.where(id: 1, advice:"Example")).not_to be_empty
end

end
</pre>

===Testing on UI===
====To Test only if an Instructor who owns the rubric or his TA can edit the rubric====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6 (This can be found out from the expertiza_development database using query: select name from questionnaires where instructor_id=6;)
#User should be redirected to a page where he can edit the questionnaire
#Impersonate 'teaching_assistant520' (is a TA under instructor6) and repeat steps 2-5
#User should be redirected to a page where he can edit the questionnaire
#Repeat the above steps for a questionnaire which is not owned by the instructor
#An error message is displayed above the 'Manage Content' title

====To Test if a user is able to Import/Export CSV files====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on 'Browse' button under 'Import/Export (from/to CSV format)' and select a file of CSV format which contains the questions
#Click on 'Import from CSV' button. The questions in the files should be saved into the questionnaire
##This can invite future research into the area, since currently, it allows the duplicated sequence number code to be added
#Click on 'Export questions to CSV'. The questions should be saved to the local system in a file of CSV format

====To test if a user is able to edit advice for a questionnaire====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content.
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on edit advice button. This should redirect to a page containing the advice for that questionnaire

====To test if a user is able to save edited advice for a questionnaire====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on 'save and redisplay' button. This should reload the same page with the edited advice

CSC/ECE 517 Fall 2016/E1653. Fix and improve rubric criteria

2016-11-04T03:59:17Z

Nsingh9: /* Changes in source code */

==E1653. Fix and Improve Rubric Criteria==

__TOC__

===Expertiza background===

[http://expertiza.ncsu.edu/ Expertiza] is an open source web application based on [http://rubyonrails.org/ Ruby on Rails] framework. This application facilitates submission and peer review of assignments and team projects. Students can upload their assignments and URLs linked to their work on expertiza which can be reviewed by the instructor and peer reviewed by other students. Expertiza also expedites the process of selecting/assigning topics and choosing team mates for team projects. Instructors can also create and customize assignments for students and create review rubrics which are used by students for peer reviewing others' work.

===Tasks identified===
* Change allow_action? method of questionnaires controller to restrict unauthorized access to edit review rubrics. Only those Instructors who own the rubric or their Teaching Assistants should be allowed edit them.
* Display an error message when a user who is not the owner of a questionnaire attempts to edit it and redirect him back to the page he came from.
*Fix the working of import and export methods(dumping and loading criterion) in the Questionnaire controller.
*Perform feature testing for the import and export methods of questionnaire controller.
*Remove old and unused code related to rubric import and export.
*Write feature tests for criterion advice.

===Modified/Created files===
*questionnaires_controller.rb
*QuestionnaireHelper.rb
*Questionnaire.rb
*questionnaire_spec.rb
*spec/features/import_export_csv_oss/ (New folder created containing 3 test files)

===Summary of implementation===
====New functionality====
* An instructor can no longer change others' review rubrics but can only view them. If he attempts to do so, an error message will be displayed and he will be redirected back.
* Only those review rubrics can be modified by an instructor which are owned by him.
* A Teaching Assistant can modify only those review rubrics which are owned by the instructor under whom he works.
* A CSV file containing the questions with the correct column names can now be imported into the rubric.
* A rubric can also be exported in CSV format to a destination path on our local system.

====Changes in source code====
1. Changes in allow_action? method of the Questionnaires controller.

The action_allow? method earlier provided access to all users to modify or view any review rubric.
<pre>
# Source code before implementation.
def action_allowed?

['Super-Administrator',
'Administrator',
'Instructor',
'Teaching Assistant', 'Student'].include? current_role_name

end
</pre>
The action_allow? method now provides access to modify a rubric to those instructors who own the rubric or the Teaching Assistants who work under them. However, any user can view the contents of the review rubric.
<pre>
# Source code after implementation.
def action_allowed?

case params[:action]
when 'edit', 'update', 'delete', 'toggle_access'
#Modifications can only be done by papertrail
q= Questionnaire.find_by(id:params[:id])
owner_inst_id = q.instructor_id
if(current_user.role_id==6) #Identifying if the current user is a Teaching Assistant
current_ta = current_user;
end
b= (current_user.id == owner_inst_id)
if(!current_ta.nil?)
b = b or (current_ta.parent_id == owner_inst_id)
end
return b

else
#Allow all others
['Super-Administrator',
'Administrator',
'Instructor',
'Teaching Assistant',
'Student'].include? current_role_name
end

end
</pre>
2.
a. Modification of import method declared in the questionnaires controller.

The code initially was not using the read method to read the file data and was unable to import a file.
<pre>
#Source code before implementation
def import

@questionnaire = Questionnaire.find(params[:id])
file = params['csv']
@questionnaire.questions << QuestionnaireHelper.get_questions_from_csv(@questionnaire, file)
end
</pre>
The modified code now reads data from the file and calls the method get_questions_from_csv and passes the data to it. The method reads data in rows and saves each row as a question. It then saves each question.
<pre>
#Source code after implementation
def import

# The following code uploads the file and saves it the given directory from where it can be read. This way, when deployed, any user can upload a file from his local machine
uploaded_io = params[:csv]
File.open(Rails.root.join('spec', 'features/import_export_csv_oss/', uploaded_io.original_filename), 'wb') do |file|
file.write(uploaded_io.read)
end
#The following code reads and imports the saved file
questionnaire_id = (params[:id])
begin
file_data = File.read(Rails.root.join('spec/features/import_export_csv_oss/'+params[:csv]))
QuestionnaireHelper.get_questions_from_csv(file_data,params[:id])
#Questionnaire.import(file_data)

redirect_to edit_questionnaire_path(questionnaire_id.to_sym), notice: "All questions have been successfully imported!"
rescue
redirect_to edit_questionnaire_path(questionnaire_id.to_sym), notice: $ERROR_INFO
end
end
</pre>

b. Removing unwanted code and modifying the get_questions_from_csv method declared in the questionnaire controller.

The method get_questions_from_csv defined in the questionnaire helper was unable to read data from the file.
<pre>
#Source code before implementation
def self.get_questions_from_csv(questionnaire, file)
questions = []
custom_rubric = questionnaire.section == "Custom"
CSV::Reader.parse(file) do |row|
unless row.empty?
i = 0
score = questionnaire.max_question_score
q = Question.new
q_type = QuestionType.new if custom_rubric
q.true_false = false
row.each do |cell|
case i
when CSV_QUESTION
q.txt = cell.strip unless cell.nil?
when CSV_TYPE
unless cell.nil?
q.true_false = cell.downcase.strip == Question::TRUE_FALSE.downcase
q_type.q_type = cell.strip if custom_rubric
end
when CSV_PARAM
if custom_rubric
q_type.parameters = cell.strip if cell
end
when CSV_WEIGHT
q.weight = cell.strip.to_i if cell
else
if score >= questionnaire.min_question_score and !cell.nil?
a = QuestionAdvice.new(score: score, advice: cell.strip) if custom_rubric
a = QuestionAdvice.new(score: questionnaire.min_question_score + i - 4, advice: cell.strip)
score -= 1
q.question_advices << a
end
end
i += 1
end
q.save
q_type.question = q if custom_rubric
q_type.save if custom_rubric
questions << q
end
end
questions
end
</pre>
The unwanted code from the get_questions_from_csv method is now removed and the modified code successfully reads data from the csv file and saves questions present in the from of rows in the rubric.
<pre>
#Source code after implementation
def self.get_questions_from_csv(file_data,id)
CSV.parse(file_data, headers: true) do |row|
# row.each do |cell|
questions_hash = row.to_hash
ques = Question.new(questions_hash)
ques.questionnaire_id=id
ques.save
end # end CSV.parse
end
</pre>
3. Removing dysfunctional code from the QuestionnaireHelper and adding a new method in questionnaire.rb model

The create_questionnaire_csv method was not functional and was removed from the QuestionnaireHelper
<pre>
def self.create_questionnaire_csv(questionnaire, _user_name)
csv_data = CSV.generate do |csv|
for question in questionnaire.questions
# Each row is formatted as follows
# Question, question advice (from high score to low), type, weight
row = []
row << question.txt
row << question.type
row << question.alternatives || ''
row << question.size || ''
row << question.weight

# loop through all the question advice from highest score to lowest score
adjust_advice_size(questionnaire, question)
for advice in question.question_advices.sort {|x, y| y.score <=> x.score }
row << advice.advice
end

csv << row
end
end

csv_data
end
</pre>
The to_csv function was added in the questionnaire.rb model class which generates a CSV out of the data in the question table which can then be exported to a local machine.
<pre>
def to_csv(ques)
questions = ques
csv_data = CSV.generate do |csv|
row = ['seq','txt','type','weight','size','max_label','min_label','alternatives']
csv << row
for question in questions
row = []
row << question.seq
row << question.txt
row << question.type
row << question.weight
row << question.size || ''
row << question.max_label
row << question.min_label
row << question.alternatives

csv << row

end
end
end

</pre>

===Testing using RSpec===

A set of feature tests using the RSpec framework have been added to test the implemented functionalities. Test data from spec/features/import_export_csv_oss/ was used to run the test cases.

1. The file to be uploaded should not be an empty file. The following test case checks if the imported file is empty.
<pre>
describe 'Import questions from CSV' do

it 'should not be an empty file', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot.csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).not_to have_content('No such file')
end
</pre>

2.The following test case validates an imported CSV file. The test case passes if all the questions get successfully imported.
<pre>
it 'should be a valid CSV file', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot.csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).to have_content('All questions have been successfully imported!')

end
</pre>

3. The following test case validates the names of all columns in the imported CSV file. The following example shows that this test case passes when there's an error in the column name of the imported file. If we change this test file with the one in the above two cases, and change expect().to to expect().not_to, we can see that it does exactly what we require it to.
<pre>
it 'should have valid column names', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot (propername).csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).to have_content('unknown attribute')
end
</pre>

===Testing on UI===
====To Test only if an Instructor who owns the rubric or his TA can edit the rubric====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6 (This can be found out from the expertiza_development database using query: select name from questionnaires where instructor_id=6;)
#User should be redirected to a page where he can edit the questionnaire
#Impersonate 'teaching_assistant520' (is a TA under instructor6) and repeat steps 2-5
#User should be redirected to a page where he can edit the questionnaire
#Repeat the above steps for a questionnaire which is not owned by the instructor
#An error message is displayed above the 'Manage Content' title

====To Test if a user is able to Import/Export CSV files====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on 'Browse' button under 'Import/Export (from/to CSV format)' and select a file of CSV format which contains the questions
#Click on 'Import from CSV' button. The questions in the files should be saved into the questionnaire
#Click on 'Export questions to CSV'. The questions should be saved to the local system in a file of CSV format

====To test if a user is able to edit advice for a questionnaire====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content.
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on edit advice button. This should redirect to a page containing the advice for that questionnaire

====To test if a user is able to save edited advice for a questionnaire====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on 'save and redisplay' button. This should reload the same page with the edited advice

CSC/ECE 517 Fall 2016/E1653. Fix and improve rubric criteria

2016-11-04T03:56:25Z

Nsingh9: /* Changes in source code */

==E1653. Fix and Improve Rubric Criteria==

__TOC__

===Expertiza background===

[http://expertiza.ncsu.edu/ Expertiza] is an open source web application based on [http://rubyonrails.org/ Ruby on Rails] framework. This application facilitates submission and peer review of assignments and team projects. Students can upload their assignments and URLs linked to their work on expertiza which can be reviewed by the instructor and peer reviewed by other students. Expertiza also expedites the process of selecting/assigning topics and choosing team mates for team projects. Instructors can also create and customize assignments for students and create review rubrics which are used by students for peer reviewing others' work.

===Tasks identified===
* Change allow_action? method of questionnaires controller to restrict unauthorized access to edit review rubrics. Only those Instructors who own the rubric or their Teaching Assistants should be allowed edit them.
* Display an error message when a user who is not the owner of a questionnaire attempts to edit it and redirect him back to the page he came from.
*Fix the working of import and export methods(dumping and loading criterion) in the Questionnaire controller.
*Perform feature testing for the import and export methods of questionnaire controller.
*Remove old and unused code related to rubric import and export.
*Write feature tests for criterion advice.

===Modified/Created files===
*questionnaires_controller.rb
*QuestionnaireHelper.rb
*Questionnaire.rb
*questionnaire_spec.rb
*spec/features/import_export_csv_oss/ (New folder created containing 3 test files)

===Summary of implementation===
====New functionality====
* An instructor can no longer change others' review rubrics but can only view them. If he attempts to do so, an error message will be displayed and he will be redirected back.
* Only those review rubrics can be modified by an instructor which are owned by him.
* A Teaching Assistant can modify only those review rubrics which are owned by the instructor under whom he works.
* A CSV file containing the questions with the correct column names can now be imported into the rubric.
* A rubric can also be exported in CSV format to a destination path on our local system.

====Changes in source code====
1. Changes in allow_action? method of the Questionnaires controller.

The action_allow? method earlier provided access to all users to modify or view any review rubric.
<pre>
# Source code before implementation.
def action_allowed?

['Super-Administrator',
'Administrator',
'Instructor',
'Teaching Assistant', 'Student'].include? current_role_name

end
</pre>
The action_allow? method now provides access to modify a rubric to those instructors who own the rubric or the Teaching Assistants who work under them. However, any user can view the contents of the review rubric.
<pre>
# Source code after implementation.
def action_allowed?

case params[:action]
when 'edit', 'update', 'delete', 'toggle_access'
#Modifications can only be done by papertrail
q= Questionnaire.find_by(id:params[:id])
owner_inst_id = q.instructor_id
if(current_user.role_id==6) #Identifying if the current user is a Teaching Assistant
current_ta = current_user;
end
b= (current_user.id == owner_inst_id)
if(!current_ta.nil?)
b = b or (current_ta.parent_id == owner_inst_id)
end
return b

else
#Allow all others
['Super-Administrator',
'Administrator',
'Instructor',
'Teaching Assistant',
'Student'].include? current_role_name
end

end
</pre>
2.
a. Modification of import method declared in the questionnaires controller.

The code initially was not using the read method to read the file data and was unable to import a file.
<pre>
#Source code before implementation
def import

uploaded_io = params[:csv]
File.open(Rails.root.join('spec', 'features/import_export_csv_oss/', uploaded_io.original_filename), 'wb') do |file|
file.write(uploaded_io.read)
end
@questionnaire = Questionnaire.find(params[:id])
file = params['csv']
@questionnaire.questions << QuestionnaireHelper.get_questions_from_csv(@questionnaire, file)
end
</pre>
The modified code now reads data from the file and calls the method get_questions_from_csv and passes the data to it. The method reads data in rows and saves each row as a question. It then saves each question.
<pre>
#Source code after implementation
def import

questionnaire_id = (params[:id])
begin
file_data = File.read(Rails.root.join('spec/features/import_export_csv_oss/'+params[:csv]))
QuestionnaireHelper.get_questions_from_csv(file_data,params[:id])
#Questionnaire.import(file_data)

redirect_to edit_questionnaire_path(questionnaire_id.to_sym), notice: "All questions have been successfully imported!"
rescue
redirect_to edit_questionnaire_path(questionnaire_id.to_sym), notice: $ERROR_INFO
end
end
</pre>

b. Removing unwanted code and modifying the get_questions_from_csv method declared in the questionnaire controller.

The method get_questions_from_csv defined in the questionnaire helper was unable to read data from the file.
<pre>
#Source code before implementation
def self.get_questions_from_csv(questionnaire, file)
questions = []
custom_rubric = questionnaire.section == "Custom"
CSV::Reader.parse(file) do |row|
unless row.empty?
i = 0
score = questionnaire.max_question_score
q = Question.new
q_type = QuestionType.new if custom_rubric
q.true_false = false
row.each do |cell|
case i
when CSV_QUESTION
q.txt = cell.strip unless cell.nil?
when CSV_TYPE
unless cell.nil?
q.true_false = cell.downcase.strip == Question::TRUE_FALSE.downcase
q_type.q_type = cell.strip if custom_rubric
end
when CSV_PARAM
if custom_rubric
q_type.parameters = cell.strip if cell
end
when CSV_WEIGHT
q.weight = cell.strip.to_i if cell
else
if score >= questionnaire.min_question_score and !cell.nil?
a = QuestionAdvice.new(score: score, advice: cell.strip) if custom_rubric
a = QuestionAdvice.new(score: questionnaire.min_question_score + i - 4, advice: cell.strip)
score -= 1
q.question_advices << a
end
end
i += 1
end
q.save
q_type.question = q if custom_rubric
q_type.save if custom_rubric
questions << q
end
end
questions
end
</pre>
The unwanted code from the get_questions_from_csv method is now removed and the modified code successfully reads data from the csv file and saves questions present in the from of rows in the rubric.
<pre>
#Source code after implementation
def self.get_questions_from_csv(file_data,id)
CSV.parse(file_data, headers: true) do |row|
# row.each do |cell|
questions_hash = row.to_hash
ques = Question.new(questions_hash)
ques.questionnaire_id=id
ques.save
end # end CSV.parse
end
</pre>
3. Removing dysfunctional code from the QuestionnaireHelper and adding a new method in questionnaire.rb model

The create_questionnaire_csv method was not functional and was removed from the QuestionnaireHelper
<pre>
def self.create_questionnaire_csv(questionnaire, _user_name)
csv_data = CSV.generate do |csv|
for question in questionnaire.questions
# Each row is formatted as follows
# Question, question advice (from high score to low), type, weight
row = []
row << question.txt
row << question.type
row << question.alternatives || ''
row << question.size || ''
row << question.weight

# loop through all the question advice from highest score to lowest score
adjust_advice_size(questionnaire, question)
for advice in question.question_advices.sort {|x, y| y.score <=> x.score }
row << advice.advice
end

csv << row
end
end

csv_data
end
</pre>
The to_csv function was added in the questionnaire.rb model class which generates a CSV out of the data in the question table which can then be exported to a local machine.
<pre>
def to_csv(ques)
questions = ques
csv_data = CSV.generate do |csv|
row = ['seq','txt','type','weight','size','max_label','min_label','alternatives']
csv << row
for question in questions
row = []
row << question.seq
row << question.txt
row << question.type
row << question.weight
row << question.size || ''
row << question.max_label
row << question.min_label
row << question.alternatives

csv << row

end
end
end

</pre>

===Testing using RSpec===

A set of feature tests using the RSpec framework have been added to test the implemented functionalities. Test data from spec/features/import_export_csv_oss/ was used to run the test cases.

1. The file to be uploaded should not be an empty file. The following test case checks if the imported file is empty.
<pre>
describe 'Import questions from CSV' do

it 'should not be an empty file', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot.csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).not_to have_content('No such file')
end
</pre>

2.The following test case validates an imported CSV file. The test case passes if all the questions get successfully imported.
<pre>
it 'should be a valid CSV file', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot.csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).to have_content('All questions have been successfully imported!')

end
</pre>

3. The following test case validates the names of all columns in the imported CSV file. The following example shows that this test case passes when there's an error in the column name of the imported file. If we change this test file with the one in the above two cases, and change expect().to to expect().not_to, we can see that it does exactly what we require it to.
<pre>
it 'should have valid column names', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot (propername).csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).to have_content('unknown attribute')
end
</pre>

===Testing on UI===
====To Test only if an Instructor who owns the rubric or his TA can edit the rubric====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6 (This can be found out from the expertiza_development database using query: select name from questionnaires where instructor_id=6;)
#User should be redirected to a page where he can edit the questionnaire
#Impersonate 'teaching_assistant520' (is a TA under instructor6) and repeat steps 2-5
#User should be redirected to a page where he can edit the questionnaire
#Repeat the above steps for a questionnaire which is not owned by the instructor
#An error message is displayed above the 'Manage Content' title

====To Test if a user is able to Import/Export CSV files====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on 'Browse' button under 'Import/Export (from/to CSV format)' and select a file of CSV format which contains the questions
#Click on 'Import from CSV' button. The questions in the files should be saved into the questionnaire
#Click on 'Export questions to CSV'. The questions should be saved to the local system in a file of CSV format

====To test if a user is able to edit advice for a questionnaire====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content.
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on edit advice button. This should redirect to a page containing the advice for that questionnaire

====To test if a user is able to save edited advice for a questionnaire====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on 'save and redisplay' button. This should reload the same page with the edited advice

CSC/ECE 517 Fall 2016/E1653. Fix and improve rubric criteria

2016-10-31T23:19:34Z

Nsingh9: /* Changes in source code */

==E1653. Fix and Improve Rubric Criteria==

__TOC__

===Expertiza background===

[http://expertiza.ncsu.edu/ Expertiza] is an open source web application based on [http://rubyonrails.org/ Ruby on Rails] framework. This application facilitates submission and peer review of assignments and team projects. Students can upload their assignments and URLs linked to their work on expertiza which can be reviewed by the instructor and peer reviewed by other students. Expertiza also expedites the process of selecting/assigning topics and choosing team mates for team projects. Instructors can also create and customize assignments for students and create review rubrics which are used by students for peer reviewing others' work.

===Tasks identified===
* Change allow_action? method of questionnaires controller to restrict unauthorized access to edit review rubrics. Only those Instructors who own the rubric or their Teaching Assistants should be allowed edit them.
* Display an error message when a user who is not the owner of a questionnaire attempts to edit it and redirect him back to the page he came from.
*Fix the working of import and export methods(dumping and loading criterion) in the Questionnaire controller.
*Perform feature testing for the import and export methods of questionnaire controller.
*Remove old and unused code related to rubric import and export.
*Write feature tests for criterion advice.

===Modified/Created files===
*questionnaires_controller.rb
*QuestionnaireHelper.rb
*Questionnaire.rb
*questionnaire_spec.rb
*spec/features/import_export_csv_oss/ (New folder created containing 3 test files)

===Summary of implementation===
====New functionality====
* An instructor can no longer change others' review rubrics but can only view them. If he attempts to do so, an error message will be displayed and he will be redirected back.
* Only those review rubrics can be modified by an instructor which are owned by him.
* A Teaching Assistant can modify only those review rubrics which are owned by the instructor under whom he works.
* A CSV file containing the questions with the correct column names can now be imported into the rubric.
* A rubric can also be exported in CSV format to a destination path on our local system.

====Changes in source code====
1. Changes in allow_action? method of the Questionnaires controller.

The action_allow? method earlier provided access to all users to modify or view any review rubric.
<pre>
# Source code before implementation.
def action_allowed?

['Super-Administrator',
'Administrator',
'Instructor',
'Teaching Assistant', 'Student'].include? current_role_name

end
</pre>
The action_allow? method now provides access to modify a rubric to those instructors who own the rubric or the Teaching Assistants who work under them. However, any user can view the contents of the review rubric.
<pre>
# Source code after implementation.
def action_allowed?

case params[:action]
when 'edit', 'update', 'delete', 'toggle_access'
#Modifications can only be done by papertrail
q= Questionnaire.find_by(id:params[:id])
owner_inst_id = q.instructor_id
if(current_user.role_id==6) #Identifying if the current user is a Teaching Assistant
current_ta = current_user;
end
b= (current_user.id == owner_inst_id)
if(!current_ta.nil?)
b = b or (current_ta.parent_id == owner_inst_id)
end
return b

else
#Allow all others
['Super-Administrator',
'Administrator',
'Instructor',
'Teaching Assistant',
'Student'].include? current_role_name
end

end
</pre>
2.
a. Modification of import method declared in the questionnaires controller.

The code initially was not using the read method to read the file data and was unable to import a file.
<pre>
#Source code before implementation
def import
@questionnaire = Questionnaire.find(params[:id])
file = params['csv']
@questionnaire.questions << QuestionnaireHelper.get_questions_from_csv(@questionnaire, file)
end
</pre>
The modified code now reads data from the file and calls the method get_questions_from_csv and passes the data to it. The method reads data in rows and saves each row as a question. It then saves each question.
<pre>
#Source code after implementation
def import

questionnaire_id = (params[:id])
begin
file_data = File.read(Rails.root.join('spec/features/import_export_csv_oss/'+params[:csv]))
QuestionnaireHelper.get_questions_from_csv(file_data,params[:id])
#Questionnaire.import(file_data)

redirect_to edit_questionnaire_path(questionnaire_id.to_sym), notice: "All questions have been successfully imported!"
rescue
redirect_to edit_questionnaire_path(questionnaire_id.to_sym), notice: $ERROR_INFO
end
end
</pre>

b. Removing unwanted code and modifying the get_questions_from_csv method declared in the questionnaire controller.

The method get_questions_from_csv defined in the questionnaire helper was unable to read data from the file.
<pre>
#Source code before implementation
def self.get_questions_from_csv(questionnaire, file)
questions = []
custom_rubric = questionnaire.section == "Custom"
CSV::Reader.parse(file) do |row|
unless row.empty?
i = 0
score = questionnaire.max_question_score
q = Question.new
q_type = QuestionType.new if custom_rubric
q.true_false = false
row.each do |cell|
case i
when CSV_QUESTION
q.txt = cell.strip unless cell.nil?
when CSV_TYPE
unless cell.nil?
q.true_false = cell.downcase.strip == Question::TRUE_FALSE.downcase
q_type.q_type = cell.strip if custom_rubric
end
when CSV_PARAM
if custom_rubric
q_type.parameters = cell.strip if cell
end
when CSV_WEIGHT
q.weight = cell.strip.to_i if cell
else
if score >= questionnaire.min_question_score and !cell.nil?
a = QuestionAdvice.new(score: score, advice: cell.strip) if custom_rubric
a = QuestionAdvice.new(score: questionnaire.min_question_score + i - 4, advice: cell.strip)
score -= 1
q.question_advices << a
end
end
i += 1
end
q.save
q_type.question = q if custom_rubric
q_type.save if custom_rubric
questions << q
end
end
questions
end
</pre>
The unwanted code from the get_questions_from_csv method is now removed and the modified code successfully reads data from the csv file and saves questions present in the from of rows in the rubric.
<pre>
#Source code after implementation
def self.get_questions_from_csv(file_data,id)
CSV.parse(file_data, headers: true) do |row|
# row.each do |cell|
questions_hash = row.to_hash
ques = Question.new(questions_hash)
ques.questionnaire_id=id
ques.save
end # end CSV.parse
end
</pre>
3. Removing dysfunctional code from the QuestionnaireHelper and adding a new method in questionnaire.rb model

The create_questionnaire_csv method was not functional and was removed from the QuestionnaireHelper
<pre>
def self.create_questionnaire_csv(questionnaire, _user_name)
csv_data = CSV.generate do |csv|
for question in questionnaire.questions
# Each row is formatted as follows
# Question, question advice (from high score to low), type, weight
row = []
row << question.txt
row << question.type
row << question.alternatives || ''
row << question.size || ''
row << question.weight

# loop through all the question advice from highest score to lowest score
adjust_advice_size(questionnaire, question)
for advice in question.question_advices.sort {|x, y| y.score <=> x.score }
row << advice.advice
end

csv << row
end
end

csv_data
end
</pre>
The to_csv function was added in the questionnaire.rb model class which generates a CSV out of the data in the question table which can then be exported to a local machine.
<pre>
def to_csv(ques)
questions = ques
csv_data = CSV.generate do |csv|
row = ['seq','txt','type','weight','size','max_label','min_label','alternatives']
csv << row
for question in questions
row = []
row << question.seq
row << question.txt
row << question.type
row << question.weight
row << question.size || ''
row << question.max_label
row << question.min_label
row << question.alternatives

csv << row

end
end
end

</pre>

===Testing using RSpec===

A set of feature tests using the RSpec framework have been added to test the implemented functionalities. Test data from spec/features/import_export_csv_oss/ was used to run the test cases.

1. The file to be uploaded should not be an empty file. The following test case checks if the imported file is empty.
<pre>
describe 'Import questions from CSV' do

it 'should not be an empty file', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot.csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).not_to have_content('No such file')
end
</pre>

2.The following test case validates an imported CSV file. The test case passes if all the questions get successfully imported.
<pre>
it 'should be a valid CSV file', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot.csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).to have_content('All questions have been successfully imported!')

end
</pre>

3. The following test case validates the names of all columns in the imported CSV file. The following example shows that this test case passes when there's an error in the column name of the imported file. If we change this test file with the one in the above two cases, and change expect().to to expect().not_to, we can see that it does exactly what we require it to.
<pre>
it 'should have valid column names', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot (propername).csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).to have_content('unknown attribute')
end
</pre>

===Testing on UI===
====To Test only if an Instructor who owns the rubric or his TA can edit the rubric====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6 (This can be found out from the expertiza_development database using query: select name from questionnaires where instructor_id=6;)
#User should be redirected to a page where he can edit the questionnaire
#Impersonate 'teaching_assistant520' (is a TA under instructor6) and repeat steps 2-5
#User should be redirected to a page where he can edit the questionnaire
#Repeat the above steps for a questionnaire which is not owned by the instructor
#An error message is displayed above the 'Manage Content' title

====To Test if a user is able to Import/Export CSV files====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on 'Browse' button under 'Import/Export (from/to CSV format)' and select a file of CSV format which contains the questions
#Click on 'Import from CSV' button. The questions in the files should be saved into the questionnaire
#Click on 'Export questions to CSV'. The questions should be saved to the local system in a file of CSV format

====To test if a user is able to edit advice for a questionnaire====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content.
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on edit advice button. This should redirect to a page containing the advice for that questionnaire

====To test if a user is able to save edited advice for a questionnaire====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on 'save and redisplay' button. This should reload the same page with the edited advice

CSC/ECE 517 Fall 2016/E1653. Fix and improve rubric criteria

2016-10-31T21:21:49Z

Nsingh9: /* Testing on UI */

==E1653. Fix and Improve Rubric Criteria==

__TOC__

===Expertiza background===

[http://expertiza.ncsu.edu/ Expertiza] is an open source web application based on [http://rubyonrails.org/ Ruby on Rails] framework. This application facilitates submission and peer review of assignments and team projects. Students can upload their assignments and URLs linked to their work on expertiza which can be reviewed by the instructor and peer reviewed by other students. Expertiza also expedites the process of selecting/assigning topics and choosing team mates for team projects. Instructors can also create and customize assignments for students and create review rubrics which are used by students for peer reviewing others' work.

===Tasks identified===
* Change allow_action? method of questionnaires controller to restrict unauthorized access to edit review rubrics. Only those Instructors who own the rubric or their Teaching Assistants should be allowed edit them.
* Display an error message when a user who is not the owner of a questionnaire attempts to edit it and redirect him back to the page he came from.
*Fix the working of import and export methods(dumping and loading criterion) in the Questionnaire controller.
*Perform feature testing for the import and export methods of questionnaire controller.
*Remove old and unused code related to rubric import and export.
*Write feature tests for criterion advice.

===Modified/Created files===
*questionnaires_controller.rb
*QuestionnaireHelper.rb
*Questionnaire.rb
*questionnaire_spec.rb
*spec/features/import_export_csv_oss/ (New folder created containing 3 test files)

===Summary of implementation===
====New functionality====
* An instructor can no longer change others' review rubrics but can only view them. If he attempts to do so, an error message will be displayed and he will be redirected back.
* Only those review rubrics can be modified by an instructor which are owned by him.
* A Teaching Assistant can modify only those review rubrics which are owned by the instructor under whom he works.
* A CSV file containing the questions with the correct column names can now be imported into the rubric.
* A rubric can also be exported in CSV format to a destination path on our local system.

====Changes in source code====
1. Changes in allow_action? method of the Questionnaires controller.

The action_allow? method earlier provided access to all users to modify or view any review rubric.
<pre>
# Source code before implementation.
def action_allowed?

['Super-Administrator',
'Administrator',
'Instructor',
'Teaching Assistant', 'Student'].include? current_role_name

end
</pre>
The action_allow? method now provides access to modify a rubric to those instructors who own the rubric or the Teaching Assistants who work under them. However, any user can view the contents of the review rubric.
<pre>
# Source code after implementation.
def action_allowed?

case params[:action]
when 'edit', 'update', 'delete', 'toggle_access'
#Modifications can only be done by papertrail
q= Questionnaire.find_by(id:params[:id])
owner_inst_id = q.instructor_id
if(current_user.role_id==6) #Identifying if the current user is a Teaching Assistant
current_ta = current_user;
end
b= (current_user.id == owner_inst_id)
if(!current_ta.nil?)
b = b or (current_ta.parent_id == owner_inst_id)
end
return b

else
#Allow all others
['Super-Administrator',
'Administrator',
'Instructor',
'Teaching Assistant',
'Student'].include? current_role_name
end

end
</pre>
2.
a. Modification of import method declared in the questionnaires controller.

The code initially was not using the read method to read the file data and was unable to import a file.
<pre>
#Source code before implementation
def import
@questionnaire = Questionnaire.find(params[:id])
file = params['csv']
@questionnaire.questions << QuestionnaireHelper.get_questions_from_csv(@questionnaire, file)
end
</pre>
The modified code now reads data from the file and calls the method get_questions_from_csv and passes the data to it. The method reads data in rows and saves each row as a question. It then saves each question.
<pre>
#Source code after implementation
def import

questionnaire_id = (params[:id])
begin
file_data = File.read(params[:csv])
QuestionnaireHelper.get_questions_from_csv(file_data,params[:id])
#Questionnaire.import(file_data)

redirect_to edit_questionnaire_path(questionnaire_id.to_sym), notice: "All questions have been successfully imported!"
rescue
redirect_to edit_questionnaire_path(questionnaire_id.to_sym), notice: $ERROR_INFO
end
end
</pre>

b. Removing unwanted code and modifying the get_questions_from_csv method declared in the questionnaire controller.

The method get_questions_from_csv defined in the questionnaire helper was unable to read data from the file.
<pre>
#Source code before implementation
def self.get_questions_from_csv(questionnaire, file)
questions = []
custom_rubric = questionnaire.section == "Custom"
CSV::Reader.parse(file) do |row|
unless row.empty?
i = 0
score = questionnaire.max_question_score
q = Question.new
q_type = QuestionType.new if custom_rubric
q.true_false = false
row.each do |cell|
case i
when CSV_QUESTION
q.txt = cell.strip unless cell.nil?
when CSV_TYPE
unless cell.nil?
q.true_false = cell.downcase.strip == Question::TRUE_FALSE.downcase
q_type.q_type = cell.strip if custom_rubric
end
when CSV_PARAM
if custom_rubric
q_type.parameters = cell.strip if cell
end
when CSV_WEIGHT
q.weight = cell.strip.to_i if cell
else
if score >= questionnaire.min_question_score and !cell.nil?
a = QuestionAdvice.new(score: score, advice: cell.strip) if custom_rubric
a = QuestionAdvice.new(score: questionnaire.min_question_score + i - 4, advice: cell.strip)
score -= 1
q.question_advices << a
end
end
i += 1
end
q.save
q_type.question = q if custom_rubric
q_type.save if custom_rubric
questions << q
end
end
questions
end
</pre>
The unwanted code from the get_questions_from_csv method is now removed and the modified code successfully reads data from the csv file and saves questions present in the from of rows in the rubric.
<pre>
#Source code after implementation
def self.get_questions_from_csv(file_data,id)
CSV.parse(file_data, headers: true) do |row|
# row.each do |cell|
questions_hash = row.to_hash
ques = Question.new(questions_hash)
ques.questionnaire_id=id
ques.save
end # end CSV.parse
end
</pre>
3. Removing dysfunctional code from the QuestionnaireHelper and adding a new method in questionnaire.rb model

The create_questionnaire_csv method was not functional and was removed from the QuestionnaireHelper
<pre>
def self.create_questionnaire_csv(questionnaire, _user_name)
csv_data = CSV.generate do |csv|
for question in questionnaire.questions
# Each row is formatted as follows
# Question, question advice (from high score to low), type, weight
row = []
row << question.txt
row << question.type
row << question.alternatives || ''
row << question.size || ''
row << question.weight

# loop through all the question advice from highest score to lowest score
adjust_advice_size(questionnaire, question)
for advice in question.question_advices.sort {|x, y| y.score <=> x.score }
row << advice.advice
end

csv << row
end
end

csv_data
end
</pre>
The to_csv function was added in the questionnaire.rb model class which generates a CSV out of the data in the question table which can then be exported to a local machine.
<pre>
def to_csv(ques)
questions = ques
csv_data = CSV.generate do |csv|
row = ['seq','txt','type','weight','size','max_label','min_label','alternatives']
csv << row
for question in questions
row = []
row << question.seq
row << question.txt
row << question.type
row << question.weight
row << question.size || ''
row << question.max_label
row << question.min_label
row << question.alternatives

csv << row

end
end
end

</pre>

===Testing using RSpec===

A set of feature tests using the RSpec framework have been added to test the implemented functionalities. Test data from spec/features/import_export_csv_oss/ was used to run the test cases.

1. The file to be uploaded should not be an empty file. The following test case checks if the imported file is empty.
<pre>
describe 'Import questions from CSV' do

it 'should not be an empty file', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot.csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).not_to have_content('No such file')
end
</pre>

2.The following test case validates an imported CSV file. The test case passes if all the questions get successfully imported.
<pre>
it 'should be a valid CSV file', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot.csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).to have_content('All questions have been successfully imported!')

end
</pre>

3. The following test case validates the names of all columns in the imported CSV file. The following example shows that this test case passes when there's an error in the column name of the imported file. If we change this test file with the one in the above two cases, and change expect().to to expect().not_to, we can see that it does exactly what we require it to.
<pre>
it 'should have valid column names', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot (propername).csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).to have_content('unknown attribute')
end
</pre>

===Testing on UI===
====To Test only if an Instructor who owns the rubric or his TA can edit the rubric====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6 (This can be found out from the expertiza_development database using query: select name from questionnaires where instructor_id=6;)
#User should be redirected to a page where he can edit the questionnaire
#Impersonate 'teaching_assistant520' (is a TA under instructor6) and repeat steps 2-5
#User should be redirected to a page where he can edit the questionnaire
#Repeat the above steps for a questionnaire which is not owned by the instructor
#An error message is displayed above the 'Manage Content' title

====To Test if a user is able to Import/Export CSV files====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on 'Browse' button under 'Import/Export (from/to CSV format)' and select a file of CSV format which contains the questions
#Click on 'Import from CSV' button. The questions in the files should be saved into the questionnaire
#Click on 'Export questions to CSV'. The questions should be saved to the local system in a file of CSV format

====To test if a user is able to edit advice for a questionnaire====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content.
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on edit advice button. This should redirect to a page containing the advice for that questionnaire

====To test if a user is able to save edited advice for a questionnaire====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content
#Click on any one of the Review tab (For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on 'save and redisplay' button. This should reload the same page with the edited advice

CSC/ECE 517 Fall 2016/E1653. Fix and improve rubric criteria

2016-10-31T21:20:37Z

Nsingh9: /* References */

==E1653. Fix and Improve Rubric Criteria==

__TOC__

===Expertiza background===

[http://expertiza.ncsu.edu/ Expertiza] is an open source web application based on [http://rubyonrails.org/ Ruby on Rails] framework. This application facilitates submission and peer review of assignments and team projects. Students can upload their assignments and URLs linked to their work on expertiza which can be reviewed by the instructor and peer reviewed by other students. Expertiza also expedites the process of selecting/assigning topics and choosing team mates for team projects. Instructors can also create and customize assignments for students and create review rubrics which are used by students for peer reviewing others' work.

===Tasks identified===
* Change allow_action? method of questionnaires controller to restrict unauthorized access to edit review rubrics. Only those Instructors who own the rubric or their Teaching Assistants should be allowed edit them.
* Display an error message when a user who is not the owner of a questionnaire attempts to edit it and redirect him back to the page he came from.
*Fix the working of import and export methods(dumping and loading criterion) in the Questionnaire controller.
*Perform feature testing for the import and export methods of questionnaire controller.
*Remove old and unused code related to rubric import and export.
*Write feature tests for criterion advice.

===Modified/Created files===
*questionnaires_controller.rb
*QuestionnaireHelper.rb
*Questionnaire.rb
*questionnaire_spec.rb
*spec/features/import_export_csv_oss/ (New folder created containing 3 test files)

===Summary of implementation===
====New functionality====
* An instructor can no longer change others' review rubrics but can only view them. If he attempts to do so, an error message will be displayed and he will be redirected back.
* Only those review rubrics can be modified by an instructor which are owned by him.
* A Teaching Assistant can modify only those review rubrics which are owned by the instructor under whom he works.
* A CSV file containing the questions with the correct column names can now be imported into the rubric.
* A rubric can also be exported in CSV format to a destination path on our local system.

====Changes in source code====
1. Changes in allow_action? method of the Questionnaires controller.

The action_allow? method earlier provided access to all users to modify or view any review rubric.
<pre>
# Source code before implementation.
def action_allowed?

['Super-Administrator',
'Administrator',
'Instructor',
'Teaching Assistant', 'Student'].include? current_role_name

end
</pre>
The action_allow? method now provides access to modify a rubric to those instructors who own the rubric or the Teaching Assistants who work under them. However, any user can view the contents of the review rubric.
<pre>
# Source code after implementation.
def action_allowed?

case params[:action]
when 'edit', 'update', 'delete', 'toggle_access'
#Modifications can only be done by papertrail
q= Questionnaire.find_by(id:params[:id])
owner_inst_id = q.instructor_id
if(current_user.role_id==6) #Identifying if the current user is a Teaching Assistant
current_ta = current_user;
end
b= (current_user.id == owner_inst_id)
if(!current_ta.nil?)
b = b or (current_ta.parent_id == owner_inst_id)
end
return b

else
#Allow all others
['Super-Administrator',
'Administrator',
'Instructor',
'Teaching Assistant',
'Student'].include? current_role_name
end

end
</pre>
2.
a. Modification of import method declared in the questionnaires controller.

The code initially was not using the read method to read the file data and was unable to import a file.
<pre>
#Source code before implementation
def import
@questionnaire = Questionnaire.find(params[:id])
file = params['csv']
@questionnaire.questions << QuestionnaireHelper.get_questions_from_csv(@questionnaire, file)
end
</pre>
The modified code now reads data from the file and calls the method get_questions_from_csv and passes the data to it. The method reads data in rows and saves each row as a question. It then saves each question.
<pre>
#Source code after implementation
def import

questionnaire_id = (params[:id])
begin
file_data = File.read(params[:csv])
QuestionnaireHelper.get_questions_from_csv(file_data,params[:id])
#Questionnaire.import(file_data)

redirect_to edit_questionnaire_path(questionnaire_id.to_sym), notice: "All questions have been successfully imported!"
rescue
redirect_to edit_questionnaire_path(questionnaire_id.to_sym), notice: $ERROR_INFO
end
end
</pre>

b. Removing unwanted code and modifying the get_questions_from_csv method declared in the questionnaire controller.

The method get_questions_from_csv defined in the questionnaire helper was unable to read data from the file.
<pre>
#Source code before implementation
def self.get_questions_from_csv(questionnaire, file)
questions = []
custom_rubric = questionnaire.section == "Custom"
CSV::Reader.parse(file) do |row|
unless row.empty?
i = 0
score = questionnaire.max_question_score
q = Question.new
q_type = QuestionType.new if custom_rubric
q.true_false = false
row.each do |cell|
case i
when CSV_QUESTION
q.txt = cell.strip unless cell.nil?
when CSV_TYPE
unless cell.nil?
q.true_false = cell.downcase.strip == Question::TRUE_FALSE.downcase
q_type.q_type = cell.strip if custom_rubric
end
when CSV_PARAM
if custom_rubric
q_type.parameters = cell.strip if cell
end
when CSV_WEIGHT
q.weight = cell.strip.to_i if cell
else
if score >= questionnaire.min_question_score and !cell.nil?
a = QuestionAdvice.new(score: score, advice: cell.strip) if custom_rubric
a = QuestionAdvice.new(score: questionnaire.min_question_score + i - 4, advice: cell.strip)
score -= 1
q.question_advices << a
end
end
i += 1
end
q.save
q_type.question = q if custom_rubric
q_type.save if custom_rubric
questions << q
end
end
questions
end
</pre>
The unwanted code from the get_questions_from_csv method is now removed and the modified code successfully reads data from the csv file and saves questions present in the from of rows in the rubric.
<pre>
#Source code after implementation
def self.get_questions_from_csv(file_data,id)
CSV.parse(file_data, headers: true) do |row|
# row.each do |cell|
questions_hash = row.to_hash
ques = Question.new(questions_hash)
ques.questionnaire_id=id
ques.save
end # end CSV.parse
end
</pre>
3. Removing dysfunctional code from the QuestionnaireHelper and adding a new method in questionnaire.rb model

The create_questionnaire_csv method was not functional and was removed from the QuestionnaireHelper
<pre>
def self.create_questionnaire_csv(questionnaire, _user_name)
csv_data = CSV.generate do |csv|
for question in questionnaire.questions
# Each row is formatted as follows
# Question, question advice (from high score to low), type, weight
row = []
row << question.txt
row << question.type
row << question.alternatives || ''
row << question.size || ''
row << question.weight

# loop through all the question advice from highest score to lowest score
adjust_advice_size(questionnaire, question)
for advice in question.question_advices.sort {|x, y| y.score <=> x.score }
row << advice.advice
end

csv << row
end
end

csv_data
end
</pre>
The to_csv function was added in the questionnaire.rb model class which generates a CSV out of the data in the question table which can then be exported to a local machine.
<pre>
def to_csv(ques)
questions = ques
csv_data = CSV.generate do |csv|
row = ['seq','txt','type','weight','size','max_label','min_label','alternatives']
csv << row
for question in questions
row = []
row << question.seq
row << question.txt
row << question.type
row << question.weight
row << question.size || ''
row << question.max_label
row << question.min_label
row << question.alternatives

csv << row

end
end
end

</pre>

===Testing using RSpec===

A set of feature tests using the RSpec framework have been added to test the implemented functionalities. Test data from spec/features/import_export_csv_oss/ was used to run the test cases.

1. The file to be uploaded should not be an empty file. The following test case checks if the imported file is empty.
<pre>
describe 'Import questions from CSV' do

it 'should not be an empty file', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot.csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).not_to have_content('No such file')
end
</pre>

2.The following test case validates an imported CSV file. The test case passes if all the questions get successfully imported.
<pre>
it 'should be a valid CSV file', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot.csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).to have_content('All questions have been successfully imported!')

end
</pre>

3. The following test case validates the names of all columns in the imported CSV file. The following example shows that this test case passes when there's an error in the column name of the imported file. If we change this test file with the one in the above two cases, and change expect().to to expect().not_to, we can see that it does exactly what we require it to.
<pre>
it 'should have valid column names', js: true do
login_as("instructor6")
visit '/questionnaires/1/edit'
file_path=Rails.root+"spec/features/import_export_csv_oss/navjot (propername).csv"
attach_file('csv',file_path)
click_button "Import from CSV"
expect(page).to have_content('unknown attribute')
end
</pre>

===Testing on UI===
====To Test only if an Instructor who owns the rubric or his TA can edit the rubric====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content.]
#Click on any one of the Review tab(For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6 (This can be found out from the expertiza_development database using query: select name from questionnaires where instructor_id=6;)
#User should be redirected to a page where he can edit the questionnaire.
#Impersonate 'teaching_assistant520'(is a TA under instructor6) and repeat steps 2-5.
#User should be redirected to a page where he can edit the questionnaire.
#Repeat the above steps for a questionnaire which is not owned by the instructor.
#An error message is displayed above the 'Manage Content' title.

====To Test if a user is able to Import/Export CSV files====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content.]
#Click on any one of the Review tab(For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on 'Browse' button under 'Import/Export (from/to CSV format)' and select a file of CSV format which contains the questions.
#Click on 'Import from CSV' button. The questions in the files should be saved into the questionnaire.
#Click on 'Export questions to CSV'. The questions should be saved to the local system in a file of CSV format.

====To test if a user is able to edit advice for a questionnaire====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content.]
#Click on any one of the Review tab(For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on edit advice button. This should redirect to a page containing the advice for that questionnaire.

====To test if a user is able to save edited advice for a questionnaire====
#Login to expertiza as 'instructor6' (Username: instructor6 Password:password)
#Select 'Questionnaire' Tab under Manage Content.]
#Click on any one of the Review tab(For eg: Review, Metareview, Author Feedback)
#Click on edit button of a questionnaire which is owned by instructor6
#Click on 'save and redisplay' button. This should reload the same page with the edited advice.

CSC/ECE 517 Fall 2016/E1653. Fix and improve rubric criteria

2016-10-29T04:30:21Z

Nsingh9: /* Testing using RSpec */

CSC/ECE 517 Fall 2016/E1653. Fix and improve rubric criteria

2016-10-29T04:14:14Z

Nsingh9: /* Changes in source code */

CSC/ECE 517 Fall 2016/E1653. Fix and improve rubric criteria

2016-10-29T04:05:30Z

Nsingh9: /* Changes in source code */

CSC/ECE 517 Fall 2016/E1653. Fix and improve rubric criteria

2016-10-29T04:02:04Z

Nsingh9: /* New functionality */

CSC/ECE 517 Fall 2016/E1653. Fix and improve rubric criteria

2016-10-29T03:58:07Z

Nsingh9: /* Tasks identified */

CSC/ECE 517 Fall 2016

2016-10-28T14:41:09Z

Nsingh9: /* Writing Assignments 2 */